From 0cef9216d58118afb67a20fbbb9450f64ba3e28a Mon Sep 17 00:00:00 2001
From: deltanedas <39013340+deltanedas@users.noreply.github.com>
Date: Wed, 16 Apr 2025 19:12:13 +0100
Subject: [PATCH] aac tablet cleanup (#3483)

* localized AAC tablet window

* no writing novels

* gleep

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
---
 Content.Client/_DV/AACTablet/UI/AACWindow.xaml    | 8 ++++----
 Content.Client/_DV/AACTablet/UI/AACWindow.xaml.cs | 7 +++++++
 Content.Server/_DV/AACTablet/AACTabletSystem.cs   | 4 +++-
 Resources/Locale/en-US/_DV/ui/aac-tablet.ftl      | 4 ++++
 4 files changed, 18 insertions(+), 5 deletions(-)
 create mode 100644 Resources/Locale/en-US/_DV/ui/aac-tablet.ftl

diff --git a/Content.Client/_DV/AACTablet/UI/AACWindow.xaml b/Content.Client/_DV/AACTablet/UI/AACWindow.xaml
index d23e7b1676..777edca5de 100644
--- a/Content.Client/_DV/AACTablet/UI/AACWindow.xaml
+++ b/Content.Client/_DV/AACTablet/UI/AACWindow.xaml
@@ -1,15 +1,15 @@
 <controls:FancyWindow xmlns="https://spacestation14.io"
     xmlns:controls="clr-namespace:Content.Client.UserInterface.Controls"
-    Title="AAC Tablet"
+    Title="acc-tablet-title"
     Resizable="True"
     SetSize="540 300"
     MinSize="540 300">
     <BoxContainer Orientation="Vertical">
         <BoxContainer Orientation="Horizontal" HorizontalExpand="True">
-            <CheckBox Name="ShouldBuffer" Text="Combine"/>
+            <CheckBox Name="ShouldBuffer" Text="aac-tablet-combine"/>
             <LineEdit Name="BufferedString" Editable="False" HorizontalExpand="True"/>
-            <Button Name="ClearButton" Text="Backspace" TextAlign="Center"/>
-            <Button Name="SendButton" Text="Send" TextAlign="Center"/>
+            <Button Name="ClearButton" Text="aac-tablet-backspace" TextAlign="Center"/>
+            <Button Name="SendButton" Text="aac-tablet-send" TextAlign="Center"/>
         </BoxContainer>
         <TabContainer Name="WindowBody" TabTitle="Search" VerticalExpand="True" MouseFilter="Pass">
             <BoxContainer Orientation="Vertical" Name="Search" MinSize="540 200">
diff --git a/Content.Client/_DV/AACTablet/UI/AACWindow.xaml.cs b/Content.Client/_DV/AACTablet/UI/AACWindow.xaml.cs
index 1690f173e0..2b425a301b 100644
--- a/Content.Client/_DV/AACTablet/UI/AACWindow.xaml.cs
+++ b/Content.Client/_DV/AACTablet/UI/AACWindow.xaml.cs
@@ -25,6 +25,8 @@ public sealed partial class AACWindow : FancyWindow
     private const int ButtonWidth =
         (int)((ParentWidth - SpaceWidth * 2) / ColumnCount - SpaceWidth * ((ColumnCount - 1f) / ColumnCount));
 
+    public const int MaxPhrases = 10; // no writing novels
+
     private readonly List<ProtoId<QuickPhrasePrototype>> _phraseBuffer = [];
     private readonly List<ProtoId<QuickPhrasePrototype>> _phraseSingle = [];
 
@@ -32,6 +34,7 @@ public sealed partial class AACWindow : FancyWindow
     {
         RobustXamlLoader.Load(this);
         IoCManager.InjectDependencies(this);
+
         _phrases = _prototype.EnumeratePrototypes<QuickPhrasePrototype>().ToList();
         _phrases.Sort((a, b) => string.CompareOrdinal(a.Group, b.Group));
         SearchBar.OnTextChanged += FilterSearch;
@@ -217,6 +220,10 @@ public sealed partial class AACWindow : FancyWindow
     {
         if (ShouldBuffer.Pressed)
         {
+            // there's no user feedback but you shouldn't be writing novels anyway
+            if (_phraseBuffer.Count >= MaxPhrases)
+                return;
+
             _phraseBuffer.Add(phraseId);
             UpdateBufferText();
         }
diff --git a/Content.Server/_DV/AACTablet/AACTabletSystem.cs b/Content.Server/_DV/AACTablet/AACTabletSystem.cs
index d8a00fa1eb..4303810a8e 100644
--- a/Content.Server/_DV/AACTablet/AACTabletSystem.cs
+++ b/Content.Server/_DV/AACTablet/AACTabletSystem.cs
@@ -15,6 +15,8 @@ public sealed class AACTabletSystem : EntitySystem
 
     private readonly List<string> _localisedPhrases = [];
 
+    public const int MaxPhrases = 10; // no writing novels
+
     public override void Initialize()
     {
         base.Initialize();
@@ -23,7 +25,7 @@ public sealed class AACTabletSystem : EntitySystem
 
     private void OnSendPhrase(Entity<AACTabletComponent> ent, ref AACTabletSendPhraseMessage message)
     {
-        if (ent.Comp.NextPhrase > _timing.CurTime)
+        if (ent.Comp.NextPhrase > _timing.CurTime || message.PhraseIds.Count > MaxPhrases)
             return;
 
         var senderName = Identity.Entity(message.Actor, EntityManager);
diff --git a/Resources/Locale/en-US/_DV/ui/aac-tablet.ftl b/Resources/Locale/en-US/_DV/ui/aac-tablet.ftl
new file mode 100644
index 0000000000..23c8ba98e8
--- /dev/null
+++ b/Resources/Locale/en-US/_DV/ui/aac-tablet.ftl
@@ -0,0 +1,4 @@
+aac-tablet-title = AAC Tablet
+aac-tablet-combine = Combine
+aac-tablet-backspace = Backspace
+aac-tablet-send = Send