From 42c6edacd48b3d73ca5f636be03f135bcc429d82 Mon Sep 17 00:00:00 2001 From: =?UTF-8?q?=C4=81da?= Date: Thu, 30 Oct 2025 19:09:44 -0500 Subject: [PATCH] Fix all ignored recipes in material arbitrage (#41134) * lights * drink glasses * vial chem bottle * plates n stuff * boards * airtank --------- Co-authored-by: iaada --- .../Tests/MaterialArbitrageTest.cs | 18 ++++-------------- .../Consumable/Food/Containers/plate.yml | 8 ++++---- .../Circuitboards/Machine/production.yml | 12 ++++++------ .../Prototypes/Recipes/Lathes/chemistry.yml | 6 +++--- .../Prototypes/Recipes/Lathes/cooking.yml | 2 +- Resources/Prototypes/Recipes/Lathes/misc.yml | 4 ++-- 6 files changed, 20 insertions(+), 30 deletions(-) diff --git a/Content.IntegrationTests/Tests/MaterialArbitrageTest.cs b/Content.IntegrationTests/Tests/MaterialArbitrageTest.cs index dcb47fb81c..3c6c372b75 100644 --- a/Content.IntegrationTests/Tests/MaterialArbitrageTest.cs +++ b/Content.IntegrationTests/Tests/MaterialArbitrageTest.cs @@ -28,20 +28,10 @@ namespace Content.IntegrationTests.Tests; [TestFixture] public sealed class MaterialArbitrageTest { - // These recipes are currently broken and need fixing. You should not be adding to these sets. - private readonly HashSet _destructionArbitrageIgnore = - [ - "BaseChemistryEmptyVial", "DrinkShotGlass", "SodiumLightTube", "DrinkGlassCoupeShaped", - "LedLightBulb", "ExteriorLightTube", "LightTube", "DrinkGlass", "DimLightBulb", "LightBulb", "LedLightTube", - "ChemistryEmptyBottle01", "WarmLightBulb", - ]; - - private readonly HashSet _compositionArbitrageIgnore = - [ - "FoodPlateSmall", "AirTank", "FoodPlateTin", "FoodPlateMuffinTin", "WeaponCapacitorRechargerCircuitboard", - "WeaponCapacitorRechargerCircuitboard", "BorgChargerCircuitboard", "BorgChargerCircuitboard", "FoodPlate", - "CellRechargerCircuitboard", "CellRechargerCircuitboard", - ]; + // These sets are for selectively excluding recipes from arbitrage. + // You should NOT be adding to these. They exist here for downstreams and potential future issues. + private readonly HashSet _destructionArbitrageIgnore = []; + private readonly HashSet _compositionArbitrageIgnore = []; [Test] public async Task NoMaterialArbitrage() diff --git a/Resources/Prototypes/Entities/Objects/Consumable/Food/Containers/plate.yml b/Resources/Prototypes/Entities/Objects/Consumable/Food/Containers/plate.yml index 55d22e3980..36dff3a8d6 100644 --- a/Resources/Prototypes/Entities/Objects/Consumable/Food/Containers/plate.yml +++ b/Resources/Prototypes/Entities/Objects/Consumable/Food/Containers/plate.yml @@ -57,7 +57,7 @@ - Trash - type: PhysicalComposition materialComposition: - Glass: 60 + Glass: 50 - type: SpaceGarbage - type: entity @@ -117,7 +117,7 @@ acts: [ "Destruction" ] - type: PhysicalComposition materialComposition: - Glass: 30 + Glass: 25 - type: entity parent: FoodPlateTrash @@ -196,7 +196,7 @@ - Trash - type: PhysicalComposition materialComposition: - Steel: 60 + Steel: 50 - type: SpaceGarbage # Muffin Tin @@ -220,5 +220,5 @@ - Trash - type: PhysicalComposition materialComposition: - Steel: 30 + Steel: 25 - type: SpaceGarbage diff --git a/Resources/Prototypes/Entities/Objects/Devices/Circuitboards/Machine/production.yml b/Resources/Prototypes/Entities/Objects/Devices/Circuitboards/Machine/production.yml index 818cf3f77e..22e74f2ba5 100644 --- a/Resources/Prototypes/Entities/Objects/Devices/Circuitboards/Machine/production.yml +++ b/Resources/Prototypes/Entities/Objects/Devices/Circuitboards/Machine/production.yml @@ -687,8 +687,8 @@ Cable: 5 - type: PhysicalComposition materialComposition: - Steel: 30 - Plastic: 30 + Steel: 25 + Plastic: 25 - type: StaticPrice price: 15 - type: Tag # DeltaV - augment construction @@ -732,8 +732,8 @@ Cable: 5 - type: PhysicalComposition materialComposition: - Steel: 30 - Plastic: 30 + Steel: 25 + Plastic: 25 - type: StaticPrice price: 15 - type: Tag # DeltaV - augment construction @@ -755,8 +755,8 @@ CableMV: 5 - type: PhysicalComposition materialComposition: - Steel: 30 - Plastic: 30 + Steel: 25 + Plastic: 25 - type: StaticPrice price: 15 diff --git a/Resources/Prototypes/Recipes/Lathes/chemistry.yml b/Resources/Prototypes/Recipes/Lathes/chemistry.yml index 9e2d79e848..93ae4bd90e 100644 --- a/Resources/Prototypes/Recipes/Lathes/chemistry.yml +++ b/Resources/Prototypes/Recipes/Lathes/chemistry.yml @@ -79,7 +79,7 @@ result: ChemistryEmptyBottle01 completetime: 2 materials: - Glass: 50 + Glass: 100 # - type: latheRecipe # DeltaV - Disable the Vape # id: Vape @@ -97,8 +97,8 @@ result: BaseChemistryEmptyVial completetime: 2 materials: - Glass: 50 - #Wood: 20 # DeltaV - chemists shouldn't have to loot maints + Glass: 100 + # Wood: 20 # DeltaV - Why wood? Because of the cork? That's dumb. - type: latheRecipe id: ClothingEyesGlassesChemical diff --git a/Resources/Prototypes/Recipes/Lathes/cooking.yml b/Resources/Prototypes/Recipes/Lathes/cooking.yml index 333279a820..e3081437c4 100644 --- a/Resources/Prototypes/Recipes/Lathes/cooking.yml +++ b/Resources/Prototypes/Recipes/Lathes/cooking.yml @@ -19,7 +19,7 @@ id: BaseGlasswareRecipe completetime: 0.8 materials: - Glass: 100 + Glass: 200 - type: latheRecipe parent: BaseGlasswareRecipe diff --git a/Resources/Prototypes/Recipes/Lathes/misc.yml b/Resources/Prototypes/Recipes/Lathes/misc.yml index 9d93c2d7d1..6741354705 100644 --- a/Resources/Prototypes/Recipes/Lathes/misc.yml +++ b/Resources/Prototypes/Recipes/Lathes/misc.yml @@ -8,7 +8,7 @@ completetime: 2 materials: Steel: 50 - Glass: 50 + Glass: 200 # Recipes @@ -120,7 +120,7 @@ result: AirTank completetime: 4 materials: - Steel: 300 + Steel: 400 - type: latheRecipe id: DoubleEmergencyOxygenTank