fix solution contents duplication on spill behavior (#33231)

* I’M SCREAMING INTO THE VOID AND IT’S NOT LISTENING

* review

* explodes pancakes with mind

* graaaaaaaaaaaaaaaaaaaaaaaaaaaaaaaa

* Meteors RAAAAAAAAAAH

* I'm so tired of solutions

* whhop

* revert

---------

Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
This commit is contained in:
Milon
2026-01-26 19:25:32 +01:00
committed by BarryNorfolk
co-authored by Princess Cheeseballs
parent 3a96154bca
commit 857ddff7cb
6 changed files with 69 additions and 56 deletions
+11 -2
View File
@@ -354,6 +354,15 @@ public abstract partial class SharedPuddleSystem : EntitySystem
}
#region Spill
/// <inheritdoc cref="TrySplashSpillAt(EntityUid,EntityCoordinates,Solution,out EntityUid,bool,EntityUid?)"/>
public abstract bool TrySplashSpillAt(Entity<SpillableComponent?> entity,
EntityCoordinates coordinates,
out EntityUid puddleUid,
out Solution spilled,
bool sound = true,
EntityUid? user = null);
// These methods are in Shared to make it easier to interact with PuddleSystem in Shared code.
// Note that they always fail when run on the client, not creating a puddle and returning false.
// Adding proper prediction to this system would require spawning temporary puddle entities on the
@@ -367,9 +376,9 @@ public abstract partial class SharedPuddleSystem : EntitySystem
/// <remarks>
/// On the client, this will always set <paramref name="puddleUid"/> to <see cref="EntityUid.Invalid"/> and return false.
/// </remarks>
public abstract bool TrySplashSpillAt(EntityUid uid,
public abstract bool TrySplashSpillAt(EntityUid entity,
EntityCoordinates coordinates,
Solution solution,
Solution spilled,
out EntityUid puddleUid,
bool sound = true,
EntityUid? user = null);