cmdrunematti
/
Delta-v
mirror of https://github.com/DeltaV-Station/Delta-v.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity

Reactions test cleanup. (#42979) 

* Make TryAllReactionsTest use a scrounged reagent list.

* naming

* Poke
This commit is contained in:
Moony 2026-03-10 20:56:30 +01:00 committed by Coryler
parent 35177173e2
commit b26a9735aa
1 changed files with 74 additions and 55 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

129
Content.IntegrationTests/Tests/Chemistry/TryAllReactionsTest.cs
View File

@ -5,6 +5,7 @@ using Robust.Shared.Map;
using Robust.Shared.Prototypes;
using Robust.Shared.Utility;
using System.Linq;
using Content.IntegrationTests.Utility;
using Content.Shared.Chemistry.EntitySystems;
namespace Content.IntegrationTests.Tests.Chemistry
@ -24,8 +25,13 @@ namespace Content.IntegrationTests.Tests.Chemistry
maxVol: 50
canMix: true";
private static string[] _reactions = GameDataScrounger.PrototypesOfKind<ReactionPrototype>();
[Test]
public async Task TryAllTest()
[TestCaseSource(nameof(_reactions))]
[TestOf(typeof(ReactionPrototype))]
[Description("Tries an individual reaction to see if it succeeds.")]
public async Task TryReaction(string reaction)
{
await using var pair = await PoolManager.GetServerClient();
var server = pair.Server;
@ -36,87 +42,100 @@ namespace Content.IntegrationTests.Tests.Chemistry
var coordinates = testMap.GridCoords;
var solutionContainerSystem = entityManager.System<SharedSolutionContainerSystem>();
foreach (var reactionPrototype in prototypeManager.EnumeratePrototypes<ReactionPrototype>())
{
//since i have no clue how to isolate each loop assert-wise im just gonna throw this one in for good measure
Console.WriteLine($"Testing {reactionPrototype.ID}");
var reactionPrototype = prototypeManager.Index<ReactionPrototype>(reaction);
EntityUid beaker = default;
Entity<SolutionComponent>? solutionEnt = default!;
Solution solution = null;
EntityUid beaker = default;
Solution solution = null;
Entity<SolutionComponent>? solutionEnt = default!;
await server.WaitAssertion(() =>
{
beaker = entityManager.SpawnEntity("TestSolutionContainer", coordinates);
Assert.That(solutionContainerSystem
.TryGetSolution(beaker, "beaker", out solutionEnt, out solution));
solutionContainerSystem.SetCanReact(solutionEnt.Value, false);
solutionContainerSystem.SetCanReact(solutionEnt!.Value, false);
foreach (var (id, reactant) in reactionPrototype.Reactants)
{
#pragma warning disable NUnit2045
Assert.That(solutionContainerSystem
.TryAddReagent(solutionEnt.Value, id, reactant.Amount, out var quantity, reactionPrototype.MinimumTemperature));
Assert.That(reactant.Amount, Is.EqualTo(quantity));
Assert.That(solutionContainerSystem
.TryAddReagent(solutionEnt.Value,
id,
reactant.Amount,
out var quantity,
reactionPrototype.MinimumTemperature));
Assert.That(reactant.Amount, Is.EqualTo(quantity));
#pragma warning restore NUnit2045
}
}
//Get all possible reactions with the current reagents
var possibleReactions = prototypeManager.EnumeratePrototypes<ReactionPrototype>()
.Where(x => x.Reactants.All(id => solution.Contents.Any(s => s.Reagent.Prototype == id.Key)))
.ToList();
//Get all possible reactions with the current reagents
var possibleReactions = prototypeManager.EnumeratePrototypes<ReactionPrototype>()
.Where(x => x.Reactants.All(id => solution.Contents.Any(s => s.Reagent.Prototype == id.Key)))
.ToList();
//Check if the reaction is the first to occur when heated
foreach (var possibleReaction in possibleReactions.OrderBy(r => r.MinimumTemperature))
//Check if the reaction is the first to occur when heated
foreach (var possibleReaction in possibleReactions.OrderBy(r => r.MinimumTemperature))
{
if (possibleReaction.Priority >= reactionPrototype.Priority &&
possibleReaction.MinimumTemperature < reactionPrototype.MinimumTemperature &&
possibleReaction.MixingCategories == reactionPrototype.MixingCategories)
{
if (possibleReaction.Priority >= reactionPrototype.Priority && possibleReaction.MinimumTemperature < reactionPrototype.MinimumTemperature && possibleReaction.MixingCategories == reactionPrototype.MixingCategories)
{
Assert.Fail($"The {possibleReaction.ID} reaction may occur before {reactionPrototype.ID} when heated.");
}
Assert.Fail(
$"The {possibleReaction.ID} reaction may occur before {reactionPrototype.ID} when heated.");
}
}
//Check if the reaction is the first to occur when freezing
foreach (var possibleReaction in possibleReactions.OrderBy(r => r.MaximumTemperature))
//Check if the reaction is the first to occur when freezing
foreach (var possibleReaction in possibleReactions.OrderBy(r => r.MaximumTemperature))
{
if (possibleReaction.Priority >= reactionPrototype.Priority &&
possibleReaction.MaximumTemperature > reactionPrototype.MaximumTemperature &&
possibleReaction.MixingCategories == reactionPrototype.MixingCategories)
{
if (possibleReaction.Priority >= reactionPrototype.Priority && possibleReaction.MaximumTemperature > reactionPrototype.MaximumTemperature && possibleReaction.MixingCategories == reactionPrototype.MixingCategories)
{
Assert.Fail($"The {possibleReaction.ID} reaction may occur before {reactionPrototype.ID} when freezing.");
}
Assert.Fail(
$"The {possibleReaction.ID} reaction may occur before {reactionPrototype.ID} when freezing.");
}
}
//Now safe set the temperature and mix the reagents
solutionContainerSystem.SetTemperature(solutionEnt.Value, reactionPrototype.MinimumTemperature);
solutionContainerSystem.SetCanReact(solutionEnt.Value, true);
if (reactionPrototype.MixingCategories != null)
{
var dummyEntity = entityManager.SpawnEntity(null, MapCoordinates.Nullspace);
var mixerComponent = entityManager.AddComponent<ReactionMixerComponent>(dummyEntity);
mixerComponent.ReactionTypes = reactionPrototype.MixingCategories;
solutionContainerSystem.UpdateChemicals(solutionEnt.Value, true, mixerComponent);
}
});
await server.WaitIdleAsync();
await server.WaitAssertion(() =>
if (reactionPrototype.MixingCategories != null)
{
//you just got linq'd fool
//(i'm sorry)
var foundProductsMap = reactionPrototype.Products
.Concat(reactionPrototype.Reactants.Where(x => x.Value.Catalyst).ToDictionary(x => x.Key, x => x.Value.Amount))
.ToDictionary(x => x, _ => false);
foreach (var (reagent, quantity) in solution.Contents)
{
Assert.That(foundProductsMap.TryFirstOrNull(x => x.Key.Key == reagent.Prototype && x.Key.Value == quantity, out var foundProduct));
foundProductsMap[foundProduct.Value.Key] = true;
}
var dummyEntity = entityManager.SpawnEntity(null, MapCoordinates.Nullspace);
var mixerComponent = entityManager.AddComponent<ReactionMixerComponent>(dummyEntity);
mixerComponent.ReactionTypes = reactionPrototype.MixingCategories;
solutionContainerSystem.UpdateChemicals(solutionEnt.Value, true, mixerComponent);
}
});
Assert.That(foundProductsMap.All(x => x.Value));
});
await server.WaitIdleAsync();
await server.WaitAssertion(() =>
{
//you just got linq'd fool
//(i'm sorry)
var foundProductsMap = reactionPrototype.Products
.Concat(reactionPrototype.Reactants
.Where(x => x.Value.Catalyst)
.ToDictionary(x => x.Key, x => x.Value.Amount)
)
.ToDictionary(x => x, _ => false);
foreach (var (reagent, quantity) in solution.Contents)
{
Assert.That(foundProductsMap.TryFirstOrNull(
x => x.Key.Key == reagent.Prototype && x.Key.Value == quantity,
out var foundProduct));
foundProductsMap[foundProduct!.Value.Key] = true;
}
Assert.That(foundProductsMap.All(x => x.Value));
server.EntMan.DeleteEntity(beaker);
});
}
await pair.CleanReturnAsync();
}
}
}