Commit Graph

4487 Commits

Author SHA1 Message Date
Leon Friedrich 4ce7efd04d
Prevent Identity.Name NRE exception (#28433)
Fix Identity.Name exception
2024-06-01 17:56:36 +02:00
Leon Friedrich 65a712700c
Only auto-enable internals when necessary (#28248)
* Only auto-enable internals when necessary

* Add toxic gas check

* Rename Any -> AnyPositive
2024-06-01 17:55:05 +02:00
ShadowCommander 1338c4a059
Fix TryGetActionData error triggering when run on deleting entities (#27839)
* Fix TryGetActionData error triggering when run on deleting entities

* Only get metadata once
2024-06-01 17:54:46 +02:00
Tayrtahn 2a56896045
Convert advertisements to use localized datasets (#28400)
* Convert advertisements to use LocalizedDatasets

* File consolidation

* Arcade machines too
2024-06-01 17:41:58 +02:00
Tayrtahn a5d25c0550
Convert story generation to use LocalizedDatasets (#28402)
Converted story generation to use LocalizedDatasets
2024-06-01 17:41:55 +02:00
metalgearsloth 4755223c9f
Predict ActivatableUIRequiresPower (#28405)
A lot of BUIs aren't going to handle the state coming in cleanly but we can fix em as we find em.
2024-06-01 17:38:43 +02:00
ShadowCommander ebddaa8e3d
Move ApcPowerReceiverComponent Powered state to shared (#28206)
* Try syncing powered state to client

For some reason the client is not receiving the ApcPowerReceiverComponentState, so it's not working.

* Fix powered state not syncing to client

The client PowerReceiverSystem was abstract, which prevented it from
running initialize.

* Flip check so that it runs bigger checks first

PowerDisabled skips the others.
NeedsPower skips the receiving check.

* Disallow changing Powered manually

* Move Powered update to PowerReceiverSystem

* Move appearance to event subscription

* Move metadata component to AllEntityQuery

* Cleanup

* Move Powered update back to PowerNetSystem

It's easier to use the EntityQueries and it dosen't need to be updated
anywhere else.

* Put appearance updating back

* Move IsPowered to shared

* Simplify IsPowered

* Cleanup

* Remove duplicate PowerChangedEvent

PowerChangedEvent on ProviderChanged doesn't seem to be needed
PowerChangedEvent gets raised by in update if the power state changes
after a new provider is connected
2024-06-01 17:38:41 +02:00
deltanedas 819c173308
item cabinet rework + stuff (#26779) 2024-06-01 17:19:54 +02:00
ShadowCommander ec1696bc8e
Change PlaceableSurfaceSystem.cs to file scoped namespace (#28379) 2024-06-01 17:19:38 +02:00
metalgearsloth 4271fc5174
Fix single-user BUIs erroneously closing (#28375) 2024-06-01 17:19:37 +02:00
DrSmugleaf e1ce368229
Fix FixedPoint2.Abs multiplying the value by 100 (#28378) 2024-06-01 17:19:34 +02:00
Kevin Zheng a6e4fd4c7a
Tune spacing speed to fix under-pressure lockout (#28370) 2024-06-01 17:19:28 +02:00
Tayrtahn 0ffa4b1e55
Fix off-by-one error in LocalizedDatasetPrototype (#28366) 2024-06-01 17:19:24 +02:00
basic pack a1191c1150
Lowers restart round vote's minimum players dead percentage. (#27470) 2024-06-01 17:19:06 +02:00
Tayrtahn e718a3e714
Add LocalizedDatasetPrototype (#28310) 2024-06-01 17:19:04 +02:00
ShadowCommander adee8b16ab
Add pressure and temperature warning text to firelocks (#28341) 2024-06-01 17:17:54 +02:00
Nemanja 49ae1f57ee
Small anomaly behavior fix (#28290)
* Small anomaly behavior fix

* well put together code
2024-06-01 17:17:36 +02:00
slarticodefast d25743c22f
Cargo bounty corrections (#28255)
cargo bounty corrections
2024-06-01 17:17:29 +02:00
Nemanja ac98ee082e
fix mirror server crashes (#28318) 2024-06-01 17:13:44 +02:00
metalgearsloth 413889283c
Add loadout group check (#28311)
Forgot to add it back in one of the rewrites.
2024-06-01 17:13:44 +02:00
metalgearsloth b99a66afc1
Selectively revert PullController (#28126)
I am leaving the issues open and have updated #26547 with more info on what we should do long-term. This is just to bandaid the short-term complaining.
2024-06-01 17:13:38 +02:00
Nemanja 3d8706561d
fix borg ui mispredict opening (#28305)
move borg ui junk to shared
2024-06-01 17:13:35 +02:00
deltanedas 82b8d835b2
fix antag selection being evil (#28197)
* fix antag selection being evil

* fix test

* untroll the other tests

* remove role timer troll

* Allow tests to modify antag preferences

* Fix antag selection

* Misc test fixes

* Add AntagPreferenceTest

* Fix lazy mistakes

* Test cleanup

* Try stop players in lobbies from being assigned mid-round antags

* ranting

* I am going insane

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
Co-authored-by: ElectroJr <leonsfriedrich@gmail.com>
2024-06-01 17:13:27 +02:00
Nemanja 9a7f4416b2
actually fix magic mirrors (#28282) 2024-06-01 17:13:23 +02:00
Leon Friedrich 386728db2f
Fix stripping not marking interactions as handled (#28292) 2024-06-01 17:13:16 +02:00
Leon Friedrich 85b0e876e7
Fix storage UI interactions (#28291)
* Fix storage UI interactions

* Add VV support
2024-06-01 17:13:10 +02:00
Errant 5768c2a8d4
Changing hands unwields item (#28161)
Unhand me, fiend
2024-06-01 17:13:07 +02:00
DrSmugleaf 94375b73ce
Make it possible to hide full health bars below a total damage threshold (#28127)
* Make it possible to hide full health bars below a total damage threshold

* Fix not setting state
2024-06-01 17:00:25 +02:00
Ady4ik 78dbdfa00c
Move PendingZombieComponent to Shared (#28143)
* Move PendingZombieComponent to Shared

* network me boy

---------

Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
2024-06-01 17:00:22 +02:00
metalgearsloth 9e350a452c
Fix water postshader (#28130) 2024-06-01 17:00:16 +02:00
DrSmugleaf 8833e0b046
Fix not networking whitelist and blacklist in storage component (#28238) 2024-06-01 16:57:32 +02:00
Leon Friedrich 1942652d87
Fix weapon error logs (#28264) 2024-06-01 16:57:14 +02:00
nikthechampiongr a036d3a485
Fix firelock prediction issues with periodic pulses of closing lights (#28227)
* Fix firelock prediction issues with periodic pulses of closing lights

For some reason this function was setting a time for the next state
which was triggering the door system to try to close the firelock.
This does not happen serverside because the function only fires from an
event called clientside apparently.
It appears to be an attempt to stop firelocks from closing instantly
that did not function properly, and I cannot discern any other purpose.
As such I have removed it.

* Remove redundant serverside check

This became redundant with commit 439a87f2
2024-06-01 16:57:01 +02:00
Leon Friedrich 768f48bd4f
Improve InteractionSystem range & BUI checks (#27999)
* Improve InteractionSystem range & BUI checks

* Ghost fixes

* AAA

* Fix test

* fix nullable

* revert to broadcast event

* Fixes for eengine PR

* Ah buckle code

* )
2024-06-01 16:56:23 +02:00
Leon Friedrich 396a6ad5a6
Content changes for engine delta-state PR (#28134)
* Update GasTileOverlayState

* Update DecalGridState

* Update NavMapState

* poke

* poke2

* poke3

* Poke dem tests
2024-06-01 16:55:53 +02:00
Nemanja 9adf1ed402
Remove AlertType and AlertCategory (#27933) 2024-06-01 16:55:49 +02:00
DrSmugleaf 471726b6e5
Fix whatever the fuck is going on in storage system slightly (#28236)
* Fix whatever the fuck is going on in storage system slightly

* Fix inverted check

* h

* Add silent bool

* Silent
2024-06-01 16:55:46 +02:00
DrSmugleaf 1aedf69112
Prioritize empty item slots when inserting (#28203)
* Prioritize empty item slots when inserting

* Revert "Prioritize empty item slots when inserting"

This reverts commit 4272a65cba5fc18df801812b0af20123aec08409.

* Prioritize empty item slots when inserting

* Try drop

* Check for any can insert before dropping
2024-06-01 16:55:40 +02:00
nikthechampiongr 06b4df686b
Firelock improvements part 1 (#26582)
* Change prying system and pryunpoweredcomp to allow for custom time modifiers

This will be useful if I go the route of making firelocks pryable when
unpowered instead of just being able to open and close instantly when
unpowered.

* Make firelocks properly predicted

Shared system made. Since atmos checks can only be done on the server we
just have it set relevant bools on the component and then dirty it.
Ditched atmos checks on trying to open, they now only happen whenever
firelocks are updated.

* Make firelocks pryable without a crowbar

While this usually would only allow you to do this when a door is
unpowered, firelocks do not have the airlock component which actually
does that check. As such firelocks will always allow you to pry them
open/closed by hand.

* Clean up System. Change update interval to be based on ticks. Move as much as possible to shared

* Make firelocks unable to emergency close for 2 seconds after being pried open

* Clean up

* More cleanup

* Reorganize SharedFirelockSystem methods to match Initialize order

---------

Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
2024-06-01 16:55:26 +02:00
DrSmugleaf f580b4be64
Add defib event, add fields to be able to disable crit defib and do after movement (#28174)
* Add defib event, add fields to be able to disable crit defib and do after movement

* Fix check
2024-06-01 16:55:16 +02:00
Leon Friedrich 74308b008f
Use non-generic `TryComp()` for metadata & transform (#28133) 2024-06-01 16:53:51 +02:00
Tayrtahn 7ff91799cc
Fix non-ghosts and admins counting toward most followed (#28120)
* Fixed non-ghosts and admins counting toward most followed

* Redone to better leverage EntityQueryEnumerator

* Remember to test your code before you commit it, kids

* Review revisions

* Update Content.Shared/Follower/FollowerSystem.cs

Co-authored-by: ShadowCommander <shadowjjt@gmail.com>

* Update Content.Shared/Follower/FollowerSystem.cs

Co-authored-by: ShadowCommander <shadowjjt@gmail.com>

* Update Content.Shared/Follower/FollowerSystem.cs

* Clean up

---------

Co-authored-by: ShadowCommander <shadowjjt@gmail.com>
Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
2024-06-01 16:53:44 +02:00
Flesh 09113824e9
Add plant metabolism effects to chemical guidebook (#28038)
* draft one of plant metabolism guidebook

* loc fix?

* add attributes loc

* fix loc syntax

* improved appearance

* last commit was undercooked, my bad

* last commit was still undercooked, my worse

* last commit was even still undercooked, my worst

* Addressed comments?

* Fix newlines

* Hopefully this works

* Cleanup, I think

* 2xs
2024-06-01 16:51:34 +02:00
Nemanja c88d5d53dd
Fix magic mirror (#28084)
* Fix magic mirror

* buff magic mirror
2024-06-01 16:51:30 +02:00
DrSmugleaf 10aeac7560
Make standing state down sound nullable (#28132) 2024-06-01 16:51:29 +02:00
Leon Friedrich d8d385adeb
Fix gun cooldown timespan overflow exception (#28136) 2024-06-01 16:51:22 +02:00
DrSmugleaf 198b67bef6
Make wielding automatically drop the item on your other hand (#27975)
* Make wielding automatically drop the item on your other hand

* Fix docs

* Remove redundant parameter

* Fix not deleting virtuals on fail

* Make count freeable hands method

* Add popup when dropping item
2024-06-01 16:51:09 +02:00
dffdff2423 24bb967ffc
Fix Flavor Text editor not saving correctly (#28122)
* Check for flavor text equality in profile.

* Fix some characters being deleted from flavor text

Sometimes the last few characters of the flavor text would get deleted. This fixes this issue.
2024-06-01 16:51:06 +02:00
Tayrtahn d000edce59
Fix activatable UI popup message spam (#28123)
Fixed activatable UI popup message spam
2024-06-01 16:51:03 +02:00
Ed d9e5a8dbae
Revert "Tile variantize after deconstruct" (#28119)
Revert "Tile variantize after deconstruct (#28118)"

This reverts commit bf0529df56.
2024-06-01 16:51:01 +02:00