* Fix usages of TryIndex()
Most usages of TryIndex() were using it incorrectly. Checking whether prototype IDs specified in prototypes actually existed before using them. This is not appropriate as it's just hiding bugs that should be getting caught by the YAML linter and other tools. (#39115)
This then resulted in TryIndex() getting modified to log errors (94f98073b0), which is incorrect as it causes false-positive errors in proper uses of the API: external data validation. (#39098)
This commit goes through and checks every call site of TryIndex() to see whether they were correct. Most call sites were replaced with the new Resolve(), which is suitable for these "defensive programming" use cases.
Fixes#39115
Breaking change: while doing this I noticed IdCardComponent and related systems were erroneously using ProtoId<AccessLevelPrototype> for job prototypes. This has been corrected.
* fix tests
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Sorted the ID card computer's buttons.
* Sorted the Jukebox song list
* Sorted the jukebox entries.
* Sorted access config.
* Forgot a comment.
* Changed collection expression
* Also updated Door electronics bound interface.
* Used the existing method now that I can lol
* Make more objects spray paintable (Reviving #31328) (#37341)
* PaintableAirlockComponent and AirlockGroupPrototype have been replaced
* Slightly redesigned SprayPainterSystem for greater versatility
* Added handling of changes to the appearance of doors and storages
* PaintableGroup prototypes have been created
* Generating tabs with styles in the UI
* Fix error with undiscovered layer
* Slight improvement
* Removed unnecessary property
* The category for `PaintableGroup` was allocated to a separate prototype so that the engine itself would check if the category existed
* Added canisters, but repainting doesn't work
* Added localization to styles
* Fix sprite changing
* Added the ability to paint canisters
* slight ui improvement
* Fix yamllinter errors
* Fix test
* The UI now remembers which tab was open
* Fix build (?)
* Rename
* Charges have been added to the spray painter
* Added a charge texture for the spray painter
* Now spray painter can paint decals
* Increased number of charges
* Spawning dummy objects has been replaced by PrototypeManager
* added a signature about the painting of the object
* fix
* Code commenting
* Fix upstream
* Update Content.Shared/SprayPainter/Components/SprayPainterAmmo.cs
Co-authored-by: pathetic meowmeow <uhhadd@gmail.com>
* review
* Now decals can only be painted if the corresponding tab in the menu is open.
* Fixed a bug with pipe and decal tabs not being remembered
* Update EntityStorageVisualizerSystem.cs
* record
* loc
* Cleanup
* Revert electrified visuals
* more cleanup, fix charges, del ammo4
* no empty file, remove meta component
* closet exceptions, storage visualizer fixes
* enable/disable decal through alt-verb
* Fix missed merge conflicts
* fix snap offset, button event handlers
* simpler order, fix snap loc string
* Remove PaintableViz.BaseRSI, no decal item, A-Z
* State-respecting UI, BUI updates, FTL fixes
* revert DecalPlacerWindow changes
* revert unwanted changes, cleanup function order
* Limit SprayPainterAmmo write access to AmmoSystem
* Remove PaintedSystem
* spray paint ammo lathe recipe, youtool listing
* category as a list, groups as subtabs
* Restore inhand copyright in meta.json
* empty spray painter, recipe produces an empty one
* allow alpha on spray painter decals
* add comments
* paintable wall lockers
* Restrict painting more objects
* Suggested event changes, event cleanup
* component comments, fix ammo inhands
* uncleanable decals, dirty styles on mapinit
* organize paintables, separate emergency/closet grp
* fix categories newline at EOF
* airlock group whitespace cleanup
* realphabetize
* Clean up EntityStorageViz merge conflict markers
* Apply requested changes
* Apply suggestions from sowelipililimute's review
Co-authored-by: pathetic meowmeow <uhhadd@gmail.com>
* betrayal most foul
* Remove members from EntityPaintedEvent
* No emerg. group, steelsec to secure, locker/closet
* Enable repainting the medical wall locker
* comments, no flags on PaintableVisuals
* Remove locked variants from closets/wall closets
* removable decals
* off value consistency
* can't paint away those bones
* fix precedence
* Remove AirlockDepartment, AirlockGroup protos
Both unused.
* whitelist consistency re: ammo component
* add standing emergency closet styles
* alphabetize the spray painter listings
---------
Co-authored-by: Ertanic <black.ikra.14@gmail.com>
Co-authored-by: Эдуард <36124833+Ertanic@users.noreply.github.com>
Co-authored-by: pathetic meowmeow <uhhadd@gmail.com>
* Adds stencil lettering to the spraypainter (#39701)
* adds stencil lettering to the spraypainter
* update decal IDs to match convention
* Add Serializable, NetSerializable attributes to DecalPaintMode (#38921)
Serializable, Net" on DecalPaintMode
* Fixes my mistakes and adds DV compat
* Adds DV-specific stuff
* Makes Our Names Not Use This Case
* Comments xeno stuff we do not have
* RD is dead. Long live the Mystagogue
---------
Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com>
Co-authored-by: Ertanic <black.ikra.14@gmail.com>
Co-authored-by: Эдуард <36124833+Ertanic@users.noreply.github.com>
Co-authored-by: pathetic meowmeow <uhhadd@gmail.com>
Co-authored-by: Alkheemist <alkheemist@gmail.com>
* 1 warning in KudzuVisualizerSystem
* 2 warnings in ChameleonProjectorSystem
* 1 warning in MarkerSystem
* 2 warnings in ItemSystem
* 1 warning in GhostToggleSelfVisibility
* 1 warning in FoamVisualizerSystem
* 1 warning in ClickableTest
* 1 warning in ThrownItemVisualizerSystem
* 2 warnings in InfantSystem
* 1 warning in ChasmFallingVisualsSystem
* 1 warning in PotencyVisualsSystem
* 2 warnings in OrbitVisualsSystem
* 2 warnings in BeamSystem
* 1 warning in JitteringSystem
* 1 warning in CardboardBoxSystem
* 2 warnings in StationAiSystem
* 2 warnings in FirelockSystem
* 2 warnings in CargoSystem.Telepad
* 1 warning in StasisBedSystem
* 2 warnings in WeldableVisualizerSystem
* 2 warnings in DeliveryVisualizerSystem
* 1 warning in TimerTriggerVisualizerSystem
* 1 warning in StorageFillVisualizerSystem
* 2 warnings in RadiationCollectorSystem
* 2 warnings in BorgSwitchableTypeSystem
* 1 warning in TurnstileSystem
* 1 warning in SurveillanceCameraVisualsSystem
* 1 warning in BurnStateVisualizerSystem
* 2 warnings in CableVisualizerSystem
* 1 warning in JetpackSystem
* Cleanup warnings in DamageMarkerSystem
* Cleanup warnings in CuffableSystem
* Cleanup warnings in DeployableTurretSystem
* Cleanup warnings in StorageContainerVisualsSystem
* Cleanup warnings in ItemMapperSystem
* Cleanup warnings in ItemCounterSystem
* Cleanup warnings in RandomSpriteSystem
* Cleanup warnings in PowerCellSystem
* Cleanup warnings in ParticleAcceleratorPartVisualizerSystem
* Cleanup warnings in PaperVisualizerSystem
* Cleanup warnings in PoweredLightVisualizerSystem
* Cleanup warnings in LightBulbSystem
* Cleanup warnings in EmergencyLightSystem
* Cleanup warnings in DoorSystem
* Cleanup warnings in ClockSystem
* Cleanup warnings in BuckleSystem
* Cleanup warnings in JukeboxSystem
* Fix glass duplication with beakers (#34441)
Update chemistry.yml
Fixing glass dupe.
* Automatic changelog update
* Heterochromia for Moth (#36061)
* 1
* Fix local
* formatting
---------
Co-authored-by: Milon <milonpl.git@proton.me>
* Salvage Airlock (#36375)
* Salvage
* atmos a
* more muted colours
* Mapping Related to AI
* Fixed small naming inconsistency
* Revert "Fixed small naming inconsistency"
This reverts commit 985e1fd46a09e521c11dc345f470228e7907fbb9.
* Revert "Mapping Related to AI"
This reverts commit 5d5ae4feb819396c5c2a7413399ab5ce34f8683b.
* Revert "atmos a"
This reverts commit 529831e2584df27fa102ee1c970948fa3b6bab56.
* indent
---------
Co-authored-by: Milon <milonpl.git@proton.me>
* Automatic changelog update
* Departmental shelves whitelist expansion (Attempt №3) (#34292) (disabled)
* Expand-Shelves-Whitelist
Made departmental shelves hold a wider variety of items.
* Accidentally included "Packet" twice
* Automatic changelog update
* Replace GetEntitiesInTile with EntityLookupSystem equivalent (#36756)
* commit GET!!
* minor cleanup
* Automatic changelog update
* Unused dependency cleanup. (#36760)
* take 2! fight!!!
* final touches
* reeeeeee
* Fire protection for ERT engineering hardsuit (#34949)
* Automatic changelog update
* Nonlethal throwables crate (#35808)
* Automatic changelog update
* Use non-generic TryComp in `StationSpawningSystem` (#36769)
Use non-generic TryComp in StationSpawningSystem
* Add marker components for admin shenanigans (#36776)
* Automatic changelog update
* Restore `LimitedChargesComponent.MaxCharges` default value to 3 (#36778)
* Wizard Figure Voiceline Fix#36771 (#36779)
DA WIZARDgit add -A
* change MV cable outline (#36751)
* change MV cable outline
* zamn
* The Beverage Jug Can Now Look Open (#36070)
* GenJug-Changes
Signed-off-by: Prole <172158352+Prole0@users.noreply.github.com>
* Guh
Signed-off-by: Prole <172158352+Prole0@users.noreply.github.com>
* Support For the Rest
Signed-off-by: Prole <172158352+Prole0@users.noreply.github.com>
* New Sprites
Signed-off-by: Prole <172158352+Prole0@users.noreply.github.com>
* Newest Sprites
Signed-off-by: Prole <172158352+Prole0@users.noreply.github.com>
---------
Signed-off-by: Prole <172158352+Prole0@users.noreply.github.com>
* Pirate Gear Tweaks. (#35986)
* Tweaked pirate gear to be in-line with similar items.
* Added attribution for flashlight sprites, made hardsuits Major Contraband
* Added empty versions of the pirate revolver and flintlock.
* Test fail fix hopefully?
* Test fail fix hopefully V2.0
* Test fail fix hopefully V3.0
* Test fail fix hopefully V4.0
---------
Co-authored-by: RedBookcase <Usualmoves@gmail.com>
* Automatic changelog update
* Markings overhaul (#35938)
* markings displacement setup
* ok i got it!
* fix map updating
* remove trackingLayers
* markings clean up and modernizize
* marking disabling displacements
* markings restriction
* dehihienize
* dehihiniezize 2
* aa
* nice
* Automatic changelog update
* Resprite main altars (#35685)
* resprite main altars
* updated meta.json
* Automatic changelog update
* Adds beanies to the WinterDrobe! (#32946)
* sprites
* messing with the ymls
* new sprites
* that's a lotta yaml
* make the sprites gooder
* color adjustment
* to the winterdrobe with you
* layering fix
* Automatic changelog update
* Santa hat with a foldable beard (#36510)
* Added foldable component to santa hat
* Modified sprites, modified YAML. YAML is cursed
* Changed santa hat description to mention the beard fold
* Removed HideLayerClothing since it doesnt work
* Changed the prefix from "beard" to "nobeard" to match with the fold/unfold verb
* Credits for sprite changes
---------
Co-authored-by: Lanedon <matth.galvez@gmail>
* Automatic changelog update
* Puddle Code Slipping Cleanup (#35845)
* Init Commit
* windows yelling at me to update commit
* working commit, need prediciton and more dehardcoding
* Project 0 warnings
* Working Commit (Near Final)
* ryder got confused commit
* I love Merge Conflicts :)
* Working commit, no prediction
* Forgot the yaml changes
* Comments and typos
* Apparently while the reduced launch mult of lube was initialized it was never used so I revered back to default
* Fixed an incorrect divisor
* bit of cleanup
* Prediciton fixed, and puddles now affect all entities
* FORGOT TO RENAME A VERY IMPORTANT VARIABLE OOPS
* Really big I forgor moment
* Even bigger I forgor moment
* four more merge conflicts to fix four more oopsies
* fixed actual divide by zero moment and also im very dumb
* Even bigger I forgor moment
* four more merge conflicts to fix four more oopsies
* fixed actual divide by zero moment and also im very dumb
* Fix all test fails
* code cleanup
* Webedit whitespace
* Code cleaup
* whitespace webedit
* whitespace webedit
* whitespace webedit
* whitespace removal
* Comments and cleanup
* Re-Added 20 warnings as per Ork's request
* Cleanups
* Spacing fix
* bugfixes and cleanup
* Small bugfix
* Actually dirty the slipComp for real
* Added Friction field to Reagent Prototype per design discussion
* Sliding system is kill
* The Bartender can now make Eggnog (#34065)
* Preliminary eggnog changes (egg in shaker crashes?)
* Fixed eggnog reagent name and description
* added - to flavor
* deleted a space
* Added eggnog glass sprite
* changed fill levels to match rsi
* Added two more fill levels to eggnog
* Removed fizziness, changed physical description, and fixed rsi
---------
Co-authored-by: uhbg <29674581+uhbg@users.noreply.github.com>
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
* Automatic changelog update
* Require traitors to maroon their objective no matter what (#35825)
* jesus
* okay.
* OOPS
* ok
* ok
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* ok
* Update Resources/Prototypes/Objectives/paradoxClone.yml
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Update Resources/Prototypes/Objectives/base_objectives.yml
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* m
* ok
* ok
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Wizard Headset (#35732)
* wizardcomms
* wizheadset
* Addressed requested changes and axed wizard channel due to redundancy.
* oops overlooked this, dont tell anyone
* another mistake fixed
* removed wiz encryption key due to redundancy
* accidentally left some punctuation in a now unrelated meta.json
* Automatic changelog update
* Remove MK ULTRA ai name (#35726)
* Remove bad AI names
* Fine, I won't try to sneak this in here.
* Reorder electronics recipe file, add filter categories (#35713)
* electronics split
* split base recipe and category
* all but machines
* machine shuffle
* reorder
* delete unused recipes
* rename cargo to supply
* git weirdness
* git weirdness 2
* Automatic changelog update
* Cleanup warnings in `SharedPortalSystem` (#36747)
* Cleanup warnings in SharedPortalSystem
* Formatting while we're here
* Replace uses of !Any() with Count == 0
* AnyEntitiesIntersecting
* Binomial Number Selector for EntityTables (#36783)
* binomial dist
* lol initialize the int tho idiot
* xml docs my forgotten
* ditto
* Add more ruins (#36785)
* Fix NRE in GasTileOverlaySystem (#36793)
* Automatic changelog update
* Add RGA/RSI to Credits (#36704)
* Add RGA and RSI to Credits
* Move to thread + add directory field
* Further Allocation Tweaks (#36800)
* init
* fix lockboxes
* Automatic changelog update
* Add the medical HUDs to medical's loadouts (except chem) (#32847)
Added the medical HUD and eyepatch to the medical (CMO, doctor, paramed and intern) loadout to let them choose between. Also gives the option for the regular glasses.
* Automatic changelog update
* new salv ruins (#36798)
* hotplate, kitcken grille bugfixes (#34776)
* commit
* cleanup
* Automatic changelog update
* Solution drag and drop now checks if container is closed and drainable (#34683)
drainable fix
* Automatic changelog update
* fix some datasets (#36806)
* Add rehydratable mop bucket cube, refactor the rehydratable yml (#34586)
* Refactor rehydratable items
* Finish main refactor
* Add mop bucket cube
* Move cube sprite and item size to RehydratableAnimalCube
* Fix sprite attribution
* Make it follow the conventions
* Refactor wrapped cube, leave MonkeyCube tag only on the cube and the Syndie Sponge
* Fix DehydratedSpaceCarp inheritance overwriting needed components
* no need for this comment
* remove whitespace
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* indentation
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Restore lost description
* reorder stuff
* line
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Automatic changelog update
* Increase thief to player ratio (#36531)
* reduce max number of traitors, increase thief to player ratio
* revert traitor max back to 8
* Automatic changelog update
* Added a semi-functional genderfluid pin. (#35854)
* Added a semi-function GenderfluidPin
* Update pins.yml
fix bug
* Fix meta.json under the newly merged "fix as you go" policy
* Update pin description
---------
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
* Automatic changelog update
* Station AI Name Identifier (#36801)
init
* Automatic changelog update
* Makes EventRole Ids properly set ID names. (#28958)
* Add id binding system
* Change so it activates when added too
* Add to eventhumanoid
* Add PDA binding, try to fix some things
* Still not fixed, PDA is working right
* Move to server, add on mind instead
* Implement suggestions
* Fix things
* Finish review stuff
* Messed up cluwne
* Remove after only changing id too
---------
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
* Various sharedsystem spring cleaning (#36200)
* Various shared system warnings cleanup
* More shared system warnings cleanup
* Rearranging changes
* Using correct transform for unbuckle
* Small changes
* Revert buckle change
* Update Content.Shared/Ghost/SharedGhostSystem.cs
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Fix some locale strings and make some code for them looks better (#32003)
* Fix a lot locale strings
add functions using
fix identity for meat spike and creaming
* comma
* fixes for fixes
* yeah
* fuck
* Automatic changelog update
* Remove non-functional ninja exemption from `SpawnAndDeleteEntityCountTest` (#36813)
Remove non-functional ninja exemption from SpawnAndDeleteEntityCountTest
* Firelock temperature and pressure warning lights (#28339)
* Add temperature and pressure lights to firelocks
* Replace sprites with new pressure and temperature light versions
* Remove obsolete deny and locked sprites
* Add SpriteSync for warning light animation synchronization
* Teal lights
* Partial animation implementation
* fixup! Teal lights
* Temperature lights
* Adjusted firelock light heights and added final warning light sprites
* Fix colors
* Testing colors
* Update light sprites
* updated sprites
---------
Co-authored-by: EmoGarbage404 <retron404@gmail.com>
* Automatic changelog update
* Fix bots parenting, emotes (#29949)
* Bots overhaul
* fix
* change speech sound to pai
* purge a lot
* i forgor :trollface:
* adjust
* that aswell
* Automatic changelog update
* Fix identity grammar (#36817)
Fix identity
* Fix Animal Versions of Captain Uniform (#36804)
* scienceevasuit
* update money uniforms
* update meta.json files and hamster hats
* revert scienceevasuit
* revert accidental prisoner eva change
* Automatic changelog update
* Fix vox hair (#36816)
* Fix vox hair
* remove CL
* Tweak Security protection values (#30212)
* Tweak Hardsuits
* HoS/Ward Coats change
* Whoopsie wrong number
god why am i doing this its 1:33 AM and i made a silly mistake...
* Adress Review
Revert Warden hardsuit slowdown to 30% again
Decreased Security hardsuit heat protection down to 20%
* Automatic changelog update
* Added more salvage ruins (#36822)
* Metal foam grenade rework, small tweaks to grenade timers (#34579)
* Automatic changelog update
* dragons can now pry doors (#36811)
* Automatic changelog update
* Make funding allocation computer more configurable (#36790)
* Make funding allocation computer more configurable
* admin logging
* unused
* ccvar enabled
---------
Co-authored-by: ScarKy0 <scarky0@onet.eu>
* Automatic changelog update
* Fingerprint taking improvements (#31864)
* now using event to check access to fingerprint
* Opps actually commiting the changes
---------
Co-authored-by: YourUsername <you@example.com>
Co-authored-by: beck-thompson <beck314159@hotmail.com>
* Banana cream pie loc improvements (#36829)
* CAPITALIZE(THE($owner))
* Rename "thrower" to "thrown"; use THE($thrown)
* "the banana cream pie" -> "a banana cream pie"
* Simplify filter
* Automatic changelog update
* Command uniform (#32103)
* Added generic command jumpskirt, jumpsuit and cap, and made them available in the HoP's clothing printer.
* fixed generic command jumpskirt and jumpsuit.
* Updated generic command jumpskirt/-suit textures, added generic command beret.
* Fixed game-breaking bug in previous commit relating to the command beret.
* altered generic command soft cap/baseball cap sprites.
* Update Resources/Prototypes/Entities/Clothing/Head/hats.yml
Co-authored-by: SlamBamActionman <83650252+SlamBamActionman@users.noreply.github.com>
* Update Resources/Prototypes/Entities/Clothing/Uniforms/jumpskirts.yml
Co-authored-by: SlamBamActionman <83650252+SlamBamActionman@users.noreply.github.com>
* Update Resources/Prototypes/Entities/Clothing/Uniforms/jumpsuits.yml
Co-authored-by: SlamBamActionman <83650252+SlamBamActionman@users.noreply.github.com>
* review
* whoopsie
---------
Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com>
Co-authored-by: SlamBamActionman <83650252+SlamBamActionman@users.noreply.github.com>
Co-authored-by: Milon <milonpl.git@proton.me>
* Automatic changelog update
* downprice many cargo orders (#32375)
* atmos repricing
* emitter crate
* materials
* lasers
* revert gun prices
* Automatic changelog update
* Ashen hud item status slot fix (#31411)
* new patchMargin variable added, horizontals fixed
* All sides now work, system is fully integarated
---------
Co-authored-by: Zachary Yona <magicalusf@gmail.com>
* Ashtray Resprite and Fix (#31643)
* The meat and potatoes
Yup
* Stupid recycler
bruh
* guh
guh
* Update MinorAntagonists.xml (#36836)
* Simulate command in minutes for real (#36808)
* 60
* Fix warning CS0414 instances (#36832)
Fix warning cs0414 instances
* Nerf Firelock electronic prices (#33469)
* Nerf Firelock electronic prices
- make firelock electronics price half of the input cost to make one
(27) rounded up
* Why does firelock make glass?
- remove the Physical composition of glass from
FirelockElectronics as the input does not contain glass
and the output cannot contain half a steel and plastic
---------
Co-authored-by: Milon <milonpl.git@proton.me>
* Automatic changelog update
* Give Admins "Tails" (#36842)
One line yaml change
* Fix construction orientation being ignored for some objects (#36488)
* fixes
* removed empty "SnapToGrid"s and parent "completed"s
* Automatic changelog update
* elemental.yml & asteroid.yml cleanup (#36448)
* Moth-pockets (#34517)
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* Four new food crates for the ATS (#33286)
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* Automatic changelog update
* Cleanup: Move folders out of bureaucracy.rsi and paper.yml (#35108)
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* Improve LocalizedDataset test to check for low Count (#36848)
* Improve LocalizedDataset test to check for low Count
* Fix missing entries for FigurinesFootsoldier
* Add 1 dragon name (#36846)
* this is a commit you cannot skip
* why do you have to add a count why
* Remove steel sheet hull fixing (#33443)
* Remove steel sheet hull fixing
It's unintuitive that it's wasteful, there's not really any systems to NOT make it wasteful, and it's a UX trap. No this is not "noob trap", no. It's an UX issue because if hundreds of people do it over and over again without noticing anything wrong, well, something fails to properly note that there's an issue with what they are doing. Aka user experience issue. Aka not a problem with the user but the design.
Also could be a shitty doafter action that makes you wonder if something's wrong
* Why was this testing using steel of all things
* Automatic changelog update
* cleanup + add names to some entities (#36856)
* Remove redundant fields from `MovementSpeedModifierComponent` (#36859)
Delete _baseWalkSpeedVV and _baseSprintSpeedVV
* Cleanup warnings in NinjaSuitSystem (#36861)
Fix warnings in NinjaSuitSystem
* Modernize `GhostComponent` & Ghost API (#36858)
* Move CanReturnToBody to system
* Move CanGhostInteract to system
* Cleanup redundant datafields and viewvariables
* Document datafields
* Document component
* Add SetTimeOfDeath Entity<T> overload, obsolete old version
* Document public methods
* Cleanup obsoleted method calls
* Cleanup warning in `EmptyAllContainersBehaviour` (#36860)
Fix warning in EmptyAllContainersBehaviour
* Cleanup warnings in `SharedCryostorageSystem` (#36863)
Fix warnings in SharedCryostorageSystem
* Cleanup warnings in `CableSystem.Placer` (#36868)
* Fix warnings in CableSystem.Placer
* Formatting
* Cleanup warnings in `PolymorphSystem.Map` (#36869)
Fix warnings in PolymorphSystem.Map
* Cleanup warnings in `WorldgenConfigSystem` (#36864)
Fix warnings in WorldgenConfigSystem
* Move guardian sounds to component (#36870)
* Cleanup warnings in `SpawnSalvageMissionJob` (#36866)
* DoMapInitialize and SetMapPaused
* GridTileToLocal
* Formatting
* Remove unused variables
* Update Content.Server/Salvage/SpawnSalvageMissionJob.cs
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Fix warnings in `ServerDbManager` (#36871)
Fix warnings in ServerDbManager
* pAI Software Catalog (#36857)
* initial commit
* add the shop and make it work
* add existing pai actions to the software shop
* added power monitor app
* killed the power and crew monitor software, too powercreepy
* fix test failures
* fix more test failures
* fix merge conflicts
* code changes to conform with review
* fix unintentional submodule update
* submodule update
* remove unused currency prototype ref
---------
Co-authored-by: archrbx <punk.gear5260@fastmail.com>
* New Salvage Ruin - Hydro Outpost (#36826)
* Automatic changelog update
* Make toy sword less obvious (#34199)
* YAML fuckery
* Remove toy_sword.rsi
Not a webedit btw
* Automatic changelog update
* Adds shorts/pants to ClothesMate vending machine (#35361)
* Clothesmate shorts
* matches price of vend to the new contents
* Moths can eat pills (#35609)
* Automatic changelog update
* Xenoborgs part 1 (#36830)
Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* Updated Syndicate and Ammo Contraband (#35102)
Co-authored-by: RedBookcase <crazykid1590@gmail.com>
* Automatic changelog update
* Put items inside cakes! (#31015)
* First commit
* I'm silly
* Please be it
* Some more fixes
* Cleanup
* fine!
* removed = false
* review
---------
Co-authored-by: Milon <milonpl.git@proton.me>
* Removed syndicate surgery duffel, added advanced circular saw to Medical Doctor uplink. (#35915)
* Removed syndicate surgery duffel, added advanced circular saw to Medical Doctor uplink.
* Update Resources/Prototypes/Entities/Objects/Specific/Medical/surgery.yml
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
---------
Co-authored-by: RedBookcase <Usualmoves@gmail.com>
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
* unremove surgery duffel
* unfunny
* Automatic changelog update
* fix NoCargoOrderArbitrage fail (#36878)
whoopsie
* Cotton Grilled Cheese Sandwich (#36135)
* Working entity.
* New sprite by MadeOfHeartAndStone
* Removed deadspace, changed attribution in meta.json
* review
---------
Co-authored-by: Milon <milonpl.git@proton.me>
* Automatic changelog update
* Meat Patty (#34896)
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* Automatic changelog update
* Remove beaker from the MaterialArbitrageTest whitelist (#36876)
* Turnstiles (#36313)
* construction rotation fix
* Turnstiles
* renaming
* review-slarticodefast-1
* mild attempts to fix (sorry sloth)
* move some more shit
* Remove engine dependency
* grid agnostic
* remove debug string
* fix json
* Update Content.Shared/Movement/Pulling/Systems/PullingSystem.cs
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* Update Content.Shared/Movement/Pulling/Systems/PullingSystem.cs
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* remove pass delay for mispredict reasons.
* most minor of changes
* Give directional indicator on examine
---------
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* Automatic changelog update
* Genpop Closets & IDs (#36392)
* Genpop IDs and Lockers
* placeholder generation, no ui yet.
* UI
* Fix time offset
* fix meta.jsons
* big speller
* Scarkyo review
* Add turnstile prototypes
* make IDs recyclable
---------
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
* Automatic changelog update
* Fix small misc. turnstile issues (#36893)
* Fix small misc. turnstile issues
* more missing things
* quieter
* New Spawners, Modified Spawners, new Service/Theatre Airlock, and new Colorful Light Crate (#36750)
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* Automatic changelog update
* Automatic changelog update
* Disable shadows for observer pointlight (#36897)
no shadows
* Fix QSI bringing people into paused maps (#36834)
* Automatic changelog update
* Fix storage ui hovering over the hotbar (#36770)
* Turnstiles lower volume + access reader (#36900)
fixes
* Fix disposal unit flush animation (#30677)
* Fix disposal unit flush animation
* Revert "Fix disposal unit flush animation"
This reverts commit a596ecfd5f5368f87ef52cfb27884a8e000185c6.
* control by setting layer visibility rather than overwriting
* restore changes
* Correct IdentityBlocker to include specific outer clothing (#33085)
* Make IdentityBlocker include outerclothing
* Modify Correct Bit
* Fix mask/eye cobo
* Automatic changelog update
* Change some posters to be rules-compliant (#32734)
* Initial commit
* Minor edit
* it's very hard to fit "disorder"
* Revert No ERP poster, fix spawner
* Attribution
* Update text
* Missed poster spawner
---------
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
* Automatic changelog update
* Cyborg Rebalance (#34186)
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
* Automatic changelog update
* Reptilians Can Eat Orange Creamsicles (#36890)
* Automatic changelog update
* Add Bloodstream to Goliaths (#33305)
* Automatic changelog update
* Nerf mining hardsuit's effectiveness against bullets and bombs. (#31450)
* Automatic changelog update
* Controls page guidebook rework 2025 Q1 (#36363)
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* Automatic changelog update
* Lower interdyne herbals TC cost (#36841)
* Automatic changelog update
* cleanup instruments yml (#32262)
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* Automatic changelog update
* Automatic changelog update
* [FIX] Rubber now uneatable (#34543)
* Releasing an under-pressure lockout is now a verb (#36910)
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* Automatic changelog update
* fix changelog (#36915)
* Fix for ghosts being unable to follow the AI when it uses a holopad (#36355)
* Initial commit
* Added to-do
* Automatic changelog update
* Fix random maints room deleting whatever was already there (#36605)
* Fix donuts tags breaking the bounty (#36903)
* Automatic changelog update
* Make 10u of "Atomic Bomb" drink instead of 11u (#36921)
changed atomic bomb recipe
* Automatic changelog update
* PKA Modkits + Rebalance (#31247)
* Automatic changelog update
* Remove a redundant trycomp from TileAnomalySystem (#36924)
* remove a redundant check
* revert this space.
* Land mine armament (#33883)
* Land Mine is now armable, it will not explode unless armed.
* Land Mine is now armable, it will not explode unless armed.
* Explicitly have Armed as false
* SharedLandMineSystem.cs adds the "Arm"-verb in "Content.Shared" with the Arming logic being implemented in "Content.Server"
* Land Mines now blink only when armed.
* Added prediction components, moved logic to SharedLandMineSystem.cs and inherit it in client content.
* Accessing the datafield directly instead of using methods
* Mines are now armed by default with a unarmed prototype
* Land mine now shows if it is armed when examined and in range.
* Landmine is unarmed by default with an armed variant for mapping purposes.
* Removed properties that were already defined by inheritance.
* Access the bool directly from the component
* Add booleans to change if the Arm-verb is showed and if examining the mine shows the status.
* Added status message for unarmed mine, removed using PushGroup since only one string is displayed.
* Added properties to the explosive floor sign to ensure that it is armed, not showing neither status nor arm-verb.
* The prototypes work now as before with added unarmed versions. Sprite is now only one toggable layer.
* Make the craftable land mine unarmed.
* Refactored the arming mechanic into own component and system.
* Reverted the explosive wet floor sign to previous prototype and added the Armable component and ItemToggle to the landmines.
* Moved the examination strings from land-mines.ftl to armable.ftl.
* Removed unused property.
* Formatting and fixing imports
* Added prefixes to the ftl naming. Moved LocId from system to component
* Added documentation. Moved check for armable to HandleStepTriggerAttempt.
Moved the LocId to component.
* Removed the TryArming method. Added documentation.
* Removed unnecessary TryComp
* Simplified the logic for the trigger attempt
* HasComp instead of TryComp on logic
* EmoGarbage Review
---------
Co-authored-by: Franz - Josef Björck <kaiserbirch@proton.me>
Co-authored-by: EmoGarbage404 <retron404@gmail.com>
* Add Cotton Burgers (#36405)
* Adds cotton burgers
* Rephrased copyright
* Added an extra comment
* Adds CottonBurger to tags.yml, Not sure if i am supposed to do this or not.
* Reordered Cotton bun YAML, and fixed overwritten tags
* Merge issue fix?
* Add experiment plushie and remove rubber chicken from cotton burgers
* Minor comment change
---------
Co-authored-by: beck-thompson <beck314159@hotmail.com>
* hide light-switches from build menu (#34664)
* Automatic changelog update
* Fixed stinger grenade lag spikes (#36641)
* Fixed stinger lag spikes
* Simplify nullable checks
* More cleanup of projectile grenades
* Remove null default from ShootProjectile
* Sheet-meister 2000 Cloth recipe (#32676)
* Sheet-meister 2000 can now make rolls of cloth
* Small Cleanup
* resolve conflicts
---------
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* Automatic changelog update
* Clear MIDI masters properly to avoid replay freezes (#36809)
While trying to play a replay I noticed that the replay would freeze
when seeking in some cases. After some debugging, I discovered that two
MIDI renderers had each other as master, which caused an infinite loop
processing MIDI events.
I'm not entirely sure of the sequence of events that leads to this
during replay playback, but I did notice that MIDI render masters are
never set to null. This is in the best case just a memory leak, in the
worst case probably the source of the bug, so... I fixed that.
* Changed soundGunshot for Pulse Pistol and Pulse Carbine from laser_cannon to laser3 (#36952)
* Automatic changelog update
* The Atmos A Airlock (#36376)
* airlocks
* Update meta.json
Added my modification in the meta
* Changed the storage sizes of different swords. (#36564)
Co-authored-by: RedBookcase <Usualmoves@gmail.com>
* Automatic changelog update
* Fix autorecharge (#36955)
* Fix inflatable barriers finishing instantly if canceled! (#36937)
Fix
* Automatic changelog update
* Only sec glasses can show contraband: second attempt (#36412)
* Add base code for cheking contraband in hud
* Fix missing using in InventorySystem.Relay
* Fix errors and update HUD yml
* Add show contraband with component on entity
* fix component description
* Update Content.Shared/Contraband/ShowContrabandDetailsComponent.cs
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* Update "if" for check if ent hasComp in contrabandSystem
* Remove << InventorySystem.Relay.cs
* Update Content.Shared/Contraband/ShowContrabandDetailsComponent.cs
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Update Content.Shared/CCVar/CCVars.Game.cs
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Fix partial class ShowContrabandSystem
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Update Content.Shared/Contraband/ShowContrabandDetailsComponent.cs
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Update Content.Shared/Inventory/InventorySystem.Relay.cs
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Some update ShowContrabandSystem
* Try with record struct
* back again ti default class with EntityEventArgs
* Remove EntityEventArgs
* Finally use record struct
---------
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Automatic changelog update
* Resolve a warning in SharedAnomalySystem and quell some linter whining. (#36939)
* resolve a warning and deal with some linter whining.
* Update Content.Shared/Anomaly/SharedAnomalySystem.cs
---------
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
* Automatic changelog update
* Truncate lathe announcement lists (#36945)
* Automatic changelog update
* Descriptions for .30 Rifle (#36958)
Initial commit
* CMO Hardsuit: Zombification Resistance tweak (#36957)
initial commit
* Automatic changelog update
* Adds Parcel Wrap (#34471)
* Parcel Wrap
* fix TG sprite licenses
update attribution on modified `unwrapped` sprite to better conform to CC's guidance
* ContainerContainer test failure fix
* Just easy changes for now.
* Imagine building your code before pushing it for review
* The rest of the PR comments
* PR comments
* more comments + cargo orderability
* whitespace: deduplicated.
* use limitedcharges
replace mostly-duped client/server with if(onserver)
* cabinet perspective sprites
* web edit detected
fite me
* @ps3moira 's new sprites for me :)
* add a touch of attribution
* EmoGarbage Review
* Merge with master
* Merge with master
---------
Co-authored-by: EmoGarbage404 <retron404@gmail.com>
* Automatic changelog update
* Ammo Mag + Speedloader Inhand Sprites (#34235)
* Added inhand visuals to (most) ammo magazines and speedloaders
* whoops mixed up a single inhand on the rifle mag
* Didn't realize rubber ammo got removed.
* added attributions
* adjusted inhand visuals to account for magazine types
* missed one 👁️👁️
---------
Co-authored-by: EmoGarbage404 <retron404@gmail.com>
* Automatic changelog update
* New Science Biosuit Locker Sprite (#36929)
* first commit, slightly broken
* fixed meta json
* reverse accidental cmo inclusion
* Automatic changelog update
* Remove legacy cargo shuttle code/prototypes (#36967)
* Automatic changelog update
* Paramedic suits adjustments (#36707)
* Changes
* meta
* Battery (SMES/substation) interface (#36386)
* Add ENERGYWATTHOURS() loc function
Takes in joules (energy), displays as watt-hours.
* Add simple OnOffButton control
* Re-add Inset style class
This was sloppily removed at some point?? Whatever, I need it.
* Add helper functions for setting title/guidebook IDs on FancyWindow
Reagent dispenser uses these, more in the next commits.
* Add BuiPredictionState helper
This enables me to implement coarse prediction manually in the battery UI.
Basically it's a local buffer of predicted inputs that can easily be replayed against future BUI states from the server.
* Add input coalescing infrastructure
I ran into the following problem: Robust's Slider control absolutely *spams* input events, to such a degree that it actually causes issues for the networking layer if directly passed through. For something like a slider, we just need to send the most recent value.
There is no good way for us to handle this in the control itself, as it *really* needs to happen in PreEngine. For simplicity reasons (for BUIs) I came to the conclusion it's best if it's there, as it's *before* any new states from the server can be applied. We can't just do this in Update() or something on the control as the timing just doesn't line up.
I made a content system, BuiPreTickUpdateSystem, that runs in the ModRunLevel.PreEngine phase to achieve this. It runs a method on a new IBuiPreTickUpdate interface on all open BUIs. They can then implement their own coalescing logic.
In the simplest case, this coalescing logic can just be "save the last value, and if we have any new value since the last update, send an input event." This is what the new InputCoalescer<T> type is for.
Adding new coalescing logic should be possible in the future, of course. It's all just small helpers.
* Battery interface
This adds a proper interface to batteries (SMES/substation). Players can turn IO on and off, and they can change charge and discharge rate. There's also a ton of numbers and stuff. It looks great.
This actually enables charge and discharge rates to be changed for these devices. The settings for both have been set between 5kW and 150kW.
* Oops, forgot to remove these style class defs.
* Automatic changelog update
* Use RMC mob collision values (#36851)
Use RMC movement values
General feedback was it's too slow to push through people but this still prevents stacking so.
* Automatic changelog update
* early merge fix AAAAAA validcheck
* Cherry Pick Round-start Solar Variation (#36825)
* Roundstart Variation for Solar Panels (#86)
* Added roundstart variation for solar panels
* Removed HV cable spawner since i don't want to bother with mapping them
* Solar Panel Variation Pass Fix (#96)
Added a second variation pass for regular solar assemblies, since otherwise they would spawn both it and the broken variety
* Reorganized everything to no longer be in the _Moffstation subdirectory
* Removed a forgotten tag for Moffstation
* Removed the moffstation namespace settings
* Update Content.Server/GameTicking/Rules/VariationPass/Components/SolarPanelReplaceVariationPassComponent.cs
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
* Update Content.Server/GameTicking/Rules/VariationPass/Components/ReplacementMarkers/SolarPanelReplacementMarkerComponent.cs
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
---------
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
* disable solar panel variation
* put surgery borg module icons in _Shitmed
* the big fix
* abstract the right recipe
* goida
* no milk
* update coscult code
* update coscult objectives
* migrate SignCansScience away
* goida
* update engine maybe fix test
* GET OUT OF MY HEAD
* i give up
---------
Signed-off-by: Prole <172158352+Prole0@users.noreply.github.com>
Co-authored-by: Alice4267 <psycopompass14@gmail.com>
Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com>
Co-authored-by: Pgriha <133212269+Pgriha@users.noreply.github.com>
Co-authored-by: Milon <milonpl.git@proton.me>
Co-authored-by: TakoDragon <69509841+BackeTako@users.noreply.github.com>
Co-authored-by: Hyper B <137433177+HyperB1@users.noreply.github.com>
Co-authored-by: Kyle Tyo <36606155+VerinSenpai@users.noreply.github.com>
Co-authored-by: K-Dynamic <20566341+K-Dynamic@users.noreply.github.com>
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
Co-authored-by: YoungThug <ramialanbagy@gmail.com>
Co-authored-by: lzk <124214523+lzk228@users.noreply.github.com>
Co-authored-by: Prole <172158352+Prole0@users.noreply.github.com>
Co-authored-by: RedBookcase <crazykid1590@gmail.com>
Co-authored-by: RedBookcase <Usualmoves@gmail.com>
Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com>
Co-authored-by: Booblesnoot42 <108703193+Booblesnoot42@users.noreply.github.com>
Co-authored-by: UBlueberry <161545003+UBlueberry@users.noreply.github.com>
Co-authored-by: Banedon <15725971+Lanedon@users.noreply.github.com>
Co-authored-by: Lanedon <matth.galvez@gmail>
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
Co-authored-by: uhbg <uhbg@users.noreply.github.com>
Co-authored-by: uhbg <29674581+uhbg@users.noreply.github.com>
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
Co-authored-by: Jackson Langley <tripwiregamer@gmail.com>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
Co-authored-by: Entvari <195642967+Entvari@users.noreply.github.com>
Co-authored-by: dffdff2423 <dffdff2423@gmail.com>
Co-authored-by: āda <ss.adasts@gmail.com>
Co-authored-by: IProduceWidgets <107586145+IProduceWidgets@users.noreply.github.com>
Co-authored-by: Spessmann <156740760+Spessmann@users.noreply.github.com>
Co-authored-by: Leon Friedrich <60421075+ElectroJr@users.noreply.github.com>
Co-authored-by: Thomas <87614336+Aeshus@users.noreply.github.com>
Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
Co-authored-by: Phooooooooooooooooooooooooooooooosphate <184853112+Phooooooooooooooooooooooooooooooosphate@users.noreply.github.com>
Co-authored-by: TytosB <54259736+TytosB@users.noreply.github.com>
Co-authored-by: Łukasz Lindert <lukasz.lindert@protonmail.com>
Co-authored-by: Hrosts <35345601+Hrosts@users.noreply.github.com>
Co-authored-by: T <theo75cg@gmail.com>
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
Co-authored-by: Verm <32827189+Vermidia@users.noreply.github.com>
Co-authored-by: J <billsmith116@gmail.com>
Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
Co-authored-by: EmoGarbage404 <retron404@gmail.com>
Co-authored-by: Ghagliiarghii <68826635+Ghagliiarghii@users.noreply.github.com>
Co-authored-by: Michael <107807667+Doc-Michael@users.noreply.github.com>
Co-authored-by: mubururu_ <139181059+muburu@users.noreply.github.com>
Co-authored-by: pathetic meowmeow <uhhadd@gmail.com>
Co-authored-by: ScarKy0 <scarky0@onet.eu>
Co-authored-by: godisdeadLOL <169250097+godisdeadLOL@users.noreply.github.com>
Co-authored-by: YourUsername <you@example.com>
Co-authored-by: beck-thompson <beck314159@hotmail.com>
Co-authored-by: Golden Can <greentopcan@gmail.com>
Co-authored-by: SlamBamActionman <83650252+SlamBamActionman@users.noreply.github.com>
Co-authored-by: Ilya246 <57039557+Ilya246@users.noreply.github.com>
Co-authored-by: Zachary Yona <58833995+Magicalus@users.noreply.github.com>
Co-authored-by: Zachary Yona <magicalusf@gmail.com>
Co-authored-by: Hanz <41141796+Hanzdegloker@users.noreply.github.com>
Co-authored-by: catlord <catlord0009@gmail.com>
Co-authored-by: poklj <compgeek223@gmail.com>
Co-authored-by: Vladislav Suchkov <20380250+murolem@users.noreply.github.com>
Co-authored-by: kosticia <kosticia46@gmail.com>
Co-authored-by: Smith <182301147+AgentSmithRadio@users.noreply.github.com>
Co-authored-by: Winkarst <74284083+Winkarst-cpu@users.noreply.github.com>
Co-authored-by: T-Stalker <43253663+DogZeroX@users.noreply.github.com>
Co-authored-by: Saphire Lattice <lattice@saphi.re>
Co-authored-by: ArchRBX <5040911+ArchRBX@users.noreply.github.com>
Co-authored-by: archrbx <punk.gear5260@fastmail.com>
Co-authored-by: Southbridge <7013162+southbridge-fur@users.noreply.github.com>
Co-authored-by: No Elka <125199100+NoElkaTheGod@users.noreply.github.com>
Co-authored-by: PotRoastPiggy <121025443+PotRoastPiggy@users.noreply.github.com>
Co-authored-by: Samuka-C <47865393+Samuka-C@users.noreply.github.com>
Co-authored-by: Coolsurf6 <coolsurf24@yahoo.com.au>
Co-authored-by: beck-thompson <107373427+beck-thompson@users.noreply.github.com>
Co-authored-by: deltanedas <@deltanedas:kde.org>
Co-authored-by: SG6732 <151011904+SG6732@users.noreply.github.com>
Co-authored-by: themias <89101928+themias@users.noreply.github.com>
Co-authored-by: Preston Smith <92108534+thetolbean@users.noreply.github.com>
Co-authored-by: Nox <nebulousnox38@gmail.com>
Co-authored-by: Victor Shen <71985089+Vexerot@users.noreply.github.com>
Co-authored-by: Alzore <140123969+Blackern5000@users.noreply.github.com>
Co-authored-by: Kresny <krzeszny@gmail.com>
Co-authored-by: chromiumboy <50505512+chromiumboy@users.noreply.github.com>
Co-authored-by: Radezolid <snappednexus@gmail.com>
Co-authored-by: Kiri1674 <107365596+Kiri-Yoshikage@users.noreply.github.com>
Co-authored-by: kaiserbirch <150971100+kaiserbirch@users.noreply.github.com>
Co-authored-by: Franz - Josef Björck <kaiserbirch@proton.me>
Co-authored-by: Wolfkey-SomeoneElseTookMyUsername <wolfkey75@gmail.com>
Co-authored-by: TGRCDev <tgrc@tgrc.dev>
Co-authored-by: OnyxTheBrave <131422822+OnyxTheBrave@users.noreply.github.com>
Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>
Co-authored-by: SyaoranFox <99053675+SyaoranFox@users.noreply.github.com>
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: qrwas <aleksandr.vernigora93@gmail.com>
Co-authored-by: UpAndLeaves <92269094+Alpha-Two@users.noreply.github.com>
Co-authored-by: Centronias <me@centronias.com>
Co-authored-by: Tiniest Shark <head.rebel@yahoo.com>
Co-authored-by: KingFroozy <140668342+KingFroozy@users.noreply.github.com>
* Delta confirmed monarch of sloggery
* Do a dirty, rotten web edit
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Remove some BUI boilerplate
- The disposals overrides got removed due to the helper method handling it.
- Replace window creation with CreateWindow helper.
- Fixed some stinky code which would cause exceptions.
* More
* moar
* weh
* done
* More BUIs
* More updates
* weh
* moar
* look who it is
* weh
* merge
* weh
* fixes
* Change prying system and pryunpoweredcomp to allow for custom time modifiers
This will be useful if I go the route of making firelocks pryable when
unpowered instead of just being able to open and close instantly when
unpowered.
* Make firelocks properly predicted
Shared system made. Since atmos checks can only be done on the server we
just have it set relevant bools on the component and then dirty it.
Ditched atmos checks on trying to open, they now only happen whenever
firelocks are updated.
* Make firelocks pryable without a crowbar
While this usually would only allow you to do this when a door is
unpowered, firelocks do not have the airlock component which actually
does that check. As such firelocks will always allow you to pry them
open/closed by hand.
* Clean up System. Change update interval to be based on ticks. Move as much as possible to shared
* Make firelocks unable to emergency close for 2 seconds after being pried open
* Clean up
* More cleanup
* Reorganize SharedFirelockSystem methods to match Initialize order
---------
Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
* Add door electronics configuration menu
* Use file-scoped namespaces
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Open door electronics configuration menu only with network configurator
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Doors will now try to move their AccessReaderComponent to their door electronics when the map is initialized
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Make the access list in the id card computer a separate control
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Fix merge conflict
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Remove DoorElectronics tag
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Integrate doors with #17927
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Move door electornics ui stuff to the right place
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Some review fixes
Signed-off-by: c4llv07e <kseandi@gmail.com>
* More fixes
Signed-off-by: c4llv07e <kseandi@gmail.com>
* review fix
Signed-off-by: c4llv07e <kseandi@gmail.com>
* move all accesses from airlock prototypes to door electronics
Signed-off-by: c4llv07e <kseandi@gmail.com>
* rework door electronics config access list
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Remove Linq from the door electronics user interface
* [WIP] Add EntityWhitelist to the activatable ui component
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Better interaction system
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Refactor
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Fix some door electronics not working without AccessReaderComponent
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Move AccessReaderComponent update code to the AccessReaderSystem
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Remove unnecesary newlines in the door access prototypes
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Remove unused variables in access level control
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Remove unnecessary method from the door electronics configuration menu
Signed-off-by: c4llv07e <kseandi@gmail.com>
* [WIP] change access type from string to ProtoId<AccessLevelPrototype>
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Remove unused methods
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Newline fix
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Restored to a functional state
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Fix access configurator not working with door electronics AccessReaderComponent
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Replace all string access fields with ProtoId
Signed-off-by: c4llv07e <kseandi@gmail.com>
* move access level control initialization into Populate method
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Review
---------
Signed-off-by: c4llv07e <kseandi@gmail.com>
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
(cherry picked from commit 64bb8dbdd50e0b1e5744e1eb0cc6f24bda959ade)
* remove deprecated entity coordinate extension functions. Reduces warning count by approximately 50
* final toCoords Removed
* Remove all unused variables and dead code paths
* remove always true variable, should be a cvar or something instead
* remove superfluous variables from tests
(cherry picked from commit 59e46aab93ca38f8d57fcad4e3a2c893737d9ad4)
* Use new Subs.CVar helper
Removes manual config OnValueChanged calls, removes need to remember to manually unsubscribe.
This both reduces boilerplate and fixes many issues where subscriptions weren't removed on entity system shutdown.
* Fix a bunch of warnings
* More warning fixes
* Use new DateTime serializer to get rid of ISerializationHooks in changelog code.
* Get rid of some more ISerializationHooks for enums
* And a little more
* Apply suggestions from code review
Co-authored-by: 0x6273 <0x40@keemail.me>
---------
Co-authored-by: 0x6273 <0x40@keemail.me>
(cherry picked from commit 68ce53ae17985876d6d112b764b2144964a9f42e)
Winkarst-cpu
Pieter-Jan Briers
Vanessa
Minerva
Tayrtahn
deltanedas
ShadowCommander
Hannah Giovanna Dawson
eoineoineoin
metalgearsloth
Nemanja
nikthechampiongr
c4llv07e
Jake Huxell
themias
778b
DrSmugleaf
Debug
Tom Leys
Kara
Leon Friedrich
TemporalOroboros
0x6273
TekuNut
Andreas Kämper
Visne
keronshb
Alex Evgrashin
Joosep Jääger
Fishfish458
WlarusFromDaSpace
Vera Aguilera Puerto