Commit Graph

98 Commits

Author SHA1 Message Date
Tayrtahn 11eff87687
Code cleanup: Dirty(Comp) (#26238)
* Replaced uses of Dirty(Component) with Dirty(Uid, Component)
Modified some systems (notably pulling-related) to use uids.

* Missed a few

* Revert changes to pulling

* No

(cherry picked from commit 4a83c365858830e3b2ff2b94fff501256422c20e)
2024-03-24 00:04:13 +01:00
nikthechampiongr ad5628777b
Simplify DoAfterArgs behavior for movement and distance checks (#25226)
* Merge BreakOnWeightlessMove and BreakOnMove. Provide different theshold for weightless movement.

* Adjust WeightlessMovementThresholds. Put a thing I forgot to put in the doafterargs.

* Make DoAfterArgs only use OnMove to determine whether to check for
movement and MoveThreshold to determine the threshold regardless of
weightlessness. Gave DistanceThreshold a default value which will always
be checked now.

* Fix issue introduced by merge.

* Use interaction system for determining whether a distance is within range

* Fix incorrect doafter args introduced by previous merge.
Forgor to commit these.

* Exorcise ghost.

The execution system should have been deleted when I merged previously.
For a reason I cannot comprehend it came back, but only the execution
system.

* Exorcise ghost Pt. 2

* Allow for movement check to be overriden in zero g and adjust doafter args where needed.

You can now override checking for movement in zero g with the BreakOnWeightlessMove bool. By default it will check.
The following doafters were made to ignore the movement check in zero g:
- Healing yourself with healing items,
- Removing embedded projectiles,
- Using tools like welders and crowbars

* Adjust distance for cuffing/uncuffing to work. Make injections not break on weightless movement.

* Fix evil incorrect and uneeded comments

(cherry picked from commit 362d56981fd7654f6ebec36f16cc8fabdd04b6a7)
2024-03-24 00:03:28 +01:00
Pieter-Jan Briers e7a3b82a8d
Use new ComponentPauseGenerator (#25183)
Also includes some (non critical) changes to the solution file to re-organize the Roslyn components.

(cherry picked from commit e00f74505c62310bd15aeaba8d6530f648397074)
2024-03-07 00:57:05 +01:00
Pieter-Jan Briers 8cdd3d1cb7
Fix disposals bins not automatically flushing after an object is inserted (#25233)
Fix disposals bins not automatically flushing after an object is inserted.

Because of Spaghetti Code™️, AfterInsert() in DisposalUnitSystem still handles insertion itself. Except in all cases except drag/drop insert, the object is already inserted so this check fails and the remaining logic doesn't happen anymore. Fixed now.

(cherry picked from commit 571d4f735888343ca3ba90eaea0908257095cdb9)
2024-02-18 23:13:35 +01:00
TemporalOroboros aebae6fab7
Content ecs containers (#22484)
(cherry picked from commit 7a77d6d5dd73a34be238fdebc284da5bc2917c67)
2024-01-22 18:47:55 +01:00
zero dacd620ca7 Add sounds when inserting/missing into a disposal (#22077) 2023-12-02 20:35:40 +01:00
Leon Friedrich 99f9583a3e Adds a new `AtmosphereSystem.GetTileMixture()` override (#21804) 2023-12-02 20:26:02 +01:00
Leon Friedrich 1465c02a77 Move ActorComponent to shared (#21293) 2023-10-31 19:12:44 +01:00
I.K 22dc5f9a3e Make forcing others into disposals take longer and more apparent (#20687) 2023-10-08 19:53:53 +02:00
metalgearsloth c9648da984 Content update for NetEntities (#18935) 2023-09-27 21:59:12 +02:00
metalgearsloth 4d1c3ae66a
Revert "Remove IContainer and move functions to the container system.… (#19975) 2023-09-10 21:46:36 +10:00
Leon Friedrich b45e53603d
Remove IContainer and move functions to the container system. (#19834) 2023-09-10 12:16:37 +10:00
deltanedas 4b5228e10d
disposal emag fix and refactoring (#19790)
Co-authored-by: deltanedas <@deltanedas:kde.org>
2023-09-05 00:11:34 +10:00
faint 0b9b4f6532
Fix dumping into disposals (#19736) 2023-09-02 00:02:35 -04:00
metalgearsloth b08967b752
Remove disposals compref (#19558)
This one was relatively painless.
2023-08-30 19:08:23 -06:00
Slava0135 e6159d8581
Damage other on hit player feedback (#18539) 2023-08-02 19:30:04 +10:00
metalgearsloth 3eb93988e5
Disposals refactor (#17803) 2023-07-06 13:39:34 +10:00
TemporalOroboros 9849737e5a
Cleans up warnings in disposals (#17419) 2023-06-22 00:31:19 +10:00
metalgearsloth ae01618874
Revert "Revert "Replace `ResourcePath` with `ResPath` (#15308)" (#155… (#15566) 2023-04-20 20:16:01 +10:00
metalgearsloth acf79a8209
Revert "Replace `ResourcePath` with `ResPath` (#15308)" (#15551) 2023-04-20 11:43:54 +10:00
Ygg01 71f358a027
Replace `ResourcePath` with `ResPath` (#15308) 2023-04-19 23:39:17 +10:00
DrSmugleaf b947856431
Remove hands component reference (#15197) 2023-04-07 11:21:12 -07:00
Leon Friedrich 19277a2276
More DoAfter Changes (#14609)
* DoAfters

* Compact Clone()

* Fix mice and cuffables

* Try generalize attempt events

* moves climbabledoafter event to shared, fixes issue with climbable target

* Fix merge (cuffing)

* Make all events netserializable

* handful of doafter events moved

* moves the rest of the events to their respective shared folders

* Changes all mentions of server doafter to shared

* stop stripping cancellation

* fix merge errors

* draw paused doafters

* handle unpausing

* missing netserializable ref

* removes break on stun reference

* removes cuffing state reference

* Fix tools

* Fix door prying.

* Fix construction

* Fix dumping

* Fix wielding assert

* fix rev

* Fix test

* more test fixes

---------

Co-authored-by: keronshb <keronshb@live.com>
2023-04-02 21:13:48 -04:00
deltanedas 52af530d61
emag disposal units to disable pressure requirement (#14630) 2023-03-23 10:55:49 -04:00
Leon Friedrich 2f88173730
DoAfter and other bugfixes (#14669) 2023-03-15 13:05:53 +11:00
metalgearsloth 44fb8a9e2d
Fix rsi sprite access for verbs (#14284) 2023-02-26 18:48:57 +11:00
keronshb 9ebb452a3c
DoAfter Refactor (#13225)
Co-authored-by: DrSmugleaf <drsmugleaf@gmail.com>
2023-02-25 01:01:25 +01:00
metalgearsloth c8f89eca60
ECS dragdrop (#12973)
* ECS dragdrop

No more excuses.

* AAAAAAAAAAAAAA

* kry

* events

* aaaaaaaaaa

* HUH

* Fix stripping

* aaaaaa

* spoike

* asease

* fix table vaulting

* ded

* rebiew

* aaaaaaaaaaaaa

* drag

* aeaeae

* weh
2023-02-13 13:29:34 +00:00
eoineoineoin be94048932
Convert DisposalUnitVisualizer to VisualizerSystem (#13637) 2023-02-03 18:26:50 -04:00
Rane 80d4dc430d
Generic power switch component (#11999) 2023-01-20 08:05:54 -08:00
Chief-Engineer 0907989e94
Add DisposalUnit logs (#13309) 2023-01-03 22:45:35 -08:00
Leon Friedrich 881a2b2ece
PopupSystem public methods rejig (#12830) 2022-12-19 08:41:47 +11:00
metalgearsloth 6c76061887
Content changes for mapgrid kill (#12567) 2022-11-22 13:12:04 +11:00
metalgearsloth c0abea8047
Content side for removing IMap / IMapGrid comps (#12357) 2022-11-04 10:12:25 +11:00
Leon Friedrich 1e97d6defb
Fix disposal unit termination (#12266) 2022-10-28 16:59:01 -05:00
Leon Friedrich c0b657ca18
Remove InteractedWithEvent and friends. (#11939) 2022-10-26 12:15:48 +11:00
metalgearsloth 0b38589728
Raise power events by ref and not broadcast (#11923)
Also some other minor stuff.
2022-10-14 23:08:15 -05:00
Morb a210373972
Localize disposal unit state (#11725) 2022-10-07 01:53:36 +11:00
Mervill 47e1e991b5
Change where the "missed" popup comes from when throwing things into the disposal unit. (#11609) 2022-09-29 12:50:31 -07:00
Mervill 03484d831a
User feedback for when you miss throwing something in disposals (#11426)
* user feedback for when you miss throwing something in disposals

* Update missed message

Co-authored-by: theashtronaut <112137107+theashtronaut@users.noreply.github.com>

* Update Content.Server/Disposal/Unit/EntitySystems/DisposalUnitSystem.cs

Co-authored-by: Kara <lunarautomaton6@gmail.com>

* missing nullable check

Co-authored-by: theashtronaut <112137107+theashtronaut@users.noreply.github.com>
Co-authored-by: Kara <lunarautomaton6@gmail.com>
2022-09-26 14:42:49 -05:00
metalgearsloth 78a4ab6eb2
Update for collision events by-ref (#10933) 2022-09-14 17:26:26 +10:00
metalgearsloth 8415f08560
Update disposals code standards (#11076)
Co-authored-by: Kara <lunarautomaton6@gmail.com>
2022-09-10 23:50:59 -07:00
Leon Friedrich 93584f21db
Add entity prototype save test (#10274) 2022-08-17 10:47:58 +10:00
Leon Friedrich 24b21c80f2
Remove duplicate disposal unit verb (#10607)
* Remove duplicate verb

* also fix missing loc string
2022-08-14 20:58:58 -07:00
Julian Giebel b2436c22a7
Adds disposal mailing units (again) (#7630) 2022-08-13 22:57:25 -07:00
Visne 58769634c7
Fix a bunch of compiler warnings (#10518) 2022-08-13 22:28:34 -07:00
Leon Friedrich cfec035b9d
Fix disposal entry (#10230) 2022-08-02 08:35:34 +10:00
wrexbe b5de805083
Mouse disposal nullable patch (#10185) 2022-07-30 21:23:46 -07:00
Lucas 8000d31a62
No handed mobs now cant insert other mobs on disposal (#9993)
* fix mouse now cant insert other mobs on disposal, but still can jump inside

* Apply suggestions from code review

Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>

* using popupSystem depedency and better fluent use

* change where the message You don't have hands are

* Caution popup

Co-authored-by: zero <ribeirolucasdev@gmail.com>
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
2022-07-30 21:17:30 -07:00
Leon Friedrich bae540ab2f
Fix gas tank and other hand-interaction bugs (#9700) 2022-07-30 19:56:26 -07:00