Commit Graph

7857 Commits

Author SHA1 Message Date
Nemanja be7ffd89e2
AME Deconstruction Changes (#29317)
* AME deconstruction complexity

* review

---------

Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2024-06-22 14:15:21 +10:00
nikthechampiongr 76a65c8e43
Implement BlacklistedRange exempt flag (#29258)
* Implement a new kind of ip range ban that only applies to new players

* Put determining whether a player record exists to its own function

* Make BlacklistedRange bans get bypassed by any ban exemption

* Stop trying to get another DbGuard while already having one

This does break with convention on the functions in that area but
considering the use of this function it's probably fine?
I could alternatively just move the place it's called from.

Also I was suppossed to wait for tests to finish locally just to be
sure, but nah. I am pushing this now
2024-06-21 14:06:07 +02:00
TsjipTsjip 949a837720
Ghostrole rule updates (#29249)
* First batch of ghostrole rule updates

* Second pass

* Re-word free agent

* Apply review comments

Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>

* You heard it here first folks

God rules are weird to write.

Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>

* Honkbot -> Free Agent

Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>

* Mimebot -> Free Agent

Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>

* Jonkbot -> Free Agent

Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>

* Softer blue

---------

Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>
2024-06-21 04:41:54 -05:00
slarticodefast d62dddcfcb
fix initial infected icons and add a briefing to the character menu (#29259) 2024-06-21 15:42:17 +10:00
Tayrtahn 880fef507d
Replace BlockSolutionAccessComponent with an attempt event (#26988)
* BlockSolutionAccessComponent now only blocks one specified solution.

* Significant overhaul
Separated spilling when worn functionality into its own component/system.
Removed BlockSolutionAccessComponent.
Added an event for solution access.
2024-06-21 13:04:02 +10:00
Tayrtahn afc800274c
Fix null exceptions in SurveillanceCameraMonitorSystem (#29275)
* Add IsNullOrEmpty checks before indexing KnownSubnets

* actor
2024-06-21 10:17:16 +10:00
Pieter-Jan Briers c33644532d
Rate limit ahelps (#29219)
* Make chat rate limits a general-purpose system.

Intending to use this with ahelps next.

* Rate limt ahelps

Fixes #28762

* Review comments
2024-06-21 00:13:02 +02:00
Mr. 27 8c9fcd4ca7
Fix ERT becoming sleeper agents and add sleeper agent preferences (#27817)
* b

* Update antags.ftl

* m

* ok

* Update events.yml

* antag

* a

* Create InitialInfectedExemptComponent.cs

* Delete InitialInfectedExemptComponent.cs

* yes

* Delete InitialInfectedExemptComponent.cs

* Create AntagImmuneComponent.cs
2024-06-20 21:12:58 +10:00
Alice "Arimah" Heurlin 2b92ec79f7
Prevent fly-by fixture from powering containment field generator (#29225)
* Prevent fly-by fixture from powering containment field generator

* Update according to review
2024-06-19 19:51:07 -04:00
Leon Friedrich fa3c89a521
Partial buckling refactor (#29031)
* partial buckling refactor

* git mv test

* change test namespace

* git mv test

* Update test namespace

* Add pulling test

* Network BuckleTime

* Add two more tests

* smelly
2024-06-20 01:14:18 +10:00
Tayrtahn e33f0341ad
Code cleanup: radio jammer (#29052)
* Code cleanup for radio jammer

* More Entity<T> for the people, and fix an accidental variable reuse
2024-06-20 01:13:40 +10:00
Tayrtahn 024521b66b
Add prediction for Tech Disks, cleanup (#29061)
* Add prediction for Tech Disks, cleanup

* Remove IsServer check in OnMapInit

* Use HashSet for techs, remove LINQ
2024-06-20 01:04:30 +10:00
Truoizys fc40cd79fb
Fixed cartridges installing more than once (#29187)
* fixed cartridges installing more than once

* replaced prototypes with CartridgeComponent

* relocated checks from InstallProgram to InstallCartridge
2024-06-19 15:21:05 +02:00
Rouge2t7 c8de4ec397
PullingController cooldown change (#29177)
* Revert "Automatic changelog update"

This reverts commit 3358aef40f.

* Revert "Revert "Automatic changelog update""

This reverts commit 3d0b6a7ade06ec555d4f6df3f39134b139e5247c.

* Removal of the throw cooldown as it felt sluggish and unresponsive before.
2024-06-19 10:29:47 +10:00
deltanedas 0910983c4b
unhardcode thief MaxSelectedSets (#29175)
* unhardcode thief MaxSelectedSets

* we do a little copy paste :trollface:

* :trollface:

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-06-19 10:29:06 +10:00
osjarw 707f1f4981
Fix air alarms (#29172)
Broken by #28272
2024-06-18 16:20:57 -08:00
metalgearsloth b0b76a1133
Replace StationRandomTransform (#29149)
* Revert "Rotate and Offset station CCVar nuke (#26175)"

This reverts commit 44b20f60ff.

# Conflicts:
#	Content.Server/Station/Systems/StationSystem.cs
#	Resources/Prototypes/Maps/europa.yml

* Fix

* Review
2024-06-18 23:27:34 +10:00
metalgearsloth 65821c96f4
Fix conveyor mispredicts (#28157)
* Fix conveyor mispredicts

Instead of tracking active conveyors we instead track the conveyed entities. This also handles things like stacking conveyors more gracely.

* Fix ActiveConveyor

* Fix lerping
2024-06-18 22:11:36 +10:00
DrSmugleaf bd0631c45b
Add cvar to disable round end pvs overrides (#29151) 2024-06-18 22:00:29 +10:00
Ed a1e66cfbb4
clean up weather systems (#28792)
* clean up weather systems

* Update WeatherComponent.cs

* Update SharedWeatherSystem.cs

* some fix

* Update SharedWeatherSystem.cs

* Update WeatherComponent.cs

* Update WeatherComponent.cs

* revert autoPause

* Update SharedWeatherSystem.cs
2024-06-18 20:27:34 +10:00
Tayrtahn e5a85e2a13
Make wearing an Ushanka also apply accent to your name (#29111) 2024-06-17 14:03:55 -04:00
Nemanja 4aa74c5e1d
improve meteor spawning (#29057) 2024-06-17 01:20:47 -04:00
deltanedas c332677971
remove robotics console emag checking, make it a bit fairer (#27876) 2024-06-16 23:30:10 -04:00
Partmedia 388d372ee8
Fix incorrect use of atmos dt (#29112) 2024-06-16 21:13:32 -04:00
Tayrtahn 89a9f07c3a
Add a system for modifying entity names without causing conflicts (#27863) 2024-06-16 15:38:53 -04:00
Nemanja 5e50bd83d6
Missing meteor presets (#29044)
* add meteors into missing game presets

* changes for real

* implement code

* this too
2024-06-16 21:37:43 +02:00
Leon Friedrich f121946b12
Fix RotateWhilePulling not working (#29032) 2024-06-16 21:30:35 +10:00
DrSmugleaf 4954b6d79e
Add cvar to disable ghosting killing your crit mob (#28945)
* Add cvar to disable ghosting killing your crit mob

* Update Content.Shared/CCVar/CCVars.cs

Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
2024-06-16 21:21:16 +10:00
Nemanja dfe9d5264c
Slightly speed up borgsystem module check (#29070) 2024-06-15 21:32:01 -04:00
Nemanja c2f88b2e17
fix exclusive borg module bug (#29038) 2024-06-15 21:10:21 -04:00
Nemanja c063347ed6
fix meteor announcement color (#29058) 2024-06-15 19:24:15 -04:00
icekot8 a2affe3d00
add 👷 JobCondition system for reagents (#29023)
* hell 💀

* you're right

i'm dumb

* use the beautiful protoid and or in localization 🥩

* 🙏
2024-06-15 17:36:25 -04:00
Partmedia 6835e6b4aa
Adjust TEG efficiency curve, remove heat transfer limit (#29050)
The TEG used to limit hot-cold energy transfer based on actual power drawn, and had maximum efficiency at whatever temperature difference. This PR adjusts the hot-cold energy transfer to be uncapped, "venting" the excess heat that is not used to generate power, and adds an efficiency curve that limits efficiency at low thermal temperatures.

People have been cheesing the TEG by hooking up the hot end to the CO2 miner (which produces infinite, room-temperature gas) and the cold end to a space radiator.

With this change, you will actually need to set up a burn chamber in order to get appreciable power out of the TEG (see below).

If you build a gas holding chamber, you will have to throttle the gas flowing into the TEG instead of constantly cycling the gas through over and over again.
2024-06-15 14:05:57 -07:00
BombasterDS 81e41f8e8d
Mannequin (#29004)
* Mannequin

* rsi license fix

* damage container fix

* container fix

hope this works

* layers fix + appearance comp (mb it help?)

* maybe fixed?

* one day it will work...

* can't even understand why test failing... (maybe fix?)

* last try?
2024-06-15 13:50:55 -04:00
ShadowCommander 789453adf0
Make firelock warning light not require power and add a PointLight (#29024)
* Add a PointLight to firelocks when warnings are active

* Remove power requirement for lights
2024-06-15 11:17:16 -04:00
TsjipTsjip 71eb4d9178
CVarify meteor behavior (#29030)
* CVarify meteor behavior

* Cache value to reduce CVar calls, hook into OnValueChanged

* _cfg is still null at construction time, fixed by just making it set up on Started instead

* Invoke immediately! Learning more every step of the way.

* Move cached value initialisation to Initialize call

* Add explicit supercall
2024-06-15 10:03:20 -04:00
Nemanja 31d1d3b6e7
fix borgs getting deleted by salvage magnets (#29006) 2024-06-15 23:19:23 +10:00
metalgearsloth 8f12e90b90
Don't use invalid defaults for loadouts (#28740)
* Don't use invalid defaults for loadouts

At the time it made more sense but now with species specific stuff it's better to have nothing.

* Loadout SetDefault only applies valid loadouts
2024-06-15 16:53:42 +10:00
AJCM-git c339773b5f
Fixes the ShowRulesCommand and the client not syncing rules correctly (#28752) 2024-06-15 00:41:25 -04:00
Nemanja 748e5831e8
Add moon boots (#29009) 2024-06-14 20:43:23 -07:00
Nemanja f136657b38
Revamped Meteor Swarm (#28974)
* meteor code and balanced values

* Meteor Swarms

* Update meteors.yml

* Update meteors.yml

* HOO! (fix overkill bug and buff space dust)

* undo BloodstreamComponent.cs changes

* DamageDistribution -> DamageTypes

* part 2.
2024-06-14 20:38:43 -07:00
Robert V 48f90322f2
Allow vending machines to be repaired (#28920)
Vending machines can be repaired
2024-06-14 23:13:52 -04:00
Verm 41a081d5ef
Donk co. microwave + microwave tweaks (#28951)
* THE syndie microwave

* Always burn to explode microwave when copying

* Make it so copying ids stop when the microwave is goign to explode

* Made explosion destroy the board and spit out the machine parts

* Move logic is MicrowaveSystem, make metal cooking use the same logic

* Fix passing the wrong malfunction time

* Shuttle cannot escape aggressive branding

* Always make it explode with an id

* Forgot to invert bool, move it after fry chance
2024-06-14 23:00:00 -04:00
Plykiya 835d1dd153
Prevent borgs from getting duplicate modules (#28943)
* Prevent borgs from getting duplicate modules

* outta the loop

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-06-14 22:58:30 -04:00
Zonespace 3cd740c32b
Replaces reagent-effect-guidebook-missing with more descriptive guidebook entries (#28817)
removes `reagent-effect-guidebook-missing`

Co-authored-by: John Doe <johndoe@gmail.com>
2024-06-14 22:43:36 -04:00
Zonespace 6d71ec1b14
Non-uplink PDAs no longer can have TC inserted into them (#28985)
* PDAs no longer can have TC inserted into them

* far better way of doing this

---------

Co-authored-by: John Doe <johndoe@gmail.com>
2024-06-14 11:24:40 -04:00
Hannah Giovanna Dawson 3b3163c4f4
SS-28662 Add cvars to support forcing people to departures and making those at departures invincible (#28765)
* SS-28662 Add cvar to force spawn everyone at departures

This cvar means everyone must spawn at departures. This
could be handy for an admin event? But mostly it's so the
tutorial departures terminal can be seen by all newbies on
gateway servers.

* Small fix to ArrivalsSystem flow

* Remove incorrect todo

* Add godmode arrivals cvar
2024-06-14 04:15:42 -07:00
Tayrtahn 6c343ddae2
Move SleepingSystem to Shared & cleanup (#28672)
* Move SleepingSystem to Shared & cleanup

* Remove empty OnShutdown handler
2024-06-14 12:15:29 +10:00
Cojoke 57858cd6a5
Lasers passover objects like projectiles unless the target is clicked on (#28768)
* uh...

* fix

* alright, there we go

* Revert "alright, there we go"

This reverts commit 448180bfa58cc24c42a4d59ef34c017b9941f37b.

* Make lasers not hit certain objects and lying mobs unless clicked on

* comment

* Update Content.Server/Weapons/Ranged/Systems/GunSystem.cs

* an l vanished?

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
2024-06-14 12:04:45 +10:00
osjarw ad3f1f77b7
Nodescanner now works with right click (#26873) 2024-06-13 22:01:32 -04:00