Commit Graph

7324 Commits

Author SHA1 Message Date
metalgearsloth cd8b5b96b5
Optimise DecalOverlay (#25266)
ChunkSize is still 32 so doesn't cut down on heaps of decals atm though we avoid passing many decals to drawing with the coordinates bounds check now.

(cherry picked from commit d8e5f5c24b88bf8096ddaec11e80f1af2953637b)
2024-03-05 09:49:43 +01:00
Pieter-Jan Briers 905bb83a2d
Make department / job list sorting consistent. (#25486)
* Make department / job list sorting consistent.

This makes late join, crew manifest and character profile all apply consistent sorting for jobs and departments.

We use the already-defined weights for departments (so command, then sec, then station specific, then just sort by prototype ID). Jobs also use weight (so heads are always at the top) then prototype ID, then character name (for manifest).

Removed the crewmanifest.ordering CVar as doing it via prototype weight is just easier, and that CVar was already a mess anyways.

* Fix jittery job icons in lists.

They were set to KeepCentered in TextureRect. This has issues because the allocated space is actually an odd number of pixels, so it tries to position the draw at a half pixel offset.

Now, yes, fixing this in TextureRect would make much more sense, but get off my back. (Ok seriously we need better helper functions for doing that in the engine. Don't wanna deal with that right now and I already have this patch made.)

Instead I'm just gonna fix the issue by using VerticalAlignment in all these places instead which ends up doing exactly the same thing YIPPEE.

Also gave a margin next to the icon on the crew manifest. Margins people!

(cherry picked from commit 715794dd414c5d4b794cd6f2201983ecbc5d4f17)
2024-03-05 09:49:19 +01:00
Pieter-Jan Briers 324ea7fbc8
Switch project files to C# 12. (#25487)
Just unlocks new language features like primary constructors.

(cherry picked from commit b1de6dd6017f4f56045df409db59fb7d303bde5d)
2024-03-05 09:49:02 +01:00
Tayrtahn 164c06f6ed
Add prediction to Openable (#25477)
* Fix formatting problem with FullOpened

* Moved to Shared and networked

* Revert "Fix formatting problem with FullOpened"

This reverts commit f8353403da830a4402bdd457bcf24a2432a5f566.

(cherry picked from commit 381bb9020aeba82e9cad111c77c34bee29d52c68)
2024-03-05 09:48:52 +01:00
Tayrtahn ef6958e1cf
Fix examine text bug for Openable Drinkables (#25478)
Break up Opened/Closed and fill level onto separate lines

(cherry picked from commit 146c7b272d9af2ff68e110211d88c9c3c38b5fd9)
2024-03-05 09:48:49 +01:00
Nemanja 384c060ea5
Predict doors and airlocks (#25419)
* predict doors and airlocks

* prying, too

* ack

* eek

(cherry picked from commit ce0a51fc29675b3b0afb90296b6a8ce90c3f9cd3)
2024-03-05 09:48:41 +01:00
HoofedEar e96254fb4c
Add RequiresGrid component (#23394)
* saving working code

* add checks for deletion

(cherry picked from commit 487dd113b05aa54a8683f6be980a60f3e431d226)
2024-03-05 09:48:10 +01:00
beck-thompson 67acf16d1a
Changed radio jammer wattage from 6 -> 2 (#25432)
Changed wattage from 6 -> 2

(cherry picked from commit 48213ebb65c149bdbe1f259539f5efd38fe63998)
2024-03-05 09:46:25 +01:00
genderGeometries 6d902b62a6
Crop harvest int cast fix (#25453)
* deleted int cast on solution amount

* deleted int cast on solution amount for real

(cherry picked from commit 1360d57eea3938ee61899e03f0b5e2aefd425ea9)
2024-03-05 09:46:14 +01:00
metalgearsloth 9516ab5794
Fix bwoink sounds (#25441)
* Fix bwoink sounds

Didn't get a chance to test with 2 clients as I'm about to sleep but otherwise I'll check tomorrow.

* a

(cherry picked from commit 79c6385ca7d1b42263e154dc1dad4fe912ac0bbf)
2024-03-05 09:45:58 +01:00
keronshb fd4445253d
Moves muted to shared (#25374)
* moves muted to shared

* fixes usings

* Update MutedComponent.cs

funny webedit

* Update MutedComponent.cs

oops using statement webedit

(cherry picked from commit 046c874daeb60609d8880fe27617836d37de1a94)
2024-03-05 09:45:27 +01:00
Fildrance d0a55859df
fix: #25102 cryo pod now uses health-analyzer system to update body state in UI (#25109)
* fix: cryo pod now uses health-analyzer system to update body state in UI

* refactor: use EntityEventRefHandler instead ComponentEventRefHandler in CryoPodComponent subscribe on EntRemovedFromContainerMessage

---------

Co-authored-by: pa.pecherskij <pa.pecherskij@interfax.ru>
(cherry picked from commit ef849a0156e52d93c3a3c3b03f30858b33400292)
2024-03-05 09:44:53 +01:00
Krunklehorn 9338e0d12b
Voice trigger fixes, death acidifier typos (#24941)
* Fixed length check, added attempt event, added popups on failure

* Fixed file name typo, fixed description

* Converted to else-if

(cherry picked from commit f29575f43f3274ff993aafd727bc23341c9a366f)
2024-03-05 09:44:49 +01:00
dffdff2423 6757f63a90
Add option for admins to disable bwoink (#25008)
* Add option for admins to disable bwoink

In a vain attempt to get people to ahelp more, provide the possibility
for admins to not play the bwoink sound if they don't want to scare the
player.

* Add silent indicator to discord relay

* Use string interpolation

(cherry picked from commit a3c93b0bd7478c0f75daaa2f7d0bd8b88565b27e)
2024-03-05 09:43:40 +01:00
Debug 9822e6f6e1
Fix CarryingSystem 2024-03-05 09:42:54 +01:00
metalgearsloth 345cb0f96d
Remove contests (#25425)
- Not mentioned anywhere ingame.
- Stupid.

(cherry picked from commit 012e6e6c86e2637b6fa8788a59af4eb974e990b8)
2024-03-05 09:39:03 +01:00
Debug 9a246f9527
Remove drones, fix InnateToolSystem (#25372) 2024-03-05 09:34:57 +01:00
deltanedas 1d24249d49
make midround antag spawn code better (#919)
* kill shitcode

* give each midround antag its own spawn rule

* using

* break test real

* typographical error

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-03-02 23:27:13 +01:00
Guess-My-Name da049f789d
Psionic insulation and invisibility fix (#887)
* fix

* invis people can no longer see other invis people
2024-02-23 19:36:40 +01:00
VMSolidus 0f9414b5ea
Fix deep fryer divide by zero (#886)
Update DeepFryerSystem.cs
2024-02-22 04:55:58 +00:00
Guess-My-Name b9dd5eddb1
oracle wrong item message cooldown (#885)
no more oracle spam
2024-02-22 05:32:37 +01:00
Debug a0511fcfc0
Merge pull request #878 from DebugOk/25394
Early merge
2024-02-21 04:28:15 +01:00
Vasilis 0c95a1db1a
Add roundid to replay_final.yml (#25398)
oopsy i forgor

(cherry picked from commit 5170593e853ab074f4351281073e4da4e39324bd)
2024-02-21 04:08:52 +01:00
Pieter-Jan Briers 837272c745
Fix admin notes and database time nonsense. (#25280)
God bloody christ. There's like three layers of shit here.

So firstly, apparently we were still using Npgsql.EnableLegacyTimestampBehavior. This means that time values (which are stored UTC in the database) were converted to local time when read out. This meant they were passed around as kind Local to clients (instead of UTC in the case of SQLite). That's easy enough to fix just turn off the flag and fix the couple spots we're passing a local DateTime ez.

Oh but it turns out there's a DIFFERENT problem with SQLite: See SQLite we definitely store the DateTimes as UTC, but when Microsoft.Data.Sqlite reads them it reads them as Kind Unspecified instead of Utc.

Why are these so bad? Because the admin notes system passes DateTime instances from EF Core straight to the rest of the game code. And that means it's a PAIN IN THE ASS to run the necessary conversions to fix the DateTime instances. GOD DAMNIT now I have to make a whole new set of "Record" entities so we avoid leaking the EF Core model entities. WAAAAAAA.

Fixes #19897

(cherry picked from commit 2e6eaa45c57c7f5ba561d1fb1ef6712d2432a8fa)
2024-02-21 04:03:44 +01:00
Vasilis f1bacc31d2
Hotfix: Set round end information for replays back to null on round start instead of round end (#25394)
* Hotfix

* I dont think i need this now

(cherry picked from commit 2548b13abf882a33ef3bf98c79ddaf91eddfa956)
2024-02-21 04:03:40 +01:00
Debug 9af8726a1e
Wait no it was correct
Signed-off-by: Debug <49997488+DebugOk@users.noreply.github.com>
2024-02-21 00:41:06 +01:00
Debug 4e080593aa
Incorrect math resulting in false negative
Webedit ops

Signed-off-by: Debug <49997488+DebugOk@users.noreply.github.com>
2024-02-21 00:34:36 +01:00
Debug bc0baa6797
Make periapsis only have 10 non-whitelisted slots, and make whitelist not shit (#874)
Whitelist
2024-02-20 20:46:17 +01:00
ArchPigeon 783284ab0f
Stop wagging tails on crit (#25323)
* Add Flammable Touch Reaction for liquid tritium

* Stop tail wagging action on crit

* Revert "Add Flammable Touch Reaction for liquid tritium"

This reverts commit 41be57b058a0cdee0cecfc51eb1c4a25631e62f3.

(cherry picked from commit e8eddf57f64daca19054f0e3dfbe73dd6af8c342)
2024-02-18 23:39:38 +01:00
Pieter-Jan Briers 5da6086a02
Add new "OptionsVisualizer" (#25128)
This is a visualizer somewhat similar to the Generic. It allows configuring appearance info based on specific CVars the user has set. This allows YAML to easily configure alternatives for accessibility CVars like reduced motion.

(cherry picked from commit 1ce21553152199e3d97a8d02c11922fb8db5fd52)
2024-02-18 23:39:23 +01:00
Vasilis df79ac49b9
Save round information into replay_final.yml (#23013)
* Save round information into the replay

* Add round end text too

* This is way better

* Get actual job

* oop

* OK THERE

* Fake line endings to make life easier

* I was told this yaml is legal

* I just realised this will make my life easier

* REVIEWS BABY IM A PROGRAMMER MOMMY

* Live pjb reaction

* Live pjb reaction 2

* Reviews 2

* Dont need this

* Please no more have mercy on my soul

* Oh frick

(cherry picked from commit cb999d23f4b15e1c182e1ae4bf2e414306822f89)
2024-02-18 23:36:10 +01:00
Flesh 194c9d7755
fixed the specific if statement called when plant age is under 0 (#25346)
(cherry picked from commit 5b485fedbd6f41ffb82343f1f6cbb7113ce6284f)
2024-02-18 23:36:02 +01:00
Plykiya afcae40a0a
Fix: Grenades don't make trigger sound (#25321)
* Fix: Grenades don't make trigger sound

* transform instead of trycomp transform

---------

Co-authored-by: Plykiya <plykiya@protonmail.com>
(cherry picked from commit 7d94cc719c4c7c6cbffbe4b7aad72f36ed689621)
2024-02-18 23:36:01 +01:00
Arendian c9a6019f97
Fix nymphs being deleted immediatly after spawning (#25344)
* nymphs now don't get deleted together with the body of the diona

* moved nymph system to server

(cherry picked from commit 9969bd25841b5162d80125c9a2fc000a94c3b558)
2024-02-18 23:35:48 +01:00
Flesh e44942d341
Change plant clipping mechanics (#25326)
Make seeds from clipped plants inherit the decreased health from parents.
Also require one growth stage before clipping.

(cherry picked from commit dab2c4884928eae42e5dbd16237d7b0624b86c68)
2024-02-18 23:35:46 +01:00
LankLTE e7d8f5e080
Diona Nymphs & Splitting (#24630)
* Porting & implementation

* Fix two stupid errors

* Human not humans

* fix audio path

* Fix test fails & update cooldown

* Work on reviews & test fail

* Rework nymph organ system.

* Make the nymph organs nospawn.

* IsDeadIC

(cherry picked from commit 407d4aed586a5143dc1dd0d31e7898f6df07a411)
2024-02-18 23:34:45 +01:00
Debug 93503d9fd1
WebP lobby images (#25184) 2024-02-18 23:32:45 +01:00
MilenVolf cb0fdb47d1
LockVisualizer (#25224)
* LockVisualizer

* Fix state

* Clean some code

* Make it component, fix tests fail

* Fix for StateUnlocked

Now it is possible to manually set the unlocked state and it will work!

* Optimize LockVisualizer, add check for unlocked state

* No todo I guess

(cherry picked from commit c7870882f6f956eea07cbb4738ae45c8805c8ce6)
2024-02-18 23:27:28 +01:00
Krunklehorn b1e1ec66ea
Add sfx for writing on paper (#25257)
* Initial commit

* Moved params to sound

* Removed type tag

* Removed null check

* Forced default

(cherry picked from commit 1de3f24f16733521d22543708a59e72a6b396c71)
2024-02-18 23:25:50 +01:00
Łukasz Mędrek dd92fe8786
Fix spawning glass shard for each glass sheet in stack (#25308)
* fix: SpawnEntitiesBehavior now works with stacks

Fixed the issue of SpawnEntitiesBehavior not executing multiple times on
entities with stack conponent.

Fixes #25287

* fix: reduced dictionary iterations

(cherry picked from commit 53270be66c9aca763b4bfc68e119d0692cd03fd7)
2024-02-18 23:17:54 +01:00
Pieter-Jan Briers e9975e23e8
Nuke fancification (#25297)
Actually use more icon states for deployed/armed/about to explode

Also unlit layer.

Also examine text

(cherry picked from commit 3a45d519dcc3679375b5239b6f1881cdd1a07344)
2024-02-18 23:17:22 +01:00
Pieter-Jan Briers 8cdd3d1cb7
Fix disposals bins not automatically flushing after an object is inserted (#25233)
Fix disposals bins not automatically flushing after an object is inserted.

Because of Spaghetti Code™️, AfterInsert() in DisposalUnitSystem still handles insertion itself. Except in all cases except drag/drop insert, the object is already inserted so this check fails and the remaining logic doesn't happen anymore. Fixed now.

(cherry picked from commit 571d4f735888343ca3ba90eaea0908257095cdb9)
2024-02-18 23:13:35 +01:00
nikthechampiongr a37bd5b2a7
Clarify stripping logs (#25190)
* Indicate whether pickpocketing is stealthy in logs, change :user to :actor, and clean up messages.

* Remove ugly whitespace

* Do the thing I should have done but didn't because I didn't want to think

* Fix spacing

(cherry picked from commit 82f5bf8121f6f018d8af6442a031b21f9d95cba7)
2024-02-18 23:13:34 +01:00
Jezithyr 53bd523984
Death acidifier fix (#25251)
(cherry picked from commit be29a054de37b54d7c0a09c75b6fded91374341a)
2024-02-18 23:13:32 +01:00
Plykiya 15d22b8315
Fix: Holosigns can be stored again (#25249)
* Holosigns can be stored again

* TryComp to HasComp

---------

Co-authored-by: Plykiya <plykiya@protonmail.com>
(cherry picked from commit d6139429ad59a4137c383044613364137a8a338b)
2024-02-18 23:13:18 +01:00
Menshin 7e6a8ef6e5
Allow thermomachines to exchange with air instead of inlet (#25247)
Add purely atmospheric heat exchange to the gas thermomachine component (in preparation for space heaters).

(cherry picked from commit ce4bd8568cba4d64fb19e80d3182e21f010a86c1)
2024-02-18 23:13:12 +01:00
brainfood1183 0b848034e9
Add French accent beret (#21430)
(cherry picked from commit e1805e04d43bc7c8cb240ebc1d1271fa229bcc62)
2024-02-18 23:12:00 +01:00
Krunklehorn 5a315ab91a
Fix spawn priority persistence on reconnect and restart (#25246)
Because of course I would forget one line

(cherry picked from commit 2f0c837816589b24b1548eafa278e28340577eb3)
2024-02-18 23:11:51 +01:00
Pieter-Jan Briers 1031a93942
Predict Injector (syringes), cleanup (#25235)
At least the mode/transfer amount logic. Actual transfer logic needs Bloodstream which I didn't wanna move into shared.

(cherry picked from commit 6d8be538c90cf4c3a6636e2f8b84631af457cd42)
2024-02-18 23:11:33 +01:00
Jessica M f5a0ac1688
Makes clumsy not delete guns (#25243)
clumsy no longer deletes guns

Co-authored-by: Jessica M <jessica@maybe.sh>
(cherry picked from commit d0c24f9aff574e4f929dff66c7dac4c167e51fb5)
2024-02-18 23:11:19 +01:00