Commit Graph

4970 Commits

Author SHA1 Message Date
Leon Friedrich 4d4782313f Fix PlantHolder interactions & InteractionSystem assert (#32874) 2024-10-24 02:12:06 +01:00
Vasilis 636ed4e69e Change the window titlebar to show the joined server (#32547)
* Change the window titlebar to show the joined server

Requires https://github.com/space-wizards/RobustToolbox/pull/5475/

* Totally not a webedit

* Can you tell what cvar I copied?

* And this kids is why we don't webedit

* Reviews

---------

Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2024-10-24 02:09:49 +01:00
Zachary Higgs 27f5d6d817 Give AI a Sound Cue when an Antimov board is inserted (#32625)
* Subversion Board Insertion Audio Notification

Add Subversion flag and SubversionSound to SiliconLawProviderComponent

Add new Method (OnSubversionInserted)
to SiliconLawSystem to handle a Subversive
SiliconLawProviderComponent and play it's SubversionSound

Add Check for Subversive law provider to OnUpdaterInsert that
calls OnSubversionInserted if the SiliconLawProviderComponent is
Subversive

* Fix subversion Sound

- Change out Weh sound used to test that subversion sounds can be
changed by prototype for a a not yet present Antimov subversion sound

* Make it not just subversive

- Remove OnSubversionInserted and move the MindPlaySound in the
OnUpdaterInsert so long as LawUploadSound exists

- Modify SubversionSound into LawUploadSound

- Remove the Subversion flag

- Just use emagged_borg.ogg until the better one is made

* Remove errant spaces and a errant namespace

* CR Fixes - Add generic Lawboard insert cue

- Combine the If statements per /pull/32625#discussion_r1786926400
inside OnUpdaterInsert

- Remove the ViewVariables(VVAccess.ReadWrite) per
pull/32625#discussion_r1786924433

- Add Cryo_warning.ogg from TGStation, the sound utilized for Law Upload
cue, Attribution.

* CR Add a placeholder Antimov notification sound

- Add a new sound kitbashed from the cryo_sound used for uploading
and the emagged noise

* Add self referential source attribution

- also fix an errant space

* Add more bespoke Sound by ps3moira + attributions
2024-10-24 02:09:07 +01:00
LittleNyanCat 2306368492 Several small SFX tweaks (#28897)
* Several small sfx tweaks

* fix small yml oopsie

* Redo the basin code to use events

* now uses an event for when the transfer is successful, not when there's just an attempt

* forgot to remove this

* Update Content.Server/Botany/Components/PlantHolderComponent.cs

Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>

* Update Content.Server/Botany/Systems/PlantHolderSystem.cs

Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>

* adds sound variations to shoes as well

* variations on honkbots and the H.O.N.K mech

* Update Content.Server/Botany/Systems/PlantHolderSystem.cs

* Update Content.Server/Botany/Systems/PlantHolderSystem.cs

* fix compile issue

* oops forgot to delete this

* cleanup

---------

Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2024-10-24 02:08:06 +01:00
deltanedas 49b18586fa fix grappling hooks getting bricked (#32738)
Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-10-24 02:08:05 +01:00
ScarKy0 21c600d4ca Cyborg module action icons (#32505)
* Init

* added jani and medical

* + sci and service modules

* + syndi modules

* fixing up

* geiger counter stuff
2024-10-24 02:06:02 +01:00
Джексон Миссиссиппи 53e4abf428 cleanup melee (#32486)
* it removes warns ig

* Quick fix

---------

Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2024-10-24 02:06:01 +01:00
Leon Friedrich 64ef8dd18c Add `IsQueuedForDeletion` checks to interaction system (#32526) 2024-10-24 02:02:23 +01:00
Leon Friedrich 59d5a3cbff Remove inaccurate admin log when moving a held item (#32525)
Remove inaccurate admin log when switching held item
2024-10-24 02:02:23 +01:00
metalgearsloth c66df62b98 Jobreq format (#32806)
* Format job requirements as hours and minutes

* Use TimeSpan.ToString for playtime instead of custom method

* wehflicts

---------

Co-authored-by: jmcb <joelsgp@protonmail.com>
2024-10-24 02:02:23 +01:00
Leon Friedrich a7c6acd402 Hide role entities in the spawn menu (#32798) 2024-10-24 02:01:21 +01:00
Leon Friedrich 8057cee55a Add role prototype validation tests (#32801)
* Add role prototype validation test

* Rejig GetPrototypesWithComponent

* More tests n stuff
2024-10-24 01:59:40 +01:00
SkaldetSkaeg a08ba13031 Block emotes for sleeping (#32779)
* Block emotes

* typing issue

* Update Content.Shared/Bed/Sleep/SleepingSystem.cs

Co-authored-by: MilenVolf <63782763+MilenVolf@users.noreply.github.com>

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: MilenVolf <63782763+MilenVolf@users.noreply.github.com>
2024-10-24 01:58:17 +01:00
slarticodefast 26b80c3e00 Fix SpawnAndDeleteAllEntitiesInTheSameSpot heisentest (#32330)
What happened was that the new tech anomaly randomly triggered a signal sink on the portable generator, which is currently broken and throws an error if the that sink is activated.

The resolve needed logMissing = false because it does not expect the ActiveGeneratorRevvingComponent to exist.
2024-10-24 01:56:14 +01:00
eoineoineoin 2c001fb6dc Make APC UI work correctly with multiple users (#32465)
* Make APC UI work correctly with multiple users

* Check access only on client, when constructing UI

* Do TODO (Thanks, Robust 236.1)

---------

Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es>
2024-10-24 01:56:14 +01:00
Errant e11d85131c Fix random test fail in DeleteAllThenGhost (#32753)
It's simple. We kill the heisentest
2024-10-24 01:56:05 +01:00
deltanedas eeb06fac47 update for mind roles and fix random stuff, localize alt ids 2024-10-24 01:55:17 +01:00
Errant ab5d439272 Mind Role Entities (#31318)
* Mind Role Entities wip

* headrev count fix

* silicon stuff, cleanup

* exclusive antag config, cleanup

* jobroleadd overwerite

* logging stuff

* MindHasRole cleanup, admin log stuff

* last second cleanup

* ocd

* minor cleanup

* remove createdTime datafield

* now actually using the event replacement I made for role time tracking

* weh
2024-10-24 00:32:47 +01:00
beck-thompson f194cc45c9 Plushies can now have pAIs stuffed into them (v2)! (#30805)
* First commit

* I forgot silly me

* Actually added comments

* spellin

* fixes

* more blacklists

* Minor fixes

* Speech Verb also changes now

* Simple name stuff

* Other fixes

* remove one line of whitespace

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2024-10-24 00:17:33 +01:00
chavonadelal a24c85a1dd Job title localization (#32338)
* Job title localization

* Correcting fields
2024-10-24 00:11:34 +01:00
deltanedas 1b1169c63f
remove 8 second role rule timer (#2026)
Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-10-20 18:02:51 +02:00
Milon 00815becc4
Merge pull request #1982 from deltanedas/upstream-ops
upstream merge 7/10
2024-10-14 20:05:19 +02:00
deltanedas 91dbd3084a
early merge of fix item locations (#1996)
this was just copypasted without any context wasn't it

Co-authored-by: Callmore <22885888+Callmore@users.noreply.github.com>
2024-10-12 13:44:34 +00:00
Pieter-Jan Briers 3337c91e7b Fix borg hands showing up in stripping menu (#32606)
* Fix borg hands showing up in stripping menu

Borgs can't drop their items anyways, and the amount of hands borgs have causes the UI to just bug out.

* Add more checks
2024-10-07 22:26:19 +01:00
deltanedas ba4e0f6b1d
Merge pull request #1953 from MilonPL/accessability
disable species vision filters by default
2024-10-05 16:25:17 +00:00
Milon ca8778b759
unfuck frezon and n2o prices (#1963)
fucked up
2024-10-05 00:54:46 +00:00
deltanedas 7e435cf8cb
Merge pull request #1957 from deltanedas/upstream-ops
upstream merge 2/10
2024-10-02 22:09:14 +00:00
deltanedas cc6bbfebd4
port psionic sacraficing (#1883)
* uncomment and update guidebook

* update loot pool to use entity table and dont hardcode bluespace

* add sacraficing to altars

* :trollface:

* :trollface:

* :trollface:

* 2 lines of sec

* rename files

* replace gamer loot with fake wizard outfit or a normality crystal

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-10-02 13:04:35 +00:00
deltanedas 42b47a0f20 finish syrinx rework and other fix 2024-10-02 13:03:03 +01:00
Plykiya 2fdce66e61 Fix quick-swap stacks of items (#32560)
* remove picking up stack on quick swap

* better
2024-10-02 12:17:34 +01:00
metalgearsloth 0efacebd28 Fix sensors blocking doors (#32591) 2024-10-02 12:17:34 +01:00
Zylofan 5009550336 Seismic charge now craftable (#32459)
* when tryInsertBlueprint is called it now also calls UpdateMaterialWhitelist on the ent so that it can accept new materials if needed.

* Changed the previous commit to now just have sharedMaterialStorageSystem subscribe to TechnologyDatabaseModifiedEvent which will call  UpdateMaterialWhitelist.

* Empty-Commit
2024-10-02 12:16:35 +01:00
BramvanZijp 5c06299f64 Prevent borgs from being able to be briefly toggled off. (#32485)
* Prevent borgs from being able to be briefly toggled off.

* Use the pre-existing component instead of making an unneccesary duplicate.
2024-10-02 12:16:27 +01:00
Celene b110214c62 Execution System uses the identity of an entity; added "the" to execution message (#32536)
* Exec.System now uses IdentityManagement; added the where necessary

* Included attacker in check for Identity

---------

Co-authored-by: Celene <maurice_riepert94@web.de>
2024-10-02 12:12:14 +01:00
SlamBamActionman e8e687ce7c Add webhook for votekicks (#32513)
* Initial commit

* Localization
2024-10-02 12:09:34 +01:00
Leon Friedrich da431bbb81 Add interaction rate limits (#32527)
* Move PlayerRateLimitManager to shared

* Add interaction rate limits

* uncap tests
2024-10-02 12:09:34 +01:00
nikthechampiongr a5ebe6a25d Fix RA0032 (#32514) 2024-10-02 12:08:12 +01:00
MilenVolf bfa43833d3 Replace obsolete Tile Access methods (#32508)
* Replace obsolete SetTile

* Remove obsolete GetTileRef & GetAllTiles

* Forgor

* Apply suggested `GetMapOrInvalid`
2024-10-02 12:08:12 +01:00
metalgearsloth fae9f90d2d Fix multiple door issues (#32483)
* Fix multiple door issues

- Doors should no longer cycle open-and-closed anymore (at least nowhere near as easily).
- Door sprites shouldn't flicker as much (needs my engine PRs to remove all but one of them).

* woops conversion
2024-10-02 12:08:11 +01:00
metalgearsloth 46a3d6d100 Optimise drains (#32230)
* Optimise drains

If it's still a problem then we do what I did for rmc14 and just dump all the active drains onto a job to getentitiesinrange in parallel.

* Fixes
2024-10-02 12:08:11 +01:00
beck-thompson b4452f8fa5 Predict appraisal tool verb! (#32496)
* First commit

* Network :(
2024-10-02 12:08:11 +01:00
Fildrance 75f17c9c97 Station AI ability to electricute doors (#32012)
* Boom! Emergency access!

* Emergency access sound

* locale

* Updated sounds

* bleh

* Door electrify base

* feat: popups on attempt to activate AI action when wires cut

* refactor: use SharedApcPowerReceiverComponent to check if AI can interact with door

* refactor: added icon and sound for door overcharge

* meta.json should use tabs not spaces

* refactor: extracted sounds for airlock overcharge to static field in system

* refactor: cleanup, ScarKy0 mentions for resources

* refactor: removed unused textures

* feat: now notification is displayed when AI attempting to interact with door which have wire cut

* StationAiWhitelistComponent is properly gating  BUI OnMessageAttempt, SharedPowerReceiverSystem.IsPowered is now used to check if device powered

* refactor: use PlayLocal to play electrify sound only for AI player

* refactor: SetBoltsDown now uses TrySetBoltDown, checks for power.

* bolts now check for power using SharedPowerReceiverSystem

* electrify localization and louder electrify sounds

* extracted ShowDeviceNotRespondingPopup, reverted airlocks not opening/closing when ai wire was cut

* refactor: cleanup

* New sprites and fixes

* Copyright

* even more sprite changes

* refactore: cleanup, rename overcharge => electrify

---------

Co-authored-by: ScarKy0 <scarky0@onet.eu>
Co-authored-by: pa.pecherskij <pa.pecherskij@interfax.ru>
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
2024-10-02 12:06:48 +01:00
metalgearsloth 9a59024f13 Predict stripping (#32478)
* Predict stripping

Stops mob verbs from getting moved around again.

* Bola

* Fix ftl
2024-10-02 12:06:37 +01:00
metalgearsloth 9c313b57b4 Fix storage area pickup sound playing multiple times (#32397) 2024-10-02 12:06:37 +01:00
metalgearsloth 38a7494d7d Fix airlock autoclose mispredict (#32477)
* Fix airlock autoclose mispredict

It was hard to see this ingame due to animations masking it. The only way you'd notice currently is the light mispredicting.

* cudin
2024-10-02 12:06:37 +01:00
beck-thompson 41341a8a03 Voice Mask refactor (#30798)
* First commit

* Added base.Initialize()

* Voice wire fix (Electricty name)

* Various minor cleanups

* Localized default voice mask name

* Added VoiceOverride stuff

* Removed unused stuff

* Typo

* Better localized stuff

* Typo / spelling stuff / comments

* Blessed
2024-10-02 12:06:05 +01:00
SlamBamActionman fccb0e30ed Add Votekick functionality (#32005) 2024-10-02 11:38:43 +01:00
Ilya246 79676fd560 lower frezon/n2o sale prices, make frezon take more trit (#32407)
* lower gas prices

* set trit ratio from 1:50 to 1:8
2024-10-02 11:38:43 +01:00
keronshb aaa4ab9351 Adds real-time charge & disabled action information to Actions (#31821) 2024-10-02 11:38:42 +01:00
goet 8847889eeb Fix contraband never getting added to vend inventory (#32431)
* fix contraband never getting added to vend inventory

* Revert "fix contraband never getting added to vend inventory"

This reverts commit e7fb3a60c3cb6fcbf41d7f015f13dbc7b1c1901d.

* readd setter method to system

* fix again without reparenting
2024-10-02 11:38:42 +01:00