* Content - change the (should-be-obsolete) DisposeAllChildren into the more robust RemoveAllChildren.
* Remove duplicate calls.
---------
Co-authored-by: ElectroJr <leonsfriedrich@gmail.com>
* Fix usages of TryIndex()
Most usages of TryIndex() were using it incorrectly. Checking whether prototype IDs specified in prototypes actually existed before using them. This is not appropriate as it's just hiding bugs that should be getting caught by the YAML linter and other tools. (#39115)
This then resulted in TryIndex() getting modified to log errors (94f98073b0), which is incorrect as it causes false-positive errors in proper uses of the API: external data validation. (#39098)
This commit goes through and checks every call site of TryIndex() to see whether they were correct. Most call sites were replaced with the new Resolve(), which is suitable for these "defensive programming" use cases.
Fixes#39115
Breaking change: while doing this I noticed IdCardComponent and related systems were erroneously using ProtoId<AccessLevelPrototype> for job prototypes. This has been corrected.
* fix tests
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* add reputation system
* add contracts button to PDA
* give traitors contracts
* add GetRandomObjective to SharedObjectivesSystem
* add TryRemoveObjective overload
* add everything needed for reputation store and objectives
* "ui"
* giant uplink reputation tagging
* prevent buying reputation-locked gear with uplink implant
* :trollface:
* more ui stuff
* :trollface:
* :trollface:
* remove default objectives
* :trollface:
* UI fixes
* stuff
* objective component changes
* add offerings and stuff to yml
* make some objectives work
* make rcd objective real
* more ui fix
* :trollface:
* ui usable
* bunch of low risk objectives
* syndie jail wip
* more wip
* massive amount of work
* add bad guidebooks
* prevent fultoning anchored things
* fixes
* disable claim buttons when no slots are open
* :trollface:
* :trollface:
* :trollface:
* update ui when a slot unlocks
* move rejecting to offerings, remove rescan (automatic now)
* add verb to attach fulton, fix
* dont get objective to ransom/kill someone you already ransomed
* make offering slots random + maximum count in rep level
* :trollface:
* rela
* update syndie jail
* more syndie jail update
* make marshal real
* fix
* fix power room power
* remove access from timer
* :trollface:
* engine
* allow syndicate items on syndie jail
* add ransom ui
* update map loading
* add ransom purchasing to cargo request console
* warn not error for loading
* ui fixes
* final fixy
* mg book fix
* final fixy II
* remove redundant Announcement word
* more []
* end ransom when leaving the jail
* :trollface:
* 10 tc for roundstart traitors
* make nuke core objective work for traitor
* guidebook gaming
* early merge of guidebook comments
* update bunch of objectives
* add min reputation to kill fellow traitor
* guidebook gaming
* evil
* giant stuff
* dont offer dupe objectives
* evil
* pronoun
* fix
* grr
* blacklist assist and DAGD from assist objective
* grr
* fix linter
* remove objectives from traitor rule test
* nuke disk anti-troll
* evil test
* add objectives test to find bad objective groups
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* fixy
* fix
* fix stuff
* reword ransom announcement
* pro
* goida
---------
Signed-off-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
Co-authored-by: deltanedas <@deltanedas:kde.org>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Add struct for holding historical data on cargo bounties
* Add localisation strings for bounty history
* Add new XAML entry for display bounty history
* Expand cargo bounty menu to include tabs
* Ensure station databases hold historical bounty data
* Add to the bounty history when removing one from active
* Feed bounty history into cargo's bounty system
* Move tab title setting to constructor
* Remove redundant access specifications
* Remove un-needed override
* Fixup BountyHistoryEntry backing code
* Fix formatting in CargoBountyMenu
* Reformat BountyHistoryData
* Rework TryRemoveBounty to use new Entity type
* Add Enum for showing bounty results
* Rework look and feel of History tab
* Add visible text when no bounties have been completed yet
* Remove control
* Swap default to null
* Reverse ordering of bounties so last entry comes first
* Remove redundant Visible
* Move enum docs into the enum
* Remove redundant access specifications
* Remove un-needed override
* Fixup BountyHistoryEntry backing code
* Fix formatting in CargoBountyMenu
* Reformat BountyHistoryData
* Rework TryRemoveBounty to use new Entity type
* Add Enum for showing bounty results
* Rework look and feel of History tab
* Add visible text when no bounties have been completed yet
* Remove control
* Swap default to null
* Reverse ordering of bounties so last entry comes first
* Add struct for holding historical data on cargo bounties
* Add localisation strings for bounty history
* Add new XAML entry for display bounty history
* Expand cargo bounty menu to include tabs
* Ensure station databases hold historical bounty data
* Add to the bounty history when removing one from active
* Feed bounty history into cargo's bounty system
* Remove some BUI boilerplate
- The disposals overrides got removed due to the helper method handling it.
- Replace window creation with CreateWindow helper.
- Fixed some stinky code which would cause exceptions.
* More
* moar
* weh
* done
* More BUIs
* More updates
* weh
* moar
* look who it is
* weh
* merge
* weh
* fixes
* add button to menu
* networking and component work
* try to add access stuff
* main functionality done
* add access lock? I think?
* remove extra line
* fix access system
* move SkipTime to StationCargoBountyDatabaseComponent
* Disable/Enable skip button based on cooldown
* remove debugging
* add access denied sound
* remove DataField tags
* dynamic timer
(cherry picked from commit fd067731b544eb219493338a8fe446c154e880f4)
- every category of type "cargoProduct" was edited to "cargoproduct-category-name-{categoryName}"
- file "cargoproduct-categories.ftl" was added to english localization to localize categories of cargoProduct
- CargoConsoleMenu.xaml.cs got tweaks which prevent issues with strings comparisons
(cherry picked from commit 6e38b992cfc607e09178efc178b86f35152f0cde)
* Use new Subs.CVar helper
Removes manual config OnValueChanged calls, removes need to remember to manually unsubscribe.
This both reduces boilerplate and fixes many issues where subscriptions weren't removed on entity system shutdown.
* Fix a bunch of warnings
* More warning fixes
* Use new DateTime serializer to get rid of ISerializationHooks in changelog code.
* Get rid of some more ISerializationHooks for enums
* And a little more
* Apply suggestions from code review
Co-authored-by: 0x6273 <0x40@keemail.me>
---------
Co-authored-by: 0x6273 <0x40@keemail.me>
(cherry picked from commit 68ce53ae17985876d6d112b764b2144964a9f42e)
- Change namespace, and folder of FancyWindow to Content.Client.UserInterface.Controls
- Change xaml reference from ui to controls in some places
- Change ClientAlertsSystem from internal to public
- Change namespace, and folder of HighDivider to Content.Client.UserInterface.Controls
LordCarve
Pieter-Jan Briers
pathetic meowmeow
Nemanja
deltanedas
BarryNorfolk
metalgearsloth
Killerqu00
MODERN
Flesh
Vasilis
Checkraze
eoineoineoin
corentt
wrexbe
Visne
Marat Gadzhiev
Kara
20kdc
Galactic Chimp
DrSmugleaf