* Enable whitelisting specific DNM prototypes per map
* Enable whitelisting directories
* Rename fields
* Use a HashSet instead of an array
* Add check for unused whitelist entries
* Remove whitelisting for meta (warden's rubber stamp was removed)
* Add glob support courtesy of @IProduceWidgets
* Update xmldoc
* Fix usages of TryIndex()
Most usages of TryIndex() were using it incorrectly. Checking whether prototype IDs specified in prototypes actually existed before using them. This is not appropriate as it's just hiding bugs that should be getting caught by the YAML linter and other tools. (#39115)
This then resulted in TryIndex() getting modified to log errors (94f98073b0), which is incorrect as it causes false-positive errors in proper uses of the API: external data validation. (#39098)
This commit goes through and checks every call site of TryIndex() to see whether they were correct. Most call sites were replaced with the new Resolve(), which is suitable for these "defensive programming" use cases.
Fixes#39115
Breaking change: while doing this I noticed IdCardComponent and related systems were erroneously using ProtoId<AccessLevelPrototype> for job prototypes. This has been corrected.
* fix tests
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Revert "Disable vulpkanin human hair (#40144)"
This reverts commit d02aa1a4e2e106b9bfd8e9516464c9dbd86df7ca.
* You can once again shave your pet Vulp
* I can see the ass, I'm safe
* Rectified docstring as I am a good person
* I am doing this instead of playing Silksong please help
* Fix forgetting to re-add shader overriding
* alert cleanup and API
* I expect update loops to be at the top.
* Address review
* Address review x 2
* Merg my PR
* Fix
* Update Content.Shared/Alert/AlertsSystem.cs
webedit
Co-authored-by: Perry Fraser <perryprog@users.noreply.github.com>
* FIX THAT TEST FAIL!!!!
* Me when I forget to actually give you alerts
* Hammedborgar
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
Co-authored-by: Perry Fraser <perryprog@users.noreply.github.com>
* init
* init
* PUSH!!!
* //
* Me when the when the me when the
* review
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
Fix missing scrollbars in Admin Player List window (#40525)
* Fix missing scrollbars in Admin Player List window
* Revert "Fix missing scrollbars in Admin Player List window"
This reverts commit c5aea1a0550deb1d1d7aae4e2dec964e93d2d8ae.
* Invalidate cached item height when item generation callback changes
Signed-off-by: DisposableCrewmember42 <disposablecrewmember42@proton.me>
Co-authored-by: eoineoineoin <helloworld@eoinrul.es>
* Sorted the ID card computer's buttons.
* Sorted the Jukebox song list
* Sorted the jukebox entries.
* Sorted access config.
* Forgot a comment.
* Changed collection expression
* Also updated Door electronics bound interface.
* Used the existing method now that I can lol
* uhmmm
* health analyzer gaming
* cleanup
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* yeah
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* text update
* cleanup
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Added shark vision to Feroxi.
* Fixed a bug if someone was holding a container of blood.
* Updated pulse time and useDelay for the pulse.
* Updated guidebook
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Cleanup
* More clean-up
* Removed vision goggles sound from ability
* Got rid of an unused namespace
* last fix I swear
* Apply suggestions from code review
Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: Vanessa <908648+ShepardToTheStars@users.noreply.github.com>
* Apply suggestion from @Toby222
Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: Vanessa <908648+ShepardToTheStars@users.noreply.github.com>
* Removed SharedLightSystem from SharkVisionOverlay
---------
Signed-off-by: Vanessa <908648+ShepardToTheStars@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Tobias Berger <toby@tobot.dev>
* Initial port of EE Harpy flying (#919)
* Added better friction and acceleration modifiers.
* Moved server's flight system to shared. I don't know why it isn't in the first place.
* Shifting things around.
* Code tweaks to make it better
* Comment fixes
* Fixed footsteps and footstep sounds
* Added a quick conditional if InitialStaminaCost greater than zero
* Removed a pop-up that wasn't showing
* Additional adjustments
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Fixed a few more systems to call the Flying system instead of the component
* Comment consistency. DeltaV comments where I made it better. EE comments where they originally had things
* YAML fixes
* Guidebook
* Apply suggestions from code review
Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: Vanessa <908648+ShepardToTheStars@users.noreply.github.com>
* Removed DoAfterDashEvent
* Fixed suggestions
* Updated comment
* Added new copyright free wingflaps with proper attribution
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Appeased YAML gods
---------
Signed-off-by: Vanessa <908648+ShepardToTheStars@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Tobias Berger <toby@tobot.dev>
* Initial glimmer change
* Added glimmer multiplier
* Adds scalar of research properly like the old glimmer system
* Left over code
* Glimmer changes for Analysis Console UI
* Accidental Namespace added
* Fixed small Math issue with glimmer values
* Fixed reference to Nyano
* Update Content.Client/Xenoarchaeology/Ui/AnalysisConsoleMenu.xaml
Co-authored-by: KOTOB <59124164+kotobdev@users.noreply.github.com>
Signed-off-by: SirSmith148 <64059804+SirSmith148@users.noreply.github.com>
* Update Content.Client/Xenoarchaeology/Ui/AnalysisConsoleMenu.xaml
Co-authored-by: KOTOB <59124164+kotobdev@users.noreply.github.com>
Signed-off-by: SirSmith148 <64059804+SirSmith148@users.noreply.github.com>
* Update Content.Shared/Xenoarchaeology/Equipment/Components/ArtifactAnalyzerComponent.cs
Co-authored-by: KOTOB <59124164+kotobdev@users.noreply.github.com>
Signed-off-by: SirSmith148 <64059804+SirSmith148@users.noreply.github.com>
* Fixed Deltav comment references
Went though various files and added comments to signify where delta v changes are to the upstream code
* More DeltaV Comment fixes
Added a few more comments for DeltaV specific changes, I also removed an unused line of code, and renamed to variables for better clarity
* Commenting and moving one file to _DV
I cant read apparently and only saw some fixes requested, here are the rest apologies
* Update Content.Shared/Xenoarchaeology/Equipment/Components/ArtifactAnalyzerComponent.cs
Co-authored-by: Charlie Morley <cmorley191@gmail.com>
Signed-off-by: SirSmith148 <64059804+SirSmith148@users.noreply.github.com>
* Update Content.Shared/Xenoarchaeology/Equipment/Components/AnalysisConsoleComponent.cs
Co-authored-by: Charlie Morley <cmorley191@gmail.com>
Signed-off-by: SirSmith148 <64059804+SirSmith148@users.noreply.github.com>
* Update Content.Shared/Content.Shared.csproj
Co-authored-by: Charlie Morley <cmorley191@gmail.com>
Signed-off-by: SirSmith148 <64059804+SirSmith148@users.noreply.github.com>
* Update Content.Server/Xenoarchaeology/Equipment/ArtifactAnalyzerSystem.cs
Co-authored-by: Charlie Morley <cmorley191@gmail.com>
Signed-off-by: SirSmith148 <64059804+SirSmith148@users.noreply.github.com>
* Update Content.Client/Xenoarchaeology/Ui/AnalysisConsoleBoundUserInterface.cs
Co-authored-by: Charlie Morley <cmorley191@gmail.com>
Signed-off-by: SirSmith148 <64059804+SirSmith148@users.noreply.github.com>
* Update Content.Shared/_DV/Xenoarchaeology/BUI/AnalysisConsoleBoundUserInterfaceState.cs
Co-authored-by: Charlie Morley <cmorley191@gmail.com>
Signed-off-by: SirSmith148 <64059804+SirSmith148@users.noreply.github.com>
* Update Resources/Locale/en-US/xenoarchaeology/artifact-analyzer.ftl
Co-authored-by: Charlie Morley <cmorley191@gmail.com>
Signed-off-by: SirSmith148 <64059804+SirSmith148@users.noreply.github.com>
* Addressed issues of cleaning up a function to one that already exists, restoring an old comment from upstream, and moving localization data to _DV folder
* Update Content.Client/Xenoarchaeology/Ui/AnalysisConsoleMenu.xaml.cs
Co-authored-by: Charlie Morley <cmorley191@gmail.com>
Signed-off-by: SirSmith148 <64059804+SirSmith148@users.noreply.github.com>
* Update Content.Client/Xenoarchaeology/Ui/AnalysisConsoleMenu.xaml.cs
Co-authored-by: Charlie Morley <cmorley191@gmail.com>
Signed-off-by: SirSmith148 <64059804+SirSmith148@users.noreply.github.com>
* Update Content.Server/Xenoarchaeology/Equipment/ArtifactAnalyzerSystem.cs
Co-authored-by: Charlie Morley <cmorley191@gmail.com>
Signed-off-by: SirSmith148 <64059804+SirSmith148@users.noreply.github.com>
* Update Content.Server/Xenoarchaeology/Equipment/ArtifactAnalyzerSystem.cs
Co-authored-by: Charlie Morley <cmorley191@gmail.com>
Signed-off-by: SirSmith148 <64059804+SirSmith148@users.noreply.github.com>
* Update Content.Client/Xenoarchaeology/Ui/AnalysisConsoleMenu.xaml.cs
Co-authored-by: Charlie Morley <cmorley191@gmail.com>
Signed-off-by: SirSmith148 <64059804+SirSmith148@users.noreply.github.com>
* Missed one line to bring over to _DV
* Fixed github and IDE complains about null ref
---------
Signed-off-by: SirSmith148 <64059804+SirSmith148@users.noreply.github.com>
Co-authored-by: KOTOB <59124164+kotobdev@users.noreply.github.com>
Co-authored-by: Charlie Morley <cmorley191@gmail.com>
* xenoarch: hide some node effects until unlocked
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* minor review comments
* added missing deltav comments
* test failures: forgot DataField annotation on XAEDetails.AllowLockedEffectHiding, and LocId SpecificTip field needed default
* AnalysisConsoleMenu.xaml.cs copypasta mistake (that'll teach me to push before testing)
* arti effect hiding increased to 70%
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
This prevents the volume and temperature labels from changing width when the value lands on integer values, making the text easier to read.
Co-authored-by: opl <4833621+opl@users.noreply.github.com>
Charlie Morley
Absotively
Tayrtahn
Winkarst-cpu
SlamBamActionman
Ser11y
Fildrance
Pieter-Jan Briers
Hannah Giovanna Dawson
Princess Cheeseballs
Quantum-cross
ScarKy0
Milon
DisposableCrewmember42
Vanessa
KOTOB
ConstantlyConfused
SirSmith148
beck-thompson
Tobias Berger
Coryn
opl-
Centronias
slarticodefast
InsoPL
Kyle Tyo
Whatstone
vitopigno
Southbridge