Commit Graph

13 Commits

Author SHA1 Message Date
Pieter-Jan Briers b7f297f612 Fix usages of TryIndex() (#39124)
* Fix usages of TryIndex()

Most usages of TryIndex() were using it incorrectly. Checking whether prototype IDs specified in prototypes actually existed before using them. This is not appropriate as it's just hiding bugs that should be getting caught by the YAML linter and other tools. (#39115)

This then resulted in TryIndex() getting modified to log errors (94f98073b0), which is incorrect as it causes false-positive errors in proper uses of the API: external data validation. (#39098)

This commit goes through and checks every call site of TryIndex() to see whether they were correct. Most call sites were replaced with the new Resolve(), which is suitable for these "defensive programming" use cases.

Fixes #39115

Breaking change: while doing this I noticed IdCardComponent and related systems were erroneously using ProtoId<AccessLevelPrototype> for job prototypes. This has been corrected.

* fix tests

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-12-29 11:39:03 -06:00
deltanedas eeb06fac47 update for mind roles and fix random stuff, localize alt ids 2024-10-24 01:55:17 +01:00
Errant ab5d439272 Mind Role Entities (#31318)
* Mind Role Entities wip

* headrev count fix

* silicon stuff, cleanup

* exclusive antag config, cleanup

* jobroleadd overwerite

* logging stuff

* MindHasRole cleanup, admin log stuff

* last second cleanup

* ocd

* minor cleanup

* remove createdTime datafield

* now actually using the event replacement I made for role time tracking

* weh
2024-10-24 00:32:47 +01:00
metalgearsloth 52c4875d96 Reapply "Fix spawnpref" (#32018) (#32058)
This reverts commit 119dd610fa30edd3927cd51acbc68601f7d0b8e0.
2024-09-14 14:23:14 +01:00
Emisse b2209d3f35 Revert "Fix spawnpref" (#32018) 2024-09-14 14:06:41 +01:00
metalgearsloth 3999999e63 Fix spawnpref (#31892) 2024-09-14 14:06:16 +01:00
metalgearsloth 389a92a317 Fixup playerspawn stuff (#31546)
* Fixup playerspawn stuff

- Also removed arrivals forcing, this should just turn containerspawnpoint off.

* fix this one

* test fix

* really fix
2024-08-30 08:07:09 +01:00
Krunklehorn 922407e2e8
Client customization late-join spawner priority for arrivals/cryostorage (#24586)
* Initial commit, requires server restart to take effect

* Exposes callbacks directly instead, takes effect immediately

* Cleaned up control flow, swapped cvar for client customization

* Switched to int, dictionary of callbacks, migration

* Update Content.Shared/Preferences/SpawnPriorityPreference.cs

* krunkle stan

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>

(cherry picked from commit ed0f2aa2213cc47b817476206a2dd0b4e7c176b1)
2024-02-08 12:16:20 +01:00
Debug 2d03cc63b6
Add prisoner latejoin cryopod (#751) 2024-01-31 22:02:05 +00:00
Debug 4414a65301
Fix prisoners spawning at latejoin cryopods (#743) 2024-01-31 09:42:57 +00:00
Krunklehorn e666d3aeb4
Changed spawn priority to arrivals -> containers -> points. (#24476)
(cherry picked from commit 00c83844acab389edb896ecd1df7d7c0c68e0134)
2024-01-27 23:53:52 +01:00
Nemanja 04d5a09774
fix cryosleepers deleting the station (#24143)
* fix cryogenic units deleting the station

* ship it

(cherry picked from commit 017450ef17ed19f24fee3375cd35967e974ab119)
2024-01-26 22:55:45 +01:00
Nemanja e624317d37
Cryogenic Sleep Units (#24096)
* Cryogenic sleep units

* pause map support

* no more body deletion

* Cryogenic Storage Units

* boowomp

* no more emag, no more dropping present people

(cherry picked from commit 736b9dd7df6e35f07fed88686c7c863ac61af846)
2024-01-26 22:51:41 +01:00