Commit Graph

9 Commits

Author SHA1 Message Date
Pieter-Jan Briers 68ce53ae17
Random spontaneous cleanup PR (#25131)
* Use new Subs.CVar helper

Removes manual config OnValueChanged calls, removes need to remember to manually unsubscribe.

This both reduces boilerplate and fixes many issues where subscriptions weren't removed on entity system shutdown.

* Fix a bunch of warnings

* More warning fixes

* Use new DateTime serializer to get rid of ISerializationHooks in changelog code.

* Get rid of some more ISerializationHooks for enums

* And a little more

* Apply suggestions from code review

Co-authored-by: 0x6273 <0x40@keemail.me>

---------

Co-authored-by: 0x6273 <0x40@keemail.me>
2024-02-13 16:48:39 -05:00
Nemanja c29896f505
fix radiators leaking heat into atmos blocked tiles (#24124)
* fix radiators leaking heat into atmos blocked tiles

* Fix the fix

Pointyhat to: emogarbage

* Remove unused imports

---------

Co-authored-by: Kevin Zheng <kevinz5000@gmail.com>
2024-01-16 18:58:04 +11:00
Kara bc1f8b0e40
Convert atmos device events to ref events (#22843) 2023-12-21 17:48:18 -08:00
Leon Friedrich 477327f952
Atmos scaling cvar changes (#22501) 2023-12-15 14:02:21 -08:00
Ilya246 2185a2bf45
Fix radiators overshooting energy transfer (#19395)
Co-authored-by: Kevin Zheng <kevinz5000@gmail.com>
2023-08-24 23:30:56 -07:00
Kevin Zheng d7fa5b73c3
Remove atmos device dependency on game timer (#18847) 2023-08-13 16:42:12 +10:00
Ilya246 376a71100d
Fix radiator transfer rate in high-pressure environments (#18858)
Co-authored-by: Kevin Zheng <kevinz5000@gmail.com>
2023-08-08 01:16:23 -07:00
Ilya246 f99741937c
Adjust radiator flow rate and fix space detection (#18764)
The previous dT did not accurately represent the actual tick time. This is being investigated separately.

Check environment mixture for zero moles, because space mixtures do not necessarily return null.

While here, make an unrelated style change involving TryComp.
2023-08-06 10:23:43 -07:00
Kevin Zheng db5dee6db3
Add radiators (#18728)
* Add radiators

* Limit heat transfer to fluid heat capacity

* Adjust datafield names

* Fix material arbitrage

* This code has been debugged, and so there are no more bugs. Debugging code is therefore unnecessary

* Adjust radiator layer subfloor visibility

* Cache CVars

* No default

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>

* Like and unsubscribe

* Fix CVar caching

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
2023-08-06 02:21:05 -06:00