Commit Graph

8058 Commits

Author SHA1 Message Date
deltanedas d3aa1efc38 item toggling giga rework + full ninja refactor (#28039)
* item toggle refactoring and some new systems

* add ToggleClothing component/system

* unhardcode magboots gravity logic

* make magboots and speedboots use ItemToggle and stuff

* remove now useless clothing components

* update client/server magboots systems

* add note to use ItemToggledEvent in ToggleActionEvent doc

* refactor PowerCellDraw to use ItemToggle for ui open/close control

* add TryUseCharges, refactor charges system

* update magboot trigger code

* make borg use ItemToggle, network SelectedModule instead of now removed Activated

* add AccessToggle for borg

* the giga ninja refactor

* update ninja yml

* update ItemToggle usage for some stuff

* fix activatableui requires power

* random fixing

* yaml fixing

* nuke ItemToggleDisarmMalus

* make defib use ItemToggle

* make things that use power not turn on if missing use charge

* pro

* fix sound prediction

* bruh

* proximity detector use ItemToggle

* oop

* big idiot syndrome

* fix ninja spawn rule and make it generic

* fix ninja spawn rule yml

* move loading profiles into AntagLoadProfileRule

* more ninja refactor

* ninja yml fixes

* the dreaded copy paste ops

* remove useless NinjaRuleComponent and ue AntagSelection for greeting

* fix invisibility

* move IsCompleted to SharedObjectivesSystem

* ability fixes

* oop fix powercell instantly draining itself

* sentient speedboots gaming

* make reflect use ItemToggle

* fix other test

* loadprofilerule moved into its own pr

* remove conflict with dragon refactor

* remove all GenericAntag code from ninja

* )

* probably

* remove old enabled

* great language bravo vince

* GREAT LANGUAGE

* who made this language

* because it stinks

* reparent blood-red magboots to magboots probbbly works

* most of the review stuff

* hasGrav doesnt mean what i thought it did

* make health analyzer use itemtoggle, not fail test

* fix mag/speed boots being wacky

* UNTROLL

* add ItemToggle to the random health analyzers

* a

* remove unused obsolete borg func

* untrolling

* :trollface:

* fix test

* fix

* g

* untroll

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-08-09 17:45:27 +01:00
MFMessage ef04a0bfe3 Picking a ghostrole as an admin will now deadmin you. (#29790)
* @forcibly deadmins you

* Added checks for AdminDeadminOnJoin
2024-08-09 17:39:45 +01:00
Cojoke b735c84e1a Fix the ability to shoot out of crates (#28961)
* Fix the ability to shoot out of crates

* Makes it check what inventory the player is in

* use IsEntityOrParentInContainer

* Fix Issues Github had

* gaahhh... Prevents lasers from being shot out of crates

* gaahhh... Prevents lasers from being shot out of crates

* Fix laser?

* hmmm... this is better looking I think?

* Uncook indentation

* Rerun tests?
2024-08-09 17:39:19 +01:00
Chief-Engineer 366cea3352 Fix baby jail (#29896)
* Revert "Revert Baby Jail (#29891)"

This reverts commit 24a2866747e6de37ab2c4395bee9ea44c9211c6f.

* the fix
2024-08-09 17:39:18 +01:00
Vasilis b0edb5ccf0 Revert Baby Jail (#29891)
* Revert "SS14-28662 Add Baby Jail: a Jail for Babies (inverse panic bunker) (#28763)"

This reverts commit 3ceb92a0c43d3815d65c8124cd6bea3be5140455.

* Revert configs

* Oops
2024-08-09 17:38:45 +01:00
Tayrtahn 87fb12b6cb Replace ProtoId<EntityPrototype> uses with EntProtoId (#29892) 2024-08-09 17:38:31 +01:00
dffdff2423 e63d2a2ac6 Add an option to the admin fax menu to lock papers such that they can't be edited by cybersun pens (#28972)
* Add option to adminfax for locking papers.

* Replace dummy control with margin
2024-08-09 17:38:28 +01:00
Moomoobeef 90d3155c0d fixed missing characters in OwO accent (#29047)
replaced two characters with ones that actually show up ingame
2024-08-09 17:38:28 +01:00
Ed 92cd28bb11 Steal Objective Condition now support stacks (#29843)
* Update StealConditionSystem.cs

* Update StealConditionSystem.cs
2024-08-09 17:38:27 +01:00
lzk ec65a571c7 Fix colornetwork desc and help (#29856)
* Fix colornetwork description

* suggested changes

* forgor

* done

* ok now it IS done
2024-08-09 17:38:27 +01:00
Plykiya f68b5a8817 Stop eating food if you drop it (#29854)
* Stop eating food if you drop it

* woops, unused param

* comments

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 17:38:27 +01:00
Errant 2337238cec Aghosts can now /ghost (#29360)
I will not be subjected to criminal abuse
2024-08-09 17:38:04 +01:00
chavonadelal 70296211fa Nozzle Direction Localization (#29849) 2024-08-09 17:38:03 +01:00
chavonadelal b2ec9a6551 Localization of the threat level in an emergency lamp (#29847) 2024-08-09 17:38:03 +01:00
lzk 2d0fc339ed Add popup for health analyzer target (#29803)
* Add popup for health analyzer target

* addition

* fix showing popup to all
2024-08-09 17:38:03 +01:00
lzk 70b269717c Add popup for healing target (#29804)
* Add popup for healing target

* hop

* huh

* fix one

* fix showing popup to all
2024-08-09 17:38:03 +01:00
slarticodefast f84b23cd38 Improve throwing precision (#29726)
* improve throwing precision

* remove debugging logs

* minor fixes

* f

* Update Content.Shared/Throwing/LandAtCursorComponent.cs

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
2024-08-09 17:35:24 +01:00
Tayrtahn 37af3861da Silence ringtones on admin PDAs (#29801)
* Silence ringtones on invisible PDAs

* Revert "Silence ringtones on invisible PDAs"

This reverts commit afc1041f31eebe82e83630a856a8856b877a9826.

* Literally just this

* Add an admin announcement for news article publishing
2024-08-09 17:35:24 +01:00
Nemanja 52472122eb The real AME nerf (#29587)
* The real AME nerf

* oh the real change

* Update AmeNodeGroup.cs
2024-08-09 17:35:23 +01:00
Nemanja 96e1be9a0a metal foam grenades (#29428)
* metal foam grenades

* wow okay

* meh

* bruh

* test

* push
2024-08-09 17:34:17 +01:00
Verm 7d74de8f5a Bartending+: Shaking and Stirring (#29243)
* Shaking and Stirring

* Remove shake message

* Switch if order a bit

* Add doafter supprot for reactionmixer

* Fix nullability

* Timespan zero

* Forgot to remove loc string

* Reorganize usings

* Remove unneeded usings, fix b52 needing to be shaken
2024-08-09 17:33:56 +01:00
Nemanja 8295d43319 Intercom buffs and fixes (#29580)
* Intercom buffs and fixes

* remove unused bui state

* mild sec intercom buff

* reinforce sec intercoms
2024-08-09 17:33:56 +01:00
beck-thompson 06f67a73e6 Spilling reagents on mutliple entities at once fix (#29763)
* Fixed!

* That could have been bad this is why I'm glad I check the diff xD
2024-08-09 17:32:07 +01:00
themias 9f37f7c14a Don't allow toggling internals while asleep (#29753) 2024-08-09 17:31:51 +01:00
lzk a008a646e9 Add summary comments for ElectrifiedComponent fields (#29733)
add summaries for ElectrifiedComponent
2024-08-09 17:31:25 +01:00
Jezithyr 4e03110cff Re-enabling nukie species(except vox), added antag species blacklisting
* Revert "Make all Nukies humans (#29693)"

This reverts commit 3e3e050aafb93daa1eb017ee06b5e2a15fb3d315.

* Implemented species blacklist

* Re-enabled all species as Nukies except for Vox because loadouts don't support breathing alternative gases yet.
2024-08-09 17:31:25 +01:00
nikthechampiongr 1f3cf5c68f Move checking code for BlacklistedRange to the right place in sqlite (#29389) 2024-08-09 17:31:25 +01:00
Nemanja 350754879e Make all nukies humans (#29693) 2024-08-09 17:30:58 +01:00
Nemanja 6dd602ef71 add apc power draw to stat value command (#29701)
add apc stat value
2024-08-09 17:27:14 +01:00
metalgearsloth 3b3e8d77fd VGRoid support (#27659)
* Dungeon spawn support for grid spawns

* Recursive dungeons working

* Mask approach working

* zack

* More work

* Fix recursive dungeons

* Heap of work

* weh

* the cud

* rar

* Job

* weh

* weh

* weh

* Master merges

* orch

* weh

* vgroid most of the work

* Tweaks

* Tweaks

* weh

* do do do do do do

* Basic layout

* Ore spawning working

* Big breaking changes

* Mob gen working

* weh

* Finalising

* emo

* More finalising

* reverty

* Reduce distance
2024-08-09 17:27:13 +01:00
Plykiya 8a38f3b8c6 Thieving glove pickups actually stealthy (#29665)
Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 17:26:15 +01:00
lzk 8910bf4c0f Fix GhostCommand naming (#29671) 2024-08-09 17:25:49 +01:00
Mervill c0a4865d75 Clean up gas miners (#29657)
Separate the environment check from CapSpawnAmount into GetValidEnvironment to make the code a little cleaner, and also makes these two checks independent.

CapSpawnAmount and GetValidEnvironment now both have zero side-effects

Broken renamed Idle to reflect its use. Broken in my mind implies that there's some method for fixing.

---------

Co-authored-by: Partmedia <kevinz5000@gmail.com>
2024-08-09 17:25:49 +01:00
lzk 73f02aaa0b Add ability to add additional friendly and hostile factions in prototypes (#29636)
* Make friendly and hostile factions in NpcFactionMemberComponent datafiels

* :trollface:

* :trollface:
2024-08-09 17:22:38 +01:00
Chief-Engineer f1c0e2cc73 add more info to entity json in logs (#18672)
* add more info to entity json in logs

* replace TryGetSessionById

* remove unused dependency

* get admin status from the entity

* group values by component

* alphabetize

* I've discovered that my original plans may be bad for performance
2024-08-09 17:19:01 +01:00
Tayrtahn c2fbcff987 Fix nukeops ending early if an operative dies at base (#29642)
Fix nukeops ending early if an operative died at base
2024-08-09 17:19:00 +01:00
Cojoke 50b01f39aa Allow Flares to light cigarettes (#29476)
* Allow Flares to light cigarettes

* !IsHot check

* nicer looking(and I think the right way to do that...)

* heh, whoops

* Adds IgnitionEvent, IgnitionSource now functions as IsHot when Ignited

* Fixes + remove redundancy

* Hows this?

* press enter

Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>

* Flare is not forever hot anymore

* Formatting fixes

* Make IgnitionEvent readonly

---------

Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
2024-08-09 17:19:00 +01:00
jmcb c1b97b0e64 Remove outdated NotNullWhen annotation (#29641)
A previous version of this function returned a bool. Since this no longer does that, remove the annotation.
2024-08-09 17:19:00 +01:00
Plykiya 8cda9cc1b1 Fixes gravity wells (#29617)
* Fixes gravity wells

* thank you slarticodefast

* Minor nitpicks addressed

* NITPICKS UNDONE

* REDO THE NITPICK, WE LOVE MATRIX MULTIPLCATION

* Revert "REDO THE NITPICK, WE LOVE MATRIX MULTIPLCATION"

This reverts commit c782eee1a1c7bda90c7ca686928019cc5f25c8cf.

* NITPICK REDO

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 17:19:00 +01:00
metalgearsloth 221b8ae475 Add FTL arrival visuals (#29402)
* Add FTL arrival visuals

* weh

* Update Content.Shared/Shuttles/Components/FTLComponent.cs

Co-authored-by: Tayrtahn <tayrtahn@gmail.com>

---------

Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
2024-08-09 17:19:00 +01:00
WarMechanic 10b7e40ed2
Senior ID cards get a custom job name: Attempt 3 (#1425)
* revert 1218

* oops wrong file

* commit changes

* it works!!!

* revert accidental changes

* hide senior virtual job prototypes from job select

* remove whitespace diff

* consolidate comments

* remove virtual job prototypes

* these changes were not staged

* remove whitespace diff

* remove whitespace diff again and revert test change

* Update station_engineer.yml

Signed-off-by: WarMechanic <69510347+WarMechanic@users.noreply.github.com>

* Update SharedJobSystem.cs

Signed-off-by: WarMechanic <69510347+WarMechanic@users.noreply.github.com>

* fix capitalisation typo

* consolidate comments and dependencies, also change Mind to use VirtualJobName

* comment correction

* localise senior job names

* fix build error

* fix spawned cards being broken

* reduced logging for finding PresetIdCard

* more fixes

* fix

---------

Signed-off-by: WarMechanic <69510347+WarMechanic@users.noreply.github.com>
2024-08-06 23:20:49 +02:00
metalgearsloth 00ae128855 Fix door access in mapping mode (#30030)
Fix shouldn't break anythingTM.
2024-07-26 00:32:25 +00:00
Null f19310b268
Merge pull request #1533 from NullWanderer/2024/07/05-upstream-merge
Finally, the big merge
2024-07-25 03:17:57 +02:00
null 96acb39b71
Untroll reagents 2024-07-25 02:07:54 +02:00
Nemanja 1bb89bdca5
Selectable Bar Signs (#29068)
* make bar sign selectable

* ajcm strongest soldier

* AJCM comes down hard for round 2

* good shit

* ok ballin

* bless'ed be the webedit
2024-07-25 01:57:58 +02:00
Plykiya fe1571b3aa
Removes obsolete AnchorEntity() functions (#28613)
Obsolete anchor entity functions

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-07-25 01:57:55 +02:00
Chief-Engineer 3d364c8e0e
Disable ame unsafe admin alert (#29582)
disable ame unsafe admin alert
2024-07-25 01:56:44 +02:00
SlamBamActionman f08ba8b494
Turn ReagentEffects into generic EntityEffects (#28168)
* Oh the possibilities

* Merge fixes

* Forgot to remote LavaSystem oops

* Changed EntityEffectArgs to EntityEffectBaseArgs and EntityEffectReagentArgs

* Throw exception for unimplemented effectargs

* Remove Json and overrideable datafields

* Fix test issues

* Actually fix the compiling issue

* Fix comments and remove EntityEffectArgs (no longer used, replaced with EntityEffectBaseArgs)
2024-07-25 01:55:29 +02:00
Guillaume E 10c33d0390
Improve gas miner's output bounds checks (#29569)
Miners now can produce a fraction of their SpawnAmount corresponding
to the "remaining space" available in their environment according to
their MaxExternalPressure and MaxExternalAmount.
2024-07-25 01:55:10 +02:00
Nemanja 09d5711680
fix explosion resistance showing 0 values (#29572)
* fix explosion resistance showing 0 values

* markup
2024-07-25 01:55:09 +02:00