Instead of each mutation being a flag that gets checked at some unique point in BotanySystem somewhere, they're now EntityEffects that get applied when the mutation occurs and when produce is harvested. One new list was added to SeedData so that multiple other fields could be removed.
All the non-stat-change mutations that have been rolled are added to the Mutations list, and get applied to the plant when the mutation occurs or when a seed with the mutation is planted. Produce get mutations applied at harvest if they apply to the produce, and carry all of the plant's mutations over as a seed. This gets rid of the one-off checks for things like Slippery, Bioluminescent, Sentient, etc.
The base odds of a mutation applying should be equal to the odds of the original mutation check. It pretended to have 1 bit flip (on averge) per mutation power, and odds of each mutation was the odds of one of its bit being flipped (1 /275 * bits). The 'thermometer code' applied for numbers will be replaced with simple random rolls, as both average out to the middle value. The new checks are much easier to understand and don't obfuscate the actual changes of something happening behind 3 layers of math. The biggest player-facing change is that Potency will be able to get over 65 significantly more often than it did in the previous system, but it will be just as common to get low values as high ones.
Mutation definitions have been moved to a .yml file. These include the odds per tick per mutagen strength of that mutation applying that tick, the effect applied, if it applies to the plant and/or its produce. This makes mutations simpler to add and edit.
This PR is limited specifically to the mutation logic. Improving other aspects of the system will be done in other PRs per the design document. Mutations was chosen first because its got the largest amount of one-off checks scattered all over that could be consolidated. Once this is merged, mutations could be contributed to the codebase with minimal extra work for later botany refactor PRs.
* Fixed bug with missing gas not getting reset
* Fix bug with MutateInt not using min/max in prob calculation
* Add divison by zero check
* Fix styling
Fix comparison
Hybrids (different plants being crossed) are supposed to have a high
chance of becoming seedless to balance overpowered plants.
However, a logic error in the comparison gave seedless to plants when
they were from the same seed (not hybrids) rather than the other way
around.
Reported by: @genderGeometries
* Chem 1984 phase 1
* Chem 1984 phase 2
* Notification on species mutation
* Plant yml balancing
* Better localization
* First version of reagent list
* Revert "Better localization"
nvm
This reverts commit bab87cb1bd58523164d306dccaefc1ac5c6b64ad.
* cooler reagents and no more popups
* :trollface:
* I’m blind
* Even more consumption
* Revert "Even more consumption"
This reverts commit 94ae0eca0ba1b4a55913f92519e1354b77e70734.
Oops forgot a file
* Believe it or not, more nutrient consumption
* Buff ez nutrient and l4z
* Add left 4 zed to emagged nutrimax just because
* Change some thresholds
drakewill-CRL
Crotalus
slarticodefast
Kevin Zheng
Doru991
Nemanja
Sailor
drteaspoon420
TomaszKawalec
612
metalgearsloth
Leon Friedrich
Duke
Visne