* Replace usages of customTypeSerializer PrototypeIdListSerializer with something that doesn't take 20 separate words to type out
* Missed one
* Missed another
* Fix data field ids
* parrots have ears. add poly
* high tech parrot functionality
* adjust times
* add accent to radio message
* don't spam everything all at once probably
* learn about the existence of prob(float)
* actually use Prob(float) correctly
* newline
* add pet spawner for poly
* move chance to talk on radio to component
* missing comment
* minor edits and doc additions
* the reviewerrrrrrr
* parrot can't learn when crit or dead
* increase default memory
* rename poly to polly
* crude way to ignore whispers. chatcode please
* This is Polly. It is set to broadcast over the engineering frequency
* add missing initialize
* add displacement map for parrot ears
* review comments - Errant
* minor things
* large rework
* fix attempting to talk when entity has no channels
* use list of active radios again to track channels
* fix bad return, some comments
* fix long learn cooldown
* minor adjustments
* use FromMinutes
* the voices told me to make these changes
* remove default reassignment
* Review changes
* remove polly's accent
* decouple radio stuff from parrotsystem
* minor stuff
* split vocalization and parroting
* minor review work
* re-add missing check
* add admin verb for clearing parrot messages
* minor action icon update
* oops
* increase icon number text size
* Admin erase parrot messages associated with players
* part 1 beck review
* add whitelist and blacklist for parrots
* Downgrade missing component error to warning
* Add comment
* add some missing comments
* Remove active radio entity tracking, use all inventory slots
* Minor changes
* small review stuff
* review radio stuff
* swap ears displacement to invisible death displacement
* remove syncsprite
* vscode why do yo have to hurt my feelings
* review changes
* use checkboth
* Allow non-preference living things to be added to a devourer's stomach
* Fix ordering of devour logic
* Minor refactor for whitelist on storage and food preference
* Fix linter issue
* Coerce workflow to run again; also fix bad indenting error
* Code review changes
* Improve and expand `TakeRoleAndReturn` to fail on bug #38292
* fix#38292 and expanded test cases
* use validated EntProtoIds for tests
remove unusued using declarations
* use const strings that match the TestPrototypes
* refactor: move puddle evaporation + absorbents to shared
* refactor: move SolutionRegeneration to shared
* refactor: make AbsorbentSystem visuals clientside
* style: general formatting/cleanup on touched files
- Few logical simplifications
- Add field for hard-coded sparkle effect ent
- Switch stuff to Entity<T>
No actual prediction fixes in this commit (though in
retrospect I should've done this commit last).
* fix: use predicted variants for predicted code
* fix: average out evaporation rates in mixtures
* refactor: move SolutionPurge to shared
* style: Basic SolutionPurgeComponent field cleanup
* fix: general prediction + timing + networking fixes
- Moves client side visuals back to shared because other
players exist
- Don't accumulate CurTime in Purge/RegenerationSystem
- Network the next update field in Purge/RegenerationSystem to
deal with UI mispredictions???
* fix: add udder bug workaround
Not needed for SolutionPurgeSystem which doesn't resolve
solutions (probably fine that SolutionPurgeSystem doesn't
cache since it's much rarer, though it probably should), and
likely not needed for AbsorbentSystem since it only resolves
against puddles which, I don't think can be in containers.
* fix: don't divide by zero for evaporation speed = 0.
* refactor: revert evaporation changes
Will cherry-pick these out in another PR.
Also reverting the evaporation speed bugfix since it's easier
to revert all at once. :)
* fix: component cleanup; autopause fields, use ProtoID
* fix: remove unused AbsorbentComponentState
* fix: ProtoId is not string
* refactor: move PuddleSystem.UpdateAppearance to shared
* style: general PuddleSystem.UpdateAppearance tweaks
- Switch to Entity<T>
- Use ProtoIds
- Minor simplifications
* fix: add udderly silly PVS workaround
* cleanup
* fix
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* initial system (this math is probably WRONG)
* General code cleanup and OnExamined support
(holy moly this code sucks)
* UICode and related events foundation
TODO:
- Actually write the XAML UI and the underlying system
- Un-shitcode the entire thing
- Actually test everything...
* Working UI code
TODO: Make predicted, as this certainly isn't predicted. Even though I said it was. It isn't.
* Remove one TODO for unshitcoding the examine code
* Add reminder
yea
* Make predicted (defenitely isn't)
(also defenitely isn't a copypaste from pressure pump code)
* It's predicted!
TODO:
- Give it snazzy predicted visuals!
- Have a different field for pressure entry, lest it gets bulldozed every UI update.
* Improve gas pressure relief valve UI
TODO: Reminder to reduce amount of dirties using deltafields
* Implement DirtyField prediction
* Entity<T> cleanup
A lot of Entity<T> conversions and lukewarm cleanup.
Also got caught copy pasting code in 4K UHD but it's not like you couldn't tell.
* More cleanup and comments
* Remove TODO comment on bulldozing window title
* """refactoring"""
- Move appearance out of shared and finally fix it. Pointless to predict appearance in this instance.
- More Entity<T> conversions because I like them.
- Move UI creation handling over entirely to the ActivatableUI system.
- Fix a hardcoded locale string (why????).
* Add visuals
* Revert debugging variable replacememt
yea
* Revert skissue
* Remove unused using directives and remove TODO
* Localize, cleanup, document
* Fix adminlogging discrepancy
* Add ability to construct, add guidebook entry
* Clear up comment
* Add guidebook tooltip to valve
* Convert GasPressureReliefValveBoundUserInterface declaration into primary constructor
* Adds more input handling and adds autofill on open
* Un-deepfry input validator shitcode
Genuinely what was I smoking
* improve visuals logic
* Refactor again
- Update math to the correct implementation
- Moved code that could be re-used in the future into a helper method under AtmosphereSystem.Gases.cs
* I'm sorry but I hate warnings
* Remove unused using directive in AtmosphereSystem.Gases.cs
* Review and cleanup
* Lukewarm UI glossup
* Maintainer for the upstream project btw
* Remove redundant state sets and messy logic
* Unduplicate valve updater code
* Redo UI (im sorry Slarti)
* run tests
* Test refactored UI messaging
* Second round of UI improvements
- God please find a way to improve this system. Feels bad.
* Update loop implementation
* Further predict UI
* Clear up SetToCurrentThreshold
* cleanup
* Update to master + pipe layers and bug fixes
want to run tests
* fixes
* Deploy rename pipebomb
* Documentation and requested changes
* Rename the method that wiggled away
* Undo rounding changes
* Fix comment
* Rename and cleanup
* Apply suggestions from code review
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Resolving Wizard Recall on Nuke disk making it impossible to disarm
- Adding a DisarmBomb case to nuke status update loop
- Changing a few methods and parameters to properly follow formatting standards
- Updating some names to follow camelCase
* Updating missed tag
* Reverting DataField change
Should prevent this preventative bugfix being a breaking change.
* Respirator Debodied
* Forgot about alerts (also respirator testa and events)
* Fix Urist eating air and not giving it back
* Stop nuke ops from taking in a breath then taking in a second breath causing them to get a headache from carbon dioxide poisoning and failing TryStopNukeOpsFromConstantlyFailing();
* Consts are smelly,
* Actually we don't need to raise the entity, just the component
* Don't forget to remove the unused code today, said me yesterday
* Remove all fallbacks
* Debody that too
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
* Use an actual Queue
* Store ProtoIds instead of prototypes
* Network as NetListAsArray
* Remove Serializable & NetSerializable from LatheRecipePrototype
* Convert CurrentlyProducing too
* No point using NetListAsArray<T> if you're going to .ToArray() it anyways.
---------
Co-authored-by: PJB3005 <pieterjan.briers+git@gmail.com>
* checkpoint
* pt 2
* pt... i forgot
* pt 4
* patch
* More test fixes
* optimization!!!
* the REAL hand system
* fix RetractableItemActionSystem.cs oversight
* the review
* test
* remove test usage of body prototype
* Update Content.IntegrationTests/Tests/Interaction/InteractionTest.cs
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
* hellcode
* hellcode 2
* Minor cleanup
* test
* Chasing the last of the bugs
* changes
---------
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
* spectra
* documentation
* added into liquid anomaly
* Update TemporaryStealthComponent.cs
* Update TemporaryStealthComponent.cs
* integrated
* new system
* mark old status effect system as obsolete
* ForcedSleeping new status effect
* work with reagents
* networking???
* Revert "integrated"
This reverts commit bca02b82bae18ae131af593d7eb86e6de2745157.
* Revert "Update TemporaryStealthComponent.cs"
This reverts commit 4a5be8c4b704a0d1ff9544b2e245d8b2701ec580.
* Revert "Update TemporaryStealthComponent.cs"
This reverts commit a4875bcb41347638854bd723d96a51c3e6d38034.
* Revert "added into liquid anomaly"
This reverts commit df5086b14bb35f1467158a36807c0f2163a16d99.
* Revert "documentation"
This reverts commit 3629b9466758cbdfa4dd5e67ece122fa2f181138.
* Revert "spectra"
This reverts commit 2d03d88c16d16ad6831c19a7921b84600daeb284.
* drowsiness status effect remove
* reagents work
* polish, remove test changes
* first Fildrance review part
* Update misc.yml
* more fildrance review
* final part
* fix trailing spaces
* sleeping status effect
* drowsiness status effect
* Create ModifyStatusEffect.cs
* some tweak
* Yay!!! Manual networking
* minor nitpick
* oopsie
* refactor: xml-docs, notnullwhen attributes, whitespaces
* fildrance and emo review
* refactor: simplify check in SharedStatusEffectsSystem by using pattern matching, TryEffectsWithComp now returns set of Entity<T, StatusEffectComponent>
---------
Co-authored-by: pa.pecherskij <pa.pecherskij@interfax.ru>
* hey look I knocked out a todo :shockedface:
* Update Resources/Locale/en-US/electrocution/electrocute-command.ftl
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Changed LobbyMusiccollection over to a Cvar and edited ContentAudioSystem.cs to use Cvar Values
* Addedd Ability to modify the lobbyMusiccollection from the command line
* Fixed changing lobby music while in the round
* Deleted uneeded duplicate line
* Removed additional duplicate lobbyplaylist line
* Alphabatized imports and refactored to use Subs.CVar
* Added error checking and default behaviour to CVar sub.
* Refactored to use TryIndex and Allowed for a empty soundcollection when a sound collection is not found. Edited Cvar comment to reflect changes.
* Made _lobbyMusicCollection nullable and addedd handling for null case where used. Also Changed LobbyMusicCollection Cvar over to audio rather than ambience.
* Update Content.Server/Audio/ContentAudioSystem.cs
---------
Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com>