Commit Graph

82 Commits

Author SHA1 Message Date
Pieter-Jan Briers 68ce53ae17
Random spontaneous cleanup PR (#25131)
* Use new Subs.CVar helper

Removes manual config OnValueChanged calls, removes need to remember to manually unsubscribe.

This both reduces boilerplate and fixes many issues where subscriptions weren't removed on entity system shutdown.

* Fix a bunch of warnings

* More warning fixes

* Use new DateTime serializer to get rid of ISerializationHooks in changelog code.

* Get rid of some more ISerializationHooks for enums

* And a little more

* Apply suggestions from code review

Co-authored-by: 0x6273 <0x40@keemail.me>

---------

Co-authored-by: 0x6273 <0x40@keemail.me>
2024-02-13 16:48:39 -05:00
nikthechampiongr 09daa534bd
Fix end of round messages looping forever (#24920)
* Fix End of Round messages looping forever and ever and ever

* Use the correct setting for round restart sounds
2024-02-04 03:43:50 +11:00
Hannah Giovanna Dawson 2e7d23674e
Actually fix round restart audio this time (#24754)
In which I'm a goober and don't clean up after
myself and accientally don't fix the issue I tried
to fix in my last round restart PR.

The audio is now maintained just like music during
restarts (yippee to ContentAudioSystem::OnRoundRestart)

This needs a refactor but at least the defect is fixed now.
2024-02-03 13:11:53 +11:00
metalgearsloth 4a13dbea76
Fix some test warnings (#24324)
Extracted from smug's pr.
2024-01-20 17:15:10 +11:00
Hannah Giovanna Dawson 5af1d0ea8b
Fixes round restart audio clipping (#24044)
* Fix round end audio clipping

* weh

---------

Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2024-01-20 14:40:00 +11:00
metalgearsloth bc07cbc97c
Fix audio fades (#23684)
Audio refactor casualty
2024-01-08 00:23:22 +11:00
metalgearsloth 4023134cf0
Add UI click sounds (#22410)
* Add UI click sounds

* tweaks

* Significant cleanup

* Audio options and numerous fixes

* Fix the remaining UI elements

* new click sound

---------

Co-authored-by: Kara <lunarautomaton6@gmail.com>
2023-12-29 15:43:36 +11:00
Leon Friedrich b6bd82caa6
Use ECS prototype-reload events (#22613)
* Use ECS prototype-reload events

* better constructors

* Maybe this fixes tests?
2023-12-23 01:13:45 +11:00
metalgearsloth 1bdf94da64
Audio fixes (#22324) 2023-12-11 21:26:55 +11:00
metalgearsloth b72c8553d8
Add audio multipliers back (#22260) 2023-12-09 15:18:15 +11:00
metalgearsloth 98d5f9f56b
Make audio sliders use gain not volume (#21984) 2023-12-09 14:03:08 +11:00
metalgearsloth c172e66d7c
Fix ambient audio (#21933) 2023-11-28 14:09:25 +11:00
metalgearsloth 269c93245d
Unrevert audio (#21330)
Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com>
2023-11-27 22:12:34 +11:00
metalgearsloth 5b8f3c48c4
Revert "Update submodule to 175.0.0 (#21318)" (#21319) 2023-10-29 15:29:30 +11:00
metalgearsloth 9b1b3e03ed
Content audio (#20862) 2023-10-29 14:58:23 +11:00
DrSmugleaf f560f88eb5
Remove 700 usages of Component.Owner (#21100) 2023-10-19 12:34:31 -07:00
metalgearsloth 4cfc578011
Revert "Remove most usages of obsolete TransformComponent methods (#1… (#19714) 2023-09-01 12:30:29 +10:00
Visne 1416942bea
Remove most usages of obsolete TransformComponent methods (#19571) 2023-08-30 12:05:19 +10:00
DrSmugleaf a88e747a0b
Refactor serialization copying to use source generators (#19412) 2023-08-22 18:14:33 -07:00
Vordenburg 2cbe8609a3
Make lobby song update occur at round end (#19303) 2023-08-21 14:54:44 -04:00
Abbey Armbruster f708a8dbf5
Add API to change the sound of AmbientSoundComponent (#18115) 2023-08-03 20:36:10 +10:00
metalgearsloth e755509fc7
More miscellaneous compiler warning fixes (#18228) 2023-07-23 16:03:57 +10:00
metalgearsloth 68480af109
Update content vectors to numerics (#17759) 2023-07-08 14:08:32 +10:00
metalgearsloth 1485666a23
Ambient music fixes (#17685) 2023-06-27 21:28:51 +10:00
metalgearsloth 0c83642c5a
Add ambient music (#16829) 2023-05-29 10:44:11 +10:00
eoineoineoin 56b2386870
Fix bug where space music would play even when on station (#16260) 2023-05-13 08:07:04 +10:00
metalgearsloth ae01618874
Revert "Revert "Replace `ResourcePath` with `ResPath` (#15308)" (#155… (#15566) 2023-04-20 20:16:01 +10:00
metalgearsloth acf79a8209
Revert "Replace `ResourcePath` with `ResPath` (#15308)" (#15551) 2023-04-20 11:43:54 +10:00
Ygg01 71f358a027
Replace `ResourcePath` with `ResPath` (#15308) 2023-04-19 23:39:17 +10:00
metalgearsloth 9c03ed805c
Don't play ambience for paused ents (#14269) 2023-02-26 04:19:31 +11:00
Leon Friedrich ccac9efc26
Fix two small ambient sound bugs. (#13249) 2023-01-01 11:40:22 +11:00
Leon Friedrich ae58bb1f1b
Store ambient sound entities on a component tree. (#13110) 2022-12-30 15:10:14 +11:00
Leon Friedrich 75ab0a1127
Fix ambient audio assert (#12938) 2022-12-09 12:16:39 +11:00
Leon Friedrich b771d2423a
Fix ambient sound error (#12808) 2022-12-01 09:02:37 -06:00
Leon Friedrich 8ec2a9ec74
Ambient sound performance improvements (#12756) 2022-11-28 12:10:40 +11:00
Leon Friedrich 6917b0fe17
Misc audio and related changes for replays (#12578) 2022-11-22 11:49:48 +11:00
rolfero 1151ca42e5
changing accumulators to timespan targets (#12407)
* changing accumulators to timespan targets

* Update Content.Server/Abilities/Mime/MimePowersSystem.cs

Co-authored-by: 0x6273 <0x40@keemail.me>

* Update MimePowersSystem.cs

* serializing timespans and adding pausetime where applicable

* remove nullable

Co-authored-by: CommieFlowers <rasmus.cedergren@hotmail.com>
Co-authored-by: 0x6273 <0x40@keemail.me>
2022-11-08 13:59:34 -06:00
theashtronaut 2856213c80
Add lobby music volume slider (#12153) 2022-11-04 11:15:37 +11:00
Jacob Tong 6d297fbb62
Cleanup audio (#11238) 2022-11-04 10:01:53 +11:00
metalgearsloth 0e9213f523
Fix lookup flags (#12235) 2022-10-28 01:09:16 +11:00
Matthias 85a26adcd6
Ambience no longer plays in the lobby (#11416)
Co-authored-by: matthst <32034333+matthst@users.noreply.github.com>
Co-authored-by: Matthias Steinletzberger <matthias.steinletzberger@ntsretail.com>
2022-10-17 15:56:10 +11:00
metalgearsloth 600c0e3255
Fix a few warnings (#11576) 2022-10-04 14:24:19 +11:00
wrexbe 35b90736b7
Minor UI refactor (#11212) 2022-09-11 20:42:12 -07:00
wrexbe c55a015b77
Small UI refactor pieces (#11026)
* ActionType rename Name to DisplayName

* Gameplay State rename+move
2022-09-04 17:21:14 -07:00
metalgearsloth 56b7b175b0
Fix ambient audio nags (#10698) 2022-08-22 05:05:43 +10:00
Visne 58769634c7
Fix a bunch of compiler warnings (#10518) 2022-08-13 22:28:34 -07:00
metalgearsloth 5449835bba
Fix audio occlusion (#10538) 2022-08-11 19:53:28 -07:00
Leon Friedrich c7ad6b709e
Audio System Rejig (#9635) 2022-07-29 12:13:12 +10:00
ike709 0b86e0e953
Event Music & Nuke Countdown Song (#8597)
Co-authored-by: ike709 <ike709@github.com>
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2022-07-04 16:29:38 +10:00
Leon Friedrich 8df89bd055
Misc state handling changes (#9265)
* misc state handling changes

* ambient dirtying
2022-06-29 13:11:09 +10:00