Delta-v/Content.Client/Atmos/EntitySystems
ArtisticRoomba f874459092
Pressure Relief Valve (#36708)
* initial system (this math is probably WRONG)

* General code cleanup and OnExamined support
(holy moly this code sucks)

* UICode and related events foundation
TODO:
- Actually write the XAML UI and the underlying system
- Un-shitcode the entire thing
- Actually test everything...

* Working UI code
TODO: Make predicted, as this certainly isn't predicted. Even though I said it was. It isn't.

* Remove one TODO for unshitcoding the examine code

* Add reminder
yea

* Make predicted (defenitely isn't)
(also defenitely isn't a copypaste from pressure pump code)

* It's predicted!
TODO:
- Give it snazzy predicted visuals!
- Have a different field for pressure entry, lest it gets bulldozed every UI update.

* Improve gas pressure relief valve UI
TODO: Reminder to reduce amount of dirties using deltafields

* Implement DirtyField prediction

* Entity<T> cleanup
A lot of Entity<T> conversions and lukewarm cleanup.

Also got caught copy pasting code in 4K UHD but it's not like you couldn't tell.

* More cleanup and comments

* Remove TODO comment on bulldozing window title

* """refactoring"""
- Move appearance out of shared and finally fix it. Pointless to predict appearance in this instance.
- More Entity<T> conversions because I like them.
- Move UI creation handling over entirely to the ActivatableUI system.
- Fix a hardcoded locale string (why????).

* Add visuals

* Revert debugging variable replacememt
yea

* Revert skissue

* Remove unused using directives and remove TODO

* Localize, cleanup, document

* Fix adminlogging discrepancy

* Add ability to construct, add guidebook entry

* Clear up comment

* Add guidebook tooltip to valve

* Convert GasPressureReliefValveBoundUserInterface declaration into primary constructor

* Adds more input handling and adds autofill on open

* Un-deepfry input validator shitcode
Genuinely what was I smoking

* improve visuals logic

* Refactor again
- Update math to the correct implementation
- Moved code that could be re-used in the future into a helper method under AtmosphereSystem.Gases.cs

* I'm sorry but I hate warnings

* Remove unused using directive in AtmosphereSystem.Gases.cs

* Review and cleanup

* Lukewarm UI glossup

* Maintainer for the upstream project btw

* Remove redundant state sets and messy logic

* Unduplicate valve updater code

* Redo UI (im sorry Slarti)

* run tests

* Test refactored UI messaging

* Second round of UI improvements
- God please find a way to improve this system. Feels bad.

* Update loop implementation

* Further predict UI

* Clear up SetToCurrentThreshold

* cleanup

* Update to master + pipe layers and bug fixes
want to run tests

* fixes

* Deploy rename pipebomb

* Documentation and requested changes

* Rename the method that wiggled away

* Undo rounding changes

* Fix comment

* Rename and cleanup

* Apply suggestions from code review

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-07-03 18:00:34 +02:00
..
AtmosDebugOverlaySystem.cs Improve atmos debug overlay (#22520) 2023-12-15 14:18:00 -08:00
AtmosPipeAppearanceSystem.cs Layering for atmospheric pipes (#36124) 2025-06-01 22:01:43 -07:00
AtmosPipeLayersSystem.cs Layering for atmospheric pipes (#36124) 2025-06-01 22:01:43 -07:00
AtmosphereSystem.cs Draw MapAtmosphere gasses (#17688) 2023-06-28 21:22:03 +10:00
FireVisualizerSystem.cs Cleanup redundant `SpriteSystem` dependencies in `VisualizerSystem`s (#37758) 2025-05-23 14:12:20 -04:00
FirestarterSystem.cs Firestarter fixes (#24647) 2024-02-01 00:01:52 +11:00
GasMinerSystem.cs Add verbose (client predicted!) examine text to Gas Miners (#30480) 2024-08-08 12:14:31 +10:00
GasPressurePumpSystem.cs Fix gas pressure pump prediction (#35865) 2025-03-28 10:42:16 +11:00
GasPressureRegulatorSystem.cs Pressure Relief Valve (#36708) 2025-07-03 18:00:34 +02:00
GasTankSystem.cs Predicted internals (#33800) 2025-05-02 18:22:29 +10:00
GasTileOverlaySystem.cs Purge uses of TransformComponent.GetWorldPositionRotation... variants (#34942) 2025-02-11 14:22:41 +11:00
PipeColorVisualizerSystem.cs Remove some obsolete AppearanceComponent method usages (#13726) 2023-02-02 12:34:53 -04:00