mirror of
https://github.com/DeltaV-Station/Delta-v.git
synced 2026-09-29 23:57:29 +00:00
Sir WarockandQuanteey
75caa105e6
* Fix EvenHealing on bodyParts (#1469) <!-- Guidelines: https://docs.spacestation14.io/en/getting-started/pr-guideline --> <!-- NOTE: All code submitted to this repository is ALWAYS licensed under the AGPL-3.0-or-later license. The REUSE Specification headers or separate .license files indicate a secondary license (e.g., MPL or MIT) solely to facilitate integration for projects that do not use the AGPL license. This secondary license does not replace the fact that AGPL-3.0-or-later remains the primary and binding license. Uncomment and modify the following line if you wish to change the license from the default of AGPL.--> <!--- LICENSE: AGPL --> <!-- What did you change? --> Fixed EvenHealing not working on limb damage when there was no general damage. <!-- Discuss how this would affect game balance or explain why it was changed. Link any relevant discussions or issues. --> When you had a massively burned victim, healing them via aloxadone would heal their general damage, and each limb profited half of that general healing. However, as soon as the general damage was healed, Aloxadone wasn't outputting any healing anymore, since even healing is dependent on damage types on the general damage - And thus, with no healing, the limbs couldn't benefit anymore. This is wrong. I fixed it. <!-- Summary of code changes for easier review. --> Separated the healing of the general damage and limb damage, they are independent of each other. Healing General Damage won't heal limb damage and vice versa. Added a way to heal each limb specifically. I tested it thoroughly, and generally, it worked. Either with multiple different damage types, or just one. Multiple damage parts, or just one. Very much encourage to find a more elegant technical solution. <!-- Attach media if the PR makes ingame changes (clothing, items, features, etc). Small fixes/refactors are exempt. Media may be used in SS14 progress reports with credit. --> I can't do videos, but videos would be required. Please try it out yourself. <!-- Confirm the following by placing an X in the brackets [X]: --> - [X] I have read and am following the [Pull Request and Changelog Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html). - [X] I have added media to this PR or it does not require an ingame showcase. - [X] I can confirm this PR contains no AI-generated content, and did not use any AI-generated content. <!-- You should understand that not following the above may get your PR closed at maintainer’s discretion --> <!-- List any breaking changes, including namespaces, public class/method/field changes, prototype renames; and provide instructions for fixing them. This will be posted in #codebase-changes. --> **Changelog** <!-- Add a Changelog entry to make players aware of new features or changes that could affect gameplay. Make sure to read the guidelines and take this Changelog template out of the comment block in order for it to show up. Changelog must have a 🆑 symbol, so the bot recognizes the changes and adds them to the game's changelog. --> 🆑 - fix: Fixed Chemicals with the EvenHealing attribute to not work on patient's limbs without General Damage. Aloxadone will now finally heal the burned Salvager's limbs. * Fix Port to Delta * Fixes * Made comments even more commenty? Signed-off-by: Sir Warock <67167466+SirWarock@users.noreply.github.com> * Update Content.Shared/Damage/Systems/DamageableSystem.cs Co-authored-by: Quanteey <61941975+Quanteey@users.noreply.github.com> Signed-off-by: Sir Warock <67167466+SirWarock@users.noreply.github.com> * Add Comments * Update Content.Shared/EntityEffects/Effects/EvenHealthChange.cs Co-authored-by: Quanteey <61941975+Quanteey@users.noreply.github.com> Signed-off-by: Sir Warock <67167466+SirWarock@users.noreply.github.com> * Update Content.Shared/Damage/Systems/DamageableSystem.cs Co-authored-by: Quanteey <61941975+Quanteey@users.noreply.github.com> Signed-off-by: Sir Warock <67167466+SirWarock@users.noreply.github.com> * Fix Comments * Update Content.Shared/EntityEffects/Effects/EvenHealthChange.cs Co-authored-by: Quanteey <61941975+Quanteey@users.noreply.github.com> Signed-off-by: Sir Warock <67167466+SirWarock@users.noreply.github.com> * commenty commenta WHEN DO THE COMMENTS END --------- Signed-off-by: Sir Warock <67167466+SirWarock@users.noreply.github.com> Co-authored-by: Quanteey <61941975+Quanteey@users.noreply.github.com>