Delta-v/Content.Server/Atmos/EntitySystems
ArtisticRoomba f874459092
Pressure Relief Valve (#36708)
* initial system (this math is probably WRONG)

* General code cleanup and OnExamined support
(holy moly this code sucks)

* UICode and related events foundation
TODO:
- Actually write the XAML UI and the underlying system
- Un-shitcode the entire thing
- Actually test everything...

* Working UI code
TODO: Make predicted, as this certainly isn't predicted. Even though I said it was. It isn't.

* Remove one TODO for unshitcoding the examine code

* Add reminder
yea

* Make predicted (defenitely isn't)
(also defenitely isn't a copypaste from pressure pump code)

* It's predicted!
TODO:
- Give it snazzy predicted visuals!
- Have a different field for pressure entry, lest it gets bulldozed every UI update.

* Improve gas pressure relief valve UI
TODO: Reminder to reduce amount of dirties using deltafields

* Implement DirtyField prediction

* Entity<T> cleanup
A lot of Entity<T> conversions and lukewarm cleanup.

Also got caught copy pasting code in 4K UHD but it's not like you couldn't tell.

* More cleanup and comments

* Remove TODO comment on bulldozing window title

* """refactoring"""
- Move appearance out of shared and finally fix it. Pointless to predict appearance in this instance.
- More Entity<T> conversions because I like them.
- Move UI creation handling over entirely to the ActivatableUI system.
- Fix a hardcoded locale string (why????).

* Add visuals

* Revert debugging variable replacememt
yea

* Revert skissue

* Remove unused using directives and remove TODO

* Localize, cleanup, document

* Fix adminlogging discrepancy

* Add ability to construct, add guidebook entry

* Clear up comment

* Add guidebook tooltip to valve

* Convert GasPressureReliefValveBoundUserInterface declaration into primary constructor

* Adds more input handling and adds autofill on open

* Un-deepfry input validator shitcode
Genuinely what was I smoking

* improve visuals logic

* Refactor again
- Update math to the correct implementation
- Moved code that could be re-used in the future into a helper method under AtmosphereSystem.Gases.cs

* I'm sorry but I hate warnings

* Remove unused using directive in AtmosphereSystem.Gases.cs

* Review and cleanup

* Lukewarm UI glossup

* Maintainer for the upstream project btw

* Remove redundant state sets and messy logic

* Unduplicate valve updater code

* Redo UI (im sorry Slarti)

* run tests

* Test refactored UI messaging

* Second round of UI improvements
- God please find a way to improve this system. Feels bad.

* Update loop implementation

* Further predict UI

* Clear up SetToCurrentThreshold

* cleanup

* Update to master + pipe layers and bug fixes
want to run tests

* fixes

* Deploy rename pipebomb

* Documentation and requested changes

* Rename the method that wiggled away

* Undo rounding changes

* Fix comment

* Rename and cleanup

* Apply suggestions from code review

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-07-03 18:00:34 +02:00
..
AirFilterSystem.cs Resolve all non-obsoleting warnings in content (#27934) 2024-05-11 20:13:58 -07:00
AirtightSystem.cs Clean up all missing `EntitySystem` proxy method uses (#38353) 2025-06-26 16:50:49 -07:00
AtmosDebugOverlaySystem.cs Run `fixgridatmos` for cargo & emergency shuttle (#26382) 2024-03-25 03:17:56 +11:00
AtmosExposedSystem.cs Move GasMixture to shared (#27480) 2024-04-30 14:31:05 -07:00
AtmosPipeLayersSystem.cs Fix some popup issues with pipe layer changes (#38244) 2025-06-11 22:31:48 -07:00
AtmosphereSystem.API.cs Move GasMixture to shared (#27480) 2024-04-30 14:31:05 -07:00
AtmosphereSystem.CVars.cs Random spontaneous cleanup PR (#25131) 2024-02-13 16:48:39 -05:00
AtmosphereSystem.Commands.cs fix atmos grid markers (#37142) 2025-05-03 09:11:31 +02:00
AtmosphereSystem.ExcitedGroup.cs Only auto-enable internals when necessary (#28248) 2024-05-31 12:28:11 +10:00
AtmosphereSystem.Gases.cs Pressure Relief Valve (#36708) 2025-07-03 18:00:34 +02:00
AtmosphereSystem.GridAtmosphere.cs Predicted internals (#33800) 2025-05-02 18:22:29 +10:00
AtmosphereSystem.HighPressureDelta.cs Convert `AtmosphereSystem` sound path strings to `SoundSpecifier`s (#38403) 2025-06-17 22:52:11 +02:00
AtmosphereSystem.Hotspot.cs Convert `AtmosphereSystem` sound path strings to `SoundSpecifier`s (#38403) 2025-06-17 22:52:11 +02:00
AtmosphereSystem.LINDA.cs Use archived gas mixture in gas exchange comparison (#32088) 2024-09-29 22:14:07 -07:00
AtmosphereSystem.Map.cs Move GasMixture to shared (#27480) 2024-04-30 14:31:05 -07:00
AtmosphereSystem.Monstermos.cs Fix for obsolete method warning in AtmosphericsSystem (#37897) 2025-05-28 11:16:54 +02:00
AtmosphereSystem.Processing.cs Clean up all missing `EntitySystem` proxy method uses (#38353) 2025-06-26 16:50:49 -07:00
AtmosphereSystem.Superconductivity.cs Use archived gas mixture in gas exchange comparison (#32088) 2024-09-29 22:14:07 -07:00
AtmosphereSystem.Utils.cs Fix for obsolete method warning in AtmosphericsSystem (#37897) 2025-05-28 11:16:54 +02:00
AtmosphereSystem.cs Content changes for SetTiles change (#37229) 2025-05-15 20:26:47 +10:00
AutomaticAtmosSystem.cs AutomaticAtmosSystem uses MassDataChangedEvent, clarifies TileMassMultiplier (#37548) 2025-05-17 21:57:50 -04:00
BarotraumaSystem.cs Remove AlertType and AlertCategory (#27933) 2024-05-23 22:43:04 -04:00
FirestarterSystem.cs Firestarter fixes (#24647) 2024-02-01 00:01:52 +11:00
FlammableSystem.cs Clean up all missing `EntitySystem` proxy method uses (#38353) 2025-06-26 16:50:49 -07:00
GasAnalyzerSystem.cs Fix gas analyzer and anom scanner wrong state (#38285) 2025-06-12 14:16:07 -07:00
GasMinerSystem.cs Add verbose (client predicted!) examine text to Gas Miners (#30480) 2024-08-08 12:14:31 +10:00
GasTankSystem.cs Move PriceCalculationEvent and EstimatedPriceCalculationEvent to shared (#37782) 2025-05-24 19:36:38 +02:00
GasTileOverlaySystem.cs Fix NRE in GasTileOverlaySystem (#36793) 2025-04-21 15:06:54 +10:00
HeatExchangerSystem.cs Atmos device performance improvements (#26493) 2024-03-30 15:17:53 +11:00
PipeRestrictOverlapSystem.cs Layering for atmospheric pipes (#36124) 2025-06-01 22:01:43 -07:00