mirror of
https://github.com/DeltaV-Station/Delta-v.git
synced 2026-10-01 16:47:26 +00:00
Moony
6656adc083
* Pass 1. * i'm FREE * Prevent hangups. * okay fine here's an attribute for settings, will polish later and prolly remove the overridable thing. * sigh. * fix singular trigger bug so LatheTest doesn't flake. * Remove SystemAttribute usage. * Poke * I used the shotgun. You know why? Cause the shot gun doesn’t miss, and unlike the shitty hybrid taser it stops a criminal in their tracks in two hits. Bang, bang, and they’re fucking done. I use four shots just to make damn sure. Because, once again, I’m not there to coddle a buncha criminal scum sucking f------, I’m there to 1) Survive the fucking round. 2) Guard the armory. So you can absolutely get fucked. If I get unbanned, which I won’t, you can guarantee I will continue to use the shotgun to apprehend criminals. Because it’s quick, clean and effective as fuck. Why in the seven hells would I fuck around with the disabler shots, which take half a clip just to bring someone down, or with the tazer bolts which are slow as balls, impossible to aim and do about next to jack shit, fuck all. The shotgun is the superior law enforcement weapon. Because it stops crime. And it stops crime by reducing the number of criminals roaming the fucking halls. * Change the faulty store test into two tests, one of which is ignored for failing.
64 lines
2.4 KiB
C#
64 lines
2.4 KiB
C#
#nullable enable
|
|
using System.Collections.Generic;
|
|
using Content.IntegrationTests.Fixtures;
|
|
using Content.Shared.Item;
|
|
using Robust.Client.GameObjects;
|
|
using Robust.Shared.GameObjects;
|
|
using Robust.Shared.Prototypes;
|
|
|
|
namespace Content.IntegrationTests.Tests.Sprite;
|
|
|
|
/// <summary>
|
|
/// This test checks that all items have a visible sprite. The general rationale is that all items can be picked up
|
|
/// by players, thus they need to be visible and have a sprite that can be rendered on screen and in their hands GUI.
|
|
/// This has nothing to do with in-hand sprites.
|
|
/// </summary>
|
|
/// <remarks>
|
|
/// If a prototype fails this test, its probably either because it:
|
|
/// - Should be marked abstract
|
|
/// - inherits from BaseItem despite not being an item
|
|
/// - Shouldn't have an item component
|
|
/// - Is missing the required sprite information.
|
|
/// If none of the abveo are true, it might need to be added to the list of ignored components, see
|
|
/// <see cref="Ignored"/>
|
|
/// </remarks>
|
|
[TestFixture]
|
|
public sealed class PrototypeSaveTest : GameTest
|
|
{
|
|
private static readonly HashSet<string> Ignored = new()
|
|
{
|
|
// The only prototypes that should get ignored are those that REQUIRE setup to get a sprite. At that point it is
|
|
// the responsibility of the spawner to ensure that a valid sprite is set.
|
|
"VirtualItem",
|
|
"HandPlaceholder" // Frontier
|
|
};
|
|
|
|
[Test]
|
|
public async Task AllItemsHaveSpritesTest()
|
|
{
|
|
var pair = Pair;
|
|
List<EntityPrototype> badPrototypes = [];
|
|
|
|
await pair.Client.WaitPost(() =>
|
|
{
|
|
foreach (var (proto, _) in pair.GetPrototypesWithComponent<ItemComponent>(Ignored))
|
|
{
|
|
var dummy = pair.Client.EntMan.Spawn(proto.ID);
|
|
pair.Client.EntMan.RunMapInit(dummy, pair.Client.MetaData(dummy));
|
|
var spriteComponent = pair.Client.EntMan.GetComponentOrNull<SpriteComponent>(dummy);
|
|
if (spriteComponent?.Icon == null)
|
|
badPrototypes.Add(proto);
|
|
pair.Client.EntMan.DeleteEntity(dummy);
|
|
}
|
|
});
|
|
|
|
Assert.Multiple(() =>
|
|
{
|
|
foreach (var proto in badPrototypes)
|
|
{
|
|
Assert.Fail($"Item prototype has no sprite: {proto.ID}. It should probably either be marked as abstract, not be an item, or have a valid sprite");
|
|
}
|
|
});
|
|
}
|
|
}
|