Apply RoleLoadout MinLimit fix to EnsureValid too (#29358)

Apply MinLimit fix to EnsureValid too
This commit is contained in:
Tayrtahn 2024-06-22 22:17:28 -04:00 committed by null
parent fb93bc0ac3
commit d06ff65bbe
No known key found for this signature in database
GPG Key ID: 212F05528FD678BE
1 changed files with 6 additions and 5 deletions

View File

@ -124,9 +124,12 @@ public sealed partial class RoleLoadout : IEquatable<RoleLoadout>
// If you put invalid ones first but that's your fault for not using sensible defaults
if (loadouts.Count < groupProto.MinLimit)
{
for (var i = 0; i < Math.Min(groupProto.MinLimit, groupProto.Loadouts.Count); i++)
foreach (var protoId in groupProto.Loadouts)
{
if (!protoManager.TryIndex(groupProto.Loadouts[i], out var loadoutProto))
if (loadouts.Count >= groupProto.MinLimit)
break;
if (!protoManager.TryIndex(protoId, out var loadoutProto))
continue;
var defaultLoadout = new Loadout()
@ -193,11 +196,10 @@ public sealed partial class RoleLoadout : IEquatable<RoleLoadout>
if (groupProto.MinLimit > 0)
{
// Apply any loadouts we can.
var addedCount = 0;
foreach (var protoId in groupProto.Loadouts)
{
// Reached the limit, time to stop
if (addedCount >= groupProto.MinLimit)
if (loadouts.Count >= groupProto.MinLimit)
break;
if (!protoManager.TryIndex(protoId, out var loadoutProto))
@ -214,7 +216,6 @@ public sealed partial class RoleLoadout : IEquatable<RoleLoadout>
loadouts.Add(defaultLoadout);
Apply(loadoutProto);
addedCount++;
}
}
}