* Add the instrument to the MIDI channel selector
* Reviews
Adds support for chained masters
Makes the channel UI update on its own when the midi changes (Works with bands too!)
* add to admin logs and limit track count
* Limit track names by length too
* remove left over comment
* Requested changes
* Reviews
* Add the instrument to the MIDI channel selector
* Reviews
Adds support for chained masters
Makes the channel UI update on its own when the midi changes (Works with bands too!)
* add to admin logs and limit track count
* Limit track names by length too
* remove left over comment
* Requested changes
* Reviews
* Remove some BUI boilerplate
- The disposals overrides got removed due to the helper method handling it.
- Replace window creation with CreateWindow helper.
- Fixed some stinky code which would cause exceptions.
* More
* moar
* weh
* done
* More BUIs
* More updates
* weh
* moar
* look who it is
* weh
* merge
* weh
* fixes
* Use new Subs.CVar helper
Removes manual config OnValueChanged calls, removes need to remember to manually unsubscribe.
This both reduces boilerplate and fixes many issues where subscriptions weren't removed on entity system shutdown.
* Fix a bunch of warnings
* More warning fixes
* Use new DateTime serializer to get rid of ISerializationHooks in changelog code.
* Get rid of some more ISerializationHooks for enums
* And a little more
* Apply suggestions from code review
Co-authored-by: 0x6273 <0x40@keemail.me>
---------
Co-authored-by: 0x6273 <0x40@keemail.me>
(cherry picked from commit 68ce53ae17985876d6d112b764b2144964a9f42e)
SS14-1148 Fix MIDI Loading Failing Whilst a MIDI is playing
The behaviour of the button event handling did some wonky
async handling that got PJB swearing repeatedly in the contributor
VC.
Improve switching MIDI songs by:
0. Add a bool that tracks if we're currently waiting for the MIDI file
browser to terminate. Use this bool to short-circuit the
MidiFileButtonOnPressed function, ensuring you don't have to close
a morbillion file windows if you spam-clicked the button or forgot
you'd opened the window.
1. Remove a four-year-old hack involving waiting 100ms to load a MIDI
after trying to stop the last MIDI, because _the rot consumes_ or some shit
(cherry picked from commit 1defdebd7bb29cafa1f4cb4ef496ef6928634168)
Errant
Pieter-Jan Briers
Simon
Quanteey
Milon
SpaceManiac
slarticodefast
metalgearsloth
Nemanja
Leon Friedrich
Hannah Giovanna Dawson
Kara
DrSmugleaf
Vera Aguilera Puerto
TemporalOroboros
Morb
Andreas Kämper
wrexbe
metalgearsloth
Vera Aguilera Puerto
20kdc
Visne