* feat: added lslaws command
* feat: add lswatchlisted command
* tweak: nicer formatting for lswatchlisted
* tweak: nicer formatting for lslaws
* feat: lsobjectives lists everyone's objectives if no user specified
* feat: mark ghosted players in players tab
* docs: add missing DeltaV patch comment
* feat: only alert admins if meatspiking player characters
* feat: always alert about station explosions, don't spam off-station alerts
* feat: stripping alert tweaks
* feat: admin alert on low hour latejoin
* refactor: forgot to make onspawncomplete non-async, wasn't necessary after all
* feat: EORG alerts
* feat: getping command
* refactor: remove unused imports, format
* refactor: early return in onspawncomplete
* feat: add coordinate link to eorg destroy alert
* tweak: cache watchlist data to avoid db calls, use in lswatchlisted
* fix: null-check in OnNoteAdded
* feat: watchlist indicator on admin overlay
* feat: optionally mark watchlisted in f7 players
* feat: refresh admin playerlist data on wl change
* fix: update player list after cache write
* feat: add tp links to prayer messages
* tweak: don't alert when uncuffing self
* tweak: lower uncuff other alert impact if mindshielded
* docs: add deltav comments to imports
* refactor: address review comments
* style: deltav comments on same line as change
* performance: get metadata only if objectives > 0
* fix: actually check user if explosion gridPos not on station
* style: remove extraneous newlines
* refactor: use fancy getOrNew method
* feat: refresh player list UI if marking pref changed
* feat: latejoin alert hours configurable
* fix: also list objectives for non-humanoids and dead people
Fixes#26211
Admin messages now have separate "seen" and "dismissed" fields. The idea is that an admin should be able to tell whether a user pressed the "dismiss for now" button. Instead of using "seen" as "show this message to players when they join", "dismissed" is now used for this.
Existing notes in the database will automatically be marked as dismissed on migration. A note cannot be dismissed without being seen (enforced via constraint in the database too, aren't I fancy).
As part of this, it has become impossible for a player to play without dismissing the message in some form. Instead of a shitty popup window, the popup is now a fullscreen overlay that blocks clicks behind it, making the game unplayable. Also, if a user somehow has multiple messages they will be combined into one popup.
Also I had enough respect for the codebase to make it look better and clean up the code somewhat. Yippee.
(cherry picked from commit d776c4b392a082dba7539d77cfa20fc904ed4091)
God bloody christ. There's like three layers of shit here.
So firstly, apparently we were still using Npgsql.EnableLegacyTimestampBehavior. This means that time values (which are stored UTC in the database) were converted to local time when read out. This meant they were passed around as kind Local to clients (instead of UTC in the case of SQLite). That's easy enough to fix just turn off the flag and fix the couple spots we're passing a local DateTime ez.
Oh but it turns out there's a DIFFERENT problem with SQLite: See SQLite we definitely store the DateTimes as UTC, but when Microsoft.Data.Sqlite reads them it reads them as Kind Unspecified instead of Utc.
Why are these so bad? Because the admin notes system passes DateTime instances from EF Core straight to the rest of the game code. And that means it's a PAIN IN THE ASS to run the necessary conversions to fix the DateTime instances. GOD DAMNIT now I have to make a whole new set of "Record" entities so we avoid leaking the EF Core model entities. WAAAAAAA.
Fixes#19897
(cherry picked from commit 2e6eaa45c57c7f5ba561d1fb1ef6712d2432a8fa)
* Use new Subs.CVar helper
Removes manual config OnValueChanged calls, removes need to remember to manually unsubscribe.
This both reduces boilerplate and fixes many issues where subscriptions weren't removed on entity system shutdown.
* Fix a bunch of warnings
* More warning fixes
* Use new DateTime serializer to get rid of ISerializationHooks in changelog code.
* Get rid of some more ISerializationHooks for enums
* And a little more
* Apply suggestions from code review
Co-authored-by: 0x6273 <0x40@keemail.me>
---------
Co-authored-by: 0x6273 <0x40@keemail.me>
(cherry picked from commit 68ce53ae17985876d6d112b764b2144964a9f42e)
DisposableCrewmember42
Tayrtahn
Pieter-Jan Briers
LankLTE
Leon Friedrich
DrSmugleaf
Visne
Riggle
metalgearsloth
Ygg01