* holy shit?
* final touches
* this is dumb
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* whatever go my integration tests
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* whoopsie forgot blacklists
* load bearing loc
* minor stuff
* whoopsie
* cool
* I LOVE REFLECTION
* got a call from the stink department
* i love fluent yes
* direction changes
* waiter more migrations please
* typo ops
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Tobias Berger <toby@tobot.dev>
* somewhat functional yes
* some cleanup
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* review
* missed one
* why not params…
* review 2
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Persist construction menu favorites to player profile
* Use `ProtoId`s for construction favorites
* Validate construction favorites updates from the client
* Actually await the async database call
* Fix glass duplication with beakers (#34441)
Update chemistry.yml
Fixing glass dupe.
* Automatic changelog update
* Heterochromia for Moth (#36061)
* 1
* Fix local
* formatting
---------
Co-authored-by: Milon <milonpl.git@proton.me>
* Salvage Airlock (#36375)
* Salvage
* atmos a
* more muted colours
* Mapping Related to AI
* Fixed small naming inconsistency
* Revert "Fixed small naming inconsistency"
This reverts commit 985e1fd46a09e521c11dc345f470228e7907fbb9.
* Revert "Mapping Related to AI"
This reverts commit 5d5ae4feb819396c5c2a7413399ab5ce34f8683b.
* Revert "atmos a"
This reverts commit 529831e2584df27fa102ee1c970948fa3b6bab56.
* indent
---------
Co-authored-by: Milon <milonpl.git@proton.me>
* Automatic changelog update
* Departmental shelves whitelist expansion (Attempt №3) (#34292) (disabled)
* Expand-Shelves-Whitelist
Made departmental shelves hold a wider variety of items.
* Accidentally included "Packet" twice
* Automatic changelog update
* Replace GetEntitiesInTile with EntityLookupSystem equivalent (#36756)
* commit GET!!
* minor cleanup
* Automatic changelog update
* Unused dependency cleanup. (#36760)
* take 2! fight!!!
* final touches
* reeeeeee
* Fire protection for ERT engineering hardsuit (#34949)
* Automatic changelog update
* Nonlethal throwables crate (#35808)
* Automatic changelog update
* Use non-generic TryComp in `StationSpawningSystem` (#36769)
Use non-generic TryComp in StationSpawningSystem
* Add marker components for admin shenanigans (#36776)
* Automatic changelog update
* Restore `LimitedChargesComponent.MaxCharges` default value to 3 (#36778)
* Wizard Figure Voiceline Fix#36771 (#36779)
DA WIZARDgit add -A
* change MV cable outline (#36751)
* change MV cable outline
* zamn
* The Beverage Jug Can Now Look Open (#36070)
* GenJug-Changes
Signed-off-by: Prole <172158352+Prole0@users.noreply.github.com>
* Guh
Signed-off-by: Prole <172158352+Prole0@users.noreply.github.com>
* Support For the Rest
Signed-off-by: Prole <172158352+Prole0@users.noreply.github.com>
* New Sprites
Signed-off-by: Prole <172158352+Prole0@users.noreply.github.com>
* Newest Sprites
Signed-off-by: Prole <172158352+Prole0@users.noreply.github.com>
---------
Signed-off-by: Prole <172158352+Prole0@users.noreply.github.com>
* Pirate Gear Tweaks. (#35986)
* Tweaked pirate gear to be in-line with similar items.
* Added attribution for flashlight sprites, made hardsuits Major Contraband
* Added empty versions of the pirate revolver and flintlock.
* Test fail fix hopefully?
* Test fail fix hopefully V2.0
* Test fail fix hopefully V3.0
* Test fail fix hopefully V4.0
---------
Co-authored-by: RedBookcase <Usualmoves@gmail.com>
* Automatic changelog update
* Markings overhaul (#35938)
* markings displacement setup
* ok i got it!
* fix map updating
* remove trackingLayers
* markings clean up and modernizize
* marking disabling displacements
* markings restriction
* dehihienize
* dehihiniezize 2
* aa
* nice
* Automatic changelog update
* Resprite main altars (#35685)
* resprite main altars
* updated meta.json
* Automatic changelog update
* Adds beanies to the WinterDrobe! (#32946)
* sprites
* messing with the ymls
* new sprites
* that's a lotta yaml
* make the sprites gooder
* color adjustment
* to the winterdrobe with you
* layering fix
* Automatic changelog update
* Santa hat with a foldable beard (#36510)
* Added foldable component to santa hat
* Modified sprites, modified YAML. YAML is cursed
* Changed santa hat description to mention the beard fold
* Removed HideLayerClothing since it doesnt work
* Changed the prefix from "beard" to "nobeard" to match with the fold/unfold verb
* Credits for sprite changes
---------
Co-authored-by: Lanedon <matth.galvez@gmail>
* Automatic changelog update
* Puddle Code Slipping Cleanup (#35845)
* Init Commit
* windows yelling at me to update commit
* working commit, need prediciton and more dehardcoding
* Project 0 warnings
* Working Commit (Near Final)
* ryder got confused commit
* I love Merge Conflicts :)
* Working commit, no prediction
* Forgot the yaml changes
* Comments and typos
* Apparently while the reduced launch mult of lube was initialized it was never used so I revered back to default
* Fixed an incorrect divisor
* bit of cleanup
* Prediciton fixed, and puddles now affect all entities
* FORGOT TO RENAME A VERY IMPORTANT VARIABLE OOPS
* Really big I forgor moment
* Even bigger I forgor moment
* four more merge conflicts to fix four more oopsies
* fixed actual divide by zero moment and also im very dumb
* Even bigger I forgor moment
* four more merge conflicts to fix four more oopsies
* fixed actual divide by zero moment and also im very dumb
* Fix all test fails
* code cleanup
* Webedit whitespace
* Code cleaup
* whitespace webedit
* whitespace webedit
* whitespace webedit
* whitespace removal
* Comments and cleanup
* Re-Added 20 warnings as per Ork's request
* Cleanups
* Spacing fix
* bugfixes and cleanup
* Small bugfix
* Actually dirty the slipComp for real
* Added Friction field to Reagent Prototype per design discussion
* Sliding system is kill
* The Bartender can now make Eggnog (#34065)
* Preliminary eggnog changes (egg in shaker crashes?)
* Fixed eggnog reagent name and description
* added - to flavor
* deleted a space
* Added eggnog glass sprite
* changed fill levels to match rsi
* Added two more fill levels to eggnog
* Removed fizziness, changed physical description, and fixed rsi
---------
Co-authored-by: uhbg <29674581+uhbg@users.noreply.github.com>
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
* Automatic changelog update
* Require traitors to maroon their objective no matter what (#35825)
* jesus
* okay.
* OOPS
* ok
* ok
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* ok
* Update Resources/Prototypes/Objectives/paradoxClone.yml
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Update Resources/Prototypes/Objectives/base_objectives.yml
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* m
* ok
* ok
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Wizard Headset (#35732)
* wizardcomms
* wizheadset
* Addressed requested changes and axed wizard channel due to redundancy.
* oops overlooked this, dont tell anyone
* another mistake fixed
* removed wiz encryption key due to redundancy
* accidentally left some punctuation in a now unrelated meta.json
* Automatic changelog update
* Remove MK ULTRA ai name (#35726)
* Remove bad AI names
* Fine, I won't try to sneak this in here.
* Reorder electronics recipe file, add filter categories (#35713)
* electronics split
* split base recipe and category
* all but machines
* machine shuffle
* reorder
* delete unused recipes
* rename cargo to supply
* git weirdness
* git weirdness 2
* Automatic changelog update
* Cleanup warnings in `SharedPortalSystem` (#36747)
* Cleanup warnings in SharedPortalSystem
* Formatting while we're here
* Replace uses of !Any() with Count == 0
* AnyEntitiesIntersecting
* Binomial Number Selector for EntityTables (#36783)
* binomial dist
* lol initialize the int tho idiot
* xml docs my forgotten
* ditto
* Add more ruins (#36785)
* Fix NRE in GasTileOverlaySystem (#36793)
* Automatic changelog update
* Add RGA/RSI to Credits (#36704)
* Add RGA and RSI to Credits
* Move to thread + add directory field
* Further Allocation Tweaks (#36800)
* init
* fix lockboxes
* Automatic changelog update
* Add the medical HUDs to medical's loadouts (except chem) (#32847)
Added the medical HUD and eyepatch to the medical (CMO, doctor, paramed and intern) loadout to let them choose between. Also gives the option for the regular glasses.
* Automatic changelog update
* new salv ruins (#36798)
* hotplate, kitcken grille bugfixes (#34776)
* commit
* cleanup
* Automatic changelog update
* Solution drag and drop now checks if container is closed and drainable (#34683)
drainable fix
* Automatic changelog update
* fix some datasets (#36806)
* Add rehydratable mop bucket cube, refactor the rehydratable yml (#34586)
* Refactor rehydratable items
* Finish main refactor
* Add mop bucket cube
* Move cube sprite and item size to RehydratableAnimalCube
* Fix sprite attribution
* Make it follow the conventions
* Refactor wrapped cube, leave MonkeyCube tag only on the cube and the Syndie Sponge
* Fix DehydratedSpaceCarp inheritance overwriting needed components
* no need for this comment
* remove whitespace
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* indentation
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Restore lost description
* reorder stuff
* line
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Automatic changelog update
* Increase thief to player ratio (#36531)
* reduce max number of traitors, increase thief to player ratio
* revert traitor max back to 8
* Automatic changelog update
* Added a semi-functional genderfluid pin. (#35854)
* Added a semi-function GenderfluidPin
* Update pins.yml
fix bug
* Fix meta.json under the newly merged "fix as you go" policy
* Update pin description
---------
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
* Automatic changelog update
* Station AI Name Identifier (#36801)
init
* Automatic changelog update
* Makes EventRole Ids properly set ID names. (#28958)
* Add id binding system
* Change so it activates when added too
* Add to eventhumanoid
* Add PDA binding, try to fix some things
* Still not fixed, PDA is working right
* Move to server, add on mind instead
* Implement suggestions
* Fix things
* Finish review stuff
* Messed up cluwne
* Remove after only changing id too
---------
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
* Various sharedsystem spring cleaning (#36200)
* Various shared system warnings cleanup
* More shared system warnings cleanup
* Rearranging changes
* Using correct transform for unbuckle
* Small changes
* Revert buckle change
* Update Content.Shared/Ghost/SharedGhostSystem.cs
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Fix some locale strings and make some code for them looks better (#32003)
* Fix a lot locale strings
add functions using
fix identity for meat spike and creaming
* comma
* fixes for fixes
* yeah
* fuck
* Automatic changelog update
* Remove non-functional ninja exemption from `SpawnAndDeleteEntityCountTest` (#36813)
Remove non-functional ninja exemption from SpawnAndDeleteEntityCountTest
* Firelock temperature and pressure warning lights (#28339)
* Add temperature and pressure lights to firelocks
* Replace sprites with new pressure and temperature light versions
* Remove obsolete deny and locked sprites
* Add SpriteSync for warning light animation synchronization
* Teal lights
* Partial animation implementation
* fixup! Teal lights
* Temperature lights
* Adjusted firelock light heights and added final warning light sprites
* Fix colors
* Testing colors
* Update light sprites
* updated sprites
---------
Co-authored-by: EmoGarbage404 <retron404@gmail.com>
* Automatic changelog update
* Fix bots parenting, emotes (#29949)
* Bots overhaul
* fix
* change speech sound to pai
* purge a lot
* i forgor :trollface:
* adjust
* that aswell
* Automatic changelog update
* Fix identity grammar (#36817)
Fix identity
* Fix Animal Versions of Captain Uniform (#36804)
* scienceevasuit
* update money uniforms
* update meta.json files and hamster hats
* revert scienceevasuit
* revert accidental prisoner eva change
* Automatic changelog update
* Fix vox hair (#36816)
* Fix vox hair
* remove CL
* Tweak Security protection values (#30212)
* Tweak Hardsuits
* HoS/Ward Coats change
* Whoopsie wrong number
god why am i doing this its 1:33 AM and i made a silly mistake...
* Adress Review
Revert Warden hardsuit slowdown to 30% again
Decreased Security hardsuit heat protection down to 20%
* Automatic changelog update
* Added more salvage ruins (#36822)
* Metal foam grenade rework, small tweaks to grenade timers (#34579)
* Automatic changelog update
* dragons can now pry doors (#36811)
* Automatic changelog update
* Make funding allocation computer more configurable (#36790)
* Make funding allocation computer more configurable
* admin logging
* unused
* ccvar enabled
---------
Co-authored-by: ScarKy0 <scarky0@onet.eu>
* Automatic changelog update
* Fingerprint taking improvements (#31864)
* now using event to check access to fingerprint
* Opps actually commiting the changes
---------
Co-authored-by: YourUsername <you@example.com>
Co-authored-by: beck-thompson <beck314159@hotmail.com>
* Banana cream pie loc improvements (#36829)
* CAPITALIZE(THE($owner))
* Rename "thrower" to "thrown"; use THE($thrown)
* "the banana cream pie" -> "a banana cream pie"
* Simplify filter
* Automatic changelog update
* Command uniform (#32103)
* Added generic command jumpskirt, jumpsuit and cap, and made them available in the HoP's clothing printer.
* fixed generic command jumpskirt and jumpsuit.
* Updated generic command jumpskirt/-suit textures, added generic command beret.
* Fixed game-breaking bug in previous commit relating to the command beret.
* altered generic command soft cap/baseball cap sprites.
* Update Resources/Prototypes/Entities/Clothing/Head/hats.yml
Co-authored-by: SlamBamActionman <83650252+SlamBamActionman@users.noreply.github.com>
* Update Resources/Prototypes/Entities/Clothing/Uniforms/jumpskirts.yml
Co-authored-by: SlamBamActionman <83650252+SlamBamActionman@users.noreply.github.com>
* Update Resources/Prototypes/Entities/Clothing/Uniforms/jumpsuits.yml
Co-authored-by: SlamBamActionman <83650252+SlamBamActionman@users.noreply.github.com>
* review
* whoopsie
---------
Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com>
Co-authored-by: SlamBamActionman <83650252+SlamBamActionman@users.noreply.github.com>
Co-authored-by: Milon <milonpl.git@proton.me>
* Automatic changelog update
* downprice many cargo orders (#32375)
* atmos repricing
* emitter crate
* materials
* lasers
* revert gun prices
* Automatic changelog update
* Ashen hud item status slot fix (#31411)
* new patchMargin variable added, horizontals fixed
* All sides now work, system is fully integarated
---------
Co-authored-by: Zachary Yona <magicalusf@gmail.com>
* Ashtray Resprite and Fix (#31643)
* The meat and potatoes
Yup
* Stupid recycler
bruh
* guh
guh
* Update MinorAntagonists.xml (#36836)
* Simulate command in minutes for real (#36808)
* 60
* Fix warning CS0414 instances (#36832)
Fix warning cs0414 instances
* Nerf Firelock electronic prices (#33469)
* Nerf Firelock electronic prices
- make firelock electronics price half of the input cost to make one
(27) rounded up
* Why does firelock make glass?
- remove the Physical composition of glass from
FirelockElectronics as the input does not contain glass
and the output cannot contain half a steel and plastic
---------
Co-authored-by: Milon <milonpl.git@proton.me>
* Automatic changelog update
* Give Admins "Tails" (#36842)
One line yaml change
* Fix construction orientation being ignored for some objects (#36488)
* fixes
* removed empty "SnapToGrid"s and parent "completed"s
* Automatic changelog update
* elemental.yml & asteroid.yml cleanup (#36448)
* Moth-pockets (#34517)
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* Four new food crates for the ATS (#33286)
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* Automatic changelog update
* Cleanup: Move folders out of bureaucracy.rsi and paper.yml (#35108)
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* Improve LocalizedDataset test to check for low Count (#36848)
* Improve LocalizedDataset test to check for low Count
* Fix missing entries for FigurinesFootsoldier
* Add 1 dragon name (#36846)
* this is a commit you cannot skip
* why do you have to add a count why
* Remove steel sheet hull fixing (#33443)
* Remove steel sheet hull fixing
It's unintuitive that it's wasteful, there's not really any systems to NOT make it wasteful, and it's a UX trap. No this is not "noob trap", no. It's an UX issue because if hundreds of people do it over and over again without noticing anything wrong, well, something fails to properly note that there's an issue with what they are doing. Aka user experience issue. Aka not a problem with the user but the design.
Also could be a shitty doafter action that makes you wonder if something's wrong
* Why was this testing using steel of all things
* Automatic changelog update
* cleanup + add names to some entities (#36856)
* Remove redundant fields from `MovementSpeedModifierComponent` (#36859)
Delete _baseWalkSpeedVV and _baseSprintSpeedVV
* Cleanup warnings in NinjaSuitSystem (#36861)
Fix warnings in NinjaSuitSystem
* Modernize `GhostComponent` & Ghost API (#36858)
* Move CanReturnToBody to system
* Move CanGhostInteract to system
* Cleanup redundant datafields and viewvariables
* Document datafields
* Document component
* Add SetTimeOfDeath Entity<T> overload, obsolete old version
* Document public methods
* Cleanup obsoleted method calls
* Cleanup warning in `EmptyAllContainersBehaviour` (#36860)
Fix warning in EmptyAllContainersBehaviour
* Cleanup warnings in `SharedCryostorageSystem` (#36863)
Fix warnings in SharedCryostorageSystem
* Cleanup warnings in `CableSystem.Placer` (#36868)
* Fix warnings in CableSystem.Placer
* Formatting
* Cleanup warnings in `PolymorphSystem.Map` (#36869)
Fix warnings in PolymorphSystem.Map
* Cleanup warnings in `WorldgenConfigSystem` (#36864)
Fix warnings in WorldgenConfigSystem
* Move guardian sounds to component (#36870)
* Cleanup warnings in `SpawnSalvageMissionJob` (#36866)
* DoMapInitialize and SetMapPaused
* GridTileToLocal
* Formatting
* Remove unused variables
* Update Content.Server/Salvage/SpawnSalvageMissionJob.cs
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Fix warnings in `ServerDbManager` (#36871)
Fix warnings in ServerDbManager
* pAI Software Catalog (#36857)
* initial commit
* add the shop and make it work
* add existing pai actions to the software shop
* added power monitor app
* killed the power and crew monitor software, too powercreepy
* fix test failures
* fix more test failures
* fix merge conflicts
* code changes to conform with review
* fix unintentional submodule update
* submodule update
* remove unused currency prototype ref
---------
Co-authored-by: archrbx <punk.gear5260@fastmail.com>
* New Salvage Ruin - Hydro Outpost (#36826)
* Automatic changelog update
* Make toy sword less obvious (#34199)
* YAML fuckery
* Remove toy_sword.rsi
Not a webedit btw
* Automatic changelog update
* Adds shorts/pants to ClothesMate vending machine (#35361)
* Clothesmate shorts
* matches price of vend to the new contents
* Moths can eat pills (#35609)
* Automatic changelog update
* Xenoborgs part 1 (#36830)
Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* Updated Syndicate and Ammo Contraband (#35102)
Co-authored-by: RedBookcase <crazykid1590@gmail.com>
* Automatic changelog update
* Put items inside cakes! (#31015)
* First commit
* I'm silly
* Please be it
* Some more fixes
* Cleanup
* fine!
* removed = false
* review
---------
Co-authored-by: Milon <milonpl.git@proton.me>
* Removed syndicate surgery duffel, added advanced circular saw to Medical Doctor uplink. (#35915)
* Removed syndicate surgery duffel, added advanced circular saw to Medical Doctor uplink.
* Update Resources/Prototypes/Entities/Objects/Specific/Medical/surgery.yml
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
---------
Co-authored-by: RedBookcase <Usualmoves@gmail.com>
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
* unremove surgery duffel
* unfunny
* Automatic changelog update
* fix NoCargoOrderArbitrage fail (#36878)
whoopsie
* Cotton Grilled Cheese Sandwich (#36135)
* Working entity.
* New sprite by MadeOfHeartAndStone
* Removed deadspace, changed attribution in meta.json
* review
---------
Co-authored-by: Milon <milonpl.git@proton.me>
* Automatic changelog update
* Meat Patty (#34896)
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* Automatic changelog update
* Remove beaker from the MaterialArbitrageTest whitelist (#36876)
* Turnstiles (#36313)
* construction rotation fix
* Turnstiles
* renaming
* review-slarticodefast-1
* mild attempts to fix (sorry sloth)
* move some more shit
* Remove engine dependency
* grid agnostic
* remove debug string
* fix json
* Update Content.Shared/Movement/Pulling/Systems/PullingSystem.cs
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* Update Content.Shared/Movement/Pulling/Systems/PullingSystem.cs
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* remove pass delay for mispredict reasons.
* most minor of changes
* Give directional indicator on examine
---------
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* Automatic changelog update
* Genpop Closets & IDs (#36392)
* Genpop IDs and Lockers
* placeholder generation, no ui yet.
* UI
* Fix time offset
* fix meta.jsons
* big speller
* Scarkyo review
* Add turnstile prototypes
* make IDs recyclable
---------
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
* Automatic changelog update
* Fix small misc. turnstile issues (#36893)
* Fix small misc. turnstile issues
* more missing things
* quieter
* New Spawners, Modified Spawners, new Service/Theatre Airlock, and new Colorful Light Crate (#36750)
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* Automatic changelog update
* Automatic changelog update
* Disable shadows for observer pointlight (#36897)
no shadows
* Fix QSI bringing people into paused maps (#36834)
* Automatic changelog update
* Fix storage ui hovering over the hotbar (#36770)
* Turnstiles lower volume + access reader (#36900)
fixes
* Fix disposal unit flush animation (#30677)
* Fix disposal unit flush animation
* Revert "Fix disposal unit flush animation"
This reverts commit a596ecfd5f5368f87ef52cfb27884a8e000185c6.
* control by setting layer visibility rather than overwriting
* restore changes
* Correct IdentityBlocker to include specific outer clothing (#33085)
* Make IdentityBlocker include outerclothing
* Modify Correct Bit
* Fix mask/eye cobo
* Automatic changelog update
* Change some posters to be rules-compliant (#32734)
* Initial commit
* Minor edit
* it's very hard to fit "disorder"
* Revert No ERP poster, fix spawner
* Attribution
* Update text
* Missed poster spawner
---------
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
* Automatic changelog update
* Cyborg Rebalance (#34186)
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
* Automatic changelog update
* Reptilians Can Eat Orange Creamsicles (#36890)
* Automatic changelog update
* Add Bloodstream to Goliaths (#33305)
* Automatic changelog update
* Nerf mining hardsuit's effectiveness against bullets and bombs. (#31450)
* Automatic changelog update
* Controls page guidebook rework 2025 Q1 (#36363)
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* Automatic changelog update
* Lower interdyne herbals TC cost (#36841)
* Automatic changelog update
* cleanup instruments yml (#32262)
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* Automatic changelog update
* Automatic changelog update
* [FIX] Rubber now uneatable (#34543)
* Releasing an under-pressure lockout is now a verb (#36910)
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* Automatic changelog update
* fix changelog (#36915)
* Fix for ghosts being unable to follow the AI when it uses a holopad (#36355)
* Initial commit
* Added to-do
* Automatic changelog update
* Fix random maints room deleting whatever was already there (#36605)
* Fix donuts tags breaking the bounty (#36903)
* Automatic changelog update
* Make 10u of "Atomic Bomb" drink instead of 11u (#36921)
changed atomic bomb recipe
* Automatic changelog update
* PKA Modkits + Rebalance (#31247)
* Automatic changelog update
* Remove a redundant trycomp from TileAnomalySystem (#36924)
* remove a redundant check
* revert this space.
* Land mine armament (#33883)
* Land Mine is now armable, it will not explode unless armed.
* Land Mine is now armable, it will not explode unless armed.
* Explicitly have Armed as false
* SharedLandMineSystem.cs adds the "Arm"-verb in "Content.Shared" with the Arming logic being implemented in "Content.Server"
* Land Mines now blink only when armed.
* Added prediction components, moved logic to SharedLandMineSystem.cs and inherit it in client content.
* Accessing the datafield directly instead of using methods
* Mines are now armed by default with a unarmed prototype
* Land mine now shows if it is armed when examined and in range.
* Landmine is unarmed by default with an armed variant for mapping purposes.
* Removed properties that were already defined by inheritance.
* Access the bool directly from the component
* Add booleans to change if the Arm-verb is showed and if examining the mine shows the status.
* Added status message for unarmed mine, removed using PushGroup since only one string is displayed.
* Added properties to the explosive floor sign to ensure that it is armed, not showing neither status nor arm-verb.
* The prototypes work now as before with added unarmed versions. Sprite is now only one toggable layer.
* Make the craftable land mine unarmed.
* Refactored the arming mechanic into own component and system.
* Reverted the explosive wet floor sign to previous prototype and added the Armable component and ItemToggle to the landmines.
* Moved the examination strings from land-mines.ftl to armable.ftl.
* Removed unused property.
* Formatting and fixing imports
* Added prefixes to the ftl naming. Moved LocId from system to component
* Added documentation. Moved check for armable to HandleStepTriggerAttempt.
Moved the LocId to component.
* Removed the TryArming method. Added documentation.
* Removed unnecessary TryComp
* Simplified the logic for the trigger attempt
* HasComp instead of TryComp on logic
* EmoGarbage Review
---------
Co-authored-by: Franz - Josef Björck <kaiserbirch@proton.me>
Co-authored-by: EmoGarbage404 <retron404@gmail.com>
* Add Cotton Burgers (#36405)
* Adds cotton burgers
* Rephrased copyright
* Added an extra comment
* Adds CottonBurger to tags.yml, Not sure if i am supposed to do this or not.
* Reordered Cotton bun YAML, and fixed overwritten tags
* Merge issue fix?
* Add experiment plushie and remove rubber chicken from cotton burgers
* Minor comment change
---------
Co-authored-by: beck-thompson <beck314159@hotmail.com>
* hide light-switches from build menu (#34664)
* Automatic changelog update
* Fixed stinger grenade lag spikes (#36641)
* Fixed stinger lag spikes
* Simplify nullable checks
* More cleanup of projectile grenades
* Remove null default from ShootProjectile
* Sheet-meister 2000 Cloth recipe (#32676)
* Sheet-meister 2000 can now make rolls of cloth
* Small Cleanup
* resolve conflicts
---------
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* Automatic changelog update
* Clear MIDI masters properly to avoid replay freezes (#36809)
While trying to play a replay I noticed that the replay would freeze
when seeking in some cases. After some debugging, I discovered that two
MIDI renderers had each other as master, which caused an infinite loop
processing MIDI events.
I'm not entirely sure of the sequence of events that leads to this
during replay playback, but I did notice that MIDI render masters are
never set to null. This is in the best case just a memory leak, in the
worst case probably the source of the bug, so... I fixed that.
* Changed soundGunshot for Pulse Pistol and Pulse Carbine from laser_cannon to laser3 (#36952)
* Automatic changelog update
* The Atmos A Airlock (#36376)
* airlocks
* Update meta.json
Added my modification in the meta
* Changed the storage sizes of different swords. (#36564)
Co-authored-by: RedBookcase <Usualmoves@gmail.com>
* Automatic changelog update
* Fix autorecharge (#36955)
* Fix inflatable barriers finishing instantly if canceled! (#36937)
Fix
* Automatic changelog update
* Only sec glasses can show contraband: second attempt (#36412)
* Add base code for cheking contraband in hud
* Fix missing using in InventorySystem.Relay
* Fix errors and update HUD yml
* Add show contraband with component on entity
* fix component description
* Update Content.Shared/Contraband/ShowContrabandDetailsComponent.cs
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* Update "if" for check if ent hasComp in contrabandSystem
* Remove << InventorySystem.Relay.cs
* Update Content.Shared/Contraband/ShowContrabandDetailsComponent.cs
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Update Content.Shared/CCVar/CCVars.Game.cs
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Fix partial class ShowContrabandSystem
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Update Content.Shared/Contraband/ShowContrabandDetailsComponent.cs
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Update Content.Shared/Inventory/InventorySystem.Relay.cs
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Some update ShowContrabandSystem
* Try with record struct
* back again ti default class with EntityEventArgs
* Remove EntityEventArgs
* Finally use record struct
---------
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Automatic changelog update
* Resolve a warning in SharedAnomalySystem and quell some linter whining. (#36939)
* resolve a warning and deal with some linter whining.
* Update Content.Shared/Anomaly/SharedAnomalySystem.cs
---------
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
* Automatic changelog update
* Truncate lathe announcement lists (#36945)
* Automatic changelog update
* Descriptions for .30 Rifle (#36958)
Initial commit
* CMO Hardsuit: Zombification Resistance tweak (#36957)
initial commit
* Automatic changelog update
* Adds Parcel Wrap (#34471)
* Parcel Wrap
* fix TG sprite licenses
update attribution on modified `unwrapped` sprite to better conform to CC's guidance
* ContainerContainer test failure fix
* Just easy changes for now.
* Imagine building your code before pushing it for review
* The rest of the PR comments
* PR comments
* more comments + cargo orderability
* whitespace: deduplicated.
* use limitedcharges
replace mostly-duped client/server with if(onserver)
* cabinet perspective sprites
* web edit detected
fite me
* @ps3moira 's new sprites for me :)
* add a touch of attribution
* EmoGarbage Review
* Merge with master
* Merge with master
---------
Co-authored-by: EmoGarbage404 <retron404@gmail.com>
* Automatic changelog update
* Ammo Mag + Speedloader Inhand Sprites (#34235)
* Added inhand visuals to (most) ammo magazines and speedloaders
* whoops mixed up a single inhand on the rifle mag
* Didn't realize rubber ammo got removed.
* added attributions
* adjusted inhand visuals to account for magazine types
* missed one 👁️👁️
---------
Co-authored-by: EmoGarbage404 <retron404@gmail.com>
* Automatic changelog update
* New Science Biosuit Locker Sprite (#36929)
* first commit, slightly broken
* fixed meta json
* reverse accidental cmo inclusion
* Automatic changelog update
* Remove legacy cargo shuttle code/prototypes (#36967)
* Automatic changelog update
* Paramedic suits adjustments (#36707)
* Changes
* meta
* Battery (SMES/substation) interface (#36386)
* Add ENERGYWATTHOURS() loc function
Takes in joules (energy), displays as watt-hours.
* Add simple OnOffButton control
* Re-add Inset style class
This was sloppily removed at some point?? Whatever, I need it.
* Add helper functions for setting title/guidebook IDs on FancyWindow
Reagent dispenser uses these, more in the next commits.
* Add BuiPredictionState helper
This enables me to implement coarse prediction manually in the battery UI.
Basically it's a local buffer of predicted inputs that can easily be replayed against future BUI states from the server.
* Add input coalescing infrastructure
I ran into the following problem: Robust's Slider control absolutely *spams* input events, to such a degree that it actually causes issues for the networking layer if directly passed through. For something like a slider, we just need to send the most recent value.
There is no good way for us to handle this in the control itself, as it *really* needs to happen in PreEngine. For simplicity reasons (for BUIs) I came to the conclusion it's best if it's there, as it's *before* any new states from the server can be applied. We can't just do this in Update() or something on the control as the timing just doesn't line up.
I made a content system, BuiPreTickUpdateSystem, that runs in the ModRunLevel.PreEngine phase to achieve this. It runs a method on a new IBuiPreTickUpdate interface on all open BUIs. They can then implement their own coalescing logic.
In the simplest case, this coalescing logic can just be "save the last value, and if we have any new value since the last update, send an input event." This is what the new InputCoalescer<T> type is for.
Adding new coalescing logic should be possible in the future, of course. It's all just small helpers.
* Battery interface
This adds a proper interface to batteries (SMES/substation). Players can turn IO on and off, and they can change charge and discharge rate. There's also a ton of numbers and stuff. It looks great.
This actually enables charge and discharge rates to be changed for these devices. The settings for both have been set between 5kW and 150kW.
* Oops, forgot to remove these style class defs.
* Automatic changelog update
* Use RMC mob collision values (#36851)
Use RMC movement values
General feedback was it's too slow to push through people but this still prevents stacking so.
* Automatic changelog update
* early merge fix AAAAAA validcheck
* Cherry Pick Round-start Solar Variation (#36825)
* Roundstart Variation for Solar Panels (#86)
* Added roundstart variation for solar panels
* Removed HV cable spawner since i don't want to bother with mapping them
* Solar Panel Variation Pass Fix (#96)
Added a second variation pass for regular solar assemblies, since otherwise they would spawn both it and the broken variety
* Reorganized everything to no longer be in the _Moffstation subdirectory
* Removed a forgotten tag for Moffstation
* Removed the moffstation namespace settings
* Update Content.Server/GameTicking/Rules/VariationPass/Components/SolarPanelReplaceVariationPassComponent.cs
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
* Update Content.Server/GameTicking/Rules/VariationPass/Components/ReplacementMarkers/SolarPanelReplacementMarkerComponent.cs
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
---------
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
* disable solar panel variation
* put surgery borg module icons in _Shitmed
* the big fix
* abstract the right recipe
* goida
* no milk
* update coscult code
* update coscult objectives
* migrate SignCansScience away
* goida
* update engine maybe fix test
* GET OUT OF MY HEAD
* i give up
---------
Signed-off-by: Prole <172158352+Prole0@users.noreply.github.com>
Co-authored-by: Alice4267 <psycopompass14@gmail.com>
Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com>
Co-authored-by: Pgriha <133212269+Pgriha@users.noreply.github.com>
Co-authored-by: Milon <milonpl.git@proton.me>
Co-authored-by: TakoDragon <69509841+BackeTako@users.noreply.github.com>
Co-authored-by: Hyper B <137433177+HyperB1@users.noreply.github.com>
Co-authored-by: Kyle Tyo <36606155+VerinSenpai@users.noreply.github.com>
Co-authored-by: K-Dynamic <20566341+K-Dynamic@users.noreply.github.com>
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
Co-authored-by: YoungThug <ramialanbagy@gmail.com>
Co-authored-by: lzk <124214523+lzk228@users.noreply.github.com>
Co-authored-by: Prole <172158352+Prole0@users.noreply.github.com>
Co-authored-by: RedBookcase <crazykid1590@gmail.com>
Co-authored-by: RedBookcase <Usualmoves@gmail.com>
Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com>
Co-authored-by: Booblesnoot42 <108703193+Booblesnoot42@users.noreply.github.com>
Co-authored-by: UBlueberry <161545003+UBlueberry@users.noreply.github.com>
Co-authored-by: Banedon <15725971+Lanedon@users.noreply.github.com>
Co-authored-by: Lanedon <matth.galvez@gmail>
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
Co-authored-by: uhbg <uhbg@users.noreply.github.com>
Co-authored-by: uhbg <29674581+uhbg@users.noreply.github.com>
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
Co-authored-by: Jackson Langley <tripwiregamer@gmail.com>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
Co-authored-by: Entvari <195642967+Entvari@users.noreply.github.com>
Co-authored-by: dffdff2423 <dffdff2423@gmail.com>
Co-authored-by: āda <ss.adasts@gmail.com>
Co-authored-by: IProduceWidgets <107586145+IProduceWidgets@users.noreply.github.com>
Co-authored-by: Spessmann <156740760+Spessmann@users.noreply.github.com>
Co-authored-by: Leon Friedrich <60421075+ElectroJr@users.noreply.github.com>
Co-authored-by: Thomas <87614336+Aeshus@users.noreply.github.com>
Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
Co-authored-by: Phooooooooooooooooooooooooooooooosphate <184853112+Phooooooooooooooooooooooooooooooosphate@users.noreply.github.com>
Co-authored-by: TytosB <54259736+TytosB@users.noreply.github.com>
Co-authored-by: Łukasz Lindert <lukasz.lindert@protonmail.com>
Co-authored-by: Hrosts <35345601+Hrosts@users.noreply.github.com>
Co-authored-by: T <theo75cg@gmail.com>
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
Co-authored-by: Verm <32827189+Vermidia@users.noreply.github.com>
Co-authored-by: J <billsmith116@gmail.com>
Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
Co-authored-by: EmoGarbage404 <retron404@gmail.com>
Co-authored-by: Ghagliiarghii <68826635+Ghagliiarghii@users.noreply.github.com>
Co-authored-by: Michael <107807667+Doc-Michael@users.noreply.github.com>
Co-authored-by: mubururu_ <139181059+muburu@users.noreply.github.com>
Co-authored-by: pathetic meowmeow <uhhadd@gmail.com>
Co-authored-by: ScarKy0 <scarky0@onet.eu>
Co-authored-by: godisdeadLOL <169250097+godisdeadLOL@users.noreply.github.com>
Co-authored-by: YourUsername <you@example.com>
Co-authored-by: beck-thompson <beck314159@hotmail.com>
Co-authored-by: Golden Can <greentopcan@gmail.com>
Co-authored-by: SlamBamActionman <83650252+SlamBamActionman@users.noreply.github.com>
Co-authored-by: Ilya246 <57039557+Ilya246@users.noreply.github.com>
Co-authored-by: Zachary Yona <58833995+Magicalus@users.noreply.github.com>
Co-authored-by: Zachary Yona <magicalusf@gmail.com>
Co-authored-by: Hanz <41141796+Hanzdegloker@users.noreply.github.com>
Co-authored-by: catlord <catlord0009@gmail.com>
Co-authored-by: poklj <compgeek223@gmail.com>
Co-authored-by: Vladislav Suchkov <20380250+murolem@users.noreply.github.com>
Co-authored-by: kosticia <kosticia46@gmail.com>
Co-authored-by: Smith <182301147+AgentSmithRadio@users.noreply.github.com>
Co-authored-by: Winkarst <74284083+Winkarst-cpu@users.noreply.github.com>
Co-authored-by: T-Stalker <43253663+DogZeroX@users.noreply.github.com>
Co-authored-by: Saphire Lattice <lattice@saphi.re>
Co-authored-by: ArchRBX <5040911+ArchRBX@users.noreply.github.com>
Co-authored-by: archrbx <punk.gear5260@fastmail.com>
Co-authored-by: Southbridge <7013162+southbridge-fur@users.noreply.github.com>
Co-authored-by: No Elka <125199100+NoElkaTheGod@users.noreply.github.com>
Co-authored-by: PotRoastPiggy <121025443+PotRoastPiggy@users.noreply.github.com>
Co-authored-by: Samuka-C <47865393+Samuka-C@users.noreply.github.com>
Co-authored-by: Coolsurf6 <coolsurf24@yahoo.com.au>
Co-authored-by: beck-thompson <107373427+beck-thompson@users.noreply.github.com>
Co-authored-by: deltanedas <@deltanedas:kde.org>
Co-authored-by: SG6732 <151011904+SG6732@users.noreply.github.com>
Co-authored-by: themias <89101928+themias@users.noreply.github.com>
Co-authored-by: Preston Smith <92108534+thetolbean@users.noreply.github.com>
Co-authored-by: Nox <nebulousnox38@gmail.com>
Co-authored-by: Victor Shen <71985089+Vexerot@users.noreply.github.com>
Co-authored-by: Alzore <140123969+Blackern5000@users.noreply.github.com>
Co-authored-by: Kresny <krzeszny@gmail.com>
Co-authored-by: chromiumboy <50505512+chromiumboy@users.noreply.github.com>
Co-authored-by: Radezolid <snappednexus@gmail.com>
Co-authored-by: Kiri1674 <107365596+Kiri-Yoshikage@users.noreply.github.com>
Co-authored-by: kaiserbirch <150971100+kaiserbirch@users.noreply.github.com>
Co-authored-by: Franz - Josef Björck <kaiserbirch@proton.me>
Co-authored-by: Wolfkey-SomeoneElseTookMyUsername <wolfkey75@gmail.com>
Co-authored-by: TGRCDev <tgrc@tgrc.dev>
Co-authored-by: OnyxTheBrave <131422822+OnyxTheBrave@users.noreply.github.com>
Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>
Co-authored-by: SyaoranFox <99053675+SyaoranFox@users.noreply.github.com>
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: qrwas <aleksandr.vernigora93@gmail.com>
Co-authored-by: UpAndLeaves <92269094+Alpha-Two@users.noreply.github.com>
Co-authored-by: Centronias <me@centronias.com>
Co-authored-by: Tiniest Shark <head.rebel@yahoo.com>
Co-authored-by: KingFroozy <140668342+KingFroozy@users.noreply.github.com>
* Port character records from CD
* Make species' base scales respected by CD heights
* Hide the height editor in the humanoid profile editor
---------
Co-authored-by: Janet Blackquill <uhhadd@gmail.com>
* Add loadout names
Did it for AI, breaking change for pgsql + migrations in general. Nothing atm uses it.
* the box
* Spawning cherry pick
* Fix nit
* revert
* Final cleanup
* Real
* Name UI fix
* Migrations
* a
* Review
* Re-run migrations
---------
Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>
This should be the primary changes for the future-proof "Modern HWID" system implemented into Robust and the auth server.
HWIDs in the database have been given an additional column representing their version, legacy or modern. This is implemented via an EF Core owned entity. By manually setting the column name of the main value column, we can keep DB compatibility and the migration is just adding some type columns.
This new HWID type has to be plumbed through everywhere, resulting in some breaking changes for the DB layer and such.
New bans and player records are placed with the new modern HWID. Old bans are still checked against legacy HWIDs.
Modern HWIDs are presented with a "V2-" prefix to admins, to allow distinguishing them. This is also integrated into the parsing logic for placing new bans.
There's also some code cleanup to reduce copy pasting around the place from my changes.
Requires latest engine to support ImmutableArray<byte> in NetSerializer.
Lol .AsSingleQuery().
Some people's preferences wouldn't load on Lizard. Turns out the entire preferences set is loaded with a morbillion joins in a single query and one person had 240,000 (!!!) rows returned for their preferences query. Yeah.
* Station AI overlay
* implement
* Bunch of ports
* Fix a heap of bugs and basic scouting
* helldivers
* Shuffle interactions a bit
* navmap stuff
* Revert "navmap stuff"
This reverts commit d1f89dd4be83233e22cf5dd062b2581f3c6da062.
* AI wires implemented
* Fix examines
* Optimise the overlay significantly
* Back to old static
* BUI radial working
* lots of work
* Saving work
* thanks fork
* alright
* pc
* AI upload console
* AI upload
* stuff
* Fix copy-paste shitcode
* AI actions
* navmap work
* Fixes
* first impressions
* a
* reh
* Revert "navmap work"
This reverts commit 6f63fea6e9245e189f368f97be3e32e9b210580e.
* OD
* radar
* weh
* Fix examines
* scoop mine eyes
* fixes
* reh
* Optimise
* Final round of optimisations
* Fixes
* fixes
* Beginnings of making the breadmemes jobs easier
* stuff
* stuff pt. 2
* Stuff pt.3
* Stuff I forgot last time
* Basic whitelist
Only people that are added to the whitelist with the addwhitelist command will be able to join. I call this the "legacy" whitelist
* Remove always deny condition in favor of just breaking if playtime check fails
* Change default whitelist
Default whitelist is now the "legacy" whitelist.
* localization
* Admin check
* minor spelling change
* Fix build
* Whitelist message
* Fix vars not being datafield and spelling mistakes
* Minor spelling mistake
* Change config for salamander
* Reviews and stuff
* Add summaries
* Fix whitelists
* Forgot to add a datafield
* Fixing stuff I guess
* Reuse admin remarks to reduce load when connecting.
* Update log messages to be verbose instead of debug
* Reviews
* whoops
* Explain a bit more how whitelist checking works
* Apply CE's review
* Append Membership to Blacklist and Whitelist conditions
* Fix review comments
* Uncapitalize playerConnectionWhitelist, add to ignored client prototypes
* Make note count field work
* Fix cvar for thingy
---------
Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>
* Start work on PostgresNotificationManager
Implement initial version of init and listening code
* Finish implementing PostgresNotificationManager
Implement ban insert trigger
* Implement ignoring notifications if the ban was from the same server
* Address reviews
* Fixes and refactorings
Fix typo in migration SQL
Pull new code in BanManager out into its own partial file.
Unify logic to kick somebody with that when a new ban is placed directly on the server.
New bans are now checked against all parameters (IP, HWID) instead of just user ID.
Extracted SQLite ban matching code into a new class so that it can mostly be re-used by the ban notification code. No copy-paste here.
Database notifications are now not implicitly sent to the main thread, this means basic checks will happen in the thread pool beforehand.
Bans without user ID are now sent to servers. Bans are rate limited to avoid undue work from mass ban imports, beyond the rate limit they are dropped.
Improved error handling and logging for the whole system.
Matching bans against connected players requires knowing their ban exemption flags. These are now cached when the player connects.
ServerBanDef now has exemption flags, again to allow matching full ban details for ban notifications.
Made database notifications a proper struct type to reduce copy pasting a tuple.
Remove copy pasted connection string building code by just... passing the string into the constructor.
Add lock around _notificationHandlers just in case.
Fixed postgres connection wait not being called in a loop and therefore spamming LISTEN commands for every received notification.
Added more error handling and logging to notification listener.
Removed some copy pasting from SQLite database layer too while I was at it because god forbid we expect anybody else to do all the work in this project.
Sorry Julian
---------
Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>
* Implement a new kind of ip range ban that only applies to new players
* Put determining whether a player record exists to its own function
* Make BlacklistedRange bans get bypassed by any ban exemption
* Stop trying to get another DbGuard while already having one
This does break with convention on the functions in that area but
considering the use of this function it's probably fine?
I could alternatively just move the place it's called from.
Also I was suppossed to wait for tests to finish locally just to be
sure, but nah. I am pushing this now
* Vox stuff
* Species loadouts and lobby refactor
The control flow for lobby is all over the shop so I pulled it all up from the individual controls so now they handle the bare minimum required and LobbyUIController handles the rest.
* a
* Bulk changes
* a
* weh
* Character import / export
* finalise
* woops this stuff too
* Also datafield exporting
* comments
* Review
Fucking whoops
In #27742 I made it so sanitization of character profiles was moved to be *after* database load. Except that means I moved it to be after the copy of all character profiles got sent to the client.
Move the sending to *also* be in that second load stage, and rename it. Fixes the issue.
First bug: if an error occured during pref loading code, it would fail. If the person then readied up, it would likely cause the round to fail to start.
Why could they ready up? The code only checks that the prefs finished loading, not that they finished loading *successfully*. Whoops.
Anyways, now people get kicked if their prefs fail to load. And I improved the error handling.
Second bug: if a user disconnected while their prefs were loading, it would cause an exception. This exception would go unobserved on lobby servers or raise through gameticker on non-lobby servers.
This happened even on a live server once and then triggered the first bug, but idk how.
Fixed this by properly plumbing through cancellation into the preferences loading code. The stuff is now cancelled properly.
Third bug: if somebody has a loadout item with a playtime requirement active, load-time sanitization of player prefs could run into a race condition because the sanitization can happen *before* play time was loaded.
Fixed by moving pref sanitizations to a later stage in the load process.
How can ONE DATABASE COLUMN have so many cursed issues I don't know, but it certainly pissed off the devil in its previous life.
The start_date column on round entities in the database was added by https://github.com/space-wizards/space-station-14/pull/21153. For some reason, this PR gave the column a nonsensical default value instead of making it nullable. This default value causes the code from #25280 to break. It actually trips an assert though that's not what the original issue report ran into.
This didn't get noticed on wizden servers because we at some point backfilled the start_date column based on the stored admin logs.
So I change the database model to make this column nullable, updated the C# code to match, and made the existing migration set the invalid values to be NULL instead. Cool.
Wait how's SQLite handle in this scenario anyways? Well actually turns out the column was *completely broken* in the first place!
The code for inserting into the round table was copy pasted between SQLite and PostgreSQL, with the only difference being that the SQLite key manually assigned the primary key instead of letting SQLite AUTOINCREMENT it. And then the code to give a start_date value was only added to the PostgreSQL version (which is actually in the base class already). So for SQLite that column's been filled up with the same invalid default the whole time.
Why was the code manually assigning a PK? I checked the SQLite docs for AUTOINCREMENT[1], and the behavior seems appropriate.
I removed the SQLite-specific code path and it just seems to work regardless. The migration just sets the old values to NULL too.
BUT WAIT, THERE'S MORE!
Turns out just doing the migration on SQLite is a pain in the ass! EF Core has to create a new table to apply the nullability change, because SQLite doesn't support proper ALTER COLUMN. This causes the generated SQL commands to be weird and the UPDATE for the migration goes BEFORE the nullability change... I ended up having to make TWO migrations for SQLite. Yay.
Fixes#26800
[1]: https://www.sqlite.org/autoinc.html
(cherry picked from commit d3ac3d06bb6eddd9c2076a586974aabf514a5c86)
Fixes#26211
Admin messages now have separate "seen" and "dismissed" fields. The idea is that an admin should be able to tell whether a user pressed the "dismiss for now" button. Instead of using "seen" as "show this message to players when they join", "dismissed" is now used for this.
Existing notes in the database will automatically be marked as dismissed on migration. A note cannot be dismissed without being seen (enforced via constraint in the database too, aren't I fancy).
As part of this, it has become impossible for a player to play without dismissing the message in some form. Instead of a shitty popup window, the popup is now a fullscreen overlay that blocks clicks behind it, making the game unplayable. Also, if a user somehow has multiple messages they will be combined into one popup.
Also I had enough respect for the codebase to make it look better and clean up the code somewhat. Yippee.
(cherry picked from commit d776c4b392a082dba7539d77cfa20fc904ed4091)
God bloody christ. There's like three layers of shit here.
So firstly, apparently we were still using Npgsql.EnableLegacyTimestampBehavior. This means that time values (which are stored UTC in the database) were converted to local time when read out. This meant they were passed around as kind Local to clients (instead of UTC in the case of SQLite). That's easy enough to fix just turn off the flag and fix the couple spots we're passing a local DateTime ez.
Oh but it turns out there's a DIFFERENT problem with SQLite: See SQLite we definitely store the DateTimes as UTC, but when Microsoft.Data.Sqlite reads them it reads them as Kind Unspecified instead of Utc.
Why are these so bad? Because the admin notes system passes DateTime instances from EF Core straight to the rest of the game code. And that means it's a PAIN IN THE ASS to run the necessary conversions to fix the DateTime instances. GOD DAMNIT now I have to make a whole new set of "Record" entities so we avoid leaking the EF Core model entities. WAAAAAAA.
Fixes#19897
(cherry picked from commit 2e6eaa45c57c7f5ba561d1fb1ef6712d2432a8fa)
* Give .props files 2-space indents.
* Move to Central Package Management.
Allows us to store NuGet package versions all in one place. Yay!
* Update NuGet packages and fix code for changes.
Notable:
Changes to ILVerify.
Npgsql doesn't need hacks for inet anymore, now we need hacks to make the old code work with this new reality.
NUnit's analyzers are already complaining and I didn't even update it to 4.x yet.
TerraFX changed to GetLastSystemError so error handling had to be changed.
Buncha APIs have more NRT annotations.
* Remove dotnet-eng NuGet package source.
I genuinely don't know what this was for, and Central Package Management starts throwing warnings about it, so YEET.
* Remove Robust.Physics project.
Never used.
* Remove erroneous NVorbis reference.
Should be VorbisPizza and otherwise wasn't used.
* Sandbox fixes
* Remove unused unit test package references.
Castle.Core and NUnit.ConsoleRunner.
* Update NUnit to 4.0.1
This requires replacing all the old assertion methods because they removed them 🥲
* Oh so that's what dotnet-eng was used for. Yeah ok that makes sense.
* Add Robust.Analyzers.Test
* Update submodule
* commit to re-run CI
(cherry picked from commit a6c9c36b688a1ba78ff4c12502e81661cf607b6c)
Vasilis The Pikachu
Milon
Errant
Southbridge
YotaXP
deltanedas
Lyndomen
metalgearsloth
beck-thompson
Pieter-Jan Briers
Repo
MendaxxDev
Simon
Julian Giebel
nikthechampiongr
Leon Friedrich
DrSmugleaf
NullWanderer
DrSmugleaf
Krunklehorn
Debug
Visne