* hotfix id card console not working due to unintentionally hidden accesses
* Update Content.Shared/Access/Components/IdCardConsoleComponent.cs
Co-authored-by: Vanessa <908648+ShepardToTheStars@users.noreply.github.com>
Signed-off-by: Charlie Morley <cmorley191@gmail.com>
---------
Signed-off-by: Charlie Morley <cmorley191@gmail.com>
Co-authored-by: Vanessa <908648+ShepardToTheStars@users.noreply.github.com>
* Fix usages of TryIndex()
Most usages of TryIndex() were using it incorrectly. Checking whether prototype IDs specified in prototypes actually existed before using them. This is not appropriate as it's just hiding bugs that should be getting caught by the YAML linter and other tools. (#39115)
This then resulted in TryIndex() getting modified to log errors (94f98073b0), which is incorrect as it causes false-positive errors in proper uses of the API: external data validation. (#39098)
This commit goes through and checks every call site of TryIndex() to see whether they were correct. Most call sites were replaced with the new Resolve(), which is suitable for these "defensive programming" use cases.
Fixes#39115
Breaking change: while doing this I noticed IdCardComponent and related systems were erroneously using ProtoId<AccessLevelPrototype> for job prototypes. This has been corrected.
* fix tests
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* refactor DeltaV/deltav resources to _DV
* change DeltaV namespaces to _DV
* add space before all DeltaV comments
* update xamls
* fix and move arena parallax to _DV
* more fix
* refactor even more stuff
* fix the grid fills
---------
Co-authored-by: deltanedas <@deltanedas:kde.org>
* legal departmant
* god i wish i knew what i was doing
* minor rsi fixes
* i forgor the legal radio frequency
* Minor fixes to radio, stamp, PDA, etc...
* add department
hehe
* Edits from Velcroboy
* Add trial timer
* add department signs
* Changes all references of legal -> justice and adds prosecutor access
* Missed one
* Adjust lawyer
* update lawyer icon
* temp to fix
* revert to fix
* add airlock texture
adds justice department airlock texture. Still need to do the yaml part of it but the texture's there.
* fix bureaucracy meta
* More meta fixes
* Connect airlocks to yaml
* Fixes, tweaks, and last reference of "legal" maybe
* Add justice to airlock groups
* add prosc. drip and fix prosecutor typos
adds prosecutor badge and suit, as well as fixes the spelling of "prosecuter" to "prosecutor"
* Changes prosecutor's supervisor to CJ
Signed-off-by: Timemaster99 <57200767+Timemaster99@users.noreply.github.com>
* Attorney <- Lawyer locale edit
* Removed modified shoukou file
* Added antag objective and touched up yaml
Fixed Clerk PDA and CJ jumpsuit error. Additionally moved notary stamp from paper.yml to rubber-stamp.yml, and fixed some indentation in the meta.json of the pda.rsi file
* Attorney <- Lawyer, now including the PDA
Forgot this last commit
* Fixed typo in Clerk Vest ID
Signed-off-by: Timemaster99 <57200767+Timemaster99@users.noreply.github.com>
* Added Chief Justice locker, all of its contents, and a prosecutor PDA (sprite pending)
* lockers 2, electric boogaloo. Committing files I forgot to commit
* Added CJ stamp and put it into CJ locker. Fixed notary stamp and put the sprites in the correct RSI
* Attempt to resolve merge conflicts
* Remove conflict markers
* Added stamp sprite, implemented CJ cloak
* Implemented Gavel Prototype and added to CJ locker
* Removed justice access from attorney as it will be used to secure Clerk's locker. Disabled antag for all justice besides attorney.
* Added Clerk locker and placed Notary Stamp into it. Uncommented gavel in CJ locker
* Added lawyer's stamp to lawdrobe
* Added Prosecutor PDA, icon, and ID sprite
* Added gavel block and made gavel tap when clicking on it
* Add component, EmitSoundOnInteractUsing onto the gavel block
* Added sprites for CJ and Clerk locker
* Spell-checked and edited job descriptions slightly
* Fixing missing type entity access.yml
Signed-off-by: Timemaster99 <57200767+Timemaster99@users.noreply.github.com>
* Adjusted rsi paths for gavel and gavel block to use forward slash
* Fixed a variety of invalid rsi references, and door remote yaml issue
* Added Lawyer access to Justice access group, fixed door_remote.yml access
* Remove antagadvantage from chief justice
Signed-off-by: Timemaster99 <57200767+Timemaster99@users.noreply.github.com>
* Apply suggestions from code review
line at the end for readability & matching current standards... line at the end for readability & matching current standards...
Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com>
Signed-off-by: Timemaster99 <57200767+Timemaster99@users.noreply.github.com>
* Hopefully remove shoukou.yml from the changed files
Signed-off-by: Timemaster99 <57200767+Timemaster99@users.noreply.github.com>
* Once again attempt to remove shoukou.yml from changed files
* Attempt once more to remove shoukou.yml from changed files
* Fixed justice pda box description
Signed-off-by: Timemaster99 <57200767+Timemaster99@users.noreply.github.com>
* Please go home, shoukou. We don't want you here
* Fixing prototype references pt1
Signed-off-by: Timemaster99 <57200767+Timemaster99@users.noreply.github.com>
* Renamed headsets/legal.rsi to headsets/justice.rsi
* Added hyphen to chief justice localizations
* Ordered justice accesses alphabetically
* Added prison key to justice headset
* Various yaml fixes from review
* Apply suggestions from code review
Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com>
Signed-off-by: Timemaster99 <57200767+Timemaster99@users.noreply.github.com>
* Localized changes to pdas and jobs
* Removed indents in locale
* Fixed reference to chief justice stamp
* Apply suggestions from code review
Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com>
Signed-off-by: Timemaster99 <57200767+Timemaster99@users.noreply.github.com>
* Renamed Lawyer to Attorney in locale, added deltav marker
* Lawyer to Attorney, Warrant Document in Clerk and CJ locker
* Apply suggestions from code review
Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com>
Signed-off-by: Timemaster99 <57200767+Timemaster99@users.noreply.github.com>
* Replaced legal with justice in job-description.ftl
Signed-off-by: Timemaster99 <57200767+Timemaster99@users.noreply.github.com>
* Moved job-name-lawyer to DeltaV locale
* Remove added space in accesses.ftl
Signed-off-by: Timemaster99 <57200767+Timemaster99@users.noreply.github.com>
* Removed unneeded deletion of unneeded spaces in headsets.yml
Signed-off-by: Timemaster99 <57200767+Timemaster99@users.noreply.github.com>
* Changed Lawyer ID name to Attorney ID
* Updated copyrights in all of the meta.json files affected
* Added formal and white variants of CJ jumpsuit to locker
* Updated to use upstream's EmitSoundOnInteractUsing
* Removing old component stuff
* Gave Prosecutor Filled Lawyer Backpack
* Deleted old component
Signed-off-by: Timemaster99 <57200767+Timemaster99@users.noreply.github.com>
* Removed old comments
* Updated doors to electronics system, fixed courier spawner that I botched
* Fixed door_access indentation
Signed-off-by: Timemaster99 <57200767+Timemaster99@users.noreply.github.com>
* Adding a little bit of loadouts
* Add loadouts for justice
* Removed accessreader from windoors
* Added job spawner icons
* Fixed spawner sprite layering
* Added missing parent in ID cards
* Removed redundant laceup shoes loadout
Signed-off-by: Timemaster99 <57200767+Timemaster99@users.noreply.github.com>
* Added lawyer windoor, fixed spawner names, fixed locker names
* Added station beacons
* Softened justice dept palette
Signed-off-by: Timemaster99 <57200767+Timemaster99@users.noreply.github.com>
* Added justice key to telecomms
* Added deltaV comments to telecomms
---------
Signed-off-by: Timemaster99 <57200767+Timemaster99@users.noreply.github.com>
Co-authored-by: Jeff <velcroboy333@hotmail.com>
Co-authored-by: Timemaster99 <57200767+Timemaster99@users.noreply.github.com>
Co-authored-by: Timemaster99 <elijahrobot@gmail.com>
Co-authored-by: luckywill339@gmail.com <luckywill339@gmail.com>
Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com>
Co-authored-by: Azzy <azzydev@icloud.com>
* Add door electronics configuration menu
* Use file-scoped namespaces
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Open door electronics configuration menu only with network configurator
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Doors will now try to move their AccessReaderComponent to their door electronics when the map is initialized
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Make the access list in the id card computer a separate control
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Fix merge conflict
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Remove DoorElectronics tag
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Integrate doors with #17927
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Move door electornics ui stuff to the right place
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Some review fixes
Signed-off-by: c4llv07e <kseandi@gmail.com>
* More fixes
Signed-off-by: c4llv07e <kseandi@gmail.com>
* review fix
Signed-off-by: c4llv07e <kseandi@gmail.com>
* move all accesses from airlock prototypes to door electronics
Signed-off-by: c4llv07e <kseandi@gmail.com>
* rework door electronics config access list
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Remove Linq from the door electronics user interface
* [WIP] Add EntityWhitelist to the activatable ui component
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Better interaction system
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Refactor
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Fix some door electronics not working without AccessReaderComponent
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Move AccessReaderComponent update code to the AccessReaderSystem
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Remove unnecesary newlines in the door access prototypes
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Remove unused variables in access level control
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Remove unnecessary method from the door electronics configuration menu
Signed-off-by: c4llv07e <kseandi@gmail.com>
* [WIP] change access type from string to ProtoId<AccessLevelPrototype>
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Remove unused methods
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Newline fix
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Restored to a functional state
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Fix access configurator not working with door electronics AccessReaderComponent
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Replace all string access fields with ProtoId
Signed-off-by: c4llv07e <kseandi@gmail.com>
* move access level control initialization into Populate method
Signed-off-by: c4llv07e <kseandi@gmail.com>
* Review
---------
Signed-off-by: c4llv07e <kseandi@gmail.com>
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
(cherry picked from commit 64bb8dbdd50e0b1e5744e1eb0cc6f24bda959ade)
* Cryogenic sleep units
* pause map support
* no more body deletion
* Cryogenic Storage Units
* boowomp
* no more emag, no more dropping present people
(cherry picked from commit 736b9dd7df6e35f07fed88686c7c863ac61af846)
* Two doors for the couriers living in logistics
But they were, all of them, deceived, for another access was given to the HoL.
* actually put the access in the id computer
* add paramedic-only access
* edit chemvend
upped jug amounts in each vend to accomodate for their use, and adds all emagged chemicals from the dispenser to them
* add portafib
* added comments and tweaked rollerbed
* one line comments
* Update IdCardConsoleComponent.cs
* increase crate price
* Comment, misspelling adjustments
removed unnecessary comments (ones indicating a Delta V change while already in the Delta V directory)
* not all jugs are created equal
this wont work btw
* chemvend restock price
---------
Signed-off-by: Colin-Tel <113523727+Colin-Tel@users.noreply.github.com>
Co-authored-by: Colin-Tel <113523727+Colin-Tel@users.noreply.github.com>
Charlie Morley
Vanessa
Pieter-Jan Briers
āda
pathetic meowmeow
deltanedas
Timemaster99
leo
Kara
c4llv07e
rosieposie
Nemanja
Velcroboy
Fluffiest Floofers
Debug
DrSmugleaf
Moony