Commit Graph

7845 Commits

Author SHA1 Message Date
Leon Friedrich 078794106e
Make tests automatically reset modified cvars (#28219)
* Make tests automatically reset modified cvars

* Fix bad return

* A

* Try Fix tests

* clarify comment

* update eng
2024-06-01 17:56:33 +02:00
Leon Friedrich 65a712700c
Only auto-enable internals when necessary (#28248)
* Only auto-enable internals when necessary

* Add toxic gas check

* Rename Any -> AnyPositive
2024-06-01 17:55:05 +02:00
Nemanja d1371865f1
Fix latejoin antag preferences not being respected (#28430)
* Fix latejoin antag preferences not being respected

* thank fuck for tests
2024-06-01 17:55:00 +02:00
Moony 56be0e1ee8
Handheld teleporter portals now must start on the same grid. (#28423)
Co-authored-by: moonheart08 <moonheart08@users.noreply.github.com>
2024-06-01 17:54:42 +02:00
Tayrtahn 2a56896045
Convert advertisements to use localized datasets (#28400)
* Convert advertisements to use LocalizedDatasets

* File consolidation

* Arcade machines too
2024-06-01 17:41:58 +02:00
Ed 7d53001a0e
Localize tips (#28285)
* localize tip

* localizzedDataset
2024-06-01 17:41:48 +02:00
metalgearsloth 4755223c9f
Predict ActivatableUIRequiresPower (#28405)
A lot of BUIs aren't going to handle the state coming in cleanly but we can fix em as we find em.
2024-06-01 17:38:43 +02:00
ShadowCommander ebddaa8e3d
Move ApcPowerReceiverComponent Powered state to shared (#28206)
* Try syncing powered state to client

For some reason the client is not receiving the ApcPowerReceiverComponentState, so it's not working.

* Fix powered state not syncing to client

The client PowerReceiverSystem was abstract, which prevented it from
running initialize.

* Flip check so that it runs bigger checks first

PowerDisabled skips the others.
NeedsPower skips the receiving check.

* Disallow changing Powered manually

* Move Powered update to PowerReceiverSystem

* Move appearance to event subscription

* Move metadata component to AllEntityQuery

* Cleanup

* Move Powered update back to PowerNetSystem

It's easier to use the EntityQueries and it dosen't need to be updated
anywhere else.

* Put appearance updating back

* Move IsPowered to shared

* Simplify IsPowered

* Cleanup

* Remove duplicate PowerChangedEvent

PowerChangedEvent on ProviderChanged doesn't seem to be needed
PowerChangedEvent gets raised by in update if the power state changes
after a new provider is connected
2024-06-01 17:38:41 +02:00
blueDev2 9f21df293f
Fixed hypo and injector entities going into disposal units (#28317) 2024-06-01 17:38:38 +02:00
Kevin Zheng 6714823ef6
Fix flow rate display (#28372) 2024-06-01 17:19:56 +02:00
deltanedas 819c173308
item cabinet rework + stuff (#26779) 2024-06-01 17:19:54 +02:00
metalgearsloth 1f5f2cfe45
Block gas analyzer updates if the UI doesn't open (#28376)
Fixes the gas analyzer UI coming up when used with a target.
2024-06-01 17:19:47 +02:00
Nemanja 0a686ec58e
Clean up RefiningSystem (#27904)
cleanup RefiningSystem
2024-06-01 17:19:45 +02:00
metalgearsloth b35c987322
Fix shuttle audio clipping (#27527)
Changed engine to use grid local-center and very high maxdistance / refdistance values so it's seamless.
2024-06-01 17:19:33 +02:00
Kevin Zheng a6e4fd4c7a
Tune spacing speed to fix under-pressure lockout (#28370) 2024-06-01 17:19:28 +02:00
metalgearsloth da6ab10cb3
Don't update APC states unless UI open (#27803) 2024-06-01 17:19:23 +02:00
lzk 16c0dae7cb
Remake gasp popup to emote (#27736) 2024-06-01 17:19:16 +02:00
Repo ea2668ff37
Fix late join & observe to de-admin admins. (#28319) 2024-06-01 17:18:14 +02:00
deltanedas a14aed3fca
missing nukies can be filled in by ghost roles (#28316) 2024-06-01 17:18:00 +02:00
ShadowCommander adee8b16ab
Add pressure and temperature warning text to firelocks (#28341) 2024-06-01 17:17:54 +02:00
MilenVolf df162070ac
Localize emergency shuttle's direction for announcements (#28340)
Localize emergency shuttle direction
2024-06-01 17:17:48 +02:00
Repo ead8267de2
Fix wall vending machines spawning items in walls. (#28279)
* Find spawning of wall vending machines.

* Review fixes
2024-06-01 17:17:43 +02:00
Nemanja 49ae1f57ee
Small anomaly behavior fix (#28290)
* Small anomaly behavior fix

* well put together code
2024-06-01 17:17:36 +02:00
slarticodefast d25743c22f
Cargo bounty corrections (#28255)
cargo bounty corrections
2024-06-01 17:17:29 +02:00
lzk 6ae7ceb5a3
Add popup for owner when inserting item in hand (#28032) 2024-06-01 17:15:45 +02:00
Nemanja 38b4bbf97c
Fix under-selecting antags (#28327)
Fix under selecting antags
2024-06-01 17:14:58 +02:00
Nemanja 5b87c90511
Prevent stacking pipes (#28308)
* prevent stacking pipes

* access

* notafet review

* notafet review pt. 2

* not the actual fix
2024-06-01 17:14:50 +02:00
metalgearsloth b99a66afc1
Selectively revert PullController (#28126)
I am leaving the issues open and have updated #26547 with more info on what we should do long-term. This is just to bandaid the short-term complaining.
2024-06-01 17:13:38 +02:00
Nemanja 3d8706561d
fix borg ui mispredict opening (#28305)
move borg ui junk to shared
2024-06-01 17:13:35 +02:00
deltanedas 82b8d835b2
fix antag selection being evil (#28197)
* fix antag selection being evil

* fix test

* untroll the other tests

* remove role timer troll

* Allow tests to modify antag preferences

* Fix antag selection

* Misc test fixes

* Add AntagPreferenceTest

* Fix lazy mistakes

* Test cleanup

* Try stop players in lobbies from being assigned mid-round antags

* ranting

* I am going insane

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
Co-authored-by: ElectroJr <leonsfriedrich@gmail.com>
2024-06-01 17:13:27 +02:00
Nemanja 9a7f4416b2
actually fix magic mirrors (#28282) 2024-06-01 17:13:23 +02:00
Leon Friedrich cc29590cfa
Make NetworkConfigurator use BoundUserInterfaceCheckRangeEvent (#28293) 2024-06-01 17:13:20 +02:00
Leon Friedrich 386728db2f
Fix stripping not marking interactions as handled (#28292) 2024-06-01 17:13:16 +02:00
Ady4ik 78dbdfa00c
Move PendingZombieComponent to Shared (#28143)
* Move PendingZombieComponent to Shared

* network me boy

---------

Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
2024-06-01 17:00:22 +02:00
eoineoineoin 6eef3dcea3
Objects ordered through cargo system shouldn't start anchored (#28115)
* Order normal space heater instead of anchored variant

* Make sure ordered objects don't spawn anchored

* Order space heater flatpack instead of a regular space heater

* Remove obsolete TODO

* Remove unnecessary name

---------

Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es>
2024-06-01 17:00:19 +02:00
Ed 5a9c7073c2
Fix candles (firestack fading) (#28139)
Update FlammableSystem.cs
2024-06-01 17:00:15 +02:00
MilenVolf c6b279ef80
Add direction relative to station for emergency shuttle's docking & nearby announcement (#28164)
* Use nav beacon location for emergency shuttle's docking announcement

Location of the shuttle relative to the nearest nav beacon in docking announcement message of the emergency shuttle

* Add directions relative to station
2024-06-01 17:00:13 +02:00
Repo c4b0fcbd5c
Fix gamerule display issues (#28178)
* A comprehensive rule list for joining admins and mid round command to get rule list added

* Fix up for when a rule is added vs started and some logging

* fix command help localization, fix admin flags and spam anouncement.

* Send admin message only to the joining player not all admins.

* Bit better formatting in chat box
2024-06-01 17:00:04 +02:00
deltanedas 1ecb083ffd
move nukie profile loading into its own rule (#28208)
* move profile loading out of nukeops rule

* make BaseNukeopsRule and use AntagLoadProfileRule

* untroll

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-06-01 17:00:00 +02:00
deltanedas 4240e5c70b
antag objective issuing refactor (#28216)
* add AntagObjectives from GenericAntag

* add AntagRandomObjectives that traitor and thief can use

* make ObjectivesSystem use initial character name which AntagSelection passes

* make thief and traitor use AntagRandomObjectives

* remove now unused locale

* make sleeper agents rule use baseTraitorRule

* restore dragon rule oop

* bandaid for genericantag

* real

* typo

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-06-01 16:59:16 +02:00
deltanedas ee90f7a0f4
fix id card console not updating records (#28237)
* fix id card console not updating records

* test

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-06-01 16:57:33 +02:00
nikthechampiongr a036d3a485
Fix firelock prediction issues with periodic pulses of closing lights (#28227)
* Fix firelock prediction issues with periodic pulses of closing lights

For some reason this function was setting a time for the next state
which was triggering the door system to try to close the firelock.
This does not happen serverside because the function only fires from an
event called clientside apparently.
It appears to be an attempt to stop firelocks from closing instantly
that did not function properly, and I cannot discern any other purpose.
As such I have removed it.

* Remove redundant serverside check

This became redundant with commit 439a87f2
2024-06-01 16:57:01 +02:00
Leon Friedrich 768f48bd4f
Improve InteractionSystem range & BUI checks (#27999)
* Improve InteractionSystem range & BUI checks

* Ghost fixes

* AAA

* Fix test

* fix nullable

* revert to broadcast event

* Fixes for eengine PR

* Ah buckle code

* )
2024-06-01 16:56:23 +02:00
Nemanja 9adf1ed402
Remove AlertType and AlertCategory (#27933) 2024-06-01 16:55:49 +02:00
nikthechampiongr 06b4df686b
Firelock improvements part 1 (#26582)
* Change prying system and pryunpoweredcomp to allow for custom time modifiers

This will be useful if I go the route of making firelocks pryable when
unpowered instead of just being able to open and close instantly when
unpowered.

* Make firelocks properly predicted

Shared system made. Since atmos checks can only be done on the server we
just have it set relevant bools on the component and then dirty it.
Ditched atmos checks on trying to open, they now only happen whenever
firelocks are updated.

* Make firelocks pryable without a crowbar

While this usually would only allow you to do this when a door is
unpowered, firelocks do not have the airlock component which actually
does that check. As such firelocks will always allow you to pry them
open/closed by hand.

* Clean up System. Change update interval to be based on ticks. Move as much as possible to shared

* Make firelocks unable to emergency close for 2 seconds after being pried open

* Clean up

* More cleanup

* Reorganize SharedFirelockSystem methods to match Initialize order

---------

Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
2024-06-01 16:55:26 +02:00
DrSmugleaf f580b4be64
Add defib event, add fields to be able to disable crit defib and do after movement (#28174)
* Add defib event, add fields to be able to disable crit defib and do after movement

* Fix check
2024-06-01 16:55:16 +02:00
Leon Friedrich 74308b008f
Use non-generic `TryComp()` for metadata & transform (#28133) 2024-06-01 16:53:51 +02:00
Tayrtahn 7ff91799cc
Fix non-ghosts and admins counting toward most followed (#28120)
* Fixed non-ghosts and admins counting toward most followed

* Redone to better leverage EntityQueryEnumerator

* Remember to test your code before you commit it, kids

* Review revisions

* Update Content.Shared/Follower/FollowerSystem.cs

Co-authored-by: ShadowCommander <shadowjjt@gmail.com>

* Update Content.Shared/Follower/FollowerSystem.cs

Co-authored-by: ShadowCommander <shadowjjt@gmail.com>

* Update Content.Shared/Follower/FollowerSystem.cs

* Clean up

---------

Co-authored-by: ShadowCommander <shadowjjt@gmail.com>
Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
2024-06-01 16:53:44 +02:00
Tayrtahn d92b6a08cb
Prevent ghosts from spawning on terminating maps/grids (#28099)
* Extra checks to prevent ghosts spawning on terminating maps/grids

* Add test for grid deletion
2024-06-01 16:53:42 +02:00
Tayrtahn 77abecef2a
Slightly emphasize popup when someone points at you (#28152)
Slightly emphasize when someone points at you
2024-06-01 16:53:39 +02:00