Commit Graph
100 Commits
Author SHA1 Message Date
ShadowCommander 445cba7836 Replace DoorVisuals.Powered with PowerDeviceVisuals.Powered (#34646) 2025-03-01 12:38:15 +00:00
ShadowCommander 614f7b31db HOTFIX: Fix lineedit focus (#34621)
* Test entered tree fix

* Use Opened override

* Fix keyboard focus on window open for DialogWindow

This affects Phone, Pray, Rename, and multiple other admin verbs.

* Clean up
2025-02-14 16:09:56 +00:00
ShadowCommanderandmetalgearsloth bb1b50866c Move PlaceableSurfaceComponent usages to PlaceableSurfaceSystem (#28384)
* Move placeable check to PlaceableSurfaceSystem

This check stops entities from being inserted into a storage entity
when it has a PlaceableSurfaceComponent.

The entity is instead placed on top of the entity like a table.

* Move SetPlaceable to PlaceableSurfaceSystem

* Update to transform system and consolidate code

* Fix interaction with storage that has a placeable component

* deadlock

---------

Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2024-09-22 02:45:06 +01:00
ShadowCommander 9ae32dce9e Give prototype refactor (#29697)
* Update GivePrototype

* File scoped namespace

* Change to EntProtoId instead of ProtoId<> for better validation
2024-09-22 02:44:51 +01:00
ShadowCommanderandmetalgearsloth 8f239aa216 Set default PDA uplink and music visibility to false (#28373)
* Set PDA uplink and music default visibility to false

#27376 seems to be the PDA receiving state before first PDA UI open

* Log error on PDA state received before first open

* Fix logging

* Fix error message

---------

Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2024-09-14 14:27:11 +01:00
ShadowCommanderandmetalgearsloth 58a6e262fd Update StackSystem and add SpawnMultiple targeting EntityUid (#29686)
* Update StackSystem and add SpawnMultiple targeting EntityUid

* Update Content.Server/Stack/StackSystem.cs

* Update Content.Server/Stack/StackSystem.cs

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
2024-09-01 03:55:39 +01:00
ShadowCommander 0a42ea3a9f Add a bool to disable buckling on InteractHand (#30001) 2024-08-27 01:00:43 +01:00
ShadowCommander a6e61f9f52 Add a component that inserts the held item when no interaction happens on the stored item (#29823)
* Insert when held item has no interaction with stored item

* Decouple inserting on failure

* Add component that stores the used entity when no interaction happened

* Add prediction
2024-08-11 14:50:15 +01:00
ShadowCommanderandEd 7dc986b95b Add EntityWorldTargetAction (#29819)
* Add EntityWorldTargetAction initial implementation

* Update obsolete methods

* Partially working EntityWorldTargetAction

* Fix entity selection

* Move and clean up AfterInteract

* Fix building new walls

* Readd no entity or coordinates error

* Consolidate action validation code

* Add summaries to component

---------

Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com>
2024-08-09 19:02:30 +01:00
ShadowCommander d1c176a6e0 Strip drag drop test (#30754)
* Add test for drag drop to open strip menu

* Make screencoords change based on deadzone
2024-08-09 19:01:46 +01:00
ShadowCommander f6e30d3950 Dragdrop fold rollerbed (#30002)
* Deploy foldable

* Add NetworkedComponent and access to the component

* Add handled to afterinteract

* Use drop target location instead of setcoordinates

* Put back in hand after failed deploy

This prevents dropping the bed when clicking while inside a locker.

* Created BaseDeployFoldable for folding chairs, body bags, and rollerbeds

* Add dragdrop to fold rollerbed to hand
2024-08-09 18:58:54 +01:00
ShadowCommander 50308341d7 Deploy foldable (#30000)
* Deploy foldable

* Add NetworkedComponent and access to the component

* Add handled to afterinteract

* Use drop target location instead of setcoordinates

* Put back in hand after failed deploy

This prevents dropping the bed when clicking while inside a locker.

* Created BaseDeployFoldable for folding chairs, body bags, and rollerbeds
2024-08-09 18:18:14 +01:00
ShadowCommanderandmetalgearsloth edde7e4a20 Clean itemmapper (#29983)
* File scoped namespace

* Format file

* Fix param name in doc comment

* Reflow doc comment

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
2024-08-09 17:47:28 +01:00
ShadowCommander 2759539d9b Add doc comments to target action components (#29982) 2024-08-09 17:45:38 +01:00
ShadowCommander 7b2b2ef7d9 Change whitelist to pass when null (#29981) 2024-08-09 17:45:38 +01:00
ShadowCommander 21e45bf669 Allow attack while pulling (#29703)
* Make VirtualItem not block attacking

* Remove unneeded usings
2024-08-09 17:38:46 +01:00
ShadowCommanderandmetalgearsloth 0743d46851 Fix ItemMapper whitelist mispredict when inserting or removing items (#29461)
* Fix ItemMapper whitelist mispredict when inserting or removing items

Makes the ItemMapper MapLayerData available on client so that the client
can predict whether an inserted/removed item changes the visibility of
a sprite layer.

* review

---------

Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2024-07-25 01:55:37 +02:00
ShadowCommander ac381dc2d3 Make firelock warning light not require power and add a PointLight (#29024)
* Add a PointLight to firelocks when warnings are active

* Remove power requirement for lights
2024-07-05 20:37:28 +02:00
ShadowCommander db8bc652f1 Fix playtime on player tab getting set to Unknown (#28876)
Update play time on admin panel player tab after db loads
2024-07-05 20:27:59 +02:00
ShadowCommander f4fecc9882 Add logs that provide session to player admin logs (#28628) 2024-06-08 20:19:42 +02:00
ShadowCommander 9194e4fde3 Add firelock warnings popup when opening on access allowed (#28420) 2024-06-01 17:57:25 +02:00
ShadowCommander 08b82e98c4 Add search filter to the admin menu player tab (#28030) 2024-06-01 17:56:42 +02:00
ShadowCommander 9da992476e Reflow the player tab to show more of the names (#28029) 2024-06-01 17:54:54 +02:00
ShadowCommander 1338c4a059 Fix TryGetActionData error triggering when run on deleting entities (#27839)
* Fix TryGetActionData error triggering when run on deleting entities

* Only get metadata once
2024-06-01 17:54:46 +02:00
ShadowCommander 39cdcc5425 Fix firelocks not requiring engineering access (#28415) 2024-06-01 17:54:35 +02:00
ShadowCommander ebddaa8e3d Move ApcPowerReceiverComponent Powered state to shared (#28206)
* Try syncing powered state to client

For some reason the client is not receiving the ApcPowerReceiverComponentState, so it's not working.

* Fix powered state not syncing to client

The client PowerReceiverSystem was abstract, which prevented it from
running initialize.

* Flip check so that it runs bigger checks first

PowerDisabled skips the others.
NeedsPower skips the receiving check.

* Disallow changing Powered manually

* Move Powered update to PowerReceiverSystem

* Move appearance to event subscription

* Move metadata component to AllEntityQuery

* Cleanup

* Move Powered update back to PowerNetSystem

It's easier to use the EntityQueries and it dosen't need to be updated
anywhere else.

* Put appearance updating back

* Move IsPowered to shared

* Simplify IsPowered

* Cleanup

* Remove duplicate PowerChangedEvent

PowerChangedEvent on ProviderChanged doesn't seem to be needed
PowerChangedEvent gets raised by in update if the power state changes
after a new provider is connected
2024-06-01 17:38:41 +02:00
ShadowCommander ec1696bc8e Change PlaceableSurfaceSystem.cs to file scoped namespace (#28379) 2024-06-01 17:19:38 +02:00
ShadowCommander 7123ad8832 Popup duplicate stacking (#27978) 2024-06-01 17:19:25 +02:00
ShadowCommander adee8b16ab Add pressure and temperature warning text to firelocks (#28341) 2024-06-01 17:17:54 +02:00
ShadowCommander 4694f79a45 Revert "Make hotplate and grill anchorable on table" (#28202)
Revert "Make hotplate and grill anchorable on table (#28026)"

This reverts commit 26747be232.
2024-06-01 16:55:30 +02:00
ShadowCommander b1c86ae0b3 Fix arrivals not docking on spinning stations (#26033)
Fix arrivals not working on spinning stations

Increases the tolerance to .15 instead of .1

(cherry picked from commit 9e2e514319)
2024-03-17 14:54:33 +01:00
ShadowCommander 144b0c7f4a Change ListContainer to send null when selected is removed from the data (#20595) 2023-10-31 18:45:36 +01:00
ShadowCommander 60ed4e80d4 Fix sound on material reclaimer (#21030)
* Fix saw sound error on client

The sound tried to play using shared PlayPvs which doesn't work on client. PlayPredicted handles client and server.

Fixed NextSound not playing again while continuously gibbing items.

* Fix duplicate splat sound on Recycler gibbing
2023-10-20 15:29:04 +02:00
ShadowCommander 5442ee5c44 Add a command to hide replay UI (#19956) 2023-10-14 22:02:32 +02:00
ShadowCommander 9e6384ee9b Cleanup GhostSystem (#17526) 2023-09-27 21:59:12 +02:00
ShadowCommander c4fb166af3 Particle Accelerator power changed admin chat warning (#18806) 2023-08-07 11:07:57 -06:00
ShadowCommander dd7032a860 Mind ECS (#16826) 2023-06-19 04:33:19 +10:00
ShadowCommander 3b21421ef1 Add EscapeContext keybind (#15301)
* Add EscapeContext

Escape context input closes windows if there are any open. If there are not any windows it opens the game menu.

* Add fluent for Escape Context

* Move EngineContext keybind to content

* Readd WindowCloseAll

* Fix EscapeContext not opening the game menu after using WindowCloseAll

WindowCloseAll does not clear the CloseRecentWindowUIController.recentlyInteractedWindows, which caused HasClosableWindow to return true because the list still had items.

Changed HasClosableWindow to check if windows in the list are still open and clear them if they aren't.

* Clean up EscapeContextUIController
2023-04-13 18:10:44 -07:00
ShadowCommander 1c55904cd2 Add Alt-click insertion to ItemSlots (#15094) 2023-04-06 16:49:27 -06:00
ShadowCommander bfc4da9377 Mind ecs (#14412) 2023-03-26 14:31:13 -04:00
ShadowCommander e4fbcf3a63 Expand the viewport when the game window is resized instead of the chat window in the Separated HUD layout (#13694) 2023-03-10 00:56:43 +11:00
Jacob Tong 343ea93d75 Fix drink DoAfter (#14437)
Copies missing arguments from FoodSystem
2023-03-05 23:52:10 -08:00
Jacob Tong 6de75669d1 Examine fixes (#13696) 2023-01-27 19:15:39 -04:00
Jacob Tong 59668b708a Update RobustToolbox to v0.71.1.3 (#12983) 2022-12-11 16:01:27 -08:00
Jacob Tong 5359f79e1f Update RobustToolbox (#12981) 2022-12-11 12:08:13 -08:00
Jacob Tong d939c43354 Remove duplicate disarm popup when target is holding an item (#12315)
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
Fixes https://github.com/space-wizards/space-station-14/issues/12114
2022-11-15 18:48:00 +11:00
Jacob Tong 74b63e83fd Add alt click to hands (#12330) 2022-11-04 12:36:45 +11:00
Jacob Tong 6d297fbb62 Cleanup audio (#11238) 2022-11-04 10:01:53 +11:00
Jacob Tong 9f485d7124 Add toggle ghost visibility button to ghost GUI (#12325)
* Add toggle ghost visibility button to ghosts

* Rename to toggleghosts
2022-11-01 20:14:06 -05:00
Jacob Tong dbb23f9cf7 Fix butchering inside of a container making the target unbutcherable permenantly (#12328) 2022-11-01 16:52:53 +11:00
Jacob Tong dfd72c5db2 Fix aghost when aghosting from a ghost (#12252) 2022-10-28 19:38:53 -07:00
Jacob Tong 52382aa7a6 Delete ghost when player is detached (#12221) 2022-10-28 01:09:35 +11:00
Jacob Tong 2003a58138 Add test for empty ListContainer (#11297) 2022-09-16 04:11:34 -07:00
Jacob Tong 473542b13c Fix ListContainer (#11296) 2022-09-15 00:25:40 -07:00
09c6a5b252 Add Context Menu to Bwoink Window (#9374)
* Clean up EntityListDisplay

* Rename EntityListDisplay to ListContainer

* Rename stuff

* Rework ListContainer

* Add tests

* Replace IControlData with record ListData

* Make _data non-nullable

* Fix test record items being duplicates

* Split filter method from populate

* Rename UpdateList to DirtyList

* Replace _count with _data.Count

* Clarify local variable toRemove

* Cleanup

* Add data selection to ListContainer

* Add selection test

* Fix comments and test name

* Fix ListContainer layout hiding items when scaled

* Add test for ListContainer top item

* Toggle fix

* Ensure buttons are re-generated

* Update unread count on select

* a

* Fix toggle test

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: ElectroJr <leonsfriedrich@gmail.com>
2022-09-14 19:03:13 -05:00
Jacob Tong e5f2a0c410 Fix tile prying offset (#11206) 2022-09-14 17:07:44 +10:00
Jacob Tong a75fa74b5d Fix extra plasteel getting returned when deconstructing shuttle airlocks (#10980) 2022-09-02 18:32:18 -07:00
Jacob Tong fdc89cea84 Fix metal counter frame deconstruction (#10957) 2022-09-01 00:21:39 -07:00
Jacob Tong fe1880062b Add logs to lattice cutting (#10956) 2022-08-31 23:52:24 -07:00
Jacob Tong 61d975644a Implement lattice cutting (#10920)
* Add lattice cutting

* Add delay when spacing the floor.

* Add LatticeCutting to jaws of life

* Add warning

* Minor fixes

* Add atmos decompression delay

* Add CanWirecutter and lattice item drops

* Remove atmos check

* Prevent tile replacement edge case
2022-08-31 03:24:51 -05:00
Jacob Tong 68a17b3794 Add shuttle airlock construction (#10944) 2022-08-31 02:28:40 -05:00
Jacob TongandKara 3bbbb59bb1 Make flash prevent handheld light toggle (#9448)
Co-authored-by: Kara <lunarautomaton6@gmail.com>
2022-07-14 19:39:42 -07:00
Jacob Tong f7363df19e Fix thrown items colliding with non-hard entities (#8243)
* Fix pies colliding with non-hard(puddles)

* Fix thrown items colliding with tables
2022-05-18 12:24:58 +10:00
Jacob Tong 7ed6e28bc5 Fix cream pie crash due to client deletion (#8234) 2022-05-17 02:56:17 -07:00
Jacob Tong 09ae27f492 Update issue template (#8218) 2022-05-16 13:08:27 -07:00
Jacob Tong cecd1b9ef6 Fix climbing out of CloningPod and MedicalScanner (#8191)
* Fix climbing out of CloningPod and MedicalScanner

* Fix mask

* Fix test
2022-05-15 19:57:13 +10:00
Jacob Tong f3d7543d68 Fix interaction and add comments to CollisionGroup (#8149) 2022-05-14 12:54:37 +10:00
Jacob Tong 460b0bc212 Make CarpetChapel not collide (#8112) 2022-05-11 23:10:15 -07:00
Jacob Tong e6e9f169a0 Collisiongroup tweaks (#8110) 2022-05-12 10:24:00 +10:00
Jacob Tong 8c853476fb Rework CollisionGroups (#7656)
* Replace Mob, Vault, and Small impassable with Mid, High, Low

* Remove CollisionGroup.Underplating

* Remove CollisionGroup.Passable

* Fix constructed APCs not being interactable

* Change firelocks to occlude

* Make pipe inherit from BaseItem

* Clean up pipes

* Remove duplicate physics and fixtures from bucket

* Rework CollisionGroups on all entities

* Add SlipLayer

* Remove fixture from delta

* Fix maps

* Address reviews

* Add SubfloorMask

* Fix glass collisions for flying mobs

* Fix maps

* Update new items

* Fix bagel again

* Fix slug

* Fix maps

* Touchups

* Fix tables blocking high pressure movement

* Update StandingState to allow going under flaps

* Cleanup

* More formatting
2022-05-10 17:57:20 -07:00
Jacob Tong 0e945b42b2 Rework climbing (#7706) 2022-05-10 01:08:52 -07:00
ShadowCommander 2a3f1d2ae0 Glass airlock construction (#7877)
* Lower indentation

* Add glass airlock construction

* Fix glass airlock wrong name
2022-05-09 15:52:19 +10:00
ShadowCommander d9633afe1a Fix health state to be 1, 19, 20, 20, 20, 20 thresholds (#7921)
Previous thresholds were 1, 33, 16, 17, 17, 16
2022-05-04 09:11:18 +10:00
ShadowCommander 106adf9399 Add checks for missing lathe sprite visuals (#7648)
* Add checks for missing lathe sprite visuals

* Address reviews
2022-04-23 13:46:41 +10:00
ShadowCommander 4571af1e6e Change doors to ignore static entities when closing (#7646) 2022-04-19 08:45:36 -05:00
ShadowCommander a57e0ca199 Add round id to lobby and round end summary (#7547) 2022-04-14 13:40:26 -05:00
ShadowCommander c543d7e816 Don't let them eat cake infinitely (#7296) 2022-03-26 23:23:32 -07:00
ShadowCommander 1fa3587d1c Alleviate attack log spam (#7218) 2022-03-23 13:08:28 +11:00
ShadowCommander b99b1f4008 Fix RoleUnban referring to the wrong ban type (#6885) 2022-02-24 15:59:38 -08:00
ShadowCommander e15f70fe90 Remove reference to missing JoinPublicServerButton (#6863) 2022-02-22 13:41:15 -07:00
ShadowCommander 4a68718050 Role ban improvements (#6855) 2022-02-21 22:00:55 -07:00
ShadowCommander 8ccdff4416 Prevent players from late joining as role banned jobs (#6853) 2022-02-21 19:45:59 -08:00
ShadowCommander 4825142210 Role bans (#6703) 2022-02-21 23:11:39 +01:00
ShadowCommander 7d30bff5ea Temp fix table clickable bounds (#6206)
* Temp fix table clickable bounds

* Fix single instance clickable data

* Consolidate table clickable bounds
2022-01-17 18:02:20 -08:00
ShadowCommander fc8da53fba Stops InteractionOutline when the mouse is off screen. (#6191) 2022-01-17 07:21:08 +11:00
ShadowCommander df63fe615f Fix VV Verb on entities that don't exist on the client (#6187) 2022-01-16 20:43:54 +01:00
ShadowCommander a3c1d8f22a Add job column to PlayerTab (#6181) 2022-01-15 14:17:33 +01:00
ShadowCommander d1a033644b Update admin overlay when player is renamed (#6180) 2022-01-15 14:15:41 +01:00
ShadowCommander 4f80dfda0d Verb confirmation (#6137) 2022-01-14 01:28:17 +11:00
ShadowCommanderandElectroJr adcdcaa4e4 Change VerbMenu categories to only execute solitary verbs (#6100)
Co-authored-by: ElectroJr <leonsfriedrich@gmail.com>
2022-01-11 14:34:49 +11:00
ShadowCommander b46c1d4779 Rename command (#6091)
* Add rename command

* Move EntityUid parsing to a method

* Change to only two arguments.
2022-01-09 23:22:22 -06:00
ShadowCommander 951a810fad Log GhostRole takeovers (#6089)
* Log GhostRole takeovers

* Remove entity word
2022-01-09 19:54:36 -06:00
ShadowCommander b335ef5e7f Prevent Holoparasites from attacking their host (#6019) 2022-01-04 10:22:28 +01:00
ShadowCommander 0a626353ab Make disconnected players in AdminNameOverlay different from connected players (#5931)
* Set transparency for disconnected players in the AdminNameOverlay

* Change to white instead of transparent
2022-01-03 16:40:45 -08:00
ShadowCommander 92d70b0587 Add teleport verbs (#5954)
* Add teleport verbs

* Add ftl file

* Make the verbs run the command serverside
2022-01-03 01:07:33 -08:00
ShadowCommander cd865b9aaa Remove crit and dead mobs from GhostRole list (#5992) 2022-01-01 23:00:21 -07:00
ShadowCommanderandPaul Ritter 007f4c6cbe Fix inventory UI not showing entities (#5981)
* Update inventory UI on init

* Add resolve pattern

* Update Content.Client/Inventory/ClientInventorySystem.cs

Co-authored-by: Paul Ritter <ritter.paul1@googlemail.com>

* Fix errors

Co-authored-by: Paul Ritter <ritter.paul1@googlemail.com>
2022-01-01 23:35:30 +01:00
ShadowCommander 9529883db1 Fix player tab opening multiple VV when closed by the X and reopened (#5986) 2022-01-01 23:10:46 +01:00
ShadowCommander 81607d0327 Reregister ghost role when player ghosts while alive (#5956)
* Reregister ghost role when player ghosts while alive

* Add ReregisterOnGhost property
2022-01-01 17:48:45 +01:00
ShadowCommander 04be14e057 Prevent equipping HandVirtualItems (#5982) 2022-01-02 00:20:32 +11:00