Commit Graph

7859 Commits

Author SHA1 Message Date
AJCM-git ab59cfea40
Makes machine parts stackable, removes unused field in stack prototypes (#28434)
* Makes machine parts stacks, removes unused field in stack prototypes

* forgor

* Fix tests

* Fixes lathe construction. Yes. This sucks but there's no better way that doesnt involve refactoring machine parts completely

* detail

* a
2024-06-06 21:29:09 +02:00
Tornado Tech 39650620e2
Clean up new HTNs tasks (#28469)
* Clean up new HTNs tasks

* Added docs to math operations
2024-06-06 21:29:07 +02:00
Nemanja 5e39323307
Clean up store system (#28463) 2024-06-06 21:28:46 +02:00
deltanedas 708e17a3d3
reverse engineering refactor and missing recipe test (#1230)
* make jugg not atmos hardsuit reable lmao

* re machine yaml refactor

* use the enum name to localize re results

* move a lot of code to shared and refactor

* clientside rework

* add test for missing recipes

* untroll

* make exped board recipe yml consistent with upstream

* fix unearthed sneaky bugs + generic does nothing so remove

* add mass media console board, remove roundstart boards from dynamic recipes

* remove roundstart stuff, add rcd ammo to protolathe

* dont dupe because of access electronics prototypes

* fix final fails

* final untroll

* final untroll 2

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
Co-authored-by: Null <56081759+NullWanderer@users.noreply.github.com>
2024-06-01 21:31:06 +00:00
DrSmugleaf eed9c58386
Add job whitelist system (#28085)
* Add job whitelist system

* Address reviews

* Fix name

* Apply suggestions from code review

Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com>

* cancinium

---------

Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com>
2024-06-01 18:02:43 +02:00
Nemanja 19eefe623d
Clean up command perms (#28451)
* Change BanExemption command to AdminFlags.Ban permissions

* Change LOOC to check for Moderator permission

* Change ListVerbs from Admin to Debug AdminFlags

* Change RunVerbAs from Admin to Fun AdminFlags

* More permission changes

* Change GhostKick to Moderator perm

* Clean up command perms

* fuck

---------

Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
2024-06-01 18:01:58 +02:00
Geekyhobo f7581b1f21
Adds a Pii Flag, Censors Hwid and Ip (#27776)
* yes

* fixes
2024-06-01 18:00:39 +02:00
beck-thompson 1d5827960f
Added verb for removing evidence! (#28101) 2024-06-01 18:00:22 +02:00
Verm fe3892977d
Randomizes more humanoid appearances (#27997) 2024-06-01 18:00:15 +02:00
Nemanja bacd52c991
Decouple interactions from hands, cleanup old events, add new fears (#28393)
* ok basic shit

* second part

* pretend it isn't real it can't hurt you.

* 👁️ 👁️

* shadowcommander review
2024-06-01 18:00:07 +02:00
Leon Friedrich 6427cc560e
Make chat & examine systems use FormattedMessage.EscapeText() (#28431) 2024-06-01 18:00:05 +02:00
Flesh f58fe5aaeb
Use existing probability field (#28422)
Remove the PlantAdjustAttribute "Prob" field and use the existing probability field from ReagentEffects instead.
2024-06-01 17:59:52 +02:00
Leon Friedrich c7c2c03be8
Fix hugging mispredict (#28432)
* git mv

* Move namespaces

* Fix hugging mispredict
2024-06-01 17:59:47 +02:00
deltanedas ecc9fbfe42
dragon antag refactor (#28217)
* remove dragon system usage of GenericAntag

* add AntagRandomSpawn for making antags spawn at a random tile

* add AntagSpawner to make an antag spawner just spawn an entity

* add antag prototype for dragon since it never had one

* make dragon spawner a GhostRoleAntagSpawner, remove GenericAntag

* make dragon rule use AntagSelection and stuff

* remove dragon GenericAntag rule

* add back to spawn menu

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-06-01 17:59:40 +02:00
Leon Friedrich 078794106e
Make tests automatically reset modified cvars (#28219)
* Make tests automatically reset modified cvars

* Fix bad return

* A

* Try Fix tests

* clarify comment

* update eng
2024-06-01 17:56:33 +02:00
Leon Friedrich 65a712700c
Only auto-enable internals when necessary (#28248)
* Only auto-enable internals when necessary

* Add toxic gas check

* Rename Any -> AnyPositive
2024-06-01 17:55:05 +02:00
Nemanja d1371865f1
Fix latejoin antag preferences not being respected (#28430)
* Fix latejoin antag preferences not being respected

* thank fuck for tests
2024-06-01 17:55:00 +02:00
Moony 56be0e1ee8
Handheld teleporter portals now must start on the same grid. (#28423)
Co-authored-by: moonheart08 <moonheart08@users.noreply.github.com>
2024-06-01 17:54:42 +02:00
Tayrtahn 2a56896045
Convert advertisements to use localized datasets (#28400)
* Convert advertisements to use LocalizedDatasets

* File consolidation

* Arcade machines too
2024-06-01 17:41:58 +02:00
Ed 7d53001a0e
Localize tips (#28285)
* localize tip

* localizzedDataset
2024-06-01 17:41:48 +02:00
metalgearsloth 4755223c9f
Predict ActivatableUIRequiresPower (#28405)
A lot of BUIs aren't going to handle the state coming in cleanly but we can fix em as we find em.
2024-06-01 17:38:43 +02:00
ShadowCommander ebddaa8e3d
Move ApcPowerReceiverComponent Powered state to shared (#28206)
* Try syncing powered state to client

For some reason the client is not receiving the ApcPowerReceiverComponentState, so it's not working.

* Fix powered state not syncing to client

The client PowerReceiverSystem was abstract, which prevented it from
running initialize.

* Flip check so that it runs bigger checks first

PowerDisabled skips the others.
NeedsPower skips the receiving check.

* Disallow changing Powered manually

* Move Powered update to PowerReceiverSystem

* Move appearance to event subscription

* Move metadata component to AllEntityQuery

* Cleanup

* Move Powered update back to PowerNetSystem

It's easier to use the EntityQueries and it dosen't need to be updated
anywhere else.

* Put appearance updating back

* Move IsPowered to shared

* Simplify IsPowered

* Cleanup

* Remove duplicate PowerChangedEvent

PowerChangedEvent on ProviderChanged doesn't seem to be needed
PowerChangedEvent gets raised by in update if the power state changes
after a new provider is connected
2024-06-01 17:38:41 +02:00
blueDev2 9f21df293f
Fixed hypo and injector entities going into disposal units (#28317) 2024-06-01 17:38:38 +02:00
Kevin Zheng 6714823ef6
Fix flow rate display (#28372) 2024-06-01 17:19:56 +02:00
deltanedas 819c173308
item cabinet rework + stuff (#26779) 2024-06-01 17:19:54 +02:00
metalgearsloth 1f5f2cfe45
Block gas analyzer updates if the UI doesn't open (#28376)
Fixes the gas analyzer UI coming up when used with a target.
2024-06-01 17:19:47 +02:00
Nemanja 0a686ec58e
Clean up RefiningSystem (#27904)
cleanup RefiningSystem
2024-06-01 17:19:45 +02:00
metalgearsloth b35c987322
Fix shuttle audio clipping (#27527)
Changed engine to use grid local-center and very high maxdistance / refdistance values so it's seamless.
2024-06-01 17:19:33 +02:00
Kevin Zheng a6e4fd4c7a
Tune spacing speed to fix under-pressure lockout (#28370) 2024-06-01 17:19:28 +02:00
metalgearsloth da6ab10cb3
Don't update APC states unless UI open (#27803) 2024-06-01 17:19:23 +02:00
lzk 16c0dae7cb
Remake gasp popup to emote (#27736) 2024-06-01 17:19:16 +02:00
Repo ea2668ff37
Fix late join & observe to de-admin admins. (#28319) 2024-06-01 17:18:14 +02:00
deltanedas a14aed3fca
missing nukies can be filled in by ghost roles (#28316) 2024-06-01 17:18:00 +02:00
ShadowCommander adee8b16ab
Add pressure and temperature warning text to firelocks (#28341) 2024-06-01 17:17:54 +02:00
MilenVolf df162070ac
Localize emergency shuttle's direction for announcements (#28340)
Localize emergency shuttle direction
2024-06-01 17:17:48 +02:00
Repo ead8267de2
Fix wall vending machines spawning items in walls. (#28279)
* Find spawning of wall vending machines.

* Review fixes
2024-06-01 17:17:43 +02:00
Nemanja 49ae1f57ee
Small anomaly behavior fix (#28290)
* Small anomaly behavior fix

* well put together code
2024-06-01 17:17:36 +02:00
slarticodefast d25743c22f
Cargo bounty corrections (#28255)
cargo bounty corrections
2024-06-01 17:17:29 +02:00
lzk 6ae7ceb5a3
Add popup for owner when inserting item in hand (#28032) 2024-06-01 17:15:45 +02:00
Nemanja 38b4bbf97c
Fix under-selecting antags (#28327)
Fix under selecting antags
2024-06-01 17:14:58 +02:00
Nemanja 5b87c90511
Prevent stacking pipes (#28308)
* prevent stacking pipes

* access

* notafet review

* notafet review pt. 2

* not the actual fix
2024-06-01 17:14:50 +02:00
metalgearsloth b99a66afc1
Selectively revert PullController (#28126)
I am leaving the issues open and have updated #26547 with more info on what we should do long-term. This is just to bandaid the short-term complaining.
2024-06-01 17:13:38 +02:00
Nemanja 3d8706561d
fix borg ui mispredict opening (#28305)
move borg ui junk to shared
2024-06-01 17:13:35 +02:00
deltanedas 82b8d835b2
fix antag selection being evil (#28197)
* fix antag selection being evil

* fix test

* untroll the other tests

* remove role timer troll

* Allow tests to modify antag preferences

* Fix antag selection

* Misc test fixes

* Add AntagPreferenceTest

* Fix lazy mistakes

* Test cleanup

* Try stop players in lobbies from being assigned mid-round antags

* ranting

* I am going insane

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
Co-authored-by: ElectroJr <leonsfriedrich@gmail.com>
2024-06-01 17:13:27 +02:00
Nemanja 9a7f4416b2
actually fix magic mirrors (#28282) 2024-06-01 17:13:23 +02:00
Leon Friedrich cc29590cfa
Make NetworkConfigurator use BoundUserInterfaceCheckRangeEvent (#28293) 2024-06-01 17:13:20 +02:00
Leon Friedrich 386728db2f
Fix stripping not marking interactions as handled (#28292) 2024-06-01 17:13:16 +02:00
Ady4ik 78dbdfa00c
Move PendingZombieComponent to Shared (#28143)
* Move PendingZombieComponent to Shared

* network me boy

---------

Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
2024-06-01 17:00:22 +02:00
eoineoineoin 6eef3dcea3
Objects ordered through cargo system shouldn't start anchored (#28115)
* Order normal space heater instead of anchored variant

* Make sure ordered objects don't spawn anchored

* Order space heater flatpack instead of a regular space heater

* Remove obsolete TODO

* Remove unnecessary name

---------

Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es>
2024-06-01 17:00:19 +02:00
Ed 5a9c7073c2
Fix candles (firestack fading) (#28139)
Update FlammableSystem.cs
2024-06-01 17:00:15 +02:00