Pieter-Jan Briers
b7f297f612
Fix usages of TryIndex() ( #39124 )
...
* Fix usages of TryIndex()
Most usages of TryIndex() were using it incorrectly. Checking whether prototype IDs specified in prototypes actually existed before using them. This is not appropriate as it's just hiding bugs that should be getting caught by the YAML linter and other tools. (#39115 )
This then resulted in TryIndex() getting modified to log errors (94f98073b0 ), which is incorrect as it causes false-positive errors in proper uses of the API: external data validation. (#39098 )
This commit goes through and checks every call site of TryIndex() to see whether they were correct. Most call sites were replaced with the new Resolve(), which is suitable for these "defensive programming" use cases.
Fixes #39115
Breaking change: while doing this I noticed IdCardComponent and related systems were erroneously using ProtoId<AccessLevelPrototype> for job prototypes. This has been corrected.
* fix tests
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-12-29 11:39:03 -06:00
Tayrtahn
9b0965832a
Cleanup warnings in `VendingMachineSystem` ( #37454 )
...
Cleanup warnings in VendingMachineSystem
2025-05-18 17:40:05 +01:00
Tayrtahn
fee5467d18
Fix vending machine manager wire error ( #37100 )
...
Skip updating amounts for removed entries
2025-05-18 16:12:01 +01:00
metalgearsloth
9d9e48226b
Predict vending machine UI ( #33412 )
2025-03-09 19:35:09 +00:00
metalgearsloth
67e26aa153
Fix window positions not saving ( #35055 )
...
Co-authored-by: Kevin Zheng <kevinz5000@gmail.com>
2025-03-01 14:13:07 +00:00
scrivoy
47ade44b83
Enhance Vending Machine UI: Adjust Minimum Height for better User Experience ( #32851 )
...
set FancyWindow MinHeight to 210
2024-10-24 02:09:24 +01:00
metalgearsloth
845a04c1d7
Predict vending machine BUI ( #32376 )
2024-10-02 11:24:27 +01:00
Plykiya
bebaf1f32f
Reduce vertical margin on vending machine UI ( #32074 )
...
Smaller vending machine UI
2024-09-14 14:23:34 +01:00
Pieter-Jan Briers
e1eb8373f0
Quick warning fixes ( #31694 )
2024-09-01 03:56:15 +01:00
Pieter-Jan Briers
83e9fe51ac
Fix ChemVend jugs again ( #31398 )
...
This re-introduces the dummy entity naming code, originally introduced in #29178 and randomly removed by #30064 with no technical justification given.
Fixes #31373
2024-08-27 00:50:40 +01:00
Winkarst
a2a7d57780
Make vending machine use EntityPrototypeView ( #30064 )
...
* Make vendor machines use EntityPrototypeView
* Update
* 1
* Kill me
* For the love of god!!!
2024-08-27 00:34:13 +01:00
metalgearsloth
87a4203267
Reapply "Remove some BUI boilerplate" ( #30214 ) ( #30219 )
...
* Reapply "Remove some BUI boilerplate" (#30214 )
This reverts commit cb0ba66be38677d248ce11f809221230ebe89642.
* Fix gas tank
* Fix PA
* Fix microwave
* Comms console underwrap
* Fix rcd
* log wehs
2024-08-09 17:52:22 +01:00
Nemanja
ac0a73c039
Revert "Remove some BUI boilerplate" ( #30214 )
...
Revert "Remove some BUI boilerplate (#28399 )"
This reverts commit cbf329a82d77eed2bb5e51666dab5d8a21fd3fff.
2024-08-09 17:52:21 +01:00
metalgearsloth
7af5d3dbaf
Remove some BUI boilerplate ( #28399 )
...
* Remove some BUI boilerplate
- The disposals overrides got removed due to the helper method handling it.
- Replace window creation with CreateWindow helper.
- Fixed some stinky code which would cause exceptions.
* More
* moar
* weh
* done
* More BUIs
* More updates
* weh
* moar
* look who it is
* weh
* merge
* weh
* fixes
2024-08-09 17:51:47 +01:00
Cojoke
4b43756e66
Remove all Assigned Values that are Never Used ( #30110 )
...
Remove all Assigned Values that are never used
2024-08-09 17:50:58 +01:00
Tayrtahn
aff298aac7
Fix unlabeled jugs in ChemVend ( #29178 )
...
* Spawn dummy entities on client for vending machine UI
* Asked sloth, and we kinda need this pr
---------
Co-authored-by: Vasilis <vasilis@pikachu.systems>
2024-07-25 01:45:05 +02:00
James Simonson
d5c65dd4d6
Vending UI facelift ( #25377 )
...
* Convert to fancy window + added footer + add list spacing
* margin add
(cherry picked from commit 99aa72e30dd79ed2388a449de41a2b3f70491356)
2024-02-21 03:58:07 +01:00
Kara
27895cd4d9
Open some windows non-centered to avoid covering the player ( #24767 )
...
(cherry picked from commit e212b10ca205b5a76c20a3daca4a13af435611c5)
2024-02-08 12:21:00 +01:00
themias
8166740cba
Remove need to toggle vending machine button ( #21543 )
2023-11-12 20:50:57 +01:00
Nemanja
d046e39f0e
fix searching on vending machines ( #21233 )
2023-10-31 18:45:37 +01:00
ike709
7586be1ddf
Adds a search bar to vending machines ( #20326 )
...
* Adds a search bar to vending machines
* fix indentation
* whitespace again
---------
Co-authored-by: ike709 <ike709@github.com>
2023-09-27 21:59:12 +02:00
metalgearsloth
21fdea5e5a
Remove lights compref ( #19531 )
2023-09-27 21:59:12 +02:00
TemporalOroboros
3ac4cf85db
Cleaner BoundUserInterfaces ( #17736 )
2023-07-09 02:02:17 +10:00
metalgearsloth
68480af109
Update content vectors to numerics ( #17759 )
2023-07-08 14:08:32 +10:00
Nemanja
faca40b8d5
more component ref removal + combining server/client comps ( #13178 )
...
Co-authored-by: DrSmugleaf <DrSmugleaf@users.noreply.github.com>
2022-12-25 05:28:21 +01:00
AJCM-git
c7ec03d2fb
TryGetData() Generics support content changes ( #13053 )
2022-12-20 14:24:55 -08:00
Mervill
69dd3a0454
Vending machines properly show their current state after an animation ( #12201 )
2022-10-30 17:12:05 +11:00
metalgearsloth
600c0e3255
Fix a few warnings ( #11576 )
2022-10-04 14:24:19 +11:00
Andreas Kämper
42f3155c85
Clean up vending machines and port their visualizer ( #10465 )
2022-08-31 05:12:09 -07:00
Leon Friedrich
921e2ee57d
BUI changes required for Engine PR ( #10608 )
2022-08-21 03:38:30 +10:00
Visne
58769634c7
Fix a bunch of compiler warnings ( #10518 )
2022-08-13 22:28:34 -07:00
metalgearsloth
45bd1edd5b
Revert "Update submodule to 0.34.0.0 ( #10356 )" ( #10359 )
2022-08-06 16:48:21 +10:00
Leon Friedrich
e06ea56eb2
Content BUI changes for engine PR ( #10308 )
2022-08-06 14:59:02 +10:00
Leon Friedrich
5449e7875e
Vending visualizer update ( #9962 )
2022-07-26 10:35:36 +10:00
Flipp Syder
8f223586d4
Vending machine changes ( #8060 )
...
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
2022-05-10 12:22:58 +10:00
mirrorcult
ec4d4688c7
Seal/abstract/virtual everything ( #6739 )
2022-02-16 18:23:23 +11:00
Fishfish458
b837b186a5
Attempted Small Vending Machine Refactor ( #6157 )
...
Co-authored-by: fishfish458 <fishfish458>
2022-01-31 15:16:41 +11:00
wrexbe
cea1b21832
Fixing some warnings ( #6250 )
...
Co-authored-by: Paul Ritter <ritter.paul1@googlemail.com>
2022-01-21 10:38:35 +01:00
wrexbe
5ceb2372bf
Clean up some warnings ( #6088 )
...
* Clean up some warnings
* Remove nullable enable
Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
2022-01-09 22:10:36 -06:00
Vera Aguilera Puerto
2699540526
Remove useless resolves from a buncha tests.
2021-12-08 12:46:30 +01:00
DrSmugleaf
2a3b7d809d
Fix 3000 errors
2021-12-05 18:09:01 +01:00
Vera Aguilera Puerto
5cd42c9ad6
Inline UID
2021-12-03 15:53:09 +01:00
Vera Aguilera Puerto
ee4ff9cfe8
Inline Name
2021-12-03 15:25:51 +01:00
Vera Aguilera Puerto
69b270017b
Inline TryGetComponent completely, for real
2021-12-03 14:17:01 +01:00
Vera Aguilera Puerto
0feebbff00
Inline HasComponent entirely
2021-12-03 12:23:18 +01:00
Vera Aguilera Puerto
b835bea086
Inline GetComponent
2021-12-03 11:55:25 +01:00
Vera Aguilera Puerto
f64df117be
Inline AddComponent
2021-12-03 11:33:40 +01:00
Swept
8e802b4305
Refactors Vending Menu to XAML-UI ( #4614 )
...
* Initial
* Some web-edit reviews
* Keep VV
* Applied Reviews
2021-09-19 17:21:05 +00:00
DrSmugleaf
ff1a2d97ea
Re-organize all projects ( #4166 )
2021-06-09 22:19:39 +02:00
Swept
fd2a081539
Slims down disposal unit ui and fixes thrown collisions ( #4122 )
...
* Cleans up disposal unit yaml and fixes inability to throw things in them.
* Comments out mailing units because they are beyond broken and need a refactor.
* Makes Disposal UI look better
* Localized the disposal unit
* Removes title line
* Removes changes to VendingMachineMenu, mistakenly committed.
* Applies code reviews
* Now uses BaseMachinePowered
2021-06-03 17:26:08 -07:00