* feat(wip): footprints now decals instead of entities
* fix: apply proper offset to footprint decals
* refactor: basedecaloffset to readonly
* feat: add back dragging smears, also resolve conflicts
* refactor: rename dragging to beingDragged for clarity
* docs: properly document draggingdecals
* refactor: remove unused reagent code
* refactor: move under _DV
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* feat(wip): mops now able to remove decals
# Conflicts:
# Content.Server/_DV/Footprints/Systems/PuddleFootPrintsSystem.cs
* fix: reset ColorQuantity if transparent prints
* feat: implement scrubbing
* refactor: remove unused import, ioc dependency
* feat: remove 5u water when scrubbing
* fix: remove unused attributes from protos
* docs: add summary to puddlefootprintscomp
* fix: colliding entity checked for flight, not the puddle
also minor refactor: renamed local variables/parameters of OnEndCollide for clarity
* style: remove newlines, redundant parens
* test: ensure FootPrints stepSize/dragSize are positive
* docs: add prediction todo
* feat: add bare footprints, restore sprite assignments
---------
Signed-off-by: DisposableCrewmember42 <disposablecrewmember42@proton.me>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* Defibs will now also shock anyone still interacting with the target.
* Improvements to test readability
* Apply fixes to other tests
* Refactor the interacting entities query to use an event.
* Include pullers as interacting with the entity they are pulling
* Broadcast event
* Use a constant
* Convert new test to InteractionTest
* Convert existing test
* Add behaviour note
* Revert "Convert existing test"
This reverts commit b8a8f2f68e3733bdb6ec254faf955a42096d47d7.
* Move new test into separate (InteractionTest) test file
* Use ToServer
* Use a constant for prototype id
* Use ToServer
* Add EntProtoId constructor
* Add assertion failure messages
* Manual cleanup of test entities
* Remove obsolete flag
* Add test summaries
* Remove tuple constructor
* Wrap entity deletion in WaitPost
* Extend DoAfter interacting test with an extra mob
* Move vending restocks to EntityTableContainerFills
* Glad I can actually see that fail now
* I could of just gone back to checking all the containers but nooo had to be stubborn
* Apply changes from code review
* Remove final enum coupling from gas YAML
* Fix comment
* Fix test
* Apply suggestions from code review
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Implement APC overloading
* Add power test
* Review
* Some more reviews
* Show map coordinates for test failures
* Widen column 2
* Reduce singularity beacon power consumption
* Try to get grid coordinates
* protected trait
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* right
* direction
* REFLECTION
* whoopsie
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* wowie
* whoopsie
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* WHY DID I DO THAT
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* holy shit?
* final touches
* this is dumb
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* whatever go my integration tests
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* whoopsie forgot blacklists
* load bearing loc
* minor stuff
* whoopsie
* cool
* I LOVE REFLECTION
* got a call from the stink department
* i love fluent yes
* direction changes
* waiter more migrations please
* typo ops
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Tobias Berger <toby@tobot.dev>
* Added CentComm shipyard console. Brought some things in Shipyard console up to modern standards.
* More shipyard stuff
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* PR Feedback
---------
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
* was it worth the hype
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* minor stuff
* multi-ingredient recipe support
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* oil transfer
* explosions and fire
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* make the yaml linter happy
* YML recipes
* typo ops
* review
* Apply suggestions from code review
Milon told me to.
Signed-off-by: Vanessa <908648+ShepardToTheStars@users.noreply.github.com>
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
---------
Signed-off-by: Vanessa <908648+ShepardToTheStars@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Stop-Signs <stopsign221@gmail.com>
Co-authored-by: Vanessa <908648+ShepardToTheStars@users.noreply.github.com>
* cleanup
* fix fixtures
* this belongs into the next PR
* review
* misc
---------
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
* Add unanchor attempt check
* Combine shared component and server component
- Combines SharedGravityGeneratorComponent and GravityGeneratorComponent
- AutoNetworked the GravityActiveBool
* Remove SharedGravityGeneratorComponent
* Update to SharedGravityGeneratorComponent
* Fix to be a complete sentence
* Dirty GravityActive whenever changed
* Rename component and remove view variables
* Update referenced component name
* Move unanchor attempt to shared system
* Add client system
* Revert popup to PopupEntity
* Fix popup to be PopupClient
* Set access restriction on GravityActive
* Update DamageableSystem to modern standards
* DamageContainerId -> DamageContainerID with lint flag
* Replace strings with protoids
* Make CVar subscription declarations all consistently whitespaced
* ChangeDamage -> TryChangeDamage, cope with C# jank
* Revert event signature changes
* Restore a comment
* Re-add two queries
* Init the queries
* Use appearanceQuery in DamageChanged
* Use damageableQuery in TryChangeDamage
* Use damageableQuery in SetDamageModifierSetId
* Final cleanup, fix sandboxing
* Rectify ExplosionSystem:::ProcessEntity's call to TryChangeDamage
* Re-organize DamageableSystem
* first big fuck you breaking change.
* THATS A LOT OF DAMAGE!!!
* Fix test fails
* test fixes 2
* push it
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
* predicted examine
* atrociously satanic
* do it right this time
* deltafields aren't necessary
* Update Content.Server/Atmos/EntitySystems/AtmosphereSystem.DeltaPressure.cs
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* eye on the prize
* OnStackInteractUsing, TryMergeStacks, TryMergeToHands, TryMergeToContacts
* namespace
* Use, get count, getMaxCount
* component access
* add regions, mark TODO
* obsolete TryAdd, public TryMergeStacks
* GetMaxCount
* event handlers
* event handlers
* SetCount
* client server event handlers
* move to shared
* Revert "move to shared"
This reverts commit 45540a2d6b8e1e6d2a8f83a584267776c7edcd73.
* misc changes to shared
* split
* spawn and SpawnNextToOrDrop
* SpawnMultipleAtPosition, SpawnMultipleNextToOrDrop, CalculateSpawns, general server cleanup
* Rename Use to TryUse.
* Small misc changes
* Remove obsolete functions
* Remove some SetCount calls
* Partialize
* small misc change
* don't nuke the git dif with the namespace block
* Comments and reordering
* touchup to UpdateLingering
* Summary comment for StackStatusControl
* Last pass
* Actual last pass (for now)
* I know myself too well
* fixup
* goodbye lingering
* fixes
* review
* fix test
* second look
* fix test
* forgot
* remove early comp getting
---------
Co-authored-by: iaada <iaada@users.noreply.github.com>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Integration tests for hunger and thirst
* Adjustements after the code review comments
* cleanup
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Initial edits of files
Untested yet. I would like to make sure all is accounted for before moving the files.
* trying my best
* Revert "trying my best"
This reverts commit 9aeece466df0169adec97e3947b061b54fd9b388.
* Revert "Initial edits of files"
This reverts commit 45c6e2343844b5fcafadbf2e5115fb2f241086a1.
* an actual meal
* Added networking to LungComponent.cs
* removed duplicate using
* moving GasRagents to SharedAtmosphereSystem.cs
* Enable whitelisting specific DNM prototypes per map
* Enable whitelisting directories
* Rename fields
* Use a HashSet instead of an array
* Add check for unused whitelist entries
* Remove whitelisting for meta (warden's rubber stamp was removed)
* Add glob support courtesy of @IProduceWidgets
* Update xmldoc
* Fix usages of TryIndex()
Most usages of TryIndex() were using it incorrectly. Checking whether prototype IDs specified in prototypes actually existed before using them. This is not appropriate as it's just hiding bugs that should be getting caught by the YAML linter and other tools. (#39115)
This then resulted in TryIndex() getting modified to log errors (94f98073b0), which is incorrect as it causes false-positive errors in proper uses of the API: external data validation. (#39098)
This commit goes through and checks every call site of TryIndex() to see whether they were correct. Most call sites were replaced with the new Resolve(), which is suitable for these "defensive programming" use cases.
Fixes#39115
Breaking change: while doing this I noticed IdCardComponent and related systems were erroneously using ProtoId<AccessLevelPrototype> for job prototypes. This has been corrected.
* fix tests
---------
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
* Add altInteract option to interaction test helper methods
* Add water cooler interaction test
* Oops, that's not a NetEntity
* Is.Not.Empty
* SPlayer
* Assert.Multiple
* Document parameters
DisposableCrewmember42
BarryNorfolk
slarticodefast
Ciarán Walsh
SnappingOpossum
Nemanja
Partmedia
Milon
Vanessa
Field Command
Princess Cheeseballs
Vanessa
Justin Pfeifler
Leon Friedrich
Connor Huffine
āda
Hannah Giovanna Dawson
ArtisticRoomba
JesterX666
Kyle Tyo
thetuerk
Tayrtahn
DrSmugleaf
chromiumboy
Red
IProduceWidgets
Pieter-Jan Briers