* Non-obsoletion warnings as errors in Release.
* Add two other obsoletions related to collection expressions.
These are not present in the codebase, but may become so in the future.
* Exempt NU1903 so the project can't mysteriously stop building.
* Fix some FULL_RELEASE mistakes.
* diff fix
* Resharper caught this one. Note to self: Wire up resharper to CI in another PR.
* Ban DB refactor seems to work at a basic level for PostgreSQL
* New ban creation API
Supports all the new functionality (multiple players/addresses/hwids/roles/rounds per ban).
* Make the migration irreversible
* Re-implement ban notifications
The server ID check is no longer done as admins may want to place bans spanning multiple rounds irrelevant of the source server.
* Fix some split query warnings
* Implement migration on SQLite
* More comments
* Remove required from ban reason
SS14.Admin changes would like this
* More missing AsSplitQuery() calls
* Fix missing ban type filter
* Fix old CreateServerBan API with permanent time
* Fix department and role ban commands with permanent time
* Re-add banhits navigation property
Dropped this on accident, SS14.Admin needs it.
* More ban API fixes.
* Don't fetch ban exemption info for role bans
Not relevant, reduces query performance
* Regenerate migrations
* Fix adminnotes command for players that never connected
Would blow up handling null player records. Not a new bug introduced by the refactor, but I ran into it.
* Great shame... I accidentally committed submodule update...
* Update GDPR scripts
* Fix sandbox violation
* Fix bans with duplicate info causing DB exceptions
Most notably happened with role bans, as multiple departments may include the same role.
* initial visual nubody
* oops overlay
* im so pheeming rn
* conversion...
* tests
* comeback of the underwear
* oops eyes
* blabbl
* zeds
* yaml linted
* search and visible count constraints
* reordering
* preserve previously selected markings colors
* fix test
* some ui niceties
* ordering
* make DB changes backwards-compatible/downgrade-friendly
* fix things again
* fix migration
* vulpkanin markings limit increase
* wrapping
* code cleanup and more code cleanup and more code cleanup and more code cleanup and
* fix slop ports
* better sampling API
* make filter work + use the method i made for its intended purpose
* fix test fails real quick
* magic mirror cleanup, remove TODO
* don't 0-init the organ profile data
* remove deltastates
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
# Conflicts:
# Content.Server/Humanoid/Components/RandomHumanoidAppearanceComponent.cs
# Content.Server/Humanoid/Systems/RandomHumanoidAppearanceSystem.cs
# Conflicts:
# Resources/Prototypes/Species/diona.yml
# Conflicts:
# Content.Server/Zombies/ZombieSystem.Transform.cs
* Add dataset for Secdog names
* Split secdog into a base + other dogs so laika keeps her name
* Add new system for enabling subdermal ID cards
* Check for subdermal ID cards for access and sensor information
* Add MindOnlyAccess marker component
* Add new generic K9 officer role for secdogs
* Add Laika/K9 officers to security
* Update Laika's role to match K9 officer
* Add subdermal implants and mind only access for K9 officers
* Set MobSecDogBase to abstract
* Set K9Officer card to sec colours
* Update comments for Subdermal IDCard
* Move mind check for access above log for access
* Re-use ImplanterComponent's slot name
* Move idcard container const into component as well
* Add missing setPreference and requirements to k9 officer
* Ensure admin tricks work on subdermal ID cards
* Remove subdermal ID cards from showing in nanochat
* Move secdogs.yml to _DV namespace
* Fix typo
* Unduplicate container id name
* Created Hitman_Case_catalog.yml
Signed-off-by: stormyatt <dratticuscrabs@gmail.com>
* for hitman
credit:stormyatt. thanks for the help those on discord and the host briefcase
Signed-off-by: stormyatt <dratticuscrabs@gmail.com>
* for hitman
credit: stormyatt with help from the discord sever and the hos briefcase pr
Signed-off-by: stormyatt <dratticuscrabs@gmail.com>
* 16/24 items filled
Signed-off-by: stormyatt <dratticuscrabs@gmail.com>
* for hitman
Signed-off-by: stormyatt <dratticuscrabs@gmail.com>
* more added
Signed-off-by: stormyatt <dratticuscrabs@gmail.com>
* top three filled
Signed-off-by: stormyatt <dratticuscrabs@gmail.com>
* for hitman, full disguise kit
Signed-off-by: stormyatt <dratticuscrabs@gmail.com>
* 27/30
Signed-off-by: stormyatt <dratticuscrabs@gmail.com>
* 28/30
Signed-off-by: stormyatt <dratticuscrabs@gmail.com>
* found the doorjack!
Signed-off-by: stormyatt <dratticuscrabs@gmail.com>
* spyCrewMonitor is cool
Signed-off-by: stormyatt <dratticuscrabs@gmail.com>
* found you!
Signed-off-by: stormyatt <dratticuscrabs@gmail.com>
* for hitman
Signed-off-by: stormyatt <dratticuscrabs@gmail.com>
* hitman: icons
Signed-off-by: stormyatt <dratticuscrabs@gmail.com>
* Created Hitman_Case.yml
Signed-off-by: stormyatt <dratticuscrabs@gmail.com>
* Create Hitman_Briefcase.rsi
Signed-off-by: stormyatt <dratticuscrabs@gmail.com>
* Delete Resources/Textures/_DV/Objects/Tools/Hitman_Briefcase.rsi
Signed-off-by: stormyatt <dratticuscrabs@gmail.com>
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* fixing it all
* I dont get it either but last of the changes which our just righting things
* Hitman_Case_catalog.yml be like that
* goodbye dupe
* renaming a file and removing a duplicate
* attributions changed to repect the caps
* as requested, name changes and useless line removal
* forgot to control S here
* names changed to try and be both simple and actualy describe the goal
* doing review changes and a small change to prototype order to make sense
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* how did i get where i moved this wrong?
* recharging radio jammer to radio jammer.
---------
Signed-off-by: stormyatt <dratticuscrabs@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: stormyatt <stormyatt@users.noreply.github.com>
* Nubody (#42419)
* Nubody
* fix test fails
* gibbing
* lung test returns
* doc comment
* hand organ test
* giblet test
* yaml formatting
* returning
* relocate
* trimming
* re-smite
* oops thusd tweak
* arachnids have slower metabolism i guess
* never mind the old behaviour is bad actually
* rider whyyy
* style changes and allat
* fix collision
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
* C# files done
* Visual nubody (humanoid appearance refactor) (#42476)
* initial visual nubody
* oops overlay
* im so pheeming rn
* conversion...
* tests
* comeback of the underwear
* oops eyes
* blabbl
* zeds
* yaml linted
* search and visible count constraints
* reordering
* preserve previously selected markings colors
* fix test
* some ui niceties
* ordering
* make DB changes backwards-compatible/downgrade-friendly
* fix things again
* fix migration
* vulpkanin markings limit increase
* wrapping
* code cleanup and more code cleanup and more code cleanup and more code cleanup and
* fix slop ports
* better sampling API
* make filter work + use the method i made for its intended purpose
* fix test fails real quick
* magic mirror cleanup, remove TODO
* don't 0-init the organ profile data
* remove deltastates
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
* Let vox eat trash again (#42503)
* C# complete port
* Getting closer
* Harpy Nubody Port
* Port Feroxi, Kitsune. Fix some yml typos and remove ipcs stuff
* Port Oni
* Port Rest, except Motorkind
* Port Motorkind
* Remove more surgery, restore too much deleted stuff
* Fix Typos and change some organ names. Need to split eyes next
* Harpy HAve Wings again
* Some fixes, More Surgeyr Removal, Copying of eye organs
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* Use correct Body imports
* Markings Refactoring, Harpy Layering
* Motorkind doesn't crash anymore. Some layer remappings.
* Allow Organs to have Markings Displacements again. (#43604)
* first shtep
* readd markings support
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
* Fix STalk eyes and several layerings
* Fix sexed organs (#42554)
* Fix markings for several species, fit them for sexed organs and rename some files to fit them for it
* Additional IPC-related removals
* Vulpkanin eyes are now correct again
* Fix Subtle Cultist Marks on species
* Fix Asakim Sprites (sexed) and make CD imports work
* Migration, error fixes, and Height
* Fix humanoid profile voice being broken (#42550)
Fix humanoid appearance voice being broken
* Change Kitsune SexChanged Event to with ref
* Fix asakim issue, Respirator fix
* Simplify hands UI code (#42534)
* Simplify hands UI code
* i remembered about SortedHands in the component
* minor cleanup
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
* Set size of Analyzer back to 350, Kitsune can't gib themselves no more. Migration
* yml linter errors and an rudimentary onAdd Organ Functionality
* Fixing it trying to remove nothing
* midpoint migration
* Why do you put so many organs everywhere
* More missing prototypes
* Migration of more organs
* Forgot lungs
* Move character preview handling into a specialized control (#41252)
* Move character preview handling into a specialized control
Co-authored-by: Quantum-cross <7065792+Quantum-cross@users.noreply.github.com>
* Restore job name that I accidentally removed from character picker buttons
* Just resolve dependencies the standard way
---------
Co-authored-by: Quantum-cross <7065792+Quantum-cross@users.noreply.github.com>
Co-authored-by: Janet Blackquill <uhhadd@gmail.com>
* Drop ICharacterProfile/ICharacterAppearance interfaces (#42661)
* Ensure profile loading only returns valid species (#42842) (Stable merge) (#42865)
Co-authored-by: pathetic meowmeow <uhhadd@gmail.com>
* Changes to make it work for us.
* No more bald Harpy
* OperatingTables instead of null
* Adding Delta V Comments, commenting out instead of deleting
* Fix broken Height Scale.
* Remove HumanoidSilicon Mention
* Did an error. Readded, uncommented.
* Clean up Marking data structure, add tests for Zombie transformation (#42756)
* Clean up Marking data structure, add tests for Zombie transformation
* empty
* AAAAAAAAAAAAAAAA
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
* Fix markings colour setting (#42771)
* Fix: Markings Color For Downstream
* Comment out A Leg. Remove Todo
* Revert to original hidden species code
---------
Co-authored-by: pathetic meowmeow <uhhadd@gmail.com>
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Princess Cheeseballs <66055347+Princess-Cheeseballs@users.noreply.github.com>
Co-authored-by: Absotively <jen@jenpollock.ca>
Co-authored-by: Quantum-cross <7065792+Quantum-cross@users.noreply.github.com>
Co-authored-by: Myra <vasilis@pikachu.systems>
* Decouple gibbing from the body system
* allow gibs that don't drop giblets
* pass through user
* prediction gon
* comment
* destructible
* playpvs
* very very very very very very very minor cleanup
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
* Entity<T>, skipping Magazine and ChamberMagazine
* missed some
* AUGH!!
* ballistic examine
* dotnet hates me
* WHY ARE YOU CALLED THAT!!!!
* cheers aada
* no longer calls evac if evac is called or if the round is over
* can't recall shuttle
* some commentary
* can recall next round
* cancel evac recalling
* add this back
* only call once
* admins can recall anyway now
* 1 bool is better than 2 i guess
* some cleanup
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
* feat: added lslaws command
* feat: add lswatchlisted command
* tweak: nicer formatting for lswatchlisted
* tweak: nicer formatting for lslaws
* feat: lsobjectives lists everyone's objectives if no user specified
* feat: mark ghosted players in players tab
* docs: add missing DeltaV patch comment
* feat: only alert admins if meatspiking player characters
* feat: always alert about station explosions, don't spam off-station alerts
* feat: stripping alert tweaks
* feat: admin alert on low hour latejoin
* refactor: forgot to make onspawncomplete non-async, wasn't necessary after all
* feat: EORG alerts
* feat: getping command
* refactor: remove unused imports, format
* refactor: early return in onspawncomplete
* feat: add coordinate link to eorg destroy alert
* tweak: cache watchlist data to avoid db calls, use in lswatchlisted
* fix: null-check in OnNoteAdded
* feat: watchlist indicator on admin overlay
* feat: optionally mark watchlisted in f7 players
* feat: refresh admin playerlist data on wl change
* fix: update player list after cache write
* feat: add tp links to prayer messages
* tweak: don't alert when uncuffing self
* tweak: lower uncuff other alert impact if mindshielded
* docs: add deltav comments to imports
* refactor: address review comments
* style: deltav comments on same line as change
* performance: get metadata only if objectives > 0
* fix: actually check user if explosion gridPos not on station
* style: remove extraneous newlines
* refactor: use fancy getOrNew method
* feat: refresh player list UI if marking pref changed
* feat: latejoin alert hours configurable
* fix: also list objectives for non-humanoids and dead people
* first
* station event rule, random objectives but error with giving antag status
* cleanup
* had a stroke and i think i did the event correctly
* small unfuckery
* listen to cc better wording
* guidebook added
* somehow duplicated the entirety of events.yml
* what they asked of me was implemented...
* test for now
* icon fix
* text fix
* fucking around, using it more like changeling yo
* whatever failed tests
* probably works?
* fix
* test test
* messing around yet again
* removed useless file
* [pre-commit.ci] auto fixes from pre-commit.com hooks
for more information, see https://pre-commit.ci
* why the fuck do objectives work now
* fix round screen not showing up
* implanter, music track and general fixes added
* text improvement
* slightly fixed formatting
* conflict fix
* Update Resources/Prototypes/_DV/Roles/Antags/ntAgent.yml
NTAgent-round-end-name
Co-authored-by: Vanessa <908648+ShepardToTheStars@users.noreply.github.com>
Signed-off-by: Cepelinas1 <kakelis01@gmail.com>
* Update Resources/Prototypes/_DV/Roles/Antags/ntAgent.yml
NTAgent-role-greeting-human
Co-authored-by: Vanessa <908648+ShepardToTheStars@users.noreply.github.com>
Signed-off-by: Cepelinas1 <kakelis01@gmail.com>
---------
Signed-off-by: Cepelinas1 <kakelis01@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
Co-authored-by: Vanessa <908648+ShepardToTheStars@users.noreply.github.com>
* Update DamageableSystem to modern standards
* DamageContainerId -> DamageContainerID with lint flag
* Replace strings with protoids
* Make CVar subscription declarations all consistently whitespaced
* ChangeDamage -> TryChangeDamage, cope with C# jank
* Revert event signature changes
* Restore a comment
* Re-add two queries
* Init the queries
* Use appearanceQuery in DamageChanged
* Use damageableQuery in TryChangeDamage
* Use damageableQuery in SetDamageModifierSetId
* Final cleanup, fix sandboxing
* Rectify ExplosionSystem:::ProcessEntity's call to TryChangeDamage
* Re-organize DamageableSystem
* first big fuck you breaking change.
* THATS A LOT OF DAMAGE!!!
* Fix test fails
* test fixes 2
* push it
---------
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
* eye on the prize
* OnStackInteractUsing, TryMergeStacks, TryMergeToHands, TryMergeToContacts
* namespace
* Use, get count, getMaxCount
* component access
* add regions, mark TODO
* obsolete TryAdd, public TryMergeStacks
* GetMaxCount
* event handlers
* event handlers
* SetCount
* client server event handlers
* move to shared
* Revert "move to shared"
This reverts commit 45540a2d6b8e1e6d2a8f83a584267776c7edcd73.
* misc changes to shared
* split
* spawn and SpawnNextToOrDrop
* SpawnMultipleAtPosition, SpawnMultipleNextToOrDrop, CalculateSpawns, general server cleanup
* Rename Use to TryUse.
* Small misc changes
* Remove obsolete functions
* Remove some SetCount calls
* Partialize
* small misc change
* don't nuke the git dif with the namespace block
* Comments and reordering
* touchup to UpdateLingering
* Summary comment for StackStatusControl
* Last pass
* Actual last pass (for now)
* I know myself too well
* fixup
* goodbye lingering
* fixes
* review
* fix test
* second look
* fix test
* forgot
* remove early comp getting
---------
Co-authored-by: iaada <iaada@users.noreply.github.com>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
Simon
Kyle Tyo
Coryler
pathetic meowmeow
Moony
B_Kirill
Samuka
Pieter-Jan Briers
BarryNorfolk
mq
YoungThugandbeck-thompson
ScarKy0andslarticodefast
Errant
Pok
DisposableCrewmember42
Cepelinas1
ThatGuyUSA
Hannah Giovanna DawsonandPrincess Cheeseballs
beck-thompson
Leon Friedrichandslarticodefast
Kyle Tyo
Jessica MandJessica M
IProduceWidgets