Delta-v/Content.Server/GameTicking/Rules
Fildrance a58252f45e
feat: #26107 uplink discounts for traitors (no nukies for now) (#26297)
* feat: #26107 uplink discounts for traitors and nukies

* refactor: #26107 extracted discount label from price of StoreListingControl

* refactor: minor renaming

* refactor: parametrized adding discounts to uplink store

* fix: #26107 prevent exception on empty discountOptions

* feat: uplink now have 'Discounted' category which contains all discounted items on this session.

* after merge fixups

* rename discount categories according to common sense

* refactor: DiscountOptions is now optional (nullable) on ListingData

* add nullability check ignore for already checked listingData.DiscountOptions

* fix after merge store menu ui

* remove unused using

* final fix after merge conflicts

* [refactor]: #26107 fix variables naming in UplinkSystem

* fix: #26107 fix after merge

* refactor: #26107 now supports discountDownUntil on ListingItem, instead of % of discount

* feat: #26107 support multiple currency discount in store on side of discount message label

* refactor: #26107 extracted discounts initialization to separate system. StoreDiscountData are spread as array and not list now

* refactor: #26107 move more code from storesystem to StoreDiscountComponent

* refactor: #26107 separated StoreSystem and StoreDiscountSystem using events

* fix: #26107 placed not-nullable variable initialization in ListingData for tests

* refactor: #26107 minor renaming, xml-docs

* fix: #26107 changed most of discounts to be down to half price for balance purposes

* ids used in with discounts are now ProtoIds, dicountCategories are now prototypes, code with weights simplified

* decoupled storesystem and store discount system

* xml-docs

* refactor:  #26107 xml-doc for StoreDiscountSystem

* is now a thing (tmp)

* fix: compilation errors + StoreDiscountData.DiscountCategoryId

* refactor: rename ListingDataWithCostModifiers, fix all cost related code, enpittyfy performance, uglify uplink_catalog

* refactor: removed unused code, more StoreDiscountSystem docs, simplify code

* refactor: moved discount category logic to respective system, now creating ListingData c-tor clones all mutable fields as expected

* refactor: rename back (its not prototype)

* refactor: move ListingItemsInitializingEvent to file with handling logic

* refactor: comments for StoreBuyFinishedEvent handling, more logging

* refactor: moved StoreInitializedEvent, xml-doc

* refactor: simplify StoreDiscountSystem code  (reduce nesting) + xml-doc

* refactor: restore old listing data cost field name

* refactor: fix linter in uplink_catalog.yml

* refactor: xml-doc for ListingDataWithCostModifiers

* refactor: limit usage of ListingData in favour of ListingDataWithCostModifiers

* refactor: purged linq, removed custom datafield names, minor cleanup

* refactor: removed double-allocation on getting available listings

* refactor: StoreSystem.OnBuyRequest now uses component.FullListingsCatalog as reference point (as it was in original code)

* fix: minor discount categories on uplink items changes following design overview

* refactor: StoreBuyListingMessage now uses protoId and not whole object

* refactor: store refund and discount integration test, RefreshAllListings now translates previous cost modifiers to refreshed list, if state previous to refresh had any listing items

---------

Co-authored-by: pa.pecherskij <pa.pecherskij@interfax.ru>
2024-09-05 22:12:39 +10:00
..
Components remove(NukeopsRuleComponent): Remove a trap from the component file (#31029) 2024-08-16 00:52:36 -04:00
VariationPass Replace obsolete EntityWhitelist IsValid usages part 2 (#28506) 2024-06-03 17:40:03 -04:00
AntagLoadProfileRuleSystem.cs Re-enabling nukie species(except vox), added antag species blacklisting 2024-07-05 00:59:16 -07:00
DeathMatchRuleSystem.cs move gamerule components to shared (#28572) 2024-06-04 21:53:24 +10:00
GameRuleSystem.Utility.cs move gamerule components to shared (#28572) 2024-06-04 21:53:24 +10:00
GameRuleSystem.cs Missing meteor presets (#29044) 2024-06-16 21:37:43 +02:00
InactivityTimeRestartRuleSystem.cs move gamerule components to shared (#28572) 2024-06-04 21:53:24 +10:00
KillCalloutRuleSystem.cs move gamerule components to shared (#28572) 2024-06-04 21:53:24 +10:00
LoadMapRuleSystem.cs Remove all Assigned Values that are Never Used (#30110) 2024-07-18 20:22:23 -04:00
MaxTimeRestartRuleSystem.cs move gamerule components to shared (#28572) 2024-06-04 21:53:24 +10:00
NukeopsRuleSystem.cs Fix nuke disk erroneously being marked 'left behind' (#31602) 2024-08-28 14:05:04 -06:00
RespawnRuleSystem.cs move gamerule components to shared (#28572) 2024-06-04 21:53:24 +10:00
RevolutionaryRuleSystem.cs move gamerule components to shared (#28572) 2024-06-04 21:53:24 +10:00
RoundstartStationVariationRuleSystem.cs move gamerule components to shared (#28572) 2024-06-04 21:53:24 +10:00
RuleGridsSystem.cs LoadMapRule grid storage rework (#28210) 2024-06-03 20:04:19 -04:00
SandboxRuleSystem.cs move gamerule components to shared (#28572) 2024-06-04 21:53:24 +10:00
SecretRuleSystem.cs Remove all Assigned Values that are Never Used (#30110) 2024-07-18 20:22:23 -04:00
SubGamemodesSystem.cs move gamerule components to shared (#28572) 2024-06-04 21:53:24 +10:00
ThiefRuleSystem.cs Remove all Assigned Values that are Never Used (#30110) 2024-07-18 20:22:23 -04:00
TraitorRuleSystem.cs feat: #26107 uplink discounts for traitors (no nukies for now) (#26297) 2024-09-05 22:12:39 +10:00
ZombieRuleSystem.cs fix initial infected icons and add a briefing to the character menu (#29259) 2024-06-21 15:42:17 +10:00