Delta-v/Content.Shared/Atmos
ArtisticRoomba f874459092
Pressure Relief Valve (#36708)
* initial system (this math is probably WRONG)

* General code cleanup and OnExamined support
(holy moly this code sucks)

* UICode and related events foundation
TODO:
- Actually write the XAML UI and the underlying system
- Un-shitcode the entire thing
- Actually test everything...

* Working UI code
TODO: Make predicted, as this certainly isn't predicted. Even though I said it was. It isn't.

* Remove one TODO for unshitcoding the examine code

* Add reminder
yea

* Make predicted (defenitely isn't)
(also defenitely isn't a copypaste from pressure pump code)

* It's predicted!
TODO:
- Give it snazzy predicted visuals!
- Have a different field for pressure entry, lest it gets bulldozed every UI update.

* Improve gas pressure relief valve UI
TODO: Reminder to reduce amount of dirties using deltafields

* Implement DirtyField prediction

* Entity<T> cleanup
A lot of Entity<T> conversions and lukewarm cleanup.

Also got caught copy pasting code in 4K UHD but it's not like you couldn't tell.

* More cleanup and comments

* Remove TODO comment on bulldozing window title

* """refactoring"""
- Move appearance out of shared and finally fix it. Pointless to predict appearance in this instance.
- More Entity<T> conversions because I like them.
- Move UI creation handling over entirely to the ActivatableUI system.
- Fix a hardcoded locale string (why????).

* Add visuals

* Revert debugging variable replacememt
yea

* Revert skissue

* Remove unused using directives and remove TODO

* Localize, cleanup, document

* Fix adminlogging discrepancy

* Add ability to construct, add guidebook entry

* Clear up comment

* Add guidebook tooltip to valve

* Convert GasPressureReliefValveBoundUserInterface declaration into primary constructor

* Adds more input handling and adds autofill on open

* Un-deepfry input validator shitcode
Genuinely what was I smoking

* improve visuals logic

* Refactor again
- Update math to the correct implementation
- Moved code that could be re-used in the future into a helper method under AtmosphereSystem.Gases.cs

* I'm sorry but I hate warnings

* Remove unused using directive in AtmosphereSystem.Gases.cs

* Review and cleanup

* Lukewarm UI glossup

* Maintainer for the upstream project btw

* Remove redundant state sets and messy logic

* Unduplicate valve updater code

* Redo UI (im sorry Slarti)

* run tests

* Test refactored UI messaging

* Second round of UI improvements
- God please find a way to improve this system. Feels bad.

* Update loop implementation

* Further predict UI

* Clear up SetToCurrentThreshold

* cleanup

* Update to master + pipe layers and bug fixes
want to run tests

* fixes

* Deploy rename pipebomb

* Documentation and requested changes

* Rename the method that wiggled away

* Undo rounding changes

* Fix comment

* Rename and cleanup

* Apply suggestions from code review

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-07-03 18:00:34 +02:00
..
Components Make gas tank UI a bit more network-happy (#38184) 2025-06-21 11:06:49 +02:00
Consoles Layering for atmospheric pipes (#36124) 2025-06-01 22:01:43 -07:00
EntitySystems Pressure Relief Valve (#36708) 2025-07-03 18:00:34 +02:00
Monitor Cleanup some misc warnings (#37904) 2025-05-28 12:45:38 -04:00
Piping Pressure Relief Valve (#36708) 2025-07-03 18:00:34 +02:00
Portable/Components Add space heaters (#25250) 2024-02-28 10:27:29 -08:00
Prototypes Cleanup: Remove redundant prototype name specifications (#35793) 2025-03-19 19:30:31 +01:00
Reactions Move GasMixture to shared (#27480) 2024-04-30 14:31:05 -07:00
Rotting Hivelord mob (#31322) 2024-09-11 09:52:27 -04:00
Visuals Change atmos plaques to yaml (#37318) 2025-05-10 02:24:07 +02:00
AtmosCommandUtils.cs Cleanup the namespaces (#8132) 2022-05-13 17:59:03 +10:00
AtmosDirection.cs Replace NavMap dictionaries with int[] (#27602) 2024-05-02 12:51:21 +10:00
Atmospherics.cs Bring back low pressure damage to its unnerfed value (#38196) 2025-06-09 17:05:48 -07:00
FireEvents.cs Fire extinguishers can now extinguish items, including when held/worn (#36267) 2025-04-14 19:00:47 +10:00
FireVisuals.cs Cleanup the namespaces (#8132) 2022-05-13 17:59:03 +10:00
GasMixture.cs Make ReactionResults an array (#34967) 2025-02-09 03:13:47 +01:00
GasMixtureStringRepresentation.cs Move GasMixture to shared (#27480) 2024-04-30 14:31:05 -07:00
GasOverlayChunk.cs Fix exception with gas overlay rendering (#24001) 2024-01-13 00:22:10 +01:00
GetFireProtectionEvent.cs Fire damage system fixes (#37241) 2025-05-06 22:03:05 -04:00
IGasMixtureHolder.cs Predicted internals (#33800) 2025-05-02 18:22:29 +10:00
PipeDirection.cs Cleanup the namespaces (#8132) 2022-05-13 17:59:03 +10:00