Pieter-Jan Briers a926d0810f Fix some rounds failing to end due to mind roles (#32792)
* Fix some rounds failing to end due to mind roles

Fixes #32791

This is caused by ShowRoundEndScoreboard running into a bug trying to display antags: some player is showing up as antag with MindIsAntagonist(), but has no antag roles listed in MindGetAllRoleInfo().

This was caused by one of the roles of the player having the Antag boolean set, but having no AntagPrototype set.

The responsible mind role appeared to be MindRoleSubvertedSilicon which is missing a set for the SubvertedSilicon antag prototype.

I also added resilience to the round-end code to make it so that an exception showing the scoreboard (and sending the Discord message) would not cause the round end logic to completely abort from an exception.

I am planning to add an integration test to cover this bug (no prototype in mind roles), but I'll leave that for not-the-immediate-hotfix.

* At least one maintainer approved this tiny PR without reading it, not naming names.
2024-10-24 01:59:40 +01:00
2024-02-21 03:56:47 +01:00
2024-05-03 00:04:44 +02:00
2023-03-04 23:56:55 +00:00
2024-06-06 21:54:06 +02:00
2024-06-06 21:54:06 +02:00
2023-12-16 20:31:24 +01:00
2024-02-18 03:11:47 +01:00
2024-09-20 13:32:25 +00:00
2024-09-20 13:32:25 +00:00
2024-09-20 13:32:25 +00:00
2024-09-20 13:32:25 +00:00
2024-07-25 00:34:48 +02:00
2024-09-20 13:32:25 +00:00
2024-07-25 00:34:48 +02:00
2023-03-09 16:01:40 -06:00
2024-08-30 05:35:45 +01:00

Space Station 14 Delta-V Logo

Delta-V is a fork of Space Station 14, embracing a mixture of classic SS13 chaos and experimentation only possible with the new engine.

Space Station 14 is a remake of SS13 that runs on Robust Toolbox, a homegrown engine written in C#.

Delta-V is a continuation of the Nyanotrasen fork. Any work done in a non-base namespace may contain incorrect attributes due to rewrites and recommitting.

DeltaV

Website | Wiki | Discord

Space Station 14

Website | Discord | Forum | Steam | Standalone Download

Documentation/Wiki

The docs site has documentation on SS14s content, engine, game design and more. It has lots of resources for new contributors to the project.

Contributing

We are happy to accept contributions from anybody. Get in Discord if you want to help. We've got a list of issues that need to be done and anybody can pick them up. Don't be afraid to ask for help either!

We are currently accepting translations of the game on our main repository. If you would like to translate the game into another language check the #localization channel in our Discord

If you make any contributions, please make sure to read the markers section in MARKERS.md Any changes made to files belonging to our upstream should be properly marked in accordance to what is specified there.

Building

  1. Clone this repo.
  2. Run RUN_THIS.py to init submodules and download the engine.
  3. Compile the solution.

More detailed instructions on building the project.

License

Content contributed to this repository after commit 87c70a89a6 is licensed under the GNU Affero General Public License version 3.0, unless otherwise stated. See LICENSE-AGPLv3.txt. Content contributed to this repository before commit 87c70a89a6 is licensed under the MIT license, unless otherwise stated. See LICENSE-MIT.txt.

87c70a89a67d0521a56388e6b1c3f2cb947943e4 was pushed on February 17th 2024 at 21:48 UTC

Most assets are licensed under CC-BY-SA 3.0 unless stated otherwise. Assets have their license and the copyright in the metadata file. Example.

Note that some assets are licensed under the non-commercial CC-BY-NC-SA 3.0 or similar non-commercial licenses and will need to be removed if you wish to use this project commercially.

S
Description
A fork of Space Station 14, embracing a mixture of classic SS13 chaos and experimentation only possible with the new engine
Readme
2.6 GiB
Languages
C# 91.2%
Fluent 8.3%
Python 0.3%