cmdrunematti
/
Delta-v
mirror of https://github.com/DeltaV-Station/Delta-v.git
1
0
Fork 0
Code Issues Packages Projects Releases Wiki Activity
Delta-v/Content.IntegrationTests/Tests
History
Pieter-Jan Briers 589c55a6fc
Solution precision fixes (#25199) 
* Add test for two chemistry issues

1. rounding issue with reaction processing when making chloral hydrate
2. reliable assert trip due to the ValidateSolution() heat capacity issue.

* Fix FixedPoint2 arithmetic

Fix internal floating point arithmetic in places where it could be avoided.

Fix incorrect rounding mode used in other places (it should always floor, like regular int arithmetic).

I had to add an explicit epsilon value for float -> FixedPoint2 because something like 1.05 is actually like 1.04999 and that'd cause it to be rounded down to 1.04.

This fixes reaction reagent processing in cases where the reagent inputs can't cleanly divide. Previously, when making 30u chloral hydrate by adding the chlorine in 10u increments you'd end up with 0.04 chlorine left over. This was caused by division in the reaction code rounding up in some cases. Changing division here to always round down fixes it.

* Attempt to fix heat capacity precision assert issues.

Fixes #22126

First, we just increase the tolerance of the assert. It was way too low.

Second, actually put a cap on float drift from one-off _heatCapacity changes.

* Fix float -> FixedPoint2 epsilon for negative number, fix tests.

* Fix DamageableTest

* Oh yeah I need to call CleanReturnAsync

(cherry picked from commit 33611b7094)
 		2024-02-18 23:27:29 +01:00
..
Access Remove obsolete TestPair.Pair (#19496) 2023-08-25 10:56:51 +10:00
Actions Random spontaneous cleanup PR (#25131) 2024-02-18 23:02:29 +01:00
Administration/Logs Un-revert IPlayerManager refactor (#21244) 2023-10-31 19:00:44 +01:00
Atmos Remove obsolete TestPair.Pair (#19496) 2023-08-25 10:56:51 +10:00
Body Try fix organ networking (#23034) 2024-01-22 18:44:25 +01:00
Buckle Dependency update / fixes / skrungle bungle (#23745) 2024-01-26 22:33:46 +01:00
Chemistry Solution precision fixes (#25199) 2024-02-18 23:27:29 +01:00
Cleanup Un-revert IPlayerManager refactor (#21244) 2023-10-31 19:00:44 +01:00
Climbing Climbing refactor (#20516) 2023-10-14 22:02:29 +02:00
Commands Remove obsolete PoolManager methods (#19499) 2023-08-25 12:13:11 +10:00
Construction Minor test fixes (#25174) 2024-02-18 23:11:13 +01:00
Damageable Solution precision fixes (#25199) 2024-02-18 23:27:29 +01:00
DeltaV Fix Crime Assist incorrect entires and add a test (#624) 2023-12-31 17:22:56 +01:00
Destructible Destruction & impact sound rework pass 1 (#24282) 2024-01-26 23:10:41 +01:00
DeviceNetwork Predict two-way levers (#25043) 2024-02-18 22:46:26 +01:00
Disposal Remove obsolete PoolManager methods (#19499) 2023-08-25 12:13:11 +10:00
DoAfter Add netserializable to test doafter (#24313) 2024-01-26 23:13:42 +01:00
Doors Remove obsolete TestPair.Pair (#19496) 2023-08-25 10:56:51 +10:00
EncryptionKeys Refactoring body system to use containers and general body cleanup (#20202) 2023-09-27 21:59:12 +02:00
Fluids Revert 'Revert 'Solution Entities'' (#23168) 2024-01-23 23:00:42 +01:00
GameObjects/Components Random spontaneous cleanup PR (#25131) 2024-02-18 23:02:29 +01:00
GameRules Roundstart variation game rules (#24397) 2024-02-08 12:03:43 +01:00
Gravity Remove obsolete PoolManager methods (#19499) 2023-08-25 12:13:11 +10:00
Guidebook Fix guideentryprototypetests (#24427) 2024-01-27 23:44:05 +01:00
Hands Remove obsolete PoolManager methods (#19499) 2023-08-25 12:13:11 +10:00
Interaction Random spontaneous cleanup PR (#25131) 2024-02-18 23:02:29 +01:00
Lobby Remove obsolete PoolManager methods (#19499) 2023-08-25 12:13:11 +10:00
Materials Remove obsolete PoolManager methods (#19499) 2023-08-25 12:13:11 +10:00
Minds Add TryGetPrimaryDepartment to jobs system (#23317) 2024-01-26 22:48:20 +01:00
NPC Remove obsolete TestPair.Pair (#19496) 2023-08-25 10:56:51 +10:00
Networking Fix missing [NetSerializable] in SimplePredictReconcileTest (#24161) 2024-01-26 22:56:49 +01:00
Nyanotrasen Metempsychosis Returns (#685) 2024-02-18 03:36:16 +01:00
Payload Move grenade components to shared (#22691) 2024-02-08 12:22:56 +01:00
Physics Add some tests and fix some miscellaneous bugs (#22836) 2024-01-22 18:44:30 +01:00
Power Remove obsolete TestPair.Pair (#19496) 2023-08-25 10:56:51 +10:00
Preferences Fix tests (#24809) 2024-02-08 12:20:24 +01:00
Procedural Remove obsolete TestPair.Pair (#19496) 2023-08-25 10:56:51 +10:00
PrototypeTests Remove obsolete TestPair.Pair (#19496) 2023-08-25 10:56:51 +10:00
Puller Emergency revert for pulling (#24923) 2024-02-08 12:34:47 +01:00
Replays Mark all tests that restart rounds as dirty (#21376) 2023-11-12 20:29:56 +01:00
Serialization Dependency update / fixes / skrungle bungle (#23745) 2024-01-26 22:33:46 +01:00
Shuttle Fix some test warnings (#24324) 2024-01-26 23:16:18 +01:00
Slipping Fix thirst errors in tests (#20481) 2023-09-27 21:59:12 +02:00
Sprite Virtual items cleanup (#23912) 2024-01-26 22:49:14 +01:00
Station Fix tests (#20017) 2023-09-27 21:59:12 +02:00
Storage Fix storage destruction/deletion bug (#24882) 2024-02-08 12:27:14 +01:00
Tag Remove obsolete TestPair.Pair (#19496) 2023-08-25 10:56:51 +10:00
Tiles Content update for NetEntities (#18935) 2023-09-27 21:59:12 +02:00
Toolshed Dependency update / fixes / skrungle bungle (#23745) 2024-01-26 22:33:46 +01:00
Utility Remove obsolete PoolManager methods (#19499) 2023-08-25 12:13:11 +10:00
Weldable Weldable cleanup (#19809) 2023-09-05 00:07:01 +10:00
CargoTest.cs Fix some test warnings (#24324) 2024-01-26 23:16:18 +01:00
ClickableTest.cs Content update for NetEntities (#18935) 2023-09-27 21:59:12 +02:00
ConfigPresetTests.cs Fix ConfigPresetTests.TestLoadAll not handling automatic panic bunker (#23414) 2024-01-26 21:27:08 +01:00
ContainerOcclusionTest.cs Content update for NetEntities (#18935) 2023-09-27 21:59:12 +02:00
DeleteInventoryTest.cs Remove obsolete PoolManager methods (#19499) 2023-08-25 12:13:11 +10:00
DummyIconTest.cs Remove obsolete TestPair.Pair (#19496) 2023-08-25 10:56:51 +10:00
EntityTest.cs Fix some test warnings (#24324) 2024-01-26 23:16:18 +01:00
FollowerSystemTest.cs Replace usages of MobObserver and AdminObserver with GameTicker consts (#21814) 2023-12-02 19:00:03 +01:00
GravityGridTest.cs Fix GravityGridTest (#23348) 2024-01-23 22:53:53 +01:00
HumanInventoryUniformSlotsTest.cs Implement gridinv, proper (#703) 2024-01-21 19:58:28 +01:00
InventoryHelpersTest.cs Remove obsolete TestPair.Pair (#19496) 2023-08-25 10:56:51 +10:00
LogErrorTest.cs Remove obsolete TestPair.Pair (#19496) 2023-08-25 10:56:51 +10:00
MachineBoardTest.cs Remove obsolete TestPair.Pair (#19496) 2023-08-25 10:56:51 +10:00
MaterialArbitrageTest.cs Remove obsolete PoolManager methods (#19499) 2023-08-25 12:13:11 +10:00
PostMapInitTest.cs Submarine Station (#704) 2024-02-01 13:30:23 -06:00
PrototypeSaveTest.cs Revert Arch testmerge 2 (#21901) 2023-12-02 19:05:12 +01:00
ResearchTest.cs Remove obsolete TestPair.Pair (#19496) 2023-08-25 10:56:51 +10:00
ResettingEntitySystemTests.cs Mark all tests that restart rounds as dirty (#21376) 2023-11-12 20:29:56 +01:00
RestartRoundTest.cs Mark all tests that restart rounds as dirty (#21376) 2023-11-12 20:29:56 +01:00
RoundEndTest.cs Changes required for frozen event bus PR (#23493) 2024-01-26 21:33:07 +01:00
SalvageTest.cs Salvage magnet revamp (#23119) 2024-01-26 21:35:22 +01:00
SaveLoadMapTest.cs Remove obsolete TestPair.Pair (#19496) 2023-08-25 10:56:51 +10:00
SaveLoadSaveTest.cs Wd 1984 (#307) 2023-10-25 18:07:25 +02:00
ShuttleTest.cs Fix some test warnings (#24324) 2024-01-26 23:16:18 +01:00
StartTest.cs Remove obsolete TestPair.Pair (#19496) 2023-08-25 10:56:51 +10:00
StorageTest.cs Implement gridinv, proper (#703) 2024-01-21 19:58:28 +01:00
VendingMachineRestockTest.cs DamageSpecifier Total => GetTotal (#24160) 2024-01-27 23:42:35 +01:00