Commit Graph

4264 Commits

Author SHA1 Message Date
Adeinitas 6d639d6d29
Carpy the Legal Carp gets a suit for differentiation (#1456)
* Carpy gets custom sprite!!

WOOO!!!

* yuh

* Does some funny shit that allows the suit to properly render I hope

* Pro backslash usage

* Update pets.yml

* Trolled by double layers yaml

* Update Resources/Prototypes/DeltaV/Entities/Mobs/NPCs/pets.yml

Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com>
Signed-off-by: Adeinitas <147965189+adeinitas@users.noreply.github.com>

* Update Resources/Prototypes/DeltaV/Entities/Mobs/NPCs/pets.yml

Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com>
Signed-off-by: Adeinitas <147965189+adeinitas@users.noreply.github.com>

* I hope this fixes it

* Added extra state to damage visualizer for carpy

* Cleanup old code

* Sprite update

---------

Signed-off-by: Adeinitas <147965189+adeinitas@users.noreply.github.com>
Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com>
Co-authored-by: Timemaster99 <57200767+Timemaster99@users.noreply.github.com>
2024-08-12 22:47:30 +00:00
portfiend 68e1a9cde1
AAC tablet for speech-impaired characters (#1491)
* basic AAC tablet prototype

using station map as a base

* set up aac component/system

* quick phrase prototype

will probably touch this up later

* basic example phrases

just so i have data to work with

* get AACWindow to iterate over quick phrases

* add the rest of the job phrases

* fix this one job name

* actually fix prison guard name

* buttons for aac window

* fix phrase inheritance

* add tabs to aac contaner

* fix column spacing and add button padding

* aac tablet button colors

* AAC tablet sends messages now

* add aac tablet voice sound yay

* add a 1 second cooldown between phrases

* subjects for most departments

* location phrases

* more phrases

* cleanup + sort buttons alphabetically

* fix these phrases

* even more departmental subject phrases

* common phrases

* cleanup imports

* show name of player that pressed button

* aac tablet can be used by multipel people

after all it does not rely on state changes and also multiple people can press buttons on a tablet at once

* capitalize aac

its an acronym

* you know what it is its more phrases!!!!

* SAFETY PHRASES

* last second phrases

* redundant phrase

* and one more hazard phrase for the road

* change voice of aac tablet from borg to alto

just sounds nicer

* localize ALL Phrases

i love utility scripting to automate tedious tasks

* add AAC tablet to loadout

* add AAC tablet to medfab

* tweak: use multiple parents instead of whatever this is

* add: justice department phrases

* add: time quantity phrases

* add: ores and kitchen appliance phrases

* fix: resolve duplicate phrases

* add: aac tablet sprites

* add: justice button style

* fix: misplaced this line oops

* add: justice dept locations

* remove: redundant phrase

* re-run tests

* fix: move aac tablet loadout format

* fix: use Identity instead of Name for aac tablet sender

* fix: return on send phrase if id is invalid

* fix: remove redundant line

* fix: use LocId instead of String for phrase text type

* add: new phrases bc upstream updates

* fix: newlines

* tweak: add end comments to these style comments

* fix: this phrase was broken lol

---------

Co-authored-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
2024-08-12 15:15:33 +00:00
beck-thompson f38903c5c5 Replaced some AddMarkups with AddMarkupOrThrow (#30632)
* First commit

* Silly me

* bruh
2024-08-11 14:52:54 +01:00
Mervill 929517eeed Remove uses of Component.Owner from AmbientSoundSystem (#30842)
Remove Component.Owner from AmbientSoundSystem
2024-08-11 14:50:15 +01:00
Mervill ed0ef06bea Refactor LightBehaviorSystem to remove obsolete code (#30890) 2024-08-11 14:50:04 +01:00
Ed 86e603f407 Custom burgers - FoodSequence system (#30755)
* setup foodsequence

* name generation and max layers limit

* move to nutrition

* move code to serverside

* move to appearance data

* marked fields as required

* Update foodsequence.yml

* b

* burgeers!

* Update produce.yml

* Update meat.yml

* Update burger.yml

* fix duplicate naming

* Update Resources/Locale/en-US/nutrition/components/food-sequence.ftl

Co-authored-by: Hrosts <35345601+Hrosts@users.noreply.github.com>

* merge flavor profiles

* make food trash List<>

* merge trash

* Update FoodComponent.cs

* Update FoodComponent.cs

* organs and cannabis support

---------

Co-authored-by: Hrosts <35345601+Hrosts@users.noreply.github.com>
2024-08-11 14:46:08 +01:00
Nemanja 7646e0d1d2 Cursed Mask (#29659)
* Cursed Mask

* extra expressions

* block ingestion

* mind returning

* okay fix the removal shit
2024-08-11 14:44:20 +01:00
deltanedas 4e00bc3b84 erm what the gleep 2024-08-09 20:35:02 +01:00
eoineoineoin f99e158e8b Improve Criminal Records Computer usability (#30292)
* Avoid destroying and recreating record list on every update message

* Add early-out on nullptr input

* Remove sussy null suppress

---------

Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es>
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2024-08-09 19:17:26 +01:00
metalgearsloth 070aa3cde2 Make clickable 1% nicer (#29706)
* Make vox roundstart

I believe all the issues are fixed.

* Click detection bandaid

* Make clickable 1% nicer

Still bad. Still doesn't handle multi-viewports well.
2024-08-09 19:17:26 +01:00
Simon 8fae659336 UI to edit silicon laws from admin verb (#28483)
* UI to edit silicon laws from admin verb

(peak shitcode)

* Improve UI

* Use Moderator admin flag

* Reviews
2024-08-09 19:17:06 +01:00
slarticodefast f6a850476c Add tooltips to the agent ID job icons and improve status icon prototypes (#28575)
* add tooltips to agentid job icons

* forgot to stage this

* make StatusIconPrototype abstract

* minor visual improvements

* cleanup

* use currentculture to sort job names

* review
2024-08-09 19:17:05 +01:00
Thomas 3406df7068 Create In-Guidebook Errors (#28942)
* Create in-guidebook errors

* Localize client-facing parser error

* Uncomment line

* Missed another localization string
2024-08-09 19:04:59 +01:00
nikthechampiongr 3a3715648b Implement a playerpanel (#30238)
* Basic structure for the player panel ui

* Ensure basic functionality

Player panel now receives and displays basic info

* Make whitelistcommands accept user ids

* Make PlayerPanel use GUIDs where possible

* Add functionality to most playerpanel buttons

* Implement remaining playerpanel features

* Localize everything

* Finish up

* Put command arguments in quotes

I am not sure if it's even possible to have something like a space in
them considering they are guids and usernames but sure why not

* Make playerpanel a verb

* Add Logs button to player panel

* Change Notesbutton text and make whitelistbutton a confirmtion button

* Add freeze button that does not mute the player

* Add sharedconnections counter to playerpanel

* Make the playetime format clearer

* Allow for copying of the a player's username

* Do minor cleanup

* Rearrange buttons

* Fix unfreeze button not updating

* Fix wrong localisation text

* "Fix" the same role ban counting multiple times

The way rolebans are stored is horrible.
As such if you ban someone from a departmenrt or something
role bans are individually placed for every role.
The only way I found to distinguish them is the bantime.
This is horrible but I do not want to rewrite how all the bans are
stored right now.

* Add Delete and Rejuvenate buttons to player panel

By popular demand

* Marginally improve ui

* Add logs

* review update

* Fix verb

* Fix double notes

---------

Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2024-08-09 19:04:58 +01:00
slarticodefast 8bff6691f6 remove UntrackedMapBoundUserInterface (#30752) 2024-08-09 19:04:17 +01:00
deltanedas 3613134d2e full sticky prediction (#30230)
* move all sticky stuff to shared and cleanup/grammar fix

* update imports and ref

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-08-09 19:04:17 +01:00
SlamBamActionman f39df535b2 Better DNA forensics & ReagentData (#26699)
* Added the ability for blood to track DNA using ReagentData; Forensic Scanner now accounts for solution DNA, non-DNA holders have "Unknown DNA"

* Removes touch DNA for puddles, adds DNA to vomit

* DNA now leaves traces in containers and those marked without don't show DNA on scan (except for puddles), gibbed parts have DNA

* Fix stupid metamorphic glass bug grrr

* Removed SpillableComponent since DnaSubstanceTraceComponent is used instead

* Removes data field from maps, adds DNA tracking for some missed items

* Give default value, fix missing values.

* Fixes recipe bug

* Review changes

* Make the Data list into a nullable type

* Revert map changes

* Move gibbed unknown DNA to forensicssystem
2024-08-09 19:04:17 +01:00
Vigers Ray 54e7b05748 Teleport and delete buttons in objects tab. (#28914)
* Тыкнул и нету ЦК

* review

---------

Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2024-08-09 19:03:54 +01:00
ShadowCommander 7dc986b95b Add EntityWorldTargetAction (#29819)
* Add EntityWorldTargetAction initial implementation

* Update obsolete methods

* Partially working EntityWorldTargetAction

* Fix entity selection

* Move and clean up AfterInteract

* Fix building new walls

* Readd no entity or coordinates error

* Consolidate action validation code

* Add summaries to component

---------

Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com>
2024-08-09 19:02:30 +01:00
Mervill 511b636f2b Add verbose (client predicted!) examine text to Gas Miners (#30480)
* add verbose examine text to gas miners so their behaviour can be understood

* no need for these to be properties

* use an enum instead of two booleans for the miner state

* require the gas miner to be anchored in order to not be disabled

* xmldoc

* pr feedback

* file-scope namespace

* it's to late to hide my transgressions in a rebase

* turns out the normal examine distance is totally fine for this
2024-08-09 19:01:47 +01:00
ShadowCommander d1c176a6e0 Strip drag drop test (#30754)
* Add test for drag drop to open strip menu

* Make screencoords change based on deadzone
2024-08-09 19:01:46 +01:00
ShadowCommander f6e30d3950 Dragdrop fold rollerbed (#30002)
* Deploy foldable

* Add NetworkedComponent and access to the component

* Add handled to afterinteract

* Use drop target location instead of setcoordinates

* Put back in hand after failed deploy

This prevents dropping the bed when clicking while inside a locker.

* Created BaseDeployFoldable for folding chairs, body bags, and rollerbeds

* Add dragdrop to fold rollerbed to hand
2024-08-09 18:58:54 +01:00
Nemanja aaa9f84fb1 Replace IClickAlert with events (#30728)
* Replace IAlertClick with events

* whoop

* eek!
2024-08-09 18:58:46 +01:00
Plykiya 17a24e13a5 Replace xform.WorldPosition with xformSystem method for Setting/Getting (#30029)
* GET WORLD POSITON, ROTATION

* Missing parentheses

* ui system depndency

* the issue

* Unused

* Let the function do the transform

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 18:57:59 +01:00
metalgearsloth 24bbd04a5a De-duplicate loadout gear (#30341)
* De-duplicate loadout gear

Needs supporting code, probably with an interface with StartingGearPrototype which would also use it, but I regexed the yaml.

* Code updates

* Remaining yaml

* Fix automatic naming

* raiseEvent

* Don't code when tired kids
2024-08-09 18:51:00 +01:00
Ed c051d7902c JobRequirement refactor (#30347)
* refactor JobRequirements

* add profile support

* fix

* Update quartermaster.yml

* sloth fixes

* inport 30208

* Update DepartmentPrototype.cs

* species restriction

* left tweak stick

* stringbuilder is cool!
2024-08-09 18:45:41 +01:00
Plykiya 752a49284e Move PaperSystem to Shared (#30592)
* Fix paper system late localization

* IS THIS WHAT YOU WANT

* well I guess this is happening now

* fix the BUI

* did that even do anything before?

* again with the escapeformatting...

* Dirtying

* Move dirty to function

* Rename PaperSystem to PaperVisualizerSystem

* Fix namespace

* how many namespace changes must I suffer through

* SetContent is for Setting Content

* minor shuffling

* review

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2024-08-09 18:31:41 +01:00
Plykiya f9ebd78a78 Gets rid of all leftover usages of IEyeManager.CurrentMap (#30022)
* Gets rid of all leftover usages of CurrentMap

* args works

* reverty

* skill issue

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 18:25:43 +01:00
slarticodefast 075dec6ba2 Improve communications console countdown formatting (#30495)
* improve communications console countdown formatting

* tostring
2024-08-09 18:25:43 +01:00
beck-thompson 80f591cf8e Explosion resistance is now predicted! (#30654)
* First commit

* Added Network and access
2024-08-09 18:24:58 +01:00
Plykiya c271b150dc Fix GhostRoleRadio icons (#30650)
Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 18:24:58 +01:00
slarticodefast 54fbf9c0e5 replace all uses of TryGetContainingContainer with non-obsolete overload (#30583)
* replace all uses of TryGetContainerContainer with non-obsolete overload

* rerun
2024-08-09 18:24:46 +01:00
Repo 576c4e4bba Fix Bwoink Player sorting again.... (#30580)
Keep players that have had messages in the round at the top
2024-08-09 18:19:09 +01:00
slarticodefast 6d77481303 Add haloperidol, potassium iodide (#27454)
* add haloperidol, potassium iodide

* review fixes

* review and tuning

* shader review

* use timespan and AutoPausedField
2024-08-09 18:19:08 +01:00
Tayrtahn 9ca4304f83 Add "fill levels" to spear in-hand/wielded/equipped sprites (#28865)
* Add fill level sprite support for equipped items

* Add fill sprites for held/equipped spears
2024-08-09 18:18:14 +01:00
Plykiya b020ea4a3d Update MoverController.cs to not use Component.Owner (#29965)
* Update MoverController.cs

* Update a bunch of movement code to use Entity<T>

* Last errors

* wow, there were more errors

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 18:18:02 +01:00
Brandon Hu 1b4a42c174 add(TransferAmountWindow): QoL stuff (#30464)
* ugh
2024-08-09 18:18:02 +01:00
SlamBamActionman b1a606aee8 Change from using obsolete method in ExplosionOverlay (#30550)
* Change from obsolete method in ExplosionOverlay

* Send AppearanceSystem through constructor
2024-08-09 18:17:31 +01:00
Nemanja 00fa513693 Add support for printing reagents in lathes (#30476)
* Add support for reagents in lathes

* missing locale
2024-08-09 18:17:30 +01:00
metalgearsloth 2813ed83b8 Add sprite exporting (#29874)
* Redo of code

* Dump IDs on lobby exports
2024-08-09 18:15:15 +01:00
Repo 5f07c630f0 Fix aHelp menu sorting (#30518)
* Keep Pinned status through player status changes.

* Fix filtering to be admin optimal.
2024-08-09 18:15:15 +01:00
slarticodefast 8f3d7ad8d7 Fix singularity overlay mouse position correction when zooming (#30509)
fix singularity overlay mouse position correction when zooming
2024-08-09 18:15:15 +01:00
chavonadelal a06cc4a78f Localization of the Salvage Expedition Console (#30339)
* Localization of the Salvage Expedition Console

* Localization of the Salvage Expedition Console 2
2024-08-09 18:14:53 +01:00
chavonadelal a549cc3190 Adding an AccessReader to a particle accelerator with engineering access (#30394)
Adding an AccessReader to a particle accelerator
2024-08-09 18:14:52 +01:00
Repo fd69799cec aHelp fixes and improvements (#28639)
* Clear search criteria on loading aHelp window

* Pinning technology.

* Relay to aHelp window and discord if a user disconnect/reconnect

* Fix pinning localization

* Log disconnect, reconnects, bans to relay and admin in aHelp

* Drop to 5min to hold active conversations

* Update Content.Server/Administration/Systems/BwoinkSystem.cs

Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>

* discord text styling if diconnect,reconnect,banned message.

* Pin icons instead of text

* Better Icons

* space

* Move button generation in to its own XAML

* List entry control

* Fix spaces

* Remove from active conversations on banned

* Discord if else block cleanup

* Better pin icons

* Move icons to stylesheet styleclass

* Better field order.

* PR review fixes

* fixes

---------

Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2024-08-09 18:14:52 +01:00
Nemanja 1dd6a00618 fix lathe screen animations (#30479) 2024-08-09 18:12:53 +01:00
themias 6c88090d18 Add envelopes (#30298)
* Add envelopes

* oops

* Remove unused loc string

* comments and fixes
2024-08-09 18:12:36 +01:00
Mervill 28acafaaef Make the powered examine text fully client predicted (#30441)
* Make the powered examine text fully client predicted

* switch to using the Entity<T> API for the examine event
2024-08-09 18:12:12 +01:00
themias b75173194d Fix arcade machines (#30376) 2024-08-09 18:08:24 +01:00
Errant 4f080a379e Replayspawn logic fix (yes, again) (#30273)
* Fix replayghost spawn

* missed a spot
2024-08-09 18:08:09 +01:00
themias a25942a8e5 Fix Ripley control panel (#30325) 2024-08-09 18:03:34 +01:00
Ed 7a94d756b9 Displacement maps big update (#30093)
* split logic into own system

* add support for different size displacement maps

* some clothes may not use displacement maps

* displacement maps spport hand sprites

* Update DisplacementMapSystem.cs

* rename things

* fuck stencilmask

* fix bugs

* no masks

* Update jumpsuits.yml

* fix species specific sprites

* Update ClothingSystem.cs

* shoes + ears displacement, some bugfix

* Update DisplacementMapSystem.cs
2024-08-09 17:58:39 +01:00
Plykiya be5dbe0cd8 fix crayon (#30263)
Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 17:55:40 +01:00
Errant 820935fd85 Fix replayghost spawning location (#30252)
Fix replayghost spawn
2024-08-09 17:54:45 +01:00
Plykiya a1d6e04731 Syndicate Reinforcement Specializations: Medic, Spy, Thief (#29853)
* Syndicate thief, spy, medic

* Fixes description for nukies

* update description for uplink

* Implement the radial menu

* forgot these were necessary to push lol

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 17:53:32 +01:00
metalgearsloth 8d9801545f Fix war declarator (#30221) 2024-08-09 17:52:23 +01:00
metalgearsloth 17590a75e1 Reset ghost role menu scroll upon search (#30159)
Quality of life so it doesn't sit on your old spot anymore.
2024-08-09 17:52:22 +01:00
metalgearsloth 037230f731 Set input coords to invalid if mouse off-screen (#30164)
This may be a breaking change for some stuff, I only tested basic combat stuff + throwing.

This fixes the coordinates setting an off-screen position to the top-left pixel and blocks throw attempts as a result.
2024-08-09 17:52:22 +01:00
metalgearsloth ebdf080e08 Fix muzzle flash tracking (#30163)
* Fix muzzle flash tracking

User was never set on the networked event but we don't really need it anyway.

* Also this one
2024-08-09 17:52:22 +01:00
Crude Oil b8af5b195c Add ability to show stack visuals on closed containers (#29309)
* add ability to show stack visuals on closed containers

* remove container stack visuals logic from sharedstoragesystem

* improve comments a bit

* move logic for open/closed containers into itemcountersystem

* move behavior to storage component

* remove unused import

* remove old comment

* fix comments

* fix wrong property name

* Update Content.Shared/Storage/EntitySystems/SharedStorageSystem.cs

* Rename variable for clarity

---------

Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
2024-08-09 17:52:22 +01:00
Nemanja 055169e12e PA ui cleanup + bugfixes (#28750)
* ui and visual aspect + radio

* finish jank ui shit and finish radio

* remove radio

* send it

---------

Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2024-08-09 17:52:22 +01:00
metalgearsloth 87a4203267 Reapply "Remove some BUI boilerplate" (#30214) (#30219)
* Reapply "Remove some BUI boilerplate" (#30214)

This reverts commit cb0ba66be38677d248ce11f809221230ebe89642.

* Fix gas tank

* Fix PA

* Fix microwave

* Comms console underwrap

* Fix rcd

* log wehs
2024-08-09 17:52:22 +01:00
Nemanja ac0a73c039 Revert "Remove some BUI boilerplate" (#30214)
Revert "Remove some BUI boilerplate (#28399)"

This reverts commit cbf329a82d77eed2bb5e51666dab5d8a21fd3fff.
2024-08-09 17:52:21 +01:00
metalgearsloth 7af5d3dbaf Remove some BUI boilerplate (#28399)
* Remove some BUI boilerplate

- The disposals overrides got removed due to the helper method handling it.
- Replace window creation with CreateWindow helper.
- Fixed some stinky code which would cause exceptions.

* More

* moar

* weh

* done

* More BUIs

* More updates

* weh

* moar

* look who it is

* weh

* merge

* weh

* fixes
2024-08-09 17:51:47 +01:00
eoineoineoin f1d1416a13 Add a background for OptionsButton popup (#29792)
Add a reasonable background for OptionsButton popup

Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es>
Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
2024-08-09 17:51:30 +01:00
CaasGit ad3dec7a3d fix(FaxVisualsSystem): Fax can Play() when a anim key has been added. (#30013)
Adds a check to see if a faxecute animation is being played before
playing another animation. The old code can thrown an exception which
I've seen on live while ghosting.
2024-08-09 17:51:30 +01:00
DrSmugleaf 6521c91ae9 Make ActionsSystem.UpdateAction public (#30056) 2024-08-09 17:51:29 +01:00
themias 3706f265a8 Fix mailing unit UI (#30174) 2024-08-09 17:51:14 +01:00
DakotaGay d32ccbf26d Fix Markup Tags in Station News (#30169)
* Fix (hopefully)

* Fixed Spelling Mistake and minor Code Cleanup

* Revert "Fixed Spelling Mistake and minor Code Cleanup" due to Pull Request Guidelines

This reverts commit cee3e0226b349187bd8fd8b639e161fb877e8bdb.
2024-08-09 17:51:14 +01:00
Ed e401ccff85 randomize iconSmoothing (#28158)
* randomize iconSmoothing

* Revert "randomize iconSmoothing"

This reverts commit 094356f975737c0af24ce39d849aec7852b9af6e.

* try 2

* trying work with client-server communication

* still dont work

* Tayrtahn good suggestion

* remove outdated code

* Fix!

* move data to Appearance

* Update RandomIconSmoothComponent.cs
2024-08-09 17:51:14 +01:00
Cojoke 4b43756e66 Remove all Assigned Values that are Never Used (#30110)
Remove all Assigned Values that are never used
2024-08-09 17:50:58 +01:00
Ed 42344fa536 Character menu issuer localization (#29840)
* Update CharacterUIController.cs

* TODO Burn this shit

* huh?

* huh!

---------

Co-authored-by: lzk <124214523+lzk228@users.noreply.github.com>
2024-08-09 17:50:12 +01:00
Simon d4b81acbfe Fix some markup related obsolete warnings in research and anomaly related systems (#30072)
Fix some Markup related obsolete warnings in Research and Anomaly related systems
2024-08-09 17:47:51 +01:00
Pieter-Jan Briers 8f95604f05 Fix invalid UI hover/click sounds breaking client (#30067)
fixes #29561
2024-08-09 17:47:51 +01:00
Pieter-Jan Briers 401379ee3a Fix AccessLevelControl breaking (#30045)
#29987 did an oopsie

This broke the ID computer, station records, and maybe some others too.
2024-08-09 17:47:50 +01:00
Ed cf7668f957 Ambient music rules refactor (#29921)
* refactor

* dutypo
2024-08-09 17:47:28 +01:00
Winkarst ce252a52ad Update AccessLevelControl.xaml.cs to use ISawmill (#29987)
* Update AccessLevelControl.xaml.cs to use ISawmill

* Update

* Silly me

* Update
2024-08-09 17:47:28 +01:00
Winkarst d545d4f108 Update MainMenu.cs to use ISawmill (#29988)
* Update MainMenu.cs to use ISawmill

* Update

* Error
2024-08-09 17:47:28 +01:00
Plykiya 1f8b8180e5 Replace obsolete EntityCoordiates.InRange() with TransformSystem.InRange() (#29993)
* Replace EntityCoordiates.InRange() with TransformSystem.InRange()

* nullspace

* I figured it out

* man I have no clue how client side sutff works

* please have mercy

* remove RadiationPulseOverlay changes

* nullspace

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 17:47:22 +01:00
Plykiya ae0a69d769 Replace obsolete xform.ToMap() with xformSystem.ToMapCoordinates() (#30010)
* Get rid of a bunch of obsolete usages

* position

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 17:47:21 +01:00
Winkarst 00e712129e Update RadiationPulseOverlay.cs to have 0 warnings (#30004) 2024-08-09 17:46:31 +01:00
Plykiya 4dd3fa17e9 Replace DetachParentToNull() with DetachEntity() (#29992)
DETACH PARENT TO ENTITY

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 17:45:45 +01:00
CaasGit a97f4ac9fd fix(SharedGunSystem): Return and debug log on CreateEffect. (#29656)
Sometimes CreateEffect is called on a Invalid Entity. This now causes
that to check, thus returning out and printing some hopefully helpful
logs to try to track down the real source of this issue.
2024-08-09 17:45:45 +01:00
slarticodefast 0b11619df3 Remove imagesharp and StatusEffectAddedEvent from FlashOverlay (#28930)
remove imagesharp and StatusEffectAddedEvent from FlashOverlay
2024-08-09 17:45:45 +01:00
Nemanja a319fca68a Watches (#29550)
* watches

* rename

* add it into loot pools
2024-08-09 17:45:45 +01:00
deltanedas aa043d43eb fire extinguisher using item toggle (#29906)
* move SprayAttemptEvent to shared

* add SolutionTransferredEvent

* replace FireExtinguisher with SpraySafety

* update fire extinguisher yml

* invert visuals

* always handle event in solution transfer, it makes popups

* instantly fill it

* untroll

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-08-09 17:45:39 +01:00
Winkarst 53b057b8c7 Update ActionAlertTooltip.cs to use TryFromMarkup (#29975) 2024-08-09 17:45:38 +01:00
Plykiya b0829df086 Update ShuttleDockControl.xaml.cs to not use Component.Owner (#29966)
Update ShuttleDockControl.xaml.cs

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 17:45:38 +01:00
Plykiya 2d62ad7d42 Update MapScreen.xaml.cs to not use Component.Owner (#29938)
Update MapScreen.xaml.cs

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 17:45:36 +01:00
Winkarst-cpu 72a80e7fbf Better admin note popups text visibility (#29909)
* Better admin note popup text visibility

* Bring buttons closer to the border
2024-08-09 17:45:29 +01:00
deltanedas d3aa1efc38 item toggling giga rework + full ninja refactor (#28039)
* item toggle refactoring and some new systems

* add ToggleClothing component/system

* unhardcode magboots gravity logic

* make magboots and speedboots use ItemToggle and stuff

* remove now useless clothing components

* update client/server magboots systems

* add note to use ItemToggledEvent in ToggleActionEvent doc

* refactor PowerCellDraw to use ItemToggle for ui open/close control

* add TryUseCharges, refactor charges system

* update magboot trigger code

* make borg use ItemToggle, network SelectedModule instead of now removed Activated

* add AccessToggle for borg

* the giga ninja refactor

* update ninja yml

* update ItemToggle usage for some stuff

* fix activatableui requires power

* random fixing

* yaml fixing

* nuke ItemToggleDisarmMalus

* make defib use ItemToggle

* make things that use power not turn on if missing use charge

* pro

* fix sound prediction

* bruh

* proximity detector use ItemToggle

* oop

* big idiot syndrome

* fix ninja spawn rule and make it generic

* fix ninja spawn rule yml

* move loading profiles into AntagLoadProfileRule

* more ninja refactor

* ninja yml fixes

* the dreaded copy paste ops

* remove useless NinjaRuleComponent and ue AntagSelection for greeting

* fix invisibility

* move IsCompleted to SharedObjectivesSystem

* ability fixes

* oop fix powercell instantly draining itself

* sentient speedboots gaming

* make reflect use ItemToggle

* fix other test

* loadprofilerule moved into its own pr

* remove conflict with dragon refactor

* remove all GenericAntag code from ninja

* )

* probably

* remove old enabled

* great language bravo vince

* GREAT LANGUAGE

* who made this language

* because it stinks

* reparent blood-red magboots to magboots probbbly works

* most of the review stuff

* hasGrav doesnt mean what i thought it did

* make health analyzer use itemtoggle, not fail test

* fix mag/speed boots being wacky

* UNTROLL

* add ItemToggle to the random health analyzers

* a

* remove unused obsolete borg func

* untrolling

* :trollface:

* fix test

* fix

* g

* untroll

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-08-09 17:45:27 +01:00
Chief-Engineer 366cea3352 Fix baby jail (#29896)
* Revert "Revert Baby Jail (#29891)"

This reverts commit 24a2866747e6de37ab2c4395bee9ea44c9211c6f.

* the fix
2024-08-09 17:39:18 +01:00
Vasilis b0edb5ccf0 Revert Baby Jail (#29891)
* Revert "SS14-28662 Add Baby Jail: a Jail for Babies (inverse panic bunker) (#28763)"

This reverts commit 3ceb92a0c43d3815d65c8124cd6bea3be5140455.

* Revert configs

* Oops
2024-08-09 17:38:45 +01:00
Winkarst-cpu db596793c1 Character menu asks if you want to save your character on exit (#29875)
* Character menu asks if you want to save your character on exit

* Fix

* Another fix, little mistake by me

* Update Content.Client/Lobby/UI/CharacterSetupGuiSavePanel.xaml.cs

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
2024-08-09 17:38:31 +01:00
beck-thompson fdf502c929 Fix typing indicators! (#29492)
* First commit

* Removed pause stuff

* Make the event better

* Forgot to add the comment

* Proto id stuff

* cool comments

* serializer

* Added the time stuff
2024-08-09 17:38:28 +01:00
dffdff2423 e63d2a2ac6 Add an option to the admin fax menu to lock papers such that they can't be edited by cybersun pens (#28972)
* Add option to adminfax for locking papers.

* Replace dummy control with margin
2024-08-09 17:38:28 +01:00
chavonadelal dd3e88d440 Action menu localization (#29839) 2024-08-09 17:38:03 +01:00
chavonadelal 1f0d608fcd localization and change of appearance of the phrase about the remaining time (#29844) 2024-08-09 17:38:03 +01:00
slarticodefast f84b23cd38 Improve throwing precision (#29726)
* improve throwing precision

* remove debugging logs

* minor fixes

* f

* Update Content.Shared/Throwing/LandAtCursorComponent.cs

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
2024-08-09 17:35:24 +01:00
Nemanja 8295d43319 Intercom buffs and fixes (#29580)
* Intercom buffs and fixes

* remove unused bui state

* mild sec intercom buff

* reinforce sec intercoms
2024-08-09 17:33:56 +01:00