Commit Graph

4133 Commits

Author SHA1 Message Date
Plykiya 4dd3fa17e9 Replace DetachParentToNull() with DetachEntity() (#29992)
DETACH PARENT TO ENTITY

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 17:45:45 +01:00
CaasGit a97f4ac9fd fix(SharedGunSystem): Return and debug log on CreateEffect. (#29656)
Sometimes CreateEffect is called on a Invalid Entity. This now causes
that to check, thus returning out and printing some hopefully helpful
logs to try to track down the real source of this issue.
2024-08-09 17:45:45 +01:00
slarticodefast 0b11619df3 Remove imagesharp and StatusEffectAddedEvent from FlashOverlay (#28930)
remove imagesharp and StatusEffectAddedEvent from FlashOverlay
2024-08-09 17:45:45 +01:00
Nemanja a319fca68a Watches (#29550)
* watches

* rename

* add it into loot pools
2024-08-09 17:45:45 +01:00
deltanedas aa043d43eb fire extinguisher using item toggle (#29906)
* move SprayAttemptEvent to shared

* add SolutionTransferredEvent

* replace FireExtinguisher with SpraySafety

* update fire extinguisher yml

* invert visuals

* always handle event in solution transfer, it makes popups

* instantly fill it

* untroll

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-08-09 17:45:39 +01:00
Winkarst 53b057b8c7 Update ActionAlertTooltip.cs to use TryFromMarkup (#29975) 2024-08-09 17:45:38 +01:00
Plykiya b0829df086 Update ShuttleDockControl.xaml.cs to not use Component.Owner (#29966)
Update ShuttleDockControl.xaml.cs

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 17:45:38 +01:00
Plykiya 2d62ad7d42 Update MapScreen.xaml.cs to not use Component.Owner (#29938)
Update MapScreen.xaml.cs

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 17:45:36 +01:00
Winkarst-cpu 72a80e7fbf Better admin note popups text visibility (#29909)
* Better admin note popup text visibility

* Bring buttons closer to the border
2024-08-09 17:45:29 +01:00
deltanedas d3aa1efc38 item toggling giga rework + full ninja refactor (#28039)
* item toggle refactoring and some new systems

* add ToggleClothing component/system

* unhardcode magboots gravity logic

* make magboots and speedboots use ItemToggle and stuff

* remove now useless clothing components

* update client/server magboots systems

* add note to use ItemToggledEvent in ToggleActionEvent doc

* refactor PowerCellDraw to use ItemToggle for ui open/close control

* add TryUseCharges, refactor charges system

* update magboot trigger code

* make borg use ItemToggle, network SelectedModule instead of now removed Activated

* add AccessToggle for borg

* the giga ninja refactor

* update ninja yml

* update ItemToggle usage for some stuff

* fix activatableui requires power

* random fixing

* yaml fixing

* nuke ItemToggleDisarmMalus

* make defib use ItemToggle

* make things that use power not turn on if missing use charge

* pro

* fix sound prediction

* bruh

* proximity detector use ItemToggle

* oop

* big idiot syndrome

* fix ninja spawn rule and make it generic

* fix ninja spawn rule yml

* move loading profiles into AntagLoadProfileRule

* more ninja refactor

* ninja yml fixes

* the dreaded copy paste ops

* remove useless NinjaRuleComponent and ue AntagSelection for greeting

* fix invisibility

* move IsCompleted to SharedObjectivesSystem

* ability fixes

* oop fix powercell instantly draining itself

* sentient speedboots gaming

* make reflect use ItemToggle

* fix other test

* loadprofilerule moved into its own pr

* remove conflict with dragon refactor

* remove all GenericAntag code from ninja

* )

* probably

* remove old enabled

* great language bravo vince

* GREAT LANGUAGE

* who made this language

* because it stinks

* reparent blood-red magboots to magboots probbbly works

* most of the review stuff

* hasGrav doesnt mean what i thought it did

* make health analyzer use itemtoggle, not fail test

* fix mag/speed boots being wacky

* UNTROLL

* add ItemToggle to the random health analyzers

* a

* remove unused obsolete borg func

* untrolling

* :trollface:

* fix test

* fix

* g

* untroll

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-08-09 17:45:27 +01:00
Chief-Engineer 366cea3352 Fix baby jail (#29896)
* Revert "Revert Baby Jail (#29891)"

This reverts commit 24a2866747e6de37ab2c4395bee9ea44c9211c6f.

* the fix
2024-08-09 17:39:18 +01:00
Vasilis b0edb5ccf0 Revert Baby Jail (#29891)
* Revert "SS14-28662 Add Baby Jail: a Jail for Babies (inverse panic bunker) (#28763)"

This reverts commit 3ceb92a0c43d3815d65c8124cd6bea3be5140455.

* Revert configs

* Oops
2024-08-09 17:38:45 +01:00
Winkarst-cpu db596793c1 Character menu asks if you want to save your character on exit (#29875)
* Character menu asks if you want to save your character on exit

* Fix

* Another fix, little mistake by me

* Update Content.Client/Lobby/UI/CharacterSetupGuiSavePanel.xaml.cs

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
2024-08-09 17:38:31 +01:00
beck-thompson fdf502c929 Fix typing indicators! (#29492)
* First commit

* Removed pause stuff

* Make the event better

* Forgot to add the comment

* Proto id stuff

* cool comments

* serializer

* Added the time stuff
2024-08-09 17:38:28 +01:00
dffdff2423 e63d2a2ac6 Add an option to the admin fax menu to lock papers such that they can't be edited by cybersun pens (#28972)
* Add option to adminfax for locking papers.

* Replace dummy control with margin
2024-08-09 17:38:28 +01:00
chavonadelal dd3e88d440 Action menu localization (#29839) 2024-08-09 17:38:03 +01:00
chavonadelal 1f0d608fcd localization and change of appearance of the phrase about the remaining time (#29844) 2024-08-09 17:38:03 +01:00
slarticodefast f84b23cd38 Improve throwing precision (#29726)
* improve throwing precision

* remove debugging logs

* minor fixes

* f

* Update Content.Shared/Throwing/LandAtCursorComponent.cs

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
2024-08-09 17:35:24 +01:00
Nemanja 8295d43319 Intercom buffs and fixes (#29580)
* Intercom buffs and fixes

* remove unused bui state

* mild sec intercom buff

* reinforce sec intercoms
2024-08-09 17:33:56 +01:00
metalgearsloth d512cd08a3 Shuttle map button tweaks (#29757)
- Avoids adding pending objects we can never show so the list should fill much faster.
2024-08-09 17:31:51 +01:00
DrSmugleaf 5232a19afd Fix showing the inventory button on entities without any inventory slots (#29728) 2024-08-09 17:31:25 +01:00
Pieter-Jan Briers 6b488b1c31 Fix animation looping bugs. (#29457)
Summary of the problem is in the corresponding engine commit: a4ea5a4620

This commit requires engine master right now.

I think #29144 is probably the most severe one, but I touched Jittering and RotatingLight too since they seemed sus too.

Fixes #29144

Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2024-08-09 17:30:59 +01:00
metalgearsloth 1de9dfcea8 Make vox roundstart (#29704)
* Make vox roundstart

I believe all the issues are fixed.

* Click detection bandaid
2024-08-09 17:30:58 +01:00
Rinary 500590142a Dynamic Radial Menus (#29678)
* fix

* Clean Some Code

* Some Commentaries

* Update Content.Client/UserInterface/Controls/RadialContainer.cs

* Update Content.Client/UserInterface/Controls/RadialContainer.cs

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
2024-08-09 17:27:14 +01:00
Leon Friedrich 3934fb9603 Allow `zoom` command to modify an eye's PVS range (#29245)
Allow zoom command to modify an eye's PVS range

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
2024-08-09 17:26:40 +01:00
slarticodefast 52dfa736b1 Fix MouseRotator on rotated grids (#29663)
* fix harm mode rotation

* cleanup

* -pi to pi
2024-08-09 17:19:01 +01:00
Tayrtahn 2b7305875f Fixed buckled players thrashing while speaking in beds (#29653)
* Fix characters thrashing when talking while lying down

* Remove weird design choice
2024-08-09 17:19:00 +01:00
jmcb 527f8bc709 Fix showing tips on the login screen from the localized tip dataset (#29640)
Regression introduced in #28285
2024-08-09 17:19:00 +01:00
metalgearsloth 221b8ae475 Add FTL arrival visuals (#29402)
* Add FTL arrival visuals

* weh

* Update Content.Shared/Shuttles/Components/FTLComponent.cs

Co-authored-by: Tayrtahn <tayrtahn@gmail.com>

---------

Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
2024-08-09 17:19:00 +01:00
Null f19310b268
Merge pull request #1533 from NullWanderer/2024/07/05-upstream-merge
Finally, the big merge
2024-07-25 03:17:57 +02:00
Nemanja 1bb89bdca5
Selectable Bar Signs (#29068)
* make bar sign selectable

* ajcm strongest soldier

* AJCM comes down hard for round 2

* good shit

* ok ballin

* bless'ed be the webedit
2024-07-25 01:57:58 +02:00
Partmedia cb8ec5e9db
Auto-scale sensor monitoring graph (#29559) 2024-07-25 01:57:45 +02:00
Plykiya 3801c6035c
Fixes colored gloves appearing incorrectly in chameleon menu (#29607)
Co-authored-by: plykiya <plykiya@protonmail.com>
2024-07-25 01:55:40 +02:00
metalgearsloth 3030323eae
Ensure trait groups get validated (#28730)
* Ensure trait groups get validated

The only validation being done was on the UI. I also made the "Default" group match the PascalCase naming schema so might be a slight breaking change but the original PR only got merged a few days ago.

* overwatch
2024-07-25 01:55:01 +02:00
Artjom 2576a556a5
Favorites tab for the construction menu (#26347)
* Added fovarite button

* Some fixes in xaml

* added some events for favorite recipes

* set methods for presenter

* fixes for  presenter

* added translates

* reset seach when you select any category

* added some margins

* some fixes from compared

* fixed PR notes about arrays

* deleted controls & margins

* did simpleer with arrays

* review

---------

Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2024-07-25 01:54:21 +02:00
metalgearsloth 4e6eee2de6
Predict typing indicator (#29551)
It greatly annoys me in the rare instance I do play.
2024-07-25 01:53:55 +02:00
Plykiya 63e7fcfe51
Fixes Chameleon menu icons appearing incorrectly (#29539)
EntityPrototypeView my beloved

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-07-25 01:53:10 +02:00
Plykiya f92114b814
Hide doafters if you're in a container (#29487)
* Hide doafters if you're in a container

* Out of the loop

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-07-25 01:51:52 +02:00
Repo 17c58d62de
Fix Admin Object tab sorting and search - Part 2 (#28681)
* admin Object tab sorting and searchable

* Fix for showing disconnected players on player admin tab

* Fix namespace and search bar location.

* Change linq to loop.

* No more Linq to sort

* Fix item click vv menu

* Added refresh button and refresh on opening tab.

* Clear spaces.

* Move tab magic numbers to enums

* Get rid of old unused xaml

* Fix code style issues and button event type.

* Merge in baby jail

* More style cleanup and move cast around.

* Make the localization a little more easy to read, same loc var names.

* Missed Loc for label

* Fix class field order

* Over zelous delete.

* Small updates.

* Min syntax issues fix
2024-07-25 01:51:49 +02:00
Pieter-Jan Briers 797ff40916
Fix coords monitor in replays (#29512)
The F3 coords manager is blocked if you're not an admin. This check happened even when playing a replay, where you actually aren't. There's now a check to make sure you are actually server-connected-to-game before running the logic.

Also moved it to a manager because this *shouldn't be a bloody entity system in the first place*.
2024-07-25 01:51:28 +02:00
Plykiya 6a59326d1e
Fixes magic mirror interactions (#29491)
* Fix for magic mirror interaction

* Works for all cases

* swap the order, works

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-07-25 01:50:46 +02:00
DrSmugleaf 914f397035
Fix storages bugging out if an open storage has its component removed (#29485)
* Fix storages bugging out if an open storage has its component removed

* Fix error on close
2024-07-25 01:50:40 +02:00
DrSmugleaf bc6a4f6de8
Attempt to fix random test fail by undeleted AlertControl._spriteViewEntity (#29424) 2024-07-25 01:47:01 +02:00
Pieter-Jan Briers 3a095a2ac5
Hotfix examine (#29408)
#55328 was failing tests and shouldn't have been merged, it broke examine.

The problem is that for some reason, client-side examine system doesn't call base Initialize. So my entity query change (that I did not test) broke.

By the way, this same "not calling base" meant that group examine system wasn't predicting properly when it totally could've. Incredible.
2024-07-25 01:45:29 +02:00
Tayrtahn aff298aac7
Fix unlabeled jugs in ChemVend (#29178)
* Spawn dummy entities on client for vending machine UI

* Asked sloth, and we kinda need this pr

---------

Co-authored-by: Vasilis <vasilis@pikachu.systems>
2024-07-25 01:45:05 +02:00
MetalSage e09b169e22
Admin UI localization (#29340)
admin ui localization

Co-authored-by: MetalSage <metalsage.official@gmail.com>
2024-07-25 01:39:13 +02:00
Nemanja e057218952
Machine-code cleanup (#28489) 2024-07-25 01:11:54 +02:00
Pieter-Jan Briers e92d9031b3
Rewrite the options menu (#28389) 2024-07-25 00:56:15 +02:00
IProduceWidgets 2af0efe196
add a type specifier where one was forgor (#29250)
* add a type specifier where one was forgor

* Fix other way because degub conditions

* okay this feels kinda dumb but it does fix it.

* Update Content.Client/Effects/ColorFlashEffectSystem.cs

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
2024-07-25 00:35:13 +02:00
metalgearsloth f0d83c1cb1
Fix entities getting stuck red (#28981) 2024-07-25 00:35:03 +02:00