* Sending a mob out of a disposals unit shouldn't push them into a wall anymore.
* Something something resolves vs. OnRemove fighting it out
* Disposals yeet reduction: Address reviews and other oddities
* Transfer most Instrument UI logic to a new component, ActivatableUIComponent
* Move more ActivatableUIComponent stuff to ECS
* ActivatableUI component ignore on client
* ActivatableUI: Get rid of component interfaces where possible
* Add in adminOnly attribute for activatable UIs
This is so that porting #4926 to this will be easier
* Transition Solar Control Computer to ActivatableUI
* Move communications console to ActivatableUI
* Move cargo console to ActivatableUI
* Move ID card console to ActivatableUI
* ActivatableUI: Make things more amiable to entity tests adding components weirdly
* ActivatableUI: Use handling or lack thereof of events properly
* ActivatableUI: component dependency issue resolution stuffs
* ActivatableUISystem: Fix#5258
* More fixes because master did stuffo
* Check for HandDeselectedEvent again because otherwise active-hand check doesn't work
* Move just a bit more code into the system, introduce a workaround for #5258
* Purge the player status detection stuff
* Oh and some obsolete stuff too
* Add a way to disable voting for maximum authoritarianism
* Allow disabling specific vote types via cvars
* Migrate standard-vote-to-cvar dictionary to being static
* PackedStation: Add lots of rubbish markers, add some traitor deathmatch PDA redemption machine markers, name northern solars warp point
* Some additional changes @TimrodDX asked for: Nudge a light back into place and un-drain some tanks
* Ghost roles now get new Minds
* Some round start/end button stuff
* Mind tracking for better round end reports
* Make traitor kill objectives use mind CharacterName rather than actual occupied entity ("kill brain" prevention)
* Transition over to EntityUid for mind stuff because that's the only way to do it
* BrainSystem fix for PR rebase
* Add "Syndicate Puddle-Jumper" blueprint for admins to spawn in
Serves as a way to let admins cause nukies.
* Unit test to make sure that maps remain loadable
* Pulling: Piano door stuck prevention (pulling angle-snap) and getting rid of a condition causing oddities with pull-to-location
* Pulling: Implement Newton's Third Law in regards to puller/pullee physics
Weightless condition was determined not to be necessary
* Fix pull-to-position on actively rotating/moving grids + fixes for rebase
* Stop pAIs from being able to wipe each other/do other odd things they shouldn't
* pAI: device changes name to indicate owner
* Make PAIComponent networked (just in case)
It'll be needed in future anyway
* AMEPartComponent: Switch to ToolSystem.HasQuality because this bugs me.
* Multitool can read power when you examine a cable with the multitool held.
* Multitool power reading: Condense storage information
* power-sensing multitool: Fix ToolSystem ref.
* Power-reading multitools: Fix misuse of GetComponent
* drain all batteries / drain battery command for saner eventing
* Reverts the part of the previous commit where drainallbatteries skips items, despite my better judgement
* setbatterypercent now takes the place of battery drainage commands
A more forall-oriented approach
* Some sanity checks on disposals movement, fix the interpolator
* Technically fix disposal routing, but I'm not done here yet
* Remove disposals reliance on implicit direction sensing entirely.
* Fix APC placement type
* Fix wall tags.
* Change wall light placement to match how it actually is now
* Change spawn-entity wall light snap mode
Separate commit so it can be nixed out for JREV
* Default switch placement mode to SnapgridCenter
One of these was going to have to be folded into the other for it to work.
I am starting to really hate this refactor.
Note that this might still leave smokable tampering broken if it was already broken, but it shouldn't break it if it wasn't.
TESTED: Grown apples, carrots, something I forgot, bananas, *client crash due to slipping*
* Graft from https://github.com/space-wizards/space-station-14/pull/3049
* 'openahelp' command
* Add AHelp into escape menu
* Add a way to ahelp a player from the kick window
* bwoink: XAMLify, bugfix, etc.
* Rename the kick/bwoink window the Player Actions Panel
* Add the bwoink sound y'all know and love
adminhelp.ogg taken from https://github.com/tgstation/tgstation/blob/d775e1ac804eb9d0259573f5f29a18d320c97ef3/sound/effects/adminhelp.ogg
(available in master, therefore see master license: "All assets including icons and sound are under a Creative Commons 3.0 BY-SA license unless otherwise indicated.")
"Changed the adminhelpsound to some creative commons sound I pinched. Until somebody can get a better one. I'm sick of MAAAAAAAAOOOOOOW."
Actual source is https://freesound.org/people/martian/sounds/19261/ (CC0)
The sound had been reversed and the volume altered.
* Actually play the bwoink sound on receiving an ahelp that you didn't send
* Migrate lots of pulling logic out of the components and clean it up
* It's buggy, but move more code out of the pullable component
* Pulling system now throws less errors than it did before the refactor
* Finally finish the big parts of refactoring pullability
* Pulling: Handle disconnect properly if the pull joint has been removed by physics shutdown
* Port 2b68449328 to this branch
* Changes as per PR reviews
* Port e801ffac45 (SharedJointSystem) and fix issues encountered during testing
SharedJointSystem.
Also, MinLength and Stiffness appear to have suddenly gained enough meaning that pulling is broken unless they're set.
* Update UI when the AME node group is changed (fixes core count indicator being wrong)
* Fix connection issues between AME controller and cores
* Fix#4365 by properly propagating and clearing AME core injection state
* Fixes#4364
* Transform the Cloning Pod visualizer into a generic enum visualizer for simple cases like it
...I find it helpful at times like these to remind myself that our true enemy is
code. Code is what makes our programs run and generally is required for all of
these machinations to function in any way at all...
* Give the kitchen/meat spike a visualizer
* GenericEnumVisualizer: Byteify enums, switch to TryGetComponent for sprite
* Migrate cuffing to an uncuff attempt event and allow self-uncuff again
* Uncuff attempt event: Use more SubscribeLocalEvent and Dependency attributes
* Fix syringe message stating you're attempting to draw from yourself when you aren't
* Fix various missing capabilities (syringes, beakers, drinks)
* And fix mug inject/dispense/etc, too!
* Injectors can now refill things, and switch over drinks and cups thereof to be refillable rather than injectable
* Refactor/fix client-side of solar control computer (introduce ComputerBoundUserInterface & fix bugs)
* Refactor server side of solar control computer (introduce BaseComputerUserInterfaceComponent)
* If you can't interact, then messages to computers are blocked.
* Add 'not powered' messages, migrate activation logic partially to an EntitySystem
* Move solar control console to a XAML UI
* Remove useless comment on UserInterfaceKey
* BaseComputerUserInterfaceComponent: Remove EnsureComponent<PowerReceiver>, it's not necessary
* Fix solar panel occlusion check direction
* Solar Control Console refactors/etc. : Handle namespace renames
* Hopefully make singularity shader warping resolution-invariant
This may or may not fix intensity issues
* Fix singularity 'zero velocity' check
It got stuck in a corner. Twice. I really thought I'd fixed that.
* Make it easier to move around various power stuff by shrinking their AABBs a little and making singulo generator a circle
* Changes to some machine prototypes to reduce duplication of collision changes (#1)
* Changes to some machine prototypes to reduce duplication of collision changes
* BaseMachine.BaseMachineUnpowered -> BaseMachine.BaseMachinePowered
* Add GNU Octave script for tuning singularity engine. startsingularityengine is now properly tuned & sets up radiation collectors. FTLize RadiationCollectorComponent.
* Fix bugs with radiation collectors producing infinite power.
* Ensure singularities don't instantly annihilate other singularities (causing new singularities to instantly dissolve)
Technically found by a "bug" where a singularity generator would make multiple singularities, but this renders that bug harmless.
* Tune singularity shield emitters to hopefully randomly fail less, and add an Octave script for looking into that
* Fix singularity shader
* Map in an unfinished PA into Saltern
* Correct PA particles being counted twice by singularity calculations, add singulo food component
* Hopefully stop "level 1 singulo stuck in a corner" issues by freezing it when it goes to level 1 from any other level
* Apply suggestions on 'jazz' PR
* Make barstools, PA components, and radiation collectors rotatable.
Making barstools rotatable is so that people can spin on the barstool. (RP moment.)
The other two are more "functional" changes for assembling a PA.
* Allow rotating a rotate-while-anchored object if you're buckled to it.
Barstool spinny
* Fix bug with rotation of an object that someone is buckled to
* BuckleSystem: Efficiency improvements with directed events
* Don't need to unsubscribe anymore from events, so in BuckleSystem, just don't
20kdc
