Commit Graph

3399 Commits

Author SHA1 Message Date
Leon Friedrich 896f80831b
Meteor Fix (#5717) 2021-12-09 16:34:38 +01:00
Vera Aguilera Puerto cd1b5f44e8 EntityStringRepresentation in logs correctly parse the EntityUid and player 2021-12-09 16:26:16 +01:00
Vera Aguilera Puerto c680d5b201
EntityStringRepresentationConverter for admin logs. (#5677) 2021-12-09 16:07:07 +01:00
Vera Aguilera Puerto deffd48905 Fix explosion log crash 2021-12-09 12:54:44 +01:00
Vera Aguilera Puerto 8b09d55b10 Fix weird lifestage autorefactors. 2021-12-09 12:39:51 +01:00
Vera Aguilera Puerto 8c351e5456 Merge branch 'master' into 2021-12-03-remove-IEntity-komm-süsser-todd 2021-12-09 10:39:11 +01:00
DrSmugleaf 81c0b1e174 Add admin logs window pop out button, default to docked
Default to unmaximized
2021-12-09 00:05:42 +01:00
Paul 0121f056df nukes more resolves 2021-12-08 19:39:03 +01:00
Vera Aguilera Puerto 4dcfebfd53 Fix build 2021-12-08 17:44:39 +01:00
Vera Aguilera Puerto cdc8336695 Even more resolve removals. 2021-12-08 17:41:14 +01:00
Vera Aguilera Puerto 684cb76173 Bunch more resolves removed. 2021-12-08 17:17:12 +01:00
Vera Aguilera Puerto ba736f70df Remove many resolves on Content.Server 2021-12-08 17:04:21 +01:00
Vera Aguilera Puerto 0a71b62305 Fix build.
I HATE STATIC I HATE STATIC I HATE STATIC
2021-12-08 13:07:24 +01:00
Vera Aguilera Puerto c8b65be747 Replace IEntityManager resolves in systems for cached EntityManager 2021-12-08 13:00:43 +01:00
Vera Aguilera Puerto 4919f1db69 Remove more IoCManager IEntityManager resolves 2021-12-08 10:41:38 +01:00
Neith 0331ad5268
Fixed redundant IoCManager resolves on GameTicker.Spawner 2021-12-07 14:19:41 -08:00
Bingo Johnson 268b2602b3
Critical and urgent change to atmos.
Extensive and comprehensive refactor spanning over 104 lines, improving performance and cleaning up the code.
2021-12-07 21:49:19 +00:00
Vera Aguilera Puerto f2c72f7c0e Fix last test 2021-12-07 18:10:51 +01:00
Vera Aguilera Puerto 3f79e3754f Merge branch 'master' into 2021-12-03-remove-IEntity-komm-süsser-todd
# Conflicts:
#	Content.Client/Crayon/CrayonDecalVisualizer.cs
#	Content.Client/Tabletop/TabletopSystem.cs
#	Content.IntegrationTests/Tests/InventoryHelpersTest.cs
#	Content.Server/AI/EntitySystems/AiSystem.cs
#	Content.Server/AI/Utility/AiLogic/UtilityAI.cs
#	Content.Server/AME/AMENodeGroup.cs
#	Content.Server/Administration/AdminVerbSystem.cs
#	Content.Server/Body/Systems/RespiratorSystem.cs
#	Content.Server/Chemistry/Components/InjectorComponent.cs
#	Content.Server/Chemistry/TileReactions/CleanTileReaction.cs
#	Content.Server/Chemistry/TileReactions/SpillTileReaction.cs
#	Content.Server/Crayon/CrayonComponent.cs
#	Content.Server/Doors/Components/ServerDoorComponent.cs
#	Content.Server/Explosion/EntitySystems/TriggerSystem.cs
#	Content.Server/Fluids/Components/MopComponent.cs
#	Content.Server/Fluids/Components/SpillExtensions.cs
#	Content.Server/Fluids/EntitySystems/PuddleSystem.cs
#	Content.Server/Instruments/InstrumentSystem.cs
#	Content.Server/Nutrition/EntitySystems/DrinkSystem.cs
#	Content.Server/Nutrition/EntitySystems/FoodSystem.cs
#	Content.Server/PneumaticCannon/PneumaticCannonSystem.cs
#	Content.Server/Storage/Components/EntityStorageComponent.cs
#	Content.Server/Storage/Components/StorageFillComponent.cs
#	Content.Server/Stunnable/StunbatonSystem.cs
#	Content.Server/Throwing/ThrowHelper.cs
#	Content.Server/Weapon/Ranged/Barrels/BarrelSystem.cs
#	Content.Server/Weapon/Ranged/Barrels/Components/ServerBatteryBarrelComponent.cs
#	Content.Server/Weapon/Ranged/ServerRangedWeaponComponent.cs
#	Content.Shared/Containers/ItemSlot/ItemSlotsSystem.cs
#	Content.Shared/Damage/Components/DamageableComponent.cs
#	Content.Shared/Damage/Systems/DamageableSystem.cs
#	Content.Shared/MobState/Components/MobStateComponent.cs
#	Content.Shared/Slippery/SharedSlipperySystem.cs
2021-12-07 17:48:49 +01:00
metalgearsloth 16e1bed678 Random IoCManager.Resolve<IEntityManager> removals moment 2021-12-07 23:48:34 +11:00
metalgearsloth 8af335097f More (IComponent) shenanigans and also some contaminated IoCManager.Resolve<IEntityManager>() very long yes calls 2021-12-07 22:22:34 +11:00
metalgearsloth 373b5988d7 Remove redundant IComponent casts 2021-12-07 21:54:00 +11:00
Leon Friedrich bd8acc5b6b
Fix food & do-after bugs (#5716) 2021-12-06 23:19:26 -07:00
pointer-to-null 090e74792c
Status effects fix. Refresh the status effect cooldown. (#5708) 2021-12-06 23:18:07 -07:00
Peptide90 e2a7fd24d5
Adds construct / deconstruct crates (#5650) 2021-12-06 15:10:03 -07:00
Vera Aguilera Puerto 8d4799e611 Fixes some integration tests 2021-12-06 16:40:04 +01:00
Vera Aguilera Puerto 0577f60df6 More crash fixes 2021-12-06 15:56:14 +01:00
Vera Aguilera Puerto c57b07a4d0 Goes in-game now 2021-12-06 15:34:46 +01:00
DrSmugleaf af4eb3c7cd Fix more errors, client and server now build 2021-12-06 14:00:39 +01:00
metalgearsloth 525297c5fe A bunch of AttachedEntity bullshit 2021-12-06 15:39:46 +11:00
DrSmugleaf 215cae5655 Fix more errors 2021-12-06 00:52:58 +01:00
DrSmugleaf 2b1fecbe02 Merge remote-tracking branch 'Zumorica/2021-12-03-remove-IEntity-komm-süsser-todd' into 2021-12-03-remove-IEntity-komm-süsser-todd
# Conflicts:
#	Content.Server/DeviceNetwork/Systems/WiredNetworkSystem.cs
#	Content.Server/Hands/Systems/HandsSystem.cs
#	Content.Server/Radio/Components/IRadio.cs
#	Content.Server/UserInterface/ActivatableUISystem.cs
2021-12-05 22:10:07 +01:00
DrSmugleaf ab9d0cc6d8 Fix errors 2021-12-05 21:02:04 +01:00
Wrexbe b9dd3be061 More Changes 2021-12-05 10:56:17 -08:00
DrSmugleaf 2a3b7d809d Fix 3000 errors 2021-12-05 18:09:01 +01:00
Leon Friedrich e8b2d0a844
Make BatteryBarrelComponent use item slots. (#5591) 2021-12-05 14:23:47 +11:00
Ygg01 d1ab9592aa
Minor spill refactors (#5569) 2021-12-05 14:18:30 +11:00
metalgearsloth 5d63411113
NPC wake / sleep cleanup (#5679) 2021-12-05 14:08:35 +11:00
Leon Friedrich ae65418c52
Remove radiation & explosion damage logs. Add better explosion-trigger logs (#5689) 2021-12-05 13:34:32 +11:00
Leon Friedrich bfff21ea73
Add IngestionBlocker component (#5692) 2021-12-04 11:56:27 -07:00
Vera Aguilera Puerto 2bfec7ec62 Some more fixes 2021-12-04 14:14:22 +01:00
Vera Aguilera Puerto 424c83e39c Fix a lot more errors. 2021-12-04 12:35:33 +01:00
Leon Friedrich 49a5696fd6
Add Syringe DoAfter (#5658)
* syringe do after

* fix spacing

* delay and log tweaks

* Apply suggestions from code review

Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>

* clean up comments

Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
2021-12-04 03:33:21 -08:00
Flipp Syder 4a161325f5
adds interactusing to electrocution (#5693) 2021-12-04 01:59:09 -08:00
Flipp Syder 863a85cef6
adds toggles for accessreaders (#5696) 2021-12-04 01:01:37 -08:00
Leon Friedrich c33d06c544
lung fix (#5697) 2021-12-04 01:11:48 -07:00
wrexbe 076910eb04
Multiply pushback ratio by 10 for better recovery from being spaced (#5687)
Co-authored-by: 20kdc <asdd2808@gmail.com>
2021-12-04 01:26:51 +01:00
Paul Ritter e4defccd33
Revert "Salvage 0.1" (#5684) 2021-12-03 23:42:38 +01:00
20kdc 0205846ab2
Salvage 0.1 (#5662) 2021-12-03 23:24:19 +01:00
Wrexbe e2d7ea6f62 Got rid of some IEntities 2021-12-03 11:15:41 -08:00
Vera Aguilera Puerto f5b8bb3731 More manual fixes. 2021-12-03 17:35:20 +01:00
Vera Aguilera Puerto f386b57148 Inline OwnerUid 2021-12-03 16:30:34 +01:00
Vera Aguilera Puerto 2eacf98335 Literally fucking remove IEntity 2021-12-03 16:08:30 +01:00
Vera Aguilera Puerto 5cd42c9ad6 Inline UID 2021-12-03 15:53:09 +01:00
Paul Ritter 219d91c6da
decal system & crayons (#5183)
Co-authored-by: Paul <ritter.paul1+git@googlemail.com>
2021-12-03 15:35:57 +01:00
Vera Aguilera Puerto 2654775bf0 Inline GetComponentOrNull 2021-12-03 15:32:05 +01:00
Vera Aguilera Puerto ee4ff9cfe8 Inline Name 2021-12-03 15:25:51 +01:00
Vera Aguilera Puerto 61be228ad0 Some manual GetComponentOrNull inlines 2021-12-03 15:18:15 +01:00
Vera Aguilera Puerto a5b57c8e10 Inline Transform 2021-12-03 14:20:34 +01:00
Vera Aguilera Puerto 69b270017b Inline TryGetComponent completely, for real 2021-12-03 14:17:01 +01:00
Vera Aguilera Puerto 2ff4ec65d5 Inline TryGetComponent completely 2021-12-03 14:05:27 +01:00
Vera Aguilera Puerto f3edecf994 Some manual TryGetComponent inlines 2021-12-03 12:51:44 +01:00
Vera Aguilera Puerto 0feebbff00 Inline HasComponent entirely 2021-12-03 12:23:18 +01:00
Vera Aguilera Puerto 88141ae6b8 Inline one TryGetComponent overload 2021-12-03 12:17:57 +01:00
Vera Aguilera Puerto 72a68c06e4 Inline one HasComponent overload 2021-12-03 12:17:57 +01:00
Vera Aguilera Puerto b835bea086 Inline GetComponent 2021-12-03 11:55:25 +01:00
Vera Aguilera Puerto c2e6da1e54 Inline QueueDelete 2021-12-03 11:43:22 +01:00
Vera Aguilera Puerto e3227546b3 Inline Delete 2021-12-03 11:43:03 +01:00
Vera Aguilera Puerto f10ed6c0c3 Inline GetAllComponents 2021-12-03 11:42:24 +01:00
Vera Aguilera Puerto e0fe09cb46 Inline RemoveComponent 2021-12-03 11:34:00 +01:00
Vera Aguilera Puerto f64df117be Inline AddComponent 2021-12-03 11:33:40 +01:00
Vera Aguilera Puerto 2d130e31d6 Inline IsValid 2021-12-03 11:32:53 +01:00
Vera Aguilera Puerto 1b13e5e0ec Inline Paused 2021-12-03 11:30:39 +01:00
Vera Aguilera Puerto b2035543e2 Inline Deleted 2021-12-03 11:30:03 +01:00
metalgearsloth 07b2ce138d
entitystorage fixes (#5660) 2021-12-03 21:19:53 +11:00
Vera Aguilera Puerto f06bfc22ce Inline Description 2021-12-03 11:18:05 +01:00
Vera Aguilera Puerto 70bbd8c502 Inline Prototype 2021-12-03 11:18:05 +01:00
Vera Aguilera Puerto cd43196ea8 Inline LifeStage 2021-12-03 11:18:05 +01:00
Vera Aguilera Puerto 5e177ae734 Inline EntityManager 2021-12-03 11:18:05 +01:00
Vera Aguilera Puerto bd18574412
The End of Entity (Komm, Süsser Todd: Part 1.0, Content PR) (#5624) 2021-12-03 11:03:41 +01:00
shaeone 705db5596c
New gyroscope sprite for the shuttle (#5617)
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2021-12-03 20:39:17 +11:00
metalgearsloth c17ef0b3c8
Allow GhostTakeoverAvailable to use MakeSentient (#5616) 2021-12-03 10:31:14 +01:00
Vera Aguilera Puerto 3f8f4c818e
Fixes admin logs and tests to not depend on IEntity caching (#5657)
Co-authored-by: Paul Ritter <ritter.paul1@googlemail.com>
2021-12-03 10:25:07 +01:00
wrexbe c4c139041c
Mapping: Check if map already exists (#5666) 2021-12-03 15:25:50 +11:00
metalgearsloth 56845da37b
Piloting and thruster tuning (#5594)
Co-authored-by: metalgearsloth <metalgearsloth@gmail.com>
2021-12-03 13:03:06 +11:00
Moony 4cd09c23f5
Removes smilies from existence. (kinda) (#5649) 2021-12-03 01:49:19 +01:00
hubismal a04720fdda
pAIs Play Music (#5614)
* Disable check

* vehicle test

* Make PAI stop instrument when turning off (player leaves/ejected)

* Give pAI an instrument component with a custom soundfont

* Add pAI synth program to custom ss14 soundfont

* Add new PAIMidi action that pAIs use to open their instruments

* Changed instrument component to allow its player to be the actor of its parent item

* Oops. Readds instrumentcomponent.

* ECS Changes

* Changed soundfont to ringtone

* Revert "Disable check"

This reverts commit 86001d8b5e94ee38d0c9504cb19826327b04fb16.

* Remove action parameters from ghost placeholder

* Revert "vehicle test"

This reverts commit 8a8ecf41083e0d5c8d4363ff02981bdab04bcd1c.

* Fixes to whitespace

* Even more fixes to whitespace

* Removed paiSynth sample from spacestation14.sf2

* Yet another indentation touchup
2021-12-02 11:49:18 -07:00
Leon Friedrich a9c3153a55
Make masks & some helmets block eating/drinkling (#5656) 2021-12-02 15:51:05 +01:00
mirrorcult 207dacd1f2
Nerf electrocution (#5651) 2021-12-01 20:03:38 -07:00
E F R 9216d279af
Events/RadiationStorm: Fancy radiation shader & SFX (#5612) 2021-12-01 13:21:17 -07:00
20kdc b5c5871453
Fix a bunch of returns where they should not be (#5640) 2021-12-01 15:00:10 +01:00
mirrorcult 53c0a47e39
Slay bobby pt. 1 (#5632) 2021-12-01 11:44:34 +01:00
metalgearsloth 1c089a4079
Fixtures (again) (#5636) 2021-12-01 18:32:37 +11:00
metalgearsloth 43b637826d Revert "Content update for fixture changes (#5524)"
This reverts commit 0a843b671f.
2021-12-01 13:55:24 +11:00
metalgearsloth 0a843b671f
Content update for fixture changes (#5524) 2021-12-01 13:05:08 +11:00
metalgearsloth c2f2d27b16
ECS chemical ammo shooting (#5620) 2021-12-01 12:40:00 +11:00
mirrorcult ccf01d7431
Remove LungBehavior and replace with LungComponent/System (#5630) 2021-11-30 18:25:02 -07:00
mirrorcult e3af2b5727
ECS BloodstreamComponent (#5629) 2021-11-30 16:47:21 -07:00
Paul d3b2f580fe misc cargo fixes 2021-11-30 17:06:40 +01:00
Paul Ritter fbcb53dcc0
pvs content (#5484)
Co-authored-by: Paul <ritter.paul1+git@googlemail.com>
2021-11-30 15:20:38 +01:00
metalgearsloth d0efe50e83
Comment out invalid access tags (#5619) 2021-11-30 14:40:46 +01:00
metalgearsloth 4c2f915e7e
Make hitscan effects use grid / map coordinates (#5621) 2021-11-30 14:38:13 +01:00
Vera Aguilera Puerto bc7463f744 Add GetTileHeatCapacity methods to AtmosphereSystem, makes TemperatureSystem use them. 2021-11-30 12:00:25 +01:00
FoLoKe 6f455346b2
Fixes mouse self-eating (#5622) 2021-11-30 21:45:33 +11:00
Vera Aguilera Puerto 94fa6efefb
Misc Atmos Improvements (#5613)
* Revert "Remove atmos archiving."

This reverts commit 7fa10bd17b.

* Explosive Depressurization now brings tiles down to TCMB.

* Tiles now specify heat capacity.

* Do not serialize archived gas mixture values.

* Remove bad idea

* dumb typo

* Space gas mixtures now have a harcoded heat capacity.
This is a bit of a hack, but rooms exposed to space now cool down properly when monstermos is disabled.
Huge thanks to @LemonInTheDark for helping me with this!

* Clean up heat capacity methods

* Better logging based on the original monstermos' logging

* Comment explosive depressurization hack better
2021-11-30 11:42:48 +01:00
FoLoKe 9db2fbefe1
Moves Sliceable to ECS (#5552) 2021-11-30 21:20:13 +11:00
Moony cc1741f0a9
Shuffle around command perms for trial admin (#5606) 2021-11-29 21:40:10 +01:00
Leon Friedrich d0c5d72d47
Forcefeed DoAfters, again. (#5582) 2021-11-29 14:27:15 +11:00
mirrorcult 9cce58a70b
The Pyro Update (#5575) 2021-11-28 19:25:51 -07:00
mirrorcult fc4a950257
Split Respirator into ThermalRegulator and Respirator and ECSes both (#5603) 2021-11-28 19:25:42 -07:00
Moony 9075cf6163
Space Kudzu (#5472) 2021-11-28 19:25:36 -07:00
Spartak 30c87ca6b2
Added auto label for ChemMaster (#5596) 2021-11-28 19:25:23 -07:00
Leon Friedrich 22ee9f5e83
Enable verbs for items in storage and prevent orphaned nested UIs (#5512) 2021-11-28 16:25:22 -07:00
Pieter-Jan Briers 64861ff034
Add Content.Shared.Database (#5588) 2021-11-28 14:56:53 +01:00
Leon Friedrich 0de4b7bc9f
Modify damage logging. (#5579) 2021-11-28 14:34:44 +01:00
metalgearsloth 32a2181d82
Fix some thrust stuff (#5577) 2021-11-28 03:03:46 +01:00
Moony 78b5cca638
Observing outside the lobby is no longer a thing you can do. (#5587) 2021-11-28 02:28:32 +01:00
Vera Aguilera Puerto 47a19f94d4
Make instruments ECS (#5516) 2021-11-28 01:47:36 +01:00
20kdc f5c3b1935b
Disable station events while mapping (#5581) 2021-11-28 03:22:20 +11:00
Kara D 120e1b75c7
unfuck every reagent effect 2021-11-27 01:27:47 -07:00
mirrorcult f697bf413c
Log a lot less reagent effects (#5572) 2021-11-27 00:31:56 -07:00
mirrorcult bf30f82ff5
Acid effects (#5466)
* acid

* balance

* nerf area effects
2021-11-27 00:31:49 -07:00
Spartak b06becaf98
Adds pills type selection and pills canister (#5539)
* Added pill type selection

Ui textures missing for now

* bugfixes

* Pill type selection

* ui changes

* Added pills canister

* Change requests
2021-11-26 23:44:36 -07:00
wrexbe a354741b4b
Fix the add role command (#5532) 2021-11-26 23:43:54 -07:00
wrexbe 1a39807ce5
Add listroles command (#5533) 2021-11-26 23:43:49 -07:00
Moony 7792c0b5f1
Station management commands (#5553) 2021-11-26 23:43:43 -07:00
Moony 469d57f34e
owo (#5510)
* owo

* URGENT FIXES

* typo moment
2021-11-26 23:43:33 -07:00
Leon Friedrich 7a843fa830
fix cigar case visuals (#5570)
* fix cigar

* newline
2021-11-26 23:43:19 -07:00
Moony ef89af1a0c
Fix the job overflow crash (#5560)
* Fix the overflow crash

* localization fail
2021-11-26 15:51:00 -07:00
Leon Friedrich 61423be24e
Add cheese & dough reactions (#5547)
* git mv

* rename CreateEntityReaction -> CreateEntityTileReaction

* cheese

* change microwave recipes

* remove unnecessary test

* TryGet->Get
2021-11-26 15:50:14 -07:00
DrSmugleaf 7ecd08b8ca Move resetting accumulatedFrameTime in AdminLogSystem to the start of the method 2021-11-26 23:43:40 +01:00
Moony f60484b15c
Random station names! (#5548) 2021-11-26 14:54:32 +01:00
wrexbe 5f02daec4e
Fix explosions with same source, and target pos (#5530)
* Fix explosions with same source, and target pos

* Using for Robust.Shared.Maths, Removed whitespace

* Don't throw in explosion if the offset is zero
2021-11-26 12:32:22 +01:00
Moony 85ea135ad4
Oh god (#5534)
* Fixes the funny station issue and prevents free respawns

* not in the sudoers file
2021-11-26 11:03:29 +01:00
20kdc f0f913f5bc
Change over solar panel breakage to use more construction graphs (#5395) 2021-11-26 10:17:21 +01:00
Moony ec68226e99
Refactor how jobs are handed out (#5422)
* Completely refactor how job spawning works

* Remove remains of old system.

* Squash the final bug, cleanup.

* Attempt to fix tests

* Adjusts packed's round-start crew roster, re-enables a bunch of old roles.
Also adds the Central Command Official as a proper role.

* pretty up ui

* refactor StationSystem into the correct folder & namespace.

* remove a log, make sure the lobby gets updated if a new map is spontaneously added.

* re-add accidentally removed log

* We do a little logging

* we do a little resolving

* we do a little documenting

* Renamed OverflowJob to FallbackOverflowJob
Allows stations to configure their own roundstart overflow job list.

* narrator: it did not compile

* oops

* support having no overflow jobs

* filescope for consistency

* small fixes

* Bumps a few role counts for Packed, namely engis

* log moment

* E

* Update Resources/Prototypes/Entities/Objects/Misc/identification_cards.yml

Co-authored-by: Leon Friedrich <60421075+ElectroJr@users.noreply.github.com>

* Update Content.Server/Maps/GameMapPrototype.cs

Co-authored-by: Leon Friedrich <60421075+ElectroJr@users.noreply.github.com>

* factored job logic, cleanup.

* e

* Address reviews

* Remove the concept of a "default" grid.
It has no future in our new multi-station world

* why was clickable using that in the first place

* fix bad evil bug that almost slipped through
also adds chemist

* rms obsolete things from chemist

* Adds a sanity fallback

* address reviews

* adds ability to set name

* fuck

* cleanup joingame
2021-11-26 20:02:46 +11:00
wrexbe dd56c05423
Skip duplicate uids in admin log (#5528) 2021-11-26 08:39:36 +01:00
DrSmugleaf 1638498273 Add CCVar to enable and disable admin logs 2021-11-26 00:11:25 +01:00
DrSmugleaf e06dc89c34 Remove setting AdminLogPlayer.RoundId explicitly 2021-11-25 23:53:59 +01:00
AJCM-git 2ea7c55e93
Clean and add spawners (#5520) 2021-11-25 15:36:57 -07:00
Moony d5c5cbeaf4
buzz buzz (#5490)
* buzz buzz

* Darn now i'm all out of periods   thanks mirror
fix toy issue

* desc edits.

* rng and alphabee

* adds some missed parens
2021-11-24 23:06:13 -07:00
FoLoKe e94bd5698d
Fixes EatVerb interaction range (#5505) 2021-11-25 13:16:56 +11:00
20kdc de0a6511cc
Fix disposals trapping you for eternity when leaving via a trunk pipe (#5498) 2021-11-25 13:10:15 +11:00
Moony c576eb91d3
Adds like 17 new logs (#5499)
Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com>
2021-11-24 23:52:31 +01:00
DrSmugleaf dc9ae49126 Fix error when getting players from a log
Also potentially fix FilterTests.Date
2021-11-24 22:07:54 +01:00
20kdc f2eea79238
Fix solar control console UI not responding to input (#5506) 2021-11-24 21:51:43 +01:00
DrSmugleaf 1342451243 Downgrade atmos to plosiveDepressurizati
Clip text of admin log types on buttons
Add a few TODOs for the future coder
2021-11-24 19:01:26 +01:00
DrSmugleaf 25ed516eb0 Fix admin log crash in the lobby
Add test
Fixes https://github.com/space-wizards/space-station-14/issues/5504
2021-11-24 18:53:55 +01:00
Leon Friedrich 3b29ffdfa0
Make chemistry machines and IdCardConsole use item slots (#5428)
* chemistry item slots

* item slots id card console
2021-11-24 18:03:07 +11:00
Moony 355625bded
OH GOD NO PLASMA PLEASE (#5494)
* OH GOD NO PLASMA PLEASE

* fuck
2021-11-23 21:08:17 -07:00
Moony 39acf77858
Speedy event patches to make events less ass (#5493) 2021-11-24 03:06:59 +01:00
20kdc eb18f7bc1c
Sending a mob out of a disposals unit shouldn't push them into a wall anymore (#5411)
* Sending a mob out of a disposals unit shouldn't push them into a wall anymore.

* Something something resolves vs. OnRemove fighting it out

* Disposals yeet reduction: Address reviews and other oddities
2021-11-23 16:38:46 -07:00
Clyybber 0e98c1c524
Refactor slip dropping to use throwing (#5476)
* Refactor slip dropping to use throwing

* Update Content.Server/Fluids/EntitySystems/SpillableSystem.cs

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>

* Uncringe

* Update Content.Server/Fluids/EntitySystems/SpillableSystem.cs

Co-authored-by: Leon Friedrich <60421075+ElectroJr@users.noreply.github.com>

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: Leon Friedrich <60421075+ElectroJr@users.noreply.github.com>
2021-11-23 16:38:39 -07:00
Paul f675ff37b1 fix exception 2021-11-23 20:20:40 +01:00
20kdc f6d44be34f
Activatable UI component (#5184)
* Transfer most Instrument UI logic to a new component, ActivatableUIComponent

* Move more ActivatableUIComponent stuff to ECS

* ActivatableUI component ignore on client

* ActivatableUI: Get rid of component interfaces where possible

* Add in adminOnly attribute for activatable UIs

This is so that porting #4926 to this will be easier

* Transition Solar Control Computer to ActivatableUI

* Move communications console to ActivatableUI

* Move cargo console to ActivatableUI

* Move ID card console to ActivatableUI

* ActivatableUI: Make things more amiable to entity tests adding components weirdly

* ActivatableUI: Use handling or lack thereof of events properly

* ActivatableUI: component dependency issue resolution stuffs

* ActivatableUISystem: Fix #5258

* More fixes because master did stuffo

* Check for HandDeselectedEvent again because otherwise active-hand check doesn't work

* Move just a bit more code into the system, introduce a workaround for #5258

* Purge the player status detection stuff

* Oh and some obsolete stuff too
2021-11-23 19:19:08 +01:00
metalgearsloth 32c36ad221
Give pried tiles a random rotation (#5482)
Also made it so they start with a random offset to avoid the additional MoveEvent going out.
2021-11-23 10:15:49 -07:00
Leon Friedrich 1de82b4324
Fix spill crash (#5480)
* fix spill

* clean up mop component

* remove unecessary code
2021-11-23 10:14:46 -07:00
DrSmugleaf cc79053825 Fix round starting and db round spam
Fixes https://github.com/space-wizards/space-station-14/issues/5467
RunLevel was being set after waiting for the DB, causing GameTicker.Update to fire during the wait
2021-11-23 18:12:24 +01:00
20kdc a2b7982c37
Add variables to prevent voting of various kinds (#5361)
* Add a way to disable voting for maximum authoritarianism

* Allow disabling specific vote types via cvars

* Migrate standard-vote-to-cvar dictionary to being static
2021-11-23 10:03:04 -07:00
DrSmugleaf 781a083fcf Fix not waiting for logs to be sent to Azkaban 2021-11-23 17:50:06 +01:00
Vera Aguilera Puerto af86378995
Log explosive depressurization. (#5474) 2021-11-23 12:22:18 +01:00
Leon Friedrich 3d755caea1
Log verbs & alt-click interactions. (#5471)
* verb logging

* Just a lil regex

Verb ([a-zA-Z]*) = new\(\)
Verb $1 = new(args)

* nvm that didn't work

* better log messages

* Revert "Just a lil regex"

This reverts commit aa2b143d042f1ed007c801d9e2c264cb07993aa1.

* remove garbage code

* better docstring
2021-11-23 11:00:16 +01:00
Acruid fa0ec5cbd9
AppearanceComponent API Changes (#5446) 2021-11-23 18:22:59 +11:00
xRiriq c8acba0ba7
biological medicine now restricted to biological targets (#5276)
Co-authored-by: xRiriq <xRiriq.git@gmail.com>
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2021-11-23 18:15:10 +11:00
Acruid 6e54e740c7
Removed Old PlayerSession Functions (#5404)
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2021-11-23 18:11:48 +11:00
mirrorcult e2205e418b
Epinephrine + epipen (#5444)
* add sprite and basic entity, no reagent or testing

* actually implement epinephrine and add it to the box

* allow creating it

* add it to nanomed

* fig
2021-11-22 23:51:51 -07:00
mirrorcult 732baa56a9
Reaction & reagent effect logging (#5463)
* Reaction logging

* effect logging

* position
2021-11-22 23:51:43 -07:00
metalgearsloth 2f6a5ea2f2
Add examine text for thrusters (#5469) 2021-11-23 17:44:08 +11:00
Kara D 567ed44408
hotfix lube crash
stackoverflowing
2021-11-22 23:21:20 -07:00
mirrorcult 6fc397f801
carpet (#5464)
* carpet

* reviews

* why tf i gotta fix integration tests in the carpet pr
2021-11-22 18:01:51 -07:00
20kdc 1e061094ca
Direct pressure and asphyxiation damage do not interrupt DoAfters anymore (#5459) 2021-11-22 17:34:56 -07:00
20kdc 1ba58456c4
Announcements play the general announcement sound unless specifically inhibited (#5460) 2021-11-22 15:34:48 -07:00
DrSmugleaf 7b5878b846 Support player sessions in admin logs and add test
Fix EventRan log type id
Make slipping low impact
2021-11-22 23:15:22 +01:00
DrSmugleaf af6353da46 Add admin logs for shuttle call/recall 2021-11-22 21:31:50 +01:00
DrSmugleaf 37e7da0e42 The technology for round time just isn't there yet
Add clock date to displayed logs
I'm sorry moony
2021-11-22 21:19:07 +01:00
DrSmugleaf 7de23c935b Expose round duration as a method on GameTicker 2021-11-22 21:12:47 +01:00
DrSmugleaf 3ba58e2d9c Merge branch 'master' of https://github.com/space-wizards/space-station-14 2021-11-22 20:59:30 +01:00
DrSmugleaf 13692b5433 Make starting and running station events high priority 2021-11-22 20:55:47 +01:00
DrSmugleaf 612c62c569 Add admin logging to system events 2021-11-22 20:49:47 +01:00
DrSmugleaf 86ce2aeb22 Add EntityUid AdminLogConverter 2021-11-22 20:36:03 +01:00
metalgearsloth 2a9b3a013c
Don't run aghost if already aghost for mapping (#5452) 2021-11-22 12:31:21 -07:00
DrSmugleaf c3fe5909ad THE RETURN OF THE KING
This reverts commit c18d07538a.
2021-11-22 19:08:27 +01:00
DrSmugleaf c18d07538a Revert "Admin logs (#5419)"
This reverts commit 319aec109d.
2021-11-22 18:55:17 +01:00
Javier Guardia Fernández 319aec109d
Admin logs (#5419)
* Add admin logging, models, migrations

* Add logging damage changes

* Add Log admin flag, LogFilter, Logs admin menu tab, message
Refactor admin logging API

* Change admin log get method names

* Fix the name again

* Minute amount of reorganization

* Reset Postgres db snapshot

* Reset Sqlite db snapshot

* Make AdminLog have a composite primary key of round, id

* Minute cleanup

* Change admin system to do a type check instead of index check

* Make admin logs use C# 10 interpolated string handlers

* Implement UI on its own window
Custom controls
Searching
Add admin log converters

* Implement limits into the query

* Change logs to be put into an OutputPanel instead for text wrapping

* Add log <-> player m2m relationship back

* UI improvements, make text wrap, add separators

* Remove entity prefix from damaged log

* Add explicit m2m model, fix any players filter

* Add debug command to test bulk adding logs

* Admin logs now just kinda go

* Add histogram for database update time

* Make admin log system update run every 5 seconds

* Add a cap to the log queue and a metric for how many times it has been reached

* Add metric for logs sent in a round

* Make cvars out of admin logs queue send delay and cap

* Merge fixes

* Reset some changes

* Add test for adding and getting a single log

* Add tests for bulk adding logs

* Add test for querying logs

* Add CallerArgumentExpression to LogStringHandler methods and test

* Improve UI, fix SQLite, add searching by round

* Add entities to admin logs

* Move distinct after orderby

* Add migrations

* ef core eat my ass

* Add cvar for client logs batch size

* Sort logs from newest to oldest by default

* Merge fixes

* Reorganize tests and add one for date ordering

* Add note to log types to not change their numeric values

* Add impacts to logs, better UI filtering

* Make log add callable from shared for convenience

* Get current round id directly from game ticker

* Revert namespace change for DamageableSystem
2021-11-22 18:49:26 +01:00
mirrorcult e40c9bc427
Reactive 3.0 (#5443)
* probably scrapping this

* reimpl old behavior

* misc fixes and initial yaml

* works basically first try
2021-11-22 10:17:35 +01:00
Kara D 8b47d0f43f
Reduce pneumatic cannon mole usage 2021-11-22 02:08:29 -07:00
mirrorcult 1ca990c879
Reduce default metabolism rate from 1 to 0.5 (#5445) 2021-11-22 19:45:20 +11:00
mirrorcult 0f2dda8275
screaming and crying (#5447) 2021-11-22 19:40:14 +11:00
Moony d171c5e84c
Fix antag shitcurity (#5441)
* fix jobs

* Antagn't the heads and sec

* good to go, time to test my code
2021-11-21 19:33:50 -07:00
Vera Aguilera Puerto a666ddb045 Remove MindHelpers, stop using PlayerHelpers. 2021-11-21 17:59:38 +01:00
Vera Aguilera Puerto 2f6e069bcd
Docked airlocks no longer depressurize the room when opened. (#5431) 2021-11-21 23:17:30 +11:00
FoLoKe 24aca21eb6
Moved Food and Utensil to ECS (#5380)
* Food and Utensil to ECS, Made utensil less restrictive, no more soup eating with a knife...

* AltVerb "can eat" check

* removed HasFlag calls

* AltActionVerb -> InteractionVerb

* "required utensil" filed
2021-11-21 00:35:09 -07:00
mirrorcult 1ab7170adb
Refactor reaction effects to use reagent effects (#5426)
* reaction effect refactor

* works now
2021-11-21 00:35:02 -07:00
metalgearsloth bdead40a80
Thrusters (shuttle go nyoom) (#5352) 2021-11-21 17:09:49 +11:00
AJCM-git 3da31d5146
Fixes ActivateItemInWorld working with things outside your container (#5424)
* Fixes InteractionActivate working inside containers

* This makes more sense now that i think about it
2021-11-20 22:06:44 -07:00
mirrorcult 181fd055ce
Adds metabolism effects to pretty much every chem already in the game (#5349)
* pass 1

* a little more reagent effect for breakfast

* move lots of stuff around

* implements all medicines

* implement all cleaning & elements

* implement toxins/pyrotechnic

* p

* linter fixies

* fixes + narcotic balancing

* fix and standardize

* reviews

* things
2021-11-20 16:47:53 -07:00
Moony eb6d24abd0
Makes map vote and roundstart smart about player count. (#5418)
* Makes map vote and roundstart smart about player count.
No more Saltern with 30 players, or Knight Ship with 50.

* a typo

* Address reviews.

* Localized.
2021-11-20 11:32:07 -07:00
Paul cc0122421c misc change for pvs 2021-11-20 12:35:22 +01:00
Leon Friedrich 91b185e3c2
Rejigging Item slots (#4933)
* itemslot overhaul

* remove "shared" prefix

* handle component shutdown

* comments, cleanup, tests

* comments and minor tweak

* rename ItemSlotManagerState

* fix swapping

* fix merge

* Add ItemSlot verb text override

* fix merge  (IEntity -> entityUid)

* Fix merge (LabelSystem)

* Fix merge (nuke disk)

* fix test
2021-11-19 22:26:01 -07:00
20kdc 73ca553ad4
Have medical scanners and cloning pods be 'climbed upon' on exit. (#5408) 2021-11-19 18:03:09 -07:00
Tomeno 8c71099fa2
Fix thermoregulation + rebalance/refactor FlammableComponent (#5406)
Co-authored-by: Paul Ritter <ritter.paul1@googlemail.com>
Co-authored-by: Tomeno <tomeno@lulzsec.co.uk>
2021-11-19 17:54:01 +01:00
Pieter-Jan Briers 86a7eece40
Adds a bool (#5372) 2021-11-18 23:36:25 -07:00
mirrorcult 07024f7c77
Severely nerf fires and severely buff fire protection (#5396)
* Make fires do less damage

* Severely nerf fires and severely buff temperature protection

* fuck it, i'll nerf it so hard and we can buff it later if we decide

* new scaling func

* fix

* unused

* reviews + balance metabolism heat + reduce atmos air temp transfer efficiency

* little more balance

* just a wee bit more

* slight adjustment
2021-11-18 23:08:30 -07:00
Kara D a724292023
Fix AME parts being rotated 2021-11-18 16:53:45 -07:00
Clyybber 6ac2446d26
Remove some warnings (#5391)
* Remove unused Dependency fields

* Remove noop null check
2021-11-18 16:46:35 -07:00
20kdc 856e570c7b
Stop BatterySystem from iterating over every battery just to recharge micro-reactors (#5393) 2021-11-18 20:02:17 +01:00
Tomeno 3c638b16dd
Solar panel optimizations (#5392)
* Rewrite solar panel update scheduling

* Use predicate to filter out non-anchored entities from solar raytrace

* Remove unused dependency

* Cache physics system

Co-authored-by: Tomeno <tomeno@lulzsec.co.uk>
2021-11-18 09:45:50 -07:00
Acruid 49151cd4cd Removes the last use of EntitySystem.EntitySystemManager in content. 2021-11-16 20:25:28 -08:00
20kdc 8c98038692
fixrotations fixes rotations properly again (#5292) 2021-11-17 12:00:58 +11:00
xRiriq ad4db6ba00
hardsuit clothing should be large and not fit in pockets (#5368)
Co-authored-by: xRiriq <xRiriq.git@gmail.com>
2021-11-16 17:05:41 -07:00
20kdc adefa610e0
Fix pneumatic cannon audio location (#5370) 2021-11-16 14:05:19 -07:00
20kdc cc41896836
TraitorDM: Fix round end description line (#5363) 2021-11-15 17:52:10 -07:00
20kdc 4cce40bd9f
Ghost roles create new minds, better tracking of roles at round end screen (#5175)
* Ghost roles now get new Minds

* Some round start/end button stuff

* Mind tracking for better round end reports

* Make traitor kill objectives use mind CharacterName rather than actual occupied entity ("kill brain" prevention)

* Transition over to EntityUid for mind stuff because that's the only way to do it

* BrainSystem fix for PR rebase
2021-11-15 11:14:34 -07:00
Pieter-Jan Briers 5923c848d2 Admins can see if other admins are AFK. 2021-11-15 14:13:18 +01:00
Pieter-Jan Briers b83ee83c22 Add adminwho command. 2021-11-15 09:10:57 +01:00
Tomeno 3f32f9f87c
AHelp tweaks - colored names for admins, window name (#5335)
Co-authored-by: T <tomeno@lulzsec.co.uk>
2021-11-14 12:21:18 -07:00
Tomeno ead09296c3
Fix airlock lights (#5334)
* Doors no longer permanently glow orange + logic tweak

* Fix server-side order of operations for deny animation timer

* Delay between deny >= deny length to allow animation to reset

* Fix airlock assets to use the correct deny animation name

Co-authored-by: T <tomeno@lulzsec.co.uk>
2021-11-14 18:51:02 +01:00
FoLoKe a23f3fde68
Adds cow milking (#5293) 2021-11-14 17:33:16 +01:00
Tomeno bdd2404fe0
Add "echo" command (#5331)
Co-authored-by: T <tomeno@lulzsec.co.uk>
2021-11-14 17:29:07 +01:00
Leon Friedrich 2bc8e8dc49
Fix infinite loop In explosions (#5330) 2021-11-14 12:19:41 +01:00
Tomeno 44e904fe5f
Block Game Ghosts (#5321)
Co-authored-by: T <tomeno@lulzsec.co.uk>
2021-11-13 21:43:54 +01:00
mirrorcult 828025d020
Turn brain behavior into a component/system (#5281) 2021-11-12 23:47:50 -07:00
metalgearsloth 753d198c1a Avoid unnecessary entitysystem resolve in atmos 2021-11-13 15:05:27 +11:00
metalgearsloth 8673c22931 Cache ConveyorSystem 2021-11-13 14:40:10 +11:00
20kdc 22da6e40c4
Flipping fixes (ensuring unanchored, rotation preservation) (#5296) 2021-11-13 12:54:03 +11:00
FoLoKe 5f3ae602ed
Add some animals basic mechanics (#5132)
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2021-11-13 12:48:05 +11:00
mirrorcult a731e545a9
Maps docking airlocks onto saltern (#5279)
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2021-11-13 12:46:27 +11:00
20kdc 79f917cf35
Properly reset the solars system each round, solar panels perf fix (#5295) 2021-11-12 20:00:39 +01:00
Paul 7cd16f77bd forgot about removing 2021-11-12 19:47:57 +01:00
Paul Ritter 7b48fdd7f5
adminmenu fixes (#5305) 2021-11-12 19:46:05 +01:00
Vera Aguilera Puerto 872bc79cf8 Fixes some YAML linter errors.
The remaining errors are mostly the linter being overzealous.
2021-11-12 11:22:46 +01:00
mirrorcult 03f766577a
Map vote & forcemap command (#5278) 2021-11-11 23:25:57 -07:00
mirrorcult 457e8c64ee
Convert StomachBehavior to a component/system + rejig body namespaces (#5249)
* Convert StomachBehavior to a component/system + rejig body namespaces

* test

* slightly more namespace changes

* remove

* Hello?????

* fuck you github test runner

* reviews

* oobsy!
2021-11-11 16:10:57 -07:00
ike709 c06f52a456
Adds a UI for gas mixers (#5165)
Co-authored-by: E F R <602406+Efruit@users.noreply.github.com>
Co-authored-by: Paul Ritter <ritter.paul1@googlemail.com>
Co-authored-by: ike709 <ike709@github.com>
2021-11-11 23:10:21 +01:00
Javier Guardia Fernández 720e750e86
Merge player database models (#5267) 2021-11-11 17:54:02 +01:00
Matt 81dc92ce9b
Fix for death timer resetting after returning to body. (#5174) 2021-11-11 16:17:23 +01:00
Vera Aguilera Puerto 1b01247c5f Fixes that annoying atmos zero pressure bug I've constantly been pinged and nagged about for like the past few days. 2021-11-11 16:15:49 +01:00
20kdc 0c0a60e432
Stop Item EntityStorages being able to eat people (#5268) 2021-11-11 23:56:38 +11:00
metalgearsloth 940134cec1
Nerf hacking speed (#5264) 2021-11-11 10:48:12 +01:00
20kdc dae33d14df
Alert the user if nobody's around to hear a bwoink (#5147) 2021-11-11 10:47:45 +01:00
metalgearsloth a360f6126e
Shuttle docking (#5169)
Co-authored-by: metalgearsloth <metalgearsloth@gmail.com>
2021-11-11 20:06:38 +11:00
metalgearsloth 6271eb440b
Add minimum distance for pilot breaking (#5232) 2021-11-11 18:42:34 +11:00
Alex Evgrashin b936ee6ad8
Add barebone nuke (#5242)
Co-authored-by: Alexander Evgrashin <evgrashin.adl@gmail.com>
2021-11-11 12:29:11 +11:00
20kdc 2d680fe3bb
Fix escaping from storages by movement attempt (#5256) 2021-11-11 00:07:05 +01:00
Paul 3f6b9b0d8e yet another attempt at fixing the adminmenu 2021-11-11 00:03:03 +01:00
Paul aeffabbea4 fixes adminmenus sins (fixes it) 2021-11-10 20:38:32 +01:00
Paul 2f54409ca5 my bad 2021-11-10 18:28:13 +01:00
Paul 2f95d77060 fixes stacksystem exception 2021-11-10 18:23:12 +01:00
Paul 58fc8ee35f includes deadmined admins in adminsystem playerlist updates 2021-11-10 18:09:22 +01:00
Leon Friedrich 88df3d8b10
Cargo: pizza & bureaucracy (#5123)
* add paper label component

* git mv

* rename namespace

* add cargo printouts

* more crates

* directly attach paper

* comment typo
2021-11-11 00:15:23 +11:00
Paul Ritter e74301a856
refactors adminmenu a timid amount (#5095)
Co-authored-by: Paul <ritter.paul1+git@googlemail.com>
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2021-11-10 23:26:25 +11:00
mirrorcult 747f02f3f3
Metabolism tweaks / metabolism 4.0 (#5246)
* Metabolism tweaks

* use MetabolismArgs and convert ReagentEntityReactions into ReagentEffects

* fork forgor 💀

* fixes
2021-11-10 11:11:28 +01:00
mirrorcult c4f91c3fe7
Remove some unused mechanism behaviors (#5248) 2021-11-10 17:42:56 +11:00
Javier Guardia Fernández 42aaba9a5d
Remove most IEntity usages from explosions (#5240)
* Remove most IEntity usages from Destructible and Explosions

* Perform a minute amount of cleanup

* Fix build
2021-11-09 21:24:35 +01:00
Azzy 3a4186f6f6
Fixes the infinite cuff glitch. (#5241) 2021-11-09 20:13:32 +01:00
Vera Aguilera Puerto d370142b80 Makes Grid Revalidation a step in the atmos update stages.
Fixes some atmos debug assert exceptions.
2021-11-09 16:50:15 +01:00
Vera Aguilera Puerto 4ca6f6ff69 Fix build 2021-11-09 15:53:37 +01:00
Vera Aguilera Puerto 5b4c813c6d MakeGhostRoleCommand uses EntityUid 2021-11-09 15:50:55 +01:00
Vera Aguilera Puerto 6803c52fe9 MakeSentient uses EntityUid 2021-11-09 15:44:07 +01:00
Vera Aguilera Puerto 8b57bafcd1 StackSystem uses EntityUid for Split and Spawn 2021-11-09 15:35:03 +01:00
Vera Aguilera Puerto e68fd8668d Fix anchorable InteractUsing not cooperating with the rest of event handlers 2021-11-09 15:10:23 +01:00
Vera Aguilera Puerto 4f215c7b45 RangedInteractEvent uses EntityUid exclusively
Did anyone else know this event was a thing?
2021-11-09 15:05:49 +01:00
Vera Aguilera Puerto 22724d06b4 DroppedEvent uses EntityUid exclusively 2021-11-09 15:05:49 +01:00
Vera Aguilera Puerto 48f8dd2284 ActionBlocker CanInteract uses EntityUid exclusively
ActionBlockerSystem fully uses EntityUid now!
2021-11-09 15:05:49 +01:00
Vera Aguilera Puerto b6337ffe7a Makes many things use OwnerUid instead of Owner.Uid 2021-11-09 15:05:49 +01:00
Javier Guardia Fernández af579b15cc
Update to .NET 6 and C# 10 (#5233)
Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>
2021-11-09 15:05:07 +01:00
Vera Aguilera Puerto 29f3d2d1ca ActionBlocker CanSweat uses EntityUid exclusively 2021-11-09 13:52:27 +01:00
Vera Aguilera Puerto cc9ae191a8 ActionBlocker CanShiver uses EntityUid exclusively 2021-11-09 13:51:15 +01:00
Vera Aguilera Puerto cba96ad830 ActionBlocker CanUnequip uses EntityUid exclusively 2021-11-09 13:46:48 +01:00
Vera Aguilera Puerto a69387d741 ActionBlocker CanEquip uses EntityUid exclusively 2021-11-09 13:45:21 +01:00
Vera Aguilera Puerto 9921801f15 ActionBlocker CanPickup uses EntityUid exclusively 2021-11-09 13:43:39 +01:00
Vera Aguilera Puerto b82cb38bf9 ActionBlocker CanEmote uses EntityUid exclusively 2021-11-09 13:41:24 +01:00
Vera Aguilera Puerto d4ded87448 ActionBlocker CanAttack uses EntityUid exclusively 2021-11-09 13:40:27 +01:00
Vera Aguilera Puerto 51e785c0fd ActionBlocker CanDrop uses EntityUid exclusively 2021-11-09 13:23:53 +01:00
Vera Aguilera Puerto 190612a350 ActionBlocker CanSpeak uses EntityUid exclusively 2021-11-09 13:21:59 +01:00
Vera Aguilera Puerto c051b1e056 ActionBlocker CanUse uses EntityUid exclusively 2021-11-09 13:21:59 +01:00
Vera Aguilera Puerto 5f9cfaac43 ActionBlocker CanMove uses EntityUid exclusively 2021-11-09 13:15:55 +01:00
Vera Aguilera Puerto 1f9e1c033f EntityWhitelist uses EntityUid 2021-11-09 13:08:09 +01:00
Vera Aguilera Puerto 5d66a08ac9 GasCanisterSystem cleanup, use EntityUid more. 2021-11-09 13:00:08 +01:00
Vera Aguilera Puerto 11c63112d1 TabletopSystem uses EntityUid 2021-11-09 12:38:05 +01:00
Vera Aguilera Puerto c00cdbff90 GodMode code uses EntityUid 2021-11-09 12:20:02 +01:00
Vera Aguilera Puerto e5c062559a MobStates use EntityUid 2021-11-09 12:15:12 +01:00
Vera Aguilera Puerto 5cec5c421c ActSystem and Destruction Threshold Behaviors use EntityUid. 2021-11-09 12:06:00 +01:00
Vera Aguilera Puerto c5fda6daca IReagentEffect and some chemistry stuff uses EntityUid 2021-11-09 11:51:24 +01:00
Vera Aguilera Puerto 222541f1a2 Fix AnchorableSystem resolve warnings 2021-11-09 11:51:24 +01:00
Vera Aguilera Puerto 36e1d0707a AddHandCommand uses EntityUid 2021-11-09 11:34:40 +01:00
Vera Aguilera Puerto f025e5f0a8 ChatManager ChatTransform uses EntityUid 2021-11-09 11:30:59 +01:00
Vera Aguilera Puerto 1a177f7479 DrinkSystem uses EntityUid instead of IEntity 2021-11-09 11:28:27 +01:00
Vera Aguilera Puerto 0220551f72 ReagentEntityReaction uses EntityUid 2021-11-09 11:12:55 +01:00
moonheart08 40c3261665
Soft player cap that lets in only admins. (#5227)
* Soft player cap that lets in only admins.

* Update Content.Server/Connection/ConnectionManager.cs

Co-authored-by: Paul Ritter <ritter.paul1@googlemail.com>

* Update Content.Server/Connection/ConnectionManager.cs

Co-authored-by: Paul Ritter <ritter.paul1@googlemail.com>
2021-11-09 10:44:39 +01:00
Vera Aguilera Puerto fe6590bbe6
Makes Anchorable ECS. (#5222) 2021-11-09 18:08:30 +11:00
mirrorcult 31d622f941
Metabolism 3.0 (#5157)
* basic system + convert all plantmetabolism

* stragglers

* convert all old metabolisms over

* fix YAML errors + dumb serialization issue

* remove unused thingy

* reimplement

* add organ type condition

* organtype condition but real

* cleanups + test fix

* metabolismtype -> metabolizertype

* solution resilience

* fixes

* serializer + use entityuid + hashset

* this is apparently an entirely different thing

* turns out it just works

* oops
2021-11-08 15:33:45 -07:00
Javier Guardia Fernández f5b11d6af8
Remove IMobStateComponent (#5220) 2021-11-08 15:11:58 +01:00
Javier Guardia Fernández 4236551d86
Remove BodyDamageChangeParams and IBodyHealthChangeParams (#5219) 2021-11-08 15:08:33 +01:00
Javier Guardia Fernández ec9e65951c
Remove IHandsComponent and ISharedHandsComponent (#5218)
* Remove IHandsComponent and ISharedHandsComponent

* Copy the documentation from the interfaces

* Revert "Copy the documentation from the interfaces"

This reverts commit 7638a2d4817743d487c7b255ba3e56add77dca86.

* Perform a minute amount of cleanup
2021-11-08 15:08:24 +01:00
Vera Aguilera Puerto e6e15b3728 Replace all ITransformComponent by TransformComponent 2021-11-08 12:37:32 +01:00
mirrorcult 2d3077f560
Remove IMoveSpeedModifier in favor of events (#5212)
* Remove IMoveSpeedModifier

* fucking magboots

* yope

* rabiews
2021-11-08 16:17:35 +11:00
Leon Friedrich 3612d25539
Fix & extend add reagent verb (#4954)
* AddReagentWindow

* addReagent command

* functional UI

* fix networking

* add comments & docstrings

* Remove unecesary system

* cleanup & close-eui

* tweak default window size

* fix EUI closing error

* fix merge issues

* fix merge
2021-11-08 15:22:42 +11:00
20kdc 206f054cdf
Pulling rotation adjustment, newton's third law, entitycoordinates for moveto (#5141)
* Pulling: Piano door stuck prevention (pulling angle-snap) and getting rid of a condition causing oddities with pull-to-location

* Pulling: Implement Newton's Third Law in regards to puller/pullee physics

Weightless condition was determined not to be necessary

* Fix pull-to-position on actively rotating/moving grids + fixes for rebase
2021-11-06 19:16:49 -07:00
Swept b46957e0d8
Initial (#5193) 2021-11-06 17:32:33 -07:00
Antoine Chavasse afeb22ccb2
Prevent drag and dropping if the user is currenly unable to perform interactions. (fixes #5144) (#5196) 2021-11-06 17:05:51 -07:00
Kara D 4abda4f7cf
Fix mobs taking damage on paused maps 2021-11-06 15:18:27 -07:00
Javier Guardia Fernández 1508efff54
Add test pooling (#4961)
* Add test pooling

* WIP test pooling changes

* Fix Destructible tests

* Don't pool unpooled or dummy ticker instances

* Change ServerPathfindingDebugSystem to replace existing entries

* Fix SaveLoadSaveTest comment

* Don't pool StartTest

* Comment out global setup

* Fix puddle tests

* Move SolarPanelComponent initialize to PowerSolarSystem OnMapInit

* Update RobustToolbox

* Finish fixing tests, make test threads background threads

* Bring back pooling

* Fix nullable

* Update RobustToolbox

* Set cvars on server return

* Un-pool tests with custom cvars

* Update RobustToolbox

* Update RobustToolbox

* Change where the main tile coordinates are

* Remove DisposalUnitTest grid check

* Fix test pooling being a fickle bitch

* Fix EntitySystemExtensionsTest

* Update RobustToolbox

* Update RobustToolbox

* Make nullable pool settings true

* Update RobustToolbox

* Wait other way around

* We are unitystation now

* Update RobustToolbox

* Create global setup

* Pool some more tests

* Fix not properly disconnecting clients before restarting the round

* Give more info on ran tests

* Standardize default test cvars

* Update RobustToolbox

* Update RobustToolbox

* Pool clients

* Fix test order issue

* Fix cvars in character creation test not being set properly

* Update RobustToolbox

* Update RobustToolbox

* Rider shut

* Update RobustToolbox

* Format tests ran better

* Update RobustToolbox

* Reset RobustToolbox

* Reset RobustToolbox harder

* Fix one instance of test order causing destructible tests to fail
2021-11-06 11:49:59 +01:00
Azzy 064cea7dd6
Fixes bullet rotation (#5179)
Fixes bullets being fired from weapons at the wrong rotation
2021-11-05 21:27:46 -07:00
moonheart08 b889aff307
Make canisters dump their contents on destruction. (#5177)
* Make canisters dump their contents on destruction.

* Address reviews
2021-11-06 01:19:12 +01:00
mirrorcult 3e8f5784a1
Verb invocation command (#5148) 2021-11-05 17:48:30 +11:00
Ephememory 418e3eaef8
fix drink examine text (#5170) 2021-11-04 21:16:28 -07:00
ike709 17e1b7827e
Adds UIs for volume and pressure pumps (#5155)
* Adds UIs for volume and pressure pumps

* Update Content.Server/Atmos/Piping/Binary/EntitySystems/GasPressurePumpSystem.cs

* Update Content.Server/Atmos/Piping/Binary/EntitySystems/GasVolumePumpSystem.cs

Co-authored-by: ike709 <ike709@github.com>
2021-11-04 17:41:56 -07:00
20kdc d9cc7ef7d4
Stop pAIs from being able to wipe each other/do other odd things, pAIs name themselves after their owners (#5160)
* Stop pAIs from being able to wipe each other/do other odd things they shouldn't

* pAI: device changes name to indicate owner

* Make PAIComponent networked (just in case)

It'll be needed in future anyway
2021-11-04 15:29:16 -07:00
20kdc 9eb6e5a109
Add indicator showing amount of ghost roles available (#5150)
* Add indicator showing amount of ghost roles available

* Make the indicator turn red if ghost roles are available
2021-11-03 16:48:12 -07:00
mirrorcult 3ab4a30a0f
Generalize ReagentUnit into FixedPoint2 and use it for damage calculations (#5151)
* Damage units

* sum ext method
2021-11-03 16:48:03 -07:00
Alex Evgrashin c1cf22d97e
Pinpointer (#5131)
* Add pinpointer sprites

* Start working on pinpointer

* Updated pinpointer

* Working on visuals

* Working on a pinpointer and eye rotation

* Add client/server pinpointers systems

* Minor cleanup

* Add distance support

* Add nuke tag

* Remove redundant flag and add pinpointer to caps locker

* Disable rotation of pinpointer

* Fixed distance

Co-authored-by: Alexander Evgrashin <evgrashin.adl@gmail.com>
2021-11-03 14:35:34 -07:00
mirrorcult 3f51ffbd3c
Pneumatic cannons (#4560)
* basics & visuals

* pneumatic cannon works perf

* loc + popups

* gas tank does stuff + queue changes

* updates

* b

* forcefeeding

* inhand

* crafting!

* pie cannon now is a pneumatic cannon

* oopy

* fix for entman + verbs

* pie

* change for tools

* actual

* combat mode + better sounds

* reviews
2021-11-03 14:33:36 -07:00
Kara D 6bb1e58e77
Fix item construction using nearby anchored items (pipes) 2021-11-03 14:33:00 -07:00
moonheart08 4f58f10c77
Log the chem dispenser to server console. (#5142) 2021-11-03 15:32:32 +01:00
Leon Friedrich 673301825b
Draw depth adjustments (#5130)
* door drawdepth toggle

* git mv

* dooooors

* drawdepth adjustments

* fix door and missed projectiles

* firelock depth tweak

* Get sprite only when needed

* single letter typo

* forgot to include closing in _activeDoors.
2021-11-03 14:43:10 +01:00
ShadowCommander bfc63e2912
Add character names to round end screen and localize more of the strings (#5088)
* Add character names and move more traitor round end strings to fluent

* Change coloring and wording

* Fix no objectives
2021-11-03 14:40:32 +01:00
20kdc 7ced7b67c7
Fix barstool rotation (#5134) 2021-11-02 19:38:47 +01:00
Vera Aguilera Puerto 52bada79a3 Electrocute Command 2021-11-02 19:32:07 +01:00
Saphire Lattice f5b4e461b3
Make humans move based on their last grid's angle (#5122)
* Make humans move based on their last grid's angle

* Fix ghost movement, fix weightless grid parenting

* Make sure to init the last grid angle without needing to move
2021-11-03 00:35:02 +11:00
Vera Aguilera Puerto 5a5006e4cf
ConstructionGL2 Part 2: Better guided steps and recipes. (#5103) 2021-11-02 11:24:32 +01:00
ike709 9da98e3916
Adds a UI for gas filters (#5052)
* Adds a UI for gas filters

* Address reviews

* Update Content.Client/Atmos/UI/GasFilterBoundUserInterface.cs

* Update Content.Server/Atmos/Piping/Trinary/EntitySystems/GasFilterSystem.cs

* Fix build

Co-authored-by: ike709 <ike709@github.com>
Co-authored-by: Vera Aguilera Puerto <6766154+Zumorica@users.noreply.github.com>
Co-authored-by: Vera Aguilera Puerto <gradientvera@outlook.com>
2021-11-02 10:44:40 +01:00
20kdc 7220132be3
ChemMaster/Chemistry Dispenser constructability, fixed edition (#5125) 2021-11-02 10:04:07 +01:00
metalgearsloth 16c31ade0f Fix pointer facing 2021-11-02 16:33:27 +11:00
moonheart08 a27c1d9bd9
funny container commands (#5113) 2021-11-02 15:32:58 +11:00
Ygg01 8c81312c0c
Extractible tweak - Allow grinding and juicing (#5112) 2021-11-02 15:20:14 +11:00
Ygg01 fc5fa67a56
Refactor Resolve and IEntity in SolutionContainerSystem (#5083)
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2021-11-02 12:03:23 +11:00
20kdc 7a03f00cfd
Placeholder pAIs, ghost role rules window (#4972) 2021-11-02 11:42:04 +11:00
Fortune117 76bc00b218
Changed drinks to use ECS (#4948)
Co-authored-by: Paul Ritter <ritter.paul1@googlemail.com>
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2021-11-02 11:40:55 +11:00
Pieter-Jan Briers 059fa9ae48
Gravity generator rewrite (#4828)
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2021-11-02 11:12:55 +11:00
ShadowCommander 0e33b246db
Fix ControlMob on already controlled mob (#3868) 2021-11-02 11:11:50 +11:00
Vera Aguilera Puerto fea41c539e Add RaiseEvent action to CGL. Machines raise a MachineDeconstructedEvent.
The latter is very useful for any special machine cleanup that needs to happen when a machine is deconstructed.
The former will be useful for so many things!
2021-11-01 17:29:09 +01:00
Vera Aguilera Puerto 0f744447d0 Remove unused using statements in construction comp 2021-11-01 17:07:30 +01:00
Vera Aguilera Puerto 182a52914a Fix construction pathfinding crash on machines when going the wrong way. 2021-11-01 16:56:33 +01:00
moonheart08 1b8b5b5d16
oh god it's BQL time (#5050)
Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>
2021-10-31 21:14:44 +01:00
Saphire Lattice eb567dc0bb
DB QOL stuff, but not breaking the migrations now (#5086) 2021-10-31 15:18:01 +01:00
Paul Ritter 1240d320a2
refactors rougepointingarrow to ecs and stops it from targeting dead things (#5114)
Co-authored-by: Paul <ritter.paul1+git@googlemail.com>
2021-10-31 15:03:32 +01:00
Saphire Lattice fdf67d8ee6
Fix containment fields finding one another (#5094) 2021-10-31 14:39:36 +01:00
ike709 0865409521
Adds support for unlimited stacks (#5084)
Co-authored-by: ike709 <ike709@github.com>
2021-10-31 14:27:11 +01:00
Paul 0bbc4d9afe fixes trashbag picking up things through walls
fixes #5098
2021-10-31 14:23:26 +01:00
Vera Aguilera Puerto 3cd88b8cf2 Sync UseTool nullable broadcast events 2021-10-30 19:27:06 +02:00
Saphire Lattice 1d136bf18b
Make ban command properly give a ban message instead of a placeholder (#5087) 2021-10-29 20:54:14 +02:00
ike709 d9d101fae8
Fixes ghosts being able to use uplinks (#5085)
Co-authored-by: ike709 <ike709@github.com>
2021-10-29 18:37:34 +02:00
Pieter-Jan Briers 5c5534de9a Revert "A bit of DB model cleanup (#5016)"
This reverts commit 8a3cee9a10.
2021-10-29 16:10:58 +02:00
Saphire Lattice 8a3cee9a10
A bit of DB model cleanup (#5016) 2021-10-29 15:41:13 +02:00
20kdc 44f5f15790
Power-reading multitool (#5046)
* AMEPartComponent: Switch to ToolSystem.HasQuality because this bugs me.

* Multitool can read power when you examine a cable with the multitool held.

* Multitool power reading: Condense storage information

* power-sensing multitool: Fix ToolSystem ref.

* Power-reading multitools: Fix misuse of GetComponent
2021-10-29 14:42:18 +02:00
Ygg01 b2aca94586
Refactor Solution from Shared -> Server (#5078)
* Move entity solution entity systems to shared

* Move SolutionComponents to Server

* Fix namespaces

* Remove Networked Component.

* Fixes

* Add components to ignore list
2021-10-29 23:40:15 +11:00
20kdc bddce95e37
Switch from drainallbatteries to a drain/fill-specific-battery command for saner eventing (#5077)
* drain all batteries / drain battery command for saner eventing

* Reverts the part of the previous commit where drainallbatteries skips items, despite my better judgement

* setbatterypercent now takes the place of battery drainage commands

A more forall-oriented approach
2021-10-29 11:49:52 +02:00
Alex Evgrashin 4002aa5852
Uplink UI icons and withdraw button (#4929)
* Uplink menu has icons now

* Add item icons

* Add few descriptions

* Better withdraw window

* Finished with withdraw window

* Refactored withdraw ui and fix some bugs

* Basic withdraw

* Quick fixes

* Removed uplink listing for TCs

* Move slider to separate control

* Final touches

* A bit more

* Not again...

* Fixed names

* Address review

* Fixed robust

* Non necessary check
2021-10-29 11:40:47 +02:00
Flipp Syder c7c651e3de
Refactors TemperatureComponent and AtmosExposed to ECS (#4927)
Co-authored-by: Vera Aguilera Puerto <6766154+Zumorica@users.noreply.github.com>
2021-10-29 10:18:43 +02:00
20kdc 7cdb9dcf86
Disposals fixed under station rotation (#5067)
* Some sanity checks on disposals movement, fix the interpolator

* Technically fix disposal routing, but I'm not done here yet

* Remove disposals reliance on implicit direction sensing entirely.
2021-10-29 19:07:32 +11:00
Flipp Syder 91b4ce6f24
Adds generic damage visualizer to the game (#4893) 2021-10-29 10:04:24 +02:00
metalgearsloth 87701b50c6
Remove naughty IEntity.Dirty calls (#5069)
Really this thing should probably be internal because you should never be calling it.
2021-10-28 22:40:05 -07:00
Kara D 78005f8e9e
Fix windoors not autoclosing
Fixes #4902
2021-10-28 22:38:36 -07:00
Leon Friedrich 5dd73ff6e0
Fix emitter lock toggle (#5066) 2021-10-28 13:29:19 +02:00
Visne 94579d1877
Fix a bunch of warnings (#5058) 2021-10-28 13:19:38 +02:00
Vera Aguilera Puerto 0bca9befca Fix being able to electrocute pulled mobs when completely insulated. 2021-10-28 11:50:31 +02:00
Vera Aguilera Puerto 335c461442 Fix sync UseTool not calling ToolFinishUse when there's a DoAfter.
Fixes #5060
2021-10-28 11:21:55 +02:00
Vera Aguilera Puerto f12cec3f98 Fix construction DoAfter results not setting current edge index.
Fixes #5061
2021-10-28 11:21:55 +02:00
Vera Aguilera Puerto f840db0458 Fix bug which allowed you to build machines for free by taking the board out and putting it in again. 2021-10-28 11:07:33 +02:00
Saphire Lattice 1e7a3ff191
Fix morgue picking up pipes (#5045) 2021-10-27 23:09:10 -07:00
Leon Friedrich 49296e33a0
Refactor Context Menus and make them use XAML & stylesheets (#4768)
* XAML verb menu

* fix ghost FOV

* spacing

* rename missed "ContextMenu"->"EntityMenu" instances

* move visibility checks to verb system

* update comment

* Remove CanSeeContainerCheck

* use ScrollContainer measure option

* MaxWidth / texxt line wrapping

* verb category default

Now when you click on a verb category, it should default to running the first member of that category.

This makes it much more convenient to eject/insert when there is only a single option

* only apply style to first verb category entry

* Use new visibility flags

* FoV -> Fov

* Revert "only apply style to first verb category entry"

This reverts commit 9a6a17dba600e3ae0421caed59fcab145c260c99.

* make all entity menu visibility checks clientside

* Fix empty unbuckle category

* fix merge
2021-10-27 22:21:19 -07:00
Alex Evgrashin 2cb35fab3c
Fix light replacer and move it to ECS (#5053)
* Fixed broken replacer prototype

* Light replacer ECS
2021-10-28 13:36:09 +11:00
Visne c67160ae19
Disable warnings that would be refactored anyway (#5047) 2021-10-27 18:10:40 +02:00
metalgearsloth a12eb29464
Convert sus events to eventbus (#5044) 2021-10-27 10:53:10 +02:00
metalgearsloth 3b508b041b Remove some unused fields again-ing 2021-10-27 19:43:57 +11:00
metalgearsloth f320c6dd8f
Fix storage closing bounds on rotated grids (#5033) 2021-10-27 10:27:25 +02:00
Ygg01 14b401f9b3
Puddle refactor 2: Spillastic boogaloo (#4784)
* Refactor PuddleComponent

* Move puddle effects into separate RSIs

Basically egg/tomato/powder puddle will be moved into separate
/Textures/Fluids RSIs

* Fix YAML for puddles

* Fix issues sloth pointed out.

* Ensure Puddle Component are properly added when spawned

* Remove unnecessary method init puddle with starting maxVolume

* Addressed ElectroSr comments

* Add Resolves

* Try fix error in ensureSolution

* Puddle unanchoring

* Address some issues with puddles

* Fix continue -> return
2021-10-27 19:24:18 +11:00
Saphire Lattice 0da8a5b9d0
Fix trashbags picking up atmos entities that are anchored (#5035) 2021-10-27 18:12:36 +11:00
Alex Evgrashin 6e00104260
Powered light ECS (#5028)
* Brrrr ECS

* Create lit on powered system

* Light bulb ECS

* Finishing porting to ECS

* Minor touches

* Removed events

* Removed old comments

* Fixed test

* To popup system
2021-10-27 12:24:22 +11:00
20kdc 60b3ff59cf
Fix morgue rotation by using more EntityCoordinates (#5041) 2021-10-27 12:23:44 +11:00
Vera Aguilera Puerto d2ffabdfd4 Fix ChangeEntity collection modified exception. 2021-10-27 01:29:10 +02:00
Vera Aguilera Puerto 189a5c7847
ConstructionGL2 Part 1: ECSification, events and steps. (#5017)
- Completely rewrited the `ConstructionComponent` logic to be ECS, *without* looking too much at the original implementation.
    - The original implementation was dirty and unmaintainable, whereas this new implementation is much cleaner, well-organized and maintainable. I've made sure to leave many comments around, explaining what everything does.
- Construction now has a framework for handling events other than `InteractUsing`.
    - This means that you can now have CGL steps for things other than inserting items, using tools...
- Construction no longer uses `async` everywhere for `DoAfter`s. Instead it uses events.
- Construction event handling occurs in the `ConstructionSystem` update tick, instead of on event handlers.
    - This ensures we can delete/modify entities without worrying about "collection modified while enumerating" exceptions.
    - This also means the construction update tick is where all the fun happens, meaning it'll show up on our metrics and give us an idea of how expensive it is/how much tick time is spent in construction.
- `IGraphCondition` and `IGraphAction` have been refactored to take in `EntityUid`, `IEntityManager`, and to not be async.
- Removes nested steps, as they made maintainability significantly worse, and nothing used them yet.
- This fixes #4892 and fixes #4857

Please note, this leaves many things unchanged, as my idea is to split this into multiple PRs. Some unchanged things:
- Initial construction code is the same. In the future, it'll probably use dummy entities.
- Client-side guided steps are the same. In the future, the server will generate the guided steps and send them to clients as needed, caching these in both the server and client to save cycles and bandwidth.
- No new construction graph steps... Yet! 👀
2021-10-26 16:38:03 +02:00
metalgearsloth 9c3a603e7e Use ActionBlockerSystem as a dependency on CGSystem 2021-10-27 01:07:19 +11:00
Julian Giebel d1a830cd74
Fix ApcPowerReceiverComponent deletion (#5031)
Co-authored-by: Julian Giebel <j.giebel@netrocks.info>
2021-10-25 21:55:00 +02:00
20kdc c29b23eb64
Fix ChemMaster bottles not having contents (#5026) 2021-10-25 16:58:16 +02:00
ike709 ec92f4eef2
Adds stack splitting (#4981)
* Adds stack splitting

* Apply suggestions from code review

Co-authored-by: ike709 <ike709@github.com>
Co-authored-by: Vera Aguilera Puerto <6766154+Zumorica@users.noreply.github.com>
2021-10-25 16:36:04 +02:00
moonheart08 debd22e19c
Add select (#5003) 2021-10-25 16:23:44 +02:00
Vera Aguilera Puerto ed3bf94a3b
Electrocution. (#4958)
Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com>
2021-10-25 16:21:56 +02:00
Leon Friedrich 6e84e23ba1
Remove some functions from HandsComponent (#4937)
* remove wrapper functions

* Remove InteractionSystem wrapper functions

* remove two more functions

* add missing `using`

* clean diff
2021-10-25 18:06:12 +11:00
StStevens e621a82e65
Fire extinguisher safety (#4912)
* Moved safety into FireExtinguisherComponent.

* Fix errant find and replace

* Address reviews

Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2021-10-25 18:04:24 +11:00
mirrorcult c0ecdb09af
Slipping tweaks + remove EffectBlocker (#4955)
* Slipping tweaks + remove EffectBlocker

* mfw failed merge conflict resolution

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
2021-10-25 17:43:49 +11:00
Leon Friedrich e016fc9906
spray bottle fix (#5012)
* fix-spray

* move vapor rotation
2021-10-25 17:29:02 +11:00
metalgearsloth 0f513f64fb
Rotate DefaultGrid on round start (#4957)
* Rotate DefaultGrid on round start

Not ideal long-term but good for bugspotting short-term.

* Fix buckle test

Because gridtraversal was being triggered the pos was being fucked when moving back

* Fix buckle

* Buckle offset
2021-10-25 15:22:57 +11:00
20kdc 63dd23ad8c
Fix RCDs on space somewhat - space-wizards/space-station-14#4742 compatibility edition (#4878) 2021-10-25 14:33:49 +11:00
Julian Giebel d1e323b993
Bugfix: ExtensionCableReceiver anchoring (#5014)
Co-authored-by: Julian Giebel <j.giebel@netrocks.info>
2021-10-24 18:49:26 +02:00
metalgearsloth 5cc3f9ee30
Truncate long name / job titles for IDs (#5009) 2021-10-24 01:28:25 -07:00
E F R 3c0473dfe4
Server/MachineLinking: allow linking devices that are inside obstructions (#5010)
...like signal buttons/switches on a wall.
2021-10-24 01:21:39 -07:00
metalgearsloth a4cd222bea Don't include anchored entities for entitystorage 2021-10-24 17:10:05 +11:00
metalgearsloth 34326cfed7 Fix hypospray
Another casualty in the solution wars.
2021-10-24 16:54:08 +11:00
Alex Evgrashin 7de1ebbd77
Move RCD to ECS (#4742)
* Moved ammo to ecs

* Moved RCD to ecs

* Replaced RCDDeconstructWhitelist with Tag

* Updated new structures RCDDeconstructWhitelist

* Queue delete
2021-10-24 14:34:00 +11:00
E F R c5dd6c8b02
Server/Storage: allow specifying a radius for _areaInsert (#5001)
️ Pay no attention to the changes in trashbag.yml... they are merely an
illusion... ️

t. 🧙‍♂️
2021-10-23 19:34:29 -07:00
Leon Friedrich 610f45e5cd
fix ghost component (#5000) 2021-10-23 19:29:38 -07:00
moonheart08 86e2f2005e
Allows placing cables on lattices. (#4984)
Adds a "sturdy" tile flag, that in the future could be used by construction/etc to figure out if it's safe to build on a tile. (For example water isn't space, but it's not a sturdy building surface!)
2021-10-23 17:32:33 -07:00
Julian Giebel 45caf25ea9
Apc device network and apc based light switch (#4908)
* Remove WireNet node group from cables
Implement extension cable components and system
Remove connection over distance logic from ApcPower... components

* Add extension cable components to prototypes

* Implement ApcNetwork
Implement ApcNetSwitch

* Fix ignoredComponents.cs

* Add friend attribute to new components

* Add construction graph for a light switch

* Address reviews

* Fix broken test

* Move ConnectionType enum to DeviceNetworkComponent
Change netId data definition to use the ConnectionType enum values

Co-authored-by: Julian Giebel <j.giebel@netrocks.info>
2021-10-23 16:23:19 -07:00
ShadowCommander e7f352d6c2
Fix barotrauma damage total failing when damageable doesn't have the value 2021-10-23 12:16:08 -07:00
ShadowCommander 6c1ba187e3
Add maximum to barotrauma damage (#4989) 2021-10-23 11:45:57 -07:00
moonheart08 89bbb71f75
ForAll command! (#4982)
* ForAll command!
Implements "Bad Query Language", which has a few specifiers you can use for badminning, namely:
named <regex>
prototyped <prototype name>
with <component name>
tagged <tag name>
parented_to <parent entity uid>

For example: forall prototyped MobHuman parented_to 855 do explode $WX $WY 1 1 1 1; addcomp $ID Item

* oops

* fix a silent parsing bug, make parser louder.

* cleanup

* rename shit
2021-10-23 19:15:40 +02:00
Vera Aguilera Puerto 328b3b2b6a Fix scrubber math 2021-10-23 13:05:03 +02:00
Vera Aguilera Puerto 0deaa9e18c Fix pill swallowing popup loc. 2021-10-23 10:59:53 +02:00
Vera Aguilera Puerto a29bc600b7 Fix exception when observer tries to take over GhostTakeoverAvailable mob that has a mind.
That method is essentially a `TryTake` method, why would it throw instead of returning false...
2021-10-23 10:56:55 +02:00
Vera Aguilera Puerto dad471562d Singularity plays collapsing sound on shutdown, not on remove. 2021-10-23 10:49:59 +02:00
Vera Aguilera Puerto eaaeefb74b Fix yet another exception with CableTerminalNode for the same dumb reason 2021-10-22 23:50:14 +02:00
Vera Aguilera Puerto cb2c044c08 Fix exception with CableTerminalPortNode assuming an entity's GridID can never be zero. 2021-10-22 23:46:30 +02:00
E F R 85f2fcb86b
Content/Light: make lights actually require power after changing the lightbulb (#4953) 2021-10-22 08:46:22 +02:00
E F R 5b531b7dcf
Content.Server: use LocalPositon instead of Coordinates.Position (#4951) 2021-10-22 08:45:36 +02:00
Alex Evgrashin a3f16295ea
Move Access to ECS (#4826)
* Moved access to ecs

* Fixed tests

* Moved test to integration

* Better IoC

* Moved preset ID card

* Moved id card to ECS

* Moved access component to ECS

* Fixed pda access

* Final touches

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
2021-10-22 13:31:07 +11:00
Vera Aguilera Puerto bfdd0e055b Fixes bad Flammable ECS conversion logic 2021-10-21 23:07:42 +02:00
metalgearsloth 7beb363285
Deprecate a bunch of IActionBlocker (#4852)
* Deprecate IActionBlocker ChangeDirectionAttempt

* Woops

* Throw and interact

* Deperacte speech

* ActionBlocker in fucking shambles

* CanEmote go byebye

* CanAttack is GONE

* IActionBlocker finally ded

* DRY
2021-10-21 13:03:14 +11:00
Fortune117 55249e3688
Add Overdosing Behaviour to Meth (#4949)
* Added debug bottle of meth as well as a damage increase on a Reagent Threshold

* fix for metabolism getting funked when there is a failed reaction condition

* removed max, raised minimum to 10

* reduced regular meth damage, increased overdose damage
2021-10-20 13:30:55 -07:00
Javier Guardia Fernández 3e5a856948
Make DisposalUnitComponent.TryInsert ECS (#4959) 2021-10-20 21:12:23 +02:00
20kdc 6fb968d47f
Set default Pow3r ramp rate/tolerance values (#4748) 2021-10-20 20:31:53 +02:00
E F R 5a03c0eca8
Storage: fix Storage insert anim with _quickInsert or _areaInsert set (#4877)
Turns out the final position calculations were wrong, so I copied/pasted
from the equivalent parts of the Hands components.

Unfortunately, this means that picking up trash with a trash bag no
longer causes said trash to rapidly zoom to 0,0.
2021-10-20 15:25:22 +02:00
E F R 0ab6ca9a12
Content/Atmos: add status info to binary devices' examine text (#4928) 2021-10-19 23:46:31 +02:00
Vera Aguilera Puerto f2fc1431aa Ignore component on client. 2021-10-19 21:15:23 +02:00
20kdc 7ccf9668d4
Varied and semi-sprited atmos markers (#4944) 2021-10-19 21:07:47 +02:00
20kdc 6c6bde8743
FoodComponent solution un-hardcoding, rehydratable solution name fixes, monkey cubes edible again, slicable food preserves poisons (#4942) 2021-10-19 00:13:43 -07:00
mirrorcult 636a04eccd
Armor (#4934)
* Armor

* radiation tweaks

* asphyxiation ignore resistances
2021-10-18 16:24:37 -07:00
Vera Aguilera Puerto b904efb942
Makes many thing that update on paused *not* do that. (#4938) 2021-10-18 23:58:34 +11:00
20kdc 1a4316c4cc
Fix pipe rotation. (#4939) 2021-10-18 13:42:30 +02:00
Vera Aguilera Puerto 1b84ee05ae Don't update solar panels while the map is paused
Fixes integration tests.
2021-10-18 13:14:37 +02:00
metalgearsloth cfc6ed065e
Remove PilotComponent when someone stop piloting (#4922) 2021-10-17 14:33:12 +02:00
20kdc c95c5e02c2
fixgridatmos blockers (#4911)
* FixGridAtmos blocker

* FixGridAtmos blockers in Saltern
2021-10-17 14:32:17 +02:00
Vera Aguilera Puerto 3001ea38cc
Add-d-ds s-s-stut-ttering t-to the g-gam-me (#4901) 2021-10-17 01:23:31 +02:00
moonheart08 f1ad199dca
MAPS IN ATMOS (#4909)
* COLORIZE!

* ATMOS!

* FUCK

* fix occluders. also supply rates snuck in, broken serv3.
2021-10-17 01:11:06 +02:00
Flipp Syder 7dc6b95a10
Moves HumanoidAppearanceComponent to ECS (#4855)
* Moves HumanoidCharacterAppearance to ECS

* Makes HumanoidAppearanceSystem work over networks

* Makes HumanoidAppearanceSystem more efficient

* Cleans up the files

* Updates privacy on a couple of functions

* Fixes a few using references, renames a file

* Makes HumanoidAppearanceSystem more cleaner

* Fixes Magic Mirror

* Cleanup

* HumanoidAppearanceComponent now has a friend

SharedHumanoidAppearanceSystem is only allowed to act on this, now

* Fixes the Body-HumanoidAppearance ECS scaffolding

* a little cleanup never hurt anybody

* quick fix for magic mirror appearance access

* Replaces a networked event with a local one

This one was... causing bugs
2021-10-17 00:28:02 +02:00
moonheart08 f69575e15a
ok saving pipes now works (#4906)
* ok saving pipes now works

* EW HACKS
2021-10-16 13:40:21 -07:00
Watermelon914 4bf8a5d527
Adds hand labelers (#4903)
* Adds hand labelers

* Removes unnecessary thing

* Docs

* Reverts some changes

* Addresses comments and adds inhand sprites

* Addressed comments

Co-authored-by: Watermelon914 <3052169-Watermelon914@users.noreply.gitlab.com>
2021-10-16 13:34:05 -07:00
ShadowCommander 9da81ea85f
Add GhostRadio to allow ghosts to hear radio messages (#4896)
* Add GhostRadio to allow ghosts to hear radio messages

* Add GhostRadio to ignored components
2021-10-16 12:04:35 -07:00
ShadowCommander dae3ed3006
Fix chemmaster UI and eating pills (#4900) 2021-10-16 14:56:20 +02:00
mirrorcult ae1ce0b31c
Status effect refactor (#4868)
* Oops! All Changes In One Commit

* try desperately to fix prediction issues and fail

* oops

* test

* actually fixes prediction issues

* port jittering to status effect

* default merge behavior + alert cooldown stuff

* silly test issue

* zabloing

* address reviews
2021-10-15 23:45:04 +02:00
Alex Evgrashin ce0b73ef62
Description for Uplink UI (and preset uplinks) (#4870)
* testing decription textlabel

* Move uplink listing to a new menu

* Add search bar

* Added description

* Added radio uplink

* Added preset uplinks

* Minor fix

* Fixed comma
2021-10-15 12:49:59 +02:00
Kara D ca90025005
Hotfix light switches not working 2021-10-14 21:16:11 -07:00
metalgearsloth c40eaa52fc
Fix doors on rotated grid (#4874) 2021-10-15 14:04:23 +11:00
20kdc 41256cc84e
Radiation pulse damage reduction (#4872) 2021-10-14 18:02:07 +00:00
Vera Aguilera Puerto 1df8402c17 Fix rare exception when CableVis tries to update an entity not on a valid grid. 2021-10-14 11:12:54 +02:00
Vera Aguilera Puerto 787aa24656 Add linter support for TimedSpawnerComponent, fix linter errors. 2021-10-14 11:09:26 +02:00
Pieter-Jan Briers 7f3d064ec4 Fix character slot deletion on postgres.
Fixes #4860
2021-10-13 21:11:20 +02:00
Pieter-Jan Briers d0472998a6 Fix restartroundnow.
Fixes #4863
Fixes #4861
2021-10-13 20:46:45 +02:00
moonheart08 9250bd62cb
Admin shuttle call button (#4859)
* shuttle call ui

* shuttle call ui

* Localize shuttle commands better.

* localization fix
2021-10-13 10:15:28 -07:00
metalgearsloth 2f3914e01e
Use Uid for standingstate methods (#4856) 2021-10-13 09:58:18 +02:00
JasperJRoth cd91e6c06b
Crayon fix (#4848)
* removed line that broke crayon decals

* Removed rotation from crayon decals.
2021-10-12 23:56:35 -07:00
metalgearsloth 07303e7a4b Remove some more unused fields 2021-10-13 17:38:20 +11:00
20kdc e144bb53f5
Fold Produce's "produce" solution into the "food" solution to fix empty food (#4837)
One of these was going to have to be folded into the other for it to work.
I am starting to really hate this refactor.
Note that this might still leave smokable tampering broken if it was already broken, but it shouldn't break it if it wasn't.

TESTED: Grown apples, carrots, something I forgot, bananas, *client crash due to slipping*
2021-10-12 10:01:23 +02:00
moonheart08 f70983e2d5
BANG (#4839)
* BANG

* how did that ever work in the first place
2021-10-11 22:11:09 -07:00
Kara D f3993be925
fixes #4736 2021-10-11 15:23:45 -07:00
Kara D fc46ff305c
fix gas loc 2021-10-11 15:08:21 -07:00
Julian Giebel a6f2c21919
Device network as ecs (#4205)
* Work on DeviceNetworkSystem

* Implement device networking as ecs
Remove mailing unit code for now
Remove device network metadata

* Implement integration tests for device networking

* Remove manual updating DeviceNetworkSystem and use WaitRunTicks

* Fix wrong component name in ignored components

* Apply suggestions from code review

Co-authored-by: mirrorcult <notzombiedude@gmail.com>

* Rename NetworkUtils to DeviceNetworkConstants
Change connection type constants to enum
Remove create function from network payload class

* Change broken nodegroup check in wirenet to grid check

* Change ComponentManager to entity manager in DeviceNetworkSystem

* Fix smaller mistakes

* Wtf random test fail pls run them again smh

* Fix DataField in DeviceNetworkComponent

* Fix yaml in DeviceNetworkTest

* Fix DeviceNetworkComponent DeviceNetId property

Co-authored-by: Julian Giebel <j.giebel@netrocks.info>
Co-authored-by: mirrorcult <notzombiedude@gmail.com>
2021-10-11 14:41:18 -07:00
Vera Aguilera Puerto 4c80fb9586
Refactor AccentManager to be an entity system, makes accents ECS. (#4825) 2021-10-11 11:18:39 -07:00
Vera Aguilera Puerto 2fe5db9498 Fixed airlocks not autoclosing anymore.
AutoClose is true by default now.
2021-10-10 15:58:17 +02:00
Vera Aguilera Puerto 6eee256b11
Refactors stunnable to be ECS. (#4819)
Also cleans up StandingStatesystem.
2021-10-10 12:47:26 +02:00
mirrorcult 9b4e495c95
Blast doors & shutters (#4822) 2021-10-10 12:43:50 +02:00
Vera Aguilera Puerto 6247299c84 Fix AI Reachable CanAccess exception when target is not on a valid grid. 2021-10-10 10:56:59 +02:00
metalgearsloth f0f7cd0e76
Update content for physics query namespace change (#4701) 2021-10-10 14:18:19 +11:00
Vera Aguilera Puerto e534e555c1 Removes jitter when (de)activating a stunbaton. 2021-10-09 21:20:54 +02:00
moonheart08 9f0c3daa65
Restart round vote now correctly shows round end screen. (#4817) 2021-10-09 20:18:20 +02:00
moonheart08 d8be2ef784
Makes announcements a +ADMIN command instead of a +FUN command. (#4815) 2021-10-09 18:36:52 +02:00
mirrorcult fe2298378d
Add verb to reset rotation of rotatable entities (#4807) 2021-10-09 18:23:34 +02:00
Vera Aguilera Puerto 67fd509c9f
Adds jittering. (#4809)
Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>
2021-10-09 17:30:04 +02:00
20kdc 4f5cbb63de
Paper Visualizer (#4811) 2021-10-09 15:48:53 +02:00
moonheart08 f635909d4e
Admin announcement panel. (#4803) 2021-10-09 10:54:27 +02:00
metalgearsloth b888b1fd9c
Enable shuttle rotation (#4798)
* Enable shuttle rotation

* Tweaks
2021-10-09 01:55:10 +02:00
Alex Evgrashin df3b766139
Telecrystals (and a bit more ECS) (#4775) 2021-10-08 12:26:42 +02:00
moonheart08 cf8ec622fd
Normalizes the permissions of some commands. (#4796) 2021-10-08 09:41:30 +02:00
moonheart08 b9329d59b8
Doors no longer have murderous intent (#4799) 2021-10-08 09:37:17 +02:00
Vera Aguilera Puerto 5c5c1a8288 Fix Wires having the wrong quality for opening the panel.
Fixes #4795
2021-10-08 08:40:39 +02:00
Vera Aguilera Puerto 0b57420d6e ToolSystem UseTool doesn't log missing components, slight cleanup for things using tools. 2021-10-07 23:08:16 +02:00
Vera Aguilera Puerto 6b73b89617 Anchorable checks for ToolComponent in Valid method. 2021-10-07 22:57:35 +02:00
Swept 6b474c75f8
Renames all mob IDs from stupid old format (#4789) 2021-10-07 18:59:59 +00:00
Vera Aguilera Puerto ef45db6811 Remove atmos assert, fix GridRevalidate adding virtual space tiles to list of active tiles on grid. 2021-10-07 16:51:36 +02:00
Vera Aguilera Puerto 365c7da4dc
Makes tools and welders ECS, add ToolQualityPrototype. (#4741) 2021-10-07 13:01:27 +02:00
20kdc b3f43509d1
Basic AHelp Panel, Ported & Fixed (#4776)
* Graft from https://github.com/space-wizards/space-station-14/pull/3049

* 'openahelp' command

* Add AHelp into escape menu

* Add a way to ahelp a player from the kick window

* bwoink: XAMLify, bugfix, etc.

* Rename the kick/bwoink window the Player Actions Panel

* Add the bwoink sound y'all know and love

adminhelp.ogg taken from d775e1ac80/sound/effects/adminhelp.ogg
 (available in master, therefore see master license: "All assets including icons and sound are under a Creative Commons 3.0 BY-SA license unless otherwise indicated.")
 "Changed the adminhelpsound to some creative commons sound I pinched. Until somebody can get a better one. I'm sick of MAAAAAAAAOOOOOOW."
 Actual source is https://freesound.org/people/martian/sounds/19261/ (CC0)
 The sound had been reversed and the volume altered.

* Actually play the bwoink sound on receiving an ahelp that you didn't send
2021-10-06 17:25:27 +02:00
Ygg01 4eac32bd32
Change Offset to take AtmosDirection instead of Direction (#4778) 2021-10-06 15:02:50 +02:00
Vera Aguilera Puerto a45de34f6f ItemCabinet UpdateAppearance doesn't log warnings for missing components. 2021-10-06 15:00:44 +02:00
Vera Aguilera Puerto 419edc710d
Various improvements to job greetings. (#4777) 2021-10-06 22:51:11 +11:00
Vera Aguilera Puerto 1f72435263 Fix ghosts having empty names under certain conditions.
Fixes #4731
2021-10-06 11:56:16 +02:00
Vera Aguilera Puerto 94a29978b5 Fix being able to trap aghosts in lockers.
This ain't an ideal fix, I'll admit. But it's better than nothing.
Fixes #4767
2021-10-06 11:45:52 +02:00
Vera Aguilera Puerto d16c299af1 PlaceableSurfaceSystem uses resolves. 2021-10-06 11:40:05 +02:00
Leon Friedrich 6f50dd2f7b
Make ItemCabinet use ItemSlots (#4771)
* pda slot names

* cabinets use item slots

* fix yaml

* fix tests
2021-10-05 14:55:45 -07:00
Leon Friedrich eb5f447e7a
fix lock system interact handle (#4772) 2021-10-05 09:02:03 -07:00
Vera Aguilera Puerto 0cb34858f8 Check if entity has FlammableComponent befor calling Extinguish on Rejuvenate. 2021-10-05 11:14:44 +02:00
Vera Aguilera Puerto 359b4b866d Fix exception when CableDeviceNode is not on a grid. 2021-10-05 09:51:23 +02:00
Leon Friedrich 6cb58e608b
ECS verbs and update context menu (#4594)
* Functioning ECS verbs

Currently only ID card console works.

* Changed verb types and allow ID card insertions

* Verb GUI sorting and verb networking

* More networking, and shared components

* Clientside verbs work now.

* Verb enums changed to bitmask flags

* Verb Categories redo

* Fix range check

* GasTank Verb

* Remove unnecessary bodypart verb

* Buckle Verb

* buckle & unbuckle verbs

* Updated range checks

* Item cabinet verbs

* Add range user override

* construction verb

* Chemistry machine verbs

* Climb Verb

* Generalise pulled entity verbs

* ViewVariables Verb

* rejuvenate, delete, sentient, control verbs

* Outfit verb

* inrangeunoccluded and tubedirection verbs

* attach-to verbs

* remove unused verbs and move VV

* Rename DebugVerbSystem

* Ghost role and pointing verbs

* Remove global verbs

* Allow verbs to raise events

* Changing categories and simplifying debug verbs

* Add rotate and flip verbs

* fix rejuvenate test

* redo context menu

* new Add Gas debug verb

* Add Set Temperature debug verb

* Uncuff verb

* Disposal unit verbs

* Add pickup verb

* lock/unlock verb

* Remove verb type, add specific verb events

* rename verb messages -> events

* Context menu displays verbs by interaction type

* Updated context menu HandleMove

previously, checked if entities moved 1 tile from click location.

Now checks if entities moved out of view.

Now you can actually right-click interact with yourself while walking!

* Misc Verb menu GUI changes

* Fix non-human/ghost verbs

* Update types and categories

* Allow non-ghost/human to open context menu

* configuration verb

* tagger verb

* Morgue Verbs

* Medical Scanner Verbs

* Fix solution refactor merge issues

* Fix context menu in-view check

* Remove prepare GUI

* Redo verb restrictions

* Fix context menu UI

* Disposal Verbs

* Spill verb

* Light verb

* Hand Held light verb

* power cell verbs

* storage verbs

and adding names to insert/eject

* Pulling verb

* Close context menu on verb execution

* Strip verb

* AmmoBox verb

* fix pull verb

* gun barrel verbs

revolver verb
energy weapon verbs
Bolt action verb

* Magazine gun barrel  verbs

* Add charger verbs

* PDA verbs

* Transfer amount verb

* Add reagent verb

* make alt-click use ECS verbs

* Delete old verb files

* Magboot verb

* finalising tweaks

* context menu visibility changes

* code cleanup

* Update AdminAddReagentUI.cs

* Remove HasFlag

* Consistent verb keys

* Remove Linq, add comment

* Fix in-inventory check

* Update GUI text alignment and padding

* Added close-menu option

* Changed some "interaction" verbs to "activation"

* Remove verb keys, use sorted sets

* fix master merge

* update some verb text

* Undo Changes

Remove some new verbs that can be added later

undid some .ftl bugfixes, can and should be done separately

* fix merge

* Undo file rename

* fix merge

* Misc Cleanup

* remove contraction

* Fix keybinding issue

* fix comment

* merge fix

* fix merge

* fix merge

* fix merge

* fix merge

* fix open-close verbs

* adjust uncuff verb

* fix merge

and undo the renaming of SharedPullableComponent to PullableComponent. I'm tired of all of those merge conflicts
2021-10-04 20:29:03 -07:00
20kdc 2a8486a384
Pullability partial ECS refactor, monkey-gibbing error fix (#4695)
* Migrate lots of pulling logic out of the components and clean it up

* It's buggy, but move more code out of the pullable component

* Pulling system now throws less errors than it did before the refactor

* Finally finish the big parts of refactoring pullability

* Pulling: Handle disconnect properly if the pull joint has been removed by physics shutdown

* Port 2b68449328 to this branch

* Changes as per PR reviews

* Port e801ffac45 (SharedJointSystem) and fix issues encountered during testing

SharedJointSystem.

Also, MinLength and Stiffness appear to have suddenly gained enough meaning that pulling is broken unless they're set.
2021-10-04 17:10:54 +02:00
20kdc ecbf8621a7
Make radiation storms occur at least somewhat near the station (Revision 3: LocalBounds) (#4745)
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2021-10-03 18:26:45 -07:00
20kdc 2b67a22485
Stop casting AME energy into int because it underflows. (#4762) 2021-10-03 17:58:54 -07:00
metalgearsloth c8193ef393 Fix master 2021-10-04 01:29:50 +11:00
Vera Aguilera Puerto 3e2a8738a9
PopupSystem now uses Filter methods for getting players from entities. (#4751) 2021-10-03 16:15:15 +02:00
Paul Ritter 6fdb364497
Admin overlay (#4728)
* adds admin overlay

* fixes things
2021-10-03 13:34:36 +02:00
20kdc b114f4a523
Update UI when the AME node group is changed, fix AME connection issues (#4750)
* Update UI when the AME node group is changed (fixes core count indicator being wrong)

* Fix connection issues between AME controller and cores

* Fix #4365 by properly propagating and clearing AME core injection state

* Fixes #4364
2021-10-03 13:33:28 +02:00
Galactic Chimp 61f1c8a05c
#3898 open sprite field for drink comp (#4235)
* temp

* #3898 some progress on DrinkCanVisualizer

* Fixed implementation

* Moved drink can sprite layer definition to abstract parent

* Added open drink can sprites

* #3898 - fixes for drink cans' sprite field after merge + moved UpdateAppeareance from DrinkComponent to DrinkSystem

* Update Content.Server/Nutrition/EntitySystems/DrinkSystem.cs

* #3898 removed obsolete comment

Co-authored-by: Javier Guardia Fernández <DrSmugleaf@users.noreply.github.com>
2021-10-03 15:56:29 +11:00
20kdc bae033d6c3
Ghosts are now spawned specifically via map coordinates (#4747)
Ought to fix #3987 and ghost blackscreen
2021-10-03 15:51:23 +11:00
metalgearsloth 734bfb4fad Fix meteorswarm 2021-10-03 15:31:03 +11:00
Alex Evgrashin e5df8dbee3
Moving PDA to ECS (#4538)
* Moved pen slot to separate component

* Moved it all to more generic item slot class

* Add sounds

* Item slots now supports many slots

* Some clean-up

* Refactored slots a bit

* Moving ID card out

* Moving pda to system

* Moving PDA owner to ECS

* Moved PDA flashlight to separate component

* Toggle lights work through events

* Fixing UI

* Moving uplink to separate component

* Continue moving uplink to separate component

* More cleaning

* Removing pda shared

* Nuked shared pda component

* Fixed flashlight

* Pen slot now showed in UI

* Light toggle now shows correctly in UI

* Small refactoring of item slots

* Added contained entity

* Fixed tests

* Finished with PDA

* Moving PDA uplink to separate window

* Adding-removing uplink should show new button

* Working on a better debug

* Debug command to add uplink

* Uplink send state to UI

* Almost working UI

* Uplink correcty updates when you buy-sell items

* Ups

* Moved localization to separate file

* Minor fixes

* Removed item slots methods events

* Removed PDA owner name

* Removed one uplink event

* Deleted all uplink events

* Removed flashlight events

* Update Content.Shared/Traitor/Uplink/UplinkVisuals.cs

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>

* Update Content.Server/Containers/ItemSlot/ItemSlotsSystem.cs

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>

* Update Content.Server/Containers/ItemSlot/ItemSlotsSystem.cs

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>

* Update Content.Server/GameTicking/Presets/PresetTraitorDeathMatch.cs

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>

* Item slots system review

* Flashlight review

* PDA to XAML

* Move UplinkMenu to seperate class, fix WeightedColors methods

* Move UI to XAML

* Moved events to entity id

* Address review

* Removed uplink extensions

* Minor fix

* Moved item slots to shared

* My bad Robust...

* Fixed pda sound

* Fixed pda tests

* Fixed pda test again

Co-authored-by: Alexander Evgrashin <evgrashin.adl@gmail.com>
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: Visne <vincefvanwijk@gmail.com>
2021-10-03 15:05:52 +11:00
20kdc eb82dd3dae
Fix #4070, Visualizer Edition (#4730)
* Transform the Cloning Pod visualizer into a generic enum visualizer for simple cases like it

...I find it helpful at times like these to remind myself that our true enemy is
code. Code is what makes our programs run and generally is required for all of
these machinations to function in any way at all...

* Give the kitchen/meat spike a visualizer

* GenericEnumVisualizer: Byteify enums, switch to TryGetComponent for sprite
2021-10-02 16:43:47 -07:00
E F R 03e5c153da
atmos: fix AtmosDeviceSystem failing to join (#4746) 2021-10-02 14:03:42 -07:00
20kdc 201b1bec89
Fix time management bugs in RadiationPulseSystem (#4743) 2021-10-02 10:53:09 -07:00
Alex Evgrashin 3b9146a11d
Fix deployable barrier light toggle (#4739) 2021-10-02 16:53:20 +02:00
Vera Aguilera Puerto b5a8e21f78 Clean up LockSystem very slightly. 2021-10-02 12:00:23 +02:00
Leon Friedrich f80f252ff2
Make fuel tanks explodey again (#4670)
* make fuel tanks explodey again

* tanks now take damage from lit welders,
2021-10-02 11:42:46 +02:00