Commit Graph

6193 Commits

Author SHA1 Message Date
beck-thompson 6ff6cf47be Add voice locks to various hidden syndicate items (#39310) 2025-11-23 15:22:23 -06:00
Princess Cheeseballs bcc9623129 Crawling Fixes 1: Dragons and Borgs can't do the worm. (#39084)
* Init Commit

* Remove unused code, fix stun visuals bug

* Update Content.Shared/Stunnable/SharedStunSystem.cs

* Some initial changes

* first batch of changes

* Commit

* One line cleanup

* KnockdownStatusEffect ain't worth it.

* Fix 2 bugs

* Fixes

* Remove that actually,

* Commit

* Better solution

* Alright final commit I think

* Add better remarks

* How the fuck did this not get pushed???

* Wait no why was my ryder trying to push that??? I didn't make that change! DON'T DO THAT!!!

* Review

* Don't log that

---------

Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
2025-11-23 15:22:22 -06:00
Nemanja d3da9ee7ec Network StationMember properly (#39509) 2025-11-23 15:22:22 -06:00
Princess Cheeseballs 2956229461 Fix: Water Bottles Verb Priority and Prediction (#39482)
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
2025-11-23 15:22:22 -06:00
deltanedas caab6744c8 fix mind role filter (#39499) 2025-11-23 15:22:22 -06:00
Princess Cheeseballs 03ffd9c959 Fix Whoopie Cushions from lagging the game. (#39194) 2025-11-23 15:22:22 -06:00
Princess Cheeseballs eb0f776ed1 Crawling Bugfix: Don't drop items when falling. (#39168)
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
2025-11-23 15:22:22 -06:00
Vanessa 49db8b9939 We're not fucked anymore :) 2025-11-23 15:22:21 -06:00
Vanessa 96bebbf41e DeltaV Stun, Paralyze, and Slowdown updates 2025-11-23 15:22:21 -06:00
Princess Cheeseballs 60cee5b245 Stunnable New Status and Cleanup (#38618)
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
Co-authored-by: pa.pecherskij <pa.pecherskij@interfax.ru>
2025-11-23 15:22:21 -06:00
Princess Cheeseballs ef6963e76d Crawling Fixes Part 5: Holy Fuck (#39109)
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
2025-11-23 15:22:21 -06:00
Princess Cheeseballs 0ae49faa22 Crawling Fix 3: OOPS!!! (#39089)
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
2025-11-23 15:22:21 -06:00
Princess Cheeseballs 1d0af70980 Crawling Fixes 2: Salvage Nerf (NPCs can shoot downed targets) (#39085)
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
2025-11-23 15:22:21 -06:00
Vanessa c77c0b5f21 Tore out the old SharedLayingDownSystem and replaced all references with Wizden's crawling system 2025-11-23 15:22:21 -06:00
Princess Cheeseballs e442b8d9f3 Crawling Part 1: The Knockdownening (#36881)
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
Co-authored-by: ScarKy0 <scarky0@onet.eu>
2025-11-23 15:22:21 -06:00
chromiumboy 1cab2803af Sentry turrets - Part 8: AI notifications (#35277) 2025-11-23 15:22:21 -06:00
deltanedas 8555a14f87 make objectives use yml defined mind filters (#36030)
* add MindHasRole whitelist overload

* add mind filters framework

* add different mind filters and pools

* update traitor stuff to use mind filters

* line

* don't duplicate kill objectives

* g

* gs

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
Co-authored-by: ScarKy0 <scarky0@onet.eu>
Co-authored-by: SlamBamActionman <slambamactionman@gmail.com>
2025-11-23 15:22:20 -06:00
Nemanja 6a02c97cff Move some Station methods into shared (#38976) 2025-11-23 15:22:20 -06:00
slarticodefast f1222f8408 give paused maps from polymorph and cryostorage a name (#39453) 2025-11-23 15:22:20 -06:00
slarticodefast c14de448b0 place stored changeling identities next to each other (#39452) 2025-11-23 15:22:20 -06:00
lolman360 c6053081d6 fixes items with complex shapes failing to insert sometimes (#38896)
* fixes item insertion bug

fixes bug where items with complex shapes would fail to insert if the item's StoredRotation wasn't a right angle

* independence from StoredRotation
2025-11-23 15:22:20 -06:00
ScarKy0 7456cac0ad Fix changeling typing indicator (#39454)
init
2025-11-23 15:22:19 -06:00
Princess Cheeseballs 6bfa31a3bd Fix Ingestion Localization Pop-ups (#39437)
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
Co-authored-by: ScarKy0 <scarky0@onet.eu>
2025-11-23 15:22:19 -06:00
Princess Cheeseballs 40057be6a7 Ingestion Bugfixes (#39436)
Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
2025-11-23 15:22:19 -06:00
Vanessa 57ca1bb31d Updated SharedMouthSystem to use new food events 2025-11-23 15:22:19 -06:00
Vanessa 294c4ed5da Updated SharedFelinidSystem to use FullyEatenEvent 2025-11-23 15:22:19 -06:00
slarticodefast 513d7ef581 Turn some implants into triggers (#39364)
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
2025-11-23 15:22:18 -06:00
Nemanja abd3e89cce Fix showvalue Ui for melee weapons (#38703)
Co-authored-by: Perry Fraser <perryprog@users.noreply.github.com>
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
2025-11-23 15:22:18 -06:00
slarticodefast c80d74cc66 Fix inventory flickering and missing InventoryTemplateUpdated event (#39379)
* fix flickering

* move InitClothing

* fix this
2025-11-23 15:22:18 -06:00
poklj 46f1c81cd0 Changeling devour and transform (#34002)
* Initial:

Create Devour componentry, preliminary identity storage and the systems
for Devouring

* I have genuinely no idea what i'm doing

- added the radial menu, it has nothing in it.

- trying to get it to populate. the event under the event is broken,
i don't know why, but apparently it's not typed right

- Added a placeholder transform

- oh also fixed up some devour stuff and moved some things around.

* Holey moley, Transform, better devour, oh my!

- Move DnaComponent into Shared because we need it for the DNA cloning

- Make Transform MOSTLY work on the LAST identity devoured.

- Fix some issues on devour that involved prediction, canceling and
Damage exeucting (Thanks Plykiya for pointing out AttemptFrequency!)

* Proper tail stealing and Damage modifier attempt

Add check to add a wagging component on the Changeling if the victim's
species Prototype had one.

attempt to add the Damage mitigation check

* MAJOR CLEANUP AND FIXES AUGH 3 DAYS!!!

- Nullspaced a clone of a victim

- fix audio using server virtualized Pvs (i hate this)

- fix the mispredicted doafters

- Clean up a wholelotta code

- utilize clone systems to clone appearances

- Move CloneAppearance from server to shared So we can actually access
it

* Examine stuff, more cleanup, Jumpsuit ripping

- make rotting prevent the action

- Add ripping of clothing (guh why is it also server)

- add some System stuff for pushing husked corpse inspection

- clean up more badcode

* Doing things properly, UI sorta kinda works.

- Utilize Relayed events for Devour checking

- Get a UI that partially works, Says the name of identities, doesn't
show their looks

- Make use of the New Dynamic BUI assignment

- commit the sin of no client prediction cause nullspace entities aren't
networked

* Got an entity for the Frontend transform

Issue with the looks

* Stick a camera into a fake mobs forehead

- Get the UI to see the net entity in pause space by using a
ViewSubscriber to get the Pvs from the initially stored identity entity

- Remove all the other parts used to try to get this to work before hand

* Raaaaadiallllllls also fix protection coefficents

- Change FancyWindow to Radial

- Fix Issue where coeffeient checking was the wrong way round

* absolutely massive cleanup, no more camera in mobs

- cleaned up event variables that are not needed

- Removed the use of a Pause space and go back to Nullspace usage

- use a PvsOverride rather than ViewSharing

- Remove old commented out code and Lots of unused code

* Fix "Ui elements" dying  on the screen

- some minor cleanup

- don't start the entities that get cloned

* ftl, cleanup, and fixing missing transform details

- add replace functionality to TypingIndicatorSystem and
BodyEmotesSystem

- add placeholder sounds and functions to TransformBodyEmotes

- add extra Pvs handling for later use

- attributions for the funny straw sound

- Sound collections for all of the sounds

- various cleanups

* Some extra cleanup

* Fix some false assumptions about TypingIndicator

- Bubbles now transfer on spawned humans rather than used humans

- Clean up YET MORE CODE

- make it so you can't eat yourself

* Oooprs, forgot to add a Husked Corpse Loc

* Missing period in the husked corpse loc

* bad devour windup placeholder

* Husking and WIP Lungs

- Husking now will be prevented from Revival fully and will change
the appearance of players

* Add finalized Sprites for actions and final meta

- add devour on and off sprites

- add transform action sprite

- Add Armblade sprite for future use

- Credit obscenelytinyshark for the sprites <3

* Remove ling lungs, Entity<> everything

- Remove the ling lungs stuff for now... body system is overly
complicated, makes my head hurt

- Switch every method to use Entity<> from Uid, Comp format

* cleanup, admin logging, WIP Roles

* Admin verb, Roundstart, gamerule stuff

- add a Admin verb to make Changelingification easy!

- Add game rule stuff for admin verb and to tell the hapless
goober how to be a changeling... sorta

- clean up parts to make VV easy... USE THE VERB!!

* Armor Coefficent Check

- Remove bespoke changeling armor check and replace it
with a generic armor coefficient query.

* move to UnrevivableComponent instead of husked

- Move UnrevivableComponent to shared

- add Analyzable and ReasonMessage to UnrevivableComponent
to give granular control of the message and whether or not it shows up
in the analyzer

- remove the check for HuskedComponent in DefibrillatorSystem

* aaaaaaa CopyComp

- Some cleanup

- make Vocal system shared

- make VocalSystem Not make more Actions than it needs

- Use some code from ChameleonProjector so we can copy components

- partially ungod method the Transform system

* Cleanup, Moving more things to CopyComp

- TransformBodyEmotes now uses CopyComp (it's a server component so i
need to tell the server to deal with it

- TypingIndicatorComponent also now uses CopyComp

- cleaned up old, now unused "replace" methods in favor of CopyComp

- BodyEmotesSystem now has a publically accessable LoadSounds to deal
with the same problem Screaming had

* WIP

* Devour Windup noise, ForensicsSystem cleanup

* Revert VocalSystem Changes

- Reverted Moving VocalSystem to shared, copy comp acomplishes it

- added component.ScreamActionEntity = null; for copy comp

* cleanup unneeded comments

* revert an accidental line removal

* Remove duplicate SharedHumanoidAppearanceSystem

* Cleanup Typo's and import Forensics components for Dna

* Some more forensics calls

* cleanup use CopyComp for now until CopyComps

* CR cleanup

* Undo some SharedHumanoidAppearanceSystem changes

* Confound these spaces

* Some Copycomp stuff and fixing some PVS override

* use the proper TryCopyComps that are merged

* Change TransformMenu with RadialWithSector

* All sounds done, Fix lack of typing indicator issue

* Updated attributions to include used sound authors

* some ftl typos and mind_role text issue

* DNA, Screaming, appearance, grammar, wagging

- reduced all of the above using ApplyComponentChanges

- Issue still remains with bodyEmotes sticking around in the UI

* Fix UI stuff, partials, entprotoid, good practices

- bunch of partials added

- UI now has a predicted message

- EntProtoID in the admin verb

- RipClothing now uses Entity<ButcherableComponent>

- husking is now optional (off by default) for testing/till we have
hivemind/when we figure out what were doing with devour

- remove TransformGrammarSet

* More CR stuff and documentation

- Make TargetIsProtected less of a meme, with a prototype
set of DamageTypes to check

- Documenation everywhere

- Move DevourEvents into its own file

* Predicted sounds and fix the comp clone list

- Made all start and stop sounds shared

- Split out the rest of the events and UI stuff into subfiles

- Fixed some Clone comp list issues where comments had -'s causing them
to be read incorrectly

* Damage cap check, Identity Shutdown cleanup, cleanup

* Sound stuff (but actually this time)

* Missed documentation

* Missed Documentation and a EntProtoId

* Remove unused dependency

* Remove a nullcheck

* Some dummy minplayers

* CR - Husked now uses a rem/ensure

* Update Actions in the Prototype

* Fixup mindswap handover

- cleanup and handover PVS on mindswap

* Fixup Missing meta from accidental "Take-theirs"

* Add the Armblade to the roundstart-role

* Cleanup, CR (everything but the UI and renames)

* missed a spot

* missed some more whitespace

* Renames

* Primary constructor and a space in these trying times

* User interface stuff for Slime transformation

* popup prediction

* Ling devour no longer makes duplicate identities

- added a key to identities to the original victim

- Add some extra clone settings

* add guard statements to OnClones

* SentOnlyToOwner additions

* fix for sound stoppage error

* Move Organ deleter into soon to be atomized husk

* clone event inventory

* mono sounds

* lower sound volume

* Fix networked sound warning

* Clone comps thing

* review

* attributions

* Fix clobbered changes

* I'm gonna weh out

- whole bunch of CR changes

* fix some very buggy git

* okay its fixed

* address most review points

* fix inventory

* we hate entityuids

* fix test and more cleanup

* move this

* fix more stuff

* fix validation and rootable

* Remove Quickswitch due to some UI quirks

* oops left out some better explanation

* remove dangling LastConsumed component fields

* fix test fail

* try this

* cleanup cloning subscriptions, add movement speed modifier

* fix slime storage

* fix cloning setting inheritance

* Add session information to transform admin logs

* slay the integration test hydra

* dwarf size

* more volume tweaks

* comments

* improve comments and unpredict deletion due to errors when shutting down the server

* fix displancement cloning

---------

Co-authored-by: ScarKy0 <scarky0@onet.eu>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-11-23 15:22:18 -06:00
Tao 440b987bbd Fun with cardboard! (#37363)
* learning???

* made card walls work, then made game unlaunchable (:

* Still broken, added notes that I thought of while in bed

* wall, door, table and chair are now bare min functional, yay

* learnt why not to web edit...

* added floors, walls and floors fully complete

* added swords, shields, armour, helmets and arrows

* added funny sound and cleanup small issues

* cleanup

* cleanup

* credited myself

* card to cardboard

* fixed licence issue and meta thingy

* adjusted arrow stam-damage

* made card carpets more regular

* simplified sprite, reduced stam damage

* formatting fixes

---------

Co-authored-by: beck-thompson <beck314159@hotmail.com>
2025-11-23 15:22:18 -06:00
Nemanja a6df796690 Miscellaneous Body Decoupling (#38958) 2025-11-23 15:22:18 -06:00
slarticodefast 77899f3688 fix repeated scale visuals removal/ensuring (#39432) 2025-11-23 15:22:18 -06:00
Princess Cheeseballs caec3e6286 Debody Food and Drink Systems, Combine Food and Drink into One System. (#39031)
* Shelve

* 22 file diff

* What if it was just better

* Hold that thought

* Near final Commit, then YAML hell

* 95% done with cs

* Working Commit

* Final Commit (Before reviews tear it apart and kill me)

* Add a really stupid comment.

* KILL

* EXPLODE TEST FAILS WITH MY MIND

* I hate it here

* TACTICAL NUCLEAR STRIKE

* Wait what the fuck was I doing?

* Comments

* Me when I'm stupid

* Food doesn't need solutions

* API improvements with some API weirdness

* Move non-API out of API

* Better comment

* Fixes and spelling mistakes

* Final fixes

* Final fixes for real...

* Kill food and drink localization files because I hate them.

* Water droplet fix

* Utensil fixes

* Fix verb priority (It should've been 2)

* A few minor localization fixes

* merge conflict and stuff

* MERGE CONFLICT NUCLEAR WAR!!!

* Cleanup

---------

Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
2025-11-23 15:22:18 -06:00
āda 7ac1816b77 Move solution examine subscription from DrinkComponent to ExaminableSolutionComponent (#39362)
* initial it works

* clean it up

* yml

* datafield the LocIds

* move from the other branch

* no max vol on puddles and anoms

* closed

* Changes inspired by #39008

* small bug and more color range

* puddle changes and more examinable solutions

* lint

* small change

* requested changes

* un-delete

* tiny comment

* 1 less loc id in this world

* request and last second change

---------

Co-authored-by: iaada <iaada@users.noreply.github.com>
2025-11-23 15:22:17 -06:00
Kyle Tyo ce981cb86c Predict base and damage examines of cartridge ammo. (#39401)
* commit

* requested changes +
2025-11-23 15:22:17 -06:00
Kyle Tyo e04f554ced Predict EMP Examine (#39419)
* another one bites the dust

* Update Content.Shared/Emp/SharedEmpSystem.cs

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-11-23 15:22:17 -06:00
slarticodefast 7e2b405b25 fix DoAfter DistanceThreshold (#39276) 2025-11-23 15:22:17 -06:00
slarticodefast 2fefa6785d Predict PickRandom verb (#39326)
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
2025-11-23 15:22:17 -06:00
Perry Fraser f29f970c8c feat: properly perform predicted porta pottys (fix toilet prediction) (#39394) 2025-11-23 15:22:17 -06:00
slarticodefast b1c2549f88 Predict cryopods (#39385)
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
2025-11-23 15:22:17 -06:00
Perry Fraser 918baf4a4f fix: properly respect AllowRepeatedMorphs (#39411)
* fix: properly respect AllowRepeatedMorphs

* feat: add IgnoreAllowRepeatedMorphs
2025-11-23 15:22:17 -06:00
Kyle Tyo 2f6189fcf7 Predict Nav Beacon Examine (#39408)
* commit

* Update Content.Shared/Pinpointer/SharedNavMapSystem.cs

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-11-23 15:22:17 -06:00
Luxeator dc6d108a6f Add guard to unbuckling to help it to not act upon terminating entities (#39410)
* Add guard to unbuckling to help it to not act upon terminating entities

* Refactor guard for unbuckling

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Revert "Refactor guard for unbuckling"

This reverts commit bf975fbd6f5cfac45324a3d5d74e592ad17ad291.

---------

Co-authored-by: Luxeator <Luxeator>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-11-23 15:22:17 -06:00
Kyle Tyo 7196e70a67 Predict warp point location examines. (#39402)
commit
2025-11-23 15:22:16 -06:00
Ser11y e2099eec3e localization support to air alarms, wire panels and more (#39307)
* Add localization to the air alarms, wire panels, network configurator list menu and loadout window

* delete unused

* redo gas localization, delete unused

* removed the extra key

* Moved and renamed air-alarm-ui-thresholds-gas-name

* Moved localization to the XAML

* Use existing strings for gas names

* it just works

* Rename _atmosphereSystem in ScrubberControl.xaml.cs

_atmosphereSystem -> atmosphereSystem

* Rename _atmosphereSystem in SensorInfo.xaml.cs

_atmosphereSystem -> atmosphereSystem
2025-11-23 15:22:16 -06:00
Perry Fraser 71f8efa37c fix: hide timer trigger's cycle time verb if DelayOptions is empty (#39388)
fix: hide cycle time verb if DelayOptions is empty
2025-11-23 15:22:16 -06:00
Tayrtahn 2a2815e354 Move `HeadstandComponent` to Shared (#39377)
Move HeadstandComponent to Shared
2025-11-23 15:22:16 -06:00
ArtisticRoomba 5f0b3a9673 Revert "Fix bug with pipe color" (#39135) 2025-11-23 15:22:15 -06:00
Vanessa 7acebd855a Goobstation Bluespace Lifeline migration to the new Trigger system 2025-11-23 15:22:15 -06:00
slarticodefast 2d14cd4cc0 Trigger Refactor (#39034) 2025-11-23 15:22:15 -06:00
DrSmugleaf b878cabc23 Fix rotate verbs not being predicted (#38165)
* Fix rotate verbs not being predicted

* fixes

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-11-23 15:22:14 -06:00
Token 7642a65ff7 parrotMemory is onGetVerbs now in shared (#39341)
* parrotMemory is onGetVerbs now in shared

* code review

* code review popup on client rename parrotMemoryComponent

* code rev create client system

* forgot usings

* is server now
2025-11-23 15:22:14 -06:00
slarticodefast 312e28055f Predict anomaly synchronizer (#39321)
* predict anomaly synchronizer

* pvs

* lambda

* Update Resources/Locale/en-US/anomaly/anomaly.ftl

---------

Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com>
2025-11-23 15:22:14 -06:00
DrSmugleaf f59810ab28 Fix ActionsSystem.IsCooldownActive always returning false if curTime is null (#39329) 2025-11-23 15:22:14 -06:00
Krosus777 dce074ec24 HumanoidCharacterProfileFix (#39333) 2025-11-23 15:22:14 -06:00
Kyle Tyo 2b995b6be4 Predict ExamineEvent for CryoPodSystem. (#39322)
commit
2025-11-23 15:22:14 -06:00
Kyle Tyo 0f3558b424 Predict EmitterSystem ExamineEvent and GetVerbsEvent (#39318)
* ididathing.exe

* commit

* cleanup

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-11-23 15:22:14 -06:00
William Lemon f563f2c566
Ports Devils from Goobstation (#4639)
* or your debil

* Woop

* Whoops, Missed this

* Whoops, Suicide System

* Hush... Extended tests... Hush

* AAAAAA

* No-longer jaunt whilst dead

* :)

* Update Content.Shared/_Lavaland/Chasm/PreventChasmFallingSystem.cs

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: William Lemon <William.Lemon2@gmail.com>

* Update Content.Server/_Goobstation/Possession/PossessionSystem.cs

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: William Lemon <William.Lemon2@gmail.com>

* Please tobysenpai forgive me

---------

Signed-off-by: William Lemon <William.Lemon2@gmail.com>
Co-authored-by: Tobias Berger <toby@tobot.dev>
2025-11-20 10:11:07 +01:00
AeraAulin 2679bb238a
Psionic Prosthetics (#4689)
* AAAAAAAAA

* consistency

* add to emag packs

* add blacklist system and blacklist high risk items and bags thank you javadocs

* add DeltaV comments

* make comment better fit comment standards
2025-11-20 12:58:08 +11:00
Sir Warock 6686c6987d
Remake Holographic Rollerbed (#4683)
* Remake Holographic Rollerbed

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Remove Hyphen

Signed-off-by: Sir Warock <67167466+SirWarock@users.noreply.github.com>

---------

Signed-off-by: Sir Warock <67167466+SirWarock@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-11-19 14:27:29 -06:00
Vanessa 9e6dfed7e5
Fixed colossus stamina issues (#4688)
* Fixed colossus stamina issues.

* Fixed some spacing.
2025-11-19 11:07:21 +01:00
Apachito ff01033eaa
Port Fishing from Goob (#4615)
* FISHING REAL

* Update fishingspots.yml

* Delete fishingspots.yml

* Create fishingspots.yml

Removed the component that was causing errors

* Update Content.Client/_Goobstation/Fishing/Overlays/FishingOverlay.cs

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: Apachito <ivanlopezlegos2004@gmail.com>

* Update Resources/Prototypes/Entities/Structures/Furniture/toilet.yml

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: Apachito <ivanlopezlegos2004@gmail.com>

* Update Resources/Prototypes/Entities/Tiles/lava.yml

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: Apachito <ivanlopezlegos2004@gmail.com>

* Update Resources/Prototypes/Entities/Tiles/liquid_plasma.yml

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: Apachito <ivanlopezlegos2004@gmail.com>

* Update Resources/Prototypes/Entities/Tiles/liquid_plasma.yml

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: Apachito <ivanlopezlegos2004@gmail.com>

* Update Resources/Prototypes/Entities/Tiles/water.yml

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: Apachito <ivanlopezlegos2004@gmail.com>

* Update Resources/Prototypes/_Goobstation/Recipes/Construction/Graphs/misc/makeshift_rod.yml

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: Apachito <ivanlopezlegos2004@gmail.com>

* Update Resources/Prototypes/Entities/Tiles/water.yml

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: Apachito <ivanlopezlegos2004@gmail.com>

* Update Resources/Prototypes/_Goobstation/Actions/fishing.yml

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: Apachito <ivanlopezlegos2004@gmail.com>

* Update Resources/Prototypes/_Goobstation/Catalog/Fills/Crates/service.yml

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: Apachito <ivanlopezlegos2004@gmail.com>

* Changed the name spaces

* Update SharedFishingSystem.cs

* Revert "Update SharedFishingSystem.cs"

This reverts commit 78451cd5c2.

* Update FishingOverlay.cs

* Update FishingOverlay.cs

* Revert "Changed the name spaces"

This reverts commit 50bac6c4be.

* Revert "Changed the name spaces"

* Fixed name spaces and the sprite system

* Update makeshift_rod.yml

* Update makeshift_rod.yml

* Update Content.Client/_Goobstation/Fishing/Overlays/FishingOverlay.cs

Signed-off-by: Tobias Berger <toby@tobot.dev>

* Update Content.Client/_Goobstation/Fishing/Overlays/FishingOverlay.cs

Signed-off-by: Tobias Berger <toby@tobot.dev>

* Fixed Name Spaced

Changed the names spaces and did the ones I forgot to do initially.

* Changed name spaces again

* Fixed name spaces real

* Update SharedFishingSystem.cs

* Update SharedFishingSystem.cs

* Update SharedFishingSystem.cs

* Update FishingSystem.cs

* Update FishingSystem.cs

---------

Signed-off-by: Apachito <ivanlopezlegos2004@gmail.com>
Signed-off-by: Tobias Berger <toby@tobot.dev>
Co-authored-by: Tobias Berger <toby@tobot.dev>
2025-11-18 22:06:59 +01:00
Tobias Berger d006c86d8e
Fix anomaly shuffle particles type (#40624)
Fix anomaly shuffle particles type (#40624)

* dev it

* screw it

* Revert "screw it"

This reverts commit 5657a1d20128e630bebbaf38f4dcb4dbac28d026.

* Revert "dev it"

This reverts commit f3d7c355da17de92e43c145efbd348f8378d6146.

* slarti best

* Revert "slarti best"

This reverts commit 8de1caafb254515202aa21d2b96029a1fce24df2.

* Reapply "dev it"

This reverts commit c603940a73246f8a22a171c5559eb3f3f995e7bc.

* Reapply "screw it"

This reverts commit 468722abe7bde7e30bc3b421bc28fa90a013bd63.

* refactor: renaming +xml-doc

---------


(cherry picked from commit 9b7c87bd7e90191404e03f55be0acab46b6e891f)

Co-authored-by: kosticia <kosticia46@gmail.com>
Co-authored-by: pa.pecherskij <pa.pecherskij@interfax.ru>
2025-11-18 12:40:31 -06:00
Sir Warock a29905f5e9
Standardize PartDamage (#4584)
* Standardize PartDamage

* Fix
2025-11-18 09:38:23 +00:00
Sir Warock ebe9f2bf10
Add CPR (#4649)
* Add CPR

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Prevent multiple CPRs

* Fix small Parenthesize mistake

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: Sir Warock <67167466+SirWarock@users.noreply.github.com>

* Fix Name Paths

* Mistake?

* Merge branch 'master' into Add-CPR

* Update Content.Shared/_DV/Body/Systems/CPRSystem.cs

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: Sir Warock <67167466+SirWarock@users.noreply.github.com>

* Fix Issues seen by Holy Toby

* Small Fix
2025-11-18 09:30:50 +00:00
Sir Warock e9033fb71b
Buff Zombies (#4585)
* Buff Zombies

* Fix Interaction with gloves that are weapons

* CommentOps
2025-11-15 00:45:13 +01:00
DisposableCrewmember42 1ed2d6612f
feat: Secured Shock Collar (#4654)
* feat: ShockOnUnequipComponent, add to Shock Collar

* feat: ShockOnUnequip respects AccessReader list

* refactor: remove unused imports

applied suggestion

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: DisposableCrewmember42 <disposablecrewmember42@proton.me>

* style: add missing newline

applied suggestion

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: DisposableCrewmember42 <disposablecrewmember42@proton.me>

---------

Signed-off-by: DisposableCrewmember42 <disposablecrewmember42@proton.me>
Co-authored-by: Tobias Berger <toby@tobot.dev>
2025-11-15 00:16:07 +01:00
Sir Warock 63eb235e94
Fix SOME test fails (#4588)
* Increase SpawnAndDeleteAllEntitiesOnDifferentMaps test simulation time (#38901)

wait longer

* Reduce LevelOfParallelism to 2 for integration tests (#39566)

less paralelliism

* Fix Assumption of Nullable to have value (#41220)

* Fix Potential Test Fail

* Please the maintainer gods

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-11-13 12:21:38 +00:00
Sir Warock afd5cf0bbe
Fix Ammo Visuals Bug (#41362) (#4626)
Fix Ammo Count Updating
2025-11-09 19:30:44 +00:00
William Lemon 29e55b9464
Upstream Merge (June / July) attempt 2 electric boogaloo (#4607)
* Fix the sensor monitoring console forcing a GC every 3 seconds (#38146)

* Optimize sensor monitoring window graph drawing

* Add shared static Vector2 pool for all GraphView instances

* Address requested changes

* remove lock

* Update submodule to 264.0.0 (#38629)

* Toy/Plushie Inhands and Wearables (#38514)

* Fixed dependency injection and some other issues in a few places.

* More issue fixes

* patchfor broken NetworkConfiguratorLinkMenu (#38632)

fix

* Fix solutions flickering when transferring contents (#34838)

* Use Solution clones when applying SolutionComponent states

* Revert "Use Solution clones when applying SolutionComponent states"

This reverts commit 013fd111cf92b22562e00f98a7aaa49bc4b4ed62.

* Make Solution implement ICloneable and rename Clone method.

* Copy CanReact value when cloning a Solution

* Convert to IRobustCloneable

* Fix typos in guidebook: Buisness → Business (#38636)

* Fix typo in `MinorAntagonists.xml`

Buisness → Business

* Fix typo in `YourFirstCharacter.xml`

Buisness → Business

* Various Headphones Fixes and Tweaks (#38479)

* sprites, wearables

* neck

* icon-on sprite

* Cleanup prototype instantiation in `DamageTest` (#38639)

Cleanup prototype instantiation in DamageTest

* Cleanup prototype instantiation in `ExplosionSystem` (#38642)

Cleanup prototype instantiation in ExplosionSystem

* AddBodyPartCommand localization. (#38612)

commit

* fix ItemSlotsSystem debug assert (#38655)

* Allow the Command & Super door remotes to use the access of their user. (Re-creation of PR due to changes to game balance) (#35536)

* Added directional beacons (#38284)

* Added directional beacons

Signed-off-by: Nox38 <nebulousnox38@gmail.com>

* Fixed names

Signed-off-by: Nox38 <nebulousnox38@gmail.com>

---------

Signed-off-by: Nox38 <nebulousnox38@gmail.com>

* Power stat and nuke codes commands get some LEC love. (#38585)

* commit

* requested changes.

* Dsay Dirty and Follow commands converted to LEC and localized. (#38666)

* commit

* whoopwhoopwhoop

* Retro laser sprite fix (#38676)

* Fixed everything except the icon

Signed-off-by: Nox38 <nebulousnox38@gmail.com>

* fixed icon

Signed-off-by: Nox38 <nebulousnox38@gmail.com>

---------

Signed-off-by: Nox38 <nebulousnox38@gmail.com>

* fix water coolers (#38681)

* Monochromacy typo fix (#38686)

* fixes the typo

* Fixed cloning looking for the trait, not the component, RE https://github.com/space-wizards/space-station-14/pull/38686#issuecomment-3025093504

* Apply suggestions from code review

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Validate `CloningSettingsPrototype`s (#38688)

* Validate CloningSettingsPrototypes

* Update Content.IntegrationTests/Tests/Cloning/CloningSettingsPrototypeTest.cs

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Check EventComponents too

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Add test of objective-related console commands (#36400)

* Add test of objective add/list/remove commands

* Not sure why we're validating test prototypes, but sure

* We don't need a map

* Improvements and fixups for New Status Effect API (#38660)

* Predict healing and bloodstream (#38690)

* initial commit

* reapply 38126

* fix rootable

* someone missed an important minus sign here

* try this

* fix

* fix

* reenable crit hits

* cleanup

* fix status time dirtying

* fix

* camelCase

* Healing and bloodstream prediction fixes.

* Resolving Wizard casting recall on nuke disk making it impossible to disarm (#38661)

* Resolving Wizard Recall on Nuke disk making it impossible to disarm
- Adding a DisarmBomb case to nuke status update loop
- Changing a few methods and parameters to properly follow formatting standards
- Updating some names to follow camelCase

* Updating missed tag

* Reverting DataField change

Should prevent this preventative bugfix being a breaking change.

* Switch HSV to the default colorspace for character customization (#38434)

* Made HSV default for character editor

* Adds/fixes comments to HSV defaulting

* Added dropbox fix, potentially cursed

* Revert "Added dropbox fix, potentially cursed"

This reverts commit a709883366fbee813e839742125e70844672af29.

---------

Co-authored-by: TrixxedHeart <46364955+TrixxedBit@users.noreply.github.com>

* Fix: Don't deploy foldables when clicking on items inside containers (#38709)

* Fix

* Apply suggestions from code review

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Pressure Relief Valve (#36708)

* initial system (this math is probably WRONG)

* General code cleanup and OnExamined support
(holy moly this code sucks)

* UICode and related events foundation
TODO:
- Actually write the XAML UI and the underlying system
- Un-shitcode the entire thing
- Actually test everything...

* Working UI code
TODO: Make predicted, as this certainly isn't predicted. Even though I said it was. It isn't.

* Remove one TODO for unshitcoding the examine code

* Add reminder
yea

* Make predicted (defenitely isn't)
(also defenitely isn't a copypaste from pressure pump code)

* It's predicted!
TODO:
- Give it snazzy predicted visuals!
- Have a different field for pressure entry, lest it gets bulldozed every UI update.

* Improve gas pressure relief valve UI
TODO: Reminder to reduce amount of dirties using deltafields

* Implement DirtyField prediction

* Entity<T> cleanup
A lot of Entity<T> conversions and lukewarm cleanup.

Also got caught copy pasting code in 4K UHD but it's not like you couldn't tell.

* More cleanup and comments

* Remove TODO comment on bulldozing window title

* """refactoring"""
- Move appearance out of shared and finally fix it. Pointless to predict appearance in this instance.
- More Entity<T> conversions because I like them.
- Move UI creation handling over entirely to the ActivatableUI system.
- Fix a hardcoded locale string (why????).

* Add visuals

* Revert debugging variable replacememt
yea

* Revert skissue

* Remove unused using directives and remove TODO

* Localize, cleanup, document

* Fix adminlogging discrepancy

* Add ability to construct, add guidebook entry

* Clear up comment

* Add guidebook tooltip to valve

* Convert GasPressureReliefValveBoundUserInterface declaration into primary constructor

* Adds more input handling and adds autofill on open

* Un-deepfry input validator shitcode
Genuinely what was I smoking

* improve visuals logic

* Refactor again
- Update math to the correct implementation
- Moved code that could be re-used in the future into a helper method under AtmosphereSystem.Gases.cs

* I'm sorry but I hate warnings

* Remove unused using directive in AtmosphereSystem.Gases.cs

* Review and cleanup

* Lukewarm UI glossup

* Maintainer for the upstream project btw

* Remove redundant state sets and messy logic

* Unduplicate valve updater code

* Redo UI (im sorry Slarti)

* run tests

* Test refactored UI messaging

* Second round of UI improvements
- God please find a way to improve this system. Feels bad.

* Update loop implementation

* Further predict UI

* Clear up SetToCurrentThreshold

* cleanup

* Update to master + pipe layers and bug fixes
want to run tests

* fixes

* Deploy rename pipebomb

* Documentation and requested changes

* Rename the method that wiggled away

* Undo rounding changes

* Fix comment

* Rename and cleanup

* Apply suggestions from code review

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Fix TextLinkTag (#32203)

* Adjust uplink buy button to be under item icon (#38596)

* Adjusted uplink buy button to be under item icon

* Put the discount subtext under the icon

* Indent fixes, added margin

---------

Co-authored-by: TrixxedHeart <46364955+TrixxedBit@users.noreply.github.com>

* Scurrets - Audio Improvements (#38482)

* Scurret audio tuning

* Add new sfx

* Update sneezing sfx

* YAML support

* Rename a folder

* make telesci wreck easier (#37569)

rel

* Validate `ShaderPrototype` IDs (#38728)

* Convert all shader prototype string literals to protoids in overlays

* Convert more shader prototype literal strings to protoids

* Convert ValidatePrototypeId to ProtoId

* Later

* [BUGFIX] Fixed revenant malfunction ability not working properly only MediBots and Stasis bed (#38664)

* fixed

* clean up

* orks fix smart

* review fix 1

* more requested changes

* less cursed

* more descriptive description

* better wording

* Tiny Tiny Cleanup of the EyeClosingSystem. (#38734)

Update EyeClosingSystem.cs

* Fix human skin tone distribution (#38701)

* fix: Use PredictedQueueDel for gib spell (#38729)

* fix: don't default to uncharged sprite state for cells (#38730)

* Fix Hristov description - remove inaccurate technical specs (#38746)

- Removes inaccurate 'armor piercing 14.5mm shells' reference
- Replaces it with a more funny description, matching the style of the other snipers and guns
- Keeps ammunition type '.60 anti-materiel ammo' specification
- Fixes issue #38590

Co-authored-by: Arthur Fiorese de Andrade <aandrade@cmcxs.gov.br>

* feat: allow mopping evaporating puddles (#38743)

* Validate remaining `ProtoId` strings (#38747)

Validate remaining ProtoId strings

* Validate `ProtoId`s in tests (#38745)

* Convert string literals to protoids in Content.Tests

* Convert string literals to protoids or consts in Content.IntegrationTests

* Fix linter failures
Tricksy static using misled me

* Cleanup warning in StomachSystem (#38748)

you did not see this

* Vox scars (#38592)

* Added vox scars n'stuff, renamed vox_tattoos.ftl to just vox.ftl

* Revert "Added vox scars n'stuff, renamed vox_tattoos.ftl to just vox.ftl"

This reverts commit c73da55ba3b39ddf93b493aecd85604c54dd8a15.

* locale key fix

* Changed top surgery scar names to be more generalized

* Adjusted face scars

* Formatting fixes

---------

Co-authored-by: TrixxedHeart <46364955+TrixxedBit@users.noreply.github.com>

* UnlockNode command to LEC. (#38751)

* commit

* Update UnlockNodeCommand.cs

* commit

* move command locale to its own file.

* Update Content.Server/Xenoarchaeology/Artifact/UnlockNodeCommand.cs

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Typofixes for figurine dialogue (#38737)

* Typofixes for figurine dialogue

* Forgot two

* Janitor Tool: Wire Brush (#38667)

* Wow! It's -brush-

* spacing.

* Update Resources/Prototypes/Entities/Objects/Specific/Janitorial/janitor.yml

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Update Resources/Prototypes/Entities/Objects/Specific/Janitorial/janitor.yml

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* fixed changes

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Minor escape menu UX improvements (#38650)

* fix: spellbooks can have infinite charges (#38376)

* fix: spellbooks can have infinite charges

* refactor: indicate infinite spellbook charges with null

Not sure if I like this much better...
2025-11-06 18:22:39 +00:00
Sir Warock 65b32f441f
QoL for cryotubes (#4456)
* Port EvenlySplitting for Cryotubes

* Make Trinox consistent

* Bring into DV_Systems

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-10-26 10:47:19 +11:00
Sir Warock cf38b86342
Fix buckled patients standing up (#4316)
* Fix Standing up when Exiting Critical State (#1612)

<!-- Guidelines:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
<!-- NOTE: All code submitted to this repository is ALWAYS licensed
under the AGPL-3.0-or-later license.
The REUSE Specification headers or separate .license files indicate a
secondary license (e.g., MPL or MIT) solely to facilitate
integration for projects that do not use the AGPL license. This
secondary license does not replace the fact that AGPL-3.0-or-later
remains the primary and binding license.
Uncomment and modify the following line if you wish to change the
license from the default of AGPL.-->
<!--- LICENSE: AGPL -->
<!-- What did you change? -->
Made buckled Entities not stand up when recovering from critical state.
<!-- Discuss how this would affect game balance or explain why it was
changed. Link any relevant discussions or issues. -->
Just generally annoying having to buckle your patient again - Or have
them unbuckle from your rollerbed as you ferry them.
<!-- Summary of code changes for easier review. -->
Removed redunancies and inserted a check for being buckled before
calling the method to stand up when entering the Alive state.
<!-- Attach media if the PR makes ingame changes (clothing, items,
features, etc).
Small fixes/refactors are exempt. Media may be used in SS14 progress
reports with credit. -->
<img width="104" height="148" alt="grafik"
src="https://github.com/user-attachments/assets/c26009f1-e46e-46ae-bd2e-f89f7431dc07"
/>

<!-- Confirm the following by placing an X in the brackets [X]: -->
- [X] I have read and am following the [Pull Request and Changelog
Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html).
- [X] I have added media to this PR or it does not require an ingame
showcase.
- [X] I have tested any changes or additions.
- [X] I can confirm this PR contains no AI-generated content, and did
not use any AI-generated content.
<!-- You should understand that not following the above may get your PR
closed at maintainer’s discretion -->

<!-- List any breaking changes, including namespaces, public
class/method/field changes, prototype renames; and provide instructions
for fixing them.
This will be posted in #codebase-changes. -->

**Changelog**
<!-- Add a Changelog entry to make players aware of new features or
changes that could affect gameplay.
Make sure to read the guidelines and take this Changelog template out of
the comment block in order for it to show up.
Changelog must have a 🆑 symbol, so the bot recognizes the changes and
adds them to the game's changelog. -->
🆑
- fix: Fixed buckled patients standing up when recovering from crit. Now
they'll stay seated.

* Small fix

* Add Comments

Signed-off-by: Sir Warock <67167466+SirWarock@users.noreply.github.com>

* Fix comment?

* Returned Useless Import

* Update Content.Shared/Mobs/Systems/MobStateSystem.Subscribers.cs

Co-authored-by: Quanteey <61941975+Quanteey@users.noreply.github.com>
Signed-off-by: Sir Warock <67167466+SirWarock@users.noreply.github.com>

* Update Content.Shared/Mobs/Systems/MobStateSystem.Subscribers.cs

Co-authored-by: Quanteey <61941975+Quanteey@users.noreply.github.com>
Signed-off-by: Sir Warock <67167466+SirWarock@users.noreply.github.com>

* Update Content.Shared/Mobs/Systems/MobStateSystem.Subscribers.cs

Co-authored-by: Quanteey <61941975+Quanteey@users.noreply.github.com>
Signed-off-by: Sir Warock <67167466+SirWarock@users.noreply.github.com>

---------

Signed-off-by: Sir Warock <67167466+SirWarock@users.noreply.github.com>
Co-authored-by: Quanteey <61941975+Quanteey@users.noreply.github.com>
2025-10-16 11:04:21 +02:00
KOTOB c6addd2e9e
Port Cortical Borers (real) (#4466)
* ITS ALL C# GOOD LORD

BORN TO PORT
WORLD IS A PR
鬼神 Merge Em All 2025
I am yaml man
410,757,864,530 UPSTREAM MERGE CONFLICTS

* that was, uh. too easy.

* very small tweak

* comment and reuse fixes

* forgot the guidebook Oops

* the guidebookening

* the reusening
2025-10-16 16:11:24 +11:00
BarryNorfolk 70d7712a35
Add Grappling for Laika (#4157)
* Create grappling system

* Add grappling to Laika and other sec dogs

* Allow grapplers to also throw themselves prone

* Apply prone on grapple to laika

* Add layingdown component to laika

* Ensure grapplers entering crit release their grapples

* Ensure IPCs can be grappled

* Fix typo

* Remove system suffix for fields

* Simplifiy returns for CanGrapple

* Use magic dotnet syntax

* Fix usages of ViewVariables over DataFields

* Swap to using marker component over tags

* Remove errant new lines

* Remove redundant brackets
2025-10-16 15:52:34 +11:00
William Lemon 48bec2057b
Fractured Form - New Psionic Power (#4506)
* Initial Fractured Form Pass

* Cleanup

* AAAAAAAAAAAAAAAAAAA

* I forgor

* Sometimes naked

* Untouch and touch where applikcable

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Better optional pattern

* Unbreak it

* Minor Spelling Mistake

* Filthy test fix hack

* Filthy hack to appease the test gods

* A normal number of post-PR commits

* AAAAAAA

* Don't know why I didn't do this in the first place

* Some cleanup

* Damn how did I miss this

* Delta Mandated Cleanup

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-10-15 06:42:43 +11:00
William Lemon b70452f797
Unapologetic Diona Buffs (#4502)
* Unapologetic Diona Buffs

* Corrected misinformation

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* 40% slowdown resist

* Pew

* Pew pew

* Wording fix

* I forgor

* crying emoji

* types vs groups D:

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-10-13 10:31:06 +02:00
KOTOB 2570998da3
Fix Avali zoom distance (#4510)
nightmare
2025-10-09 01:26:22 +00:00
KOTOB 226d164f98
Midround Free Agent - Asakim Warrior (#4459)
* explodes you with my MIND

* goated?

* medipen gaming

* evil obfuscation system from hell

* MANY things

- accent improved (takes into account word length when determining number of syllables)
- night vision tied to shitmed eye organ (not thermals, though, that's broken for some reason)
- asakim-specific backpack and jumpsuit (mono turns ert backpacks into something generic while we don't, and they use goob ninja jumpsuit so i just made a new jumpsuit with goob ninja sprites)
- gun can switch between disabler and lethal modes
- rebalanced armor, made them a bit more squishy to melee and slightly less tanky to bullets/heat
- renamed and redescribed their items to fit more into deltav "lore"
- added the High Frequency Katana, basically a silly ninja sword
- removed freedom/storage implanters

* commit before i touch evil role code

* i lied one more commit before evil role code

* a lot of assorted things

- move prototype to shared (client got angry)
- Automated Defense System issuer real
- fix spawning, remove gamer cybernetics
- fix objectives
- more blunt res
- nerf loadout
- nerf gun

* we love misprediction

* i think this works

* big changeops

- springlock suit popup and gamer prediction (kinda)
- briefing audio
- precog
- evil rules that require mrp players to actually rp (evil)
- added to freelance shuttle set
- spawner is kill
- illiterate
- more slash damage
- nerfed the gun into the absolute ground (and removed semi auto)
- sword kinda nerfed
- removed some evil mono gamerule stuff we dont have

* lower weight

* tweaks

- rules are more gamer (kill those salvies)
- nerf heat res
- 1984 psionics

* appease the linter gods

* cleanup ops

* jumpscare

* if yaml validator fails i will cry

* fix assert, maybe fix yaml thing

assert fix is from a deltanedas PR from 2023, hopefully that still works

* I LOVE RIDER I LOVE RIDER

* minor cleanup

* attrib. fix

* attrib. fix take 2

* Update asakim_small.yml

* Update asakim_small.yml

---------

Signed-off-by: KOTOB <59124164+kotobdev@users.noreply.github.com>
2025-10-08 23:31:32 +00:00
Minerva 1cc243d811
Cherrypick: "Make more objects spray paintable" and related PRs (#4480)
* Make more objects spray paintable (Reviving #31328) (#37341)

* PaintableAirlockComponent and AirlockGroupPrototype have been replaced

* Slightly redesigned SprayPainterSystem for greater versatility

* Added handling of changes to the appearance of doors and storages

* PaintableGroup prototypes have been created

* Generating tabs with styles in the UI

* Fix error with undiscovered layer

* Slight improvement

* Removed unnecessary property

* The category for `PaintableGroup` was allocated to a separate prototype so that the engine itself would check if the category existed

* Added canisters, but repainting doesn't work

* Added localization to styles

* Fix sprite changing

* Added the ability to paint canisters

* slight ui improvement

* Fix yamllinter errors

* Fix test

* The UI now remembers which tab was open

* Fix build (?)

* Rename

* Charges have been added to the spray painter

* Added a charge texture for the spray painter

* Now spray painter can paint decals

* Increased number of charges

* Spawning dummy objects has been replaced by PrototypeManager

* added a signature about the painting of the object

* fix

* Code commenting

* Fix upstream

* Update Content.Shared/SprayPainter/Components/SprayPainterAmmo.cs

Co-authored-by: pathetic meowmeow <uhhadd@gmail.com>

* review

* Now decals can only be painted if the corresponding tab in the menu is open.

* Fixed a bug with pipe and decal tabs not being remembered

* Update EntityStorageVisualizerSystem.cs

* record

* loc

* Cleanup

* Revert electrified visuals

* more cleanup, fix charges, del ammo4

* no empty file, remove meta component

* closet exceptions, storage visualizer fixes

* enable/disable decal through alt-verb

* Fix missed merge conflicts

* fix snap offset, button event handlers

* simpler order, fix snap loc string

* Remove PaintableViz.BaseRSI, no decal item, A-Z

* State-respecting UI, BUI updates, FTL fixes

* revert DecalPlacerWindow changes

* revert unwanted changes, cleanup function order

* Limit SprayPainterAmmo write access to AmmoSystem

* Remove PaintedSystem

* spray paint ammo lathe recipe, youtool listing

* category as a list, groups as subtabs

* Restore inhand copyright in meta.json

* empty spray painter, recipe produces an empty one

* allow alpha on spray painter decals

* add comments

* paintable wall lockers

* Restrict painting more objects

* Suggested event changes, event cleanup

* component comments, fix ammo inhands

* uncleanable decals, dirty styles on mapinit

* organize paintables, separate emergency/closet grp

* fix categories newline at EOF

* airlock group whitespace cleanup

* realphabetize

* Clean up EntityStorageViz merge conflict markers

* Apply requested changes

* Apply suggestions from sowelipililimute's review

Co-authored-by: pathetic meowmeow <uhhadd@gmail.com>

* betrayal most foul

* Remove members from EntityPaintedEvent

* No emerg. group, steelsec to secure, locker/closet

* Enable repainting the medical wall locker

* comments, no flags on PaintableVisuals

* Remove locked variants from closets/wall closets

* removable decals

* off value consistency

* can't paint away those bones

* fix precedence

* Remove AirlockDepartment, AirlockGroup protos

Both unused.

* whitelist consistency re: ammo component

* add standing emergency closet styles

* alphabetize the spray painter listings

---------

Co-authored-by: Ertanic <black.ikra.14@gmail.com>
Co-authored-by: Эдуард <36124833+Ertanic@users.noreply.github.com>
Co-authored-by: pathetic meowmeow <uhhadd@gmail.com>

* Adds stencil lettering to the spraypainter (#39701)

* adds stencil lettering to the spraypainter

* update decal IDs to match convention

* Add Serializable, NetSerializable attributes to DecalPaintMode (#38921)

Serializable, Net" on DecalPaintMode

* Fixes my mistakes and adds DV compat

* Adds DV-specific stuff

* Makes Our Names Not Use This Case

* Comments xeno stuff we do not have

* RD is dead. Long live the Mystagogue

---------

Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com>
Co-authored-by: Ertanic <black.ikra.14@gmail.com>
Co-authored-by: Эдуард <36124833+Ertanic@users.noreply.github.com>
Co-authored-by: pathetic meowmeow <uhhadd@gmail.com>
Co-authored-by: Alkheemist <alkheemist@gmail.com>
2025-10-06 23:56:19 +00:00
Minerva 32bd2bdaee
Makes tape recorders signal-compatible (#4437)
* Makes tape recorders signal-compatible

* Removes accidental line
2025-10-06 14:42:56 +11:00
Nico a25e223a61
Ports the pressure release valve and construction atmos device layering from upstream (#4452)
* Change 'Departamental' to 'Departmental'

* Undo typo fixes for comments

* Add pipe layering

* Add the pressure release valve

* Add the pressure release valve

* Fix the gas pump

* Fix the signal valve appearing thrice

* Fix the signal valve appearing thrice

---------

Co-authored-by: Boaz1111 <149967078+Boaz1111@users.noreply.github.com>
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
2025-10-06 12:02:52 +11:00
KOTOB b4f824f7af
Port Cybersun Stealth Hardsuit (#4341)
* copy paste ops

* no attribution allowed here no siree

* lgtm

* direction didnt mention caustic get 1984'd

* Update uplink_catalog.yml

* ftlops
2025-10-05 09:51:39 +11:00
BarryNorfolk 848e0dcbe7
Add new armour options for K9s (Laika) (#4172)
* Add simple component for handling specialised clothing and armours

* Add awful artwork for k9 armours

* Update secdog template to include head and outer clothing gear

* Add tags for K9Armour and K9

* Ensure Laika has the k9 tag

* Add entity entries for K9 armour, update starting gear for Laika

* Add lathe recipes for new K9 armour

* Update secdog sprite by breaking tail out to separate layers

* Update sprite drawing for Secdogs

* Fix missing pixel in Laika's base sprite

* Add jetpack sprites for secdog

* Remove damage state visuals

* Add layingdown component to laika

* Update helmet sprites from HTMLSystem

* Update hardsuit sprites from HTMLSystem

* Fix prone on crit for secdogs

* Add new damage visual layer for tails

* Add static tail for Laika and hook it up to damage state visuals
2025-10-05 07:57:14 +11:00
Sir Warock f47dd7b21f
Fix blunt stamina double dipping (#4419)
* Fix StaminaRes double dipping

* Fix Oni Species Description
2025-10-03 05:51:52 +00:00
Sir Warock 276d47d89a
Make Surgery dependant on Part Damage (#4307)
* Make Surgery dependant on Part Damage

* Comments

* Fix things
2025-10-03 14:52:41 +10:00
William Lemon f4a2ff6364
Merge pull request #4424 from SirWarock/Buff-Augments
Make Augments more accessible
2025-10-03 14:43:59 +10:00
William Lemon 2f4e21ca6a
Merge pull request #4375 from AeraAuling/anomaliteportstuff
[PORT] Anomalites from Impstation
2025-10-03 10:17:21 +10:00
William Lemon e7eba6c790
Merge pull request #4464 from SirWarock/Fix-Ammo-Counter-on-Shotguns
Fix Shotgun ammocount not updating (#40568)
2025-10-03 09:51:14 +10:00
AeraAulin bcc15f4093
Merge branch 'DeltaV-Station:master' into anomaliteportstuff 2025-10-02 16:39:09 -07:00
William Lemon 3b2eedb802
Merge pull request #4275 from kotobdev/avali-ops
Species - Avali
2025-10-03 08:12:19 +10:00
Sir Warock 121840d19a
Reduce oni slowdown by clothes (#4364)
* Introduce ClothingSlowResistance

* Buff Onis

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-10-02 19:58:44 +01:00
SirSmith148 50b7b5fa2d First YML fixes 2025-10-01 13:45:53 -07:00
SirSmith148 ccdb1b161d CS fixes in YML issues everywhere 2025-10-01 01:43:35 -07:00
SirSmith148 a7733e1a37 First fixes 2025-10-01 01:14:01 -07:00
SirSmith148 96e62b681e Merge branch 'master' into Xenoarch-Merge 2025-10-01 01:08:14 -07:00
Sir Warock d660042b2d
Merge branch 'master' into Fix-Ammo-Counter-on-Shotguns 2025-09-29 19:15:01 +02:00
Sir Warock c300b28abc Fix Shotgun ammocount not updating (#40568) 2025-09-29 18:57:14 +02:00
kotobdev 8150aba854 WE LOVE SHITMED!!!! 2025-09-27 15:37:40 -07:00
William Lemon 01fe85f77e
Fix Flares, Give Skia Spacewalk (#4417)
* Fix various light sources counting as Light, Give Skia spacewalk

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Replace the Ignore Gravity with Jetpack

* Clean up event code + Avoid touching upstream code where possible

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Double cone, strategic untouches

* Additional strategic untouch

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-09-26 10:03:43 +00:00
kotobdev 6cc28a3e92 using jumpscare 2025-09-22 15:00:11 -07:00
kotobdev 276a92cc3f make action a bit more generic 2025-09-22 14:57:14 -07:00
kotobdev 233e06b7b6 pretty... 2025-09-22 14:51:23 -07:00
kotobdev be25971abb all but the last 2025-09-22 14:44:15 -07:00
Sir Warock 7ccb19ce02
Merge branch 'master' into Buff-Augments 2025-09-20 04:44:33 +02:00
Charlie Morley 80ad173d2d
(early upstream merge) Fix broken psionics, ai abilities, other powers (#4423)
early merge of upstream "fix: fix non-access checking EntityTargetActions #38731"
2025-09-19 06:00:27 +00:00
Sir Warock 8a6454730f Added Examination to Augments 2025-09-19 03:07:24 +02:00
kotobdev c638b3df29 mfw didn't read the diff 2025-09-16 15:47:39 -07:00
kotobdev 562a15efb3 epic merge fail 2025-09-14 23:11:40 -07:00
kotobdev d0d52e88fb Merge branch 'evil-ass-eye-ops' into avali-ops 2025-09-14 22:54:57 -07:00
kotobdev e55c66d774 im GOATED! im GOATED! im GOATED 2025-09-14 22:30:38 -07:00
kotobdev 6a409bf61b Revert "i owe elperson 15 dollars"
This reverts commit d8626fd199.
2025-09-14 21:19:08 -07:00
kotobdev d8626fd199 i owe elperson 15 dollars 2025-09-14 21:17:45 -07:00
kotobdev e8ca996757 Revert "almost 50% functional"
This reverts commit 0b26d11779.
2025-09-13 19:05:30 -07:00
kotobdev 4bbfbced5e Revert "im actually going insane"
This reverts commit 4e8d8bb52d.
2025-09-13 19:05:24 -07:00
kotobdev e047ecb125 Revert "danger commit before i touch the upstream code"
This reverts commit 679fc85f0e.
2025-09-13 19:05:14 -07:00
kotobdev 679fc85f0e danger commit before i touch the upstream code 2025-09-13 19:02:49 -07:00
kotobdev 4e8d8bb52d im actually going insane 2025-09-12 21:40:07 -07:00
kotobdev 0b26d11779 almost 50% functional 2025-09-12 19:33:28 -07:00
AeraAulin 14d0c0a351 hopefully this all goes through well 2025-09-11 08:45:11 -07:00
William Lemon bc8f5a7a20
Even More Skia Tweaks (#4355)
* More Skia tweaks

* Swapped whitelist for EntityWhitelist

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-09-11 06:02:48 +00:00
Sir Warock 75caa105e6
Fix limb healing on evenhealing (#4315)
* Fix EvenHealing on bodyParts (#1469)

<!-- Guidelines:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
<!-- NOTE: All code submitted to this repository is ALWAYS licensed
under the AGPL-3.0-or-later license.
The REUSE Specification headers or separate .license files indicate a
secondary license (e.g., MPL or MIT) solely to facilitate
integration for projects that do not use the AGPL license. This
secondary license does not replace the fact that AGPL-3.0-or-later
remains the primary and binding license.
Uncomment and modify the following line if you wish to change the
license from the default of AGPL.-->
<!--- LICENSE: AGPL -->
<!-- What did you change? -->
Fixed EvenHealing not working on limb damage when there was no general
damage.
<!-- Discuss how this would affect game balance or explain why it was
changed. Link any relevant discussions or issues. -->
When you had a massively burned victim, healing them via aloxadone would
heal their general damage, and each limb profited half of that general
healing.
However, as soon as the general damage was healed, Aloxadone wasn't
outputting any healing anymore, since even healing is dependent on
damage types on the general damage - And thus, with no healing, the
limbs couldn't benefit anymore.

This is wrong. I fixed it.
<!-- Summary of code changes for easier review. -->
Separated the healing of the general damage and limb damage, they are
independent of each other.
Healing General Damage won't heal limb damage and vice versa.
Added a way to heal each limb specifically.

I tested it thoroughly, and generally, it worked. Either with multiple
different damage types, or just one. Multiple damage parts, or just one.
Very much encourage to find a more elegant technical solution.
<!-- Attach media if the PR makes ingame changes (clothing, items,
features, etc).
Small fixes/refactors are exempt. Media may be used in SS14 progress
reports with credit. -->
I can't do videos, but videos would be required. Please try it out
yourself.
<!-- Confirm the following by placing an X in the brackets [X]: -->
- [X] I have read and am following the [Pull Request and Changelog
Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html).
- [X] I have added media to this PR or it does not require an ingame
showcase.
- [X] I can confirm this PR contains no AI-generated content, and did
not use any AI-generated content.
<!-- You should understand that not following the above may get your PR
closed at maintainer’s discretion -->

<!-- List any breaking changes, including namespaces, public
class/method/field changes, prototype renames; and provide instructions
for fixing them.
This will be posted in #codebase-changes. -->

**Changelog**
<!-- Add a Changelog entry to make players aware of new features or
changes that could affect gameplay.
Make sure to read the guidelines and take this Changelog template out of
the comment block in order for it to show up.
Changelog must have a 🆑 symbol, so the bot recognizes the changes and
adds them to the game's changelog. -->
🆑
- fix: Fixed Chemicals with the EvenHealing attribute to not work on
patient's limbs without General Damage. Aloxadone will now finally heal
the burned Salvager's limbs.

* Fix Port to Delta

* Fixes

* Made comments even more commenty?

Signed-off-by: Sir Warock <67167466+SirWarock@users.noreply.github.com>

* Update Content.Shared/Damage/Systems/DamageableSystem.cs

Co-authored-by: Quanteey <61941975+Quanteey@users.noreply.github.com>
Signed-off-by: Sir Warock <67167466+SirWarock@users.noreply.github.com>

* Add Comments

* Update Content.Shared/EntityEffects/Effects/EvenHealthChange.cs

Co-authored-by: Quanteey <61941975+Quanteey@users.noreply.github.com>
Signed-off-by: Sir Warock <67167466+SirWarock@users.noreply.github.com>

* Update Content.Shared/Damage/Systems/DamageableSystem.cs

Co-authored-by: Quanteey <61941975+Quanteey@users.noreply.github.com>
Signed-off-by: Sir Warock <67167466+SirWarock@users.noreply.github.com>

* Fix Comments

* Update Content.Shared/EntityEffects/Effects/EvenHealthChange.cs

Co-authored-by: Quanteey <61941975+Quanteey@users.noreply.github.com>
Signed-off-by: Sir Warock <67167466+SirWarock@users.noreply.github.com>

* commenty commenta WHEN DO THE COMMENTS END

---------

Signed-off-by: Sir Warock <67167466+SirWarock@users.noreply.github.com>
Co-authored-by: Quanteey <61941975+Quanteey@users.noreply.github.com>
2025-09-09 00:11:48 +02:00
Sir Warock 51a3862c6b
Remove Alive Icon (#1252) (#4317)
* Remove Alive Icon (#1252)

<!-- Guidelines:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
<!-- NOTE: All code submitted to this repository is ALWAYS licensed
under the AGPL-3.0-or-later license.
The REUSE Specification headers or separate .license files indicate a
secondary license (e.g., MPL or MIT) solely to facilitate
integration for projects that do not use the AGPL license. This
secondary license does not replace the fact that AGPL-3.0-or-later
remains the primary and binding license.
Uncomment and modify the following line if you wish to change the
license from the default of AGPL.-->
<!--- LICENSE: AGPL -->
<!-- What did you change? -->
I removed the alive Icon from the Medical HUD.
<!-- Discuss how this would affect game balance or explain why it was
changed. Link any relevant discussions or issues. -->
It blocked vision on speech bubbles and is entirely unnecessary.
Is the entity moving? Probably alive.
Does it not have a dead or critical icon? Probably alive.
We don't need an Icon that blocks the speech bubble to tell us this.
<!-- Summary of code changes for easier review. -->
Added a boolean to not give the icon if an entity is alvie.
Removed the Mob.Alive state from the icon finder table thing.
<!-- Attach media if the PR makes ingame changes (clothing, items,
features, etc).
Small fixes/refactors are exempt. Media may be used in SS14 progress
reports with credit. -->
<img width="89" height="95" alt="grafik"
src="https://github.com/user-attachments/assets/ef9308be-276b-440b-95d4-fddcaece32b9"
/>

<!-- Confirm the following by placing an X in the brackets [X]: -->
- [X] I have read and am following the [Pull Request and Changelog
Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html).
- [X] I have added media to this PR or it does not require an ingame
showcase.
- [X] I can confirm this PR contains no AI-generated content, and did
not use any AI-generated content.
<!-- You should understand that not following the above may get your PR
closed at maintainer’s discretion -->

<!-- List any breaking changes, including namespaces, public
class/method/field changes, prototype renames; and provide instructions
for fixing them.
This will be posted in #codebase-changes. -->

**Changelog**
<!-- Add a Changelog entry to make players aware of new features or
changes that could affect gameplay.
Make sure to read the guidelines and take this Changelog template out of
the comment block in order for it to show up.
Changelog must have a 🆑 symbol, so the bot recognizes the changes and
adds them to the game's changelog. -->

🆑
- remove: Removed the alive Icon - You can finally see if someone is
typing an answer.

---------

Co-authored-by: TheDen-Bot <186991657+TheDen-Bot@users.noreply.github.com>

* Fixes

* Actually correct Comment

---------

Co-authored-by: TheDen-Bot <186991657+TheDen-Bot@users.noreply.github.com>
2025-09-08 21:48:34 +02:00
Sir Warock d2539322ed
Improve Operating Tables (#4333)
* Improve Operating Tables

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* There is no god. We suffer.

* Add Anesthesia Component to Optable

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Less shitified code

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* GoodCode™️

* Rename Systemfile

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-09-08 11:56:03 +00:00
William Lemon 75a995a730
Skia Tweaks + Removes Nightvision form Lathes (#4308)
* Adds Direction Requests

* Fix

* Fixed EntryPoint, added back Sec Lathe, and added as a Salvage Points item

* Moved SpecOpsGoggles to appease gods

* Give Skia Thermal Vision

* Removed thermals from research.

* Removed thermal vision, added comment
2025-09-07 08:11:07 +00:00
No Elka efaf62c4e7
Add examine to IdentityBlocker (#4295)
* Change stuff

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* I sure hope that works

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-09-02 09:25:50 +01:00
William Lemon 01088086dc
Adds Skia (σκιά, shade) as a Midround Antagonist (#4152)
* AAAAAAAAadds skia

* Added to the spawn options table

* Fix EOR, Added shatter ability, Fix Reroll popup

* Fixed the death of the Skia

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fixed taco's silly mistake

* Skia need pry-ability

* Adds Goob Nightvision

* Added some missing Protos

* Appease the Yaml gods

* Did the Delta Fixes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Lathes fix

* Update attributions.yml

* More yaml fixes

* The Yaml Linter shall never be sated

* More fixes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fixed objective reroll

* Bring up to date

* aaaaaaaaaaa

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fixed damageset, removed unneeded point light

* I'm so sorry Deltandas

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: William Lemon <William.Lemon2@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-09-01 08:46:23 +00:00
Elperson 24cc28b532
Actually make LPO's crew monitor actually show people on the station (#4273)
* Simple fix

* maintainer requested changes
2025-08-31 18:31:38 +01:00
Minerva b65f0733b3
Fixes all "wether" typos (#4302)
Fixes all wether typos
2025-08-31 11:07:34 +02:00
Quanteey 3caeb45922
Grabbag of bugfixes (#4296)
* .

* Add a missing ftl to AI turrets (#37965)

* missing ftl

* make it pop

* Missing ftl

* Fixed Snacks Mispredicting on Clients (#38522)

* Well this works

* Removed merge conflict bait

* PredictedDel

* Apply suggestions from code review

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* That's not how it works

Signed-off-by: Quanteey <61941975+Quanteey@users.noreply.github.com>

---------

Signed-off-by: Quanteey <61941975+Quanteey@users.noreply.github.com>
Co-authored-by: āda <ss.adasts@gmail.com>
Co-authored-by: Southbridge <7013162+southbridge-fur@users.noreply.github.com>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-08-31 01:39:30 +00:00
ConstantlyConfused 854e546e25
Update the Crime Assist PDA App to match current Space Law (#3927)
* make Grand Felonies a possible crime

* Update the crime assist to match current space law

* re-organize result pages, add missing details

* Re-organize the general flow, add new questions & crimes

* typo ops

* typo ops v2

* Modify the flow further, per feedback

* mrrp

* typo ops 3: revengeance

* rename decorp to POR

* phrasing part one

* theft/possession phrasing changes & minor flow fixes

* remove redundant question, more flow changes

* update OOJ question

* update to include Noöspheric Tampering
2025-08-31 01:27:38 +00:00
No Elka d76a01b67f
Some loosely connected cosmic cult tweaks (#4284)
* Change stuff

* Cleanup

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-08-30 14:34:17 +00:00
No Elka 4126ef130b
Add in-game date to the PDA (#4277)
* Change stuff

* Change stuff

* Comment the XAML

* Change some more stuff

* _DV bruh

* Fix format string
2025-08-29 14:41:37 +00:00
0vrseer f41b542fd6
IPC cult cope ops (#4230)
* Added HumanoidSiliconMetaphysical which emulates BiologicalMetaphysical *while* enabling the same healing regular IPCs get.

* StoredDamageContainer no longer returns "Biological" for everything

* IPCs are now valid ardent censer targets

* 🤪

* Revert "Added HumanoidSiliconMetaphysical which emulates BiologicalMetaphysical *while* enabling the same healing regular IPCs get."

This reverts commit 9589909daae5498082a8949c07679639c5bc5150.

* Remove metaphysical conversion
2025-08-28 01:42:07 +00:00
No Elka f1a8220f2a
Make quiet cult strats not so terribly slow (#4272)
* Change stuff

* Change stuff

* Revert "Change stuff"

This reverts commit 6ab70cbe46.
2025-08-27 17:32:21 +00:00
No Elka a8a2361ccc
Minor-ish cult ability rebalance (#4260)
Change stuff
2025-08-27 17:20:41 +00:00
AlgisAlphonse 495361de72
Factorio - add a power toggle link port for the robotic arm. (#4117)
* Adds a toggle power sink port to the robotic arm

* Created babys first componenet, the toggle power
link port is not a componenet (PowerTogglePort)
Wow!

* Update PowerTogglePortComponent.cs

Deltanedas special #1

Signed-off-by: AlgisAlphonse <94876543+AlgisAlphonse@users.noreply.github.com>

* Update PowerTogglePortComponent.cs

susnedas

Signed-off-by: AlgisAlphonse <94876543+AlgisAlphonse@users.noreply.github.com>

* Update PowerTogglePortComponent.cs

sus

Signed-off-by: AlgisAlphonse <94876543+AlgisAlphonse@users.noreply.github.com>

---------

Signed-off-by: AlgisAlphonse <94876543+AlgisAlphonse@users.noreply.github.com>
2025-08-26 20:05:17 +00:00
Field Command 1619e4c1c5
Arms dealers have been spotted in the sector! (#4250)
* Arms dealer

* Update switch.yml

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* requested changes and fixes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: Field Command <159087063+FieldCommand@users.noreply.github.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-08-25 14:06:03 -05:00
No Elka ab196255bb
Colossus rebalance take 2 (#4251)
* Change stuff

* ж

* Add passive healing

* Make midround colossus totally not overpowered
2025-08-25 11:47:26 +00:00
No Elka e1fa07f86f
Deal ion damage to silicons on EMP instead of draining their power cells (#4255)
* Change stuff

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* My changes so requested

* Why was that even here

* I can't really build so github will do it for me

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-08-23 08:39:03 +00:00
No Elka 9cb68c46e3
Make secret take total player amount into account, lower the required amount of players ready (#4246)
* Change stuff

* Change prototypes

* Fix stuff

* Add // DeltaV

* _player
2025-08-21 08:53:49 +00:00
No Elka 4bf3905083
Make some swing animations nicer (#4235)
* Combo attacks when

* Remove stuff
2025-08-21 07:53:56 +00:00
No Elka 6f0c091b06
Cosmic cult bugfix bundle (#4233)
* Change stuff

* Fix more stuff

* Fix just a bit more

* Make non-cultists foxforms censerable too

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-08-20 19:43:20 +00:00
No Elka a021394ebe
Cosmic glyph rework: activation time and animations. (#4147)
* Refactoring in progress

* Refactoring completed, proceeding to animate a ton

* Don't commit that idiot

* Ballin

* Actually use the animations I made

* More sprites

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Change a lot of stuff

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Hopefuly finish changing stuff

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Prototype

* Change sprites

* Fix test fail

* Cessation sprites

* warding

* Add sounds

* Typo

* Projection

* Truth

* Knowledge

* Fix being able to convert SSD peeps

* Add interaction outline because why the hell not

* Change stuff

* Surely this won't explode

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-08-20 10:18:42 +00:00
No Elka 274ada2996
Minor cult audio tweaks (#4213)
* Replace colossus briefing sound

* Voice override for cult armor

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Why do I keep forgetting those

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-08-20 09:28:12 +00:00
KOTOB bfa721ea53
Make Glimmer Look Beautiful (#4130)
* about to break this all

* event goidacode

* cleanup

* cleanup 2

* cleanup 3

* cleanup 4

is it even worth bothering with these descriptions. added newline to end of a couple files

* single extra space WAUGH

* toggleable + minor cleanup

* that was reverted already what

why did merge conflict editor add in a line that isn't even present on master?? huh???

* fixops

GlimmerSystem looks like That to avoid extraneous network events being raised if something is attempting to push glimmer over 1000
2025-08-20 03:54:19 +00:00
No Elka 7cd8fffc17
Make siphon entropy work on crit people... with a twist (#4178)
* Change stuff

* Fixes

* Replace bibleUsers with command staff

* Change stuff

* Блять

* Блять 2

* Kill

* Today I learned how ternary operators work. Yay.
2025-08-18 12:57:15 +00:00
No Elka 9e12719c61
Cosmic cult entropy balance tweaks (#4099)
* Decrease entropy value

* Adjust siphoning

* Change entropyDegen

* Un-nerf cosmic equipment debuff

* Unindent by 2 spaces ops
2025-08-15 09:24:29 +03:00
No Elka bac514fc94
Multispectral inhibitor, new cosmic cult structure (#4181)
* JammerSystem additions

* Temporary sprite

* Prototypes

* Locale and guidebook changes

* Revert "JammerSystem additions"

This reverts commit b4019131b2.

* All my homies hate RadioJammerComponent

* Lower the range a tad

* Add actual sprite

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix stuff

* Kill SpriteFade while I'm at it

* Increase range

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-08-14 23:51:17 +00:00
Quanteey 980bc05edc Merge remote-tracking branch 'origin/master' into upstream-merge-ops 2025-08-14 15:53:14 +02:00
Proxy also works :3 7b7e69a80d
decrease emote cd to 3s (#4185)
i am not double checking
2025-08-14 10:25:33 +00:00
No Elka 737558289b
Make cult less obvious on earlier stages (#4179)
* Random rift spawn

* Change announcements

* Tweak timers

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Do in fact use ProtoId

* Revert "Do in fact use ProtoId"

This reverts commit cdc0972cac.

* Actually add the event into the pool

* Remove ancient code

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-08-14 09:57:13 +00:00
No Elka 8e45b2fa75
Allow cultists to absorb another rift after expending their empowerment (#4166)
* Kill

* Remove action on use
2025-08-13 11:28:27 +00:00
Perry Fraser 831199a5b9
fix: make advanced operating table advanced (#4170)
* fix: make advanced operating table advanced

* Test flake

* Test flake

* Bro
2025-08-11 13:57:42 +00:00
Quanteey 942b83fe03
Merge branch 'master' into upstream-merge-ops 2025-08-07 20:00:49 +02:00
Tayrtahn 4cb372c0a1 Remove redundant IoC Resolve in `EmptyOrWindowValidInTile` (#38446)
Remove redundant IoC Resolve in EmptyOrWindowValidInTile
2025-08-07 19:47:32 +02:00
deathride58 5bf18aa2ff Playtime Reminders - Raising awareness of addiction by highlighting excessive playtime (#36483)
* grass touch protocol - Rebases to latest master to fix conflicts

* aight local tests are passing lets see if our golf works

* It is 5 am and our ass COMPLETELY overcomplicated this lmaooo

* Addresses feedback - Clarifies comments, swaps internal var names for grasstouchless and selfdestructive, makes the third tier a little less demanding, and fixes 1 hours

* Addresses review - conflict fix

* This too

* Axes playtime exclusion for ghosts

* Use switch expression

code style nit

* Refactor/cleanup

Use IGameTiming.RealTime to track time instead of DateTime. Use nullable instead of magic values.

Expose the current day value through a property that is always up to date, instead of making the API to read the CVar that updates at inconsistent times. This also makes it trivial to debug with VV.

Other minor cleanup like using string interp, code style fixes, comments, etc.

---------

Co-authored-by: PJB3005 <pieterjan.briers+git@gmail.com>
2025-08-07 19:33:32 +02:00
kosticia 9422eba227 show reflection prob on examine (#38199)
* goaaaaaaaal

* hmmmmmmmmmm... sorry aeshus, but thats sucks

* adwaswa

* reviev

* awdasdws

* redo

* should work

* mistake

* change
Co-authored-by: Tayrtahn Tayrtahn@users.noreply.github.com

* Update Resources/Locale/en-US/reflect/reflect-component.ftl

---------

Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
2025-08-07 19:17:19 +02:00
slarticodefast 9535ad316b fix polymorph errors (#38409)
fix polymorph error
2025-08-07 19:16:39 +02:00
slarticodefast c43119296e Fix SharedActionSystem spamming errors (#38358) 2025-08-07 19:11:51 +02:00
Red f0923abef5 Spider web visuals update (#38175)
* web update

* Update Resources/Prototypes/Entities/Structures/spider_web.yml

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Update Resources/Prototypes/Entities/Structures/spider_web.yml

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* review

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-08-07 19:10:57 +02:00
kosticia 282c573c13 predicted hyposprays (#38046)
* G O I D A

* how

* now proper

* a

* Update HypospraySystem.cs

* good catch

* Apply suggestions from code review

---------

Co-authored-by: ScarKy0 <scarky0@onet.eu>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-08-07 19:03:52 +02:00
ArtisticRoomba 14b5004dc9 Thieves can innately pickpocket - thieving gloves rework (#38123)
* Thieves can innately pickpocket (#107)

Pickpocketing a skyrim guard's armor off

(cherry picked from commit 21b9f1ddb251ea3c7c6803e78871abefcaecbfb4)

* this isnt moff

* Make predicted, cleanup

* !skating-basketball

* orks are NOT the best trollface

* Implement much more sensible component replication prevention

---------

Co-authored-by: DuckManZach <144298822+duckmanzach@users.noreply.github.com>
2025-08-07 19:01:51 +02:00
ScarKy0 b86884cf10 Commands for adding and removing actions (#38317) 2025-08-07 18:48:28 +02:00
qrwas 79651839b4 Add group for loadouts (#36951)
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
2025-08-07 18:47:24 +02:00
beck-thompson 051dc369d6 Revert "Randomized Markings" (#38345) 2025-08-07 18:46:07 +02:00
beck 329fd24aec Randomized Markings (#34765)
randomized markings
2025-08-07 18:44:51 +02:00
SlamBamActionman e72b5dee65 Ensure large entities don't get stuck on conveyor belt corners (#37466)
* Initial commit

* Also avoid the friction change doesn't make turned-off conveyor belts continue going

* Ensurecomp on conveyor starting

* i give up

* Minor brackets edit

* Documentation
2025-08-07 18:44:06 +02:00
ScarKy0 7fed6632fb Retractable items system + Arm Blade action (#38150) 2025-08-07 18:41:36 +02:00
nikitosych fd6597d3da Fix for holoparasite's ability to attack the host through mech (#36659) 2025-08-07 18:38:36 +02:00
slarticodefast 1cad639d60 Fix puncturase cauterizing bleeding (#38289)
fix puncturase cauterizing bleeding
2025-08-07 18:22:47 +02:00
Qerd 7bbb964fc4 Prediction for use of utensil on incompatible food (#38297)
Prediction our beloved
2025-08-07 18:11:07 +02:00
themias b46e9f0046 Fix gas analyzer and anom scanner wrong state (#38285)
* Fix gas analyzer and anomaly scanner UI activation issue

* save

* fix comment

* milkalyzer
2025-08-07 18:09:58 +02:00
Perry Fraser a7bca8c91a Fix some popup issues with pipe layer changes (#38244)
* fix: only show pipe layer popups to the user changing them

* fix: don't show pipe layer subfloor popup when not using a screwdriver

* fix: properly pass down user and used for serverside pipe layer changes

Technically this doesn't matter as the Shared codepath for this method
doesn't actually use these on the server: only the user is used for a
clientside popup. Still, will be good to have these for future changes
that might need them.
2025-08-07 18:09:43 +02:00
Tayrtahn 5f3393032c Fix `StomachSystem` PVS error (#38268)
Fix StomachSystem PVS error
2025-08-07 17:24:26 +02:00
Simon e2739943dd Add the instrument names to the MIDI channel selector (#38083)
* Add the instrument to the MIDI channel selector

* Reviews

Adds support for chained masters
Makes the channel UI update on its own when the midi changes (Works with bands too!)

* add to admin logs and limit track count

* Limit track names by length too

* remove left over comment

* Requested changes

* Reviews
2025-08-07 12:04:09 +02:00
Quanteey 40d7ea758f Revert "Add the instrument names to the MIDI channel selector (#38083)"
This reverts commit e16c03ed29.
2025-08-07 02:55:23 +02:00
Simon e16c03ed29 Add the instrument names to the MIDI channel selector (#38083)
* Add the instrument to the MIDI channel selector

* Reviews

Adds support for chained masters
Makes the channel UI update on its own when the midi changes (Works with bands too!)

* add to admin logs and limit track count

* Limit track names by length too

* remove left over comment

* Requested changes

* Reviews
2025-08-07 02:19:03 +02:00
Tayrtahn 4d11a8ef6e Improve some `BinSystem` functionality (#38262)
* BinSystem improvements

* Prevent double-add
2025-08-07 02:17:35 +02:00
Tayrtahn 781ec9b715 Forbid string literals for `SharedToolSystem` methods (#38250)
* Forbid string literals for ToolSystem methods

* Cleanup violations

* Sort usings
2025-08-07 02:15:21 +02:00
eoineoineoin 8c7b370cc3 Add technology to tech disk names (#38157) 2025-08-07 02:14:59 +02:00
ArtisticRoomba 0932c99869 Bring back low pressure damage to its unnerfed value (#38196) 2025-08-07 02:09:13 +02:00
pathetic meowmeow a1f3ca6a69 Allow cargo request computers to send orders to the primary account (#37943) 2025-08-07 01:57:30 +02:00
DrSmugleaf e85eacb1d4 Fix eating and drinking verbs showing up after a short delay and making your verb UI bounce (#38164)
* Fix eating and drinking verbs showing up after a short delay and making your verb UI bounce

* Usings fix

* Usings fix

* Usings fix

* Usings fix

* CVar fix

* Predicted ppups

* Openable predicted popup

* Fix audio prediction
2025-08-07 01:48:46 +02:00
Leon Friedrich 173ca5fd7d Add FixedPoint2TypeParser (#38169) 2025-08-07 01:38:26 +02:00
Orsoniks c35279089c Improved Health examination text (#38126)
* more health examinations

* better blood

* fix

* tweaks

* sizeable

* silicon fix

* tweaks

* bleeding color tweaks

* fix
2025-08-07 01:36:36 +02:00
Kyle Tyo 70089b6f9e MapManager warnings cleanup Server Edition 2003 (#36781)
* now you see me

* unused depen

* test fail fix attempt 1

* test fail fix attempt 2

* fix test fail attempt 3

* shot in the dark.

* Does this work?

* import cleanup

* taking a shot at this.

* Convert PersistenceSaveCommand to LocalizedEntityCommands.

* requested changes

* requested changes. also dealt with improperly named private const

* Update Content.Server/GameTicking/GameTicker.Spawning.cs

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Update Content.Server/GameTicking/GameTicker.Spawning.cs

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Convert PlanetCommand to LocalizedEntityCommand

* Update BiomeSystem.cs

* Update Content.Server/Salvage/SalvageSystem.Runner.cs

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Update Content.Server/Procedural/DungeonSystem.Rooms.cs

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Update Content.Server/Salvage/SpawnSalvageMissionJob.cs

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Update Content.Server/Station/Systems/StationBiomeSystem.cs

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* revert to latest master.

* slartis suggestion.

* Update SetMapAtmosCommand.cs

* cleanup

* Update PersistenceSaveCommand.cs

* finish localizing persistencesavecommand

* this is icky, I change.

* :sigh:

* revert whatever I did here?

* oh I see, some inconsistencies.

* revert this

* Update PlanetCommand.cs

* move this ftl to the commands folder

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-08-07 01:36:00 +02:00
Tayrtahn c467a49a7c Forbid string literals for `NpcFactionSystem` methods (#38140)
* Add ForbidLiteral attribute to NpcFactionSystem methods

* Cleanup resulting warnings
2025-08-07 01:33:00 +02:00
slarticodefast 29556d3398 make PacifiedComponent session specific (#38137) 2025-08-07 01:30:52 +02:00
Quantum-cross 051120d6a6 Fix serialization of `SunShadowCycleComponent` (#38002)
* Use a struct to hold the items for `Directions` in `SunShadowComponent`, fix serialization.

* actually make them datafields...

* Add NetSerializable to datadef

* this is why we can't have nice things
2025-08-07 01:20:46 +02:00
slarticodefast cc9a6a95a7 Don't show climb verb for objects that cannot be climbed (#38115)
fix climb verb
2025-08-07 01:03:00 +02:00
Tayrtahn db9b106602 Cleanup unused/redundant dependencies (#38099) 2025-08-07 01:02:04 +02:00
Quanteey eb11a3a9dd Access reader downstream unfucking 2025-08-07 00:52:12 +02:00
chromiumboy d30561e06a Access Reader Refactor (#37772)
* Initial commit

* Integration test fix

* Removed redundant dirtying of accessreader
2025-08-07 00:26:56 +02:00
Quanteey 233478726c import me pls 2025-08-07 00:09:55 +02:00
chromiumboy bbaa0a6166 Tweak for the visual coverage granted to station AIs by holopads (#38059)
* Initial commit

* Added option to require anchoring
2025-08-07 00:06:44 +02:00
Funce e888c1a699 Blood-Red Magboots now correctly show if magboots are active (#38013)
* Change JetPack Item Visuals to use GenericVisualizer instead of AppearanceChangeEvents

* Fix YAML indentation for jetpacks.yml
2025-08-07 00:00:13 +02:00
SlamBamActionman 82e31f5e80 Add Diona rooting (#32782)
* Initial commit

* Add sound

* Review commets

* addressing review

* I think this is what Slart meant?

* Review fixes

* More fixes

* tiny formatting

* Review fixes

* Review fixes

* Fix small timing error

* Follow new action system

* review

---------

Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
Co-authored-by: ScarKy0 <scarky0@onet.eu>
2025-08-06 23:57:34 +02:00
Quanteey 421e1b0a12 <.< 2025-08-06 23:50:36 +02:00
āda 2a0714ec24 Loc fix for emote guidebook (#38020)
Loc fix
2025-08-06 23:42:32 +02:00
ScarKy0 42284decb8 Predict AME Fuel Examine (#38018)
* init

* :)
2025-08-06 23:42:02 +02:00
Krunklehorn 3469feabd5 Add checks for various complex interactions (#37246)
* Prevent toggling radiation collectors

* Prevent resisting locks

* Prevent unbuckling others, early exit before doafter

* Prevent camera and camera router setup

* Prevent rotating and flipping

* Also prevent adding the unbuckle verb.

* Revert ResistLocker changes

* Prevent emitter tampering

* Also prevent lock verb

* Prevent toggling welders

* Prevent gun open/close bolt, rack and switch mode

* Prevent toggling stun batons
2025-08-06 23:32:53 +02:00
slarticodefast 686ec8b8b1 improve noir glasses shader (#37996)
* improve noir glasses shader

* tweak values
2025-08-06 23:31:27 +02:00
BarryNorfolk 28fcf14220 Add multipart machines system (#35969) 2025-08-06 23:29:17 +02:00
Ciarán Walsh 6779e8ca83 Use distinct action labels for toggling internals on and off. (#36073)
* Use distinct action labels for toggling internals on and off.

* Implement specific actions for enabling/disabling internals

Avoids potential confusing race conditions where two people might perform the "Toggle Internals On" action an the same person,
which would have jsut toggled twice.

* If no gas tank, will give popup

---------

Co-authored-by: beck-thompson <beck314159@hotmail.com>
2025-08-06 23:27:43 +02:00
chromiumboy a5e16233e4 Layering for atmospheric pipes (#36124)
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
Co-authored-by: Kevin Zheng <kevinz5000@gmail.com>
2025-08-06 22:53:27 +02:00
slarticodefast 4d04f06894 Fix center of mass mispredict when placing tiles (#37969)
fix COM mispredict
2025-08-06 22:37:34 +02:00
deltanedas b334998916 fix dragon devour action (#37968)
Co-authored-by: deltanedas <@deltanedas:kde.org>
2025-08-06 22:30:09 +02:00
Nemanja 2be8dee064 Add support for contextual information in EntityTables (#37737)
* Add context support for entityTables

* fix build fail

* comments

* Update Content.Shared/EntityTable/EntityTableSystem.cs

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-08-06 22:28:50 +02:00
Quanteey 2649ed6c59 Fix downstream stuff after breaking changes in https://github.com/space-wizards/space-station-14/pull/35341 2025-08-06 22:25:51 +02:00
Centronias 697879a0ee Decouple Lights from Toggleable Visuals (and headphone music notes bugfix) (#35341)
* - Combine enum keys `ToggleableLightVisuals` and `ToggleVisuals` into `ToggleableVisuals`
- Rename `ToggleableLightVisualsComponent` to `ToggleableVisualsComponent` and `ToggleableLightVisualsSystem` to `ToggleableVisualsSystem`
  - (The `SpriteLayer` field on the component is now required because the old default of `light` doesn't make sense anymore)
- Make it so that `ToggleableVisualsComponent` works even when there's not a light attached to the entity
  - (Amazingly this seems to have only applied to  Headphones, but I can only imagine there are many other things people would like to do with simple toggleable visuals)
- Explicitly make `ItemTogglePointLightComponent`'s purpose to make `ToggleVisualsComponent` apply to `PointLightComponent`s on the same entity.
  - Add field `ToggleableVisualsColorModulatesLights`, which makes the `Color` appearance value of `ToggleableVisuals` modulate the color of lights on the same entity
  - Lots of prototype updates to uptake the above

* fix bad merge

* unbork robust

* blindly letting rider reformat stuff

* I guess I never cleaned up these imports at all
2025-08-06 22:06:58 +02:00
DrSmugleaf 8bd8b5bbb0 Allow actions to specify if they want to rotate the user when targeting (#37958) 2025-08-06 21:57:47 +02:00
beck-thompson c831ae3f0c Chameleon controller implant (Clothing fast switch) (#33887)
* Add the chameleon controller implant

* address the issues (Git please dont kill me)

* Address the review and fix some merge conflicts!

* Cleanup

* Add use delay

* Silly mistakes

* Making a PR at 2 am: Gone wrong

* Predict use delay and disable the buttons until you can choose another

* First phase custom clothing

* Better system, now relays to agent id and mindshield. Chameleon loadouts are a lot better to work with as well

* Address the review! No more evil goto

* Slams way is better I should have read more closely xD

* Some of the jobs

* Add to Cargo, CentComm, Service, Passenger, Ninja, Cluwne, Wizard + Minor changes to existing; Add chameleon to bandanas, medals, jugsuits and HUDs

* Add everything else

* Fix test

* Job name

* This looks better

* Add department organization

* Minor cleanup

* Added some mindshields

* Remove redudent comment and change funcion name to be clearer

* Fix cluwne outfit

* fix merge conflicts

---------

Co-authored-by: SlamBamActionman <slambamactionman@gmail.com>
2025-08-06 21:56:47 +02:00
Princess Cheeseballs 2a2a9f6fad [Action Refactor Fix] Action blockers now work on Actions (#37948) 2025-08-06 21:28:19 +02:00
mhamster a96c4369c4 Chameleon clothes + EMP behaviour (#30924)
* resolving conflicts??

* Controlled clothes changing

+ time stuff
+ EmpChangeIntensity

* Single clothes change

+ EmpContinious
+ moved random pick logic into GetRandomValidPrototype

* Changes from reviews

Co-Authored-By: Nemanja <98561806+emogarbage404@users.noreply.github.com>

* Update ChameleonClothingComponent.cs

* repairing irreparable damage

i failed, did i?

* damaging repaired irreparable

uh???

* 2025 FUN ALLOWED!!!!

* Minor changes from reviews

Co-Authored-By: beck-thompson <107373427+beck-thompson@users.noreply.github.com>

* Fix merge conflicts

* Fix that last bug

* cleanup

* Remove VV attr.

* AutoPausedField on emp time change

---------

Co-authored-by: Nemanja <98561806+emogarbage404@users.noreply.github.com>
Co-authored-by: beck-thompson <107373427+beck-thompson@users.noreply.github.com>
Co-authored-by: beck-thompson <beck314159@hotmail.com>
Co-authored-by: EmoGarbage404 <retron404@gmail.com>
2025-08-06 21:13:41 +02:00
Quanteey cef0fe7484 Fixes and migrating downstream yamls to use action system 2025-08-06 20:10:06 +02:00
deltanedas fb448bb7b5 action refactor proper ecs edition (#27422)
Migrated downstream YAMLs to the new action system
2025-08-06 20:08:30 +02:00
Tayrtahn 3e574a66d3 Cleanup some misc warnings (#37904)
* Fix warning CS8524 for TurretControllerWindow

* Fix warning CS0660 for AtmosAlarmThreshold
2025-08-05 20:00:42 +02:00
metalgearsloth 1c49eb4737 Content changes required for physicsmap purge (#37878)
* PhysMap changes

* Fix call

* Avoid tilefriction resolve

yummy

* a
2025-08-05 19:18:09 +02:00
Tayrtahn 7dfc1a7ac4 Fix walking in place animations when holding walk button (#37887)
Fix SpriteMovement playing when holding walk button
2025-08-05 19:02:08 +02:00
metalgearsloth e365dc9cb7 Don't click-to-face when moving (#37874)
Looks bad doing it for a single tick.
2025-08-05 17:15:22 +02:00
Tayrtahn eb94fb8e8d Cleanup warnings in `SharedMoverController` (#37613)
* Refactor IsAroundCollider to use EntityLookupSystem

* Formatting

* MapSystem methods

* Remove unused usings

* GrabRangeVV -> GrabRange
2025-08-05 17:14:52 +02:00
Nemanja 717e14ba1d Fix storage fastpath logical oversight (#37852) 2025-08-05 17:11:01 +02:00
Tayrtahn bd515c4ec9 Cleanup remaining `IMapManager.MapExists` uses (#37851)
Cleanup remaining IMapManager.MapExists uses
2025-08-05 17:10:34 +02:00
chromiumboy 2e2dd41087 Sentry turrets - Part 6: Sentry turret control panels (#35235) 2025-08-05 16:53:07 +02:00
slarticodefast 648d46439c Add WieldingBlockerComponent (#37778)
initial commit
2025-08-05 16:49:29 +02:00
Fildrance fb61aa165f Spray nozzle can suck puddles into tank directly! (#30600)
* feat: now vacuum cleaner can suck solutions from floor

* refactor using AbsorbentSystem instead of separate vacuum cleaner

* refactor: remove unused vacuum cleaner files

* refactor: renamed ConnectedContainerComponent to SlotBasedConnectedContainerComponent (and system)

* fix: fix invalid comp name

* fix: no more spray nozzle messaging about water inside bottles etc.

* refactor: minor refactor in SlotBasedConnectedContainerSystem and adjustments after merge

* refactor: cleanups

* refactor: renaming

* refactor: update to use _puddleSystem.GetAbsorbentReagents

* refactor: changed interactions with SlotBasedConnectedContainerSystem into events

* refactor: new sound and action delay adjusted to sound (amount tweaked a bit accordingly, almost)

* refactor: added networking for SlotBasedConnectedContainerComponent

* fix attribution for vacuum-cleaner-fast.ogg

* trying to fix multi-license for mix sound file

* remove empty line

* refactor: remove trailing whitespace

* by ref struct, brother

---------

Co-authored-by: pa.pecherskij <pa.pecherskij@interfax.ru>
Co-authored-by: EmoGarbage404 <retron404@gmail.com>
2025-08-05 16:49:19 +02:00
Quanteey 3c9ce1fb8a fixes 2025-08-05 16:46:25 +02:00
Princess Cheeseballs 0b9d4acaca Mob Spin Fix Update (#37603)
Kid named negative velocity
2025-08-05 16:38:18 +02:00
Cojoke 943635f5ab Removes references to GetAnchoredEntitiesEnumerator(Vector2i) (#37796)
* Removes references to GetAnchoredEntitiesEnumerator(Vector2i)

* requested changes(I think)
2025-08-05 16:24:53 +02:00
Pieter-Jan Briers 54f75362f4 New Discord integration fixes (#37793)
Fix admin chat relay.

Fix leaked task instance.

Fix warning about gateway intents on startup.

Fix packaging.
2025-08-05 16:24:38 +02:00
Simon cb7546855c Add basic discord client integration with ooc and admin chat support (#33840)
* Add basic discord client integration with ooc and admin chat support

* Use username instead of global name

WHY IS GLOBAL NAME NOT JUST THE USERNAME??? WHY ARE THERE NO DOC COMMENTS???

* stuff

* Reviews, methinks.

* Reviews

* reviews
2025-08-05 16:23:51 +02:00
slarticodefast c47dd3e51b Move PriceCalculationEvent and EstimatedPriceCalculationEvent to shared (#37782)
* moce PriceCalculationEvent to shared

* Update Content.Shared/Cargo/PriceCalculationEvent.cs

Co-authored-by: Tayrtahn <tayrtahn@gmail.com>

---------

Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
2025-08-05 16:21:45 +02:00
Tayrtahn b85a629549 Cleanup `AnchorableSystem` (#37753)
* The easy part

* Overload and obsolete

* Internal cleanup

* Update all references to new overload
2025-08-05 16:17:51 +02:00
Quanteey 4a48ba508d Fixes 2025-08-05 15:58:38 +02:00
pathetic meowmeow 33c9a4d0db Move entity effects definitions to shared (#35614)
* Move entity effects to shared

* relocate spawning to server

* Generic version of EntityEffect for just raising event.

* genericise everything

* oops forgot to push you

* some condensation

* finish rebas

* unwhite the space

* oops forgot nuke

* bad rebase fix

* useless annotations begone

---------

Co-authored-by: EmoGarbage404 <retron404@gmail.com>
2025-08-05 14:45:40 +02:00
slarticodefast 69d93a0b70 Cleanup TryGetContainingContainer (#37752)
kill
2025-08-04 19:26:39 +02:00
Tayrtahn 098595d115 Cleanup remaining `MapGridComponent.GetAnchoredEntities(MapCoordinates)` uses (#37729)
Cleanup remaining MapGridComponent.GetAnchoredEntities uses
2025-08-04 19:26:18 +02:00
metalgearsloth 6f6eb3eed0 Fix storage (#37714)
The one path I forgot to get the relative index.
2025-08-04 19:25:46 +02:00
Tayrtahn 37df758ea3 Update `SharedBiomeSystem` methods to use `Entity<T>` (#37698)
* Fix warning in TryGetBiomeTile

* Overload TryGetBiomeTile

* Overload more methods, fix internal warnings

* Update TryGetEntity uses

* Update TryGetTile uses

* Cleanup TryGetDecals use

* Formatting

* Two more warnings while we're here
2025-08-04 19:22:03 +02:00
Tayrtahn 247eb416b0 Cleanup warning in `GridInRange` (#37699)
Cleanup warning in GridInRange
2025-08-04 19:21:14 +02:00
Leon Friedrich 862f176ba1 Add microwave-nukedisk interaction (#36114)
* Add microwave-nukedisk interaction

* popup

* Fix UninitializedSaveTest
2025-08-04 19:19:05 +02:00
metalgearsloth 6d3ae2606b Ore + entitytable fixes (#37675)
* Ore + entitytable fixes

Iterate every dungeon not just last.

* Big shot

* Fixes
2025-08-04 19:17:11 +02:00
Quanteey 45e76947cc fixes 2025-08-04 19:07:04 +02:00
metalgearsloth 3a8b12103a Optimise storage a quadrillion times (#37638)
* Optimise storage a quadrillion times

* How sweaty can we get

* Add fast angle checks

* Fix chunk indices

* Optimise the refresh method

Helps on client a lot as the clientside is suboptimal atm.

* Better name

* wawawewa

* Add single-angle path

* Okay FINE rider
2025-08-04 15:39:13 +02:00
No Elka ef420e15d8
Add visuals to subtle cosmic mark (#4126)
* The previous branch got cooked let's do this again

* Species-specific sprites (fuck IPCs)

* Ы

* Add stuff to prototypes

* Jarvis play very loud incorrect buzzer sound

* Function doesn't work if it's not called

* Apparently thaven never had this

It was created FOR thaven lol

* Fix remainng bullshit

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Change stuff

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-08-04 13:29:25 +00:00
Tayrtahn c2b873f021 Cleanup warning CS0414 (#37648) 2025-08-04 15:28:50 +02:00
metalgearsloth aae1c22859 CompFactory updates (#37559) 2025-08-04 15:25:05 +02:00
Princess Cheeseballs 6fc34c9e16 Galosh Slowdown Fix (#37628)
Begone Galosh
2025-08-04 14:57:45 +02:00
SpeltIncorrectyl da4afbb1fd Give kammerer tighter spread so it's not a complete downgrade to the enforcer (#37616) 2025-08-04 14:56:22 +02:00