Commit Graph

9666 Commits

Author SHA1 Message Date
Vanessa 9d2a1f0000 Fixed DeltaV StationSystem methods after upstream moved them to shared. 2025-11-23 15:22:20 -06:00
deltanedas 8555a14f87 make objectives use yml defined mind filters (#36030)
* add MindHasRole whitelist overload

* add mind filters framework

* add different mind filters and pools

* update traitor stuff to use mind filters

* line

* don't duplicate kill objectives

* g

* gs

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
Co-authored-by: ScarKy0 <scarky0@onet.eu>
Co-authored-by: SlamBamActionman <slambamactionman@gmail.com>
2025-11-23 15:22:20 -06:00
Nemanja 6a02c97cff Move some Station methods into shared (#38976) 2025-11-23 15:22:20 -06:00
slarticodefast f1222f8408 give paused maps from polymorph and cryostorage a name (#39453) 2025-11-23 15:22:20 -06:00
Vanessa 7f89e7156c Updated Deepfryer code in SliceableFoodSystem 2025-11-23 15:22:19 -06:00
slarticodefast bd0ca3c4cc add scale:multiplyvector toolshed command (#39424) 2025-11-23 15:22:18 -06:00
slarticodefast 513d7ef581 Turn some implants into triggers (#39364)
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
2025-11-23 15:22:18 -06:00
Nemanja abd3e89cce Fix showvalue Ui for melee weapons (#38703)
Co-authored-by: Perry Fraser <perryprog@users.noreply.github.com>
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
2025-11-23 15:22:18 -06:00
poklj 46f1c81cd0 Changeling devour and transform (#34002)
* Initial:

Create Devour componentry, preliminary identity storage and the systems
for Devouring

* I have genuinely no idea what i'm doing

- added the radial menu, it has nothing in it.

- trying to get it to populate. the event under the event is broken,
i don't know why, but apparently it's not typed right

- Added a placeholder transform

- oh also fixed up some devour stuff and moved some things around.

* Holey moley, Transform, better devour, oh my!

- Move DnaComponent into Shared because we need it for the DNA cloning

- Make Transform MOSTLY work on the LAST identity devoured.

- Fix some issues on devour that involved prediction, canceling and
Damage exeucting (Thanks Plykiya for pointing out AttemptFrequency!)

* Proper tail stealing and Damage modifier attempt

Add check to add a wagging component on the Changeling if the victim's
species Prototype had one.

attempt to add the Damage mitigation check

* MAJOR CLEANUP AND FIXES AUGH 3 DAYS!!!

- Nullspaced a clone of a victim

- fix audio using server virtualized Pvs (i hate this)

- fix the mispredicted doafters

- Clean up a wholelotta code

- utilize clone systems to clone appearances

- Move CloneAppearance from server to shared So we can actually access
it

* Examine stuff, more cleanup, Jumpsuit ripping

- make rotting prevent the action

- Add ripping of clothing (guh why is it also server)

- add some System stuff for pushing husked corpse inspection

- clean up more badcode

* Doing things properly, UI sorta kinda works.

- Utilize Relayed events for Devour checking

- Get a UI that partially works, Says the name of identities, doesn't
show their looks

- Make use of the New Dynamic BUI assignment

- commit the sin of no client prediction cause nullspace entities aren't
networked

* Got an entity for the Frontend transform

Issue with the looks

* Stick a camera into a fake mobs forehead

- Get the UI to see the net entity in pause space by using a
ViewSubscriber to get the Pvs from the initially stored identity entity

- Remove all the other parts used to try to get this to work before hand

* Raaaaadiallllllls also fix protection coefficents

- Change FancyWindow to Radial

- Fix Issue where coeffeient checking was the wrong way round

* absolutely massive cleanup, no more camera in mobs

- cleaned up event variables that are not needed

- Removed the use of a Pause space and go back to Nullspace usage

- use a PvsOverride rather than ViewSharing

- Remove old commented out code and Lots of unused code

* Fix "Ui elements" dying  on the screen

- some minor cleanup

- don't start the entities that get cloned

* ftl, cleanup, and fixing missing transform details

- add replace functionality to TypingIndicatorSystem and
BodyEmotesSystem

- add placeholder sounds and functions to TransformBodyEmotes

- add extra Pvs handling for later use

- attributions for the funny straw sound

- Sound collections for all of the sounds

- various cleanups

* Some extra cleanup

* Fix some false assumptions about TypingIndicator

- Bubbles now transfer on spawned humans rather than used humans

- Clean up YET MORE CODE

- make it so you can't eat yourself

* Oooprs, forgot to add a Husked Corpse Loc

* Missing period in the husked corpse loc

* bad devour windup placeholder

* Husking and WIP Lungs

- Husking now will be prevented from Revival fully and will change
the appearance of players

* Add finalized Sprites for actions and final meta

- add devour on and off sprites

- add transform action sprite

- Add Armblade sprite for future use

- Credit obscenelytinyshark for the sprites <3

* Remove ling lungs, Entity<> everything

- Remove the ling lungs stuff for now... body system is overly
complicated, makes my head hurt

- Switch every method to use Entity<> from Uid, Comp format

* cleanup, admin logging, WIP Roles

* Admin verb, Roundstart, gamerule stuff

- add a Admin verb to make Changelingification easy!

- Add game rule stuff for admin verb and to tell the hapless
goober how to be a changeling... sorta

- clean up parts to make VV easy... USE THE VERB!!

* Armor Coefficent Check

- Remove bespoke changeling armor check and replace it
with a generic armor coefficient query.

* move to UnrevivableComponent instead of husked

- Move UnrevivableComponent to shared

- add Analyzable and ReasonMessage to UnrevivableComponent
to give granular control of the message and whether or not it shows up
in the analyzer

- remove the check for HuskedComponent in DefibrillatorSystem

* aaaaaaa CopyComp

- Some cleanup

- make Vocal system shared

- make VocalSystem Not make more Actions than it needs

- Use some code from ChameleonProjector so we can copy components

- partially ungod method the Transform system

* Cleanup, Moving more things to CopyComp

- TransformBodyEmotes now uses CopyComp (it's a server component so i
need to tell the server to deal with it

- TypingIndicatorComponent also now uses CopyComp

- cleaned up old, now unused "replace" methods in favor of CopyComp

- BodyEmotesSystem now has a publically accessable LoadSounds to deal
with the same problem Screaming had

* WIP

* Devour Windup noise, ForensicsSystem cleanup

* Revert VocalSystem Changes

- Reverted Moving VocalSystem to shared, copy comp acomplishes it

- added component.ScreamActionEntity = null; for copy comp

* cleanup unneeded comments

* revert an accidental line removal

* Remove duplicate SharedHumanoidAppearanceSystem

* Cleanup Typo's and import Forensics components for Dna

* Some more forensics calls

* cleanup use CopyComp for now until CopyComps

* CR cleanup

* Undo some SharedHumanoidAppearanceSystem changes

* Confound these spaces

* Some Copycomp stuff and fixing some PVS override

* use the proper TryCopyComps that are merged

* Change TransformMenu with RadialWithSector

* All sounds done, Fix lack of typing indicator issue

* Updated attributions to include used sound authors

* some ftl typos and mind_role text issue

* DNA, Screaming, appearance, grammar, wagging

- reduced all of the above using ApplyComponentChanges

- Issue still remains with bodyEmotes sticking around in the UI

* Fix UI stuff, partials, entprotoid, good practices

- bunch of partials added

- UI now has a predicted message

- EntProtoID in the admin verb

- RipClothing now uses Entity<ButcherableComponent>

- husking is now optional (off by default) for testing/till we have
hivemind/when we figure out what were doing with devour

- remove TransformGrammarSet

* More CR stuff and documentation

- Make TargetIsProtected less of a meme, with a prototype
set of DamageTypes to check

- Documenation everywhere

- Move DevourEvents into its own file

* Predicted sounds and fix the comp clone list

- Made all start and stop sounds shared

- Split out the rest of the events and UI stuff into subfiles

- Fixed some Clone comp list issues where comments had -'s causing them
to be read incorrectly

* Damage cap check, Identity Shutdown cleanup, cleanup

* Sound stuff (but actually this time)

* Missed documentation

* Missed Documentation and a EntProtoId

* Remove unused dependency

* Remove a nullcheck

* Some dummy minplayers

* CR - Husked now uses a rem/ensure

* Update Actions in the Prototype

* Fixup mindswap handover

- cleanup and handover PVS on mindswap

* Fixup Missing meta from accidental "Take-theirs"

* Add the Armblade to the roundstart-role

* Cleanup, CR (everything but the UI and renames)

* missed a spot

* missed some more whitespace

* Renames

* Primary constructor and a space in these trying times

* User interface stuff for Slime transformation

* popup prediction

* Ling devour no longer makes duplicate identities

- added a key to identities to the original victim

- Add some extra clone settings

* add guard statements to OnClones

* SentOnlyToOwner additions

* fix for sound stoppage error

* Move Organ deleter into soon to be atomized husk

* clone event inventory

* mono sounds

* lower sound volume

* Fix networked sound warning

* Clone comps thing

* review

* attributions

* Fix clobbered changes

* I'm gonna weh out

- whole bunch of CR changes

* fix some very buggy git

* okay its fixed

* address most review points

* fix inventory

* we hate entityuids

* fix test and more cleanup

* move this

* fix more stuff

* fix validation and rootable

* Remove Quickswitch due to some UI quirks

* oops left out some better explanation

* remove dangling LastConsumed component fields

* fix test fail

* try this

* cleanup cloning subscriptions, add movement speed modifier

* fix slime storage

* fix cloning setting inheritance

* Add session information to transform admin logs

* slay the integration test hydra

* dwarf size

* more volume tweaks

* comments

* improve comments and unpredict deletion due to errors when shutting down the server

* fix displancement cloning

---------

Co-authored-by: ScarKy0 <scarky0@onet.eu>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-11-23 15:22:18 -06:00
Nemanja a6df796690 Miscellaneous Body Decoupling (#38958) 2025-11-23 15:22:18 -06:00
Princess Cheeseballs caec3e6286 Debody Food and Drink Systems, Combine Food and Drink into One System. (#39031)
* Shelve

* 22 file diff

* What if it was just better

* Hold that thought

* Near final Commit, then YAML hell

* 95% done with cs

* Working Commit

* Final Commit (Before reviews tear it apart and kill me)

* Add a really stupid comment.

* KILL

* EXPLODE TEST FAILS WITH MY MIND

* I hate it here

* TACTICAL NUCLEAR STRIKE

* Wait what the fuck was I doing?

* Comments

* Me when I'm stupid

* Food doesn't need solutions

* API improvements with some API weirdness

* Move non-API out of API

* Better comment

* Fixes and spelling mistakes

* Final fixes

* Final fixes for real...

* Kill food and drink localization files because I hate them.

* Water droplet fix

* Utensil fixes

* Fix verb priority (It should've been 2)

* A few minor localization fixes

* merge conflict and stuff

* MERGE CONFLICT NUCLEAR WAR!!!

* Cleanup

---------

Co-authored-by: Princess Cheeseballs <66055347+Pronana@users.noreply.github.com>
2025-11-23 15:22:18 -06:00
ScarKy0 e6840d291b MessyDrinker for dogs (#38852) 2025-11-23 15:22:18 -06:00
Kyle Tyo ce981cb86c Predict base and damage examines of cartridge ammo. (#39401)
* commit

* requested changes +
2025-11-23 15:22:17 -06:00
Kyle Tyo e04f554ced Predict EMP Examine (#39419)
* another one bites the dust

* Update Content.Shared/Emp/SharedEmpSystem.cs

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-11-23 15:22:17 -06:00
slarticodefast 2fefa6785d Predict PickRandom verb (#39326)
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
2025-11-23 15:22:17 -06:00
Perry Fraser f29f970c8c feat: properly perform predicted porta pottys (fix toilet prediction) (#39394) 2025-11-23 15:22:17 -06:00
slarticodefast b1c2549f88 Predict cryopods (#39385)
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
2025-11-23 15:22:17 -06:00
Perry Fraser 918baf4a4f fix: properly respect AllowRepeatedMorphs (#39411)
* fix: properly respect AllowRepeatedMorphs

* feat: add IgnoreAllowRepeatedMorphs
2025-11-23 15:22:17 -06:00
Kyle Tyo 2f6189fcf7 Predict Nav Beacon Examine (#39408)
* commit

* Update Content.Shared/Pinpointer/SharedNavMapSystem.cs

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-11-23 15:22:17 -06:00
Kyle Tyo 935303f6e0 Reduced SalvageStructureComponent to atoms. (#39400)
* commit

* whoopsie daisy

* Update SpawnSalvageMissionJob.cs

* Update SpawnSalvageMissionJob.cs

* cleanup
2025-11-23 15:22:17 -06:00
Kyle Tyo 7196e70a67 Predict warp point location examines. (#39402)
commit
2025-11-23 15:22:16 -06:00
Tayrtahn 2a2815e354 Move `HeadstandComponent` to Shared (#39377)
Move HeadstandComponent to Shared
2025-11-23 15:22:16 -06:00
ArtisticRoomba 5f0b3a9673 Revert "Fix bug with pipe color" (#39135) 2025-11-23 15:22:15 -06:00
Vanessa 0920380cc5 Few more DV-specific trigger fixes 2025-11-23 15:22:15 -06:00
Vanessa 7acebd855a Goobstation Bluespace Lifeline migration to the new Trigger system 2025-11-23 15:22:15 -06:00
slarticodefast 2d14cd4cc0 Trigger Refactor (#39034) 2025-11-23 15:22:15 -06:00
DrSmugleaf b878cabc23 Fix rotate verbs not being predicted (#38165)
* Fix rotate verbs not being predicted

* fixes

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-11-23 15:22:14 -06:00
Token 7642a65ff7 parrotMemory is onGetVerbs now in shared (#39341)
* parrotMemory is onGetVerbs now in shared

* code review

* code review popup on client rename parrotMemoryComponent

* code rev create client system

* forgot usings

* is server now
2025-11-23 15:22:14 -06:00
slarticodefast 312e28055f Predict anomaly synchronizer (#39321)
* predict anomaly synchronizer

* pvs

* lambda

* Update Resources/Locale/en-US/anomaly/anomaly.ftl

---------

Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com>
2025-11-23 15:22:14 -06:00
Kyle Tyo 2b995b6be4 Predict ExamineEvent for CryoPodSystem. (#39322)
commit
2025-11-23 15:22:14 -06:00
Perry Fraser 7210699f8b Fix tabletop grids rarely spawning on top of another (#39327)
* fix: fix off-by-one for tabletop map positions

Ulam spirals start at 1, not 0.

* fix: make the ulam spiral a ulam spiral
2025-11-23 15:22:14 -06:00
Kyle Tyo 0f3558b424 Predict EmitterSystem ExamineEvent and GetVerbsEvent (#39318)
* ididathing.exe

* commit

* cleanup

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-11-23 15:22:14 -06:00
SlamBamActionman 9e0397d60e Fix variantize command not respecting tile rotation (#39314)
Oopsiedoodle
2025-11-23 15:22:13 -06:00
Charlie Morley f0f1f552d0
Oracle "offer item" context menu verb (#4704)
Adds context menu verb for offering items to Oracle
2025-11-22 12:32:37 -06:00
Coryn bfc41c6f0e
Allow Borgs to use emotes without sound (#4703) 2025-11-21 21:18:52 -06:00
William Lemon f563f2c566
Ports Devils from Goobstation (#4639)
* or your debil

* Woop

* Whoops, Missed this

* Whoops, Suicide System

* Hush... Extended tests... Hush

* AAAAAA

* No-longer jaunt whilst dead

* :)

* Update Content.Shared/_Lavaland/Chasm/PreventChasmFallingSystem.cs

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: William Lemon <William.Lemon2@gmail.com>

* Update Content.Server/_Goobstation/Possession/PossessionSystem.cs

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: William Lemon <William.Lemon2@gmail.com>

* Please tobysenpai forgive me

---------

Signed-off-by: William Lemon <William.Lemon2@gmail.com>
Co-authored-by: Tobias Berger <toby@tobot.dev>
2025-11-20 10:11:07 +01:00
Niomi 7f0ab295f9
Un-robust Anomalites (#4595)
* Nerfed Anomalites

Massively reduced health and resistances

* Direction requested changes

HP 40 > 60
Can only respawn once

* Code review changes
2025-11-19 12:05:22 +01:00
Apachito ff01033eaa
Port Fishing from Goob (#4615)
* FISHING REAL

* Update fishingspots.yml

* Delete fishingspots.yml

* Create fishingspots.yml

Removed the component that was causing errors

* Update Content.Client/_Goobstation/Fishing/Overlays/FishingOverlay.cs

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: Apachito <ivanlopezlegos2004@gmail.com>

* Update Resources/Prototypes/Entities/Structures/Furniture/toilet.yml

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: Apachito <ivanlopezlegos2004@gmail.com>

* Update Resources/Prototypes/Entities/Tiles/lava.yml

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: Apachito <ivanlopezlegos2004@gmail.com>

* Update Resources/Prototypes/Entities/Tiles/liquid_plasma.yml

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: Apachito <ivanlopezlegos2004@gmail.com>

* Update Resources/Prototypes/Entities/Tiles/liquid_plasma.yml

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: Apachito <ivanlopezlegos2004@gmail.com>

* Update Resources/Prototypes/Entities/Tiles/water.yml

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: Apachito <ivanlopezlegos2004@gmail.com>

* Update Resources/Prototypes/_Goobstation/Recipes/Construction/Graphs/misc/makeshift_rod.yml

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: Apachito <ivanlopezlegos2004@gmail.com>

* Update Resources/Prototypes/Entities/Tiles/water.yml

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: Apachito <ivanlopezlegos2004@gmail.com>

* Update Resources/Prototypes/_Goobstation/Actions/fishing.yml

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: Apachito <ivanlopezlegos2004@gmail.com>

* Update Resources/Prototypes/_Goobstation/Catalog/Fills/Crates/service.yml

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: Apachito <ivanlopezlegos2004@gmail.com>

* Changed the name spaces

* Update SharedFishingSystem.cs

* Revert "Update SharedFishingSystem.cs"

This reverts commit 78451cd5c2.

* Update FishingOverlay.cs

* Update FishingOverlay.cs

* Revert "Changed the name spaces"

This reverts commit 50bac6c4be.

* Revert "Changed the name spaces"

* Fixed name spaces and the sprite system

* Update makeshift_rod.yml

* Update makeshift_rod.yml

* Update Content.Client/_Goobstation/Fishing/Overlays/FishingOverlay.cs

Signed-off-by: Tobias Berger <toby@tobot.dev>

* Update Content.Client/_Goobstation/Fishing/Overlays/FishingOverlay.cs

Signed-off-by: Tobias Berger <toby@tobot.dev>

* Fixed Name Spaced

Changed the names spaces and did the ones I forgot to do initially.

* Changed name spaces again

* Fixed name spaces real

* Update SharedFishingSystem.cs

* Update SharedFishingSystem.cs

* Update SharedFishingSystem.cs

* Update FishingSystem.cs

* Update FishingSystem.cs

---------

Signed-off-by: Apachito <ivanlopezlegos2004@gmail.com>
Signed-off-by: Tobias Berger <toby@tobot.dev>
Co-authored-by: Tobias Berger <toby@tobot.dev>
2025-11-18 22:06:59 +01:00
pootslap 6931f5c06e
Footprints remove less units from puddles (#4674)
* reagent transfer

footprints don't exist + smears only contain 0.01u

* actually remove footprints

set it properly this time

* Update FootPrintsVisualizerSystem.cs

footprints back in, 99% less good at cleaning

* woops

actually remembered to reduce reagents in the puddle
2025-11-18 12:57:10 -06:00
Tobias Berger d006c86d8e
Fix anomaly shuffle particles type (#40624)
Fix anomaly shuffle particles type (#40624)

* dev it

* screw it

* Revert "screw it"

This reverts commit 5657a1d20128e630bebbaf38f4dcb4dbac28d026.

* Revert "dev it"

This reverts commit f3d7c355da17de92e43c145efbd348f8378d6146.

* slarti best

* Revert "slarti best"

This reverts commit 8de1caafb254515202aa21d2b96029a1fce24df2.

* Reapply "dev it"

This reverts commit c603940a73246f8a22a171c5559eb3f3f995e7bc.

* Reapply "screw it"

This reverts commit 468722abe7bde7e30bc3b421bc28fa90a013bd63.

* refactor: renaming +xml-doc

---------


(cherry picked from commit 9b7c87bd7e90191404e03f55be0acab46b6e891f)

Co-authored-by: kosticia <kosticia46@gmail.com>
Co-authored-by: pa.pecherskij <pa.pecherskij@interfax.ru>
2025-11-18 12:40:31 -06:00
KOTOB fe961d5d2e
MASSIVELY buff Random Animation (#4641)
gamers lock in
2025-11-18 12:27:40 -06:00
Sir Warock ebe9f2bf10
Add CPR (#4649)
* Add CPR

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Prevent multiple CPRs

* Fix small Parenthesize mistake

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: Sir Warock <67167466+SirWarock@users.noreply.github.com>

* Fix Name Paths

* Mistake?

* Merge branch 'master' into Add-CPR

* Update Content.Shared/_DV/Body/Systems/CPRSystem.cs

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: Sir Warock <67167466+SirWarock@users.noreply.github.com>

* Fix Issues seen by Holy Toby

* Small Fix
2025-11-18 09:30:50 +00:00
Sir Warock 29fca6675f
Stop Defibrillators from Causing Malpractice Lawsuits (#4583)
* Tiny bool change
2025-11-15 18:44:31 +00:00
Sir Warock e9033fb71b
Buff Zombies (#4585)
* Buff Zombies

* Fix Interaction with gloves that are weapons

* CommentOps
2025-11-15 00:45:13 +01:00
BarryNorfolk 150af3cc6a
Ensure grappled entities cleanup grapples when they crit/die (#4546)
* Ensure grappled entities cleanup grapples when they crit/die
2025-11-14 23:32:06 +00:00
DisposableCrewmember42 1ed2d6612f
feat: Secured Shock Collar (#4654)
* feat: ShockOnUnequipComponent, add to Shock Collar

* feat: ShockOnUnequip respects AccessReader list

* refactor: remove unused imports

applied suggestion

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: DisposableCrewmember42 <disposablecrewmember42@proton.me>

* style: add missing newline

applied suggestion

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: DisposableCrewmember42 <disposablecrewmember42@proton.me>

---------

Signed-off-by: DisposableCrewmember42 <disposablecrewmember42@proton.me>
Co-authored-by: Tobias Berger <toby@tobot.dev>
2025-11-15 00:16:07 +01:00
AeraAulin 5f38f59b98
Return of the Ifrit (#4570)
* return of the ifrit

* pre-PR fixes

* fix merge conflict part 1

* and put the damage modifier back in

* changed enough of the ghostrole to feel confident moving it from nyano to _DV

* pierce vs piercing gets me every time

* changes

* add playtime and temp immunity

* fix typo

Signed-off-by: AeraAulin <133451603+AeraAuling@users.noreply.github.com>

* Update Resources/Locale/en-US/_DV/ghost/roles/ifrit.ftl

Signed-off-by: Tobias Berger <toby@tobot.dev>

---------

Signed-off-by: AeraAulin <133451603+AeraAuling@users.noreply.github.com>
Signed-off-by: Tobias Berger <toby@tobot.dev>
Co-authored-by: Tobias Berger <toby@tobot.dev>
2025-11-14 23:09:55 +00:00
DisposableCrewmember42 6b65d3bb15
fix: restore pai shop action handling (#4651)
* fix: restore pai shop action handling
2025-11-14 21:20:06 +00:00
MolpeTheSeiren 56b0c23ce3
Fix Up Emagged Borg Law Redundancy (#4139)
* Update laws.ftl

Signed-off-by: MolpeTheSeiren <molpetheseiren@gmail.com>

* Update SiliconLawSystem.cs

Signed-off-by: MolpeTheSeiren <molpetheseiren@gmail.com>

* Update SiliconLawSystem.cs

Signed-off-by: MolpeTheSeiren <molpetheseiren@gmail.com>

* Update SiliconLawSystem.cs

Signed-off-by: MolpeTheSeiren <molpetheseiren@gmail.com>

* Update laws.ftl

Signed-off-by: MolpeTheSeiren <molpetheseiren@gmail.com>

* Update laws.ftl

Signed-off-by: MolpeTheSeiren <molpetheseiren@gmail.com>

---------

Signed-off-by: MolpeTheSeiren <molpetheseiren@gmail.com>
2025-11-14 20:26:06 +01:00
Sir Warock cd0db812eb
Remove Siphon Damage (#4627)
Remove Metagaming
2025-11-13 14:35:42 +00:00
Sir Warock 8b301a249d
Fix Transmutes taking transmuted objects (#4646)
Fix Transmutes taking transmuted ojbs
2025-11-13 13:09:07 +00:00
Vanessa 4d4420c99d
All species can emote typed emotes correctly now. (#4621)
Fixed a regression that disallowed people from doing text emotes of emotes from other species (aka with no sound)
2025-11-12 15:06:12 +00:00
Vanessa 1bd83bada7
Fixed emotes not working after upstream merge. (#4611)
* Fixed emotes not working after upstream merge.

* Added retry attribute to a test that fails intermittently
2025-11-07 11:03:36 +11:00
William Lemon 29e55b9464
Upstream Merge (June / July) attempt 2 electric boogaloo (#4607)
* Fix the sensor monitoring console forcing a GC every 3 seconds (#38146)

* Optimize sensor monitoring window graph drawing

* Add shared static Vector2 pool for all GraphView instances

* Address requested changes

* remove lock

* Update submodule to 264.0.0 (#38629)

* Toy/Plushie Inhands and Wearables (#38514)

* Fixed dependency injection and some other issues in a few places.

* More issue fixes

* patchfor broken NetworkConfiguratorLinkMenu (#38632)

fix

* Fix solutions flickering when transferring contents (#34838)

* Use Solution clones when applying SolutionComponent states

* Revert "Use Solution clones when applying SolutionComponent states"

This reverts commit 013fd111cf92b22562e00f98a7aaa49bc4b4ed62.

* Make Solution implement ICloneable and rename Clone method.

* Copy CanReact value when cloning a Solution

* Convert to IRobustCloneable

* Fix typos in guidebook: Buisness → Business (#38636)

* Fix typo in `MinorAntagonists.xml`

Buisness → Business

* Fix typo in `YourFirstCharacter.xml`

Buisness → Business

* Various Headphones Fixes and Tweaks (#38479)

* sprites, wearables

* neck

* icon-on sprite

* Cleanup prototype instantiation in `DamageTest` (#38639)

Cleanup prototype instantiation in DamageTest

* Cleanup prototype instantiation in `ExplosionSystem` (#38642)

Cleanup prototype instantiation in ExplosionSystem

* AddBodyPartCommand localization. (#38612)

commit

* fix ItemSlotsSystem debug assert (#38655)

* Allow the Command & Super door remotes to use the access of their user. (Re-creation of PR due to changes to game balance) (#35536)

* Added directional beacons (#38284)

* Added directional beacons

Signed-off-by: Nox38 <nebulousnox38@gmail.com>

* Fixed names

Signed-off-by: Nox38 <nebulousnox38@gmail.com>

---------

Signed-off-by: Nox38 <nebulousnox38@gmail.com>

* Power stat and nuke codes commands get some LEC love. (#38585)

* commit

* requested changes.

* Dsay Dirty and Follow commands converted to LEC and localized. (#38666)

* commit

* whoopwhoopwhoop

* Retro laser sprite fix (#38676)

* Fixed everything except the icon

Signed-off-by: Nox38 <nebulousnox38@gmail.com>

* fixed icon

Signed-off-by: Nox38 <nebulousnox38@gmail.com>

---------

Signed-off-by: Nox38 <nebulousnox38@gmail.com>

* fix water coolers (#38681)

* Monochromacy typo fix (#38686)

* fixes the typo

* Fixed cloning looking for the trait, not the component, RE https://github.com/space-wizards/space-station-14/pull/38686#issuecomment-3025093504

* Apply suggestions from code review

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Validate `CloningSettingsPrototype`s (#38688)

* Validate CloningSettingsPrototypes

* Update Content.IntegrationTests/Tests/Cloning/CloningSettingsPrototypeTest.cs

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Check EventComponents too

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Add test of objective-related console commands (#36400)

* Add test of objective add/list/remove commands

* Not sure why we're validating test prototypes, but sure

* We don't need a map

* Improvements and fixups for New Status Effect API (#38660)

* Predict healing and bloodstream (#38690)

* initial commit

* reapply 38126

* fix rootable

* someone missed an important minus sign here

* try this

* fix

* fix

* reenable crit hits

* cleanup

* fix status time dirtying

* fix

* camelCase

* Healing and bloodstream prediction fixes.

* Resolving Wizard casting recall on nuke disk making it impossible to disarm (#38661)

* Resolving Wizard Recall on Nuke disk making it impossible to disarm
- Adding a DisarmBomb case to nuke status update loop
- Changing a few methods and parameters to properly follow formatting standards
- Updating some names to follow camelCase

* Updating missed tag

* Reverting DataField change

Should prevent this preventative bugfix being a breaking change.

* Switch HSV to the default colorspace for character customization (#38434)

* Made HSV default for character editor

* Adds/fixes comments to HSV defaulting

* Added dropbox fix, potentially cursed

* Revert "Added dropbox fix, potentially cursed"

This reverts commit a709883366fbee813e839742125e70844672af29.

---------

Co-authored-by: TrixxedHeart <46364955+TrixxedBit@users.noreply.github.com>

* Fix: Don't deploy foldables when clicking on items inside containers (#38709)

* Fix

* Apply suggestions from code review

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Pressure Relief Valve (#36708)

* initial system (this math is probably WRONG)

* General code cleanup and OnExamined support
(holy moly this code sucks)

* UICode and related events foundation
TODO:
- Actually write the XAML UI and the underlying system
- Un-shitcode the entire thing
- Actually test everything...

* Working UI code
TODO: Make predicted, as this certainly isn't predicted. Even though I said it was. It isn't.

* Remove one TODO for unshitcoding the examine code

* Add reminder
yea

* Make predicted (defenitely isn't)
(also defenitely isn't a copypaste from pressure pump code)

* It's predicted!
TODO:
- Give it snazzy predicted visuals!
- Have a different field for pressure entry, lest it gets bulldozed every UI update.

* Improve gas pressure relief valve UI
TODO: Reminder to reduce amount of dirties using deltafields

* Implement DirtyField prediction

* Entity<T> cleanup
A lot of Entity<T> conversions and lukewarm cleanup.

Also got caught copy pasting code in 4K UHD but it's not like you couldn't tell.

* More cleanup and comments

* Remove TODO comment on bulldozing window title

* """refactoring"""
- Move appearance out of shared and finally fix it. Pointless to predict appearance in this instance.
- More Entity<T> conversions because I like them.
- Move UI creation handling over entirely to the ActivatableUI system.
- Fix a hardcoded locale string (why????).

* Add visuals

* Revert debugging variable replacememt
yea

* Revert skissue

* Remove unused using directives and remove TODO

* Localize, cleanup, document

* Fix adminlogging discrepancy

* Add ability to construct, add guidebook entry

* Clear up comment

* Add guidebook tooltip to valve

* Convert GasPressureReliefValveBoundUserInterface declaration into primary constructor

* Adds more input handling and adds autofill on open

* Un-deepfry input validator shitcode
Genuinely what was I smoking

* improve visuals logic

* Refactor again
- Update math to the correct implementation
- Moved code that could be re-used in the future into a helper method under AtmosphereSystem.Gases.cs

* I'm sorry but I hate warnings

* Remove unused using directive in AtmosphereSystem.Gases.cs

* Review and cleanup

* Lukewarm UI glossup

* Maintainer for the upstream project btw

* Remove redundant state sets and messy logic

* Unduplicate valve updater code

* Redo UI (im sorry Slarti)

* run tests

* Test refactored UI messaging

* Second round of UI improvements
- God please find a way to improve this system. Feels bad.

* Update loop implementation

* Further predict UI

* Clear up SetToCurrentThreshold

* cleanup

* Update to master + pipe layers and bug fixes
want to run tests

* fixes

* Deploy rename pipebomb

* Documentation and requested changes

* Rename the method that wiggled away

* Undo rounding changes

* Fix comment

* Rename and cleanup

* Apply suggestions from code review

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Fix TextLinkTag (#32203)

* Adjust uplink buy button to be under item icon (#38596)

* Adjusted uplink buy button to be under item icon

* Put the discount subtext under the icon

* Indent fixes, added margin

---------

Co-authored-by: TrixxedHeart <46364955+TrixxedBit@users.noreply.github.com>

* Scurrets - Audio Improvements (#38482)

* Scurret audio tuning

* Add new sfx

* Update sneezing sfx

* YAML support

* Rename a folder

* make telesci wreck easier (#37569)

rel

* Validate `ShaderPrototype` IDs (#38728)

* Convert all shader prototype string literals to protoids in overlays

* Convert more shader prototype literal strings to protoids

* Convert ValidatePrototypeId to ProtoId

* Later

* [BUGFIX] Fixed revenant malfunction ability not working properly only MediBots and Stasis bed (#38664)

* fixed

* clean up

* orks fix smart

* review fix 1

* more requested changes

* less cursed

* more descriptive description

* better wording

* Tiny Tiny Cleanup of the EyeClosingSystem. (#38734)

Update EyeClosingSystem.cs

* Fix human skin tone distribution (#38701)

* fix: Use PredictedQueueDel for gib spell (#38729)

* fix: don't default to uncharged sprite state for cells (#38730)

* Fix Hristov description - remove inaccurate technical specs (#38746)

- Removes inaccurate 'armor piercing 14.5mm shells' reference
- Replaces it with a more funny description, matching the style of the other snipers and guns
- Keeps ammunition type '.60 anti-materiel ammo' specification
- Fixes issue #38590

Co-authored-by: Arthur Fiorese de Andrade <aandrade@cmcxs.gov.br>

* feat: allow mopping evaporating puddles (#38743)

* Validate remaining `ProtoId` strings (#38747)

Validate remaining ProtoId strings

* Validate `ProtoId`s in tests (#38745)

* Convert string literals to protoids in Content.Tests

* Convert string literals to protoids or consts in Content.IntegrationTests

* Fix linter failures
Tricksy static using misled me

* Cleanup warning in StomachSystem (#38748)

you did not see this

* Vox scars (#38592)

* Added vox scars n'stuff, renamed vox_tattoos.ftl to just vox.ftl

* Revert "Added vox scars n'stuff, renamed vox_tattoos.ftl to just vox.ftl"

This reverts commit c73da55ba3b39ddf93b493aecd85604c54dd8a15.

* locale key fix

* Changed top surgery scar names to be more generalized

* Adjusted face scars

* Formatting fixes

---------

Co-authored-by: TrixxedHeart <46364955+TrixxedBit@users.noreply.github.com>

* UnlockNode command to LEC. (#38751)

* commit

* Update UnlockNodeCommand.cs

* commit

* move command locale to its own file.

* Update Content.Server/Xenoarchaeology/Artifact/UnlockNodeCommand.cs

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Typofixes for figurine dialogue (#38737)

* Typofixes for figurine dialogue

* Forgot two

* Janitor Tool: Wire Brush (#38667)

* Wow! It's -brush-

* spacing.

* Update Resources/Prototypes/Entities/Objects/Specific/Janitorial/janitor.yml

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Update Resources/Prototypes/Entities/Objects/Specific/Janitorial/janitor.yml

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* fixed changes

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Minor escape menu UX improvements (#38650)

* fix: spellbooks can have infinite charges (#38376)

* fix: spellbooks can have infinite charges

* refactor: indicate infinite spellbook charges with null

Not sure if I like this much better...
2025-11-06 18:22:39 +00:00
Vanessa 0deeaf7b77
Better Admin Tooling and New Curator Toys (#4577)
* Add Pockets and Tail-Drag to Admin Ghosts (#1508)

Adds 4 pockets to the Admin Ghosts and the ability to Tail-Drag (no
hands needed).

---

https://github.com/user-attachments/assets/701b66bd-c42c-429f-a33a-f8e465ef068d

---

🆑
ADMIN:
- add: Added pockets to Admin Ghosts.
- add: Added tail-drag (no-hands) to Admin Ghosts.

* Adding Admin Tools and Changing Aghost Starting Gear (#855)

- Added the admin folder, which can hold up to any normal item.
Prefilled with paper and a tasty treat.
- Added the admin toolbelt, which can hold up to any normal item.
Prefilled with various tools.
- Changed the admin satchel to be removable and added a few things to
its fill.
- Added the Admin RCD, an infinite RCD.
- Added an admin material box which contains 6 of the most basic
materials.
- The ID card in the admin PDA is now a CC ID card.

People were complaining about a lack of basic tools on the aghost.

Simple yml changes.

![image](https://github.com/user-attachments/assets/a65b145b-41d8-41e8-b48f-0ed567febe29)

- [x] I have read and am following the [Pull Request and Changelog
Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html).
- [x] I have added media to this PR or it does not require an ingame
showcase.
- [x] I can confirm this PR contains no AI-generated content, and did
not use any AI-generated content.

None afaik.

**Changelog**
🆑
- add: A bunch of new admin tools and things in the aghost starting
gear.

---------

Co-authored-by: TheDen-Bot <186991657+TheDen-Bot@users.noreply.github.com>

* Removed admin folder because it was being weird when put into containers and I don't really want fix it.

* Added auto-color for aghosts

* Added suffix to the CentComm implanter

* BSO Lifeline Port (#1730)

BSO lifeline implant - ported from Goobstation.

What is it?: It's a bluespace implant. Triggers when you die or when you
click the button twice.

Why is it?: BSO is a special role, specifically employed by CC. They
exist on station only to protect to command and nothing else. They have
pretty strong armour and weapons. So this is the solution to that +
creates an RP narrative.

It spawns in the BSO's pocket, as it's an optional implant, should
probably be taken either start of shift or when things get dicey for
command.

Additional: Adds new sprites for CC specified implants.

---

<details><summary><h1>Media</h1></summary>
<p>

![Content
Client_MHAiLxtLug](https://github.com/user-attachments/assets/907b8a0b-98af-4a1c-855b-e1737a373e0d)

</p>
</details>

---

🆑
- add: Blueshield Officer lifeline implanter

---------

Signed-off-by: Rouge2t7 <81053047+Sarahon@users.noreply.github.com>

* Fixed admin ghost color issue.

* Re-ordered the CentDrobe so useful things are at the top.

* Changed the sprite of the CentComm mindshield to match that of the Bluespace Lifeline.

* Added the ability to select a job with the 'spawncharacter' admin command.

* Added spawnplayer admin command

* Client-Side Entity Log Sorting (#1624)

<!-- Guidelines:
https://docs.spacestation14.io/en/getting-started/pr-guideline -->
<!-- NOTE: All code submitted to this repository is ALWAYS licensed
under the AGPL-3.0-or-later license.
The REUSE Specification headers or separate .license files indicate a
secondary license (e.g., MPL or MIT) solely to facilitate
integration for projects that do not use the AGPL license. This
secondary license does not replace the fact that AGPL-3.0-or-later
remains the primary and binding license.
Uncomment and modify the following line if you wish to change the
license from the default of AGPL.-->
<!--- LICENSE: AGPL -->
## About the PR
<!-- What did you change? -->
Expanded on admin log sorting. Fixes the issues from #1569

## Why / Balance
<!-- Discuss how this would affect game balance or explain why it was
changed. Link any relevant discussions or issues. -->
Admin things.

## Technical details
<!-- Summary of code changes for easier review. -->

## Media
<!-- Attach media if the PR makes ingame changes (clothing, items,
features, etc).
Small fixes/refactors are exempt. Media may be used in SS14 progress
reports with credit. -->


https://github.com/user-attachments/assets/837d9e4e-09bb-44ac-b79f-59435edc3aed


## Requirements
<!-- Confirm the following by placing an X in the brackets [X]: -->
- [x] I have read and am following the [Pull Request and Changelog
Guidelines](https://docs.spacestation14.com/en/general-development/codebase-info/pull-request-guidelines.html).
- [x] I have added media to this PR or it does not require an ingame
showcase.
- [x] I have tested any changes or additions.
- [x] I can confirm this PR contains no AI-generated content, and did
not use any AI-generated content.
<!-- You should understand that not following the above may get your PR
closed at maintainer’s discretion -->

## Breaking changes
<!-- List any breaking changes, including namespaces, public
class/method/field changes, prototype renames; and provide instructions
for fixing them.
This will be posted in #codebase-changes. -->

**Changelog**
<!-- Add a Changelog entry to make players aware of new features or
changes that could affect gameplay.
Make sure to read the guidelines and take this Changelog template out of
the comment block in order for it to show up.
Changelog must have a 🆑 symbol, so the bot recognizes the changes and
adds them to the game's changelog. -->
🆑
- tweak: ADMIN: You can sort entity logs by pressing fancy buttons!

* Fixed YAML linting issues

* Moved bluespace lifeline textures to proper directory

* Added emergency medical pods from Frontier for admemes.

* appeased the unit test gods

* Another test fail because people forgot that you can't divide by zero.

* probably appeased the unit test gods this time

* PR #4577 Feedback

---------

Signed-off-by: Rouge2t7 <81053047+Sarahon@users.noreply.github.com>
Co-authored-by: John Willis <143434770+CerberusWolfie@users.noreply.github.com>
Co-authored-by: MajorMoth <61519600+MajorMoth@users.noreply.github.com>
Co-authored-by: TheDen-Bot <186991657+TheDen-Bot@users.noreply.github.com>
Co-authored-by: Rouge2t7 <81053047+Sarahon@users.noreply.github.com>
Co-authored-by: William Lemon <William.Lemon2@gmail.com>
2025-10-30 01:52:30 +00:00
Sir Warock 65b32f441f
QoL for cryotubes (#4456)
* Port EvenlySplitting for Cryotubes

* Make Trinox consistent

* Bring into DV_Systems

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-10-26 10:47:19 +11:00
Cepelinas1 0ce67af6c8
De-metashield Epsilon part 1 + DV sound files moving (#3867)
* epsilon rewrite, first batch

* As requested, moved the announcement folder to _DV folder, which only now includes deltaV or nyanotrasen specific audio files. Please double check the license.txt in Announcements/RoundEnd to see if I got it right.

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* fix announcements again, oopsies

* potentially fixed epsilon rule, i dunno

* probably fix???? i dunno i only write goidacode

* temporary attribution.yml file for epsilon.ogg

* typo fix. not epsilon.ogg but code_epsilon.ogg

* another accidental error oops

* small test as removing my own attributions.yml file, i am going insane with these checks.

* reverted the attributions.yml deletion

* optional APC sound thing i wrote it incredibly stupid, going to do a stupider idea

* Update attributions.yml

* code saved by the angel named Toby

* added and fixed several attributions.yml files

* formatting fix oops

* fix second time hopefully

* i think i merged it correctly?

* weird way of fixing attributions

* With massive Quanteey's help and guidance, code cleanup once again.

* sound file path errors fixed

* another sound error fix

* added spacing to comments, removed CancellationTokenSource like asked and made the poweroff sound louder

* wiki page should be updated and removed epsilon mention in metashield rules

* from elevated to emergency status

* removed the funny event for 2 part

* forgot to remove a thing

* another fix

* conflict fix

* fix second time

* untouching and commenting

* untouching number 2

* untouched correctly?

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-10-23 07:26:55 +11:00
Vape fad71486d5
Organizing Shuttle Folder (#4549)
* Reuploading PR, it is readie

* Some convention fixes

* Rename the file again

Signed-off-by: Vape <76235372+Vapetastic-Gaming@users.noreply.github.com>

---------

Signed-off-by: Vape <76235372+Vapetastic-Gaming@users.noreply.github.com>
2025-10-19 02:03:13 +00:00
William Lemon ee481f557a
Fractured Form Sleep Patch (#4530)
Tiny patch
2025-10-16 16:54:33 +11:00
KOTOB c6addd2e9e
Port Cortical Borers (real) (#4466)
* ITS ALL C# GOOD LORD

BORN TO PORT
WORLD IS A PR
鬼神 Merge Em All 2025
I am yaml man
410,757,864,530 UPSTREAM MERGE CONFLICTS

* that was, uh. too easy.

* very small tweak

* comment and reuse fixes

* forgot the guidebook Oops

* the guidebookening

* the reusening
2025-10-16 16:11:24 +11:00
BarryNorfolk 70d7712a35
Add Grappling for Laika (#4157)
* Create grappling system

* Add grappling to Laika and other sec dogs

* Allow grapplers to also throw themselves prone

* Apply prone on grapple to laika

* Add layingdown component to laika

* Ensure grapplers entering crit release their grapples

* Ensure IPCs can be grappled

* Fix typo

* Remove system suffix for fields

* Simplifiy returns for CanGrapple

* Use magic dotnet syntax

* Fix usages of ViewVariables over DataFields

* Swap to using marker component over tags

* Remove errant new lines

* Remove redundant brackets
2025-10-16 15:52:34 +11:00
William Lemon 03b9098c33
Held Lights Hotfix (#4525) 2025-10-15 11:37:16 +02:00
William Lemon 48bec2057b
Fractured Form - New Psionic Power (#4506)
* Initial Fractured Form Pass

* Cleanup

* AAAAAAAAAAAAAAAAAAA

* I forgor

* Sometimes naked

* Untouch and touch where applikcable

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Better optional pattern

* Unbreak it

* Minor Spelling Mistake

* Filthy test fix hack

* Filthy hack to appease the test gods

* A normal number of post-PR commits

* AAAAAAA

* Don't know why I didn't do this in the first place

* Some cleanup

* Damn how did I miss this

* Delta Mandated Cleanup

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-10-15 06:42:43 +11:00
KOTOB 2570998da3
Fix Avali zoom distance (#4510)
nightmare
2025-10-09 01:26:22 +00:00
KOTOB 226d164f98
Midround Free Agent - Asakim Warrior (#4459)
* explodes you with my MIND

* goated?

* medipen gaming

* evil obfuscation system from hell

* MANY things

- accent improved (takes into account word length when determining number of syllables)
- night vision tied to shitmed eye organ (not thermals, though, that's broken for some reason)
- asakim-specific backpack and jumpsuit (mono turns ert backpacks into something generic while we don't, and they use goob ninja jumpsuit so i just made a new jumpsuit with goob ninja sprites)
- gun can switch between disabler and lethal modes
- rebalanced armor, made them a bit more squishy to melee and slightly less tanky to bullets/heat
- renamed and redescribed their items to fit more into deltav "lore"
- added the High Frequency Katana, basically a silly ninja sword
- removed freedom/storage implanters

* commit before i touch evil role code

* i lied one more commit before evil role code

* a lot of assorted things

- move prototype to shared (client got angry)
- Automated Defense System issuer real
- fix spawning, remove gamer cybernetics
- fix objectives
- more blunt res
- nerf loadout
- nerf gun

* we love misprediction

* i think this works

* big changeops

- springlock suit popup and gamer prediction (kinda)
- briefing audio
- precog
- evil rules that require mrp players to actually rp (evil)
- added to freelance shuttle set
- spawner is kill
- illiterate
- more slash damage
- nerfed the gun into the absolute ground (and removed semi auto)
- sword kinda nerfed
- removed some evil mono gamerule stuff we dont have

* lower weight

* tweaks

- rules are more gamer (kill those salvies)
- nerf heat res
- 1984 psionics

* appease the linter gods

* cleanup ops

* jumpscare

* if yaml validator fails i will cry

* fix assert, maybe fix yaml thing

assert fix is from a deltanedas PR from 2023, hopefully that still works

* I LOVE RIDER I LOVE RIDER

* minor cleanup

* attrib. fix

* attrib. fix take 2

* Update asakim_small.yml

* Update asakim_small.yml

---------

Signed-off-by: KOTOB <59124164+kotobdev@users.noreply.github.com>
2025-10-08 23:31:32 +00:00
Minerva 1cc243d811
Cherrypick: "Make more objects spray paintable" and related PRs (#4480)
* Make more objects spray paintable (Reviving #31328) (#37341)

* PaintableAirlockComponent and AirlockGroupPrototype have been replaced

* Slightly redesigned SprayPainterSystem for greater versatility

* Added handling of changes to the appearance of doors and storages

* PaintableGroup prototypes have been created

* Generating tabs with styles in the UI

* Fix error with undiscovered layer

* Slight improvement

* Removed unnecessary property

* The category for `PaintableGroup` was allocated to a separate prototype so that the engine itself would check if the category existed

* Added canisters, but repainting doesn't work

* Added localization to styles

* Fix sprite changing

* Added the ability to paint canisters

* slight ui improvement

* Fix yamllinter errors

* Fix test

* The UI now remembers which tab was open

* Fix build (?)

* Rename

* Charges have been added to the spray painter

* Added a charge texture for the spray painter

* Now spray painter can paint decals

* Increased number of charges

* Spawning dummy objects has been replaced by PrototypeManager

* added a signature about the painting of the object

* fix

* Code commenting

* Fix upstream

* Update Content.Shared/SprayPainter/Components/SprayPainterAmmo.cs

Co-authored-by: pathetic meowmeow <uhhadd@gmail.com>

* review

* Now decals can only be painted if the corresponding tab in the menu is open.

* Fixed a bug with pipe and decal tabs not being remembered

* Update EntityStorageVisualizerSystem.cs

* record

* loc

* Cleanup

* Revert electrified visuals

* more cleanup, fix charges, del ammo4

* no empty file, remove meta component

* closet exceptions, storage visualizer fixes

* enable/disable decal through alt-verb

* Fix missed merge conflicts

* fix snap offset, button event handlers

* simpler order, fix snap loc string

* Remove PaintableViz.BaseRSI, no decal item, A-Z

* State-respecting UI, BUI updates, FTL fixes

* revert DecalPlacerWindow changes

* revert unwanted changes, cleanup function order

* Limit SprayPainterAmmo write access to AmmoSystem

* Remove PaintedSystem

* spray paint ammo lathe recipe, youtool listing

* category as a list, groups as subtabs

* Restore inhand copyright in meta.json

* empty spray painter, recipe produces an empty one

* allow alpha on spray painter decals

* add comments

* paintable wall lockers

* Restrict painting more objects

* Suggested event changes, event cleanup

* component comments, fix ammo inhands

* uncleanable decals, dirty styles on mapinit

* organize paintables, separate emergency/closet grp

* fix categories newline at EOF

* airlock group whitespace cleanup

* realphabetize

* Clean up EntityStorageViz merge conflict markers

* Apply requested changes

* Apply suggestions from sowelipililimute's review

Co-authored-by: pathetic meowmeow <uhhadd@gmail.com>

* betrayal most foul

* Remove members from EntityPaintedEvent

* No emerg. group, steelsec to secure, locker/closet

* Enable repainting the medical wall locker

* comments, no flags on PaintableVisuals

* Remove locked variants from closets/wall closets

* removable decals

* off value consistency

* can't paint away those bones

* fix precedence

* Remove AirlockDepartment, AirlockGroup protos

Both unused.

* whitelist consistency re: ammo component

* add standing emergency closet styles

* alphabetize the spray painter listings

---------

Co-authored-by: Ertanic <black.ikra.14@gmail.com>
Co-authored-by: Эдуард <36124833+Ertanic@users.noreply.github.com>
Co-authored-by: pathetic meowmeow <uhhadd@gmail.com>

* Adds stencil lettering to the spraypainter (#39701)

* adds stencil lettering to the spraypainter

* update decal IDs to match convention

* Add Serializable, NetSerializable attributes to DecalPaintMode (#38921)

Serializable, Net" on DecalPaintMode

* Fixes my mistakes and adds DV compat

* Adds DV-specific stuff

* Makes Our Names Not Use This Case

* Comments xeno stuff we do not have

* RD is dead. Long live the Mystagogue

---------

Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com>
Co-authored-by: Ertanic <black.ikra.14@gmail.com>
Co-authored-by: Эдуард <36124833+Ertanic@users.noreply.github.com>
Co-authored-by: pathetic meowmeow <uhhadd@gmail.com>
Co-authored-by: Alkheemist <alkheemist@gmail.com>
2025-10-06 23:56:19 +00:00
Lonestar827 ef7b433a06
Fixes damage caused by EMP blast from EMP implanter (#4484)
Fixes damage problem with EMP blast.
2025-10-06 19:32:55 +11:00
Nico a25e223a61
Ports the pressure release valve and construction atmos device layering from upstream (#4452)
* Change 'Departamental' to 'Departmental'

* Undo typo fixes for comments

* Add pipe layering

* Add the pressure release valve

* Add the pressure release valve

* Fix the gas pump

* Fix the signal valve appearing thrice

* Fix the signal valve appearing thrice

---------

Co-authored-by: Boaz1111 <149967078+Boaz1111@users.noreply.github.com>
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
2025-10-06 12:02:52 +11:00
William Lemon ebb52d85e5
Merge pull request #4329 from mnva0/nosurgerypainwhennumb
People with the Numb trait no longer scream during surgery
2025-10-03 10:33:48 +10:00
AeraAulin c925018392 remove unused import thing 2025-10-02 16:46:38 -07:00
AeraAulin bcc15f4093
Merge branch 'DeltaV-Station:master' into anomaliteportstuff 2025-10-02 16:39:09 -07:00
William Lemon 3b2eedb802
Merge pull request #4275 from kotobdev/avali-ops
Species - Avali
2025-10-03 08:12:19 +10:00
SirSmith148 ccdb1b161d CS fixes in YML issues everywhere 2025-10-01 01:43:35 -07:00
SirSmith148 96e62b681e Merge branch 'master' into Xenoarch-Merge 2025-10-01 01:08:14 -07:00
William Lemon 01fe85f77e
Fix Flares, Give Skia Spacewalk (#4417)
* Fix various light sources counting as Light, Give Skia spacewalk

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Replace the Ignore Gravity with Jetpack

* Clean up event code + Avoid touching upstream code where possible

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Double cone, strategic untouches

* Additional strategic untouch

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-09-26 10:03:43 +00:00
Charlie Morley 5cfc51e192
allow ghosting if mind swap or telegnosis goes wrong (#4393)
* allow ghosting if mind swap or telegnosis goes wrong

* Review comment update Content.Server/Nyanotrasen/Abilities/Psionics/Abilities/MindSwapPowerSystem.cs

Co-authored-by: Tobias Berger <toby@tobot.dev>
Signed-off-by: Charlie Morley <cmorley191@gmail.com>

---------

Signed-off-by: Charlie Morley <cmorley191@gmail.com>
Co-authored-by: Tobias Berger <toby@tobot.dev>
2025-09-24 11:49:34 +02:00
William Lemon 3d0655ef8a
Make Night Vision Goggles cause you to ignore Flash Protection (#4378)
* Using NVGs now make you VERY flash vulnerable

* Removed redundant After

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-09-22 05:46:44 +00:00
Charlie Morley 1462f5bd1f
id card computer now sets access when selecting a job preset (#4441) 2025-09-21 21:49:45 +01:00
Charlie Morley f0ba366f61
silicons now hidden from records when filtering by fingerprint or dna (#4390) 2025-09-21 20:30:56 +02:00
kotobdev c638b3df29 mfw didn't read the diff 2025-09-16 15:47:39 -07:00
kotobdev e55c66d774 im GOATED! im GOATED! im GOATED 2025-09-14 22:30:38 -07:00
kotobdev 6a409bf61b Revert "i owe elperson 15 dollars"
This reverts commit d8626fd199.
2025-09-14 21:19:08 -07:00
kotobdev d8626fd199 i owe elperson 15 dollars 2025-09-14 21:17:45 -07:00
kotobdev 679fc85f0e danger commit before i touch the upstream code 2025-09-13 19:02:49 -07:00
kotobdev 4e8d8bb52d im actually going insane 2025-09-12 21:40:07 -07:00
kotobdev 0b26d11779 almost 50% functional 2025-09-12 19:33:28 -07:00
AeraAulin 14d0c0a351 hopefully this all goes through well 2025-09-11 08:45:11 -07:00
William Lemon bc8f5a7a20
Even More Skia Tweaks (#4355)
* More Skia tweaks

* Swapped whitelist for EntityWhitelist

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-09-11 06:02:48 +00:00
KOTOB 8baca76590
Nerf prober explosion lowering glimmer (#4340) 2025-09-09 12:03:35 +00:00
Charlie Morley 223b81ea35
Bugfix microwaves staying locked out after cooking finishes (#4352)
* fix microwaves staying locked out after cooking finishes (issue 4201)

upstream issue (goob is where the breaking changes came from): https://github.com/Goob-Station/Goob-Station/issues/4086

* minor style fixes
2025-09-09 05:54:09 +00:00
Minerva a7fff28602
Changes "credits" to "spesos" in the stock market (#4343) 2025-09-08 06:40:14 +02:00
William Lemon 75a995a730
Skia Tweaks + Removes Nightvision form Lathes (#4308)
* Adds Direction Requests

* Fix

* Fixed EntryPoint, added back Sec Lathe, and added as a Salvage Points item

* Moved SpecOpsGoggles to appease gods

* Give Skia Thermal Vision

* Removed thermals from research.

* Removed thermal vision, added comment
2025-09-07 08:11:07 +00:00
mnva 685cec5be8 People with the Numb trait no longer scream during surgery 2025-09-03 20:23:04 -04:00
William Lemon 01088086dc
Adds Skia (σκιά, shade) as a Midround Antagonist (#4152)
* AAAAAAAAadds skia

* Added to the spawn options table

* Fix EOR, Added shatter ability, Fix Reroll popup

* Fixed the death of the Skia

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fixed taco's silly mistake

* Skia need pry-ability

* Adds Goob Nightvision

* Added some missing Protos

* Appease the Yaml gods

* Did the Delta Fixes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Lathes fix

* Update attributions.yml

* More yaml fixes

* The Yaml Linter shall never be sated

* More fixes

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fixed objective reroll

* Bring up to date

* aaaaaaaaaaa

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fixed damageset, removed unneeded point light

* I'm so sorry Deltandas

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Signed-off-by: William Lemon <William.Lemon2@gmail.com>
Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-09-01 08:46:23 +00:00
No Elka cb0655798b
Minor cult fix (#4292)
Fix fun
2025-08-30 14:34:28 +00:00
No Elka d76a01b67f
Some loosely connected cosmic cult tweaks (#4284)
* Change stuff

* Cleanup

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-08-30 14:34:17 +00:00
No Elka 4126ef130b
Add in-game date to the PDA (#4277)
* Change stuff

* Change stuff

* Comment the XAML

* Change some more stuff

* _DV bruh

* Fix format string
2025-08-29 14:41:37 +00:00
KOTOB 47ec277b1a
Mass Mindswap rework (#4136)
* we ball?

* ok ❤️ yay ❤️

* changeops

* changeops

* im so good at coding
2025-08-29 02:22:41 +00:00
0vrseer f41b542fd6
IPC cult cope ops (#4230)
* Added HumanoidSiliconMetaphysical which emulates BiologicalMetaphysical *while* enabling the same healing regular IPCs get.

* StoredDamageContainer no longer returns "Biological" for everything

* IPCs are now valid ardent censer targets

* 🤪

* Revert "Added HumanoidSiliconMetaphysical which emulates BiologicalMetaphysical *while* enabling the same healing regular IPCs get."

This reverts commit 9589909daae5498082a8949c07679639c5bc5150.

* Remove metaphysical conversion
2025-08-28 01:42:07 +00:00
No Elka a8a2361ccc
Minor-ish cult ability rebalance (#4260)
Change stuff
2025-08-27 17:20:41 +00:00
No Elka ab196255bb
Colossus rebalance take 2 (#4251)
* Change stuff

* ж

* Add passive healing

* Make midround colossus totally not overpowered
2025-08-25 11:47:26 +00:00
Charlie Morley b2dd909ceb
Bugfix station beacons not showing up on map (#4211)
* * fix station beacons not showing up sometimes (typically the custom named ones)

upstream issue: https://github.com/space-wizards/space-station-14/issues/3769

* Lady Elegance: remove duplicate station beacons

* Review requests: simplify beacon bugfix, remove map changes

* comments
2025-08-24 01:15:10 +00:00
No Elka e1fa07f86f
Deal ion damage to silicons on EMP instead of draining their power cells (#4255)
* Change stuff

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* My changes so requested

* Why was that even here

* I can't really build so github will do it for me

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-08-23 08:39:03 +00:00
No Elka e5a415dbb1
Add software corruption damage type (#4245)
* Add the damage type

* Add the damage where applicable

# Conflicts:
#	Resources/Prototypes/_DV/CosmicCult/glyphs.yml

* Blyat

* *mild russian dissatisfaction*

* It finally works as intended

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Rename to ion damage

* Add to disabler bolts for some reason

* Woops

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-08-22 10:38:51 +00:00
No Elka 246ac5e61c
Make malign rifts actually (kinda) dangerous (#4216)
* Our cult so cosmic

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Add more gambling

* Change stuff

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Use EntityQuerry (what is that even for)

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Not how it works apparently

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-08-22 07:43:25 +00:00
No Elka 9cb68c46e3
Make secret take total player amount into account, lower the required amount of players ready (#4246)
* Change stuff

* Change prototypes

* Fix stuff

* Add // DeltaV

* _player
2025-08-21 08:53:49 +00:00
KOTOB 8d7920b0c2
Lower warops minimum nukies to 3 (#4169)
* warops ops ops ops

* commentops
2025-08-21 08:04:19 +00:00
No Elka 6f0c091b06
Cosmic cult bugfix bundle (#4233)
* Change stuff

* Fix more stuff

* Fix just a bit more

* Make non-cultists foxforms censerable too

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-08-20 19:43:20 +00:00
No Elka a021394ebe
Cosmic glyph rework: activation time and animations. (#4147)
* Refactoring in progress

* Refactoring completed, proceeding to animate a ton

* Don't commit that idiot

* Ballin

* Actually use the animations I made

* More sprites

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Change a lot of stuff

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Hopefuly finish changing stuff

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Prototype

* Change sprites

* Fix test fail

* Cessation sprites

* warding

* Add sounds

* Typo

* Projection

* Truth

* Knowledge

* Fix being able to convert SSD peeps

* Add interaction outline because why the hell not

* Change stuff

* Surely this won't explode

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-08-20 10:18:42 +00:00
No Elka 274ada2996
Minor cult audio tweaks (#4213)
* Replace colossus briefing sound

* Voice override for cult armor

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Why do I keep forgetting those

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-08-20 09:28:12 +00:00
KOTOB c275c9d55c
Tie xenoarch point output to glimmer (#4164)
* it work i think

* tweakops

* commentops

* newline ops

* direction + bugfix ops

exponential point increase, no more insane glimmer nukes (sad!), analyzer no longer displays negative points
2025-08-19 00:48:50 +00:00
No Elka 7cd8fffc17
Make siphon entropy work on crit people... with a twist (#4178)
* Change stuff

* Fixes

* Replace bibleUsers with command staff

* Change stuff

* Блять

* Блять 2

* Kill

* Today I learned how ternary operators work. Yay.
2025-08-18 12:57:15 +00:00
No Elka fc1f773209
Fix ghosts vismasks and make colossi see the monument (#4226)
Fix
2025-08-18 11:57:51 +00:00
No Elka 1d4a60eaf0
Tweak cosmic cult win conditions (#4156)
* Change stuff

Change more stuff

Change locale.

Don't count cultists that are cuffed

Bruh

Change more stuff

Fuck around

* Blyat

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-08-16 12:24:12 +00:00
No Elka 9e12719c61
Cosmic cult entropy balance tweaks (#4099)
* Decrease entropy value

* Adjust siphoning

* Change entropyDegen

* Un-nerf cosmic equipment debuff

* Unindent by 2 spaces ops
2025-08-15 09:24:29 +03:00
No Elka bac514fc94
Multispectral inhibitor, new cosmic cult structure (#4181)
* JammerSystem additions

* Temporary sprite

* Prototypes

* Locale and guidebook changes

* Revert "JammerSystem additions"

This reverts commit b4019131b2.

* All my homies hate RadioJammerComponent

* Lower the range a tad

* Add actual sprite

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix stuff

* Kill SpriteFade while I'm at it

* Increase range

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-08-14 23:51:17 +00:00
Quanteey b8ae7f67c6
Speedmerge #39243 from upstream (#4190)
* Reduce system.dungeon logspam

* Update Content.Server/Procedural/DungeonJob/DungeonJob.Ore.cs

Co-authored-by: āda <ss.adasts@gmail.com>

* Fix leftover bracket

* Update Content.Server/Procedural/DungeonJob/DungeonJob.Ore.cs

Co-authored-by: Perry Fraser <perryprog@users.noreply.github.com>

---------

Co-authored-by: Atakku <atakkudev@gmail.com>
Co-authored-by: Atakku <atakkudev+github.atakku@gmail.com>
Co-authored-by: āda <ss.adasts@gmail.com>
Co-authored-by: Perry Fraser <perryprog@users.noreply.github.com>
2025-08-14 23:01:18 +00:00
Quanteey 1a2b429dac Action refactor things 2025-08-14 15:59:35 +02:00
Quanteey 980bc05edc Merge remote-tracking branch 'origin/master' into upstream-merge-ops 2025-08-14 15:53:14 +02:00
No Elka 737558289b
Make cult less obvious on earlier stages (#4179)
* Random rift spawn

* Change announcements

* Tweak timers

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Do in fact use ProtoId

* Revert "Do in fact use ProtoId"

This reverts commit cdc0972cac.

* Actually add the event into the pool

* Remove ancient code

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-08-14 09:57:13 +00:00
No Elka a7df10b20d
Censer tweaks part 2 (#4171)
* Kill asphyx damage

* UI goidacode

* Locale

* I think this is needed too???

* Code stuff

* Code stuff

* Replace fuel with mindbreaker toxin

* Move censer to lockers

* Halve censer fuel capacity

* I sure hope the branch won't fucking explode

* Remove accidental line break

* blyat

* Update desc

* Move to nested fill
2025-08-13 11:34:50 +00:00
No Elka 8e45b2fa75
Allow cultists to absorb another rift after expending their empowerment (#4166)
* Kill

* Remove action on use
2025-08-13 11:28:27 +00:00
Quanteey c64d0563dc
Merge branch 'master' into upstream-merge-ops
Signed-off-by: Quanteey <61941975+Quanteey@users.noreply.github.com>
2025-08-10 18:59:17 +02:00
No Elka 90974a99b2
Remove do-after on null fragmentation (#4102)
* Change stuff

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

* Fix

* How did that even get here

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-08-09 14:30:19 +01:00
Quanteey b57229dbfa Fix NoCargoOrderArbitrage and a possible future crash 2025-08-08 12:12:16 +02:00
Quanteey 942b83fe03
Merge branch 'master' into upstream-merge-ops 2025-08-07 20:00:49 +02:00
Quanteey 6e03871555 Migrate _DV GhostRoleSystem.Character.cs to use new outfitsystem 2025-08-07 19:39:40 +02:00
Kyle Tyo 9ebebb041b Command resolves and LEC conversions batch 4 (#38382)
* reeeecolllaaaaaaaa

* gonna convert these to public while I'm here for consistency sake

* requested changes.
2025-08-07 19:30:32 +02:00
Kyle Tyo d5dccb809c Relocate SetOutfit method to ServerClothingSystem and LEC setoutfit command. (#38391)
* that'll do

* requested changes.

* missed this.
2025-08-07 19:30:19 +02:00
beck-thompson fac62f9d81 Fix stacks only recycling one instead of the stack amount (#38433)
* fix

* Fixes
2025-08-07 19:19:14 +02:00
Kyle Tyo 5273a6811e Command resolves (#38415)
touchups
2025-08-07 19:17:10 +02:00
Tayrtahn b6b1915cea Convert `AtmosphereSystem` sound path strings to `SoundSpecifier`s (#38403)
* Convert AtmosphereSystem sound path strings to SoundSpecifiers

* Convert to SoundCollections
2025-08-07 19:16:50 +02:00
Kyle Tyo fc18b3bc75 Command resolve mega pr batch 5 (#38389)
* commit progress

* requested changes
2025-08-07 19:16:44 +02:00
Kyle Tyo 5b2180ec34 Command resolve killing and LEC conversions batch 2 (#38367)
commit progress
2025-08-07 19:16:31 +02:00
Kyle Tyo 1039360c64 Command resolve mega pr 6 (#38398)
commit progress
2025-08-07 19:16:26 +02:00
Whatstone 9c9ce5e385 Add directionality to cable terminal port nodes (#38394) 2025-08-07 19:15:49 +02:00
Simon 4bad0c3cd6 Switch Discord integration to use NetCord instead of Discord.Net (#38400) 2025-08-07 19:15:43 +02:00
Perry Fraser a75ea1ab80 fix: erase expedition disks when their map is deleted (#38322)
* fix: erase expedition disks when their map is deleted

* fix: include paused entities in disk query, add dirty
2025-08-07 19:14:36 +02:00
Kyle Tyo d76afe3d72 Command resolve and LEC conversion batch 3 (#38378)
* I'm just a silly goober

* requested changes

* Update Content.Server/Interaction/TilePryCommand.cs

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-08-07 19:12:57 +02:00
Whatstone c80e8bd5e7 Fix adjacent north/south cable terminals breaking east/west HV cable (#38377) 2025-08-07 19:12:18 +02:00
kosticia 282c573c13 predicted hyposprays (#38046)
* G O I D A

* how

* now proper

* a

* Update HypospraySystem.cs

* good catch

* Apply suggestions from code review

---------

Co-authored-by: ScarKy0 <scarky0@onet.eu>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-08-07 19:03:52 +02:00
beck-thompson fa450fdff1 Objectives that do not fit requirements are now deleted (#38365)
* Fix

* Update Content.Server/Objectives/ObjectivesSystem.cs

Thanks Tayrathn!

Co-authored-by: Tayrtahn <tayrtahn@gmail.com>

---------

Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
2025-08-07 19:03:02 +02:00
Tayrtahn 1181854f82 Cleanup duplicate dependency in `AddActionCommand` (#38360)
Cleanup duplicate dependency in AddActionCommand
2025-08-07 18:49:09 +02:00
ScarKy0 b86884cf10 Commands for adding and removing actions (#38317) 2025-08-07 18:48:28 +02:00
Helix-ctrl 12cdedc99b Add hints towards flash protection to all items which provide it (#37267)
* Update welding.yml

* Update FlashSystem.cs

Add subscriber event for flash immunity examine text

* Create flash-immunity-component.ftl

* Removed changed description text

* change to use entity version

* fixed mistake
2025-08-07 18:45:39 +02:00
ScarKy0 7fed6632fb Retractable items system + Arm Blade action (#38150) 2025-08-07 18:41:36 +02:00
nikitosych fd6597d3da Fix for holoparasite's ability to attack the host through mech (#36659) 2025-08-07 18:38:36 +02:00
SyaoranFox 1496ff6e87 Zombies won't attack Initial Infected (#38128)
* Added Zombie faction roles everywhere that makes sense for initial infected to be associated with Zombies.

* Adding faction component to round start zombie. (not hopeful)

* Removed stupid attempts and added zombie faction component to the zombie system when the player is given the ability to force themself to zombify.

* Changed use of "zombie" for ProtoId<NpcFactionPrototype>

* Update Content.Server/Zombies/ZombieSystem.cs

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Update Content.Server/Zombies/ZombieSystem.cs

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Removed faction component from ZombieOutbreak event. Shouldn't cause problems with the event as II gets component with their ability to self zombify.

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-08-07 18:27:45 +02:00
slarticodefast 1cad639d60 Fix puncturase cauterizing bleeding (#38289)
fix puncturase cauterizing bleeding
2025-08-07 18:22:47 +02:00
themias b46e9f0046 Fix gas analyzer and anom scanner wrong state (#38285)
* Fix gas analyzer and anomaly scanner UI activation issue

* save

* fix comment

* milkalyzer
2025-08-07 18:09:58 +02:00
Perry Fraser 2185ba5e21 fix: Correct respath for lizard smite icon (#38288) 2025-08-07 18:09:54 +02:00
Perry Fraser a7bca8c91a Fix some popup issues with pipe layer changes (#38244)
* fix: only show pipe layer popups to the user changing them

* fix: don't show pipe layer subfloor popup when not using a screwdriver

* fix: properly pass down user and used for serverside pipe layer changes

Technically this doesn't matter as the Shared codepath for this method
doesn't actually use these on the server: only the user is used for a
clientside popup. Still, will be good to have these for future changes
that might need them.
2025-08-07 18:09:43 +02:00
RedBookcase 993c0d4c45 Removed Toys.rsi, reorganize toy RSIs, broad /Fun/ cleanup. (#37189)
Co-authored-by: RedBookcase <Usualmoves@gmail.com>
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
2025-08-07 17:44:39 +02:00
Quanteey 384054a27d Fix for previous 2025-08-07 16:15:07 +02:00
Simon e2739943dd Add the instrument names to the MIDI channel selector (#38083)
* Add the instrument to the MIDI channel selector

* Reviews

Adds support for chained masters
Makes the channel UI update on its own when the midi changes (Works with bands too!)

* add to admin logs and limit track count

* Limit track names by length too

* remove left over comment

* Requested changes

* Reviews
2025-08-07 12:04:09 +02:00
Cepelinas1 18d58fac84
Engraveable rings (#4103)
* rings first commit

* changes implemented

* moved engraving.ftl to other folder

* [pre-commit.ci] auto fixes from pre-commit.com hooks

for more information, see https://pre-commit.ci

---------

Co-authored-by: pre-commit-ci[bot] <66853113+pre-commit-ci[bot]@users.noreply.github.com>
2025-08-07 02:29:29 +01:00
Quanteey 40d7ea758f Revert "Add the instrument names to the MIDI channel selector (#38083)"
This reverts commit e16c03ed29.
2025-08-07 02:55:23 +02:00
Simon e16c03ed29 Add the instrument names to the MIDI channel selector (#38083)
* Add the instrument to the MIDI channel selector

* Reviews

Adds support for chained masters
Makes the channel UI update on its own when the midi changes (Works with bands too!)

* add to admin logs and limit track count

* Limit track names by length too

* remove left over comment

* Requested changes

* Reviews
2025-08-07 02:19:03 +02:00
Tayrtahn 781ec9b715 Forbid string literals for `SharedToolSystem` methods (#38250)
* Forbid string literals for ToolSystem methods

* Cleanup violations

* Sort usings
2025-08-07 02:15:21 +02:00
Tayrtahn c3c5a49860 Cleanup unused fields in `DrinkSystem` (#38181)
Cleanup unused fields in DrinkSystem
2025-08-07 01:59:26 +02:00
pathetic meowmeow a1f3ca6a69 Allow cargo request computers to send orders to the primary account (#37943) 2025-08-07 01:57:30 +02:00
Quanteey 100fe319a9 import unfuck redux 2025-08-07 01:51:49 +02:00
DrSmugleaf e85eacb1d4 Fix eating and drinking verbs showing up after a short delay and making your verb UI bounce (#38164)
* Fix eating and drinking verbs showing up after a short delay and making your verb UI bounce

* Usings fix

* Usings fix

* Usings fix

* Usings fix

* CVar fix

* Predicted ppups

* Openable predicted popup

* Fix audio prediction
2025-08-07 01:48:46 +02:00
Orsoniks c35279089c Improved Health examination text (#38126)
* more health examinations

* better blood

* fix

* tweaks

* sizeable

* silicon fix

* tweaks

* bleeding color tweaks

* fix
2025-08-07 01:36:36 +02:00
Kyle Tyo 70089b6f9e MapManager warnings cleanup Server Edition 2003 (#36781)
* now you see me

* unused depen

* test fail fix attempt 1

* test fail fix attempt 2

* fix test fail attempt 3

* shot in the dark.

* Does this work?

* import cleanup

* taking a shot at this.

* Convert PersistenceSaveCommand to LocalizedEntityCommands.

* requested changes

* requested changes. also dealt with improperly named private const

* Update Content.Server/GameTicking/GameTicker.Spawning.cs

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Update Content.Server/GameTicking/GameTicker.Spawning.cs

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Convert PlanetCommand to LocalizedEntityCommand

* Update BiomeSystem.cs

* Update Content.Server/Salvage/SalvageSystem.Runner.cs

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Update Content.Server/Procedural/DungeonSystem.Rooms.cs

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Update Content.Server/Salvage/SpawnSalvageMissionJob.cs

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Update Content.Server/Station/Systems/StationBiomeSystem.cs

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* revert to latest master.

* slartis suggestion.

* Update SetMapAtmosCommand.cs

* cleanup

* Update PersistenceSaveCommand.cs

* finish localizing persistencesavecommand

* this is icky, I change.

* :sigh:

* revert whatever I did here?

* oh I see, some inconsistencies.

* revert this

* Update PlanetCommand.cs

* move this ftl to the commands folder

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-08-07 01:36:00 +02:00
Samuka-C 73c2657d8c adjreagent now accepts float (#38134)
* adjreagent now accepts float

* var
2025-08-07 01:35:46 +02:00
Tayrtahn c467a49a7c Forbid string literals for `NpcFactionSystem` methods (#38140)
* Add ForbidLiteral attribute to NpcFactionSystem methods

* Cleanup resulting warnings
2025-08-07 01:33:00 +02:00
K-Dynamic d761cce130 Genpop wall lockers (#38102)
* sprites

* genpop wall lockers

* number 5 alive

* slight boilerplate code, thank you slarti
2025-08-07 01:24:14 +02:00
slarticodefast 13242382ab fix wallmount vending machine dispense direction (#38112)
fix wallmount vending machine direction
2025-08-07 01:20:38 +02:00
Kyle Tyo b5353746fa Add player autofill to rename command. (#38074)
* simple enough

* switch to CompletionResult.FromOptions and CompletionHelper.SessionNames

* cleanup
2025-08-07 01:04:29 +02:00
Tayrtahn db9b106602 Cleanup unused/redundant dependencies (#38099) 2025-08-07 01:02:04 +02:00
themias 79377f30ff Muzzles reduce emote sound (#34444)
* Muzzles reduce emote sound

* update based on review comments

* review comments
2025-08-07 01:00:26 +02:00
Quanteey eb11a3a9dd Access reader downstream unfucking 2025-08-07 00:52:12 +02:00
chromiumboy d30561e06a Access Reader Refactor (#37772)
* Initial commit

* Integration test fix

* Removed redundant dirtying of accessreader
2025-08-07 00:26:56 +02:00
Simon f4499df338 Split codewords into its own system (#37928)
* Split codewords into its own system

* Fix admin log

* Nuke unused code

* Fix formatting errors

* Fix tests

* Make the codeword system add itself if called when not active

* Put comment in right place.

* Review: Rename prototypes

* Review: Make codewords serializable

* Fix build

* Reviews: Change the system to not be a gamerule.

* Fix YAML Linter

* Fix test fail

* Remove unused import
2025-08-07 00:09:11 +02:00
Quanteey c85d501fb2 uwu 2025-08-07 00:01:48 +02:00
SlamBamActionman 82e31f5e80 Add Diona rooting (#32782)
* Initial commit

* Add sound

* Review commets

* addressing review

* I think this is what Slart meant?

* Review fixes

* More fixes

* tiny formatting

* Review fixes

* Review fixes

* Fix small timing error

* Follow new action system

* review

---------

Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
Co-authored-by: ScarKy0 <scarky0@onet.eu>
2025-08-06 23:57:34 +02:00
TheFlyingSentry 574f36cb71 Fixes electropacks not ignoring insulation (#38011)
Co-authored-by: TheFlyingSentry <Daniel.l.Elledge@gmail.com>
2025-08-06 23:46:55 +02:00
ScarKy0 42284decb8 Predict AME Fuel Examine (#38018)
* init

* :)
2025-08-06 23:42:02 +02:00
Krunklehorn 3469feabd5 Add checks for various complex interactions (#37246)
* Prevent toggling radiation collectors

* Prevent resisting locks

* Prevent unbuckling others, early exit before doafter

* Prevent camera and camera router setup

* Prevent rotating and flipping

* Also prevent adding the unbuckle verb.

* Revert ResistLocker changes

* Prevent emitter tampering

* Also prevent lock verb

* Prevent toggling welders

* Prevent gun open/close bolt, rack and switch mode

* Prevent toggling stun batons
2025-08-06 23:32:53 +02:00
BarryNorfolk 28fcf14220 Add multipart machines system (#35969) 2025-08-06 23:29:17 +02:00
Ciarán Walsh 6779e8ca83 Use distinct action labels for toggling internals on and off. (#36073)
* Use distinct action labels for toggling internals on and off.

* Implement specific actions for enabling/disabling internals

Avoids potential confusing race conditions where two people might perform the "Toggle Internals On" action an the same person,
which would have jsut toggled twice.

* If no gas tank, will give popup

---------

Co-authored-by: beck-thompson <beck314159@hotmail.com>
2025-08-06 23:27:43 +02:00
chromiumboy a5e16233e4 Layering for atmospheric pipes (#36124)
Co-authored-by: ArtisticRoomba <145879011+ArtisticRoomba@users.noreply.github.com>
Co-authored-by: Kevin Zheng <kevinz5000@gmail.com>
2025-08-06 22:53:27 +02:00
Princess Cheeseballs 1f4b5300ec [HOTFIX] Salvage Job Computer Eating your Jobs (#37997)
One line fix
2025-08-06 22:40:15 +02:00
slarticodefast 4d04f06894 Fix center of mass mispredict when placing tiles (#37969)
fix COM mispredict
2025-08-06 22:37:34 +02:00
Nemanja 2be8dee064 Add support for contextual information in EntityTables (#37737)
* Add context support for entityTables

* fix build fail

* comments

* Update Content.Shared/EntityTable/EntityTableSystem.cs

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-08-06 22:28:50 +02:00
Centronias 697879a0ee Decouple Lights from Toggleable Visuals (and headphone music notes bugfix) (#35341)
* - Combine enum keys `ToggleableLightVisuals` and `ToggleVisuals` into `ToggleableVisuals`
- Rename `ToggleableLightVisualsComponent` to `ToggleableVisualsComponent` and `ToggleableLightVisualsSystem` to `ToggleableVisualsSystem`
  - (The `SpriteLayer` field on the component is now required because the old default of `light` doesn't make sense anymore)
- Make it so that `ToggleableVisualsComponent` works even when there's not a light attached to the entity
  - (Amazingly this seems to have only applied to  Headphones, but I can only imagine there are many other things people would like to do with simple toggleable visuals)
- Explicitly make `ItemTogglePointLightComponent`'s purpose to make `ToggleVisualsComponent` apply to `PointLightComponent`s on the same entity.
  - Add field `ToggleableVisualsColorModulatesLights`, which makes the `Color` appearance value of `ToggleableVisuals` modulate the color of lights on the same entity
  - Lots of prototype updates to uptake the above

* fix bad merge

* unbork robust

* blindly letting rider reformat stuff

* I guess I never cleaned up these imports at all
2025-08-06 22:06:58 +02:00
Fildrance 3a963de67d fix: anomaly shooting no longer throws when it have no possible targets in range (#37927)
Co-authored-by: pa.pecherskij <pa.pecherskij@interfax.ru>
2025-08-06 22:05:48 +02:00
ArtisticRoomba a625367d07 Show TEG theoretical supply on inspect (#37957)
* Show TEG theoretical supply on inspect

* revert autoformatting changes
2025-08-06 22:05:16 +02:00
Obani Gemini 13cbf9606c Improved French accent (th sound) (#33630)
* Improved French accent

* Remove the double consonna part to simplify the code and behaviour

* French accent: clarify a comment

Co-authored-by: Centronias <charlie.t.santos@gmail.com>

---------

Co-authored-by: Centronias <charlie.t.santos@gmail.com>
2025-08-06 22:04:48 +02:00
beck-thompson c831ae3f0c Chameleon controller implant (Clothing fast switch) (#33887)
* Add the chameleon controller implant

* address the issues (Git please dont kill me)

* Address the review and fix some merge conflicts!

* Cleanup

* Add use delay

* Silly mistakes

* Making a PR at 2 am: Gone wrong

* Predict use delay and disable the buttons until you can choose another

* First phase custom clothing

* Better system, now relays to agent id and mindshield. Chameleon loadouts are a lot better to work with as well

* Address the review! No more evil goto

* Slams way is better I should have read more closely xD

* Some of the jobs

* Add to Cargo, CentComm, Service, Passenger, Ninja, Cluwne, Wizard + Minor changes to existing; Add chameleon to bandanas, medals, jugsuits and HUDs

* Add everything else

* Fix test

* Job name

* This looks better

* Add department organization

* Minor cleanup

* Added some mindshields

* Remove redudent comment and change funcion name to be clearer

* Fix cluwne outfit

* fix merge conflicts

---------

Co-authored-by: SlamBamActionman <slambamactionman@gmail.com>
2025-08-06 21:56:47 +02:00
mhamster a96c4369c4 Chameleon clothes + EMP behaviour (#30924)
* resolving conflicts??

* Controlled clothes changing

+ time stuff
+ EmpChangeIntensity

* Single clothes change

+ EmpContinious
+ moved random pick logic into GetRandomValidPrototype

* Changes from reviews

Co-Authored-By: Nemanja <98561806+emogarbage404@users.noreply.github.com>

* Update ChameleonClothingComponent.cs

* repairing irreparable damage

i failed, did i?

* damaging repaired irreparable

uh???

* 2025 FUN ALLOWED!!!!

* Minor changes from reviews

Co-Authored-By: beck-thompson <107373427+beck-thompson@users.noreply.github.com>

* Fix merge conflicts

* Fix that last bug

* cleanup

* Remove VV attr.

* AutoPausedField on emp time change

---------

Co-authored-by: Nemanja <98561806+emogarbage404@users.noreply.github.com>
Co-authored-by: beck-thompson <107373427+beck-thompson@users.noreply.github.com>
Co-authored-by: beck-thompson <beck314159@hotmail.com>
Co-authored-by: EmoGarbage404 <retron404@gmail.com>
2025-08-06 21:13:41 +02:00
Quantum-cross b1c14262a2 Make `TryGetWires<T>` actually work. (#37937) 2025-08-06 21:08:06 +02:00
pathetic meowmeow 4ee86c0164 Actually handle nutrition and robust harvest entity effects (#37912) 2025-08-06 20:56:56 +02:00
TemporalOroboros 3a9d07fdef Fix obsolete MapGridComponent warning in SpawnAfterInteractSystem (#37911) 2025-08-06 20:56:45 +02:00
TemporalOroboros 0a007d9b41 Fix obsolete method warning in SimpleFloorPlanPopulatorSystem (#37910)
Fix obsolete method warning
2025-08-06 20:56:32 +02:00
Quanteey cef0fe7484 Fixes and migrating downstream yamls to use action system 2025-08-06 20:10:06 +02:00
deltanedas fb448bb7b5 action refactor proper ecs edition (#27422)
Migrated downstream YAMLs to the new action system
2025-08-06 20:08:30 +02:00
Tayrtahn 1acd544d57 Cleanup warning in `StealConditionSystem` (#37903)
Fix 1 warning in StealConditionSystem
2025-08-05 20:00:22 +02:00
metalgearsloth 1c49eb4737 Content changes required for physicsmap purge (#37878)
* PhysMap changes

* Fix call

* Avoid tilefriction resolve

yummy

* a
2025-08-05 19:18:09 +02:00