Commit Graph

9666 Commits

Author SHA1 Message Date
deltanedas 990e3305fa Merge branch 'upstream-ops' 2025-01-16 12:44:11 +00:00
rosieposie 3204aa8c50
Acidifying Sec Crates & Emergency Lasers (#2672)
* adds three PRs!

* random failure

* Update AntiTamperSystem.cs

* Update cargo_technician.yml

* Update cargo_technician.yml

* armory & sec crates only

* untouch

* review fixes

* more tweaks
2025-01-16 12:37:56 +00:00
deltanedas fa50ae5986 merge master 2025-01-14 15:05:15 +00:00
beck-thompson 45ea7451ca
Fixed various issues with kill objectives (#2723)
The fix is in doc!
2025-01-14 14:14:01 +00:00
Lyndomen f8c86e2c5d
Port: Disable round end pacifism and add a new command to pacify everyone (#2642)
* pacify stuff from Harmony

* pacify stuff from Harmony

* error ops

* yeag
2025-01-13 15:21:05 -05:00
Dirius77 fc3d428f1a
Increase Tesla fade time (#2710) 2025-01-12 23:16:00 +00:00
deltanedas 8f9e62edbc remove FastAccessors from deep frier 2025-01-12 08:57:25 +00:00
Errant e7cd9bc0dc Role Types (#33420)
* mindcomponent namespace

* wip MindRole stuff

* admin player tab

* mindroletype comment

* mindRolePrototype redesign

* broken param

* wip RoleType implementation

* basic role type switching for antags

* traitor fix

* fix AdminPanel update

* the renameningTM

* cleanup

* feature uncreeping

* roletypes on mind roles

* update MindComponent.RoleType when MindRoles change

* ghostrole configuration

* ghostrole config improvements

* live update of roleType on the character window

* logging stuff and notes

* remove thing no one asked for

* weh

* Mind Role Entities wip

* headrev count fix

* silicon stuff, cleanup

* exclusive antag config, cleanup

* jobroleadd overwerite

* logging stuff

* MindHasRole cleanup, admin log stuff

* last second cleanup

* ocd

* move roletypeprototype to its own file, minor note stuff

* remove Roletype.Created

* log stuff

* roletype setup for ghostroles and autotraitor reinforcements

* ghostrole type configs

* adjustable admin overlay

* cleanup

* fix this in its own PR

* silicon antagonist

* borg stuff

* mmi roletype handling

* spawnable borg roletype handling

* weh

* ghost role cleanup

* weh

* RoleEvent update

* polish

* log stuff

* admin overlay config

* ghostrolecomponent cleanup

* weh

* admin overlay code cleanup

* minor cleanup

* Obsolete MindRoleAddedEvent

* comment

* minor code cleanup

* MindOnDoGreeting fix

* Role update message

* fix duplicate job greeting for cyborgs

* fix emag job message dupe

* nicer-looking role type update

* crew aligned

* syndicate assault borg role fix

* fix test fail

* fix a merge mistake

* fix LoneOp role type

* Update Content.Client/Administration/AdminNameOverlay.cs

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Update Content.Shared/Roles/SharedRoleSystem.cs

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* comment formatting

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* change logging category

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* fix a space

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* use MindAddRoles

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* get MindComponent from TryGetMind

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* move var declaration outside loop

* remove TryComp

* take RoleEnum behind the barn

* don't use ensurecomp unnecessarily

* cvar comments

* toggleableghostrolecomponent documentation

* skrek

* use EntProtoId

* mindrole config

* merge baserolecomponent into basemindrolecomponent

* ai and borg silicon role tweaks

* formatting

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* I will end you (the color)

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* use LocId type for a locale id

* update RoleEvent documentation

* update RoleEvent documentation

* remove obsolete MindRoleAddedEvent

* refine MindRolesUpdate()

* use dependency

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* inject dependency

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* roleType.Name no longer required

* reformatted draw code logic

* GhostRoleMarkerRoleComponent comment

* minor SharedRoleSystem cleanup

* StartingMindRoleComponent, unhardcode roundstart silicon

* Update Content.Shared/Roles/SharedRoleSystem.cs

* remove a whitespace

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2025-01-12 08:26:32 +00:00
Leon Friedrich 87e570c2c8 Remove Entity<T> data-fields (#34083) 2025-01-12 08:17:19 +00:00
Zachary Higgs 0b1e1b8ac3 Make indestructible tiles not breakable by explosions (#34339)
* No more Ai Spacing

* Move guard into earlier guard statement
2025-01-12 08:17:18 +00:00
Tayrtahn cf1c941c95 Let ghosts sometimes make certain devices say creepy things (#34368)
* Add SpookySpeaker component/system

* Shuffle Boo action targets before trying to activate them

* Add SpookySpeaker to vending machines

* Fix chatcode eating messages starting with "..."

* Add SpookySpeaker to recycler

* Oops

* Decrease speak probability for vending machines

* Add spooky speaker to arcade machines
2025-01-12 08:17:18 +00:00
Tayrtahn 8e8bc3695e Add a popup message when ghost Boo action does nothing (#34369) 2025-01-12 08:17:18 +00:00
Leon Friedrich 65458362c5 Replace some sound PlayEntity with PlayPvs (#34317) 2025-01-12 08:15:23 +00:00
Southbridge 20415a6894 Add copy threshold button to air alarms (#34346) 2025-01-12 08:14:50 +00:00
Errant 8544328a5b Fix battery charging stopping just short of being full (#34028) 2025-01-12 08:14:50 +00:00
ScarKy0 dc2fc5441a Fix access configurator debug assert (#34330)
* fix

* greytide fix

* fix admin log

* Dirty
2025-01-12 08:14:50 +00:00
c4llv07e 6dc50752e8 Fix empty lines in adminwho with stealthmins. (#34122)
Don't print newline if admin is hidden.
2025-01-12 08:14:19 +00:00
Tayrtahn 4e12779b49 Add bleating accent to goats (#34273) 2025-01-12 08:14:04 +00:00
SlamBamActionman 7992a69376 Add Chameleon PDA (#30514)
* V1 commit

* Remove PDA name and unnecessary pda state

* Adds PDA to Chameleon backpack & thief toolbox

* Change to use AppearanceDataInit

* Add basic PDA state to ensure there's always a sprite before AppearanceData can be applied

* Revert PDA name (this will be changed to another way later)

* Update PDA name updating to new system

* Fix yaml, and fix Agent ID chameleon

* Updated based on review
2025-01-12 08:05:13 +00:00
Dylan Hunter Whittingham c8a77a1821 Added pricegun sound (#34119)
added pricegun sound

Co-authored-by: dylanhunter <dylan2.whittingham@live.uwe.ac.uk>
2025-01-12 07:46:00 +00:00
Dylan Hunter Whittingham 8165b3ea11 added basic admin logs for PDA notekeeper notes (#34118)
* added basic admin logs for PDA notekeeper notes

* formatting

* added new LogType 'PdaInteract' and changed PDA notekeeper logs to it

---------

Co-authored-by: dylanhunter <dylan2.whittingham@live.uwe.ac.uk>
2025-01-12 07:45:11 +00:00
chromiumboy cd3d35b4f0 Bugfix for the AI player's eye getting stuck when their broadcast is interrupted (#34093)
Initial commit
2025-01-12 07:44:52 +00:00
Janet Blackquill 056c98c054
Replace ForcedSleep with Anesthesia for surgery (#2684)
* Replace ForcedSleeping with Anesthesia for surgery checks

* Add Anesthesia to NO2, Nocturine, and ChloralHydrate
2025-01-11 06:44:50 +00:00
deltanedas 60c529140d
mediborg candy refactor (#2639)
refactor borg candy and move to shared _DV namespace

Signed-off-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
Co-authored-by: deltanedas <@deltanedas:kde.org>
2025-01-09 18:04:48 +00:00
deltanedas 17d0861596
make limb severing bleed instead of bloodloss damage (#2668)
Co-authored-by: deltanedas <@deltanedas:kde.org>
2025-01-09 18:02:34 +00:00
deltanedas cfdf734e7a
Revert "allow cloning living people (#932)" (#2667)
This reverts commit c8ad050c69.

Co-authored-by: deltanedas <@deltanedas:kde.org>
2025-01-09 12:39:39 +00:00
beck-thompson f49135686d
Feedback popup command (#2663)
* first commit

* Localized entity command pro

* Not sure this is amazing

* evil lines are gone
2025-01-09 06:43:32 +00:00
Stop-Signs d6b7f74fb9
Butlerops PT 2 (#2661)
Yummers
2025-01-09 04:50:43 +00:00
Joe 29879a151f
Add pronouns to crew manifest (#2647)
* Refactored crew manifest

* Add Delta-V Comments, Move locale file to _DV scope.

* Missed adding comments to a file.

* Made the comments slightly more verbose to make it clear why the changes were made.

* Comments are love, comments are life.

---------

Co-authored-by: TGRCDev <tgrc@tgrc.dev>
2025-01-08 11:39:09 +00:00
deltanedas 52611d29c9
small shitmed update (#2649)
* fix most sharp things not being usable in surgeries (#1381)

Co-authored-by: deltanedas <@deltanedas:kde.org>

* somewhat untroll harpy body parts

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2025-01-08 06:11:31 +00:00
deltanedas 83a8002922
Merge pull request #2542 from deltanedas/shitmed-ops
shitmed real
2025-01-07 17:15:23 +00:00
deltanedas a28dba9359
fix holopads for ai for real (#2640)
change return to continue

Co-authored-by: deltanedas <@deltanedas:kde.org>
2025-01-07 17:04:08 +00:00
deltanedas 27bfa35f53
Speech is relayed by holopad holograms (#33978) (#2631)
* Initial commit

* Corrected a field attribute

Co-authored-by: chromiumboy <50505512+chromiumboy@users.noreply.github.com>
2025-01-06 17:14:57 +00:00
deltanedas 7840ad75b7 spacing does 1/5 damage to limbs 2025-01-06 02:59:38 +00:00
deltanedas 1f01adef38
Merge pull request #2589 from deltanedas/upstream-ops
upstream merge 2/1/25
2025-01-06 01:35:55 +00:00
deltanedas 659565c528
no using headsets when cuffed (#2610)
Co-authored-by: deltanedas <@deltanedas:kde.org>
2025-01-05 05:44:05 +00:00
deltanedas 84c0b3e895
snipe qol prs from upstream (#2614)
* Remove discard functionality from the ChemMaster

This duplicates other methods of discarding chemicals, including
the drain conventionally given to chemistry labs.

Any problems it solves are miniscule compared to the severe UI error
that is having a destructive action without confirmation attached
to a mode, the most common source of user error.

* Improve animal cube interactions (#31668)

* Working on dehydrate recipes to renew animal cubes

* Added remaining cube dehydration recipes

* Add OnExamine to RehydratableSystem.cs, need to add functionality to check total volume vs current volume to determine if 'soaked' text needs to be displayed

* Added logic to append text to the description when the wrong reagent has been added to a compressed animal cube

* Re-adding deleted summary

* Update default SolutionName to be correct

* Remove cube recipes to prevent infinite nutrient generation

* Add OnMicrowaved event to RehydratableSystem.cs in order to clear solution of cube when microwaved. CURRENT ERROR REQUIRES REFACTOR OF MICROWAVECOMPONENT

* Subscribe to microwave event

* Refactor of MicrowaveComponent.cs to be in shared folder, accessible to RehydratableSystem.cs. Updated imports

* Modify cube to only dehydrate in microwave when cooked for at least 5 seconds

* now using event to check access to fingerprint

* Tweak - Reflective vest and Energy Katana should reflect only in correct slots (#31902)

* ReflectComponentLogicFix
Added bool InRightPlace and updated relevant system

* Using SlotFlags

* prevent friendly fire for dragon/carp (#32231)

* add NoFriendlyFire

* make zombies use NoFriendlyFire

* no friendly fire for dragon

* let dragon kill naughty fish and validhunting syndies

* add button to print logprobe logs (#32255)

* add EntityName at the bottom of LogProbe

* add button to print logprobe logs

* Add camera mod to diagnostic hud (#32254)

* ai-glass

* weh to protect against bad grammar

* transmutation into diagnostic hud

* Apply forensics when loading with an ammo box

* inaprovaline metabolizes slower

* :trollface:

---------

Co-authored-by: Janet Blackquill <uhhadd@gmail.com>
Co-authored-by: Preston Smith <Blackfoot03@outlook.com>
Co-authored-by: YourUsername <you@example.com>
Co-authored-by: BIGZi0348 <svalker0348@gmail.com>
Co-authored-by: deltanedas <@deltanedas:kde.org>
Co-authored-by: ArZarLordOfMango <arzarchannel@gmail.com>
Co-authored-by: themias <themias5@gmail.com>
Co-authored-by: Alzore <blackern5000@gmail.com>
2025-01-05 03:55:34 +00:00
deltanedas 57402795f2 evil surgery damage and change stuff to work for it 2025-01-04 05:39:38 +00:00
sleepyyapril f4efc57194
Discord AHelp Reply System (#2315)
* Discord Ahelp Reply System (#2283)

* First part of Remote Bwoinking

* This should technically work

* No Actoring

* Fixes Guid not sending over

* Making it work for the final.

* Fixes for api

* Moar Commants!

Just more Comments to mark Frontier changes.

* comment

* wops

* Fixes Naming Rules

* I Should also fix the naming in the actually code...

* Testing some new code

* Naming rule and dependency fix (hopefully)

* Serverside Webhook update on external sent ahelp messages

* Still get data from custom URL's, even if it dosent match a discord webhook

* Apply suggestions from code review (Part 1)

Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com>

* Apply suggestions from code review (Part 2)

* Bwoink system suggsetions

* missing BwoinkSystem changes

* Change access on BwoinkSystem._messageQueues

* Updates the Regex to support other Discord Clients (beta, alpha)

* Merge Fixes

* BwoinkSystem: explicitly match "canary."/"ptb."

---------

Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com>
Co-authored-by: Whatstone <whatston3@gmail.com>

* All the configuration

* CVar to use admin OOC color

* Fix description.

* Review changes

* Review changes

* Review changes

---------

Co-authored-by: Myzumi <34660019+Myzumi@users.noreply.github.com>
Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com>
Co-authored-by: Whatstone <whatston3@gmail.com>
2025-01-04 00:31:42 +00:00
deltanedas 06fb0846f2 make gun executions target the head 2025-01-03 21:19:58 +00:00
deltanedas 8d653b3547
fix precognition spamming late round events (#2608)
Co-authored-by: deltanedas <@deltanedas:kde.org>
2025-01-03 18:59:24 +00:00
DisposableCrewmember42 4134dce77e
fix: glimmer probers now explode when unanchored due to grid change (#2606)
tweak: glimmer probers now explode when unanchored due to grid change
2025-01-03 18:06:24 +00:00
beck-thompson 36a18def82
Feedback popups (#2561)
* First commit

* Added webhook

* Added round number support

* More fixes

* Fixes

* Merge conflict begone

* how is that even possible
2025-01-02 22:22:04 +00:00
deltanedas e2b7907e79
more harmless critters from events (#2518)
* more harmless critters from events

* adjust it to be less extreme

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2025-01-02 22:18:09 +00:00
deltanedas 3adee14052
make nanochat notifications more robust (#2565)
* add IsClosed and avoid unnecessary dirty calls

* make nanochat notifications more robust

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2025-01-02 22:16:10 +00:00
Stop-Signs 80d20fbe68
Update butlertron foods and payout (#2500)
* Holy shit this took forever

* fucking mothmallows

Signed-off-by: Stop-Signs <stopsign221@gmail.com>

* Fucking weed

Signed-off-by: Stop-Signs <stopsign221@gmail.com>

---------

Signed-off-by: Stop-Signs <stopsign221@gmail.com>
Co-authored-by: deltanedas <@deltanedas:kde.org>
2025-01-02 22:15:36 +00:00
deltanedas e68655a477 untroll 2025-01-02 21:48:47 +00:00
ReeZer2 115f8e68c8 FIX: Thief beacon doubled steal targets (#33750) 2025-01-01 17:20:46 +00:00
chromiumboy 813de46c18 Holopads no longer log broadcasted speech and emotes in the chat (#34114)
Initial commit
2025-01-01 17:19:49 +00:00
chromiumboy 352f9921e8 Holopad UI tweak for incoming calls (#34137)
* Initial commit

* Update

* Comment correction

* Minor margin increase
2025-01-01 17:19:49 +00:00
chromiumboy 7cfedd2651 UI improvements for holopads (#34055)
* Initial commit

* Minor update
2025-01-01 17:16:48 +00:00
psykana 4257b25ea1 Traitor can no longer get multiple objectives to save/help/kill the same person (#33704)
* Deduplicate traitor objectives

* Remove redundant check
2025-01-01 17:16:47 +00:00
crazybrain23 c1d0f357b2 Arrivals blacklist for bluespace lockers and QSIs (#34072)
* Ensure Arrivals Blacklist in Bluespace Locker rule

* While I'm at it, stop the QSI too

* fix thing I broke somehow

* Every bluespace locker arrivals blacklisted

* Add ArrivalsBlacklist to the prototypes too
2025-01-01 17:11:44 +00:00
Pieter-Jan Briers dd8cc6f243 Fix race condition causing disconnected admins to appear in adminwho (#34033) 2025-01-01 17:10:37 +00:00
amatwiedle b60b81e1fa Fix borgs being able to drink from buckets and spray bottles. (#32964)
* Added a check for if the entity trying to drink is a borg.

* Fixed missing namespace issue.

* Improved code conciseness.

* Removed borg chassis check, added stomach check.

* Removed unused namespace

---------

Co-authored-by: dankeaj <andrewjdanke@gmail.com>
2025-01-01 17:10:26 +00:00
deltanedas 8360e715c2
stock market refactor (#2141)
* stock market refactor

* PlayEntity

* make client use int

* refactor and fix cartridge system

* fix

* deny sound if it fails

* reviews

* thank you ss14

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2025-01-01 13:47:42 +00:00
deltanedas 36d634bdff
shipyard ui cleanup (#1257)
* small cleanup

* use BankClient for balance updating

* pro

* fixes fixes fixes

* untroll engine

---------

Signed-off-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
Co-authored-by: deltanedas <@deltanedas:kde.org>
Co-authored-by: Tad "Taddy" Johnson <120885811+TadJohnson00@users.noreply.github.com>
Co-authored-by: Milon <milonpl.git@proton.me>
Co-authored-by: Milon <plmilonpl@gmail.com>
2025-01-01 13:47:28 +00:00
deltanedas 9ece272884 merge master 2025-01-01 09:14:40 +00:00
deltanedas ec94579ebc
the great namespace refactor (#2574)
* refactor DeltaV/deltav resources to _DV

* change DeltaV namespaces to _DV

* add space before all DeltaV comments

* update xamls

* fix and move arena parallax to _DV

* more fix

* refactor even more stuff

* fix the grid fills

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2025-01-01 07:50:34 +00:00
deltanedas b83ee1b5c7 make mousetraps damage your feet 2024-12-31 08:47:10 +00:00
deltanedas 2849f56a43
refactor harpy singing visuals into InstrumentVisuals (#2564)
Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-12-31 01:12:43 +00:00
Dvir 07da7ec901
Diona immune to FTL Knockdown (#2543)
* Strong

* Update ShuttleSystem.FasterThanLight.cs

Signed-off-by: Dvir <39403717+dvir001@users.noreply.github.com>

---------

Signed-off-by: Dvir <39403717+dvir001@users.noreply.github.com>
2024-12-28 05:35:10 +00:00
deltanedas 83959a4fa9 random fixes 2024-12-27 17:48:54 +00:00
deltanedas f39c249948 add autodoc (#970)
Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-12-27 17:13:36 +00:00
gluesniffler a3ccc297e6 Major Shitmed Bugfixes (#1003) 2024-12-27 17:13:03 +00:00
deltanedas dc703f6adb make any sharp item a ghetto surgery tool (#990)
Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-12-27 17:08:25 +00:00
deltanedas 81e7366e9a surgery changes for autodoc (#969)
Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-12-27 17:08:22 +00:00
deltanedas 80b726539c fix surgerytarget check (#972)
Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-12-27 17:08:18 +00:00
gluesniffler fd11cee0e0 Shitmed Update 2 - bottom text (#956)
* full fucking send

* ope forgot to remove the EE scripts

* fix test

* fix shitcode fail

* DELTA THAT VALUE IS NULLABLE

* whoopsie daysie

* fixed???

* chat is this real
2024-12-27 17:02:58 +00:00
deltanedas c8ad050c69 allow cloning living people (#932)
* allow cloning living people

* fix client

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-12-27 16:54:19 +00:00
gluesniffler bf33742d18 Shitmed Update 1 - Forma de Goob (#897)
* full fucking send

* ope forgot to remove the EE scripts

* fix test

* fix shitcode fail

* DELTA THAT VALUE IS NULLABLE

* whoopsie daysie
2024-12-27 16:53:52 +00:00
deltanedas a778a9b8d8 they did surgery on a fish (#889)
* add breathing immunity and organ status effects

* they did surgery on a fish

* fix error for installing parts on non-humanoids

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-12-27 16:51:10 +00:00
deltanedas 67b0a95b2f add ghetto surgery real (#884)
* move MatchstickComponent to shared

* add Speed field to ISurgeryTool, add Tweezers and Tending tools

* add support for ghetto surgery tools

* use Tending and Tweezers for some steps

* GHETTO SURGERY!!!

* add qualities to fire axe

* fix popups

* :trollface:

* disable coil hemostat

* add examine verb for a tools uses

* work#

* round the speed to 2 decimal places

* remove .

* webedit ops

* shitcode

* undo breaking change

* fix

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-12-27 16:50:53 +00:00
gluesniffler da885d8854 Shitmed (#869)
* full fucking send

* ope forgot to remove the EE scripts

* fix test

* fix shitcode fail
2024-12-27 16:47:20 +00:00
username ba34712789 ok 2024-12-27 16:40:58 +00:00
whateverusername0 b496993ee6 lol!!! 2024-12-27 16:40:05 +00:00
Avalon 9a22c09da6
Port Magic Crayon From Frontier (#2410)
* ART

* Update clown.yml

* Loadout fixes, time req

* loadout bgone

* Fixes, moved things

* fixoneoops

* More fixes

* CRAFTING WORKS!

* Flipped slashes

* UNTOUCHED! AT LAST

* Fix comment

* Mailladd

* Webedit ops

Signed-off-by: Avalon <jfbentley1@gmail.com>

* untroll indent

Signed-off-by: deltanedas <39013340+deltanedas@users.noreply.github.com>

---------

Signed-off-by: Avalon <jfbentley1@gmail.com>
Signed-off-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
Co-authored-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
2024-12-27 15:05:15 +00:00
deltanedas afe588d506
salvage points shop (#2510)
* add conscription bag

* add gar mesons

* remove salvage vendor restock

* add code for shop vendors

* make salvage vendor a shop vendor

* ui fixes

* :trollface:

* update locker and vendor inventory

* add mining hardsuit for 3k

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-12-27 03:06:17 +00:00
SolStar b5a7e1bc92
Precog fixes (#2519)
Fix Precog results not cached on init
2024-12-23 21:58:03 +00:00
deltanedas 3204e46c10
fix vent critters rarely spawning anything (#2517)
* update events to use entity tables

* change Entries to Table in the component

* update rule and add log

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-12-23 15:34:18 +00:00
deltanedas 69db4ca0d3
cleanup more stuff (#2481)
* ICEE cleanup

* full cleanup of precognition

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-12-23 10:46:05 +00:00
deltanedas 9beaf06897
vent critters rework (#2495)
* vent critters rework

* change pests timer to 15

* nullspace check and loggy

* OH

* 15 -> 30 seconds

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-12-23 10:45:33 +00:00
deltanedas 13a1e1fda2
Merge pull request #2496 from deltanedas/upstream-ops
upstream merge 21/12
2024-12-22 20:05:08 +00:00
deltanedas cb4a5df2cb
add tape recorder (#2498)
* add tape recorder

* add filled tape recorder to trinkets

* :trollface:

* :trollface:

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-12-22 20:04:02 +00:00
beck-thompson 0b9ac4cbf7
Add kill fellow traitor objective (#2488)
* add feature

* opps

* fixes

* increase weight to 0.2

Signed-off-by: deltanedas <39013340+deltanedas@users.noreply.github.com>

---------

Signed-off-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
Co-authored-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
2024-12-21 13:51:52 +00:00
deltanedas 3bcbea673f :trollface: 2024-12-21 11:16:06 +00:00
Leon Friedrich a41c511e07 Toolshed refactor (#33598)
* Content changes for engine toolshed PR

* add contains command

* more permissive commands
2024-12-21 10:26:06 +00:00
metalgearsloth 57628b8742 Implement some field-level deltas (#28242)
* Update GasTileOverlayState

* Update DecalGridState

* Update NavMapState

* poke

* poke2

* poke3

* Implement field deltas for guns

* Content done

* Update

---------

Co-authored-by: ElectroJr <leonsfriedrich@gmail.com>
2024-12-21 10:25:48 +00:00
ScarKy0 3267b261b7 Increase syndicate uplink discount amount to 6. (#33950)
* Increase uplink discounts from 3 to 7

* nevermind, 6
2024-12-21 10:25:23 +00:00
beck-thompson ae8e1d9c27 Add clearer defib cooldowns! (#31251)
* First commit

* Fix silly test

* Swiched stuff up

* Update Content.Shared/Medical/DefibrillatorComponent.cs

* remove unneeded visuals

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2024-12-21 10:25:22 +00:00
chromiumboy 656eea1085 Minor fixes for the holopad (#33969)
Initial commit
2024-12-21 10:21:57 +00:00
chromiumboy 8de252e30e Tweaks for the holopad (#33928)
* Initial commit

* AIs get a warning when trying to answer long distance calls

* Better handling of ending telephone calls

* Fixed issue with duplicated holopad window when an AI answers a summons

* Changed how ranges are handled, added the bluespace holopad

* Bug fixes

* More bug fixes

* More bug fixes

* Update Resources/Prototypes/Entities/Structures/Machines/holopad.yml

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Update Resources/Prototypes/Entities/Structures/Machines/holopad.yml

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2024-12-21 10:21:09 +00:00
Centronias eeba6b3b28 Logic Gate Compatibility with Non-Logic Signals bugfix (#33792)
:)
2024-12-21 10:20:57 +00:00
ArtisticRoomba 1737f9ee94 Show battery level for selected devices in Power Monitoring Console (#33854)
* Use class instead of out variables

* Show battery level in power monitoring console

* Better color contrast for battery level + localized string

* Add visualization to battery percentage

* Reverts random ChatSystem.cs whitespace change

* Address review

* Show BatteryLevel stats in child view when selecting devices

---------

Co-authored-by: Crotalus <crotalus@users.noreply.github.com>
2024-12-21 10:20:42 +00:00
Ed 3a4dcb9ee6 Sprite Movement working with AI movement (#33494)
* FINALLY

* Update animals.yml
2024-12-21 10:19:51 +00:00
slarticodefast 88f7e91d63 Only disable panicbunker for admins with AdminFlags.Admin (#33879)
* Only disable panicbunker for admins with AdminFlags.Admin

* nicer curly braces
2024-12-21 10:18:30 +00:00
Centronias 8a1574cb84 Reduce network burden of the hunger system (#32986)
* reduce network burden of the hunger system

* explicit start + last updated

* remove auto reformat changes to otherwise untouched code

add clamp helper

* imagine making breaking changes, documenting them, and then not thinking to check the yaml

* comments

* Remove unused net manager in hunger system
Remove lastAuthoritativeHungerValue from prototypes
2024-12-21 10:17:05 +00:00
chromiumboy dc44048047 Holopads (#32711)
* Initial resources commit

* Initial code commit

* Added additional resources

* Continuing to build holopad and telephone systems

* Added hologram shader

* Added hologram system and entity

* Holo calls now have a hologram of the user appear on them

* Initial implementation of holopads transmitting nearby chatter

* Added support for linking across multiple telephones/holopads/entities

* Fixed a bunch of bugs

* Tried simplifying holopad entity dependence, added support for mid-call user switching

* Replaced PVS expansion with manually networked sprite states

* Adjusted volume of ring tone

* Added machine board

* Minor features and tweaks

* Resolving merge conflict

* Recommit audio attributions

* Telephone chat adjustments

* Added support for AI interactions with holopads

* Building the holopad UI

* Holopad UI finished

* Further UI tweaks

* Station AI can hear local chatter when being projected from a holopad

* Minor bug fixes

* Added wire panels to holopads

* Basic broadcasting

* Start of emergency broadcasting code

* Fixing issues with broadcasting

* More work on emergency broadcasting

* Updated holopad visuals

* Added cooldown text to emergency broadcast and control lock out screen

* Code clean up

* Fixed issue with timing

* Broadcasting now requires command access

* Fixed some bugs

* Added multiple holopad prototypes with different ranges

* The AI no longer requires power to interact with holopads

* Fixed some additional issues

* Addressing more issues

* Added emote support for holograms

* Changed the broadcast lockout durations to their proper values

* Added AI vision wire to holopads

* Bug fixes

* AI vision and interaction wires can be added to the same wire panel

* Fixed error

* More bug fixes

* Fixed test fail

* Embellished the emergency call lock out window

* Holopads play borg sounds when speaking

* Borg and AI names are listed as the caller ID on the holopad

* Borg chassis can now be seen on holopad holograms

* Holopad returns to a machine frame when badly damaged

* Clarified some text

* Fix merge conflict

* Fixed merge conflict

* Fixing merge conflict

* Fixing merge conflict

* Fixing merge conflict

* Offset menu on open

* AI can alt click on holopads to activate the projector

* Bug fixes for intellicard interactions

* Fixed speech issue with intellicards

* The UI automatically opens for the AI when it alt-clicks on the holopad

* Simplified shader math

* Telephones will auto hang up 60 seconds after the last person on a call stops speaking

* Added better support for AI requests when multiple AI cores are on the station

* The call controls pop up for the AI when they accept a summons from a holopad

* Compatibility mode fix for the hologram shader

* Further shader fixes for compatibility mode

* File clean up

* More cleaning up

* Removed access requirements from quantum holopads so they can used by nukies

* The title of the holopad window now reflects the name of the device

* Linked telephones will lose their connection if both move out of range of each other
2024-12-21 10:13:32 +00:00
Patrik Caes-Sayrs 55baf525e1 Zombies keep their anomalies on zombification (#33867)
* Zombies keep their anomalies on zombification

* Refactor anombies to isolate anomalies and zombies

InnerBodyAnomalies now send an event when the host dies.
Zombies cancels this event if the host is turning into a zombie.

* Anomazombies: deprecate CancellableEntityEventArgs

CancellableEntityEventArgs is deprecated. Use structs
with bool Cancelled instead.
2024-12-21 10:13:26 +00:00
chromiumboy e977f87e50 Atmospheric network monitor (#32294)
* Updated to latest master version

* Added gas pipe analyzer

* Completed prototype

* Playing with UI display

* Refinement of the main UI

* Renamed gas pipe analyzer to gas pipe sensor

* Added focus network highlighting and map icons for gas pipe sensors

* Added construction graph for gas pipe sensor

* Improved efficiency of atmos pipe and focus pipe network data storage

* Added gas pipe sensor variants

* Fixed gas pipe sensor nav map icon not highlighting on focus

* Rendered pipe lines now get merged together

* Set up appearance handling for the gas pipe sensor, but setting the layers is bugged

* Gas pipe sensor lights turn off when the device is unpowered

* Renamed console

* The gas pipe sensor is now a pipe. Redistributed components between it and its assembly

* AtmosMonitors can now optionally monitor their internal pipe network instead of the surrounding atmosphere

* Massive code clean up

* Added delta states to handle pipe net updates, fixed entity deletion handling

* Nav map blip data has been replaced with prototypes

* Nav map blip fixes

* Nav map colors are now set by the console component

* Made the nav map more responsive to changes in focus

* Updated nav map icons

* Reverted unnecessary namespace changes

* Code tidy up

* Updated sprites and construction graph for gas pipe sensor

* Updated localization files

* Misc bug fixes

* Added missing comment

* Fixed issue with the circuit board for the monitor

* Embellished the background of the console network entries

* Updated console to account for PR #32273

* Removed gas pipe sensor

* Fixing merge conflict

* Update

* Addressing reviews part 1

* Addressing review part 2

* Addressing reviews part 3

* Removed unnecessary references

* Side panel values will be grayed out if there is no gas present in the pipe network

* Declaring colors at the start of some files

* Added a colored stripe to the side of the atmos network entries

* Fixed an issue with pipe sensor blip coloration

* Fixed delay that occurs when toggling gas sensors on/off
2024-12-21 10:13:11 +00:00
beck-thompson ab1b17390b Figures can now be activated remotely (#32769)
* First commit

* I'm silly

* weh

* will this work?

* Better design

* Fixes!

* rider :(

* L rider
2024-12-21 10:13:10 +00:00
deathride58 2e162dfa50 Makes admins not count towards the playercount cap (#33424)
* Makes admins not count towards the playercount cap

* Update Content.Shared/CCVar/CCVars.Admin.cs (thx Aeshus

Co-authored-by: Thomas <87614336+Aeshus@users.noreply.github.com>

* Actually fixes whitespace on the comments
Thanks VScode very good IDE

---------

Co-authored-by: Thomas <87614336+Aeshus@users.noreply.github.com>
2024-12-21 09:58:03 +00:00
Preston Smith 3ef2bfa6db Prevent pulling when teleporting (#33252)
* No more teleporting pulling

* pulled dash

* Update Content.Shared/Ninja/Systems/DashAbilitySystem.cs

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Update Content.Server/Implants/SubdermalImplantSystem.cs

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2024-12-21 09:58:02 +00:00
Baa b55171fcdd Fix udder wooly reagent creation V2 (#32905)
* Changed comments to be more clear and uniform.
EggLayer uses NextGrowth instead of frame accumulation.
Egglayer uses much less energy to make eggs, and lay time is randomized for player and AI chicken.

* UdderComponent ReagentId can be changed now
UdderSystem and WoolySystem use SharedSolutionContainerSystem now

* Entities with udders can be examined to see a rough hunger level
udders and wooly stop reagent generation/extra nutrient usage once the solution container is full

* Moved stuff to Shared
AutoPausedField now

* Cleanup moving stuff to Shared

* Oops. Make UdderSystem sealed instead of abstract.

* Switch PopupEntity for PopupClient

* Didn't mean to delete Access

* new() instead of default! prototype
revert egglayer balance change
NextGrowth += timespan   in egglayer

* forgot [Datafield] for NextGrowth

* forgot NetworkedComponent again...

* Renaming Shared Animal to Shared Animals to match Server
Hopefully also resolve merge conflicts.

* Fix incorrect filename

* Update with requested changes
Put UdderSystem dependencies in alphabetical order.
Initialise NextGrowth for Udder and Wooly components on MapInitEvent.
Clean-up EggLayerSystem a little.
Re-write OnExamine function for UdderSystem, improving clarity.
Add full stops to end of udder examine locales.
And more :)

* Add some additional descriptions for cow hunger levels.

* Add Udder and Wooly quantity to AutoNetworkedField

* Account for less than starving threshold.

---------

Co-authored-by: sirionaut <sirionaut@gmail.com>
Co-authored-by: Sirionaut <148076704+Sirionaut@users.noreply.github.com>
Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
2024-12-21 09:58:02 +00:00
deltanedas c52db7dff1 add SpawnTableOnUse (#32620)
* add SpawnTableOnUse

* make BaseEmitSound more flexible and remove sound from spawntable

* add log

* :trollface:

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-12-21 09:58:02 +00:00
Plykiya e62d937c06 Cluster grenade refactor and contra markings (#31108)
* Cluster grenade refactor

* oopsies on the name

* Solve client-side errors

* reviews addressed

* filling scattering grenades is now predicted

* reviews addressed
2024-12-21 09:58:01 +00:00
Nim bfc4820a81 Other colour of the binary channel (#33841)
* radio

* color 2

* console-announcement

* 5ed7aa
2024-12-21 09:56:59 +00:00
lzk 356ed9152c Increase war ops evac time (#33628) 2024-12-21 09:56:32 +00:00
lzk 62a3def274 fix ghost command error string (#33838) 2024-12-21 09:56:32 +00:00
BramvanZijp e0636a829c Rework the HoS's Energy Shotgun (Varying energy consumption depending on fire-mode + re-adds a toned down self recharge.) (#32104)
* Rebalance HoS's Energy Shotgun

* SLIGHTLY Up the max charge so the gun properly recharges all of its charges, which matters a lot more with the self charge cooldown system.

* Prevent recharge cooldown if 0 power is used.

* Makes the clientside HUD actually update to reflect the changes in firecost and thus max/current charges.

* Properly fix that recharging to just under full issue instead of applying a budget fix to only the eshotgun.

* Clean up the client ammo UI fix.

* Update the self recharger component to comply with maintainer request.

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Remove code that was made redundant by a hotfix from another PR.

* Make the recharge pause on EMP, document things where needed, clean up code as per maintainer request, add a note to make the code better when power is moved to shared.

* Fix another internal issue

* Code cleanup + fix the rapid recharge verb to remove pause.

* cleanup

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2024-12-21 09:55:48 +00:00
slarticodefast 66050176d5 Fix greytide virus hitting other maps (#33806)
fix greytide virus hitting other maps
2024-12-21 09:54:48 +00:00
TGRCDev 9a9b6f2002 Made anchor visuals generic (#33810)
Added a generic anchor visuals enum
2024-12-21 09:54:48 +00:00
sleepyyapril 4c20f92f90 Fix Disposals Ejections (#33468)
* Fix disposals.

* Rename properly

---------

Co-authored-by: sleepyyapril <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>
2024-12-21 09:38:27 +00:00
Errant 581b4a2cea Signal timer duration limit (#33781)
* max duration

* comment
2024-12-21 09:38:27 +00:00
slarticodefast 23ba1f6cb6 Fix gas pipe leaking when unanchoring or breaking them (#33774)
* fix gas pipe unanchoring

* remove unneeded update

* revert popup change
2024-12-21 09:38:17 +00:00
Pieter-Jan Briers b2742a754a Singularity equipment can now be activated with E interact (#33762)
These were coded to only listen to InteractHand, which doesn't follow our interaction model properly.
2024-12-21 09:37:14 +00:00
deltanedas 98f554a8ba
make wrecks cost mining points to pull (#2457)
* add UserHasPoints helper method

* add cost to wreck pulls

* implement wreck pull cost

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-12-20 05:28:42 +00:00
SolStar d5716a8d41
New psionic ablility: Precognition (#2131)
* TESTING enable events for dev enviroment

* Add NextEventComponent

* Check for schedulers NextEventComponent

* Seperate gernateing event to its own method

* Add NextEventSystem and use in BasicStationEventSchedulerSystem

* TESTING: Override time and player restrictions

* Stash events in NextEventComponent (#1)

* Add NextEventComponent

* Check for schedulers NextEventComponent

* Seperate gernateing event to its own method

* Add NextEventSystem and use in BasicStationEventSchedulerSystem

* Format code

* Add nextEvent time perdiction

* Use RunTime instead of float minutes

* Bug fixes

* Add NextEvent to Ramping and Meteors

* Fix timing on BasticStationEvents

* initialize NextEventComponent when created

* Event scheduler caching (#2)

* Check for schedulers NextEventComponent

* Seperate gernateing event to its own method

* Add NextEventSystem and use in BasicStationEventSchedulerSystem

* Format code

* Add nextEvent time perdiction

* Use RunTime instead of float minutes

* Bug fixes

* Add NextEvent to Ramping and Meteors

* Fix timing on BasticStationEvents

* initialize NextEventComponent when created

---------

Signed-off-by: SolStar <44028047+ewokswagger@users.noreply.github.com>

* Revert "Event scheduler caching (#2)"

This reverts commit bf9cd26ed4.

* Revert "Merge branch 'seer' into stash-next-event"

This reverts commit 656ca26173, reversing
changes made to 36f45be10e.

* Revert "Caching next exent"

This reverts commit 9f1bee4131, reversing
changes made to 82678d9c18.

* Reapply "Event scheduler caching (#2)"

This reverts commit 82678d9c18.

* More merge conflict nonsence

* oops

* oops 2

* Oops 3

* Precognition Psionic ability (#3)

* Precognition ability added

* Precog get next event

* Get soonest event and display

* update prototypes with precog results

* Add random

* Use Timespan for UseDelay

* Damage breaks doafter

* typo

* fix localization

* fix do after

* Add effects durring do after

* Revert "TESTING enable events for dev enviroment"

This reverts commit 03453133bd.

* Revert testing changes

* add deltav comments

* Cleaning up!

* Move NextEvent to server space

* Fix NextEventId init value

* Reverted upstream file to block scoped namespace

* Add precognitnon result messages

* reverting testing changes for real

* Add admin alert for upcoming events

* Add sound effect

* make alert more subtule

* extended max window size

* fix message mixup

* yaml fixes

* more yaml fixes

* Delta Changes

* totaly a yaml error trust

* remove unsessesary weights

---------

Signed-off-by: SolStar <44028047+ewokswagger@users.noreply.github.com>
2024-12-19 03:55:15 +00:00
deltanedas 61cad3c304
make glimmer events trigger psionic artifacts (#2440)
* make glimmer events trigger psionic artifacts

* :trollface:

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-12-19 03:43:18 +00:00
Stop-Signs 5da943a9c6
New weapon - I.C.E.E. (#2170)
* Update hitscan.yml

* All the things

* Fixing the cold

* Fixed sprite and some formatting

* im dumb

* Revert "Fixed sprite and some formatting"

This reverts commit 2550f41240.

* Reapply "Fixed sprite and some formatting"

This reverts commit 3f4d5eaade.

* Revert "im dumb"

This reverts commit 9056ca3507.

* names

* Reviewed Changes

* Reviewed Changes

* Fixed for Milon

* delta changes

---------

Signed-off-by: Stop-Signs <stopsign221@gmail.com>
2024-12-19 03:34:10 +00:00
BarryNorfolk 600ef0e5a6
Add history tab to bounty console (#2473)
* Add struct for holding historical data on cargo bounties

* Add localisation strings for bounty history

* Add new XAML entry for display bounty history

* Expand cargo bounty menu to include tabs

* Ensure station databases hold historical bounty data

* Add to the bounty history when removing one from active

* Feed bounty history into cargo's bounty system
2024-12-18 13:36:06 +00:00
deltanedas ee4fca43f4
cleanup and carrying refactor (#2466)
* remove evil file

* clean up fugi emag lines

* clean up barrel/keg yml and meta

* surface-level refactor of deep fryer component

* move carrying to shared and fully refactor

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-12-18 11:22:19 +00:00
SolStar 94b2542165
Add error logging for Auto ACO procedure. (#2450)
* Add error logging for Auto ACO procedure.

* type
2024-12-18 02:25:22 -05:00
deltanedas 85a29fbdf4
add ash storms to lavaland (#2445)
* add SaturationLoss to LungComponent

* add code for ash storms

* add ash storms to lavaland

* add ashwalker mob

* :trollface:

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-12-18 01:27:23 +00:00
deltanedas e809c51201 upstream merge 7/12 but merge commit 2024-12-17 04:48:41 +00:00
deltanedas c690177b0e
check ban flag for auto panic bunker (#2443)
Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-12-14 21:31:29 +00:00
deltanedas 79a58be6c1 move gun execution system to deltav folder, fix it 2024-12-13 23:02:38 +00:00
deltanedas 3247caeadf reenable greytide virus with changed announcement 2024-12-13 22:47:13 +00:00
metalgearsloth 84844202b3 Ion storm refactor (#33311) 2024-12-13 21:05:40 +00:00
deltanedas 40362d22c4 what 2024-12-13 21:05:04 +00:00
deltanedas 50f87d4540
fix lavaland shuttle for real (#2434)
Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-12-13 13:32:49 +00:00
SolStar 3b9fa30bb8
fix auto aco timing (#2431) 2024-12-12 23:51:18 +00:00
deltanedas 019cc24950
fix mining shuttle not docking on small stations (#2430)
fix bug and add log

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-12-12 22:49:53 +00:00
SolStar 9db6651231
Auto ACO Procedure bug fixes (#2424)
* bug fixes and safty improvments

* remove unsued useings

* this is dumb but ok

* removed global annoucement

* why does my ide keep doing this shit

* remove unessesary stuff
2024-12-12 06:09:22 +00:00
Milon dd6675d3a1
fix "teach person a lesson" (#2412)
* "when you code it" but i already fucking did

* FUCK

* ok thats a thing apparently
2024-12-12 00:18:28 +00:00
Milon 2c6517953a
pda messaging real (#2362)
* the shiny new toy that breaks everything else

* privacy 😌

* janky shit

* real??

* :trollface:

* ALL HAIL DUCT TAPE SOLUTION

* FUCK

* commented every shit
2024-12-10 20:33:58 +00:00
deltanedas 8829c541b9
add lavaland real (#2380)
* fix not being able to make catwalk over lava

* add planet prototypes

* StationSurface -> StationPlanetSpawner

* spawn lavaland for all stations

* remove reclaimer wrecks muahaha

* add mining shuttle

* add lavaland map

* convert glacier surface to a grid (still unusable)

* update glacier comment

* add docking shuttle/console systems

* fix test

* make glacier use a lavaland base reskin

* -m actually set the atmosphere

* :trollface:

* fix test

* address most reviews

* add no shuttle warning

* remove unnecessary usings

* 80C and higher pressure

* lock the shuttle docks to external access

* correct comment pressure

* add salvage access to the console

* lock supply room to salv, add a cooler

---------

Signed-off-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
Co-authored-by: deltanedas <@deltanedas:kde.org>
Co-authored-by: Milon <plmilonpl@gmail.com>
2024-12-10 19:37:43 +01:00
Milon 28f16b6edd
make lathe items worthless (#2406)
* shutting down the money printer

* fix ore processor
2024-12-10 04:16:38 +00:00
SolStar b5ee0f4906
Automatic ACO procedure (#2351)
* Add events for player updating jobs

* Add NoCaptainComponent

* add and remove NoCaptainComponent logic

* Gernalized to CaptainStateComponent

* Generalized CaptainStateComponent

* Add requesting aco vote

* Add auto unlock aa

* Remove hardcodecd strings

* Add localization

* // DeltaV

* pro fix

* fax cc please

* move captain detection to CaptainStateSystem

* track spareidsafe with comp instead

* little bit of movement

* fix broken formating

Signed-off-by: SolStar <44028047+ewokswagger@users.noreply.github.com>

* pls

* Remove unused method

* subscribe captainstatecomponent for job events

* Cvars, Disabled AA on peri

* temp fix for intergration test bug

* :3

* format fix

* spelling ops

* nameing ops

* done final real this time (1) (1)

* remove has an out very nice

---------

Signed-off-by: SolStar <44028047+ewokswagger@users.noreply.github.com>
2024-12-09 18:05:19 +01:00
Milon 13c1e0154c
aac tablet refactor (#2401)
* another thing nobody asked for

* just.. why? who did this, and why?
2024-12-09 14:21:18 +00:00
metalgearsloth 76f8a19ce8 Predicted gas pumps (#33717)
* Predicted gas pumps

I wanted to try out atmos and first thing I found.

* a

* Remove details range
2024-12-07 22:10:56 +00:00
Winkarst 394a1eb0fe Make unknown shuttle events trigger an announcement (#33450)
* Make unknown shuttle events trigger an announcement

* Call base at the end

---------

Co-authored-by: Winkarst <74284083+Winkarst-cpu@users.noreply.github.co>
2024-12-07 22:10:49 +00:00
0tito a0ac0665ff Add Sprite changes to Logic Gates to show the input/output state (#33277) 2024-12-07 22:05:25 +00:00
Ed 360db55913 Fix debris chunks loot spawning (#33747)
Update DungeonJob.PostGenBiome.cs
2024-12-07 22:05:18 +00:00
deltanedas 94b09d6ee7 Revert "fix debris having nothing (#2280)"
This reverts commit 3a27784542.
2024-12-07 22:05:05 +00:00
ScarKy0 75918fc180 Derelict Borg Revival (#33433)
* Derelictn'tn't Borg!

* Clean *sparkles*

* Removed "S: Awaiting Changes"
2024-12-07 22:03:47 +00:00
IProduceWidgets e41f317513 fix a station event weighting bug (#33584)
* fractional weights dont work in StationEvents

* force-int

* sure why not, we can keep floats I guess.
2024-12-07 22:03:36 +00:00
Winkarst 566e840e70 Fix meteor's ArithmeticException (#33556)
Co-authored-by: Winkarst <74284083+Winkarst-cpu@users.noreply.github.co>
2024-12-07 22:02:39 +00:00
Leon Friedrich 42be836539 More device configurator serialization fixes (#33664)
More device configurator invalid entity serialization fixes
2024-12-07 22:02:31 +00:00
Partmedia 5fdfa2aee0 Fix sinks and toilets not draining (#33691)
* Fix AutoDrain

Per the system comments, AutoDrain is designed to automatically move
puddles into the drain (like a floor drain). Drains without AutoDrain
are still supposed to gradually empty the buffer, but not remove puddles
(like sinks and toilets).

However, a logic error in the original implementation causes drains with
AutoDrain set to false to simply not work. Hence sinks never emptied.

* Update documentation
2024-12-07 22:01:08 +00:00
MilenVolf 9b4b264012 Replace obsolete GetTilesIntersecting methods (#32455)
* Remove usage of obsolete GetTilesIntersecting round 1

* Oop wrong uids

* Remove usage of obsolete GetLocalTilesIntersecting round 2

* Remove usage of obsolete GetLocalTilesIntersecting final round

* weh

* Fix using `SharedMapSystem` in `StencilOverlay`
2024-12-07 21:55:22 +00:00
Token 0cd0206c70 Fix makeghostroleraffle command where 4 arguments (#31836)
Fix makeghostroleraffle command with 4 arguments
2024-12-07 21:54:42 +00:00
Gansu eb45cadd29 Fix for arrivals deleting nuke (#33659)
Adds FTLSmashImmune to nuke prototype to stop it from arrival smashing
Adds a comment in FasterThanLight to indicate where the FTLSmashImmuneComponent is checked

Co-authored-by: aa5g21 <aa5g21@soton.ac.uk>
2024-12-07 21:53:58 +00:00
DrSmugleaf 863b9650d2 Add admin log for ghost warping (#33636) 2024-12-07 21:52:42 +00:00
beck-thompson df595e10c3 Light verb is now predicted (#33622)
Fix
2024-12-07 21:52:08 +00:00
slarticodefast f193b67fd3 Greytide Virus station event (#33547)
* proof of concept

* full implementation

* I commited a crime

* t

* min players increase
2024-12-07 21:48:28 +00:00
Niels Huylebroeck 810880d840 Turn off PointLights on VendingMachines when broken or off. (#33513)
The light itself should already turn off due to `LitOnPowered`
component, but the broken state of a VendingMachine did not.

Fixes  #33382
2024-12-07 21:46:52 +00:00
Schrödinger 97fe9b1819 [BUGFIX] "Ghost" in the lobby lets you see the whole chat (#33529)
* fix bug, in ghost command lobby

* fix

* Fix build
2024-12-07 21:45:50 +00:00
deltanedas d9a50737ae fix exped caves generation (#32890)
Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-12-07 21:45:11 +00:00
MilenVolf 5e8009c47b Allow shuttles on planets to make FTL jump (#33507)
This check conflicts with an attempt to FTL from the planet before expedition ends
2024-12-07 21:45:11 +00:00
goet 62cf5730e2 Ensure wires can always be cut (#32447)
ensure wires are always cut
2024-12-07 21:43:14 +00:00
IProduceWidgets d4f4f6292f baby proof the terminal (#33281)
* baby proof the terminal

* Make a couple exceptions for items that you might take with you.

* alwayspoweredlights

* Uncuttable cables since cablecomp is a snowflake construction system

* chairs and vendors

* rerun heisentests

* rerun tests again
2024-12-07 17:27:35 +00:00
c4llv07e 588357d6ca Add telegram to the server info-links (#33459) 2024-12-07 17:25:37 +00:00
chromiumboy 48ad7a9f60 Gas pipe sensors (#33128)
* Initial commit

* Monitored pipe node is now referenced by name

* Review changes

* Simplified construction

* Tweaked deconstruction to match other binary atmos devices

* Helper function removal

* Updated attribution
2024-12-07 17:25:26 +00:00
slarticodefast f6dda6b725 electrification hud 2024-12-07 16:50:43 +00:00
IProduceWidgets 1689950693 Coal presents and chrimmas tree options. Presents no longer itemify (#33147)
* Dont ensure ItemComp because it could lead to weirds, and also PickupOrDrop handles non-items already.

* presents and tree

* woops

* reviews a
2024-12-07 16:50:31 +00:00
DrSmugleaf 12781b4fe5 Fix imports 2024-12-07 16:38:11 +00:00
DrSmugleaf 078dbfb287 Move PlayerBeforeSpawnEvent and PlayerSpawnCompleteEvent to Shared 2024-12-07 16:37:50 +00:00
Saphire c437a5d9d6 Move some of the new singularity code into shared
Hopefully without explosions yay
2024-12-07 16:32:22 +00:00
SlamBamActionman 0ede705300 Add emag functionality 2024-12-07 16:32:15 +00:00
MilenVolf abac268e9a Localize planet dataset names (#33398)
* Localize planet names (borer)

* DatasetPrototype -> LocalizedDatasetPrototype

* Apply requested changes
2024-12-07 16:31:37 +00:00
Pieter-Jan Briers 7ece549aa8 .NET 9 forward compatibility changes (#33421)
This doesn't switch the projects over to .NET 9, but it does make them work on .NET 9 when we decide to switch in the future.
2024-12-07 16:21:13 +00:00
Ilya246 eba8a40e76 fix viewing nav slowing shuttle down (#32381)
fix
2024-12-07 16:20:56 +00:00
Saphire f6ff4c7937 Bump the failsafe timer down 2024-12-07 16:20:47 +00:00
faint 4b3bdc9a2f Replace direct uses of GameTicker dictionary with `TryGetValue` (#33222)
Fix station events schedulers, antag selection and possibly other systems acting weird in a rare scenario
2024-12-07 16:20:37 +00:00
ScarKy0 d383ee6217 Changes + Cleanup 2024-12-07 16:18:20 +00:00
ActiveMammmoth 6fe0d4631c Wizard Summon Guns/Magic (#32692)
* mostly done but there's a bug with spawning

* RandomGlobalSpawnSpellEvent now actually works

* Summon Guns/Magic is working

* Added sound, cap gun, and auto pick up

* Added all requested changes/fixes from reviews

* Halving cooldowns
2024-12-07 16:11:56 +00:00
Saphire f7b57d2375 Fix the component defaults 2024-12-07 16:11:07 +00:00
Saphire 363e9aa878 Temporarily make singularity a bit harder to loose as non-antag 2024-12-07 16:11:03 +00:00
MossyGreySlope 875ab71002 Fix server crash when the seed extractor is used on the dev map (#33312)
handle event when using seed extractor

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2024-12-07 15:43:42 +00:00
Saphire Lattice 8e0b24b38a Fix utensils not being thrown away (#33326) 2024-12-07 15:43:42 +00:00
Saphire Lattice c65ab51393 Improve crayon UI to not be stuck in 1996 (#33101)
* Improve crayon UI to not be stuck in 1996

* Make a horrifying crayon spaghetti

* Crayon

* Undeprecate the crayon, describe the crayon
2024-12-07 15:43:36 +00:00
ScarKy0 c86c20355c S: Awaiting Changes 2024-12-07 15:43:26 +00:00
beck-thompson 8abdafc353 Clumsy system refactor (#31147)
* First commit

* Fixes

* Added the noise

* Renames

* Timespan

* Fixed space

* entity -> ent

* This shouldn't work

* opps....

* Datafield name change

* Better comments

* small comment

* Personal skill issue

* Event renames and stuff

* Couple fixes

* Defib ref fixes (Silly me)

* Added clumsy back!

* no hard code clumsy!

* Identity fix

* Event name change

* Comment change

* Function name change

* opp

* Update names

* Damage stuff!

* Fixes!

* Fixes

* opps

* This was hidden away!!

* negative diff feeds me
2024-12-07 15:42:29 +00:00
deltanedas 04a33dcea9
dont give AI a fugi report (#2363)
Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-12-04 23:20:55 +00:00
deltanedas 027df56d23
borg slavery 🔥 🔥 🔥 (#2337)
* fuck it fix emag law 4

* add borg enslaving

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-12-01 23:48:13 +01:00
Pieter-Jan Briers 26b36db09d Integrate Modern HWID into content
This should be the primary changes for the future-proof "Modern HWID" system implemented into Robust and the auth server.

HWIDs in the database have been given an additional column representing their version, legacy or modern. This is implemented via an EF Core owned entity. By manually setting the column name of the main value column, we can keep DB compatibility and the migration is just adding some type columns.

This new HWID type has to be plumbed through everywhere, resulting in some breaking changes for the DB layer and such.

New bans and player records are placed with the new modern HWID. Old bans are still checked against legacy HWIDs.

Modern HWIDs are presented with a "V2-" prefix to admins, to allow distinguishing them. This is also integrated into the parsing logic for placing new bans.

There's also some code cleanup to reduce copy pasting around the place from my changes.

Requires latest engine to support ImmutableArray<byte> in NetSerializer.
2024-11-29 19:18:11 +01:00
sativaleanne a07cb3b222 Rolebanlist command UI (#30827)
* rolebanlist command opens ui

* removed commented out section
2024-11-29 19:18:11 +01:00
Kr8art 04b9239581
Port Dogtags from CD and fix some minor issues with it. (#2301)
* Port Dogtags from CD and fix some minor issues with it.

* Addressing reviews
2024-11-28 12:04:17 +00:00
deltanedas b4d79a29cb
fix the shadow factory (#2299)
* update code to allow lawset updating

* use lawset field on borgs

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-11-28 07:22:06 +00:00
deltanedas 921a0e26fd
zombie gamemode semi rework (#2194)
* zombie gamemode semi rework

* remove 1

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-11-26 12:23:26 +00:00
Milon d375f35350
fix KillPersonCondition (#2289)
* aaaaaaaaaaaaaaaaaa

* what even was this
2024-11-26 08:26:47 +00:00
deltanedas 3a27784542
fix debris having nothing (#2280)
Revert "improve BiomeDunGen (#33113)"

This reverts commit b94731c4f8.

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-11-24 20:25:25 +00:00
deltanedas 11807309de
cherry pick portable charger (#2206)
* Portable Recharger: Arsenal T3 (#26655)

* sys

* item

* ahm.

* Update Content.Server/Power/Components/ChargerComponent.cs

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>

* remove funny spaces

* funny fix

---------

Co-authored-by: icekot8 <93311212+icekot8@users.noreply.github.com>
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-11-24 11:09:31 +01:00
deltanedas 51d8874c74 merge master 2024-11-24 04:27:00 +00:00
Milon c723d16298
fix pain popups (#2248)
whoopsie!!
2024-11-20 20:26:19 +00:00
deltanedas 3b6c3b56ec merge master 2024-11-20 05:15:21 +00:00
Lyndomen fdb26756ec
Ports Bloodstains And Footprints from EE (#2186)
* bogos binted

* bogos binted

* Update human.yml

Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>

* Update skeleton.yml

Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>

* untouch

Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>

* untouch please

Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>

* fixed real

---------

Signed-off-by: Lyndomen <49795619+Lyndomen@users.noreply.github.com>
2024-11-20 01:00:15 +00:00
Milon f1c859a9ee
pain system + addictions + traits (#2192)
* the nightmare continues unchecked

* HOLY FUCKING SHITCODE

* Update traits.ftl

* makes the yaml linter happy

* we'll regret this later

* what why
2024-11-20 00:59:17 +00:00
Lyndomen 0e3643bee9
Port frontier no power popups (#2230)
* meow

* meow

* meow

* meow

* meow
2024-11-18 22:19:17 +00:00
deltanedas 069a73317e
Merge branch 'master' into upstream-ops
Signed-off-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
2024-11-18 21:42:45 +00:00
Lyndomen b1941efa97
Ports Salv Cannon requiring power from Frontier (#2227)
* meow

* meow
2024-11-18 16:53:07 +00:00
Lyndomen 39d9ea854d
Change Kill Person to "Teach person a lesson" (#2184)
* bogos binted

* bogos binted

* bogos binted

* bogos binted

* bogos binted

* bogos binted

* bogos binted

* fixes, still doesnt stay completed.

* fixed real

* meow

* meow
2024-11-18 04:33:27 +01:00
Pieter-Jan Briers 4aecc673ae Borg type switching. (#32586)
* Borg type switching.

This allows borgs (new spawn or constructed) to select their chassis type on creation, like in SS13. This removes the need for the many different chassis types, and means round-start borgs can actually play the game immediately instead of waiting for science to unlock everything.

New borgs have an additional action that allows them to select their type. This opens a nice window with basic information about the borgs and a select button. Once a type has been selected it is permanent for that borg chassis.

These borg types also immediately start the borg with specific modules, so they do not need to be printed. Additional modules can still be inserted for upgrades, though this is now less critical. The built-in modules cannot be removed, but are shown in the UI.

The modules that each borg type starts with:

* Generic: tools
* Engineering: advanced tools, construction, RCD, cable
* Salvage: Grappling gun, appraisal, mining
* Janitor: cleaning, light replacer
* Medical: treatment
* Service: music, service, clowning

Specialized borgs have 3 additional module slots available on top of the ones listed above, generic borgs have 5.

Borg types are specified in a new BorgTypePrototype. These prototypes specify all information about the borg type. It is assigned to the borg entity through a mix of client side, server, and shared code. Some of the involved components were made networked, others are just ensured they're set on both sides of the wire.

The most gnarly change is the inventory template prototype, which needs to change purely to modify the borg hat offset. I managed to bodge this in with an API that *probably* won't explode for specifically for this use case, but it's still not the most clean of API designs.

Parts for specific borg chassis have been removed (so much deleted YAML) and specialized borg modules that are in the base set of a type have been removed from the exosuit fab as there's no point to printing those.

The ability to "downgrade" a borg so it can select a new chassis, like in SS13, is something that would be nice, but was not high enough priority for me to block the feature on. I did keep it in mind with some of the code, so it may be possible in the future.

There is no fancy animation when selecting borg types like in SS13, because I didn't think it was high priority, and it would add a lot of complex code.

* Fix sandbox failure due to collection expression.

* Module tweak

Fix salvage borg modules still having research/lathe recipes

Engie borg has regular tool module, not advanced.

* Fix inventory system breakage

* Fix migrations

Some things were missing

* Guidebook rewordings & review

* MinWidth on confirm selection button
2024-11-15 19:35:37 +00:00
CheddaCheez 0fbf77cf90 Fix mime broken vow alert (#33303)
Swap VowAlert and VowBrokenAlert on lines 149 and 150 so that the proper alerts are cleared and shown
2024-11-15 17:58:01 +00:00
keronshb 0fee1b6d2b Ethereal Jaunt Spell for Wizard & Jaunt ECS (#33201)
* Act

* Adds Jaunt ECS and related prototypes

* Adds jaunt sounds

* Adds enter and exit sound support to polymorphs

* Updates jaunt description

* Adds jaunt action sprite and changes jaunt polymorph to use it

* Adds Jaunt and upgrade to the wizard grimoire

* Makes base mob jaunt parent off of incorporeal and basemob, adds blue ghost sprite for ethereal jaunt

* Update Resources/Locale/en-US/store/spellbook-catalog.ftl

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Update Resources/Prototypes/Entities/Mobs/Player/jaunt_mobs.yml

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Update Resources/Prototypes/Entities/Mobs/Player/jaunt_mobs.yml

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Update Resources/Prototypes/Entities/Mobs/Player/jaunt_mobs.yml

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Update Content.Shared/Polymorph/PolymorphPrototype.cs

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Update Content.Shared/Polymorph/PolymorphPrototype.cs

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* removes meta changes

* removes other meta changes

* adds context menu and a description to basemobjaunt

* comments for jaunt component and adds on component shutdown method

* Update Content.Shared/Jaunt/JauntComponent.cs

* Update Content.Shared/Jaunt/JauntComponent.cs

* Update Content.Shared/Jaunt/JauntComponent.cs

* Update Resources/Prototypes/Catalog/spellbook_catalog.yml

---------

Co-authored-by: lzk <124214523+lzk228@users.noreply.github.com>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2024-11-15 17:45:08 +00:00
dffdff2423 a48bc2d02f tag:with toolshed command (#31751) 2024-11-15 17:45:08 +00:00
Repo 345cf26239 Fix unban/editing role bans placed in groups. (#30659)
* On editing a roleban, get all the bans with the same time.

* forgoten newline

* Update to check for player ID too.
2024-11-15 17:42:52 +00:00
Preston Smith ecec393d8f Make Droppers Respect Closed/Sealed Containers (#33011)
* Make droppers respect closed/sealed

* Combine nested

* Optimize conditions a bit
2024-11-15 17:42:52 +00:00
Ed b94731c4f8 improve BiomeDunGen (#33113)
* improve BiomeDunGen

* forgot lol

* Update DungeonJob.PostGenBiome.cs

* Update DungeonJob.PostGenBiome.cs
2024-11-15 17:42:34 +00:00
Simon df426f2174 Separate CCVars into separate files 2024-11-15 17:42:11 +00:00
Andrew Montagne 4078532184 BUGFIX: Fix APEs being able to be turned on without power (#32493)
Add a check to see the APC is powered before turning the emitter on.
2024-11-15 17:37:08 +00:00
leonidussaks 26cd83c61b Fix vape use without check if doafter cancelled (#33245)
vape small fix
2024-11-15 17:36:38 +00:00
IProduceWidgets ba4494aced tweak: weather command tooltip (#33130)
clear weather tip
2024-11-15 17:35:37 +00:00
ScarKy0 ca7e827ecb Intellicards now have a doAfter. (#33198)
* init

* cleanup

* Oops! Forgot something

* addressing changes

* guh

* guh 2.0

* some cleanup

* all bless the intellicard

* Yippee

* small locale thing

* changes + small bugfix

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2024-11-15 17:35:10 +00:00
SlamBamActionman 493a7cb3cd Add a Walking alert (#32954)
* Initial commit

* Review feedback changes

* ProtoId

* TempCommit

* First attempt to have client alerts

* Review changes
2024-11-15 17:35:04 +00:00
Jezithyr 8ea3ee2e58 Stable Merge (#33218) 2024-11-15 17:32:57 +00:00
deltanedas af0c9e60f5 pass Actor to cartridge messages (#33210)
* pass Actor to cartridge messages

* NonSerialized gaming

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-11-15 17:32:06 +00:00
FN 47d17fd933 Fix cursed mask bug (#33014)
* One line fix

* Removed redundant using

* Allocation improvement
2024-11-15 17:32:06 +00:00
SolStar 93981a264f Fix research disk crash (#33205)
* Fix reserach disk crash

* remove extra whitespace

* removed args.handled where args are not handled
2024-11-15 17:32:00 +00:00
SlamBamActionman 9304ee44d3 Changes to "Burst" firemode; Drozd, WT550 and C20-r (#31292)
* Initial commit

* Change burst fire variable to be a set value rather than a multiplier
2024-11-15 17:31:26 +00:00
Errant 3eebc83de2 Don't show Reinforcement codewords on round end (#33181)
Don't show unused codeword sets
2024-11-15 17:28:49 +00:00
DrSmugleaf 6ce73a5fdf Fix DisplayVotes doing nothing for a vote (#33170) 2024-11-15 17:28:49 +00:00
Zachary Higgs 4370d56895 Add Silicon Law cues to Every method a Silicon can have their laws change (#32887)
* Silicon Law Sound cue refactor

- Added CueEntityMind to Silicon Law system to more uniformally
send sounds to minds

- Switch all previous MindPlaySound to instead call to the new method

* Change SiliconLawEui to cue the mind

* CR: TryGetComponent and Change the Documentation

- Remove GetComponentOrNull for  _entityManager.TryGetComponent

- Change SiliconLawProviderComponent.LawUploadSound to be more general
rather than just referencing lawboards

* Update Content.Server/Silicons/Laws/SiliconLawEui.cs

* Update Content.Shared/Silicons/Laws/Components/SiliconLawProviderComponent.cs

* Silicon-law-cue-refactor - CR:

- Roll the cuing into NotifyLawsChanged via an optional variable for the
cue

- Modify "SetLaws" to take in an optional soundProvider for the cue

- modify Emagged, Ion, Eui and SetLaws to instead send the sound cue via
NotifyLawsChanged

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2024-11-15 17:27:41 +00:00
Tr1bute c51f5e98ab Added Popup for the Ligneous plant mutation when using hands. (#33136)
* Added Popup for the Ligneous plant mutation when using hands.

There was some confusion for players with the Ligneous mutation which makes the plant harvestable only with sharp tools. Adding a popup with the message "The plant is too tough." to give them a hint to use something other than just their hands.

I decided to only put the message when attempting to harvest using hands, as the intent is clear that the player just wanted to harvest, but wasn't able to. Using any other tools like a crowbar or a screwdriver will not trigger the popup.

* Update Resources/Locale/en-US/botany/components/plant-holder-component.ftl

Co-authored-by: SlamBamActionman <83650252+SlamBamActionman@users.noreply.github.com>

---------

Co-authored-by: SlamBamActionman <83650252+SlamBamActionman@users.noreply.github.com>
2024-11-15 17:26:03 +00:00
Errant 3d7e121137 Hotfix add debug info to traitor activation (#33119)
* Add debug messages to traitor activation

* more debug
2024-11-15 17:22:20 +00:00
Milon f580084e61
stamina damage resist (#2190)
* someone had to be brave enough to kill this

* it's finally real

* god himself couldn't fix this shit

* :trollface:
2024-11-14 14:28:08 +00:00
Milon 648396c663
announcecustom command (#2163)
* rushed af

* Update AnnounceCustomCommand.cs
2024-11-10 17:16:05 +00:00
deltanedas b6b2971616
prevent telegnomes from interacting with anything (#2117)
* disable interaction for telegnomes, add access for the components

* make client and server systems extend shared system

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-11-09 19:27:59 +00:00
Milon 96fc62ce2b
cherry pick "fix solution contents duplication on spill behavior" (#33231) (#2157)
I’M SCREAMING INTO THE VOID AND IT’S NOT LISTENING
2024-11-09 12:46:34 +00:00
Milon 38d6e87dd9
fix metempsychosis (#2156)
* this is an insult to my sanity

* this is an insult to my sanity

* Revert "Merge branch 'shitcode' of https://github.com/MilonPL/Delta-v into shitcode"

This reverts commit 3de8ffc704, reversing
changes made to b22c053376.

* FUCKING GITSHIT

* AAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAAA

* docs and shit
2024-11-09 10:47:17 +00:00
deltanedas d8265ce026
make meat spike drop organs (#2154)
Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-11-09 05:40:16 +01:00
deltanedas 2620eb48a8
upstream merge 2/11 (#2090)
* Fix multiplying colors of differing nullabilities (#32991)

* revert the temporary hack

* Make atmos alert computer colors private variables (#32992)

* Add flash reaction effect (#32377)

add flash reaction effect

* Automatic changelog update

* Fix loneop spawnrate by reverting it to not use the shuttle event system. (#32942)

Fix loneop spawnrate by reverting it to not use the custom shuttle event system.

* Automatic changelog update

* add atmosia to devmap (#32460)

change

* bowls now make drinking sounds (#32819)

* Automatic changelog update

* Add health analyzer unrevivability warning (#32636)

* Add health analyzer unrevivability warning

* Remove errornous comment

* Automatic changelog update

* Removed the name "Hujsak" (#32998)

removed hujsak

* fix pie throwing sound not playing (#33017)

* Automatic changelog update

* Fix TestSuicideByHeldItem and TestSuicideByHeldItemSpreadDamage (#33030)

* make ai speak robotically (#33025)

* Automatic changelog update

* Extends the minimum round time for meteor swarm events (#32876)

* adjusted minimum timers in meteorswarms.yml

* Updated timer minimum from 20 to 15 minutes

* Reduced minimum timer to 10 minutes as a result of other meteor changes

---------

Co-authored-by: august-sun <45527070+august.sun@users.noreply.github.com>

* Automatic changelog update

* add StartDelay bool to actions (#33026)

* add StartDelay bool to actions

* forgot summary

* Updated an incorrect sprite in the smite menu (#33043)

changed the synth sprite used in the icon for the instrumentify smite out for the more accurate supersynth sprite

* fix lava expeds (#33042)

Co-authored-by: deltanedas <@deltanedas:kde.org>

* Automatic changelog update

* Fix separated game screen bumping (#33046)

I don't really understand why RecordedSplitContainer exists but removing it looks identical and fixes the panel bumping occasionally.

* Automatic changelog update

* Fix: Make Plushie Damage Unexaminable (#33061)

Set hidden to true

* fix chameleon projector bot whitelist (#33055)

fix

* Various Vaugely Connected Sprite Updates™: Encryption Keys, Station Map, Brig Timer (#32786)

* various resprites (encryption keys + signal screens + station map)

* brig timer update

* fixes n shit

* Give proto-kinetic crushers, glaives, and daggers better inhands. Update the crusher and glaive icons. (#32212)

* inhands

* better inhands

* indent

* Automatic changelog update

* Make the security belt contain more useful items by default (#32291)

* replace tear gas and flashbang with holobarrier and sec radio

* holobarrier-belt-fix

* revert changes of 32291

* Automatic changelog update

* Add 3 bottle boxes to nanomed plus (#33018)

three bottle boxes in nanomed plus

* Automatic changelog update

* Nukie med bundle now costs 24 tc and contains a unique defibrillator (#32720)

* a-few-injectors

* comment

* defib-ops-when

* Automatic changelog update

* Pill Bottles can only store pills now (#33074)

* no longer absurd

* Update Resources/Prototypes/Entities/Objects/Specific/chemistry.yml

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Automatic changelog update

* Add a spare bible to PietyVend (#32363)

Update chapel.yml

* Automatic changelog update

* [#28722 fix] Add notification for dependent wearables being dropped (#33078)

* add notification for dependent wearables being dropped

* fix dropped item popup redundancy
- did a check to see if any item was dropped, instead of making a notification for each item being dropped.

* change popup to client-only variant

* fix redundant messages, add plural locale string

* fix conventions, fix locale input to be more intuitive

---------

Co-authored-by: Justin <justinbrick1@gmail.com>

* Automatic changelog update

* More pda space (#32601)

* Rebalance the max programs that a PDA can hold

* Give Caps PDA more programs too.

* Make the max programs a static 8

* I forgor sec and med

* CaseCase

* Empty commit to re-run checks

* The final change, I hope.

* Automatic changelog update

* Fixed spelling mistake in water blaster description. (#33087)

Fixed minor spelling mistake

* [#20285 fix] Carp Plush and Rehydratables can now be put into mop bucket (#33079)

* Make shark plush janitor-bucketable

* fix bucketed grey shark texture

* Make sprites less shiny and adapt copyright notice

* Made shark way way less shiny

* Allow carp plush and rehydratables in mop bucket.

* Remove old mop bucket shark sprites

* Fix post-merge bugs

* Fix errors

* Move ReactiveContainer stuff to shared

That should mean it is now predicted.

* Custom eject verb for the mop bucket

* Fixes OnSolutionChange, removes pop-up as there already is one.

* .ftl is not necessary as the custom pop-up was removed

* Review fixes

* Update Content.Shared/Chemistry/Components/ReactiveContainerComponent.cs

* Update Content.Shared/Chemistry/EntitySystems/ReactiveContainerSystem.cs

---------

Co-authored-by: Psychpsyo <psychpsyo@gmail.com>
Co-authored-by: Psychpsyo <60073468+Psychpsyo@users.noreply.github.com>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Automatic changelog update

* remove now duplicated nyano PlushieCarp tag

* Fixes tailthump breaking positional audio by making it mono (#33092)

* Automatic changelog update

* ExaminableDamage now puts its message at the bottom and in color (#32820)

* the examineableDamage component now puts its messages at the bottom, and in color

* god help us if something is priority -100 :godo:

* Automatic changelog update

* Lower in-round votekick requirements (#32953)

Initial commit

* Allow votekicks to be initiated in the lobby (#32528)

Initial commit

* Automatic changelog update

* Fixes bolt lights of previously unpowered bolted doors (#33063)

fix

* Automatic changelog update

* Muffins (#29318)

* Update meta.json

* Add files via upload

* Update misc.yml

* Update meal_recipes.yml

* Update meta.json

* Add files via upload

* Update plate.yml

* Update food_baked_single.yml

* Update dinnerware.yml

* Update cooking.yml

* Update misc.yml

* Add files via upload

* Delete Resources/Textures/Objects/Consumable/Food/Baked/misc.rsi/muffin-cherry.png

* Add files via upload

* Update meta.json

* Update misc.yml

* Update meal_recipes.yml

* Update meta.json

* Fix meta.json

* Fix meta.json again

* Update misc.yml

* Update misc.yml

* Update misc.yml

* Update misc.yml

* Update meta.json

* Update meta.json

* Update misc.yml

* Update meal_recipes.yml

* Update Resources/Prototypes/Entities/Objects/Consumable/Food/Baked/misc.yml

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Update dinnerware.yml

* Delete cherry

* Add files via upload

* Delete banana

* Add banana

* Delete chocolate

* Add chocolate

* lathe recipe fix

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Automatic changelog update

* Borgs can no longer see mindshield + AI can no longer toggle off seeing job icons (#33069)

* :(

* Removed the sprite + updated RSI

* Automatic changelog update

* Add CanLoad for biomes (#33050)

CPUJob to come later.

* Remove CargoPallet component from the cargo pallet (#33022)

* Change cargo shuttle pallets to catwalks.

* Remove CargoPallet component from the cargo pallet.

* Undo cargo shuttle changes.

* Automatic changelog update

* Minor antagonist guidebook changes (#32824)

* took a two month nap. accidentally pushed too many buttons. let's try this again. added thieves to antagonists.xml

* even after that nap, i don't feel well-rested at all.

* please don't kill me for using webedit

* capitalization, typo

* Apply suggestions from code review (more period moving)

Thanks Evan, very cool

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* guess you could say im not pro-proper noun

* typo

* Update Resources/ServerInfo/Guidebook/Antagonist/Nuclear Operatives.xml

* ok

Co-authored-by: SlamBamActionman <83650252+SlamBamActionman@users.noreply.github.com>

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
Co-authored-by: SlamBamActionman <83650252+SlamBamActionman@users.noreply.github.com>

* Give Nukies a Hand Labeler (#33053)

* Add hand-labeler to nukie planet

* Rearrange nukie chem table

* Fix `ItemSlotSystem` popup Logic (#28856)

* move popup call out of `CanInsert` into `OnInteractUsing`

* im stupid and `reason` is completely unnecessary

Signed-off-by: Brandon Li <sirbrandonthenerd@gmail.com>

* return early when `itemSlots.Slots.Count == 0`

* tweak logic for triggering popups

* change popup logic again

* Consolidate whitelist check

* Get any popup message not just last failed slot

* Apply suggestions from code review

Co-authored-by: chromiumboy <50505512+chromiumboy@users.noreply.github.com>

* yoink

Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>

---------

Signed-off-by: Brandon Li <sirbrandonthenerd@gmail.com>
Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
Co-authored-by: chromiumboy <50505512+chromiumboy@users.noreply.github.com>

* Add cvars to votekick to customize requirements for the initiator. (#32490)

* Automatic changelog update

* Add on-call functionality for adminning (#30443)

* Add on-call functionality for adminning

The first time an ahelp gets SOS it gets relayed to the specified channel with the specified ping. Every time after that it doesn't until it gets a non-SOS response received.

* Remove redundant name

Pretty sure this already gets chucked on the name of the msg itself I think it just didn't show in screenshot because they were subsequent.

* Update Content.Server/Administration/Systems/BwoinkSystem.cs

Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>

---------

Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>
Co-authored-by: deathride58 <deathride58@users.noreply.github.com>

* Automatic changelog update

* Pills are explosion resistant (partially reverts #15851) (#32458)

* idk how to revert a pr so I just deleted some lines

* pill destructible with explosion resistance

* comment for explosion resist

* "and" to "but"

---------

Co-authored-by: SlamBamActionman <83650252+SlamBamActionman@users.noreply.github.com>

* Automatic changelog update

* Hasten handcraft gauze recipe & decrease techfab gauze cost (#32744)

* med lathe gauze price reduction

* gauze craft doafter time

* 3 second doafter craft

* Automatic changelog update

* Service workers antagonist fix. (#31359)

* add

* Revert "add"

This reverts commit 25da34b0fead5812fe5800c9bf5dd7b10ef48d7d.

* antagonism allowed™️

* Automatic changelog update

* Adds a new AME sound effect! (#33097)

* Changes the AME sound effect to not be the default MetalThud.

* Was told on discord to make a minor change to autorerun the tests due to the Build & Test Debug failing!

* Attribution and licensing, as requsted by deathride58

* Fixes the high-pitched squeak audible to some people!

* Audio file tweaked by SlamBamActionMan to eliminate a weird squeak they were still able to hear. Thanks!

* Automatic changelog update

* Allow for the ai's laws to be changed from its core and eye (#32461)

* Allow for the ai's laws to be changed from its core and eye

* Address reviews

* Automatic changelog update

* clean up tools lathe recipes (#31521)

* clean up tools lathe recipes

* add medical and cooking tools

* add result

* add result to others

* review

* engine

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>

* Automatic changelog update

* Intercoms and Radios both pick up proximate speech (#32737)

* Deduping of recent messages should consider the channel it's being sent to

* rerun actions

* Automatic changelog update

* Adds headphones to loadouts (#33067)

added headphones to trinkets

* Automatic changelog update

* Cardboard Box Capacity 4 -> 5 (#32743)

* capacity upgrade

* comment update

* remove our duplicate pill whitelist

* fix

* remove broken crew monitor from dev map, how did it even get there

---------

Signed-off-by: Brandon Li <sirbrandonthenerd@gmail.com>
Co-authored-by: chromiumboy <50505512+chromiumboy@users.noreply.github.com>
Co-authored-by: deltanedas <@deltanedas:kde.org>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com>
Co-authored-by: BramvanZijp <56019239+BramvanZijp@users.noreply.github.com>
Co-authored-by: Ilya246 <57039557+Ilya246@users.noreply.github.com>
Co-authored-by: Moomoobeef <62638182+Moomoobeef@users.noreply.github.com>
Co-authored-by: Saphire Lattice <lattice@saphi.re>
Co-authored-by: FluffMe <1780586+FluffMe@users.noreply.github.com>
Co-authored-by: Theodore Lukin <66275205+pheenty@users.noreply.github.com>
Co-authored-by: August Sun <45527070+august-sun@users.noreply.github.com>
Co-authored-by: august-sun <45527070+august.sun@users.noreply.github.com>
Co-authored-by: lzk <124214523+lzk228@users.noreply.github.com>
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: Preston Smith <92108534+thetolbean@users.noreply.github.com>
Co-authored-by: Milon <plmilonpl@gmail.com>
Co-authored-by: Flareguy <78941145+Flareguy@users.noreply.github.com>
Co-authored-by: Alzore <140123969+Blackern5000@users.noreply.github.com>
Co-authored-by: Boaz1111 <149967078+Boaz1111@users.noreply.github.com>
Co-authored-by: Jarmer123 <148848017+Jarmer123@users.noreply.github.com>
Co-authored-by: SlamBamActionman <83650252+SlamBamActionman@users.noreply.github.com>
Co-authored-by: Justin <justinbrick1@gmail.com>
Co-authored-by: SpaceLizard <the.justice.league.of.canada@gmail.com>
Co-authored-by: Psychpsyo <psychpsyo@gmail.com>
Co-authored-by: Psychpsyo <60073468+Psychpsyo@users.noreply.github.com>
Co-authored-by: deathride58 <deathride58@users.noreply.github.com>
Co-authored-by: PopGamer46 <yt1popgamer@gmail.com>
Co-authored-by: RumiTiger <154005209+RumiTiger@users.noreply.github.com>
Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
Co-authored-by: Minemoder5000 <minemoder50000@gmail.com>
Co-authored-by: UBlueberry <161545003+UBlueberry@users.noreply.github.com>
Co-authored-by: Brandon Li <48413902+aspiringLich@users.noreply.github.com>
Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
Co-authored-by: Vasilis <vasilis@pikachu.systems>
Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>
Co-authored-by: K-Dynamic <20566341+K-Dynamic@users.noreply.github.com>
Co-authored-by: Ubaser <134914314+UbaserB@users.noreply.github.com>
Co-authored-by: AftrLite <61218133+AftrLite@users.noreply.github.com>
Co-authored-by: nikthechampiongr <32041239+nikthechampiongr@users.noreply.github.com>
Co-authored-by: Centronias <me@centronias.com>
Co-authored-by: joshepvodka <86210200+joshepvodka@users.noreply.github.com>
Co-authored-by: Scribbles0 <91828755+Scribbles0@users.noreply.github.com>
2024-11-07 20:09:25 +00:00
SolStar e06d593302
Add hushed trait (#2106)
* Add new speech trait: Hushed

* Hushed entities' local messages will now be whispers

* Sepeate Hushed check from prefix removal

* Move to Delta-v Namespace

* Minor refactoring

* Bug fixes

* Change to file scoped namespace

* Change comments more in line to DeltaV
2024-11-06 21:50:09 +00:00
Milon e7065f0e1f
stocks trading (#2103)
* sort of works

* fix

* oh right

* admin abuse

* buy/sell events

* price history, better error handling

* joke

* buying and selling

* access handling

* IT'S FINALLY REAL

* fixes

* AAAAAAAAAAAAAAAAA

* i keep fucking forgetting things

* FUCKING

* move company structs out of the comp

* ok im going to sleep

* Revert "oh right"

This reverts commit 8681e5a07b.

* Revert "fix"

This reverts commit 3992ec99fd.

* address reviews
2024-11-06 18:30:54 +01:00
Milon 1e0c4f3d11
the return of player character spawners (feat. mindshield bullshit) (#2072)
* aaaaaaaaaaa

* guh

* epic fail

* fuck it we ball
2024-11-06 09:50:48 +00:00
Milon f79cb26c51
cherry pick "fix BankClientComponent never updating" (#33123) (#2116)
* oh right

* fix
2024-11-04 16:56:23 +00:00
Milon 7f53bd3792
Addictions 2 electric boogaloo (#1897)
* OMG FINALLY FIXED THIS JANKY SHIT

* oh

* no structure, zero fucks given

* this also

* trolled

* shitcode v2

* FUCK

* what was i even fucking thinking???

* remove unused codeanalysis import

Signed-off-by: deltanedas <39013340+deltanedas@users.noreply.github.com>

---------

Signed-off-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
Co-authored-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
2024-11-04 14:55:13 +00:00
beck-thompson 4d81976f0d
Fix Syrinx implant (#2055)
* Fixed

* Added comment

* pro delta changes

* Evil

* please work!
2024-11-03 18:02:03 +00:00
Khoa Nguyen 06afad235b
Fixed trash not being spawned when throwing pies (#33013) (#2082)
* Fixed trash not being spawned when throwing pies

* Completely removed trash component flag check prior to the spawn loop
2024-11-01 13:29:37 +00:00
Milon a59dc99d0f
mail refactor (#2067)
* DEAR GOD

* shuffle shit around

* ohhhhhh
2024-10-28 19:32:07 +00:00
deltanedas b9d659596f
fix mail jobs not being localized (#2060)
* fix mail jobs not being localized

* JobTitle is also nullable how did this die

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-10-28 09:34:00 +00:00
Milon ede462870a
make teslas great again (#1916)
* RETAKE: fucking teslas

* take 2

* god's shittiest maintainers
2024-10-27 23:05:22 +00:00
Milon c8309ee53b
cherry-pick "Fix server crash on shutdown due to DB notifications" (#31379) (#2057)
Fix server crash on shutdown due to DB notifications (#31379)

Fixes #31365

Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>
2024-10-27 15:38:18 +00:00
Milon d50df0e13f
early merge killpersonconditionsystem refactor (#32680) (#2044)
zero appreciation for my work, part 2
2024-10-25 11:14:36 +00:00
deltanedas 7ab6ff12a2
use LocalizedJobTitle in crew manifest (#2037)
localize

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-10-24 12:54:35 +00:00
deltanedas 3e3f971c12 :trollface: 2024-10-24 09:09:54 +01:00
deltanedas a2281c892e early merge of #32940 2024-10-24 02:39:27 +01:00
deltanedas 6a533f2fea :trollface: 2024-10-24 02:36:25 +01:00
chromiumboy deaf652637 Visualized regions for NavMapControl (#31910)
* Atmospheric alerts computer

* Moved components, restricted access to them

* Minor tweaks

* The screen will now turn off when the computer is not powered

* Bug fix

* Adjusted label

* Updated to latest master version

* Initial commit

* Tidy up

* Add firelocks to the nav map

* Add nav map regions to atmos alerts computer

* Added support for multiple region overlay sets per grid

* Fixed issue where console values were not updating correctly

* Fixing merge conflict

* Fixing merge conflicts

* Finished all major features

* Removed station map regions (to be re-added in a separate PR)

* Improved clarity

* Adjusted the color saturation of the regions displayed on the atmos alerts computer
2024-10-24 02:25:28 +01:00
BramvanZijp a554fb5eb6 Several Ninja Suit power cell upgrade fixes. (#32902)
* Fix several jank issues with space ninja cell upgrades.

* Rework the code to comply with maintainer request.

* Fix some naming convention & formatting errors.

* Change from a custom check to an item whitelist to avoid power cages from fitting.

* Make the EntityUid of GetCellScore non nullable.

* Remove a line from a previous solution to the above problem I forgot to remove.

* Fix the magic number issue.
2024-10-24 02:25:27 +01:00
ScarKy0 87b100b703 Syringe gun! (#32112)
* Init testing

* copyright

* oops

* Tracking the embed entity uid

* testing stuff for gradual injection

* work

* weh

* god save me

* bleh

* Yippee!

* Again

* Mini syringe ammo

* cleaning up

* mini syringes have a texture for fill amount

* -3 cool points :(

* hitboxes

* init cleanup

* much needed fixes

* Fixes
2024-10-24 02:25:12 +01:00
Pieter-Jan Briers 0b504cf545 System to automatically restart server after certain uptime. (#32814) 2024-10-24 02:20:39 +01:00
Łukasz Lindert 30fef5fa1b Fix for low zombie blood (#32532)
fix for low zombie blood

Co-authored-by: Łuaksz <test@test.com>
2024-10-24 02:20:17 +01:00
MendaxxDev d523b1f79f exponential backoff for admin logs db update (#32865)
* exponential backoff for admin logs db update

* Update Content.Server/Database/ServerDbBase.cs

---------

Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com>
2024-10-24 02:17:25 +01:00
Errant 95aaa62309 Merge spider clan charges can be armed again (#32866) to Master (#32881)
HOTFIX spider clan charges can be armed again (#32866)

* fix ninja bomb component check

* remove TryGetRole
2024-10-24 02:14:32 +01:00
Errant 571f2ae2b9 Traitor activation fix for missing PDA (#30359)
* Implant the uplink if no PDA is found

* comments

* tidy up loose ends

* Whoops usually I start with the namespace, how did I forget it, shame shame

* Consistent data type for starting TC balance, misc changes

* Implant briefing, guidebook

* Update AutoTraitor, add uplink, codeword and briefing parameters to TraitorRuleComponent,  no pda for reinforcements

* engine 5c0ce43

* pass pda to AddUplink

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* nicer string handling

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* case typo 1

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* case typo 2

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* case typo 3

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* minor layout changes

* removed redundant implant check

* minor cleanup

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2024-10-24 02:14:32 +01:00
Theodore Lukin 32aa590c95 Fix warden being and qm being not considered head for tot kill head objective (#32721)
* fixed warden being and qm being not considered head for traitor kill head objective

* fixed hypothetical warden traitor not getting disk objective

* change suggested by deltanedas

* cleanup

* cleanup

* fix

* changed as suggested

* removed a dot in the comment

* removed an empty line

* reformulation
2024-10-24 02:12:06 +01:00
Leon Friedrich 4d4782313f Fix PlantHolder interactions & InteractionSystem assert (#32874) 2024-10-24 02:12:06 +01:00
Thomas 72b2319310 Sanitize shorthand emotes throughought the whole message (#28645)
* Rename ChatSanitizationManager to ChatEmoteSanitizationManager

The prior name was kind of confusing as there's a emote one and
then now there's also chat expansion happening in the accent system,
so knowing which I actually need to edit is useful.

So, I just need to keep myself not confused.

* Rename smileyToEmote and remove punctuation duplicates

The name SmileyToEmote is just... Bad.

Plus, I needed to remove the punctuation duplicates as that would
break any kind of regex parsing that I tried.

* Switch to regex from checking end of string

I also changed from System.Globalization to ILocalizationManager.

Writing that regex was definitely an experience.

* Document regex and the manager

* Rename it back

* Simplify regex
2024-10-24 02:11:06 +01:00
Zachary Higgs 27f5d6d817 Give AI a Sound Cue when an Antimov board is inserted (#32625)
* Subversion Board Insertion Audio Notification

Add Subversion flag and SubversionSound to SiliconLawProviderComponent

Add new Method (OnSubversionInserted)
to SiliconLawSystem to handle a Subversive
SiliconLawProviderComponent and play it's SubversionSound

Add Check for Subversive law provider to OnUpdaterInsert that
calls OnSubversionInserted if the SiliconLawProviderComponent is
Subversive

* Fix subversion Sound

- Change out Weh sound used to test that subversion sounds can be
changed by prototype for a a not yet present Antimov subversion sound

* Make it not just subversive

- Remove OnSubversionInserted and move the MindPlaySound in the
OnUpdaterInsert so long as LawUploadSound exists

- Modify SubversionSound into LawUploadSound

- Remove the Subversion flag

- Just use emagged_borg.ogg until the better one is made

* Remove errant spaces and a errant namespace

* CR Fixes - Add generic Lawboard insert cue

- Combine the If statements per /pull/32625#discussion_r1786926400
inside OnUpdaterInsert

- Remove the ViewVariables(VVAccess.ReadWrite) per
pull/32625#discussion_r1786924433

- Add Cryo_warning.ogg from TGStation, the sound utilized for Law Upload
cue, Attribution.

* CR Add a placeholder Antimov notification sound

- Add a new sound kitbashed from the cryo_sound used for uploading
and the emagged noise

* Add self referential source attribution

- also fix an errant space

* Add more bespoke Sound by ps3moira + attributions
2024-10-24 02:09:07 +01:00
lzk caab01d01e Fix holosignsystem popup (#32808) 2024-10-24 02:09:07 +01:00
LittleNyanCat 2306368492 Several small SFX tweaks (#28897)
* Several small sfx tweaks

* fix small yml oopsie

* Redo the basin code to use events

* now uses an event for when the transfer is successful, not when there's just an attempt

* forgot to remove this

* Update Content.Server/Botany/Components/PlantHolderComponent.cs

Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>

* Update Content.Server/Botany/Systems/PlantHolderSystem.cs

Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>

* adds sound variations to shoes as well

* variations on honkbots and the H.O.N.K mech

* Update Content.Server/Botany/Systems/PlantHolderSystem.cs

* Update Content.Server/Botany/Systems/PlantHolderSystem.cs

* fix compile issue

* oops forgot to delete this

* cleanup

---------

Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2024-10-24 02:08:06 +01:00
IProduceWidgets 7629eedbe7 FTL coordinate disk command for admins: ftldisk (#28075)
* Add robo control comp, also de-reinforce a lot of walls.

* Revert "Add robo control comp, also de-reinforce a lot of walls."

This reverts commit b6be6b616aa9732b81e02bed76e3c9ae103cf7cb.

* FTLdiskburner command to make FTL disks.

* Elegant failure on mistyped ID.

* even more more eleganter failures.

* foo

* bar

* I have reached completion

* prevent id confusion

* I'm givin' her all she's got captain!

* a bit more hug boxing for safe destinations.

* comments for foo

* extra thoughts.

* cleanup

* continuen't

* Improve feedback strings

* reviewer QOL

* Reviewer QOL 2

* handle easy reviews

* Add comments to clarify reviews

* howdoicode to the rescue.

* ftldisk in hand

* ftl.ftl

* funny disk case

* loc

* unusing
2024-10-24 02:08:05 +01:00
IProduceWidgets b9b3b0dfd2 Fix omega cursed smite code. (#32844)
* le fixo smotes

* CURSE OF BLINDNESS

* Guh
2024-10-24 02:08:05 +01:00
slarticodefast 827b65ffdf Fix plant holder double solution transfer (#32813) 2024-10-24 02:08:05 +01:00
metalgearsloth 81873aa3ab Fix tech anomaly nexttimer (#32805) 2024-10-24 02:06:02 +01:00
ScarKy0 21c600d4ca Cyborg module action icons (#32505)
* Init

* added jani and medical

* + sci and service modules

* + syndi modules

* fixing up

* geiger counter stuff
2024-10-24 02:06:02 +01:00
Kevin Matuschzik 5af96d5429 Fixed portal artifacts targeting the Ai (#32677)
* Added checks to not target AIs and people in containers

* made the change to use IsEntityInContainer. Much Better!

* returned old Mindquerry and removed wrong use of admin logger

* guard statment

* removed unnecessery refs and fixed position swap

* Minor change

---------

Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2024-10-24 02:06:01 +01:00
Джексон Миссиссиппи 53e4abf428 cleanup melee (#32486)
* it removes warns ig

* Quick fix

---------

Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2024-10-24 02:06:01 +01:00
Pieter-Jan Briers a75c5b7eae Fix role ban loading bugs (#32725)
This code was a mess. Now it's less of a mess and user UserDbDataManager now.

Fixes the following bugs:

* If you connect to a server, restart your client, connect again in the same round, you role bans would not be visible in the client.
* If you role ban somebody who is not connected to the server, then they connect within the round, they will only have the recently-applied ban.

Likely fixes #24781, #27282
2024-10-24 02:01:46 +01:00
Leon Friedrich a7c6acd402 Hide role entities in the spawn menu (#32798) 2024-10-24 02:01:21 +01:00
Leon Friedrich 8057cee55a Add role prototype validation tests (#32801)
* Add role prototype validation test

* Rejig GetPrototypesWithComponent

* More tests n stuff
2024-10-24 01:59:40 +01:00
Pieter-Jan Briers a926d0810f Fix some rounds failing to end due to mind roles (#32792)
* Fix some rounds failing to end due to mind roles

Fixes #32791

This is caused by ShowRoundEndScoreboard running into a bug trying to display antags: some player is showing up as antag with MindIsAntagonist(), but has no antag roles listed in MindGetAllRoleInfo().

This was caused by one of the roles of the player having the Antag boolean set, but having no AntagPrototype set.

The responsible mind role appeared to be MindRoleSubvertedSilicon which is missing a set for the SubvertedSilicon antag prototype.

I also added resilience to the round-end code to make it so that an exception showing the scoreboard (and sending the Discord message) would not cause the round end logic to completely abort from an exception.

I am planning to add an integration test to cover this bug (no prototype in mind roles), but I'll leave that for not-the-immediate-hotfix.

* At least one maintainer approved this tiny PR without reading it, not naming names.
2024-10-24 01:59:40 +01:00
John 110232dfa9 Fixing Thief Beacon Role Check Logic (to use new mindrole system) (#32764) 2024-10-24 01:58:17 +01:00
slarticodefast bdf4b7cf9d Don't error on missing component in ChangeHeat (#32451) 2024-10-24 01:56:14 +01:00
eoineoineoin 2c001fb6dc Make APC UI work correctly with multiple users (#32465)
* Make APC UI work correctly with multiple users

* Check access only on client, when constructing UI

* Do TODO (Thanks, Robust 236.1)

---------

Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es>
2024-10-24 01:56:14 +01:00
deltanedas eeb06fac47 update for mind roles and fix random stuff, localize alt ids 2024-10-24 01:55:17 +01:00
nikthechampiongr 2098868364 Fix bounties(and potentially other things) running out of ids (#32700)
* Make NameIdentifier Ids get refreshed after round restarts

Before this commit the existing values would just get shuffled.
This means that eventually the server would run out of ids to give to
new entities for different groups. As a result everything would get id 0

* Comply with what seemingly is the convention for sawmills

* Make it impossible to insert a bounty with a duplicate id

* Reduce duplication

* Remove unused sawmill

* Fix rustbrain and skill issue

* Aaaa

* Apply suggestions from code review

---------

Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com>
2024-10-24 00:32:48 +01:00
Errant ab5d439272 Mind Role Entities (#31318)
* Mind Role Entities wip

* headrev count fix

* silicon stuff, cleanup

* exclusive antag config, cleanup

* jobroleadd overwerite

* logging stuff

* MindHasRole cleanup, admin log stuff

* last second cleanup

* ocd

* minor cleanup

* remove createdTime datafield

* now actually using the event replacement I made for role time tracking

* weh
2024-10-24 00:32:47 +01:00
Pieter-Jan Briers e475512e7b Fix error log when recycling something with small material counts. (#32723)
* Fix error log when recycling something with small material counts.

MaterialStorageSystem.SpawnMultipleFromMaterial now doesn't call StackSystem.SpawnMultiple if it tries to spawn zero. This happens because the recycler calls SpawnMultipleFromMaterial for everything recycled, even if the amount it has stored is < the amount for one sheet.

* Update Content.Server/Materials/MaterialStorageSystem.cs

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2024-10-24 00:17:33 +01:00
beck-thompson f194cc45c9 Plushies can now have pAIs stuffed into them (v2)! (#30805)
* First commit

* I forgot silly me

* Actually added comments

* spellin

* fixes

* more blacklists

* Minor fixes

* Speech Verb also changes now

* Simple name stuff

* Other fixes

* remove one line of whitespace

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2024-10-24 00:17:33 +01:00
chavonadelal a24c85a1dd Job title localization (#32338)
* Job title localization

* Correcting fields
2024-10-24 00:11:34 +01:00
SlamBamActionman 8c2f2cfe2b Add admin log for codewords (#32531)
* initial commit

* Delta review
2024-10-24 00:11:33 +01:00
lzk a770b7ee54 Fix cryo locale again (#32654)
* Fix cryo locale again

* yeep
2024-10-24 00:08:00 +01:00
Milon 1f21b4601a
disable the stupid fucking rate limit popup (#2033)
I DON'T CARE
2024-10-22 07:07:26 +00:00
Milon a64c71535e
untroll glimmermobspawnrule (#1980)
* fix your shit

* take 2

* take 3
2024-10-14 23:43:16 +00:00
Radezolid 6082d47778
Adds the coordinates to the rattle message. (#1983)
Adds the coordinates to the rattle.
2024-10-14 20:06:50 +02:00
Saphire Lattice 4204854297 Change minibomb to be explosion resistant and start timer on damage (#32429)
* Make minibomb explosion resistant and trigger timer on damage

* Tune damage behaviour and threshold for minibomb
2024-10-08 01:14:09 +01:00
Saphire Lattice acc4499420 Change the syndicate charge to start a timer on signal (#32423)
* Change the syndicate charge to start a timer on signal

* Actually add the component in question

* Add default link for TimerStart signal
2024-10-07 22:31:42 +01:00
Saphire Lattice 876486339b Make the explosions throw the container/item they originated from (#32428)
Extra fun if it's something that can trigger multiple times
2024-10-07 22:31:34 +01:00
Plykiya fb2604b4a4 Two additional checks to prevent FTLing stations (#32558)
Add two additional checks to prevent FTLing
2024-10-07 22:31:01 +01:00
deltanedas 7e435cf8cb
Merge pull request #1957 from deltanedas/upstream-ops
upstream merge 2/10
2024-10-02 22:09:14 +00:00
deltanedas cc6bbfebd4
port psionic sacraficing (#1883)
* uncomment and update guidebook

* update loot pool to use entity table and dont hardcode bluespace

* add sacraficing to altars

* :trollface:

* :trollface:

* :trollface:

* 2 lines of sec

* rename files

* replace gamer loot with fake wizard outfit or a normality crystal

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-10-02 13:04:35 +00:00
deltanedas 5719e73e22
make fugitives anonymous (#1817)
* make fugitives anonymous

* add either dna or prints to the report

* :trollface:

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-10-02 15:03:40 +02:00
deltanedas 42b47a0f20 finish syrinx rework and other fix 2024-10-02 13:03:03 +01:00
deltanedas bf54bc3364 :trollface: 2024-10-02 12:28:34 +01:00
ArchRBX 5f795d84e0 MedTek Cartridge (#32450)
* initial commit

* adds cartridge to cmo's locker

* tidies up yml, adds default scanner sound, makes it so the silent property silences the scanner sound too

* fixes ert medic pda not having it preinstalled

* adds attribution

* removes redundant dependencies

* fix agent pda

---------

Co-authored-by: archrbx <punk.gear5260@fastmail.com>
2024-10-02 12:23:15 +01:00
Golinth 712640f75c Added Firebots - Real (#32482)
* Add Firebots

Had to add OnActivateInWorld to the spray system to get the bot to work. Checks for the flammable component and if the onFire boolean is true.

* Make SpraySystem actually use useDelay

got rid of that TODO

* Added firebot speech

Fire detected!
2024-10-02 12:16:27 +01:00
drakewill-CRL 9e60af1209 Use archived gas mixture in gas exchange comparison (#32088)
The comparison for doing gas exchange used current and not archived
moles. This could lead to update order-dependent gas spreading effects.

To fix this, convert TileAtmosphere's MolesArchived and
TemperatureArchived to a AirArchived, and use that in the comparison
method.

---------

Co-authored-by: PraxisMapper <praxismapper@gmail.com>
Co-authored-by: Kevin Zheng <kevinz5000@gmail.com>
2024-10-02 12:13:09 +01:00
slarticodefast 79ec0cb1cf Fix mutation system debug assert (#32530) 2024-10-02 12:09:34 +01:00
SlamBamActionman e8e687ce7c Add webhook for votekicks (#32513)
* Initial commit

* Localization
2024-10-02 12:09:34 +01:00
Leon Friedrich da431bbb81 Add interaction rate limits (#32527)
* Move PlayerRateLimitManager to shared

* Add interaction rate limits

* uncap tests
2024-10-02 12:09:34 +01:00
nikthechampiongr a5ebe6a25d Fix RA0032 (#32514) 2024-10-02 12:08:12 +01:00
MilenVolf bfa43833d3 Replace obsolete Tile Access methods (#32508)
* Replace obsolete SetTile

* Remove obsolete GetTileRef & GetAllTiles

* Forgor

* Apply suggested `GetMapOrInvalid`
2024-10-02 12:08:12 +01:00
metalgearsloth 46a3d6d100 Optimise drains (#32230)
* Optimise drains

If it's still a problem then we do what I did for rmc14 and just dump all the active drains onto a job to getentitiesinrange in parallel.

* Fixes
2024-10-02 12:08:11 +01:00
beck-thompson b4452f8fa5 Predict appraisal tool verb! (#32496)
* First commit

* Network :(
2024-10-02 12:08:11 +01:00
Fildrance 75f17c9c97 Station AI ability to electricute doors (#32012)
* Boom! Emergency access!

* Emergency access sound

* locale

* Updated sounds

* bleh

* Door electrify base

* feat: popups on attempt to activate AI action when wires cut

* refactor: use SharedApcPowerReceiverComponent to check if AI can interact with door

* refactor: added icon and sound for door overcharge

* meta.json should use tabs not spaces

* refactor: extracted sounds for airlock overcharge to static field in system

* refactor: cleanup, ScarKy0 mentions for resources

* refactor: removed unused textures

* feat: now notification is displayed when AI attempting to interact with door which have wire cut

* StationAiWhitelistComponent is properly gating  BUI OnMessageAttempt, SharedPowerReceiverSystem.IsPowered is now used to check if device powered

* refactor: use PlayLocal to play electrify sound only for AI player

* refactor: SetBoltsDown now uses TrySetBoltDown, checks for power.

* bolts now check for power using SharedPowerReceiverSystem

* electrify localization and louder electrify sounds

* extracted ShowDeviceNotRespondingPopup, reverted airlocks not opening/closing when ai wire was cut

* refactor: cleanup

* New sprites and fixes

* Copyright

* even more sprite changes

* refactore: cleanup, rename overcharge => electrify

---------

Co-authored-by: ScarKy0 <scarky0@onet.eu>
Co-authored-by: pa.pecherskij <pa.pecherskij@interfax.ru>
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
2024-10-02 12:06:48 +01:00
metalgearsloth 9a59024f13 Predict stripping (#32478)
* Predict stripping

Stops mob verbs from getting moved around again.

* Bola

* Fix ftl
2024-10-02 12:06:37 +01:00
beck-thompson 41341a8a03 Voice Mask refactor (#30798)
* First commit

* Added base.Initialize()

* Voice wire fix (Electricty name)

* Various minor cleanups

* Localized default voice mask name

* Added VoiceOverride stuff

* Removed unused stuff

* Typo

* Better localized stuff

* Typo / spelling stuff / comments

* Blessed
2024-10-02 12:06:05 +01:00
SlamBamActionman fccb0e30ed Add Votekick functionality (#32005) 2024-10-02 11:38:43 +01:00
themias 79e8470cd5 Fix agent ID card unlimited range (#32445)
* Fix agent ID card unlimited range

* update order to be more optimized
2024-10-02 11:38:42 +01:00
goet 8847889eeb Fix contraband never getting added to vend inventory (#32431)
* fix contraband never getting added to vend inventory

* Revert "fix contraband never getting added to vend inventory"

This reverts commit e7fb3a60c3cb6fcbf41d7f015f13dbc7b1c1901d.

* readd setter method to system

* fix again without reparenting
2024-10-02 11:38:42 +01:00
Brandon Hu 89e29c47c4 fix(BatterySelfRecharger): Fully charge BatterySelfRechargers (#30627) 2024-10-02 11:38:42 +01:00
Pieter-Jan Briers 7974306676 Fix cartesian explosion in pref loading (#32434)
Lol .AsSingleQuery().

Some people's preferences wouldn't load on Lizard. Turns out the entire preferences set is loaded with a morbillion joins in a single query and one person had 240,000 (!!!) rows returned for their preferences query. Yeah.
2024-10-02 11:38:42 +01:00
ArchRBX 726ad01ccd AstroNav GPS Cartridge (#32194)
* initial commit

* adds astronav cartridge to QM locker

* changes requested in review

* fix merge conflicts

* fixes the statuscontrol disappearing if you eject the cartridge but still have it installed

* fix notificationsenabled on salv pda proto

* fixes lingering statuscontrol on eject while held

---------

Co-authored-by: archrbx <punk.gear5260@fastmail.com>
2024-10-02 11:36:12 +01:00
Pieter-Jan Briers 63eefe060d Fix OOC not re-enabling if restartroundnow is used (#32401)
The ChatSystem code for re-enabling OOC only ran during PostRound, which gets skipped over when doing restartroundnow. Now it does this on PreRoundLobby too.
2024-10-02 11:29:23 +01:00
metalgearsloth 845a04c1d7 Predict vending machine BUI (#32376) 2024-10-02 11:24:27 +01:00
PotentiallyTom 393dc95028 Makes it possible to disable the vent pressure lockout temporarily with a screwdriver (#31050)
* builds

* doesn't crash

* seems to work

* distance cap was dumb

* Requested changes

* can't find any issues from making the changes

* Check for anchor and minor optimisation

* Removed unnecessary usings

* Code less verbose and cleanup
2024-10-02 11:22:34 +01:00
AsnDen e6c7792f89 AI now "can" use media console (#32334) 2024-10-02 11:22:03 +01:00
Milon ddcb212778
cherry pick "Fix currency duplication bug (#32524)" (#1936)
Fix currency duplication bug (#32524)

Co-authored-by: Leon Friedrich <60421075+ElectroJr@users.noreply.github.com>
2024-09-29 14:24:09 +00:00
deltanedas 4d6af523bc :trollface: 2024-09-22 03:39:29 +01:00
Plykiya 5260d8b622 Rat kings can butcher things (#32232)
* rat kings can butcher things

* minor organization

* fix

* important comma
2024-09-22 02:58:31 +01:00
deltanedas 239deca8bd increase thieving beacon range to 2 (#31340)
* increase thieving beacon range to 2

* add obstruction check

* review

* Entity<T?> strikes again

* webedit ops because github died or something

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-09-22 02:46:57 +01:00
lzk 0705af9640 fix conjugate have in cryo locale string (#31993) 2024-09-22 02:46:11 +01:00
Tayrtahn 00e00d9fd8 Fix Set Outfit command/verb (#29672)
* Filter Set Outfit menu to exclude loadout sets

* Apply loadouts to job outfits

* Use appropriate species for Urists

* squishy

---------

Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2024-09-22 02:45:06 +01:00
IProduceWidgets bb65810671 Clean up solution regen and drain comps (#29777)
* clean up solution regen and drain comps

* Tape applied.

* Update Content.Server/Chemistry/Components/SolutionRegenerationComponent.cs

Co-authored-by: Tayrtahn <tayrtahn@gmail.com>

* remain entity

* That has to be a rogue test fail.

---------

Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
2024-09-22 02:45:06 +01:00
Luiz Costa 5968726e65 Fix TEG acting as infinite energy source on destruction (#29972)
* TEG now checks for power supply before checking for IsFullyBuilt

* Update Content.Server/Power/Generation/Teg/TegSystem.cs

Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
2024-09-22 02:45:05 +01:00
Winkarst 8b535b1a9f Make fire leave burnt decals on the tiles (#31939)
* Make fire leave burnt decals on the tiles

* License

* Yes

* Update

* Spelling error

* Prototypes reload support

* To array
2024-09-22 02:44:51 +01:00
SlamBamActionman 095fb63bca Allow containment field generators to be enabled on mapinit (#31158)
* Initial commit

* review fix
2024-09-22 02:44:51 +01:00
ShadowCommander 9ae32dce9e Give prototype refactor (#29697)
* Update GivePrototype

* File scoped namespace

* Change to EntProtoId instead of ProtoId<> for better validation
2024-09-22 02:44:51 +01:00
DrSmugleaf a8c2444a66 Add mapping editor (#23427)
* Add mapping editor (#757)

* Remove mapping actions, never again

* Cleanup actions system

* Jarvis, remove all references to CM14

* Fix InventoryUIController crashing when an InventoryGui is not found

* Rename mapping1 to mapping

* Clean up context calls

* Add doc comments

* Add delegate for hiding decals in the mapping screen

* Jarvis mission failed

* a

* Add test

* Fix not flushing save stream in mapping manager

* change

* Fix verbs

* fixes

* localise

---------

Co-authored-by: DrSmugleaf <DrSmugleaf@users.noreply.github.com>
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>
2024-09-22 02:44:27 +01:00
chavonadelal 418ced1530 Localization of the shuttle call sender (#32286) 2024-09-22 02:38:56 +01:00
Winkarst ba94df3dcb Use TurfSystem.IsTileBlocked instead of TurfHelpers (#32174)
* Use TurfSystem.IsTileBlocked instead of TurfHelpers

* !
2024-09-22 02:38:29 +01:00
Leon Friedrich e7ac40578a Fix AudioSystem nullability checks for engine PR (#32233) 2024-09-22 02:38:29 +01:00
drakewill-CRL 3951e2dcdf Fix plant mutations carrying over to other plants and future rounds (#32257)
Lists are a reference type, so each component should get a new one, not point at the previous one.

Co-authored-by: PraxisMapper <praxismapper@gmail.com>
2024-09-22 02:38:29 +01:00
Ed 482caea466 fix Tech anomaly loud sounds and superfast flickering (#32245)
Update TechAnomalySystem.cs
2024-09-22 02:38:29 +01:00
Ed dd701436ab Anomalous infections (#31876)
* inner anomaly

* anomaly pulse action

* test anom mine

* Update anomalies.yml

* fix action cooldown

* pyro_eyes

* clientsystem

* experiments

* blya

* some telegraphy

* shock eyes!

* shadow eyes

* separate files

* frosty eyes

* fix

* flora eyes

* bluespace eyes

* flesh eyes

* redoing injction

* auto add layers

* пипяу

* new injector component

* stupid me

* nice marker injectors

* anomaly spawn on shutdown

* gravity anom

* dead anomaly spawning

* add VOX states

* sprite specific layers support

* technology anom infection

* auto detach anomalies that have moved away

* Update anomaly_injections.yml

* anomalyspawner integration

* rock anomaly!

* Update anomaly_injections.yml

* fix crash bug

* tag filter

* fix anom dublication spawns

* Update anomaly.yml

* Update InnerBodyAnomalyComponent.cs

* Update anomaly_injections.yml

* dont spawn anomalies after decay

* fix morb sprite, add end message

* gravity resprite

* admin logging, double injection fix

* make flesh and living light mobs friendly to anomaly hosts

* popups

* severity feedback

* sloth review

* A

* keep organs after gib

* punpun host

* sloth synchronization

* Update arachnid.yml

* increase infections spawnrate
2024-09-22 02:38:28 +01:00
chavonadelal ffdf6bb838 Localization of steal targets (#30153)
* Localization of steal targets

* Correction of localization of theft objects

* The second correction of the localization of theft targets

* Update steal-target-groups.ftl

Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com>

* Revision of the localization method

* Choosing a simple option for localization

* Fix TechnologyDisk name

* Corrections based on feedback received

* correction of declension

---------

Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com>
2024-09-22 02:36:01 +01:00
lzk 02dfbd94c4 localize skeleton accent (#32166)
* localize skeleton accent

* commit number 2

* remove that from this

* this

* babushka
2024-09-22 02:24:29 +01:00
deltanedas a65484e61a prevent using holo inside containers (#32068)
Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-09-22 02:23:50 +01:00
Plykiya 7f19d50900 Fix build and lint (#32180) 2024-09-22 02:23:50 +01:00
drakewill-CRL 31e3ef00fa Botany Rework Part 1: Mutations (#31163)
Instead of each mutation being a flag that gets checked at some unique point in BotanySystem somewhere, they're now EntityEffects that get applied when the mutation occurs and when produce is harvested. One new list was added to SeedData so that multiple other fields could be removed.

All the non-stat-change mutations that have been rolled are added to the Mutations list, and get applied to the plant when the mutation occurs or when a seed with the mutation is planted. Produce get mutations applied at harvest if they apply to the produce, and carry all of the plant's mutations over as a seed. This gets rid of the one-off checks for things like Slippery, Bioluminescent, Sentient, etc.

The base odds of a mutation applying should be equal to the odds of the original mutation check. It pretended to have 1 bit flip (on averge) per mutation power, and odds of each mutation was the odds of one of its bit being flipped (1 /275 * bits). The 'thermometer code' applied for numbers will be replaced with simple random rolls, as both average out to the middle value. The new checks are much easier to understand and don't obfuscate the actual changes of something happening behind 3 layers of math. The biggest player-facing change is that Potency will be able to get over 65 significantly more often than it did in the previous system, but it will be just as common to get low values as high ones.

Mutation definitions have been moved to a .yml file. These include the odds per tick per mutagen strength of that mutation applying that tick, the effect applied, if it applies to the plant and/or its produce. This makes mutations simpler to add and edit.

This PR is limited specifically to the mutation logic. Improving other aspects of the system will be done in other PRs per the design document. Mutations was chosen first because its got the largest amount of one-off checks scattered all over that could be consolidated. Once this is merged, mutations could be contributed to the codebase with minimal extra work for later botany refactor PRs.
2024-09-22 02:23:49 +01:00
Partmedia 01eb4aca7c Make pressure and volume pumps require power (#28995) 2024-09-22 02:23:49 +01:00
nikthechampiongr 9a089a1f04 Rename fix (#31654)
* Localize RenameCommand and delegate most of the process to MetaDataSystem.SetEntityName()

* Make renaming rely on the EntityRenamedEvent. Fix issue where renaming would keep old Examine text

Requires engine change

* Fix localisation strings

* Make PDA search be based on a renamed entity's Uid instead of its old name

To do this the pda component now has an PdaOwner field which gets
assigned when it is given as a loadout to a player

* Fix bad merge???

huh

* Use AllEntityQuery
2024-09-22 02:23:49 +01:00
slarticodefast e12eb474e5 fix infinite banana bug (#32167) 2024-09-22 02:23:34 +01:00
Winkarst fbe93227f1 Use Transform instead of TryComp<TransformComponent> (#32170)
Use Transform instead of TryComp
2024-09-22 02:23:28 +01:00
BIGZi0348 904b8ea110 Moved hardcoded string "PEOPLE" to Loc.GetString() (#32164) 2024-09-22 02:22:13 +01:00
deltanedas 55e6e3b3eb
make meteors duds on glacier (#1872)
* make meteors duds on glacier

* remove unused explosive from copy paste

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-09-20 13:23:14 +00:00
DisposableCrewmember42 8bb4681515
feat: Different Oracle Bark Types, default to Never (#1786)
* feat: Different Oracle Bark Types, default to Never

* refactor: Add newline before EOF

* refactor: move BarkType into component, remove redundant argument

* refactor: don't nest OracleBarkType

* style: Add missing newline
2024-09-18 00:09:06 +10:00
deltanedas d98fbbe1ad
make random sentience a glimmer event + fix glimmer events not existing (#1834)
* add MaxSpawns to GlimmerMobRule

* remove defunct nyano event code

* add glimmer event scheduler and fix events

* add glimmer event scheduler to all presets

* typo ops

Signed-off-by: deltanedas <39013340+deltanedas@users.noreply.github.com>

---------

Signed-off-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-09-17 05:44:14 +00:00
deltanedas eecda36f51 remove uses of removed obsolete code 2024-09-14 14:57:07 +01:00
Mervill ce286f78f4 Replace obsolete code in GasPortableSystem (#31407) 2024-09-14 14:31:50 +01:00
deltanedas 977b5dad64 network airlock AutoClose (#32124)
* network airlock AutoClose

* least stupid language

* great language

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-09-14 14:27:12 +01:00
Pieter-Jan Briers de1ecb95ca Fix powered machines working unpowered if the panel is open. (#32135) 2024-09-14 14:27:12 +01:00
Fildrance 8a3fa634de Fix setmapatmos temperature argument
Co-authored-by: pa.pecherskij <pa.pecherskij@interfax.ru>
2024-09-14 14:27:12 +01:00
slarticodefast f8a97c378d Add extradimensional orange, holymelon, meatwheat, worldpeas mutations (#27624)
* new mutations

* translation string fix

* add haloperidol to plant

* fix

* add FoodSequence

* food sequence fixes
2024-09-14 14:27:11 +01:00
Gorox221 1e910d9b66 Eject mech pilot alert (#31649)
* Bruh

* well

* yes
2024-09-14 14:27:11 +01:00
Errant d1f48cf16b movercontroller namespace (#31749) 2024-09-14 14:27:10 +01:00
lzk a75de13ad5 don't apply traits for borg and ai (#31990)
* doesn't apply traits for borg or ai

* add some comment and summaries

* weh

weh

* well ok

Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com>

---------

Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com>
2024-09-14 14:26:27 +01:00
Tayrtahn bd542971a6 Add guidebook protodata tag: embed prototype values in guidebook text (#27570)
* First clumsy implementation of guidebook protodata

* Support for Properties, format strings

* Better null

* Rename file

* Documentation and some cleanup

* Handle errors better

* Added note about client-side components

* A couple of examples

* DataFields

* Use attributes like a sane person

* Outdated doc

* string.Empty

* No IComponent?

* No casting

* Use EntityManager.ComponentFactory

* Use FrozenDictionary

* Cache tagged component fields

* Iterate components and check if they're tagged
2024-09-14 14:26:27 +01:00
blueDev2 5a6a92cd50 Add ReagentWhitelist to Injector component and system (#28262)
* Add reagent whitelist to Injector component and system

* Apply suggested Changes

* Remove LINQ function for performance

* Update Content.Server/Chemistry/EntitySystems/InjectorSystem.cs

Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com>

---------

Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com>
2024-09-14 14:26:27 +01:00
metalgearsloth 02b7b1254d Reapply "FTL + AI fixes (#31952)" (#31968) (#32094)
* Reapply "FTL + AI fixes (#31952)" (#31968)

This reverts commit c46a4ab876ff0baa1e0636569751b120c27f710c.

* Update
2024-09-14 14:26:27 +01:00
metalgearsloth cbd7e434c2 Fix latejoins (#32093)
For realsies :)
2024-09-14 14:24:35 +01:00
lzk df02b9ad46 Change forensic pad to use label isntead of name changing (#31842)
change name change to label
2024-09-14 14:23:35 +01:00
deltanedas 0a7b7645aa dont log missing ArtifactComponent for artifexium (#32073)
Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-09-14 14:23:35 +01:00
themias 195fea60bf Fix cauterization spam from space damage (#32080) 2024-09-14 14:23:35 +01:00
Ed d9550335a2 TechAnomaly fixes (#32067)
Update TechAnomalySystem.cs
2024-09-14 14:23:34 +01:00
SlamBamActionman 7dc6709643 Fix Station AI being affected by Bureaucratic Event (#32021)
* init commit

* I forgot components exist

* delta told me to make it a list
2024-09-14 14:23:14 +01:00
metalgearsloth 52c4875d96 Reapply "Fix spawnpref" (#32018) (#32058)
This reverts commit 119dd610fa30edd3927cd51acbc68601f7d0b8e0.
2024-09-14 14:23:14 +01:00
Nemanja 5215e59a76 Mining Asteroid Treasure Vaults (#31638)
add interior rooms to the vgroid
2024-09-14 14:22:59 +01:00
DisposableCrewmember42 8a85c49f0e fix: Check revenant ability costs correctly (#32050)
* fix: Check revenant ability costs correctly

* refactor: Idiomatically get negative value
2024-09-14 14:18:27 +01:00
TurboTracker 927990848d Removal of Maxcaps via cvar (#31437)
* Comment out gastank explosion trigger

* CVAR creation

* Blank line between method + toml update

* I fucking hate VistualStudio

* change bool logic into float

* cat dancing.gif

* Adjust some minor nits

* Update Content.Server/Atmos/EntitySystems/GasTankSystem.cs

Co-authored-by: Partmedia <kevinz5000@gmail.com>

* Un-hardcode unused initial cached CVar value

* Update Resources/ConfigPresets/WizardsDen/wizardsDen.toml

---------

Co-authored-by: Kevin Zheng <kevinz5000@gmail.com>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2024-09-14 14:17:42 +01:00
Ed 46d4d7d5a6 FoodSequence fix (#32034)
Update FoodSequenceSystem.cs
2024-09-14 14:12:44 +01:00
Emisse b2209d3f35 Revert "Fix spawnpref" (#32018) 2024-09-14 14:06:41 +01:00
lzk 0636958fd8 Special latejoin message for captain (#31991)
* Special latejoin message for captain

* fix gender in locale

* remove this for now

* shame

* not really shame

* change

* do that
2024-09-14 14:06:29 +01:00
metalgearsloth 3999999e63 Fix spawnpref (#31892) 2024-09-14 14:06:16 +01:00
themias 15b0315e5f Save unpublished news articles (#31491)
* Add draft saving to news consoles

* fix after bui changes

* comments + rename vars

* no
2024-09-14 14:04:52 +01:00
Hreno ecf2ea7332 Display agents' jobs in the Round End Summary window (#31652) 2024-09-14 14:02:06 +01:00
Cojoke 283eacd83c Nuke Now Requires the Disk to be Inserted to Toggle Anchor (#29565)
* Nuke Now Requires the Disk to be Inserted to Toggle Anchor

* message stating you need the disk to toggle floor bolts
2024-09-14 14:02:05 +01:00
godisdeadLOL 75cca5e31b Surveillance camera's red light fixes (#31831)
several surv camera related fixes

Co-authored-by: YourUsername <you@example.com>
2024-09-14 13:58:55 +01:00
qwerltaz ae765872e6 fix dragon spawn location and round end summary (#31890)
* spawn dragon rule at station edge

* 2

* stuff

* fix round end summary not showing

* no invalid euid
2024-09-14 13:58:54 +01:00
Pieter-Jan Briers 1a94de83db Extend shuttle dock time if the shuttle doesn't dock at evac. (#31496)
* Extend shuttle dock time if the shuttle doesn't dock at evac.

If the shuttle can't dock at evac for *some reason*, it will instead try to dock at another port on the station. And if that fails it goes somewhere random on the station.

Because of the chaos and confusion caused by this, many people will frequently not get to the shuttle in time under these circumstances. This sucks for everybody.

To alleviate this, the shuttle launch timer will now be extended if the station doesn't dock at its ideal spot. The default values (controlled via CVar) are 1.667x and 2x respectively for "wrong dock" and "no dock at all" scenarios.

The code around here was a mess, so I fixed that too. "CallEmergencyShuttle" has been renamed to "DockEmergencyShuttle", the overload that did the actual docking has been renamed to DockSingleEmergencyShuttle. Code has been split into separate dock -> announce methods so we can calculate shuttle delay in between the case of multiple stations.

Also made the "shuttle couldn't find a dock" text announce the time until it launches and fix the shuttle timers not triggering for it.

* Minor review

---------
2024-09-14 13:56:26 +01:00
slarticodefast 16fe76520d Revert "FTL + AI fixes (#31952)" (#31968) 2024-09-14 13:53:58 +01:00
metalgearsloth da10fbe6e8 FTL + AI fixes (#31952) 2024-09-14 13:52:59 +01:00
nikthechampiongr f51d37bcef Add completions to addobjective and localize it (#30456)
* Add completions to addobjective and localise it

* Cleanup

* Fix

* Make a manager to handle subscribtion completion options

This is so we can unsubscribe to prototype reloads properly

* Convert the manager into a system

* Move the system into the systems folder

I forgor

* Merge CompletionsSystem into ObjectivesSystem
2024-09-14 13:52:41 +01:00
Ed a59f68e227 Metamorphosis - FoodSequence 3 (#31012)
* setup some data

* cheeseburger recipe

* Update FoodSequenceSystem.cs

* finalize cheseburger recipe

* remove fun

* return old taco sprites

* full foodsequence data refactor

* return tacos

* well done

* add cutlets to burger

* chickenburger recipe

* +2 burger recipes

* more fun

* Update brain.png

* some slice produce added

* documentation

* watermelon

* skewer work

* flipping

* tomato

* skewer watermelon

* Update skewer.yml

* oopsie, ok, im go to sleep

* fix checks

* Update produce.yml

* screwed

* cheeeeeeeese

* all cooked meat added

* produce added

* aaaaand suppermatter

* key to Tag

* More

* proto string remove

* raw snail

* fix

* Update FoodMetamorphableByAddingComponent.cs

* fixes

* fix3

* fififififx
2024-09-14 13:52:20 +01:00
Nemanja 2bf7941fef Biogenerator (#30694)
* biogenerator

* ack

* test success!

* fix tests

* increase price of reagents
2024-09-14 13:38:21 +01:00
LucasTheDrgn 4d2835a2d6 Returned functionality to industrial reagent grinders (#31903)
* Returned functionality to industrial reagent grinders without un-nerfing recyclers

* Limited industrial reagent grinder to only extractable solutions
2024-09-14 13:38:15 +01:00
Ilya246 7ae4736f1d fix flammable reagents deigniting you (#31930)
fix
2024-09-14 13:38:15 +01:00
deltanedas 8b1d674100
give fugitives a copy of their warrant (#1797)
Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-09-12 13:30:42 +00:00
deltanedas 845d5841d0
add glimmer/psionic artifact stuff (#1785)
* add TryMakePsionic

* refactor psionic abilities file, add PsionicPowerDetectedEvent

* add glimmer/psionic artifact code

* add glimmer/psionic artifact triggers and effects

* pro

* o

* fix hint

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-09-12 01:25:59 +00:00
DisposableCrewmember42 35f45522c6
fix: Borgs can no longer sacrifice their equipment to the Oracle (#1769)
fixes #1742
2024-09-11 12:17:05 +00:00
deltanedas c93551dad7
upstream merge 7/9 (#1762)
* Remove always false checks (#31708)

* Remove calls to FormattedMessage obsolete methods (#31706)

* Remove FormattedMessage obsolete methods

* Oops

* remove misinformation from tip 26 (#31705)

tip 26

* Automatic changelog update

* Replace obsolete code in AnomalySystem.Generator.cs (#31718)

* replace obsolete

* weh

* Added cursor indicator for space dragon fire breath ability (#31725)

space dragon breath cursor indicator

Co-authored-by: YourUsername <you@example.com>

* Automatic changelog update

* small yml cleanup (#31720)

* Updates descriptions of station specific jobs. (#31713)

done

* Remove unused IoC dependency references. (#31704)

Remove unused IoC dependencies

* cleanup filing cabinets yml (#31211)

* partmedia ahh kommit

* ahh

* everything should be fine now

* f

* now should be good

* Update Resources/Prototypes/Entities/Structures/Storage/filing_cabinets.yml

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* fix suffix

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Move IgnitionEvent to shared (#30985)

* Cleanup railings yml (#31618)

* Cleanup railings

* fix line

* real fix

* Roundstart Grappling Gun (#31737)

Roundstart grappling hook

* Automatic changelog update

* Added in-hand sprite for Smile the Slime (#31731)

added smile the slime in-hand texture

Co-authored-by: YourUsername <you@example.com>

* Lite Magnet Rebalancing (#31726)

magnet rebalancing ish

* unnerf fishops

* Devmap crew monitor fix (#31677)

* Automatic changelog update

* Add ERT time stats (#31629)

* add jobs for ghost roles

* add job to ToggleableGhostRole

* typo

---------

Co-authored-by: Mota <belochuc@gmail.com>

* Automatic changelog update

* Fix CS0642 - Possible mistaken empty statement (#31740)

* Throw the book at em! The space law book now does 1 blunt projectile damage (#31387)

* you can now throw the space law book for 1 blunt damage

* made book damage a feature of all books

* Replace instances of SolutionContainerSystem with SharedSolutionContainerSystem (#30084)

* Replace instances of SolutionContainerSystem with SharedSolutionContainerSystem

* guap

* More fixes

* Wait you can do that?

---------

Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>

* Add Donk Co. microwave board to Combat Bakery Kit (#31239)

* Add special microwave board to Combat Bakery Kit

* use event instead of trycomp

* make the board sus

* add instructions note

* embarrassing typo

* Add functionality to Donk Co. microwave instead

* update note

* Automatic changelog update

* Actions bar dynamic resizing (#31759)

* action bar dynamic resizing

* action bar dynamic resizing for separated style

* decreased indent for separated style

---------

Co-authored-by: YourUsername <you@example.com>

* Automatic changelog update

* Fix warnings related to non-exhaustive pattern matching.  (#31763)

old man shakes fist at modern syntax

* ats update (#31766)

* ats update

* fix pipenet

* Ninja throwing star ability fix (#31684)

fixed ninja star not spawning

Co-authored-by: YourUsername <you@example.com>

* Automatic changelog update

* Remove duplicate using from FoodSystem (#31769)

* vox voices revamp (#31679)

vox voices v2

* fixed broken pipe sprites (#31773)

* Return Long2 and Long3 hairstyles  (#30963)

* Sprites

* Prototype_&_Locale

* sorted_in_alphabetical_order

* Automatic changelog update

* Added many old ion lawsets for borgs and AI. (#31664)

* Added the Commandments, Paladin, LetLive, Station Efficiency, Robocop, Overlord, Dungeon Master, Artist, Antimov and Nutimov lawsets/

* Wording

* Anti-Antimov

* Fixed fun

* Add Snails (#30765)

* add snails

* scuffix

* migrate

* mo-grate

* oopsied the ftls

* Revert "oopsied the ftls"

This reverts commit 0d3c6c17f31ec904679d6a48799cea71e77c1f99.

* the curse of staging the wrong file, resolved.

* Snoth

* fix my dumbs

* reviews 1

* anti space technology

* salt hurty

* spelling

* Its a slotherhouse out here

* sequencing

* cooked snail

* volfix

* speed reversal

* Automatic changelog update

* Remove testbed command (#31793)

* feat: now when research is unlocked in console, approver of reasearch is radio-ed too (#31170)

* feat: now when research is unlocked in console, approver of reasearch is radio-ed too

* refactor: now most of events that require actor name to be radio-ed or logged use TryGetIdentityShortInfoEvent which is subscibed by id-card system and borg system (to work for both carbon and synthetic life-forms)

* refactor: moved TryGetIdentityShortInfoEvent on id card system to shared, fixed cargo cent-com-originated orders

* remove unused check

* refactor: decoupled systems from IdCardSystem (those that are not dependent on it anymore)

* refactor: removed unuseed usings

* feat: emagged cargo/research consoles wont radio messages on buy/research confirm anymore

---------

Co-authored-by: pa.pecherskij <pa.pecherskij@interfax.ru>

* Automatic changelog update

* New chemical based artifact nodes (#30873)

* Initial pH nodes, and description changes to indicate pH

* Psychoactive and stimulant nodes, Medical foundation, bioreactive hint

* Added medical reagents to medical node. Added norepinephric acid to acidic and made up a pH

* Added pyrotechnic chem node, and corresponding hint

* spelled psychedelic correctly

* Fixed capitalisation skill issue

* fixed indentation skill issue

* fixed a further indentation skill issue

* Removed extraneous whitespace

* Replaced bioreactive with theraputic and psychoactive. Also fixed typo skill issue.

* removed unnecessary comment

* Replaced heartbreaker with THC for psychadelic

* removed artifexium from acidic

* added tran acid to acidic

* added more medical chems

* removed pH values

* removed all but medical

* Automatic changelog update

* Add Red Neck Gaiter To Secdrobe (#30106)

* Red Neck Gaiter Added to SecDrobe

* Removes Gaiter From TheaterDrobe

* Automatic changelog update

* Fixed typos (#31811)

* Automatic changelog update

* Station AI has their name displayed in announcements now. (#31802)

* Station AI has their name displayed in announcements now.

* I'm so sorry

* Corrections

* part 2

* part 3 :|

* part 4

* Whitespace

* Fixing whitespace part 1

* No more whitespace

* PLEASE NO MORE WHITESPACE

* Automatic changelog update

* Add disabled station anchors version (#31794)

* Add disabled station anchors versions

* remove this

* add structural damage taken to a lot of prototypes (#30790)

* fix

* add structural damage taken to a lot of other things

* do requested changes

* how did this happen

* Automatic changelog update

* No Mr.Snail, I expect you to die! (fix sprite) (#31834)

* No Mr.Snail, I expect you to die!

* emoting

* Allow some mobs to walk slowly (#31360)

* Allow mice to walk slowly

* add more

* Automatic changelog update

* Delete nonsense solar assembly construction through the Construction window (#31425)

* Delete construction for solar assembly, it's the way to do it

* Fix description of solar tracker electronics

* Improvements to hand labeler UI (#31833)

Give line edit focus when window is opened
No longer require pressing enter to set the text
Give feedback when user hits the maximum label length

Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es>

* make tesla brighter (#31357)

* make tesla brighter

* radius to 10

* Automatic changelog update

* CorrectContraband levels on each type of magboots (#30960)

* Added a ClothingShoesBootsMagBase, to allow the other versions of the magboots to have their own contraband settings

* Changed Science Boots to not be contraband

* Made ClothingShoesBootsMagBase abstract

* Removed Engineering Contraband from base magboots. Now only the CE's Advanced Magboots are contraband (Grand Theft Contraband). Blood Reds are Syndie Contraband.

* Automatic changelog update

* Morgue system refactor remove unused VVs and into Entity (#31835)

* Remove unused VVs params and usings
from entityUid, MorgueComponent into Entity<MorgueComponent> ent

* remove unnecesary VVs cuz datafields add em

* Make midround zombie outbreaks much rarer (#30266)

* Remove midround zombies

* super rare, like, 1/651 chance every few minutes.

* weight to 1

---------

Co-authored-by: Ubaser <134914314+UbaserB@users.noreply.github.com>

* Automatic changelog update

* Teleporting while pulling crash fix (#31787)

teleporting while pulling crash fix

Co-authored-by: YourUsername <you@example.com>

* Automatic changelog update

* quietify stealthbox (#30741)

* Automatic changelog update

* Atmospheric alerts computer (#25938)

* Atmospheric alerts computer

* Moved components, restricted access to them

* Minor tweaks

* The screen will now turn off when the computer is not powered

* Bug fix

* Adjusted label

* Updated to latest master version

* Automatic changelog update

* Day 0 bug fix for atmos alerts computer (#31858)

Initial commit

* Basically every electronic device can now be used by the AI. (#31730)

* Basically every electronic device can now be used by the AI.

* Removed stuff that didnt make sense

* oops

* Removed access from mailing and disposal units.

* Added AI wires to a couple machines.

* cool epic stuff

* Automatic changelog update

* Fix a typo in the 10 commandments (#31856)

* feat: #26107 uplink discounts for traitors (no nukies for now) (#26297)

* feat: #26107 uplink discounts for traitors and nukies

* refactor: #26107 extracted discount label from price of StoreListingControl

* refactor: minor renaming

* refactor: parametrized adding discounts to uplink store

* fix: #26107 prevent exception on empty discountOptions

* feat: uplink now have 'Discounted' category which contains all discounted items on this session.

* after merge fixups

* rename discount categories according to common sense

* refactor: DiscountOptions is now optional (nullable) on ListingData

* add nullability check ignore for already checked listingData.DiscountOptions

* fix after merge store menu ui

* remove unused using

* final fix after merge conflicts

* [refactor]: #26107 fix variables naming in UplinkSystem

* fix: #26107 fix after merge

* refactor: #26107 now supports discountDownUntil on ListingItem, instead of % of discount

* feat: #26107 support multiple currency discount in store on side of discount message label

* refactor: #26107 extracted discounts initialization to separate system. StoreDiscountData are spread as array and not list now

* refactor: #26107 move more code from storesystem to StoreDiscountComponent

* refactor: #26107 separated StoreSystem and StoreDiscountSystem using events

* fix: #26107 placed not-nullable variable initialization in ListingData for tests

* refactor: #26107 minor renaming, xml-docs

* fix: #26107 changed most of discounts to be down to half price for balance purposes

* ids used in with discounts are now ProtoIds, dicountCategories are now prototypes, code with weights simplified

* decoupled storesystem and store discount system

* xml-docs

* refactor:  #26107 xml-doc for StoreDiscountSystem

* is now a thing (tmp)

* fix: compilation errors + StoreDiscountData.DiscountCategoryId

* refactor: rename ListingDataWithCostModifiers, fix all cost related code, enpittyfy performance, uglify uplink_catalog

* refactor: removed unused code, more StoreDiscountSystem docs, simplify code

* refactor: moved discount category logic to respective system, now creating ListingData c-tor clones all mutable fields as expected

* refactor: rename back (its not prototype)

* refactor: move ListingItemsInitializingEvent to file with handling logic

* refactor: comments for StoreBuyFinishedEvent handling, more logging

* refactor: moved StoreInitializedEvent, xml-doc

* refactor: simplify StoreDiscountSystem code  (reduce nesting) + xml-doc

* refactor: restore old listing data cost field name

* refactor: fix linter in uplink_catalog.yml

* refactor: xml-doc for ListingDataWithCostModifiers

* refactor: limit usage of ListingData in favour of ListingDataWithCostModifiers

* refactor: purged linq, removed custom datafield names, minor cleanup

* refactor: removed double-allocation on getting available listings

* refactor: StoreSystem.OnBuyRequest now uses component.FullListingsCatalog as reference point (as it was in original code)

* fix: minor discount categories on uplink items changes following design overview

* refactor: StoreBuyListingMessage now uses protoId and not whole object

* refactor: store refund and discount integration test, RefreshAllListings now translates previous cost modifiers to refreshed list, if state previous to refresh had any listing items

---------

Co-authored-by: pa.pecherskij <pa.pecherskij@interfax.ru>

* Automatic changelog update

* Fixed AI Actions (#31823)

* Updated sprites for AI HUD

* Epic test fail

* Merged AGhost actions and AI actions together again.

* Seperate comms and bugfix. Fixed broadcast.

* Automatic changelog update

* add wireless net to evac shuttles

* Automatic changelog update

* A kit to help new botanists discover chemistry (#31738)

* Add a kit for botanists to do some limited chemistry to the NutriMax. Intended to help new botanists learn in-game about chemistry.

* remove exclamation marks from names

* naming fix

* Rejected trademark application for 'Farmers Helper'.

---------

Co-authored-by: PraxisMapper <praxismapper@gmail.com>

* Automatic changelog update

* Board for the AI upload console (#31867)

board

* Automatic changelog update

* Fix typo in agri-chem manual (#31869)

* Fix typo in agri-chem manual

* Unremove my added newline

* Cleanup books.yml (#31838)

* Cleanup books.yml

* yeah

* shame

* Vox sign/N2 locker update (#31845)

* Vox sign/N2 locker update

The "vox area" sign and N2 locker sprite were both taken from /vg/station. These sprites have bad racist connotations as discussed in https://github.com/space-wizards/space-station-14/issues/31840, and do not fit our server culture.

The new N2 locker is not a taped on piece of trash. It now also has a blue stripe to mimic the regular O2 locker and make it more distinct from fire safety closets.

The new "vox area" sign sprite follows the same style as other "area indicator" signs used throughout the blue and isn't an explicit warning sign anymore. It still has "No O2" on it to fill that role though.

* emogarbage adjustments

---------

Co-authored-by: EmoGarbage404 <retron404@gmail.com>

* Automatic changelog update

* Pizza boxes now have a chance to contain cotton pizza (#31883)

Pizza box now contains cotton pizza

Co-authored-by: Ekkosangen <9094006+XyyxShard@users.noreply.github.com>

* Automatic changelog update

* Tech Anomaly (#31764)

* A

* B

* C

* D

* Update TechAnomalySystem.cs

* idle anim

* Update meta.json

* new animation

* Automatic changelog update

* Fixed throngler name inconsistencies (#31889)

changed throngler names

* I have spent more time today cleaning up garbage than coding new shit, and I am mad (#31246)

* Fix logging of GetWebhook errors

Yeah let's just not log the error only stack trace.

* I have spent more time today cleaning up garbage than coding new shit, and I am mad

Cleans up the custom vote Discord webhook code because I *happened* to lay my eyes on how completely terrible it was and immediately found an obvious bug with it.

Also did basic QA because jesus christ: it more clearly reports pending votes, properly indicates cancelled votes, improves footer formatting, better error logging, all the usual shit.

Requires https://github.com/space-wizards/RobustToolbox/pull/5375 to avoid test failures

* Mineral Scanner (#31390)

* Mineral Scanner

* doink

* review

* sunday funday

* review and fix bugs i think?

* Update MiningOverlay.cs

* Automatic changelog update

* Fix ai upload console itemslot whitelist (#31900)

* Fix ai upload console itemslot whitelist

* aw man

* Automatic changelog update

* improved vox laugh (#31798)

vox laugh not underwater

* fix pump shotgun wielded sprite (#31885)

* fix shotgun sprite

* fix take 2

* fix: Snail event wasnt tabled (#31884)

pest events reorganized and snails spawn

* Automatic changelog update

* Force stop pulling when fall asleep (#31893)

* break pull at sleep

* TryStopPull without user

---------

Co-authored-by: YourUsername <you@example.com>

* Automatic changelog update

* Energy Shotgun Change 2 - Narrow Nerf + instances from NoSpawn --> categories: [ HideSpawnMenu ] + self recharge removed + 1 more shot + normal recharge speed (#31235)

* narrow nerf

* last instance of nospawn gone

* removes self recharge

* 8 shots, less recharge time

* Automatic changelog update

* Add justice helm (#31905)

* Add justice helm

* backslash moment

* spinny light

* remove power cell from recipe

* Automatic changelog update

* Quiver Crafting Recipe (#27198)

* Update quiver.yml

* Create quiver.yml

* Update clothing.yml

* Update pneumatic_cannon.yml

* Update pneumatic_cannon.yml

* Update pneumatic_cannon.yml

* Update pneumatic_cannon.yml

* Delete RDs binary encryption key (#31909)

Deleting binary key

Silicon supremacy!

* undelete rd key

* Automatic changelog update

* split temperature protection into heating and cooling (#30662)

* split temperature protection into heating and cooling

* fugg

* weh

* update TemperatureProtection for stuff

* Automatic changelog update

* makes the maple wing marking have a primary and a secondary color (#31691)

bogos binted

* Automatic changelog update

* Remake bottles and syringes names to use labels (#29956)

* Remake bottles and syringes names to use labels

* vial

* fix and add stuff

* Automatic changelog update

* guide on agrichem and botanicals guidebook update (#31896)

* Automatic changelog update

* Automatic changelog update

* Lost evac pod thing tiny fan (#31915)

* disaster evacpod tinyfan

* real

* :trollface:

* untroll

* Ghostrole rule updates (#29249)

* First batch of ghostrole rule updates

* Second pass

* Re-word free agent

* Apply review comments

Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>

* You heard it here first folks

God rules are weird to write.

Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>

* Honkbot -> Free Agent

Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>

* Mimebot -> Free Agent

Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>

* Jonkbot -> Free Agent

Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>

* Softer blue

---------

Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>

* :trollface:

* :trollface:

* :trollface:

* pro

---------

Co-authored-by: Winkarst <74284083+Winkarst-cpu@users.noreply.github.com>
Co-authored-by: Ilya246 <57039557+Ilya246@users.noreply.github.com>
Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com>
Co-authored-by: Errant <35878406+Errant-4@users.noreply.github.com>
Co-authored-by: godisdeadLOL <169250097+godisdeadLOL@users.noreply.github.com>
Co-authored-by: YourUsername <you@example.com>
Co-authored-by: lzk <124214523+lzk228@users.noreply.github.com>
Co-authored-by: Boaz1111 <149967078+Boaz1111@users.noreply.github.com>
Co-authored-by: Mervill <mervills.email@gmail.com>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
Co-authored-by: DrSmugleaf <10968691+DrSmugleaf@users.noreply.github.com>
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
Co-authored-by: deltanedas <@deltanedas:kde.org>
Co-authored-by: poeMota <142114334+poeMota@users.noreply.github.com>
Co-authored-by: Mota <belochuc@gmail.com>
Co-authored-by: Moomoobeef <62638182+Moomoobeef@users.noreply.github.com>
Co-authored-by: Cojoke <83733158+Cojoke-dot@users.noreply.github.com>
Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>
Co-authored-by: themias <89101928+themias@users.noreply.github.com>
Co-authored-by: Emisse <99158783+Emisse@users.noreply.github.com>
Co-authored-by: Арт <123451459+JustArt1m@users.noreply.github.com>
Co-authored-by: ScarKy0 <106310278+ScarKy0@users.noreply.github.com>
Co-authored-by: IProduceWidgets <107586145+IProduceWidgets@users.noreply.github.com>
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: Fildrance <fildrance@gmail.com>
Co-authored-by: pa.pecherskij <pa.pecherskij@interfax.ru>
Co-authored-by: Lye <128915833+Lyroth001@users.noreply.github.com>
Co-authored-by: DieselMohawk <gavin.drinka@gmail.com>
Co-authored-by: Hreno <hrenor@gmail.com>
Co-authored-by: eoineoineoin <github@eoinrul.es>
Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es>
Co-authored-by: qwerltaz <69696513+qwerltaz@users.noreply.github.com>
Co-authored-by: Ty Ashley <42426760+TyAshley@users.noreply.github.com>
Co-authored-by: Token <esil.bektay@yandex.com>
Co-authored-by: Alzore <140123969+Blackern5000@users.noreply.github.com>
Co-authored-by: Ubaser <134914314+UbaserB@users.noreply.github.com>
Co-authored-by: chromiumboy <50505512+chromiumboy@users.noreply.github.com>
Co-authored-by: Psychpsyo <60073468+Psychpsyo@users.noreply.github.com>
Co-authored-by: drakewill-CRL <46307022+drakewill-CRL@users.noreply.github.com>
Co-authored-by: PraxisMapper <praxismapper@gmail.com>
Co-authored-by: Nim <128169402+Nimfar11@users.noreply.github.com>
Co-authored-by: Perry Fraser <perryprog@users.noreply.github.com>
Co-authored-by: EmoGarbage404 <retron404@gmail.com>
Co-authored-by: Ekkosangen <9094006+Ekkosangen@users.noreply.github.com>
Co-authored-by: Ekkosangen <9094006+XyyxShard@users.noreply.github.com>
Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com>
Co-authored-by: Chubbicous <100180479+Chubbicous@users.noreply.github.com>
Co-authored-by: Ps3Moira <113228053+ps3moira@users.noreply.github.com>
Co-authored-by: FungiFellow <151778459+FungiFellow@users.noreply.github.com>
Co-authored-by: Futuristic-OK <141568243+Futuristic-OK@users.noreply.github.com>
Co-authored-by: Ian <ignaz.k@live.de>
Co-authored-by: TsjipTsjip <19798667+TsjipTsjip@users.noreply.github.com>
Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>
2024-09-10 01:20:38 +10:00
Stop-Signs 33a2d120f2
Butlertron Rebalance (#1771)
* Update RoboisseurComponent.cs

Signed-off-by: Stop-Signs <stopsign221@gmail.com>

* Update RoboisseurSystem.cs

Signed-off-by: Stop-Signs <stopsign221@gmail.com>

---------

Signed-off-by: Stop-Signs <stopsign221@gmail.com>
2024-09-08 01:33:03 -03:00
portfiend 690cbe995a
Rodentia Species (#1511)
* add: basic rodent species

* add: rodentia base sprites

* add: basic rodent hand/foot markings

* add: ears i got em

* add: tail markings

* add: big ears

by request

* tweak: default markings, coloration

everything uses skin color by default when added except for these new "default" markings which use tattoo

* add: the rest of the basic body part markings

* add: snout textures

* add: pattern markings

* add: cheek detail

* add: sex variations for chest marking

* add: give rodentia the generic markings

* add: rodentia names

* add: damage, voice, mass, emotes to rodentia

* add: rummager ability for rodentia

* remove: temperature protection from rodentia

* add: some makeup markings for rodentia

* add: include rodentia in misc pools

* add: rodentia guidebook entries

* tweak: adjust rodentia marking points

* add: rodentia pie sprite

* tweak desc

* tweak: change rodentia name scheme

* tweak: adjust damage modifiers for rodentia

* add: rodentia always trigger mouse traps

* tweak: rodentia have unique speech verbs

* tweak: change rodentia inventory shape

* tweak: rodentia take more phys dmg overall

* tweak: made rodentia hungry

* add: mouth storage component on rodents

* add: server mouthstoragesystem

* add: force-dump mouth storage on trip

hmm the networking on this is a little ehh. but watever

* add: rodentia drop mouth items on damage

* add: blocked interactions if mouth is full

* fix: corrected accent oops

* tweak: tense

* fuck this import in particular

* tweak: spit damage threshold

* fix: no redundant open actions

* refactor: move this action into the types file

* add: rodentia get ability to hide under tables etc.

* tweak: change rodentia action icons

* refactor: im renaming this component and system lol

* refactor: rename this event too

i was gonna refactor the whole system to be more like climbing, but the climbing system is convoluted so im just gonna do this and put it aside

* tweak: fix the mouth storage icon
the number covers it

* tweak: check if colliding with table before un-sneaking

* fix: crawl action cooldown and popup text

* add: slowdown to sneak ability

* refactor: fix this namespace

* tweak: rummageable objects now use a cooldown

* fix: newlines

* Apply suggestions from code review

Co-authored-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com>
Signed-off-by: portfiend <109661617+portfiend@users.noreply.github.com>

* Apply suggestions from code review

Co-authored-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com>
Signed-off-by: portfiend <109661617+portfiend@users.noreply.github.com>

* fix: collision group variavbles

* add: proper "full body" sprite

* add: move blaze to head folder, "round face" marking

* add: whisker markings

* tweal: rodentia are 50% -> 33% hungrier

1.5x seemed excessive

* refactor(mouthStorage): move OnExamined from server to shared

* refactor(mousetrap): use HasComp

* refactor(mouthStorage): use a public api instead of event here

* refactor(yml): KILL REPETITION

* refactor(parts/rodentia): KILL REPETITION

---------

Signed-off-by: portfiend <109661617+portfiend@users.noreply.github.com>
Co-authored-by: DEATHB4DEFEAT <77995199+DEATHB4DEFEAT@users.noreply.github.com>
2024-09-07 23:04:34 -03:00
Adeinitas 952f368c05
Frontier Mail (#1652)
* Does all the under the hood changes to mail components before I EVEN start thinking about MailSystem

* Mail Handheld Rapid Parcel Delivery System (#974)

* Mail RPDS

* removed sizes, more items go in capsules

* fixed error

* capsule resprite, added it to service techfab

* Update after upstream merge

* glass

* Update frontier.yml

* tag fix

---------

Co-authored-by: Dvir <dvirf01@gmail.com>

* Mail Buff (#1473)

* MailUp

* Update base_mail.yml

* Update base_mail.yml

* Update MailTeleporterComponent.cs

* Update MailComponent.cs

* Update base_mail.yml

* Update base_mail.yml

* Update Resources/Prototypes/Nyanotrasen/Entities/Objects/Specific/Mail/base_mail.yml

Sure

Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com>

---------

Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com>

* Mail table rework (#1477)

* Mail table, system for smoke prank

* Format mail messages

* DelayedItemSystem cleanup, more mail table entries

* More mail table entries

* Remove hoverbike from mail pool

* Add large mail.

FIXME: mail_large.rsi has no copyright info

* Default mail isLarge to false, comment cleanup

* More mail types

* Add optional large mail flag to admin mailto cmd

* mail_large copyright

* admin cmd fix, new mail types, const cleanup

* Mail: new components, weighting, a few new items

* Fix merge conflict, add placeholder pipebomb mail

* Format mail text, separate sword mail from knives

* Mail: fix exp. welder ID, split up Dan's cigs

* Fourth muffin, decrease captain's sabre chance

* yaml fixes

* Add ShowJobIcons component to mail hud

* Reorganize mail items, add build-a-buddy mail

* Build-a-Buddy fixes, slime & vulp versions, text

* Reptillian->Reptilian

* More signatures, label necrosol bottle, bigger emp

* lowercase i

* extra premium cigars, premium liquors

* Cleanup

* Fixups And Edits

* Remove kendo hakama, jabroni comment, fix cigars

* Platinum cigars, fix sprites

* fix premium absinthe ID

* Remove cyberpen, add BibleUserImplanter, ATV mail

Also adjusts weights for TacticalMaid (missing a zero), Restraints (cut
in half)

* kendo mail order, more mail comments

* Remove Nyano mail lists & parcels, move into _NF/

* True to true, cigars aren't fragile

---------

Co-authored-by: Dvir <dvirf01@gmail.com>
Co-authored-by: Whatstone <whatstone3@gmail.com>

* Kills accidentally cherrypicked platinum cig, makes mail be sorted into 5 ymls again

* THE MAIL TABLE!!!!! AHHHHHHHHHHHHHHHHHHHH

* NUKES two UNNECCESSARY RANDOMLY PASTED BRACKETS

FUCK YOU BUILD ERROR !!! EAT SHIT

* a semicolon for good measure

Adei versus the one silly

* Fuck is this? Why is it in my mail?

* Pro forgot values for two of the engineering mails

💀

* First pass to fix various mail bugs + editing of papers

* obliterates a random S in a C# file, also returns the mail teleporter to how it was

* Nukes the platinum cigar's YAML

Since there's no intent for it to spawn in the mail, might as well.

* Milon's Review

Does some shit to the mail / courierdrobe and gets rid of string keys. Thanks Milon

* Milon's Review 2, Electric Boogaloo

* Various YAML fixes as I try to satisfy the Linter and fail

* Fixes Mail.yml / If I get rid of the EMP china lake does it fix things? Let's find out!

* Cleans up more C# at Milon's behest

* TORTUGAAAAAAAAAAAAAAAAAAAA!!!!

Why is this mapped in?

* Revert "TORTUGAAAAAAAAAAAAAAAAAAAA!!!!"

This reverts commit b1d415a7be.

* Migrations

* Does a bit more fixing

* Update Resources/Locale/en-US/_NF/mail/mail.ftl

Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com>
Signed-off-by: Adeinitas <147965189+adeinitas@users.noreply.github.com>

* Update Resources/Locale/en-US/nyanotrasen/Mail/mail.ftl

Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com>
Signed-off-by: Adeinitas <147965189+adeinitas@users.noreply.github.com>

* Fixes Mail Capsule / Creates frontierMigrations

Blame Velcro for frontierMigrations.

* Update Resources/Migrations/deltaMigrations.yml

Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com>
Signed-off-by: Adeinitas <147965189+adeinitas@users.noreply.github.com>

* Rewords that one fucking comment I made 2 months ago about MIT / AGPL

* Just gives the delayed smoke prank and delayed EMP effects the instant effect sprites

* Where the fuck are these random curly braces from??

* An attempt to satisfy the Yaml Linter

* Revert "Update Resources/Locale/en-US/nyanotrasen/Mail/mail.ftl"

This reverts commit 0ee3869d76.

* Revert "Update Resources/Locale/en-US/_NF/mail/mail.ftl"

This reverts commit 29129df9d6.

* Mail FTL fixes / I think I know what the linter wants

* will this sprite be valid pretty please?

* Does a first pass on noSpawn for all mails.

ANOTHER COMMIT FOR THE PILE.

* Unfucks noSpawn from the mail prototypes

---------

Signed-off-by: Adeinitas <147965189+adeinitas@users.noreply.github.com>
Co-authored-by: ErhardSteinhauer <65374927+ErhardSteinhauer@users.noreply.github.com>
Co-authored-by: Dvir <dvirf01@gmail.com>
Co-authored-by: Dvir <39403717+dvir001@users.noreply.github.com>
Co-authored-by: Whatstone <166147148+whatston3@users.noreply.github.com>
Co-authored-by: Whatstone <whatstone3@gmail.com>
Co-authored-by: Danger Revolution! <142105406+DangerRevolution@users.noreply.github.com>
2024-09-02 13:14:05 +00:00
Adeinitas 14e6342e8e
Nukes AGPL headers (#1743)
* This is inconsistent why do we have these

* Commit name
2024-09-02 10:12:46 -03:00
deltanedas 6d0102f8d3 remove dupe melee execution code, fix 2024-09-01 04:36:08 +01:00
Pieter-Jan Briers e1eb8373f0 Quick warning fixes (#31694) 2024-09-01 03:56:15 +01:00
ShadowCommander 58a6e262fd Update StackSystem and add SpawnMultiple targeting EntityUid (#29686)
* Update StackSystem and add SpawnMultiple targeting EntityUid

* Update Content.Server/Stack/StackSystem.cs

* Update Content.Server/Stack/StackSystem.cs

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
2024-09-01 03:55:39 +01:00
PJBot cef683d525 Automatic changelog update 2024-09-01 03:44:38 +01:00
Moomoobeef 49512996c6 medical lockers no longer have belts in them. (#31470)
* fixes #31469

* removed medbelts from lockers. Empty belts found in vending machine now.
2024-09-01 03:44:13 +01:00
Julian Giebel 5f5a0d46be Station Anchor (#26098)
* Work on abstracting out chargeup functionality/ui from grav gen

* Work on station anchor

* Finish implementing station anchors

* uhh yeah

* ok.

* fix tests

* whoops

* Get the last extraneous yaml fail

* PJB review

* beast mode... ACTIVATE!

---------

Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com>
Co-authored-by: EmoGarbage404 <retron404@gmail.com>
2024-09-01 03:36:44 +01:00
nikthechampiongr c07660fd8a Allow for respawn and erase verb to be used on offline players. Also minor rewrite on respawn command and new erase command (#30433)
* Localize respawn command, allow for it to use userids, and make it use [Dependency] attributes

* Make respawn verb available for offline players

* Make erase available for offline players

A thousand admins rejoice

* Reorder verbs in code

* Add erase command

* Fix localisation for erase command

* Address reviews and add completion to respawn command

* Complete reviews which I forgor
2024-09-01 03:36:44 +01:00
nikthechampiongr 577c8292d9 Fix suicide logs (#31661)
Make suicide logs include the username, as well as the character(where possible)
2024-09-01 03:36:43 +01:00
metalgearsloth 39db9ebe5d Fix AI singulo shenanigans (#31556)
* weh

* Fix broken tests directly mutating entities from wrong thread.

* fix build

* gundam

* weher

* WHY

---------

Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>
2024-09-01 03:34:12 +01:00
SsalamethVersaach 303eae8f24
New Accents, Accent Weight Change + New Irish Accent Redux (From PR #1640 Thanks GitHub) (#1701)
* From the top! - Redid my branch...

* Cleanup with some comments and explanation

* Testing if Accentless is issue- failed build test

* Wasn't the bug-

* Changed accent weights based off int discussion

* uh, forgot comment change

* Changed comments a final time- reflect new weights

---------

Co-authored-by: Adeinitas <147965189+adeinitas@users.noreply.github.com>
2024-08-31 03:47:09 +00:00
Psychpsyo 175343453d Re-add improved random sentience event (#29123)
* Re-add improved random sentience event

* Make randomly sentient PDA more likely

* Make vending machine sentience less likely

* Make requested changes

* Make randomly sentient captain's gear more likely

* Sentient captain sabre has pirate accent

* Tweak new random sentient object a bit more

* Sentient PDA improvements

* Apply recommended fixes

* Add requested changes

* Fix merge conflict
2024-08-30 09:00:08 +01:00
deltanedas cfaffab421 fix lol 2024-08-30 08:57:33 +01:00
deltanedas b6cef70f5c update stuff 2024-08-30 08:36:14 +01:00
metalgearsloth 389a92a317 Fixup playerspawn stuff (#31546)
* Fixup playerspawn stuff

- Also removed arrivals forcing, this should just turn containerspawnpoint off.

* fix this one

* test fix

* really fix
2024-08-30 08:07:09 +01:00
osjarw 4478ab1a59 Air alarms check sensors upon power returning 2024-08-30 08:06:03 +01:00
themias 7a8d8d3a06 Fix nuke disk erroneously being marked 'left behind' (#31602)
Fix erroneous 'disk left behind' objective
2024-08-30 07:59:28 +01:00
lzk 52d9ad8d48 Remove random cyrillic letters (#31600) 2024-08-30 07:59:27 +01:00
PopGamer46 e2e0ab9827 Fixes shuttles not being able to FTL onto/near station (#31569)
fixes FTL
2024-08-30 07:56:23 +01:00
metalgearsloth ba6a843514 Fix whitelist (#31563) 2024-08-30 07:54:59 +01:00
metalgearsloth af6d5bddc0 Fix PostMapInit tests not considering job containerspawns (#31538)
* Fix PostMapInit tests nto considering job containerspawns

* fix
2024-08-30 07:53:59 +01:00
metalgearsloth d58bdd65ec Station AI (#30944)
* Station AI overlay

* implement

* Bunch of ports

* Fix a heap of bugs and basic scouting

* helldivers

* Shuffle interactions a bit

* navmap stuff

* Revert "navmap stuff"

This reverts commit d1f89dd4be83233e22cf5dd062b2581f3c6da062.

* AI wires implemented

* Fix examines

* Optimise the overlay significantly

* Back to old static

* BUI radial working

* lots of work

* Saving work

* thanks fork

* alright

* pc

* AI upload console

* AI upload

* stuff

* Fix copy-paste shitcode

* AI actions

* navmap work

* Fixes

* first impressions

* a

* reh

* Revert "navmap work"

This reverts commit 6f63fea6e9245e189f368f97be3e32e9b210580e.

* OD

* radar

* weh

* Fix examines

* scoop mine eyes

* fixes

* reh

* Optimise

* Final round of optimisations

* Fixes

* fixes
2024-08-30 07:53:19 +01:00
Simon f9f2549746 Automated whitelists (#23985)
* Beginnings of making the breadmemes jobs easier

* stuff

* stuff pt. 2

* Stuff pt.3

* Stuff I forgot last time

* Basic whitelist

Only people that are added to the whitelist with the addwhitelist command will be able to join. I call this the "legacy" whitelist

* Remove always deny condition in favor of just breaking if playtime check fails

* Change default whitelist

Default whitelist is now the "legacy" whitelist.

* localization

* Admin check

* minor spelling change

* Fix build

* Whitelist message

* Fix vars not being datafield and spelling mistakes

* Minor spelling mistake

* Change config for salamander

* Reviews and stuff

* Add summaries

* Fix whitelists

* Forgot to add a datafield

* Fixing stuff I guess

* Reuse admin remarks to reduce load when connecting.

* Update log messages to be verbose instead of debug

* Reviews

* whoops

* Explain a bit more how whitelist checking works

* Apply CE's review

* Append Membership to Blacklist and Whitelist conditions

* Fix review comments

* Uncapitalize playerConnectionWhitelist, add to ignored client prototypes

* Make note count field work

* Fix cvar for thingy

---------

Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>
2024-08-30 05:37:15 +01:00
Thomas 5d0ad84d8e Disable Arrivals message for Cryosleep (#30888)
* Disable arrivals message for cryosleep late arrivals

* Provide silent to PlayerSpawnCompleteEvent

* Fix typo

* Move message to event and into arrivals system
2024-08-30 05:35:45 +01:00
IProduceWidgets e18e19c897 Centcom & FTLDestination cleanup (#30226)
* centcomm name and ftlcomp

* networking microopstimization

* go sleep.

* map names and arrivals
2024-08-30 05:32:45 +01:00
deltanedas 6e29441a46 merge master 2024-08-28 03:20:44 +01:00
Nemanja db4e7cb567 Add space debris to salvage magnet (#31113)
* add space debris to salvage magnet

* multiplication

* necessary mercy for NPCs

* back and forth on mercy
2024-08-28 03:17:20 +01:00
deltanedas 7fd2541aee
job whitelists panel !!! (#1678)
* make JobPrototype.Whitelisted respect blanket whitelist, make jobs use it

* add jobwhitelists command and ui

* add job whitelist button to player panel

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-08-28 00:33:30 +00:00
deltanedas fef6ca80a3 :trollface: 2024-08-27 01:16:08 +01:00
Mervill c588096950 Replace obsolete functions in NPC systems (#31448) 2024-08-27 01:04:58 +01:00
Mervill 8d79b9aad6 Replace obsolete code in shuttle systems. (#31408)
* Format DockingSystem.Shuttle

* arrivals system

* docking system

* shuttle console system

* emergency shuttle system

* shuttle system

* thruster system

* Fix compile error

---------

Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>
2024-08-27 01:03:07 +01:00
Winkarst 7a33c10410 Move OnGhostAttempt to GhostSystem (#31445)
* Move OnGhostAttempt to GhostSystem

* Remove unused dependencies and sort them
2024-08-27 01:03:06 +01:00
metalgearsloth 17d4d701b3 Predict EmitSoundOnUIOpen (#31464)
* Predict EmitSoundOnUIOpen

BUI prediction led to this moment.

* unforky
2024-08-27 01:03:06 +01:00
Brandon Hu 356f7c360b fix(FieldGenerators): Don't show nonsense popup (#30469)
* .
2024-08-27 01:00:43 +01:00
Ed 4987111d59 Weather fix (#30857)
* weather fix

* localize errors
2024-08-27 01:00:43 +01:00
metalgearsloth 4cf95ff879 Action stuff (#31305)
* Action stuff

- Cleanup some event stuff
- Avoid dirtying entity unnecessarily
- Add ActionGrant as an easy way to apply / remove actions via compregistry.

* Fix merge
2024-08-27 01:00:43 +01:00
metalgearsloth f8b8ec7994 Power stuff (#31314)
* Power stuff

- Add shared IsPowered
- Add shared ResolveApc
- Move PowerChangedEvent to shared for now
- Add SlimPoweredLight that actually functions how you'd expect a PoweredLight to function it id didn't have a bunch of bloat on it.

* big update

* boing
2024-08-27 01:00:42 +01:00
deltanedas 27274a9df4 decouple ItemToggle from PowerCellDraw (#31392)
* remove ItemToggle from PowerCellDraw query

* add EntityQuery for resolves, make them all optional

* move integration to ToggleCellDraw

* add ToggleCellDraw to almost every PowerCellDraw prototype

* :trollface:

* :trollface:

* :trollface:

* let it disable on mapinit

* set update time on mapinit, make borg power logic consistent now

* :trollface:

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-08-27 01:00:14 +01:00
Nemanja 677d3a00ef Blueprints (#31138)
* Blueprints

* Update tables_loot.yml

* doink

* mark as required
2024-08-27 01:00:13 +01:00
metalgearsloth 3a2e9badc6 Fix dungeon spawn + ftl overlap (#31413)
* Fix dungeon spawn + ftl overlap

* Better fixes
2024-08-27 00:50:40 +01:00
eoineoineoin 6d014c29b0 Remove client state from server AirAlarmComponent (#31236)
* Remove client state from server AirAlarmComponent

Send information for all connected devices, not just the ones for the
current tab, as attempting to limit this breaks multiple users viewing
the same UI.

Fixes #12842

* Send device data as a list, rather than a dictionary

---------

Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es>
2024-08-27 00:50:40 +01:00
PursuitInAshes bd0c80e2ee Change `Resave` Permission Requirement to Host (#31397)
ChangePermissionFlagToHost
2024-08-27 00:50:40 +01:00
deltanedas 4effb1df45 Add Vox atmosphere marker, vents, and air alarms 2024-08-27 00:48:33 +01:00
deltanedas 09d5fe3f9f Make component fields datafields 2024-08-27 00:48:33 +01:00
deltanedas 1ab7a31bf9 Revert "add atmos stuff for mapping vox boxes (#1668)"
This reverts commit 6dc5ff7720.
2024-08-27 00:47:20 +01:00
Nemanja 4e16a3eac2 Mining Rebalance (#30920)
* first pass

* this shit too

* ok fix that shit

* buff

* actually fix that
2024-08-27 00:45:07 +01:00
Nemanja 5cdfbe5ab2 add new salv loot into the vgroid procgen (#31290)
add new loot into vgroid procgen
2024-08-27 00:43:25 +01:00
SlamBamActionman 81ceabba13 Add codeword highlighting (#30092)
* Added codeword highlighting

* Updated to support more codeword roles, color is set serverside

* Review feedback

* Change to a Component-based system using SessionSpecific

* Tidied up CanGetState, set Access restrictions on component

* Clean-up

* Makes the injection ignore brackets, restore some codewords, remove "Taste/Touch" from adjectives
2024-08-27 00:42:12 +01:00
Ed 248af8f15d fix Gatherable magic number (#31327)
Update GatherableSystem.cs
2024-08-27 00:40:13 +01:00
Mervill 67bc3aaef3 Remove obsolete functions from tile commands. (#31112)
* first part

* second part - file scope namespaces

* missing peice
2024-08-27 00:40:02 +01:00
Nemanja 652ce96239 Move mining roid and magnet pulls closer (#31296)
move mining roid and magnet pulls closer
2024-08-27 00:38:07 +01:00
Mervill d2f733ae93 Remove some wayward folder includes in the `csproj` (#31244)
remove some wayward folder inlcudes
2024-08-27 00:37:51 +01:00
Sigil 7b30347b20 Fixes the projectile list in AmmoShotEvent when firing something with a ProjectileSpreadComponent (#31300)
Fixed multiple projectile addition.
2024-08-27 00:34:13 +01:00
metalgearsloth 87f85cf778 Predict IntrinsicUI (#31310) 2024-08-27 00:34:13 +01:00
Nemanja 3b1e65c656 fix and buff the handheld mass scanner (#31284) 2024-08-27 00:30:54 +01:00
deltanedas 6dc5ff7720
add atmos stuff for mapping vox boxes (#1668)
* add 101kpa nitrogen fixgridatmos marker

* make a lot of things datafields so they save and can be set in yml

* add vox box scrubber/filter/sensor/alarm

* move some stuff to deltav folder, add deltav comments to the fixgridatmos mixture

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-08-22 20:14:35 +00:00
deltanedas d4e3c531c3
use old meteor entity (#1658)
* add old meteor entity

* spawn old meteor entity in rule

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-08-22 14:29:18 +00:00
Leon Friedrich 12a64769f7 Fix flatpacker (#28736)
* Fix flatpacker

* a
2024-08-22 13:41:09 +01:00
Mervill 3926ee6f3a Replace obsolete map function in AtmosphereSystem (#31252) 2024-08-21 16:16:51 +01:00
Pieter-Jan Briers 9cdf9b0d70 Don't create new JsonSerializerOptions for every discord webhook (#31240)
*sigh*
2024-08-21 16:16:41 +01:00
Julian Giebel 0ba5b81a6a Kick on ban for entire server group (#28649)
* Start work on PostgresNotificationManager
Implement initial version of init and listening code

* Finish implementing PostgresNotificationManager
Implement ban insert trigger

* Implement ignoring notifications if the ban was from the same server

* Address reviews

* Fixes and refactorings

Fix typo in migration SQL

Pull new code in BanManager out into its own partial file.

Unify logic to kick somebody with that when a new ban is placed directly on the server.

New bans are now checked against all parameters (IP, HWID) instead of just user ID.

Extracted SQLite ban matching code into a new class so that it can mostly be re-used by the ban notification code. No copy-paste here.

Database notifications are now not implicitly sent to the main thread, this means basic checks will happen in the thread pool beforehand.

Bans without user ID are now sent to servers. Bans are rate limited to avoid undue work from mass ban imports, beyond the rate limit they are dropped.

Improved error handling and logging for the whole system.

Matching bans against connected players requires knowing their ban exemption flags. These are now cached when the player connects.

ServerBanDef now has exemption flags, again to allow matching full ban details for ban notifications.

Made database notifications a proper struct type to reduce copy pasting a tuple.

Remove copy pasted connection string building code by just... passing the string into the constructor.

Add lock around _notificationHandlers just in case.

Fixed postgres connection wait not being called in a loop and therefore spamming LISTEN commands for every received notification.

Added more error handling and logging to notification listener.

Removed some copy pasting from SQLite database layer too while I was at it because god forbid we expect anybody else to do all the work in this project.

Sorry Julian

---------

Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>
2024-08-21 16:16:41 +01:00
Jacob b7ddee3b64 Add failure logging to DiscordWebhook.cs (#30835)
* Add failure logging to DiscordWebhook.cs

Add a new function that logs errors with discord webhook's http requests.

Create, Delete, and Edit functions were modified slightly to call the log function but return the same information as before.

The log function logs the error code, caller method using a simple constant (could be better), and attempts to log headers mentioned in issue #30248.

* remove extra ';'

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>

* Move header error logs to debug

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: Pieter-Jan Briers <pieterjan.briers+git@gmail.com>
2024-08-21 16:16:41 +01:00
Brandon Hu d7c4e2b1d7 fix(SpecialRespawn): Check if prototype exists before attemping to respawn it (#31140)
* Co-Authored-By: deltanedas <deltanedas@users.noreply.github.com>

* _

* They're playing basketball

Co-authored-by: deltanedas <@deltanedas:kde.org>

* They're playing basketball

Co-authored-by: deltanedas <deltanedas@users.noreply.github.com>

---------

Co-authored-by: deltanedas <deltanedas@users.noreply.github.com>
2024-08-21 16:16:13 +01:00
metalgearsloth d0bccb8653 Bandaid wire sounds (#31067)
Issue was tools was predicted but wires aren't so this would exclude user from audio.

For now we just do the non-predicted version and I or someone else will fully predict wires later.
2024-08-21 16:15:50 +01:00
tosatur 599b61a032 added a few chatsan entries (#31085)
* added a few chatsan entries

* added 2 more

* added 4 more and fixed errors

* fixed error again

* added allg

* removed fullstops
2024-08-21 16:02:05 +01:00
Cojoke 07907dd9ae Fix Pacified Damage Dealing Thrown Objects (#31183) 2024-08-21 16:02:05 +01:00
Nemanja 35923b6994 Recycler Overhaul (#30802)
* Recycler overhaul

* remove
2024-08-21 16:00:29 +01:00
Zachary Yona 80144686f5 Device-list limiting (#30997)
* PDA can no longer be linked to multitool

* Ignore previous commit, it would've broken things

* Added SavableAddress field to DeviceNetwork component and PDA for testing. Still need to implement

* System works, borg and pda addresses cannot be saved, but they still connect to the net.

* Suit sensors can no longer be added to network configurators, still work for monitoring purposes.

---------

Co-authored-by: Zachary Yona <magicalusf@gmail.com>
2024-08-21 15:50:04 +01:00
Boaz1111 0d4d336761 New Projectile Effect:Temperature Change (#31004)
* bah

* all done, thanks slarti

* makes the watcher do the thing

* Update TemperatureSystem.cs

Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com>

* changes something

---------

Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com>
2024-08-21 15:50:04 +01:00
Red Mushie 4cff2509e5 Fix news management console publish timeout activating when nothing was published (#31161)
Fix news management console updating publish timeout, now updating it *after* access checks instead of before
2024-08-21 15:46:31 +01:00
Red Mushie b1efdb1b2d Fix news management console access checks (#31160)
* Fix news management console access checks using manifest instead of AccessReader component

* Fix one tiny mistake

* Fix one tiny mistake, properly this time

* Revert accidental changes unrelated to this PR

* Add missing .Owner on delete check
2024-08-21 15:46:31 +01:00
geraeumig 855df347b4 Trim punctuation marks in the chat emote system (#28612)
Co-authored-by: geraeumig <alfenos@proton.me>
2024-08-21 15:43:53 +01:00
deltanedas bd7a2a42db add memory cell and rework logic construction (#24983)
* rework construction to be deconstructable, add memory cell

* update textures

* add code

* add memory cell and ports, empty circuit

* d

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-08-21 15:42:36 +01:00
slarticodefast d0db86170a Fix raditation collectors gaslighting you (#31175)
fix raditation collectors gaslighting you
2024-08-21 15:40:17 +01:00
beck-thompson 2ca5673969 Cutting food now moves the food a little bit. (#31166)
First commit
2024-08-21 15:37:33 +01:00
Nemanja 21381d6f71 Goliath mob (#30839)
* Goliath mob

* Update asteroid.yml

* mcfuck yourself

* add cloak

* fixes

* Update materials.yml
2024-08-21 15:36:50 +01:00
Crotalus e3cadf0e37 Fix botany bugs (#27210)
* Fixed bug with missing gas not getting reset

* Fix bug with MutateInt not using min/max in prob calculation

* Add divison by zero check

* Fix styling
2024-08-21 15:31:42 +01:00
Mervill 861c0fa8e7 Replace obsolete map functions in disposals code (#31133) 2024-08-21 15:31:25 +01:00
Nemanja 78a8d551b1 Make printing from ore procecssors slightly more bearable (#31074)
* Make printing from ore procecssors slightly more bearable

* Update sheet.yml
2024-08-21 15:30:20 +01:00
Nemanja caf92a723f Fix npcs throwing themselves straight into space (#31118) 2024-08-21 15:21:03 +01:00
slarticodefast d9a8efc7f5 Fix bluespace anomaly teleporting borg brains and PAIs in container slots (#30744)
* Fix bluespace

* filter all containers
2024-08-21 15:21:03 +01:00
Token bc055a7b65 Plants scream mutation now have more scream variety (#30862)
* seed screams now SoundCollectionSpecifier
More types of scream sounds

* plants scream mutation have 10+ scream types

* plant scream reduce scream volume
And scream powerness get's from yml instead of hardcode, so from prototypes could be changed pretty much easilly

* plants review change
2024-08-21 15:21:02 +01:00
Mervill 160eadb9db Fixs suffocation alerts not appearing. (#31115)
Fixs suffocation alerts not appearing
2024-08-21 15:21:02 +01:00
themias eb2451b543 Add sound for turning on grill (#31099)
* Add sound for turning on grill

* remove view variable
2024-08-21 15:21:02 +01:00
Milon 2af5955659
fix aac tables not working on radio (#1660)
* success begins with suck

* but but my component bloat!!

* oh ffs
2024-08-21 07:24:52 +00:00
deltanedas f941121384
upstream merge (#1636)
* uncomment grappling gun

* Remove rest of Geras files (#30912)

remove remaining geras stuff

* tweak(AgeRequirement): Make the requiredAge more sensible (#30913)

* chrore(ageRequirement): fix grammar. atleast -> at least (#30914)

* Minor sprite fix to inhand med hardsuits and HoS turtleneck jumpsuit (#30918)

* Fixes inhand hardsuit cross color from https://github.com/space-wizards/space-station-14/issues/26516#issue-2213917971

* Fixed HoS Turtle not covering all butt pixels

---------

Co-authored-by: Zachary Yona <magicalusf@gmail.com>

* Add execution component to all energy sword weapons (#30909)

Co-authored-by: plykiya <plykiya@protonmail.com>

* Automatic changelog update

* chore(grammar): correct some mistakes (#30916)

* Add diamond mining drills, buff regular mining drills (#30814)

* why do I have to change so much just to add drills

* diamon

* Automatic changelog update

* give trash a reusable entity table (#30921)

* Contraband marking & examining (#28688)

* System & loc strings

* pass over syndie contraband

* fixes

* grand theft pass

* contrabandexamine -> contraband

* examine text generation update

* all composition parents necessary

* bring back minor contra so it has a less confusing message

* minor

* weapon pass

* jumpsuit pass

* feet pass

* AUUUUUUUUUGHHHHHHHHHHHHHHHHHH

* head

* AUUUUGH

* ear

* belt

* back

* fix

* bro

* rename for more clarity

* do da review

* add cvar for contraband examine

---------

Co-authored-by: EmoGarbage404 <retron404@gmail.com>
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>

* Automatic changelog update

* Automatic changelog update

* Removes variant cube migration (#30934)

add

* First Review Pass Contraband Fixes (#30930)

* First pass contra fix

* bam

* More

* Security crates are now marked as security restricted

* Syndicate raid suit is contra

* damn I forgot gatfruit

* Add conducting gloves to the maintenance loot table (#30904)

* add

* lower weight

* Fix DoDrop to DropNextTo in container cases (#30911)

* Fix DoDrop to DropNextTo in container cases
DoDrop is too heavy to calculation. In any other case we should use alternatives, for example DropNextTo helper method

* codestyle change

* Fix Reagent Fire Stacks (#30766)

* Fix Reagent Fire Stacks

* Comments on code

* little nicer wording?

* Lines 88 and 89, updated 'narsie' and 'ratvar' to 'Nar'Sie' and Ratva… (#30954)

Lines 88 and 89, updated 'narsie' and 'ratvar' to 'Nar'Sie' and Ratvar, per issue #30719.

* Automatic changelog update

* Fix permission check for whitelists in player panel (#30948)

* Automatic changelog update

* Grey mantle in winterdrobe (#29774)

* add the mantle

* fix a few things

* fix merge conflict stuff, remove from winterdrobe and lathe.

* Add mantle to loadouts (20 hour requirement)

* Automatic changelog update

* Sliceable doAfter (#30824)

* init

* wtf git

* Automatic changelog update

* Add capfruit, a gatfruit mutation. (#30850)

* add base

* add fake suffix and flavor fix

* address some reviews

* parent it

* fix test fail

* add FoodSequence support and address small review

* Automatic changelog update

* Fixes the grey mantle (#30971)

add the thing i missed

* Add keybinds for rotating and flipping objects (#30540)

* add keybinds for rotating and flipping objects

* no popup for verbs

* Automatic changelog update

* tweak(Shuttle_honki): Remove DeviceQuantumSpinInverter from honki shuttle. (#30618)

* Make the Borgs Names Appear When they Make an Announcement (#30107)

* Make the Borgs Names Appear When they Make an Announcement

* bwomp

* re-order

* Use Name instead of metadata

* goiup

* Automatic changelog update

* disable contraband examine

* rename our SliceFoodEvent

* Throngler Plushie Sprite (#30969)

Throngonkler Plush sprite

* Fix bug with rotating shelves (#30978)

* Main

* Update shelfs.yml

* Little bug fix

* No weather on concrete tiles (#30952)

* concrete weather

* miss

* development build ghostrole lottery changes (#30980)

debug ghostrole lottery changes

* Automatic changelog update

* Add a saline syringe to the combat medical kit (#29954)

saline

* Automatic changelog update

* fix the admin verbs trying to kill players by filling their lungs with plasma (#30991)

fix the admin tools trying to kill players by filling their lungs with plasma

* Custom Taco & Kebabs - FoodSequence 2 (#30905)

* control layer ordering

* sprite update

* taco!

* taco naming gen

* fix separator naming

* some proto fixes

* default naming separation

* fix taco naming

* rat update

* hamsterburger

* organs taco

* remove from spawners

* fixes

* fix separators and lemons

* Update food-sequence.ftl

* randomization offset

* fix

* kebabs refactor

* fix

* skewer weapon

* Update food_single.yml

* Update migration.yml

* suppermatter

* hamlet centered

* hamsburger

* Update dead-0.png

* 20 -> 4 burger layers max

* Update burger.yml

* canReact: false

* capfruit update

* Update burger.yml

* Update burger.yml

* Update produce.yml

* some fixes

* Update Resources/Textures/Objects/Consumable/Food/taco.rsi/meta.json

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Update Content.Shared/Nutrition/Components/FoodSequenceStartPointComponent.cs

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Update Content.Shared/Nutrition/Components/FoodSequenceStartPointComponent.cs

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* chicken

* Update food-sequence.ftl

* documentation

* fixes

* Update meat.yml

* Update meat.yml

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Automatic changelog update

* Fix popups not working properly with an eye offset (#30990)

* Adds a random smokable spawner (#30870)

* Textures to make lamps mappable to East/West.

* Adds a random smokable spawner

* remove double derma

* Increase chance for just basic cig

* Update to enitity tables

* Tweak values

* Remove space

---------

Co-authored-by: Jeff <velcroboy333@hotmail.com>

* Fix lizards being unable to eat custom burgers (#31005)

* Fix lizards being unable to eat custom burgers

* ensure tag comp

* Automatic changelog update

* Sedin (#27110)

* Sedin

* almost forgot this.

* what

* Did a few fixes, tried to readd popup

* Fix popup, ready for merge

* minor change

* Generalize seed removal/destruction system, add popups in general.

* fix

* fix (again)

* deadcode is no more

* Sedin buff (nerfing the recipe soon)

* godont

* webedit moment

ok listen I had to nuke my setup because my computer was being Dumb As Shit so let me do this ONE webedit

* CRIKEY

* Revert "CRIKEY"

This reverts commit 1c6959ffd9ba8bb1e97ccf2eb0b37b3ff4ec82ee.

I was not supposed to commit that >:/

* Alright, it should be good now but I havent tested it

* ready for merge/review

* prob -> probability

* Requested changes nodoc

* Review nodoc

* documento

* thumb up emoji

* Automatic changelog update

* Adds a Dinky Star Sticker for security officers (#29767)

* Sec-Star-TASTIC

* fix license

* now counts as trash

* Sticks to people + wearable

* no more sticky

* no more sticky

* mystery-space

* Update Loadout Yaml

* Automatic changelog update

* tweak(hospital): Reduce diamond stack from 30 to 1 (#31027)

* tweak(experiment): Reduce diamond stack from 30 to 1 (#31025)

* replace mapped diamond stacks with single

* Figurine voicelines (#30865)

* initial commit

* tweaks to the new voice lines

capitalizations of I's and the Y on hos 3 voice lines
also changed the captain figuring voice line 2 to something completely different

* capitalized one letter

man i really suck at capitalization

* more capitalization

i never thought this pr would need so many changes

* changed one comma to a dot

* Update Resources/Locale/en-US/datasets/figurines.ftl

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

* Automatic changelog update

* Adding shock collar and electropack (#30529)

* Adding shock collar with the new ShockOnTrigger

* Cleaning and updating the shock collar

* Add StripDelay datafield to ClothingComponent

* Adding SelfUnremovableClothingComponent

* ShockCollar Update

* Correction of the shock collar

* Correction of the shock collar 2

* Renaming the DamageSpecifier DataField to Damage

* Fixing the damage field in ShockCollar

* Cleaning the ShockCollar

* Renaming ShockCollar to ClothingNeckShockCollar

* Adding ClothingNeckShockCollar as a stealTarget to a thief

* Fixing a typo of the sprite path in ClothingNeckShockCollar

* Cleaning the ShockOnTriggerComponent

* Revision of SelfUnremovableClothing

* Adding a ClothingBackpackElectropack

* Sprite fix

* Code review

* Shock Collar sprite update

* add commit hash

---------

Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>

* Automatic changelog update

* Greatly improve the usability of the Gas Analyzer. (#30763)

* greatly improve how the gas analyzer behaves

* don't close the analyzer when the object goes out of range

* cleanup

* always switch to the device tab when a new device is analyzed

* modern api part one

* modern api part 2

* modern api part three

* file scope namespace

* Automatic changelog update

* Fix false and true in player-panel.ftl (#31043)

Fix false and true in player-panel

Add a new True string

* Contra Review Passs - Round 2 (#30942)

* Contra pass round two

* command too

* Stamps

* oopsied a bracket

* Namespace cleanup around Mind Roles (#30965)

* namespaces

* Comment does not need a semicolon

---------

Co-authored-by: Vasilis <vascreeper@yahoo.com>

* Contraband Review Pass - The Threequel (#30970)

Contraband pass number three

* Golden toilet (#31049)

* golden toilet

* Destructible

* sprite

* fix

* copyright

* Automatic changelog update

* Salvage Spawners (#31020)

* treasure entities and spawners

* no more smiles

* remove nyano shock collar code

* Event scheduler setting tweaks (#31018)

tweaks

* Automatic changelog update

* remove meteor swarms rule for a moment

* Revamped Meteor Swarm (#28974)

* meteor code and balanced values

* Meteor Swarms

* Update meteors.yml

* Update meteors.yml

* HOO! (fix overkill bug and buff space dust)

* undo BloodstreamComponent.cs changes

* DamageDistribution -> DamageTypes

* part 2.

* Missing meteor presets (#29044)

* add meteors into missing game presets

* changes for real

* implement code

* this too

* Meteors now leave behind a bit of ore (#30419)

* Meteors that leave behind asteroid ore

* bigger offset

* Bit more generic

* Better defaults

* hrm?

* I HATE CUSTOM SERIALIZERS

* More comments

* renamed a variable

---------

Co-authored-by: plykiya <plykiya@protonmail.com>

* refactor event schedulers to use explicit game rules (#29320)

* works, still has testing values, im sure I did stupid shit.

* shitvent crapfactor

* snap extra word out of existence

* shit I died of old

* remove useless inaccurate design comments

* Oopsie, handle requirement params in RandomRuleSystem too

* I'm a slash slinging hasher

* Address reviews, add admin alerts I forgor

* EntityMan saves the day

* address reviews 1

* eh, I actually don't care about the cargo gifts thing.

* started

* Do reviews

* you actually meant 1.2 lmao

* dependency inheritance is a fickle bitch

* I have no idea.

* Threads are for sheets not computers.

* fix traitor rule test

* fix round type tattling

* break things

* It worky

* Toolshed makes we want to drink depresso.

* Finished?

* remove debug values

* timings

* use defaults

* alphabetize

* bobby drop tables

* Float required fr fr

* continue

* more continence

* uno mas

* obsolution

* cleanup and documentations

* Yell at self

* use the right value defaults

* housekeeping

* Event scheduler setting tweaks (#31018)

tweaks

* Automatic changelog update

* remove(NukeopsRuleComponent): Remove a trap from the component file (#31029)

ah

* Fix bug with holding objects (#31009)

Main

* Automatic changelog update

* Replace obsolete map functions in IconSmoothSystem (#30958)

* first part

* second part

* Automatic changelog update

* Fix reagents with ReagentData being duplicated  (#30983)

Initial commit

* :trollface:

* :trollface:

* actually untroll

* a

* 50 burger

* add back old meteor code

* fix

* use some live config options in dev

* remove old shock collar icon

* make ammo more consistent and work more

* clean up lathes diff to upstream

* a

* move rubber bullets to deltav folder

* a

* untroll

* more untrolls

* more untrolls

* untroll

* :trollface:

* a

* b

* remove it for real

* add missing lathe recipes

* replace cvars with component field

* remove taco from roboisseur

* migrate cardboard box with smg mags

* remove kebabs

* a

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
Co-authored-by: Killerqu00 <47712032+Killerqu00@users.noreply.github.com>
Co-authored-by: Brandon Hu <103440971+Brandon-Huu@users.noreply.github.com>
Co-authored-by: Zachary Yona <58833995+Magicalus@users.noreply.github.com>
Co-authored-by: Zachary Yona <magicalusf@gmail.com>
Co-authored-by: Plykiya <58439124+Plykiya@users.noreply.github.com>
Co-authored-by: plykiya <plykiya@protonmail.com>
Co-authored-by: PJBot <pieterjan.briers+bot@gmail.com>
Co-authored-by: Alzore <140123969+Blackern5000@users.noreply.github.com>
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
Co-authored-by: Kara <lunarautomaton6@gmail.com>
Co-authored-by: EmoGarbage404 <retron404@gmail.com>
Co-authored-by: Ubaser <134914314+UbaserB@users.noreply.github.com>
Co-authored-by: Token <esil.bektay@yandex.com>
Co-authored-by: Cojoke <83733158+Cojoke-dot@users.noreply.github.com>
Co-authored-by: LeoSantich <108027402+LeoSantich@users.noreply.github.com>
Co-authored-by: nikthechampiongr <32041239+nikthechampiongr@users.noreply.github.com>
Co-authored-by: pigeonpeas <147350443+pigeonpeas@users.noreply.github.com>
Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com>
Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
Co-authored-by: PoorMansDreams <150595537+PoorMansDreams@users.noreply.github.com>
Co-authored-by: IgorAnt028 <118114530+IgorAnt028@users.noreply.github.com>
Co-authored-by: NotSoDamn <75203942+NotSoDana@users.noreply.github.com>
Co-authored-by: Errant <35878406+Errant-4@users.noreply.github.com>
Co-authored-by: DrSmugleaf <10968691+DrSmugleaf@users.noreply.github.com>
Co-authored-by: Velcroboy <107660393+IamVelcroboy@users.noreply.github.com>
Co-authored-by: Jeff <velcroboy333@hotmail.com>
Co-authored-by: themias <89101928+themias@users.noreply.github.com>
Co-authored-by: Eris <eris@erisws.com>
Co-authored-by: FATFSAAM2 <saamboroujerdi@gmail.com>
Co-authored-by: to4no_fix <156101927+chavonadelal@users.noreply.github.com>
Co-authored-by: Mervill <mervills.email@gmail.com>
Co-authored-by: Vasilis <vascreeper@yahoo.com>
Co-authored-by: Nim <128169402+Nimfar11@users.noreply.github.com>
Co-authored-by: IProduceWidgets <107586145+IProduceWidgets@users.noreply.github.com>
Co-authored-by: SlamBamActionman <83650252+SlamBamActionman@users.noreply.github.com>
2024-08-18 17:21:07 +00:00
deltanedas 8ba57f61e5
make mindshields removable (#1631)
* make mindshields removable

* use new logic stolen from upstream pr

* a

* remove unused mafia trollage

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-08-18 10:47:55 +00:00
Milon 398ffb2dc7
fix admin pda health analyzer (#1637)
* damn it

* whoopsie

* no more fucky wucky fucky wuckies are GONE
2024-08-18 04:08:01 +00:00
portfiend 6fd2b60113
Courier performancer tracker (#1472)
* add MailMetricsCartridge prototype

using the CrimeAssist UI until i make the courier performance ui

* add sprite for mail courier cartridge

* Add MailMetricUI

YAYYYYY IT WORKS
UI Contents pending

* Mail earnings live update mailmetrics

* LO can have mailmetrics too

* Add rest of mail metrics

Also removes some loggers

* Add additional metrics to MailMetric

Also fixes some bugs related to stat counting

* MailMetric updates on mail added

* change sprite credit name

decided id rather be credited as Portfiend

* display all mail numbers now

* remove comment

* style mailmetrics, add heading

* mailmetric UI polish

* fixed unopened mail counting bug oopsie

* wtf is this import

get out of here

* move StationLogisticStats to BaseStationMail

* FOUR SPACES

sirry

* fix: newlines

* address reviews

* address reviews

SORRYYYY this is unexpectedly big

* wtf

* semicolon

---------

Co-authored-by: byte <50130120+huckleton@users.noreply.github.com>
Co-authored-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
2024-08-16 12:24:04 +00:00
Milon 49194f393e
AME changes (oh boy) (#1629)
* Revert "Adjusts AME rate of diminishing returns (#1625)"

This reverts commit 3e6e4d7b16.

* we're SO BACK

* version fuck you

* no more fucky wucky fucky wuckies are gone
2024-08-15 00:15:04 -05:00
deltanedas a03413b5b4
Fix test ops real (#1626)
* update engine

* update tests

* Missing meteor presets (#29044)

* add meteors into missing game presets

* changes for real

* implement code

* this too

* love 4 copy paste tests making sure /suicide kills you

* remote rotation from mapped artifact analyzers

* fix syndie survival boxes

* dedup portafib yml and fix

* untroll arena

* fix edge

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
2024-08-14 15:09:20 +00:00
Velcroboy 3e6e4d7b16
Adjusts AME rate of diminishing returns (#1625)
Co-authored-by: Velcroboy <velcroboy333@hotmail.com>
2024-08-14 12:16:48 +00:00
AJCM-git 1d31ae157c Fix mid round antags not starting (#28523) 2024-08-12 20:39:21 +01:00
portfiend 68e1a9cde1
AAC tablet for speech-impaired characters (#1491)
* basic AAC tablet prototype

using station map as a base

* set up aac component/system

* quick phrase prototype

will probably touch this up later

* basic example phrases

just so i have data to work with

* get AACWindow to iterate over quick phrases

* add the rest of the job phrases

* fix this one job name

* actually fix prison guard name

* buttons for aac window

* fix phrase inheritance

* add tabs to aac contaner

* fix column spacing and add button padding

* aac tablet button colors

* AAC tablet sends messages now

* add aac tablet voice sound yay

* add a 1 second cooldown between phrases

* subjects for most departments

* location phrases

* more phrases

* cleanup + sort buttons alphabetically

* fix these phrases

* even more departmental subject phrases

* common phrases

* cleanup imports

* show name of player that pressed button

* aac tablet can be used by multipel people

after all it does not rely on state changes and also multiple people can press buttons on a tablet at once

* capitalize aac

its an acronym

* you know what it is its more phrases!!!!

* SAFETY PHRASES

* last second phrases

* redundant phrase

* and one more hazard phrase for the road

* change voice of aac tablet from borg to alto

just sounds nicer

* localize ALL Phrases

i love utility scripting to automate tedious tasks

* add AAC tablet to loadout

* add AAC tablet to medfab

* tweak: use multiple parents instead of whatever this is

* add: justice department phrases

* add: time quantity phrases

* add: ores and kitchen appliance phrases

* fix: resolve duplicate phrases

* add: aac tablet sprites

* add: justice button style

* fix: misplaced this line oops

* add: justice dept locations

* remove: redundant phrase

* re-run tests

* fix: move aac tablet loadout format

* fix: use Identity instead of Name for aac tablet sender

* fix: return on send phrase if id is invalid

* fix: remove redundant line

* fix: use LocId instead of String for phrase text type

* add: new phrases bc upstream updates

* fix: newlines

* tweak: add end comments to these style comments

* fix: this phrase was broken lol

---------

Co-authored-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
2024-08-12 15:15:33 +00:00
deltanedas e4892c4272 add paradox role, better role handling 2024-08-11 15:47:24 +01:00
Brandon Hu caf5281008 fix(Commands): Improve Localization of commands. Standardize some behaviors. (#30362)
* I should be studying for school but that is sofucking boring, I will pass my class no matter, however getting an A might be a challenge. My gpa is important but is the tourture for 1 point of GPA worth it? The american government says yes but they are responsible for the majority of all genocides that have ever been conducted since the dawn of man

* ugh

* ugh
2024-08-11 15:19:51 +01:00
slarticodefast 7ace9f1cff Make the sentient plant mutation non-copyable to other plantholders (#29133)
make the sentient plant mutation not propagate by clipping, using the seed extractor or cryoxadone
2024-08-11 15:19:51 +01:00
blueDev2 e2791f19f2 Add MinHealth Construction Condition (#30892)
* Add Min Health Condition and associated Locale

* Add Comment
2024-08-11 15:19:51 +01:00
BombasterDS 735079b096 Change suit sensors on other players (#29668)
* Suit sensors can be turned off on other players

* less doafter time + interaction (nostate) check

* code cleanup

* code cleanup 2
2024-08-11 15:19:51 +01:00
Mervill ea49a51d3c Don't show Station Event announcements to players in the lobby. (#30886)
* Don't show Station Event announcements to players in the lobby.

* fix pr

---------

Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2024-08-11 15:19:51 +01:00
beck-thompson f38903c5c5 Replaced some AddMarkups with AddMarkupOrThrow (#30632)
* First commit

* Silly me

* bruh
2024-08-11 14:52:54 +01:00
Scribbles0 4f9889894b Melee Executions (#30104)
* melee executions

* fix damage bug

* cleanup

* address reviews hopefully

* resistance bypass mechanic

* component changes

* self executions (not finished yet)

* self execs part two

* ok i fixed things (still not finished)

* finish everything

* review stuff

* nuke if (kind = special)

* more review stuffs

* Make suicide system much less hardcoded and make much more use of events

* Fix a dumb bug I introduced

* self execution popups

* Integration tests

* Why did they even take 0.5 blunt damage?

* More consistent integration tests

* Destructive equals true

* Allow it to dirty-dispose

* IS THIS WHAT YOU WANT?

* FRESH AND CLEAN

* modifier to multiplier

* don't jinx the integration tests

* no file-scoped namespace

* Move the rest of execution to shared, create SuicideGhostEvent

* handled

* Get rid of unused code and add a comment

* ghost before suicide

* stop cat suicides

* popup fix + small suicide change

* make it a bit better

---------

Co-authored-by: Plykiya <58439124+Plykiya@users.noreply.github.com>
2024-08-11 14:52:53 +01:00
Ed 86e603f407 Custom burgers - FoodSequence system (#30755)
* setup foodsequence

* name generation and max layers limit

* move to nutrition

* move code to serverside

* move to appearance data

* marked fields as required

* Update foodsequence.yml

* b

* burgeers!

* Update produce.yml

* Update meat.yml

* Update burger.yml

* fix duplicate naming

* Update Resources/Locale/en-US/nutrition/components/food-sequence.ftl

Co-authored-by: Hrosts <35345601+Hrosts@users.noreply.github.com>

* merge flavor profiles

* make food trash List<>

* merge trash

* Update FoodComponent.cs

* Update FoodComponent.cs

* organs and cannabis support

---------

Co-authored-by: Hrosts <35345601+Hrosts@users.noreply.github.com>
2024-08-11 14:46:08 +01:00
deathride58 88fff83127 #30851 followup - murderficates links (#30863)
kneecaps links while we're at it
2024-08-11 14:44:20 +01:00
Nemanja 7646e0d1d2 Cursed Mask (#29659)
* Cursed Mask

* extra expressions

* block ingestion

* mind returning

* okay fix the removal shit
2024-08-11 14:44:20 +01:00
slarticodefast 5862445a84 remove TerminatorRoleComponent (#30733) 2024-08-11 14:42:48 +01:00
deathride58 c2e4b63328 [S] hopefully prevents a repeat of 4 am on 8/10/2024 in the #server-leviathan-use channel (#30851)
cant test this because the documentation sucks ass but fuck it we ball
2024-08-11 14:40:25 +01:00
Nemanja 13e799a666 Entity Tables (EntitySpawnEntry replacement) (#30579)
* Entity table code

* entity table examples

* fix dat shit

* access

* tests tests tests

* sloth review
2024-08-11 14:37:41 +01:00
deltanedas 56e4726d2f rewrite senior id shit 2024-08-10 12:38:56 +01:00
Mr. 27 12621627df :trollface: 2024-08-09 21:49:10 +01:00
deltanedas 12967d9756 :trollface: 2024-08-09 20:32:23 +01:00
metalgearsloth 971755fdfc :trollface: 2024-08-09 20:18:08 +01:00
deltanedas 772fa23067 :trollface: 2024-08-09 20:07:57 +01:00
deltanedas efc005da7d :trollface: 2024-08-09 19:59:39 +01:00
deltanedas bd832562db :trollface: 2024-08-09 19:55:59 +01:00
MilenVolf 11f6eba901 Station event component and system tweaks (#28331)
* Make anomaly, artifact and gifts events announcement sound optional

* Requested changes + Added new "GameRuleAfterAddedEvent" for StationEventSystem

We need to call "Add" in "StationEventSystem" after others GameRule's in case if we need to change StationEventComponent variables.

* Fix margins

* Makes use of GameRuleComponent.Delay and remove station system handling of delays plus small cleanup

* Fix merge

---------

Co-authored-by: AJCM <AJCM@tutanota.com>
2024-08-09 19:52:18 +01:00
deltanedas 92fc8da526 move gamerule components to shared (#28572)
* move MinMax to shared

* cleanup MinMax

* move other ticking components to shared just because

* remove unused prototype file

* update everything to use shared components

* test

* test 2

* test 3

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-08-09 19:42:00 +01:00
deltanedas 1d595f2380 make GameRule use entity category (#28294) 2024-08-09 19:38:07 +01:00
deltanedas 082c3c5627 :trollface: 2024-08-09 19:32:00 +01:00
deltanedas 3b6063a83d improve job special (#30753)
* cleanup of AddComponentSpecial

* add RemoveComponentSpecial

* require

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-08-09 19:17:26 +01:00
metalgearsloth 52420e91c0 Revert "setgamepreset command rework" (#30807)
Revert "setgamepreset command rework (#30756)"

This reverts commit de86fdb3730ac9109dff24c9d820a6ff6c923a16.
2024-08-09 19:17:26 +01:00
metalgearsloth fd4f4f0786 Add access to gun components (#30688)
* Add access to gun components

Found from an rmc14 PR.

* Admin verbs proving why access needs to exist

* Someone is probably going to post this pr to le reddit and complain about self-merges.
2024-08-09 19:17:26 +01:00
Errant 8ccdf56cc6 setgamepreset command rework (#30756)
* gameticker.gamepreset namespace

* setgamepreset now has a finite duration

* comments, cleanup
2024-08-09 19:17:26 +01:00
TsjipTsjip 869947e694 Log enrichment: Explosion damage to players (#29762)
* Log enrichment: Explosion damage to players

* Update Content.Server/Explosion/EntitySystems/ExplosionSystem.Processing.cs

Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>

* Revert to total damage variant only, currently serialised as string.

* Make this its own log type.

---------

Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>
2024-08-09 19:17:07 +01:00
Brandon Hu eb31319e07 tweak(HealthAnalyzer): Stop showing poup when used on self or when cancelled (by twitter) (#30467)
* .
2024-08-09 19:17:07 +01:00
Simon 8fae659336 UI to edit silicon laws from admin verb (#28483)
* UI to edit silicon laws from admin verb

(peak shitcode)

* Improve UI

* Use Moderator admin flag

* Reviews
2024-08-09 19:17:06 +01:00
slarticodefast f6a850476c Add tooltips to the agent ID job icons and improve status icon prototypes (#28575)
* add tooltips to agentid job icons

* forgot to stage this

* make StatusIconPrototype abstract

* minor visual improvements

* cleanup

* use currentculture to sort job names

* review
2024-08-09 19:17:05 +01:00
CaasGit 5209110dc7 add(FaxComponent): Allows for setting defaults in the component. (#30484)
* add(FaxComponent): Allows for setting defaults in the component.

This wires up the Fax component to allow the default paper and office
paper to be set. The defaults are what they were before, and it's an
optional option. Now Fax machines can be set to print different paper
when using Print File or other cases where the default paper style is
used.

* Requested change to EntProtoId.

* Fix build failure.
2024-08-09 19:04:59 +01:00
Psychpsyo b187a74a0e Add replacement words to Russian accent (#30554) 2024-08-09 19:04:59 +01:00
Repo 6cf5e83507 Fix Panic bunker and Baby Jail being up to 14hrs incorrect. (#30581)
Fix a potential bypass for Panic bunker and baby Jail
2024-08-09 19:04:59 +01:00
nikthechampiongr 3a3715648b Implement a playerpanel (#30238)
* Basic structure for the player panel ui

* Ensure basic functionality

Player panel now receives and displays basic info

* Make whitelistcommands accept user ids

* Make PlayerPanel use GUIDs where possible

* Add functionality to most playerpanel buttons

* Implement remaining playerpanel features

* Localize everything

* Finish up

* Put command arguments in quotes

I am not sure if it's even possible to have something like a space in
them considering they are guids and usernames but sure why not

* Make playerpanel a verb

* Add Logs button to player panel

* Change Notesbutton text and make whitelistbutton a confirmtion button

* Add freeze button that does not mute the player

* Add sharedconnections counter to playerpanel

* Make the playetime format clearer

* Allow for copying of the a player's username

* Do minor cleanup

* Rearrange buttons

* Fix unfreeze button not updating

* Fix wrong localisation text

* "Fix" the same role ban counting multiple times

The way rolebans are stored is horrible.
As such if you ban someone from a departmenrt or something
role bans are individually placed for every role.
The only way I found to distinguish them is the bantime.
This is horrible but I do not want to rewrite how all the bans are
stored right now.

* Add Delete and Rejuvenate buttons to player panel

By popular demand

* Marginally improve ui

* Add logs

* review update

* Fix verb

* Fix double notes

---------

Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2024-08-09 19:04:58 +01:00
Plykiya 2aaaa831ed Create Generic DamageOnInteract/Attacked Comps/Systems (#30244)
* Everything but the submodule

* stuff I forgot

* heat

* missed lights

* behonky

* LocId

* I guess it was a skill issue?

* predicted audio

* It works with lights now

* Borg equality

* Gorilla gauntlet grants protection from anomaly returned damage when attacking it

* woops, there we go

* NONE

* Use DamageModifierSets, remove Behonker damage

* Reviews dealt with

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 19:04:58 +01:00
slarticodefast 8bff6691f6 remove UntrackedMapBoundUserInterface (#30752) 2024-08-09 19:04:17 +01:00
beck-thompson e6124ea37b Secret stash refractor (#29396)
* First commit

* Will do this in another PR!

* maybe?

* Moved stuff to ToolOpenableSystem because its smarter and cooler
2024-08-09 19:04:17 +01:00
deltanedas 3613134d2e full sticky prediction (#30230)
* move all sticky stuff to shared and cleanup/grammar fix

* update imports and ref

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-08-09 19:04:17 +01:00
SlamBamActionman f39df535b2 Better DNA forensics & ReagentData (#26699)
* Added the ability for blood to track DNA using ReagentData; Forensic Scanner now accounts for solution DNA, non-DNA holders have "Unknown DNA"

* Removes touch DNA for puddles, adds DNA to vomit

* DNA now leaves traces in containers and those marked without don't show DNA on scan (except for puddles), gibbed parts have DNA

* Fix stupid metamorphic glass bug grrr

* Removed SpillableComponent since DnaSubstanceTraceComponent is used instead

* Removes data field from maps, adds DNA tracking for some missed items

* Give default value, fix missing values.

* Fixes recipe bug

* Review changes

* Make the Data list into a nullable type

* Revert map changes

* Move gibbed unknown DNA to forensicssystem
2024-08-09 19:04:17 +01:00
Ed 1bd33efe8f Thief beacons (try 2) (#29997)
content
2024-08-09 19:04:09 +01:00
Plykiya fcff7ab1c2 Add BreakOnDropItem, update do afters, remove unnecessary declarations (#30361)
* Add BreakOnDropItem, update do afters, remove unnecessary declarations

* bola

* Changed my mind about the nuke

* gennies too

* Make the comments more clear.

* Sorry for the trailing commas

* Revert "Sorry for the trailing commas"

This reverts commit e60fd9a30977393df3344948e6d5c0ce035723cd.

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 19:03:54 +01:00
IProduceWidgets c97b2cc2dc ai stays seated and pulled while cuffed. (#30397)
* ai stays seated while cuffed.

* Do the thing I thought was dumb.... whatever.

* less than
2024-08-09 19:02:30 +01:00
ShadowCommander 7dc986b95b Add EntityWorldTargetAction (#29819)
* Add EntityWorldTargetAction initial implementation

* Update obsolete methods

* Partially working EntityWorldTargetAction

* Fix entity selection

* Move and clean up AfterInteract

* Fix building new walls

* Readd no entity or coordinates error

* Consolidate action validation code

* Add summaries to component

---------

Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com>
2024-08-09 19:02:30 +01:00
deltanedas 60ca67a16a remove GenericAntag completely (#28218)
Co-authored-by: deltanedas <@deltanedas:kde.org>
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2024-08-09 19:02:29 +01:00
TakoDragon 97387d6626 Improved Spanish accent (#30551)
* Spanish and French comment

* Added the interrobang

* Make spanish accent use sting builder
2024-08-09 19:01:53 +01:00
Mervill 6019b2d3bd Remove obsolete occurrences of IComponent.Owner being assigned just before AddComponent (#30724) 2024-08-09 19:01:53 +01:00
Mervill 511b636f2b Add verbose (client predicted!) examine text to Gas Miners (#30480)
* add verbose examine text to gas miners so their behaviour can be understood

* no need for these to be properties

* use an enum instead of two booleans for the miner state

* require the gas miner to be anchored in order to not be disabled

* xmldoc

* pr feedback

* file-scope namespace

* it's to late to hide my transgressions in a rebase

* turns out the normal examine distance is totally fine for this
2024-08-09 19:01:47 +01:00
Nemanja aaa9f84fb1 Replace IClickAlert with events (#30728)
* Replace IAlertClick with events

* whoop

* eek!
2024-08-09 18:58:46 +01:00
Brandon Hu e54b983e17 fix(FieldGenerators): Add missing connection check (#30468)
.
2024-08-09 18:58:46 +01:00
NakataRin 4c9246dec4 Fix Mind Transfer and Role Assignment Logic for Antagonists (#30711)
* AntagSelectionSystemFix

* readded the stuff that shouldn've been deleted in the first place

* re-arrange

* undo indentation

---------

Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
2024-08-09 18:58:40 +01:00
Plykiya 17a24e13a5 Replace xform.WorldPosition with xformSystem method for Setting/Getting (#30029)
* GET WORLD POSITON, ROTATION

* Missing parentheses

* ui system depndency

* the issue

* Unused

* Let the function do the transform

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 18:57:59 +01:00
Nemanja a92cdf55df better examine text for radiation collectors (#30606)
* better examine text for radiation collectors

* this?

* penis
2024-08-09 18:57:58 +01:00
Errant 60c2ee6f00 Vox nukies and ninjafix (#29783)
* Nukie species gear

* antagselectionsystem autointernals

* nukie vox

* skrek

* Remove duplicate code

* skrek

* EVA tank loadouts, vox ninja update

* fix prototype duplication

* skrek

* fix summary

* fixed empty startinggear error

* enable vox ninjas

* Comments

* removed comment because startinggearprototype should not be used on antagselection aaaanyway

* squish that if

* Update Content.Shared/Clothing/LoadoutSystem.cs

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
2024-08-09 18:57:58 +01:00
DrSmugleaf 90b6b2eab0 Fix admin logs cache caching rounds forever if multiple game servers are ran on the same db (#30687) 2024-08-09 18:55:43 +01:00
Mervill 9f1cc60aa9 Refactor the `hungry` debug command to be in line with `thirsty` (#30591)
refactor the hungry debug command to be in line with thirsty

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
2024-08-09 18:54:53 +01:00
Nemanja adda0ad5b1 Add slowdown to low temperatures (#29692)
* TemperatureSpeed component

* temperature slowdown prediction (done right)

* remove unnecessary changes

* that too

* get in line

* make it readonly

* auto pause
2024-08-09 18:54:53 +01:00
SlamBamActionman f54bc47e84 Change Thief Syndie & Chameleon kit contents, add Syndie codeword paper (#30446)
* Initial commit

* more like bYE

* Fix exception during test
2024-08-09 18:54:53 +01:00
metalgearsloth 120f4a4854 Fix random unused field warnings (#29948)
* Fix random unused field warnings

Not many but it counts.

* caught

* Field
2024-08-09 18:54:53 +01:00
Mervill 970c79fe9f Debug command to set either your hunger or thirst to one of their respective threshold levels (#30563)
* Debug command to set either your hunger or thirst to one of their respective threshold levels

* code updates

* code + loc changes
2024-08-09 18:54:53 +01:00
metalgearsloth 24bbd04a5a De-duplicate loadout gear (#30341)
* De-duplicate loadout gear

Needs supporting code, probably with an interface with StartingGearPrototype which would also use it, but I regexed the yaml.

* Code updates

* Remaining yaml

* Fix automatic naming

* raiseEvent

* Don't code when tired kids
2024-08-09 18:51:00 +01:00
Errant 6505969a17 Restore the longer traitor briefing message (#30404)
* Restore the long traitor briefing

* highlights
2024-08-09 18:45:42 +01:00
Ed c051d7902c JobRequirement refactor (#30347)
* refactor JobRequirements

* add profile support

* fix

* Update quartermaster.yml

* sloth fixes

* inport 30208

* Update DepartmentPrototype.cs

* species restriction

* left tweak stick

* stringbuilder is cool!
2024-08-09 18:45:41 +01:00
Plykiya 752a49284e Move PaperSystem to Shared (#30592)
* Fix paper system late localization

* IS THIS WHAT YOU WANT

* well I guess this is happening now

* fix the BUI

* did that even do anything before?

* again with the escapeformatting...

* Dirtying

* Move dirty to function

* Rename PaperSystem to PaperVisualizerSystem

* Fix namespace

* how many namespace changes must I suffer through

* SetContent is for Setting Content

* minor shuffling

* review

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2024-08-09 18:31:41 +01:00
Simon 53e1aeaeb3 Fix warnings in ShuttleSystem.GridFill.cs (#30253)
* Fix warnings in ShuttleSystem.GridFill.cs

* remove the thingie

---------

Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2024-08-09 18:26:30 +01:00
Killerqu00 8543b2c84c Sleeper agents event no longer occurs when evacuation is called (#30646)
no more evac sleeper agents
2024-08-09 18:26:26 +01:00
beck-thompson 80f591cf8e Explosion resistance is now predicted! (#30654)
* First commit

* Added Network and access
2024-08-09 18:24:58 +01:00
slarticodefast 54fbf9c0e5 replace all uses of TryGetContainingContainer with non-obsolete overload (#30583)
* replace all uses of TryGetContainerContainer with non-obsolete overload

* rerun
2024-08-09 18:24:46 +01:00
Mervill 1f00153e29 Remove unused variable from ThownInsertContainerSystem (#30611) 2024-08-09 18:24:46 +01:00
DrSmugleaf 921e7da311 Don't show toggle internals verb if no breath tools are found while off (#30622)
* Don't show toggle internals verb if no breath tools are found

* only if not working
2024-08-09 18:24:29 +01:00
DrSmugleaf a1a62a23e0 Make pointing cooldown a cvar (#30623)
* Make pointing cooldown a cvar

* Remove empty line
2024-08-09 18:24:29 +01:00
Brandon Hu b8bea99091 fix(ChargerSystem): Don't show battery level twice. (#30625) 2024-08-09 18:24:29 +01:00
Brandon Hu 29d8624236 fix(GhostRoleAntagSpawner): Create a new mind before transfering (#30354)
* IN MY WALLS! IN MY WALLS THEY ARE IN MY WALLS HELP HEELP HEKP PA DADOEAMD EODM AOM D *DIES* IM NOT DEAD ADADADDADIAMSDIM

* RUN I SAID RUN! THEY TOOK MY UKELELE

Co-authored-by: EmoGarbage404 <retron404@gmail.com>

* Many have fallen

* It's all emo's fault

---------

Co-authored-by: EmoGarbage404 <retron404@gmail.com>
2024-08-09 18:22:27 +01:00
lzk 07c81e18ea SpeakOnUseSystem and phrases for figurines (#30455)
* commit 1

* 2

* add more text

* apply review

* apply review 2

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>

---------

Co-authored-by: slarticodefast <161409025+slarticodefast@users.noreply.github.com>
2024-08-09 18:22:27 +01:00
RiceMar1244 677eb7cf34 Shotgun spread refactor (#27773)
* Moves spread data to new component

* Refactors shotgun spread code

* Makes shotgun cartridges and projectiles use new component

* Attempts to fix nullable build error

* Fixes hitscan weapons that I broke :(

* Saviour commit?

---------

Co-authored-by: EmoGarbage404 <retron404@gmail.com>
2024-08-09 18:22:27 +01:00
to4no_fix abfe5439d4 Display the administrator's title in ahelp and ahelp relay (#30075)
* Adding the admin prefix to the ahelp

* Updating the admin prefix

* The second update of the admin prefix

* Configuration correction
2024-08-09 18:22:26 +01:00
slarticodefast 6d77481303 Add haloperidol, potassium iodide (#27454)
* add haloperidol, potassium iodide

* review fixes

* review and tuning

* shader review

* use timespan and AutoPausedField
2024-08-09 18:19:08 +01:00
Mervill c37a177224 Debug command to make you thirsty (#30562)
* debug command to make you thirsty

* pr feedback
2024-08-09 18:18:15 +01:00
Mervill a366604df9 Remove obsolete code from Food, Drink and Respirator systems. (#30560)
* Remove obsolete code from Food, Drink and Respirator systems

* remove obsolete comment
2024-08-09 18:18:14 +01:00
Aiden e6acacee75 'Spawn Here' Verb Forces Mind Transfer (#30568)
Update AdminVerbSystem.cs
2024-08-09 18:18:14 +01:00
IProduceWidgets 54cc68445e Allow ai to understand if its handcuffed. (#30402)
* allow ai to understand if its handcuffed.

* rerun tests they worky on local

* Contained here in, a string of expletives about flaky tests.

* on retrospect, default true is probably smorter.

* do reviews

* I forgor xml

* more xml
2024-08-09 18:18:14 +01:00
osjarw eb6f3ea560 Add DoAfter handling to `InteractWithOperator` (#30319)
* commit used for the recording, mostly copypaste

* Remove recording artifacts, now contains content

* use switch expression instead of switch statement
Also `ExpectedDoAfter` to fail when doafter isn't raised
2024-08-09 18:18:14 +01:00
Plykiya 9cee7cffd1 Add percentage reading to chargers (#28500)
* Add percentage reading to chargers

* using args.pushgroup

* change message

* Update Content.Server/Power/EntitySystems/ChargerSystem.cs

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
2024-08-09 18:18:14 +01:00
Mervill fa08b3b045 Show the player a server message when they get booted from the arrivals shuttle (#30519)
show the player a server message when they get booted from the arrivals shuttle
2024-08-09 18:18:02 +01:00
Plykiya b020ea4a3d Update MoverController.cs to not use Component.Owner (#29965)
* Update MoverController.cs

* Update a bunch of movement code to use Entity<T>

* Last errors

* wow, there were more errors

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 18:18:02 +01:00
Nemanja 00fa513693 Add support for printing reagents in lathes (#30476)
* Add support for reagents in lathes

* missing locale
2024-08-09 18:17:30 +01:00
Mervill e6e0c5c945 Remove obsolete code from LightningSystem (#30546) 2024-08-09 18:16:14 +01:00
Mervill 316360112d Remove obsolete code from VomitSystem (#30544) 2024-08-09 18:15:16 +01:00
Plykiya f7b70eb1f7 Update RespiratorSystem.cs to not use Component.Owner (#30426)
Update RespiratorSystem.cs

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 18:15:16 +01:00
IgorAnt028 ac4ed25de6 A small addition to the documentation (#30506)
* Completion of documentation

Comments have been added to ConditionalSpawnerComponent and RandomSpawnerComponent

* Appear fix

Some fixes with word "appear"
2024-08-09 18:15:16 +01:00
TemporalOroboros 55b87b6607 Relocate TemperatureProtectionComponent (#30437)
Moves it from the atmos module to the temperature module where it is actually used.
2024-08-09 18:14:53 +01:00
Cojoke 29ab6da803 Remove Walking out of Containers while You can't Walk (#30391)
* Require Standing to Exit Containers

* whoops, forgot a not

* You can't walk out if cuffed

* GUAH(requested stuff)

* bwomp(tiny cleanup)
2024-08-09 18:14:52 +01:00
Repo fd69799cec aHelp fixes and improvements (#28639)
* Clear search criteria on loading aHelp window

* Pinning technology.

* Relay to aHelp window and discord if a user disconnect/reconnect

* Fix pinning localization

* Log disconnect, reconnects, bans to relay and admin in aHelp

* Drop to 5min to hold active conversations

* Update Content.Server/Administration/Systems/BwoinkSystem.cs

Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>

* discord text styling if diconnect,reconnect,banned message.

* Pin icons instead of text

* Better Icons

* space

* Move button generation in to its own XAML

* List entry control

* Fix spaces

* Remove from active conversations on banned

* Discord if else block cleanup

* Better pin icons

* Move icons to stylesheet styleclass

* Better field order.

* PR review fixes

* fixes

---------

Co-authored-by: Chief-Engineer <119664036+Chief-Engineer@users.noreply.github.com>
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2024-08-09 18:14:52 +01:00
themias e073250aa5 Fix ACC wire light not appearing (#30453) 2024-08-09 18:12:53 +01:00
osjarw fa8b8d03b3 Allow the creation of recursive HTNs (#30138)
Allow recursive HTNs
2024-08-09 18:12:53 +01:00
Plykiya 6219a29c08 Make magic mirror do-after longer, add popups to notify the target (#30366)
* Make magic mirror do-after longer, add popups to notify the target

* Turns out I do have access to the user

* More detailed popups

* Helmets protecc

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 18:12:53 +01:00
nikthechampiongr c8c963677d Vanquish inaccurate docs (#30449) 2024-08-09 18:12:53 +01:00
Mervill 28acafaaef Make the powered examine text fully client predicted (#30441)
* Make the powered examine text fully client predicted

* switch to using the Entity<T> API for the examine event
2024-08-09 18:12:12 +01:00
lzk 19f2865aed FINALLY FIX APPROVER IN CARGO INVOICE!!! (#29690)
* OH DEAR LORD I WASTED 2 HOURS ON THIS STUPID SHIT!!!

* change some logic
2024-08-09 18:12:09 +01:00
Plykiya ab2976cab6 Update stomach removal and lung removal smite to not use Component.Owner (#29927)
* Update stomach removal and lung removal smite

* New function makes things simple

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 18:11:59 +01:00
IProduceWidgets 0205f41c14 Prevent gridfill from leaking (#30395)
dont forget to set the airtights when the tights are aired
2024-08-09 18:11:04 +01:00
metalgearsloth 95079d24e8 Move vgroid much closer (#29943)
* Move vgroid much closer

General feedback is map spam + it takes too long to get to. This is somewhat "close" (considering 1/4 of the distance is the vgroid itself) but without a jetpack / shuttle it's going to be an endeavour.

* Decrease max

* Tweaks

* godzilla

* Update Content.Server/Shuttles/Components/GridSpawnComponent.cs
2024-08-09 18:11:04 +01:00
Errant 1593607249 Do not duplicate Job Greeting on antag selection (#30407)
Silence MindAddRoles in AntagSelectionSystem
2024-08-09 18:10:30 +01:00
metalgearsloth e6b18f37d5 Fix VGRoid grid spam (#29946)
Specifically if a grid splits under the cvar size it doesn't get a label. This also stops stuff like shuttles splitting in half creating new entries for the new grids. Splitting code leaves the largest grid as the existing one so this will always prefer to keep it large (but if there's multiple splits it won't adjust).
2024-08-09 18:08:24 +01:00
chavonadelal dd376f5315 Localization of the title of the job (#30353) 2024-08-09 18:08:24 +01:00
themias b75173194d Fix arcade machines (#30376) 2024-08-09 18:08:24 +01:00
Brandon Hu 3f13ff9bd8 fix(cmd-Jobwhitelistadd): Fixed typo in Loc.GetString (#30355)
LET ME IN THE BAR LET ME IN THE BAR LET ME IN THE BAR. IM 18 I SWEAR PLEASE PPLEASE NOOOO I SWEAR PLEASE PLEASE I WANNA GET CRUNK
2024-08-09 18:08:09 +01:00
Plykiya 6a73ae1005 Update vomit organ smite to not use Component.owner (#29926)
* Update vomit organ smite to not use Component.owner

* is this what you want...?

* am I winning, dad?

* update the comment

* we love entity<t>

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 18:06:43 +01:00
lzk bc2acf7845 Replace some to do with TODO (#30346)
Replace to do with TODO
2024-08-09 18:04:42 +01:00
osjarw 93d41fba30 Make `NeedHand` modifiable for injectorSystem (#29870)
* Get needhand from yml

* MovementThreshold modifiable + inheritdoc
2024-08-09 17:59:55 +01:00
Benjamin Velliquette 2abb5d92e2 Fix Reagent Grinder being able to do work without being powered (#30267)
* Check if grinder is powered before doing work

* Use existing extention method.
2024-08-09 17:58:41 +01:00
Scribbles0 692347a25a Handless mobs can no longer wipe devices (#30149)
add check for hands
2024-08-09 17:58:41 +01:00
Cojoke c477d32203 telescreen and television require vision + Move eye to shared (#30260)
* telescreen and television require vision

* Move Content.Server.Eye to Shared

* fix popups

* Filthy
2024-08-09 17:55:40 +01:00
Errant 820935fd85 Fix replayghost spawning location (#30252)
Fix replayghost spawn
2024-08-09 17:54:45 +01:00
osjarw f4e051c3f4 Make delay incurred from additional syringe contents modifiable + tiny syringe buff/fix (#29825)
* Make delay incurred by transfer amount modifiable

* No unintentional negative delay please

* Use more fixedpoint, hope I didn't break anything

* merge review suggestion

Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>

---------

Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
2024-08-09 17:53:48 +01:00
Plykiya 7a709ba4c4 Eating and Drinking Doafter Change (#30060)
My lawyer told me to do this

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 17:53:33 +01:00
LankLTE 2a643d2606 Darts can now pop balloons. (#30088)
Basic implementation.
2024-08-09 17:53:33 +01:00
slarticodefast dcc885d65c fix microwave construction (#30232)
* fix microwave construction

* retry
2024-08-09 17:53:32 +01:00
Tayrtahn b68bbfc939 Fix error when manually adding ChasingWalkComponent to an entity (#30207) 2024-08-09 17:53:32 +01:00
Cojoke 567b0d7100 Prevent Dragon Body from Despawning (#29842)
* Prevent Dragon Body from Despawning + Make Dragon Unrevivable

* Requested changes

* Meh, nobody wanted this anyways and it was not really an issue
2024-08-09 17:53:32 +01:00
Plykiya a1d6e04731 Syndicate Reinforcement Specializations: Medic, Spy, Thief (#29853)
* Syndicate thief, spy, medic

* Fixes description for nukies

* update description for uplink

* Implement the radial menu

* forgot these were necessary to push lol

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 17:53:32 +01:00
osjarw 44e292798d NPCs no longer consider anchored pipes as weapons (#30061)
* Anchored pipes are no longer considered weapons

* Switch to overload utilizing a TransformQuery
2024-08-09 17:53:18 +01:00
IProduceWidgets 396e0ed171 Nukie Outpost is no longer a station map (#30090)
* I dunno, break shit I guess.

* Actually fix some shit for once.

* test flakey or me flakey?

* Test were not flakey, they just didnt make any sense anymore.

* more stationy tests

* undo abuncha shit I can set in yml instead

* forgor an assert

* unneeded usings

* 1984

* I made github angy

* yoink

* the end is never the end is never the end is never the end is never the end is never the end is never the

* Im going to commit sudoku
2024-08-09 17:53:06 +01:00
Winkarst 53a4e7241c Fix servers ambience sound (#30091)
* Fix servers ambience

* I'm silly

* Clean up
2024-08-09 17:52:27 +01:00
metalgearsloth 037230f731 Set input coords to invalid if mouse off-screen (#30164)
This may be a breaking change for some stuff, I only tested basic combat stuff + throwing.

This fixes the coordinates setting an off-screen position to the top-left pixel and blocks throw attempts as a result.
2024-08-09 17:52:22 +01:00
Nemanja 055169e12e PA ui cleanup + bugfixes (#28750)
* ui and visual aspect + radio

* finish jank ui shit and finish radio

* remove radio

* send it

---------

Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2024-08-09 17:52:22 +01:00
Chief-Engineer 0c17e4e764 Add debug logs to baby jail and fix playtime logic (#30158)
* add debug logs

* Update Model.cs

* fix playtime logic for null playtime

* remove unnecessary condition

* either me or the compiler is having a C# skill issue
2024-08-09 17:52:21 +01:00
Aiden 83c71ab237 MassHallucinationsRule Minor Refactor (#28748)
* Update MassHallucinationsRule.

* Update Content.Server/StationEvents/Events/MassHallucinationsRule.cs

Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com>

* Update Content.Server/StationEvents/Events/MassHallucinationsRule.cs

Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com>

* Update Content.Server/StationEvents/Events/MassHallucinationsRule.cs

Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com>

* MGS Change

* Update Content.Server/StationEvents/Events/MassHallucinationsRule.cs

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>

* Update Content.Server/StationEvents/Events/MassHallucinationsRule.cs

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>

* Move affectedentities to component, remove masshallucinationscomponent as its no longer needed to track entities.

* Apply suggested changes.

* No double checks

---------

Co-authored-by: Ed <96445749+TheShuEd@users.noreply.github.com>
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
2024-08-09 17:52:08 +01:00
DrSmugleaf 6e98560836 Fix NPC line of sight not working if trying to ranged target a blocking entity (#30055) 2024-08-09 17:51:30 +01:00
themias 3706f265a8 Fix mailing unit UI (#30174) 2024-08-09 17:51:14 +01:00
Ed e401ccff85 randomize iconSmoothing (#28158)
* randomize iconSmoothing

* Revert "randomize iconSmoothing"

This reverts commit 094356f975737c0af24ce39d849aec7852b9af6e.

* try 2

* trying work with client-server communication

* still dont work

* Tayrtahn good suggestion

* remove outdated code

* Fix!

* move data to Appearance

* Update RandomIconSmoothComponent.cs
2024-08-09 17:51:14 +01:00
Plykiya a7e6e3a1aa Fix for thrown items dealing damage twice to first target (#30115)
* FUCK YOU

* fine

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 17:50:59 +01:00
Cojoke 4b43756e66 Remove all Assigned Values that are Never Used (#30110)
Remove all Assigned Values that are never used
2024-08-09 17:50:58 +01:00
Plykiya 224f1de03e Fix arrow pointing animation (#30134)
Fixa the arrows

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 17:50:33 +01:00
Smirnov Peter 4a6d94e75d Add item checking for moth food (#30019)
* Add ContainerContainer component checking for moth food

* Use ItemSlotsComponent checking on food item
2024-08-09 17:50:33 +01:00
Ed c5653546c6 LatheSystem independently of energy (#30148)
* Update LatheSystem.cs

* Emo
2024-08-09 17:50:33 +01:00
Cojoke 967217d67a Prevent Quantum Spin Inverter from Teleporting Things into Microwaves (#29200)
* Prevent Quantum Spin Inverter from Teleporting Things into Microwaves

* Simplifies code, GetTeleportingEntity instead of TryGet, adds failed teleport message

* remove using Linguini.Syntax.Ast;

* capital...

* re-add CanInsert and Fixes microwave issue

* beb

* beeb
2024-08-09 17:50:32 +01:00
Ed f040b209bc DungeonSystem.Rooms bugfix (#30125)
Update DungeonSystem.Rooms.cs
2024-08-09 17:50:32 +01:00
slarticodefast adbc072a5c Fix formatting warnings (#30122) 2024-08-09 17:50:32 +01:00
Ed 42344fa536 Character menu issuer localization (#29840)
* Update CharacterUIController.cs

* TODO Burn this shit

* huh?

* huh!

---------

Co-authored-by: lzk <124214523+lzk228@users.noreply.github.com>
2024-08-09 17:50:12 +01:00
Plykiya 84470154e3 Replace EntityPrototype.NoSpawn with EntityPrototype.HideSpawnMenu (#30082)
NoSpawn

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 17:47:51 +01:00
Cojoke 6d877d0be7 Remove uses of AllObjectives (#30077)
Remove the uses of AllObjectives
2024-08-09 17:47:51 +01:00
Winkarst c71f525832 Make addgamerule command process only valid game rules (#29912)
* addgamerule command processes only valid rules

* Update

* English moment
2024-08-09 17:47:51 +01:00
Simon d4b81acbfe Fix some markup related obsolete warnings in research and anomaly related systems (#30072)
Fix some Markup related obsolete warnings in Research and Anomaly related systems
2024-08-09 17:47:51 +01:00
osjarw a71417125e Fix HTN/NPC better plan selection (#30017)
* recording commit

* Remove debugging/recording content
2024-08-09 17:47:28 +01:00
lzk 73f663433e Fix AGhostCommand naming (#29945) 2024-08-09 17:47:28 +01:00
osjarw 2c27f55570 NPC exits MeleeOperator on invalid EntityUid (#30005)
EntityUid 0 problem fix
2024-08-09 17:47:28 +01:00
Plykiya 1f8b8180e5 Replace obsolete EntityCoordiates.InRange() with TransformSystem.InRange() (#29993)
* Replace EntityCoordiates.InRange() with TransformSystem.InRange()

* nullspace

* I figured it out

* man I have no clue how client side sutff works

* please have mercy

* remove RadiationPulseOverlay changes

* nullspace

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 17:47:22 +01:00
Plykiya ae0a69d769 Replace obsolete xform.ToMap() with xformSystem.ToMapCoordinates() (#30010)
* Get rid of a bunch of obsolete usages

* position

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 17:47:21 +01:00
Plykiya a289f0f934 Update SpawnAfterInteractSystem.cs to not use Component.Owner (#29968)
* Update SpawnAfterInteractSystem.cs

* what the fuck is that condition

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 17:45:46 +01:00
deltanedas ad00038233 make cargo balance ui updating its own component (#28295)
* add BankClientComponent and event

* query BankClient instead of hardcoded CargoOrderConsole for updating

* add BankClient to all ordering consoles

* :trollface:

* add Balance field to BankClient

* forgor

Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>

* m

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
2024-08-09 17:45:45 +01:00
Nemanja a319fca68a Watches (#29550)
* watches

* rename

* add it into loot pools
2024-08-09 17:45:45 +01:00
Plykiya 767be16963 Update SalvageSystem.Magnet to not use Component.Owner (#29961)
* Update SalvageSystem.Magnet.cs

* Update SalvageSystem.Magnet.cs the right way

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 17:45:39 +01:00
deltanedas aa043d43eb fire extinguisher using item toggle (#29906)
* move SprayAttemptEvent to shared

* add SolutionTransferredEvent

* replace FireExtinguisher with SpraySafety

* update fire extinguisher yml

* invert visuals

* always handle event in solution transfer, it makes popups

* instantly fill it

* untroll

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-08-09 17:45:39 +01:00
Tayrtahn bf813ccc63 Fix antag objectives always overshooting MaxDifficulty (and kill tries20) (#29830)
* The death of try20

* Add integration test for traitor gamerule

* Fix max difficulty being overshot

* Check at least one objective is assigned

* EntProtoId
2024-08-09 17:45:38 +01:00
Plykiya f52add98e3 Update SmokingSystem.SmokingPipe.cs to not use Component.Owner (#29967)
Update SmokingSystem.SmokingPipe.cs

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 17:45:38 +01:00
Plykiya 13bfc144ae Update TriggerSystem.TimedCollide.cs to not use Component.Owner (#29970)
Update TriggerSystem.TimedCollide.cs

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 17:45:38 +01:00
Plykiya 702a73c32e Update UtensilSystem.cs to not use Component.Owner (#29971)
Update UtensilSystem.cs

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 17:45:38 +01:00
Plykiya 88b82ea54d Updates GasTankSystem and InternalsSystem to not use Component.Owner (#29934)
* blah, setup

* Updates GasTankSystem and InternalsSystem to not use Component.Owner

* squish the diff

* Fixa the rest

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 17:45:37 +01:00
osjarw b33c8a024c Implement Health Consideration for NPCs (#29922)
Implement TargetHealthCon
2024-08-09 17:45:37 +01:00
chavonadelal 5de1e28465 Localization of dungeon direction (#29911) 2024-08-09 17:45:37 +01:00
Plykiya 9facadefe4 Update BiomeSystem.cs to not use Component.Owner (#29939)
Update BiomeSystem.cs

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 17:45:36 +01:00
chavonadelal c0228a4f9a Аnnouncement sender localization (#29907) 2024-08-09 17:45:29 +01:00
metalgearsloth 8f1c51e661 Revert "Picking a ghostrole as an admin will now deadmin you. (#29790)" (#29901)
This reverts commit 1a50760e674134de6065bff3bc76739526ea5429.
2024-08-09 17:45:29 +01:00
Tayrtahn d972a3647f Fix AtmosDeviceSystem debug assert Heisenbug (#29752)
Fix AtmosDeviceSystem debug assertion Heisenbug
2024-08-09 17:45:28 +01:00
deltanedas d3aa1efc38 item toggling giga rework + full ninja refactor (#28039)
* item toggle refactoring and some new systems

* add ToggleClothing component/system

* unhardcode magboots gravity logic

* make magboots and speedboots use ItemToggle and stuff

* remove now useless clothing components

* update client/server magboots systems

* add note to use ItemToggledEvent in ToggleActionEvent doc

* refactor PowerCellDraw to use ItemToggle for ui open/close control

* add TryUseCharges, refactor charges system

* update magboot trigger code

* make borg use ItemToggle, network SelectedModule instead of now removed Activated

* add AccessToggle for borg

* the giga ninja refactor

* update ninja yml

* update ItemToggle usage for some stuff

* fix activatableui requires power

* random fixing

* yaml fixing

* nuke ItemToggleDisarmMalus

* make defib use ItemToggle

* make things that use power not turn on if missing use charge

* pro

* fix sound prediction

* bruh

* proximity detector use ItemToggle

* oop

* big idiot syndrome

* fix ninja spawn rule and make it generic

* fix ninja spawn rule yml

* move loading profiles into AntagLoadProfileRule

* more ninja refactor

* ninja yml fixes

* the dreaded copy paste ops

* remove useless NinjaRuleComponent and ue AntagSelection for greeting

* fix invisibility

* move IsCompleted to SharedObjectivesSystem

* ability fixes

* oop fix powercell instantly draining itself

* sentient speedboots gaming

* make reflect use ItemToggle

* fix other test

* loadprofilerule moved into its own pr

* remove conflict with dragon refactor

* remove all GenericAntag code from ninja

* )

* probably

* remove old enabled

* great language bravo vince

* GREAT LANGUAGE

* who made this language

* because it stinks

* reparent blood-red magboots to magboots probbbly works

* most of the review stuff

* hasGrav doesnt mean what i thought it did

* make health analyzer use itemtoggle, not fail test

* fix mag/speed boots being wacky

* UNTROLL

* add ItemToggle to the random health analyzers

* a

* remove unused obsolete borg func

* untrolling

* :trollface:

* fix test

* fix

* g

* untroll

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-08-09 17:45:27 +01:00
MFMessage ef04a0bfe3 Picking a ghostrole as an admin will now deadmin you. (#29790)
* @forcibly deadmins you

* Added checks for AdminDeadminOnJoin
2024-08-09 17:39:45 +01:00
Cojoke b735c84e1a Fix the ability to shoot out of crates (#28961)
* Fix the ability to shoot out of crates

* Makes it check what inventory the player is in

* use IsEntityOrParentInContainer

* Fix Issues Github had

* gaahhh... Prevents lasers from being shot out of crates

* gaahhh... Prevents lasers from being shot out of crates

* Fix laser?

* hmmm... this is better looking I think?

* Uncook indentation

* Rerun tests?
2024-08-09 17:39:19 +01:00
Chief-Engineer 366cea3352 Fix baby jail (#29896)
* Revert "Revert Baby Jail (#29891)"

This reverts commit 24a2866747e6de37ab2c4395bee9ea44c9211c6f.

* the fix
2024-08-09 17:39:18 +01:00
Vasilis b0edb5ccf0 Revert Baby Jail (#29891)
* Revert "SS14-28662 Add Baby Jail: a Jail for Babies (inverse panic bunker) (#28763)"

This reverts commit 3ceb92a0c43d3815d65c8124cd6bea3be5140455.

* Revert configs

* Oops
2024-08-09 17:38:45 +01:00
Tayrtahn 87fb12b6cb Replace ProtoId<EntityPrototype> uses with EntProtoId (#29892) 2024-08-09 17:38:31 +01:00
dffdff2423 e63d2a2ac6 Add an option to the admin fax menu to lock papers such that they can't be edited by cybersun pens (#28972)
* Add option to adminfax for locking papers.

* Replace dummy control with margin
2024-08-09 17:38:28 +01:00
Moomoobeef 90d3155c0d fixed missing characters in OwO accent (#29047)
replaced two characters with ones that actually show up ingame
2024-08-09 17:38:28 +01:00
Ed 92cd28bb11 Steal Objective Condition now support stacks (#29843)
* Update StealConditionSystem.cs

* Update StealConditionSystem.cs
2024-08-09 17:38:27 +01:00
lzk ec65a571c7 Fix colornetwork desc and help (#29856)
* Fix colornetwork description

* suggested changes

* forgor

* done

* ok now it IS done
2024-08-09 17:38:27 +01:00
Plykiya f68b5a8817 Stop eating food if you drop it (#29854)
* Stop eating food if you drop it

* woops, unused param

* comments

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 17:38:27 +01:00
Errant 2337238cec Aghosts can now /ghost (#29360)
I will not be subjected to criminal abuse
2024-08-09 17:38:04 +01:00
chavonadelal 70296211fa Nozzle Direction Localization (#29849) 2024-08-09 17:38:03 +01:00
chavonadelal b2ec9a6551 Localization of the threat level in an emergency lamp (#29847) 2024-08-09 17:38:03 +01:00
lzk 2d0fc339ed Add popup for health analyzer target (#29803)
* Add popup for health analyzer target

* addition

* fix showing popup to all
2024-08-09 17:38:03 +01:00
lzk 70b269717c Add popup for healing target (#29804)
* Add popup for healing target

* hop

* huh

* fix one

* fix showing popup to all
2024-08-09 17:38:03 +01:00
slarticodefast f84b23cd38 Improve throwing precision (#29726)
* improve throwing precision

* remove debugging logs

* minor fixes

* f

* Update Content.Shared/Throwing/LandAtCursorComponent.cs

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
2024-08-09 17:35:24 +01:00
Tayrtahn 37af3861da Silence ringtones on admin PDAs (#29801)
* Silence ringtones on invisible PDAs

* Revert "Silence ringtones on invisible PDAs"

This reverts commit afc1041f31eebe82e83630a856a8856b877a9826.

* Literally just this

* Add an admin announcement for news article publishing
2024-08-09 17:35:24 +01:00
Nemanja 52472122eb The real AME nerf (#29587)
* The real AME nerf

* oh the real change

* Update AmeNodeGroup.cs
2024-08-09 17:35:23 +01:00
Nemanja 96e1be9a0a metal foam grenades (#29428)
* metal foam grenades

* wow okay

* meh

* bruh

* test

* push
2024-08-09 17:34:17 +01:00
Verm 7d74de8f5a Bartending+: Shaking and Stirring (#29243)
* Shaking and Stirring

* Remove shake message

* Switch if order a bit

* Add doafter supprot for reactionmixer

* Fix nullability

* Timespan zero

* Forgot to remove loc string

* Reorganize usings

* Remove unneeded usings, fix b52 needing to be shaken
2024-08-09 17:33:56 +01:00
Nemanja 8295d43319 Intercom buffs and fixes (#29580)
* Intercom buffs and fixes

* remove unused bui state

* mild sec intercom buff

* reinforce sec intercoms
2024-08-09 17:33:56 +01:00
beck-thompson 06f67a73e6 Spilling reagents on mutliple entities at once fix (#29763)
* Fixed!

* That could have been bad this is why I'm glad I check the diff xD
2024-08-09 17:32:07 +01:00
themias 9f37f7c14a Don't allow toggling internals while asleep (#29753) 2024-08-09 17:31:51 +01:00
lzk a008a646e9 Add summary comments for ElectrifiedComponent fields (#29733)
add summaries for ElectrifiedComponent
2024-08-09 17:31:25 +01:00
Jezithyr 4e03110cff Re-enabling nukie species(except vox), added antag species blacklisting
* Revert "Make all Nukies humans (#29693)"

This reverts commit 3e3e050aafb93daa1eb017ee06b5e2a15fb3d315.

* Implemented species blacklist

* Re-enabled all species as Nukies except for Vox because loadouts don't support breathing alternative gases yet.
2024-08-09 17:31:25 +01:00
nikthechampiongr 1f3cf5c68f Move checking code for BlacklistedRange to the right place in sqlite (#29389) 2024-08-09 17:31:25 +01:00
Nemanja 350754879e Make all nukies humans (#29693) 2024-08-09 17:30:58 +01:00
Nemanja 6dd602ef71 add apc power draw to stat value command (#29701)
add apc stat value
2024-08-09 17:27:14 +01:00
metalgearsloth 3b3e8d77fd VGRoid support (#27659)
* Dungeon spawn support for grid spawns

* Recursive dungeons working

* Mask approach working

* zack

* More work

* Fix recursive dungeons

* Heap of work

* weh

* the cud

* rar

* Job

* weh

* weh

* weh

* Master merges

* orch

* weh

* vgroid most of the work

* Tweaks

* Tweaks

* weh

* do do do do do do

* Basic layout

* Ore spawning working

* Big breaking changes

* Mob gen working

* weh

* Finalising

* emo

* More finalising

* reverty

* Reduce distance
2024-08-09 17:27:13 +01:00
Plykiya 8a38f3b8c6 Thieving glove pickups actually stealthy (#29665)
Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 17:26:15 +01:00
lzk 8910bf4c0f Fix GhostCommand naming (#29671) 2024-08-09 17:25:49 +01:00
Mervill c0a4865d75 Clean up gas miners (#29657)
Separate the environment check from CapSpawnAmount into GetValidEnvironment to make the code a little cleaner, and also makes these two checks independent.

CapSpawnAmount and GetValidEnvironment now both have zero side-effects

Broken renamed Idle to reflect its use. Broken in my mind implies that there's some method for fixing.

---------

Co-authored-by: Partmedia <kevinz5000@gmail.com>
2024-08-09 17:25:49 +01:00
lzk 73f02aaa0b Add ability to add additional friendly and hostile factions in prototypes (#29636)
* Make friendly and hostile factions in NpcFactionMemberComponent datafiels

* :trollface:

* :trollface:
2024-08-09 17:22:38 +01:00
Chief-Engineer f1c0e2cc73 add more info to entity json in logs (#18672)
* add more info to entity json in logs

* replace TryGetSessionById

* remove unused dependency

* get admin status from the entity

* group values by component

* alphabetize

* I've discovered that my original plans may be bad for performance
2024-08-09 17:19:01 +01:00
Tayrtahn c2fbcff987 Fix nukeops ending early if an operative dies at base (#29642)
Fix nukeops ending early if an operative died at base
2024-08-09 17:19:00 +01:00
Cojoke 50b01f39aa Allow Flares to light cigarettes (#29476)
* Allow Flares to light cigarettes

* !IsHot check

* nicer looking(and I think the right way to do that...)

* heh, whoops

* Adds IgnitionEvent, IgnitionSource now functions as IsHot when Ignited

* Fixes + remove redundancy

* Hows this?

* press enter

Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>

* Flare is not forever hot anymore

* Formatting fixes

* Make IgnitionEvent readonly

---------

Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
2024-08-09 17:19:00 +01:00
jmcb c1b97b0e64 Remove outdated NotNullWhen annotation (#29641)
A previous version of this function returned a bool. Since this no longer does that, remove the annotation.
2024-08-09 17:19:00 +01:00
Plykiya 8cda9cc1b1 Fixes gravity wells (#29617)
* Fixes gravity wells

* thank you slarticodefast

* Minor nitpicks addressed

* NITPICKS UNDONE

* REDO THE NITPICK, WE LOVE MATRIX MULTIPLCATION

* Revert "REDO THE NITPICK, WE LOVE MATRIX MULTIPLCATION"

This reverts commit c782eee1a1c7bda90c7ca686928019cc5f25c8cf.

* NITPICK REDO

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-08-09 17:19:00 +01:00
metalgearsloth 221b8ae475 Add FTL arrival visuals (#29402)
* Add FTL arrival visuals

* weh

* Update Content.Shared/Shuttles/Components/FTLComponent.cs

Co-authored-by: Tayrtahn <tayrtahn@gmail.com>

---------

Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
2024-08-09 17:19:00 +01:00
WarMechanic 10b7e40ed2
Senior ID cards get a custom job name: Attempt 3 (#1425)
* revert 1218

* oops wrong file

* commit changes

* it works!!!

* revert accidental changes

* hide senior virtual job prototypes from job select

* remove whitespace diff

* consolidate comments

* remove virtual job prototypes

* these changes were not staged

* remove whitespace diff

* remove whitespace diff again and revert test change

* Update station_engineer.yml

Signed-off-by: WarMechanic <69510347+WarMechanic@users.noreply.github.com>

* Update SharedJobSystem.cs

Signed-off-by: WarMechanic <69510347+WarMechanic@users.noreply.github.com>

* fix capitalisation typo

* consolidate comments and dependencies, also change Mind to use VirtualJobName

* comment correction

* localise senior job names

* fix build error

* fix spawned cards being broken

* reduced logging for finding PresetIdCard

* more fixes

* fix

---------

Signed-off-by: WarMechanic <69510347+WarMechanic@users.noreply.github.com>
2024-08-06 23:20:49 +02:00
metalgearsloth 00ae128855 Fix door access in mapping mode (#30030)
Fix shouldn't break anythingTM.
2024-07-26 00:32:25 +00:00
Null f19310b268
Merge pull request #1533 from NullWanderer/2024/07/05-upstream-merge
Finally, the big merge
2024-07-25 03:17:57 +02:00
null 96acb39b71
Untroll reagents 2024-07-25 02:07:54 +02:00
Nemanja 1bb89bdca5
Selectable Bar Signs (#29068)
* make bar sign selectable

* ajcm strongest soldier

* AJCM comes down hard for round 2

* good shit

* ok ballin

* bless'ed be the webedit
2024-07-25 01:57:58 +02:00
Plykiya fe1571b3aa
Removes obsolete AnchorEntity() functions (#28613)
Obsolete anchor entity functions

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-07-25 01:57:55 +02:00
Chief-Engineer 3d364c8e0e
Disable ame unsafe admin alert (#29582)
disable ame unsafe admin alert
2024-07-25 01:56:44 +02:00
SlamBamActionman f08ba8b494
Turn ReagentEffects into generic EntityEffects (#28168)
* Oh the possibilities

* Merge fixes

* Forgot to remote LavaSystem oops

* Changed EntityEffectArgs to EntityEffectBaseArgs and EntityEffectReagentArgs

* Throw exception for unimplemented effectargs

* Remove Json and overrideable datafields

* Fix test issues

* Actually fix the compiling issue

* Fix comments and remove EntityEffectArgs (no longer used, replaced with EntityEffectBaseArgs)
2024-07-25 01:55:29 +02:00
Guillaume E 10c33d0390
Improve gas miner's output bounds checks (#29569)
Miners now can produce a fraction of their SpawnAmount corresponding
to the "remaining space" available in their environment according to
their MaxExternalPressure and MaxExternalAmount.
2024-07-25 01:55:10 +02:00
Nemanja 09d5711680
fix explosion resistance showing 0 values (#29572)
* fix explosion resistance showing 0 values

* markup
2024-07-25 01:55:09 +02:00
osjarw fdd1f80fe7
Limit air lost by wrenching/breaking pipes (#29574)
Gas lost via wrench/breaking capped
2024-07-25 01:55:07 +02:00
slarticodefast 3457c80cb1
Add sprite for vent under-pressure lock-out (#29527) 2024-07-25 01:54:57 +02:00
slarticodefast 00047bb1b1
Fix air vent and scrubber not requiring power (#29544) 2024-07-25 01:54:56 +02:00
deltanedas e315a17c82
plutonium core steal objective (#26786)
* add textures

* add SealingCabinet system

* add StoreUnlocker/ObjectiveUnlock system

* add plutonium core and nuke core container

* make nuke deconstructable

* add steal core objective

* add core extraction toolbox to new category

* typo ops wrench fuel

* use queries and resolve, have it resolve instead of using Comp

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-07-25 01:54:51 +02:00
metalgearsloth 4e6eee2de6
Predict typing indicator (#29551)
It greatly annoys me in the rare instance I do play.
2024-07-25 01:53:55 +02:00
DrSmugleaf 4ef3971a4a
Move GameTicker.RoundDuration to Shared (#29425) 2024-07-25 01:53:34 +02:00
Pieter-Jan Briers 4a2fe34404
Fix bugs resulting in quantum APC visual states (#29475)
There were TWO bugs here

FIRST, APCs *did* update their visual state on initialization, but at that point the relevant power state hasn't been initialized yet, so it always returns a bogus result. There aren't guaranteed to be subsequent power updates that actually trigger the APC to update so this can get it stuck.

Fixed by just deferring the on-init update to be after the first update tick, which is itself ordered to be after power update.

SECOND: Once I fixed that, I ran into the issue that APCs created at *server startup* also fail to update, because the throttling system (to prevent frequent APC updates) thinks the LastChargeStateTime was at server startup.

Fixed by making that variable nullable so it defaults to null.

Also removed the useless datafields on the "last update" fields. These are all just used to cache and throttle updates, something that should not be persisted to a map file.
2024-07-25 01:53:30 +02:00
Guillaume E 03eded9173
Make miners respect AtmosDeviceUpdateEvent.dt (#29522)
Miners' prototype have been changed to reflect this (I read
somewhere that we have about 1 atmos tick/0.5s, my tests show more
like 1/0.53 but that looks close enough).

This also means that miner's spawnAmount is now expressed in mol/s.

See: #18781
2024-07-25 01:53:09 +02:00
metalgearsloth 3fd2abe685
Revert "Make wearing an Ushanka also apply accent to your name" (#29524)
Revert "Make wearing an Ushanka also apply accent to your name (#29111)"

This reverts commit e5a85e2a1359968ab71c4bcd79bfc834a8b3cb5a.
2024-07-25 01:51:37 +02:00
Pieter-Jan Briers cd95737190
Remove placing items on tabletop boards. (#29513)
This feature should never have been merged, it can be trivially abused to break the entire server.

It's behind a CVar because honestly that's the easiest way to 1984 the feature.
2024-07-25 01:50:55 +02:00
Partmedia 501a19be82
Increase lockout threshold (#29504) 2024-07-25 01:50:53 +02:00
Doomsdrayk 6eeb96e202
Fix disposals being effective nuclear bunkers (#29438)
Make disposals report their contents to the explosion system
2024-07-25 01:50:47 +02:00
Chief-Engineer cdb2802449
Alert shared connections (#29405)
* add admin alert for active shared connections

* update wizden config

* review
2024-07-25 01:50:32 +02:00
Tayrtahn 4fdff38655
Forcemap can be cleared with empty string again (#29472) 2024-07-25 01:47:38 +02:00
Pieter-Jan Briers 82db337c62
Revert "TEG can power itself when turned on" (#29434)
Revert "TEG can power itself when turned on (#29072)"

This reverts commit 9f9cf08d722d203baf0e6ddcf59b90c40fa40a32.
2024-07-25 01:46:28 +02:00
Tayrtahn bfa62f664a
Fix forcemap not bypassing requirements (#29426)
* Fix forcemap not bypassing requirements

* Add integration test for forcemap
2024-07-25 01:46:16 +02:00
Chief-Engineer d0838c4f55
Use moderator perms for grant_connect_bypass (#29406)
use moderator perms for grant_connect_bypass
2024-07-25 01:46:08 +02:00
ArkiveDev 36047ac7f4
Force map confirmation (#29391)
* Add map check to forcemap command

* remove debug line

* remove accidental newline
2024-07-25 01:45:20 +02:00
Tayrtahn aff298aac7
Fix unlabeled jugs in ChemVend (#29178)
* Spawn dummy entities on client for vending machine UI

* Asked sloth, and we kinda need this pr

---------

Co-authored-by: Vasilis <vasilis@pikachu.systems>
2024-07-25 01:45:05 +02:00
mhamster 589be346da
ContainmentFieldComponent's garbage destruction can now be disabled (#29376)
* Garbage Vaporizer 3000

+ DestroyGarbage bool property
+ DestroyGarbage property check when dealing with incoming trash

* Update ContainmentFieldComponent.cs

Co-authored-by: Tayrtahn <tayrtahn@gmail.com>

---------

Co-authored-by: Tayrtahn <tayrtahn@gmail.com>
2024-07-25 01:44:32 +02:00
WarMechanic bc3b04f919
TEG can power itself when turned on (#29072) 2024-07-25 01:40:31 +02:00
Partmedia ae8f9ef9bd
Add air alarm hysteresis (#29223)
Add firelock hysteresis
2024-07-25 01:39:30 +02:00
deltanedas 4a76d9a6df
add access reader log wire (#29094)
* add LoggingDisabled to AccessReader

* add LogWireAction

* -m give everything besides high-security door a log wire

* make LogAccess public and support string arg

* add log when pulsing

* m

* l

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-07-25 01:39:25 +02:00
Nemanja 6f9fa74f8f
AME Deconstruction Changes (#29317)
* AME deconstruction complexity

* review

---------

Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2024-07-25 01:38:45 +02:00
null 402af3cf88
Fix more funnies 2024-07-25 01:38:38 +02:00
Null 3d5955f265
Merge pull request #1494 from DeltaV-Station/guidebook-rules
Delta-V Guidebook Rules
2024-07-25 01:19:26 +02:00
Nemanja e057218952
Machine-code cleanup (#28489) 2024-07-25 01:11:54 +02:00
Pieter-Jan Briers e92d9031b3
Rewrite the options menu (#28389) 2024-07-25 00:56:15 +02:00
nikthechampiongr 7f6d04b7d3
Implement BlacklistedRange exempt flag (#29258)
* Implement a new kind of ip range ban that only applies to new players

* Put determining whether a player record exists to its own function

* Make BlacklistedRange bans get bypassed by any ban exemption

* Stop trying to get another DbGuard while already having one

This does break with convention on the functions in that area but
considering the use of this function it's probably fine?
I could alternatively just move the place it's called from.

Also I was suppossed to wait for tests to finish locally just to be
sure, but nah. I am pushing this now
2024-07-25 00:40:24 +02:00
slarticodefast 995e64fabc
fix initial infected icons and add a briefing to the character menu (#29259) 2024-07-25 00:39:38 +02:00
Tayrtahn 4866f1aaea
Replace BlockSolutionAccessComponent with an attempt event (#26988)
* BlockSolutionAccessComponent now only blocks one specified solution.

* Significant overhaul
Separated spilling when worn functionality into its own component/system.
Removed BlockSolutionAccessComponent.
Added an event for solution access.
2024-07-25 00:39:35 +02:00
Tayrtahn a666b6bc98
Fix null exceptions in SurveillanceCameraMonitorSystem (#29275)
* Add IsNullOrEmpty checks before indexing KnownSubnets

* actor
2024-07-25 00:39:31 +02:00
Pieter-Jan Briers 01ecd1d28b
Rate limit ahelps (#29219)
* Make chat rate limits a general-purpose system.

Intending to use this with ahelps next.

* Rate limt ahelps

Fixes #28762

* Review comments
2024-07-25 00:38:40 +02:00
Mr. 27 b7f4740a95
Fix ERT becoming sleeper agents and add sleeper agent preferences (#27817)
* b

* Update antags.ftl

* m

* ok

* Update events.yml

* antag

* a

* Create InitialInfectedExemptComponent.cs

* Delete InitialInfectedExemptComponent.cs

* yes

* Delete InitialInfectedExemptComponent.cs

* Create AntagImmuneComponent.cs
2024-07-25 00:36:58 +02:00
Alice "Arimah" Heurlin af767099db
Prevent fly-by fixture from powering containment field generator (#29225)
* Prevent fly-by fixture from powering containment field generator

* Update according to review
2024-07-25 00:34:51 +02:00
Leon Friedrich d0a8d88e78
Partial buckling refactor (#29031)
* partial buckling refactor

* git mv test

* change test namespace

* git mv test

* Update test namespace

* Add pulling test

* Network BuckleTime

* Add two more tests

* smelly
2024-07-25 00:34:37 +02:00
Tayrtahn 7819e9f251
Code cleanup: radio jammer (#29052)
* Code cleanup for radio jammer

* More Entity<T> for the people, and fix an accidental variable reuse
2024-07-25 00:34:34 +02:00
Tayrtahn 0cd2bdf33b
Add prediction for Tech Disks, cleanup (#29061)
* Add prediction for Tech Disks, cleanup

* Remove IsServer check in OnMapInit

* Use HashSet for techs, remove LINQ
2024-07-25 00:34:28 +02:00
Truoizys 084023c46b
Fixed cartridges installing more than once (#29187)
* fixed cartridges installing more than once

* replaced prototypes with CartridgeComponent

* relocated checks from InstallProgram to InstallCartridge
2024-07-25 00:30:38 +02:00
Rouge2t7 b0f5f9a096
PullingController cooldown change (#29177)
* Revert "Automatic changelog update"

This reverts commit 3358aef40f2b5525ec15e6ce01533b4e8c2ddfc9.

* Revert "Revert "Automatic changelog update""

This reverts commit 3d0b6a7ade06ec555d4f6df3f39134b139e5247c.

* Removal of the throw cooldown as it felt sluggish and unresponsive before.
2024-07-25 00:27:25 +02:00
osjarw 44533ce100
Fix air alarms (#29172)
Broken by #28272
2024-07-25 00:26:26 +02:00
null 61244f8a2f
Fix oopsie 2024-07-25 00:23:07 +02:00
metalgearsloth 96bb678c3d
Replace StationRandomTransform (#29149)
* Revert "Rotate and Offset station CCVar nuke (#26175)"

This reverts commit 44b20f60ff178813ebbc5b449229b0bbba81f649.

# Conflicts:
#	Content.Server/Station/Systems/StationSystem.cs
#	Resources/Prototypes/Maps/europa.yml

* Fix

* Review
2024-07-25 00:19:04 +02:00
metalgearsloth 8781146785
Fix conveyor mispredicts (#28157)
* Fix conveyor mispredicts

Instead of tracking active conveyors we instead track the conveyed entities. This also handles things like stacking conveyors more gracely.

* Fix ActiveConveyor

* Fix lerping
2024-07-25 00:18:40 +02:00
DrSmugleaf 8a1fe36766
Add cvar to disable round end pvs overrides (#29151) 2024-07-25 00:18:11 +02:00
Ed ac3f6eb2b6
clean up weather systems (#28792)
* clean up weather systems

* Update WeatherComponent.cs

* Update SharedWeatherSystem.cs

* some fix

* Update SharedWeatherSystem.cs

* Update WeatherComponent.cs

* Update WeatherComponent.cs

* revert autoPause

* Update SharedWeatherSystem.cs
2024-07-25 00:18:03 +02:00
Tayrtahn c8b1bc03c2
Make wearing an Ushanka also apply accent to your name (#29111) 2024-07-25 00:17:54 +02:00
deltanedas 7154d3039b
remove robotics console emag checking, make it a bit fairer (#27876) 2024-07-25 00:17:37 +02:00
Partmedia e92691eb54
Fix incorrect use of atmos dt (#29112) 2024-07-25 00:17:25 +02:00
Tayrtahn 26417d4627
Add a system for modifying entity names without causing conflicts (#27863) 2024-07-25 00:17:01 +02:00
Leon Friedrich 2b69697576
Fix RotateWhilePulling not working (#29032) 2024-07-25 00:15:37 +02:00
DrSmugleaf 7e0cad960b
Add cvar to disable ghosting killing your crit mob (#28945)
* Add cvar to disable ghosting killing your crit mob

* Update Content.Shared/CCVar/CCVars.cs

Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
2024-07-25 00:14:25 +02:00
Nemanja c83d93e461
Add moon boots (#29009) 2024-07-25 00:14:05 +02:00
Nemanja a3dd51194a
Slightly speed up borgsystem module check (#29070) 2024-07-25 00:08:37 +02:00
Nemanja 608f196845
fix exclusive borg module bug (#29038) 2024-07-25 00:08:30 +02:00
null ed71a646e3
Merge remote-tracking branch 'refs/remotes/upstream/master' into 2024/07/05-upstream-merge
# Conflicts:
#	Content.Shared/Chemistry/EntitySystems/SolutionTransferSystem.cs
2024-07-25 00:07:10 +02:00
deltanedas 8588bb0e0d
glacier real (#1169)
* glacier real

* troll

* atmosia tweaks

* 1 less can of plasma not too op

* replace troll generator with solar crate

* add StationSurface to glacier

* add surface map

* biome stuff upstream #28017

* unpause after loading

* fix no terrain

* comment out the surface spawning

* shipyard

* glacier justiceroid

* updateprototype and cleanup

* fix random shit

* untroll

* courier

* add to test :trollface:

* fix

* futureproofing

* hot loop inlet lmao

* tweak some pumps in atmosia

* carpy and make salv locker lighting better

* Edit lights, move salv dock, add justice maints, edit entity names for casing consistency, other minor edits

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
Co-authored-by: Velcroboy <velcroboy333@hotmail.com>
2024-07-17 11:39:09 -05:00
AJCM-git 1feab1d091
Fixes client having authority over rules popup cvars (#28655)
* Fixes client having authority over rules popup cvars

* Delete duplicate migration

* Pre-update

* Post-update

(cherry picked from commit 63e0ee08cb50dbd937e11ab1e965b5f79aae134d)
2024-07-13 04:21:16 +02:00
Leon Friedrich eee3cb04d3
Give jobs & antags prototypes a guide field (#28614)
* Give jobs & antags prototypes a guide field

* A

* space

Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>

* Add todo

* Fix merge errors

---------

Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>

(cherry picked from commit e7f2ae52ab24dddc8f3c94cb84b751482700e3da)
2024-07-13 04:20:47 +02:00
Nemanja be014df4b7
Convert rules to use guidebook parsing (#28647)
(cherry picked from commit 1333b48747ae62c7b3ecb809b897201a24fe4441)
2024-07-13 04:18:15 +02:00
deltanedas 4237fc9a2b
add syndicate recruiter midround event (#1345)
* add SignAttemptEvent and minor signature refactor

* add recruiter pen

* add the recruiter ship

* add recruiter antag and event

* fixes

* real

* bad popup spam

* more fix

* fix blood visual maybe

* fix greentext

* more fixy

* fix fill state not being coloured

* give btamp instead of paper in pocket 2

* f

* brighter filled state

* fix greentext

* fix error on spawn

* pro

* prevent using a syringe to inject anything into the pen

* update stuff after upstream merge

---------

Signed-off-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-07-09 12:48:03 +02:00
WarMechanic 711dd04ab6
Unique glove fibers (#1455)
* make changes

* comments

* commiting a single whitespace so i dont get executed

---------

Co-authored-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
2024-07-08 16:12:11 +02:00
icekot8 d295fe7d8d
add 👷 JobCondition system for reagents (#29023)
* hell 💀

* you're right

i'm dumb

* use the beautiful protoid and or in localization 🥩

* 🙏
2024-07-05 20:37:55 +02:00
Partmedia 012e6a7334
Adjust TEG efficiency curve, remove heat transfer limit (#29050)
The TEG used to limit hot-cold energy transfer based on actual power drawn, and had maximum efficiency at whatever temperature difference. This PR adjusts the hot-cold energy transfer to be uncapped, "venting" the excess heat that is not used to generate power, and adds an efficiency curve that limits efficiency at low thermal temperatures.

People have been cheesing the TEG by hooking up the hot end to the CO2 miner (which produces infinite, room-temperature gas) and the cold end to a space radiator.

With this change, you will actually need to set up a burn chamber in order to get appreciable power out of the TEG (see below).

If you build a gas holding chamber, you will have to throttle the gas flowing into the TEG instead of constantly cycling the gas through over and over again.
2024-07-05 20:37:40 +02:00
BombasterDS 530f98369f
Mannequin (#29004)
* Mannequin

* rsi license fix

* damage container fix

* container fix

hope this works

* layers fix + appearance comp (mb it help?)

* maybe fixed?

* one day it will work...

* can't even understand why test failing... (maybe fix?)

* last try?
2024-07-05 20:37:36 +02:00
ShadowCommander ac381dc2d3
Make firelock warning light not require power and add a PointLight (#29024)
* Add a PointLight to firelocks when warnings are active

* Remove power requirement for lights
2024-07-05 20:37:28 +02:00
Nemanja 04736e9413
fix borgs getting deleted by salvage magnets (#29006) 2024-07-05 20:37:18 +02:00
metalgearsloth 568f8d9c0f
Don't use invalid defaults for loadouts (#28740)
* Don't use invalid defaults for loadouts

At the time it made more sense but now with species specific stuff it's better to have nothing.

* Loadout SetDefault only applies valid loadouts
2024-07-05 20:37:03 +02:00
Robert V 49fd5c2b58
Allow vending machines to be repaired (#28920)
Vending machines can be repaired
2024-07-05 20:34:38 +02:00
Verm e2428b2189
Donk co. microwave + microwave tweaks (#28951)
* THE syndie microwave

* Always burn to explode microwave when copying

* Make it so copying ids stop when the microwave is goign to explode

* Made explosion destroy the board and spit out the machine parts

* Move logic is MicrowaveSystem, make metal cooking use the same logic

* Fix passing the wrong malfunction time

* Shuttle cannot escape aggressive branding

* Always make it explode with an id

* Forgot to invert bool, move it after fry chance
2024-07-05 20:34:35 +02:00
Plykiya 712dcc3299
Prevent borgs from getting duplicate modules (#28943)
* Prevent borgs from getting duplicate modules

* outta the loop

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-07-05 20:34:31 +02:00
Zonespace d0a61bbfc6
Replaces reagent-effect-guidebook-missing with more descriptive guidebook entries (#28817)
removes `reagent-effect-guidebook-missing`

Co-authored-by: John Doe <johndoe@gmail.com>
2024-07-05 20:34:28 +02:00
Zonespace 1b216bc3c5
Non-uplink PDAs no longer can have TC inserted into them (#28985)
* PDAs no longer can have TC inserted into them

* far better way of doing this

---------

Co-authored-by: John Doe <johndoe@gmail.com>
2024-07-05 20:32:40 +02:00
Hannah Giovanna Dawson 1e676e1e55
SS-28662 Add cvars to support forcing people to departures and making those at departures invincible (#28765)
* SS-28662 Add cvar to force spawn everyone at departures

This cvar means everyone must spawn at departures. This
could be handy for an admin event? But mostly it's so the
tutorial departures terminal can be seen by all newbies on
gateway servers.

* Small fix to ArrivalsSystem flow

* Remove incorrect todo

* Add godmode arrivals cvar
2024-07-05 20:32:35 +02:00
Tayrtahn 41e409d45e
Move SleepingSystem to Shared & cleanup (#28672)
* Move SleepingSystem to Shared & cleanup

* Remove empty OnShutdown handler
2024-07-05 20:31:59 +02:00
Cojoke e2122a04ed
Lasers passover objects like projectiles unless the target is clicked on (#28768)
* uh...

* fix

* alright, there we go

* Revert "alright, there we go"

This reverts commit 448180bfa58cc24c42a4d59ef34c017b9941f37b.

* Make lasers not hit certain objects and lying mobs unless clicked on

* comment

* Update Content.Server/Weapons/Ranged/Systems/GunSystem.cs

* an l vanished?

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
2024-07-05 20:29:00 +02:00
osjarw 2746025cc6
Nodescanner now works with right click (#26873) 2024-07-05 20:28:57 +02:00
MjrLandWhale f047b1f39b
Override under-pressure lock-out in air alarm "Fill" mode (#28909) 2024-07-05 20:28:14 +02:00
lzk ba716ffd20
Add order quantity to cargo invoice label (#28821) 2024-07-05 20:28:09 +02:00
Nemanja 8c7ccb94bf
Fix construction rotation (#28427) 2024-07-05 20:28:05 +02:00
ShadowCommander db8bc652f1
Fix playtime on player tab getting set to Unknown (#28876)
Update play time on admin panel player tab after db loads
2024-07-05 20:27:59 +02:00
Leon Friedrich dfbcd93745
Fix `playtime_addrole` command printing the wrong time (#28783) 2024-07-05 20:27:53 +02:00
deltanedas 1a286fb1a3
localize RoleBriefing (#28824)
Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-07-05 20:27:47 +02:00
Plykiya b1bdcc7161
Fix gauze stopping if it stops bleeding (#28844)
delete a line

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-07-05 20:27:33 +02:00
Stalen fe0a8341f1
Pets toggle internals fix (#28904) 2024-07-05 20:27:12 +02:00
Verm a70a3140d1
Make automatic gasps not create a chat message (#28907)
No chat gasp
2024-07-05 20:27:09 +02:00
Partmedia 0662237bac
Update PA admin warnings (#28911)
With singulo fixed, PA strength 3 and below (level 2) are now safe.
Update the admin logging to reflect this.
2024-07-05 20:27:06 +02:00
Partmedia 13f88e6ba8
Fix queued deletion check (singulo loosing at beyond PA 1 but only on live servers) (#28906)
Fix queued deletion check
2024-07-05 20:26:58 +02:00
dragonryan06 e77f2a23c2
Add new icon for Remove Evidence verb (#28898) 2024-07-05 20:26:54 +02:00
Robert V 8d29ece4a5
Comms Consoles without CanShuttle can no longer recall (#28803)
Consoles without CanShuttle can no longer recall
2024-07-05 20:26:39 +02:00
Tayrtahn bee3ac504c
Fix nearest beacon messages reporting the opposite direction (#28869)
* Fix nearest beacon messages reporting the opposite direction

* Lets document that method, shall we?
2024-07-05 20:26:23 +02:00
lzk b6d0c0d81e
Add reward line in bounty label (#28853) 2024-07-05 20:26:17 +02:00
Hannah Giovanna Dawson 3a50288e50
Panic Bunker uses minutes not hours (#28805)
* Panic Bunker uses minutes not hours

* Fixing an instance of hours
2024-07-05 20:24:14 +02:00
Julian Giebel ca5de48084
Implement map text (#28705) 2024-07-05 20:23:41 +02:00
Hannah Giovanna Dawson 1cee444776
SS14-28662 Add Baby Jail: a Jail for Babies (inverse panic bunker) (#28763) 2024-07-05 20:23:37 +02:00
Leon Friedrich b12e3f838f
Make `MakeAntag()` log errors instead of throwing exceptions (#28771)
Make `MakeAntag()` log errors instead of throw
2024-07-05 20:22:37 +02:00
Tayrtahn 5e2e85fbd4
Fix null ref exception in PrayerSystem (#28712)
* Fix null ref exception in PrayerSystem

* Also check that prayable ent/comp still exist
2024-07-05 20:21:45 +02:00
deltanedas 4ae20967a6
fix shipyard (#1458)
Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-07-03 15:34:06 +00:00
Null 5568ddf24f
Log giving items to the Oracle or Butlertrol (#1450)
Log oracle and Roboisseur sells
2024-07-01 21:59:16 +00:00
Null ee4dd88a53
Revert "Nyano port of digging (#400)" (#1452)
This reverts commit 089398d2
2024-07-01 21:57:16 +00:00
Bellwether 36695a3872
Add "Subpoenaed" status for SecHud and Criminal Records Computer (#1405)
* Add "Subpoenaed" to the SecHud and Criminal Records Computer

* Update Content.Server/CriminalRecords/Systems/CriminalRecordsConsoleSystem.cs

Co-authored-by: Colin-Tel <113523727+Colin-Tel@users.noreply.github.com>
Signed-off-by: Bellwether <157836624+BellwetherLogic@users.noreply.github.com>

* Update Resources/Locale/en-US/criminal-records/criminal-records.ftl

Co-authored-by: Colin-Tel <113523727+Colin-Tel@users.noreply.github.com>
Signed-off-by: Bellwether <157836624+BellwetherLogic@users.noreply.github.com>

* Moved and commented files as requested, redesigned icon due to avoid Syndicate lookalike

* moved some .ftl business so it's properly commented

* Attempting to slay a rogue byte order mark

* necromancy upon falsely slain byte order mark

* Moving things into DeltaV namespace

---------

Signed-off-by: Bellwether <157836624+BellwetherLogic@users.noreply.github.com>
Co-authored-by: Bellwether <null>
Co-authored-by: Colin-Tel <113523727+Colin-Tel@users.noreply.github.com>
2024-07-01 21:50:51 +00:00
deltanedas bee11f3a16
add glimmer wisp (#1383)
* add sacrafice/drain sound

* refactor glimmer event yml + uncomment wisp + make mites scale at lower glimmer

* remove glimmer wisp rule and make GlimmerMobRule much more flexible + better

* add LifeDrainer code that wisp uses

* add ai primitives and compounds

* add glimmer wisp

* a

* fixes

* add wisp texture

* desc

* add sounds

* buff so you cant literally 2 shot it with bible

* make it harder to kill but drop more ectoplasm

* make it work properly

* let it use zap in combat i hope

* add glimmer creatures guidebook

* test

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-07-01 22:05:56 +02:00
deltanedas 540febcbad
fugitives redux (#1413)
* add fugitive rule logic

* add fugitive role

* add fugitive event

* remove nyano spawner and make midround antag spawner work real

* fix announcement logic

* fix the funny bug i think

* fix crimes

* fix crime count

* 1 less min crime

* fix sex (real)

* thief bag unhardcode MaxSelectedSets

* :trollface:

* :trollface:

* add fugitive stash

* fix

* add misc stuff and fugitive stash

* m

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-06-30 19:40:33 +00:00
deltanedas 78cc6939bc
paradox code cleanup (#1411)
* remove unused terminator code

* remove genericantag usage, put everything on the real rule

* hide spawner from spawn menu

* remove terminator locale

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-06-30 19:34:48 +02:00
deltanedas b7b41b38bb
Centcomm justice update (#1352)
* centcom legal update

* centcom beacons maps vendis update

* put centcomm in DeltaV folder

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-06-19 16:48:59 +02:00
deltanedas 8ee5babbea
fix reveng troll (#1376)
Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-06-13 20:32:19 +00:00
Milon 8ba21594f7
rename glimmershow (#1365)
* rename glimmershow

* grrr...
2024-06-13 18:41:55 +02:00
deltanedas 5e812e0f27
listening post rewrite (#1369)
* rename pirate radio map to listening post, change spawner prototype

* refactor pirate radio spawn rule into DebrisSpawner and LoadFarGrid

* remove obsolete yml

* -m make listening post rule use new stuff and antag selection

* other changes

* fixes

* more

* fixy

* fix nan

* final fix

* what

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-06-13 18:40:41 +02:00
Scribbles0 6efdbf66c9
Unrevivable trait (#24226)
* unrevivable trait + remove unclonable remnants

* cleanup

* change to hascomp
2024-06-08 20:47:28 +02:00
null 303e71d84c
Some code fixes 2024-06-08 20:37:53 +02:00
nikthechampiongr aa1fd64b44
Make freeze, freeze & mute, and unmute verbs work on disconnected players. (#28664) 2024-06-08 20:31:53 +02:00
DrSmugleaf c75ac999fa
Fix DamageOtherOnHit.OnDoHit when the target is terminating or deleted (#28690) 2024-06-08 20:31:03 +02:00
Lyndomen 3d56f8dfd5
Dropping Corpses Devoured by Space Dragons on Gib/Butcher. (#28709)
* Update DevourSystem.cs

* Update DevourSystem.cs

* Update Content.Server/Devour/DevourSystem.cs

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
2024-06-08 20:30:58 +02:00
DrSmugleaf 58e1b529fe
Add DoPopup data field to OnUseTimerTrigger (#28691) 2024-06-08 20:30:56 +02:00
Plykiya 48534934bd
Swap some InRangeUnobstructed for InRangeUnoccluded (#28706)
Swap InRangeUnobstructed to InRangeUnoccluded

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-06-08 20:30:39 +02:00
Leon Friedrich b45a42f353
Add JobRequirementOverride prototypes (#28607)
* Add JobRequirementOverride prototypes

* a

* invert if

* Add override that takes in prototypes directly
2024-06-08 20:30:16 +02:00
Plykiya b702d3b466
Internals are kept on as long as any breathing tool is on (#28595) 2024-06-08 20:24:22 +02:00
Tayrtahn b693a16b93
Add support for LocalizedDatasets to RandomMetadata (#28601) 2024-06-08 20:24:12 +02:00
ShadowCommander f4fecc9882
Add logs that provide session to player admin logs (#28628) 2024-06-08 20:19:42 +02:00
Leon Friedrich e0ea8adb9a
Add Job preference tests (#28625)
* Misc Job related changes

* Add JobTest

* A

* Aa

* Lets not confuse the yaml linter

* fixes

* a
2024-06-08 20:19:39 +02:00
Plykiya c17df36cf6
Remove obsolete VisibilitySystem functions (#28610)
Remove obsolete visibility functions

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-06-08 20:17:17 +02:00
blueDev2 5f134731d9
Microwave recipes now uses stacktype id instead of entity prototype id for stacked entities (#28225) 2024-06-08 20:17:01 +02:00
icekot8 fe16eb1cd4
hand teleport portals now may start in the same grid. (#28556) 2024-06-08 20:16:59 +02:00
Kevin Zheng 67c27e351e
Add CVar to disable pow3r parallel processing (#28488)
* Add CVar to disable pow3r parallel processing

* Cache CVar value

* Fix pointyhat

* Move all CVar-ing to Content.Server
2024-06-08 20:16:21 +02:00
Hannah Giovanna Dawson 2bf0e82b7a
SS14-26964 Clown Waddling Replicates, etc (#26983) 2024-06-08 20:15:12 +02:00
deltanedas ce5bfe3f55
LoadMapRule grid storage rework (#28210)
*
2024-06-08 20:14:24 +02:00
Verm dec7298e6f
Humans can no longer honk on command (#28566)
* Humans can no longer honk on command

* Undo change it emote file

* I hate tabs

* Some comments
2024-06-08 20:13:45 +02:00
null 993959ae58
Replace deprecated whitelist functions 2024-06-08 20:12:43 +02:00
Plykiya 6583105f10
Replace obsolete EntityWhitelist IsValid usages part 2 (#28506) 2024-06-08 20:03:26 +02:00
Verm 5ec48e7784
Fix Weh Juice and Other emote chems not working (#28562) 2024-06-08 20:03:01 +02:00
Ed 667d1d5941
Accent trait limit (#28046) 2024-06-08 20:02:27 +02:00
Tayrtahn 7b506a05cf
Add a test for sliceable cargo bounty exploits (#28357) 2024-06-08 19:59:33 +02:00
AJCM-git 426896a432
Cleans up StatusIconSystem and fixing some bugs (#28270) 2024-06-08 19:59:10 +02:00
Leon Friedrich 316c8064db
Try fix KeyNotFoundException in KillTrackingSystem (#28553) 2024-06-08 19:58:52 +02:00
deltanedas 64329d6173
prevent nukie kidnapping (#28387) 2024-06-06 22:00:51 +02:00
AJCM-git 5c140c2095
Strip Items From Things Before Biomassing Them (#28544) 2024-06-06 21:59:38 +02:00
Verm 22c7f4e610
Welding tweaks (#27959) 2024-06-06 21:59:35 +02:00
AJCM-git d94a7bb8a0
RespawnRuleSystem tweaks. (#28528) 2024-06-06 21:58:20 +02:00
Voomra 983cdb2fa7
fix: localize PraySystem UI (#28535)
tweak: localize PraySystem UI
2024-06-06 21:54:32 +02:00
UBlueberry 92da2ec1ee
Drawl capitalization coldfix (part 2: rise of accidentally commiting to master) (#26639)
fixed finally yay
2024-06-06 21:54:02 +02:00
Errant ffbaeb0dee
Beacons no longer glitch off on grid split (#28518) 2024-06-06 21:53:58 +02:00
Leon Friedrich fcb6ce0b5b
Add debug asserts to ensure that network groups are up to date (#28495) 2024-06-06 21:47:13 +02:00
slarticodefast 7f5be661f8
Flash overlay rework and bugfixes (#27369) 2024-06-06 21:46:58 +02:00
Leon Friedrich 0f8b1bbde5
Content changes for entity categories PR (#27232)
* Content changes for entity categories PR

* Poke tests

* Why are tests suddenly working?
2024-06-06 21:44:49 +02:00
eoineoineoin c62bd23656
Replace Matrix3 with System.Numerics.Matrix3x2 (#27443)
Replace Matrix3 with Matrix3x2
2024-06-06 21:44:48 +02:00
Plykiya b2931f9a33
Replace obsolete EntityWhitelist IsValid usages (#28465)
* Replace obsolete whitelist is valid with whitelist system

* Consistency

* Fix logic

* Bork

* I figured out how to get whitelists on the client lol

* test fail

* woops

* HELP ME FUNCTIONS

* Fix errors

* simplify

---------

Co-authored-by: plykiya <plykiya@protonmail.com>
2024-06-06 21:44:41 +02:00
null f8746e20f2
Clean RES.Pacified a bit 2024-06-06 21:36:31 +02:00
Tornado Tech 91f0ba53e5
Cleans up tag system (#28272)
* Updated tag system

* Added params methods

* Fixed tag integration tests

* Fixed params methods recursion

* Revert has All/Any tag one argument realisation

* Updated tag integration tests

* Shit happens

* Added individual List/HashSet methods, docs, tests
2024-06-06 21:33:38 +02:00
Tornado Tech 228e653572
Hiding and clearing department prototype code (#28114) 2024-06-06 21:33:27 +02:00
AJCM-git ab59cfea40
Makes machine parts stackable, removes unused field in stack prototypes (#28434)
* Makes machine parts stacks, removes unused field in stack prototypes

* forgor

* Fix tests

* Fixes lathe construction. Yes. This sucks but there's no better way that doesnt involve refactoring machine parts completely

* detail

* a
2024-06-06 21:29:09 +02:00
Tornado Tech 39650620e2
Clean up new HTNs tasks (#28469)
* Clean up new HTNs tasks

* Added docs to math operations
2024-06-06 21:29:07 +02:00
Nemanja 5e39323307
Clean up store system (#28463) 2024-06-06 21:28:46 +02:00
deltanedas 708e17a3d3
reverse engineering refactor and missing recipe test (#1230)
* make jugg not atmos hardsuit reable lmao

* re machine yaml refactor

* use the enum name to localize re results

* move a lot of code to shared and refactor

* clientside rework

* add test for missing recipes

* untroll

* make exped board recipe yml consistent with upstream

* fix unearthed sneaky bugs + generic does nothing so remove

* add mass media console board, remove roundstart boards from dynamic recipes

* remove roundstart stuff, add rcd ammo to protolathe

* dont dupe because of access electronics prototypes

* fix final fails

* final untroll

* final untroll 2

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
Co-authored-by: Null <56081759+NullWanderer@users.noreply.github.com>
2024-06-01 21:31:06 +00:00
DrSmugleaf eed9c58386
Add job whitelist system (#28085)
* Add job whitelist system

* Address reviews

* Fix name

* Apply suggestions from code review

Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com>

* cancinium

---------

Co-authored-by: Pieter-Jan Briers <pieterjan.briers@gmail.com>
2024-06-01 18:02:43 +02:00
Nemanja 19eefe623d
Clean up command perms (#28451)
* Change BanExemption command to AdminFlags.Ban permissions

* Change LOOC to check for Moderator permission

* Change ListVerbs from Admin to Debug AdminFlags

* Change RunVerbAs from Admin to Fun AdminFlags

* More permission changes

* Change GhostKick to Moderator perm

* Clean up command perms

* fuck

---------

Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
2024-06-01 18:01:58 +02:00
Geekyhobo f7581b1f21
Adds a Pii Flag, Censors Hwid and Ip (#27776)
* yes

* fixes
2024-06-01 18:00:39 +02:00
beck-thompson 1d5827960f
Added verb for removing evidence! (#28101) 2024-06-01 18:00:22 +02:00
Verm fe3892977d
Randomizes more humanoid appearances (#27997) 2024-06-01 18:00:15 +02:00
Nemanja bacd52c991
Decouple interactions from hands, cleanup old events, add new fears (#28393)
* ok basic shit

* second part

* pretend it isn't real it can't hurt you.

* 👁️ 👁️

* shadowcommander review
2024-06-01 18:00:07 +02:00
Leon Friedrich 6427cc560e
Make chat & examine systems use FormattedMessage.EscapeText() (#28431) 2024-06-01 18:00:05 +02:00
Flesh f58fe5aaeb
Use existing probability field (#28422)
Remove the PlantAdjustAttribute "Prob" field and use the existing probability field from ReagentEffects instead.
2024-06-01 17:59:52 +02:00
Leon Friedrich c7c2c03be8
Fix hugging mispredict (#28432)
* git mv

* Move namespaces

* Fix hugging mispredict
2024-06-01 17:59:47 +02:00
deltanedas ecc9fbfe42
dragon antag refactor (#28217)
* remove dragon system usage of GenericAntag

* add AntagRandomSpawn for making antags spawn at a random tile

* add AntagSpawner to make an antag spawner just spawn an entity

* add antag prototype for dragon since it never had one

* make dragon spawner a GhostRoleAntagSpawner, remove GenericAntag

* make dragon rule use AntagSelection and stuff

* remove dragon GenericAntag rule

* add back to spawn menu

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-06-01 17:59:40 +02:00
Leon Friedrich 078794106e
Make tests automatically reset modified cvars (#28219)
* Make tests automatically reset modified cvars

* Fix bad return

* A

* Try Fix tests

* clarify comment

* update eng
2024-06-01 17:56:33 +02:00
Leon Friedrich 65a712700c
Only auto-enable internals when necessary (#28248)
* Only auto-enable internals when necessary

* Add toxic gas check

* Rename Any -> AnyPositive
2024-06-01 17:55:05 +02:00
Nemanja d1371865f1
Fix latejoin antag preferences not being respected (#28430)
* Fix latejoin antag preferences not being respected

* thank fuck for tests
2024-06-01 17:55:00 +02:00
Moony 56be0e1ee8
Handheld teleporter portals now must start on the same grid. (#28423)
Co-authored-by: moonheart08 <moonheart08@users.noreply.github.com>
2024-06-01 17:54:42 +02:00
Tayrtahn 2a56896045
Convert advertisements to use localized datasets (#28400)
* Convert advertisements to use LocalizedDatasets

* File consolidation

* Arcade machines too
2024-06-01 17:41:58 +02:00
Ed 7d53001a0e
Localize tips (#28285)
* localize tip

* localizzedDataset
2024-06-01 17:41:48 +02:00
metalgearsloth 4755223c9f
Predict ActivatableUIRequiresPower (#28405)
A lot of BUIs aren't going to handle the state coming in cleanly but we can fix em as we find em.
2024-06-01 17:38:43 +02:00
ShadowCommander ebddaa8e3d
Move ApcPowerReceiverComponent Powered state to shared (#28206)
* Try syncing powered state to client

For some reason the client is not receiving the ApcPowerReceiverComponentState, so it's not working.

* Fix powered state not syncing to client

The client PowerReceiverSystem was abstract, which prevented it from
running initialize.

* Flip check so that it runs bigger checks first

PowerDisabled skips the others.
NeedsPower skips the receiving check.

* Disallow changing Powered manually

* Move Powered update to PowerReceiverSystem

* Move appearance to event subscription

* Move metadata component to AllEntityQuery

* Cleanup

* Move Powered update back to PowerNetSystem

It's easier to use the EntityQueries and it dosen't need to be updated
anywhere else.

* Put appearance updating back

* Move IsPowered to shared

* Simplify IsPowered

* Cleanup

* Remove duplicate PowerChangedEvent

PowerChangedEvent on ProviderChanged doesn't seem to be needed
PowerChangedEvent gets raised by in update if the power state changes
after a new provider is connected
2024-06-01 17:38:41 +02:00
blueDev2 9f21df293f
Fixed hypo and injector entities going into disposal units (#28317) 2024-06-01 17:38:38 +02:00
Kevin Zheng 6714823ef6
Fix flow rate display (#28372) 2024-06-01 17:19:56 +02:00
deltanedas 819c173308
item cabinet rework + stuff (#26779) 2024-06-01 17:19:54 +02:00
metalgearsloth 1f5f2cfe45
Block gas analyzer updates if the UI doesn't open (#28376)
Fixes the gas analyzer UI coming up when used with a target.
2024-06-01 17:19:47 +02:00
Nemanja 0a686ec58e
Clean up RefiningSystem (#27904)
cleanup RefiningSystem
2024-06-01 17:19:45 +02:00
metalgearsloth b35c987322
Fix shuttle audio clipping (#27527)
Changed engine to use grid local-center and very high maxdistance / refdistance values so it's seamless.
2024-06-01 17:19:33 +02:00
Kevin Zheng a6e4fd4c7a
Tune spacing speed to fix under-pressure lockout (#28370) 2024-06-01 17:19:28 +02:00
metalgearsloth da6ab10cb3
Don't update APC states unless UI open (#27803) 2024-06-01 17:19:23 +02:00
lzk 16c0dae7cb
Remake gasp popup to emote (#27736) 2024-06-01 17:19:16 +02:00
Repo ea2668ff37
Fix late join & observe to de-admin admins. (#28319) 2024-06-01 17:18:14 +02:00
deltanedas a14aed3fca
missing nukies can be filled in by ghost roles (#28316) 2024-06-01 17:18:00 +02:00
ShadowCommander adee8b16ab
Add pressure and temperature warning text to firelocks (#28341) 2024-06-01 17:17:54 +02:00
MilenVolf df162070ac
Localize emergency shuttle's direction for announcements (#28340)
Localize emergency shuttle direction
2024-06-01 17:17:48 +02:00
Repo ead8267de2
Fix wall vending machines spawning items in walls. (#28279)
* Find spawning of wall vending machines.

* Review fixes
2024-06-01 17:17:43 +02:00
Nemanja 49ae1f57ee
Small anomaly behavior fix (#28290)
* Small anomaly behavior fix

* well put together code
2024-06-01 17:17:36 +02:00
slarticodefast d25743c22f
Cargo bounty corrections (#28255)
cargo bounty corrections
2024-06-01 17:17:29 +02:00
lzk 6ae7ceb5a3
Add popup for owner when inserting item in hand (#28032) 2024-06-01 17:15:45 +02:00
Nemanja 38b4bbf97c
Fix under-selecting antags (#28327)
Fix under selecting antags
2024-06-01 17:14:58 +02:00
Nemanja 5b87c90511
Prevent stacking pipes (#28308)
* prevent stacking pipes

* access

* notafet review

* notafet review pt. 2

* not the actual fix
2024-06-01 17:14:50 +02:00
metalgearsloth b99a66afc1
Selectively revert PullController (#28126)
I am leaving the issues open and have updated #26547 with more info on what we should do long-term. This is just to bandaid the short-term complaining.
2024-06-01 17:13:38 +02:00
Nemanja 3d8706561d
fix borg ui mispredict opening (#28305)
move borg ui junk to shared
2024-06-01 17:13:35 +02:00
deltanedas 82b8d835b2
fix antag selection being evil (#28197)
* fix antag selection being evil

* fix test

* untroll the other tests

* remove role timer troll

* Allow tests to modify antag preferences

* Fix antag selection

* Misc test fixes

* Add AntagPreferenceTest

* Fix lazy mistakes

* Test cleanup

* Try stop players in lobbies from being assigned mid-round antags

* ranting

* I am going insane

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
Co-authored-by: ElectroJr <leonsfriedrich@gmail.com>
2024-06-01 17:13:27 +02:00
Nemanja 9a7f4416b2
actually fix magic mirrors (#28282) 2024-06-01 17:13:23 +02:00
Leon Friedrich cc29590cfa
Make NetworkConfigurator use BoundUserInterfaceCheckRangeEvent (#28293) 2024-06-01 17:13:20 +02:00
Leon Friedrich 386728db2f
Fix stripping not marking interactions as handled (#28292) 2024-06-01 17:13:16 +02:00
Ady4ik 78dbdfa00c
Move PendingZombieComponent to Shared (#28143)
* Move PendingZombieComponent to Shared

* network me boy

---------

Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
2024-06-01 17:00:22 +02:00
eoineoineoin 6eef3dcea3
Objects ordered through cargo system shouldn't start anchored (#28115)
* Order normal space heater instead of anchored variant

* Make sure ordered objects don't spawn anchored

* Order space heater flatpack instead of a regular space heater

* Remove obsolete TODO

* Remove unnecessary name

---------

Co-authored-by: Eoin Mcloughlin <helloworld@eoinrul.es>
2024-06-01 17:00:19 +02:00
Ed 5a9c7073c2
Fix candles (firestack fading) (#28139)
Update FlammableSystem.cs
2024-06-01 17:00:15 +02:00
MilenVolf c6b279ef80
Add direction relative to station for emergency shuttle's docking & nearby announcement (#28164)
* Use nav beacon location for emergency shuttle's docking announcement

Location of the shuttle relative to the nearest nav beacon in docking announcement message of the emergency shuttle

* Add directions relative to station
2024-06-01 17:00:13 +02:00
Repo c4b0fcbd5c
Fix gamerule display issues (#28178)
* A comprehensive rule list for joining admins and mid round command to get rule list added

* Fix up for when a rule is added vs started and some logging

* fix command help localization, fix admin flags and spam anouncement.

* Send admin message only to the joining player not all admins.

* Bit better formatting in chat box
2024-06-01 17:00:04 +02:00
deltanedas 1ecb083ffd
move nukie profile loading into its own rule (#28208)
* move profile loading out of nukeops rule

* make BaseNukeopsRule and use AntagLoadProfileRule

* untroll

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-06-01 17:00:00 +02:00
deltanedas 4240e5c70b
antag objective issuing refactor (#28216)
* add AntagObjectives from GenericAntag

* add AntagRandomObjectives that traitor and thief can use

* make ObjectivesSystem use initial character name which AntagSelection passes

* make thief and traitor use AntagRandomObjectives

* remove now unused locale

* make sleeper agents rule use baseTraitorRule

* restore dragon rule oop

* bandaid for genericantag

* real

* typo

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-06-01 16:59:16 +02:00
deltanedas ee90f7a0f4
fix id card console not updating records (#28237)
* fix id card console not updating records

* test

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-06-01 16:57:33 +02:00
nikthechampiongr a036d3a485
Fix firelock prediction issues with periodic pulses of closing lights (#28227)
* Fix firelock prediction issues with periodic pulses of closing lights

For some reason this function was setting a time for the next state
which was triggering the door system to try to close the firelock.
This does not happen serverside because the function only fires from an
event called clientside apparently.
It appears to be an attempt to stop firelocks from closing instantly
that did not function properly, and I cannot discern any other purpose.
As such I have removed it.

* Remove redundant serverside check

This became redundant with commit 439a87f2
2024-06-01 16:57:01 +02:00
Leon Friedrich 768f48bd4f
Improve InteractionSystem range & BUI checks (#27999)
* Improve InteractionSystem range & BUI checks

* Ghost fixes

* AAA

* Fix test

* fix nullable

* revert to broadcast event

* Fixes for eengine PR

* Ah buckle code

* )
2024-06-01 16:56:23 +02:00
Nemanja 9adf1ed402
Remove AlertType and AlertCategory (#27933) 2024-06-01 16:55:49 +02:00
nikthechampiongr 06b4df686b
Firelock improvements part 1 (#26582)
* Change prying system and pryunpoweredcomp to allow for custom time modifiers

This will be useful if I go the route of making firelocks pryable when
unpowered instead of just being able to open and close instantly when
unpowered.

* Make firelocks properly predicted

Shared system made. Since atmos checks can only be done on the server we
just have it set relevant bools on the component and then dirty it.
Ditched atmos checks on trying to open, they now only happen whenever
firelocks are updated.

* Make firelocks pryable without a crowbar

While this usually would only allow you to do this when a door is
unpowered, firelocks do not have the airlock component which actually
does that check. As such firelocks will always allow you to pry them
open/closed by hand.

* Clean up System. Change update interval to be based on ticks. Move as much as possible to shared

* Make firelocks unable to emergency close for 2 seconds after being pried open

* Clean up

* More cleanup

* Reorganize SharedFirelockSystem methods to match Initialize order

---------

Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
2024-06-01 16:55:26 +02:00
DrSmugleaf f580b4be64
Add defib event, add fields to be able to disable crit defib and do after movement (#28174)
* Add defib event, add fields to be able to disable crit defib and do after movement

* Fix check
2024-06-01 16:55:16 +02:00
Leon Friedrich 74308b008f
Use non-generic `TryComp()` for metadata & transform (#28133) 2024-06-01 16:53:51 +02:00
Tayrtahn 7ff91799cc
Fix non-ghosts and admins counting toward most followed (#28120)
* Fixed non-ghosts and admins counting toward most followed

* Redone to better leverage EntityQueryEnumerator

* Remember to test your code before you commit it, kids

* Review revisions

* Update Content.Shared/Follower/FollowerSystem.cs

Co-authored-by: ShadowCommander <shadowjjt@gmail.com>

* Update Content.Shared/Follower/FollowerSystem.cs

Co-authored-by: ShadowCommander <shadowjjt@gmail.com>

* Update Content.Shared/Follower/FollowerSystem.cs

* Clean up

---------

Co-authored-by: ShadowCommander <shadowjjt@gmail.com>
Co-authored-by: ShadowCommander <10494922+ShadowCommander@users.noreply.github.com>
2024-06-01 16:53:44 +02:00
Tayrtahn d92b6a08cb
Prevent ghosts from spawning on terminating maps/grids (#28099)
* Extra checks to prevent ghosts spawning on terminating maps/grids

* Add test for grid deletion
2024-06-01 16:53:42 +02:00
Tayrtahn 77abecef2a
Slightly emphasize popup when someone points at you (#28152)
Slightly emphasize when someone points at you
2024-06-01 16:53:39 +02:00
Flesh 09113824e9
Add plant metabolism effects to chemical guidebook (#28038)
* draft one of plant metabolism guidebook

* loc fix?

* add attributes loc

* fix loc syntax

* improved appearance

* last commit was undercooked, my bad

* last commit was still undercooked, my worse

* last commit was even still undercooked, my worst

* Addressed comments?

* Fix newlines

* Hopefully this works

* Cleanup, I think

* 2xs
2024-06-01 16:51:34 +02:00
Nemanja c88d5d53dd
Fix magic mirror (#28084)
* Fix magic mirror

* buff magic mirror
2024-06-01 16:51:30 +02:00
Leon Friedrich caa2f7e5ba
Modify battery assert to avoid floating point errors (#28007) 2024-06-01 16:51:13 +02:00
Tayrtahn e5bbb0a4bc
Random book story generator refactor (#28082)
* Randomized book overhaul

* Fix prototype names

* Improved setting paper content

* Praise Ratvar
2024-06-01 16:50:57 +02:00
Ed e0820b8b13
Nuke spaceshroom ore (#28110)
nuke spaceshroom ore
2024-06-01 16:50:55 +02:00
double_b 7c7872a89f
Resolves Bible summon message being sent to all users (#28104)
* Changed PopupEntity overload used to ensure message is only sent to user

* Updated uid for PopupEntity call

* Updating _popupSystem.PopupEntity call in AttemptSummon
2024-06-01 16:50:40 +02:00
no 34e8105f70
Add Syndicate/generic radio implants, remove Syndicate encryption key from uplink (#1262)
* Add radio implants

* Syndie radio implant: add to uplink, formatting pass

* Syndie radio implant: fix doc string

* Syndie radio implants: add inheritdoc to systems

* Syndie radio implants: Change wording on uplink

Signed-off-by: no <165581243+pissdemon@users.noreply.github.com>

* Syndicate radio implants: More wording changes

Signed-off-by: no <165581243+pissdemon@users.noreply.github.com>

* Syndicate radio implants: fix review code problems

* syndicate radio implants: remove OpenRadioImplantEvent event and reuse storageimplant stuff

* Syndicate radio implants: prevent implanting borgs with generic radio (syndicate radio is still possible)

* syndie radio implants. extremely graphic non-null matching action and establishment of extreme non-virtual privacy

---------

Signed-off-by: no <165581243+pissdemon@users.noreply.github.com>
2024-05-27 15:24:52 +00:00
deltanedas 5e86111d7d
add secwatch pda app for current sussy baka
* Crime Assist cleanup

* Add SecWatch cartridge to PDAs

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
Co-authored-by: Azzy <azzydev@icloud.com>
2024-05-23 14:58:06 +00:00
deltanedas d1014cdedd
early merge antag fix (#1238)
* early merge antag fix

* fix test

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-05-22 08:36:39 +02:00
Null 0976829e7f
Roboisseur no longer sends messages in the chat (#1222)
Webedit ops

Signed-off-by: Null <56081759+NullWanderer@users.noreply.github.com>
2024-05-18 23:15:46 +02:00
deltanedas 94d3fdafa2
paradox anomaly antag rework (#1206)
* move paradox code around and update it

* make MidRoundAntagRule just give spawn locations

* update the yaml

* give anom and listening post raffles

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
Co-authored-by: Null <56081759+NullWanderer@users.noreply.github.com>
2024-05-18 19:44:48 +00:00
Null 72853c1b09
Senior ID cards get a custom job name (#1218)
* Allow preset id's to have different job names

* Senior roles

* Sync with Station Records

* Change markers
2024-05-18 21:29:07 +02:00
null a37b4c3477
Fix build error 2024-05-18 14:12:42 +02:00
lzk 79d60ab6e0
Move replacement chance from ReplacementAccentComponent to ReplacementAccentPrototype (#28049)
Move replacement chance to ReplacementAccentPrototype
2024-05-18 14:04:28 +02:00
DrSmugleaf 2cef141f94
Add data field for id card microwave behaviour (#28087) 2024-05-18 14:04:27 +02:00
deltanedas fb4a534b97
fix ninja hacking not affecting sechud (#28021)
minor refactor and fix

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-05-18 14:01:33 +02:00
DrSmugleaf 85a0742a88
Move most rotting code to shared (#28050)
* Move most rotting code to shared

* Remove unused dependency
2024-05-18 14:00:20 +02:00
deltanedas efe79da550
biome flexibility changes (#28017)
make biome apply template on mapinit, add api for setting Enabled

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-05-18 14:00:10 +02:00
deltanedas 16bd7f2e8d
fire troll fix (#28034)
Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-05-18 13:59:35 +02:00
beck-thompson 99d69a89b1
Fix incorrect message displaying when trying to remove stuck item from someones hand. (#28024)
* Fix

* Fixed the other spot!
2024-05-18 13:59:34 +02:00
deltanedas 08f7ab64c5
fix fire spread round removal (#27986)
* fix a resolve debug assert

* rewrite fire spread

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-05-18 13:59:20 +02:00
Brandon Li 6a83e2bb1b
Reagent dispenser UI (Again) (#27958)
* reagent dispenser: fancy window

* reagent dispenser: dispense button grid

* reagent dispenser: rearrange containers & info

* reagent dispenser: remove `reagent-dispenser-window-container-label`

* reagent dispenser: add `Scrollcontainer` on right side

* reagent dispenser: get rid of pointless actions

* reagent dispenser: cleanup actions and `inventory` field on bound ui state

* reagent dispenser: cool reagent cards & finishing touches

* reagent dispenser: final cleanup and formatting

* reagent dispenser: `ButtonGrid` and `ReagentDispenserSetDispenseAmountMessage` refactor

* reagent dispenser: cleanup code & address minor concerns

* reagent dispenser: text in reagent cards no longer clips

* reagent dispenser: oh wait i forgot to change this and thats why the builds keep failing probably

* reagent dispenser mayybe this

* reagent dispenser: remove `using FastAccessors;`

* delete unused classes

* disable reagent button when container is empty

* Make things a bit bigger

* remove obsolete text color override
2024-05-18 13:59:16 +02:00
Leon Friedrich 8530bcf6e8
Change some `EntityQueryEnumerator` to `AllEntityQuery` (#27969) 2024-05-18 13:59:02 +02:00
metalgearsloth 93a6823bbb
Implement Equals for ApcBoundInterfaceState (#27965)
* Implement Equals for ApcBoundInterfaceState

Saves a lot on bandwidth. Also made it round to the nearest 5.

* Also this
2024-05-18 13:59:01 +02:00
Kara b93f956353
Resolve `'EntitySystem.Get<T>()' is obsolete` in content (#27936)
* PROJECT 0 WARNINGS: Resolve `'EntitySystem.Get<T>()' is obsolete` in content

* pass entman

* dog ass test

* webeditor
2024-05-18 13:58:55 +02:00
nikthechampiongr c8ded7032c
Record deletion (#27883)
* Allow for Station Records interface for aghosts to delete records

* Fix record consoles not working when there are more than 2 crew members.

HOW DID NOONE NOTICE THIS SOONER???

* Stop being unconventional
2024-05-18 13:58:44 +02:00
no 3e277a22d1
Prevent admin-frozen players from ghosting or suiciding, add "Freeze And Mute" verb (#27813)
* prevent admin-frozen players from ghosting or suiciding

* Add "Freeze and Mute" admin verb

* Allow "Freeze And Mute" admin verb when player is already frozen but not muted

* Remove redundant scream handler (scream action just emotes, duh)

* AdminFrozenSystem: clean imports

* Update Content.Server/Chat/Commands/SuicideCommand.cs

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>

* Update Ghost.cs

* retrigger ci (empty commit)

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
2024-05-18 13:58:36 +02:00
Kara c56db3b1a8
Resolve `'TransformComponent.MapPosition' is obsolete` in content (#27939)
* Resolve `'TransformComponent.MapPosition' is obsolete: 'Use TransformSystem.GetMapCoordinates'` in content

* build?
2024-05-18 13:58:34 +02:00
ShadowCommander d82acccaa8
Replace AttachToGridOrMap with DropNextTo (#27950) 2024-05-18 13:57:16 +02:00
Kara 74eef92443
Resolve all non-obsoleting warnings in content (#27934)
* Resolve all non-obsoleting warnings in content

* Update ClientGameTicker.cs

* Update SkeletonAccentSystem.cs

* Update BwoinkSystem.cs
2024-05-18 13:57:06 +02:00
Джексон Миссиссиппи e8dce2b0ed
Add an admin smite for making people slip really far (and localize the admin smites better) (#27246)
* Sliiiiiiiiiiiiiiiiiip

* what

* Localize!

* antiterminate
2024-05-18 13:57:03 +02:00
metalgearsloth 25ce6c531b
Lobby refactor + species loadouts support (#27576)
* Vox stuff

* Species loadouts and lobby refactor

The control flow for lobby is all over the shop so I pulled it all up from the individual controls so now they handle the bare minimum required and LobbyUIController handles the rest.

* a

* Bulk changes

* a

* weh

* Character import / export

* finalise

* woops this stuff too

* Also datafield exporting

* comments

* Review
2024-05-18 13:55:56 +02:00
keronshb 27be1ad8c9
Magic Refactor + Wizard Grimoire (#22568)
* Brings over changes from the original magic refactor PR

* Adds Master Spellbook, spellbook categories, WizCoin currency, and locale

* Wiz€oin™

* Adds currency whitelist to Spellbook preset, grants contained actions on action added.

* Adds grant contained action and remove provided action.

* adds a way for actions to be upgraded to the store

* Adds Fireball 3 and fixes action upgrade logic so that it checks if the action can level or if the action can upgrade separately

* Fixes upgrade logic in ActionUpgradeSystem to allow for level ups without an actual upgrade. Fixed action upgrade logic in store system as well

* Removes current action entity from the bought entities list and adds new or old action entity

* Removes Current Entity

* Removes old comments, fixes TransferAllActionsWithNewAttached

* Removes TODO

* Removes Product Action Upgrade Event

* reverts changes to immovablerodrule

* Removes stale event reference

* fixes mind action grant logic

* reverts shared gun system change to projectile anomaly system

* forgor to remove the using

* Reverts unintended changes to action container

* Adds refund button to the store

* Refreshes store back to origin.

* Refund with correct currency

* Init refund

* Check for terminating and update interface

* Disables refund button

* Removes preset allow refund

* dont refund if map changed

* adds refunds to stores

* Adds method to check for starting map

* comments, datafields, some requested changes

* turns event into ref event

* Adds datafields

* Switches to entity terminating event

* Changes store entity to be nullable and checks if store is terminating to remove reference.

* Tryadd instead of containskey

* Adds a refund disable method, disables refund on bought ent container changes if not an action

* Removes duplicate refundcomp

* Removes unintended merges

* Removed another unintended change from merge

* removes extra using statement

* readds using statement

* might as well just remove both usings since it won't leave the PR

* Fixes Action upgrades from stores

* Changes to non obsolete method uses

* Shares spawn code between instant and world

* Adds action entity to action event, adds beforecastspellevent, adds spell requirements to magic component

* puts prereq check in spell methods, sets up template code for before cast event

* checks for required wizard clothes

* Networks Magic Comp and Wizard Clothes Comp. Renames MagicSpawnData to MagicInstantSpawnData.

* Removes posdata from projectiles

* Speech > RequiresSpeech

* Fixes ActionOnInteract

* checks for muted

* popup for missing reqs

* Validate click loc for blink spell

* Checks if doors are in range and not obstructed before opening

* Check ents by map coords

* Adds speak event

* Comments spellbooks

* Removes comments

* Unobsoletes smite spell

* Invert if

* Requirements loc

* Fixes spell reqs

* Inverts an if

* Comment updates

* Starts doafter work

* Removes doafter references

* Balances fireball upgrades to be more reasonable

* Enables refund on master spellbooks

* Spells to do

* update spellbook doafter

* knock toggles bolts

* Touch Spell comments

* Comments for pending spells

* more comments

* adds spider polymorph to spellbook

* TODOs for spells

* reorganizes spellbook categories and adds wands

* fixes spacing and adds limited conditions

* commented owner only for future store PR

* reenables owner only for the grimoire

* fixes grimoire sprite

* Adds wizard rod polymorph

* summon ghosts event

* Moves rod form to offensive category

* Adds charge spell and loc for rod polymorph

* Oops forgor the actual chages

* Item Recall comment

* Fixes UI

* removes extra field for wizard rod

* Cleanup

* New Condition (INCOMPLETE)

* Fix linter

* Fix linter (for real)

* fixed some descriptions

* adds regions to magic

* Adds a non-refund wizard grimoire, fixes blink to deselect after teleporting, reduces force wall despawn time to 12 seconds

* removes limited upgrade condition

---------

Co-authored-by: AJCM <AJCM@tutanota.com>
2024-05-18 13:55:05 +02:00
DrSmugleaf af6a694481
Make projectiles not hit crit mobs unless clicked on (#27905) 2024-05-18 13:53:49 +02:00
icekot8 c5b3e2861a
revenant can no longer harvest souls while in solid objects (#27612)
meow
2024-05-18 13:53:04 +02:00
ShadowCommander 13fb095cae
Fix ghosts getting spawned in nullspace (#27617)
* Add tests for ghost spawn position

* Make ghosts spawn immediately

* Format mind system

* Move ghost spawning to GhostSystem

* Spawn ghost on grid or map

This fixes the ghosts being attached the parent entity instead of the grid.

* Move logging out of the ghost system

* Make round start observer spawn using GhostSystem

* Move GameTicker ghost spawning to GhostSystem

Moved the more robust character name selection code over.
Moved the TimeOfDeath code over.
Added canReturn logic.

* Add overrides and default for ghost spawn coordinates

* Add warning log to ghost spawn fail

* Clean up test

* Dont spawn ghost on map delete

* Minor changes to the role test

* Fix role test failing to spawn ghost

It was failing the map check due to using Nullspace

* Fix ghost tests when running in parallel

Not sure what happened, but it seems to be because they were running simultaneously and overwriting values.

* Clean up ghost tests

* Test that map deletion does not spawn ghosts

* Spawn ghost on the next available map

* Disallow spawning on deleted maps

* Fix map deletion ghost test

* Cleanup
2024-05-18 13:53:01 +02:00
Vasilis 411ffc9b9d
Do not wake up NPC if there is still a mind attached. (#27651)
* Do not wake up NPC if there is still a mind attached.

This became apparent with diona nymphs (?) and slime gyras (?). This caused players that disconnected while a nymph, gyras or other npc to resume their NPC behavior. Which I would call unwanted. This fixes that.

* Zombies become AI anyway

* Update Content.Server/NPC/Systems/NPCSystem.cs

---------

Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
2024-05-18 13:52:56 +02:00
DrSmugleaf c9e717ed48
Make FTL constants in ShuttleSystem into cvars (#27706)
* Make FTL constants in ShuttleSystem into cvars

* Fix tests
2024-05-18 13:52:25 +02:00
DrSmugleaf 8971937177
Add ActionPerformedEvent, ActionsSystem.SetIfBiggerCooldown, action id to action events and BackgroundOn field (#27682)
* Add ActionPerformedEvent and ActionsSystem.SetIfBiggerCooldown

* Add action id to action events and backgroundon field to action component
2024-05-18 13:52:01 +02:00
Ed c0d1c43003
New event: Approaching unknown shuttle (#24490)
* setup codebase

* Add first shuttle

* tak

* sync striker

* sync 2

* pipipi

* Preloaded roundstart shuttles!

* Make it abstract "PreloaderGrid" not "PreloaderShuttle"

* to do

* added china cuisin shuttle

* fixes

* add disaster evacpod

* remove enemy

* final shuttles

* weight 5 -> 10

* move data to component

* remove autotrailer touching

* doc, respath

* fix frozen positioning

* fixes + cvar

* finally

* fix evacpod

* remove blacklistrules

* remove `UnknownShuttleSpawnRule`, refactor `LoadMapRule` to support preloaded grids

* use tryload

* cleanup

* fixes

* use preloadedgrid for loneops

* weight unknown shuttles differently (preliminal)

* leftover

* cleanup and raffling

* partial review

* singleton gridpreloader no station coupling

* fix grid atmoses

* `roleLoadout` support for `LoadoutComponent`, fix missing gear

* weighting changes

* init logic fix

---------

Co-authored-by: Kara <lunarautomaton6@gmail.com>
2024-05-18 13:51:30 +02:00
Errant 6a1b7c8ee7
Space Ninjas auto-toggle internals after spawning (#25083)
* fix engine version

* actually fix engine version

* Automatically activated breathing masks

* weh

* who needed that component anyway

* check if internals are already running

* Update Content.Server/Atmos/Components/BreathToolComponent.cs

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>

* Update Content.Server/Body/Systems/InternalsSystem.cs

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>

* prediction

* record struct event

* remove delayed activation, instead ensure that masks spawn last

* leftover

* engine version

* re-implement

---------

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: metalgearsloth <comedian_vs_clown@hotmail.com>
2024-05-18 13:51:21 +02:00
Jajsha fdaba28158
Players can no longer see that emagged cyborgs' internals have been tampered with. (#27816)
* Add emag-detection funtionality to diag huds

* Add component to the omniHUD

* Fix namespace

* Adress discord review, just axe the message.
2024-05-18 13:48:50 +02:00
Brandon Li 1e60c8642b
Reagent dispenser UI (#27831)
* reagent dispenser: fancy window

* reagent dispenser: dispense button grid

* reagent dispenser: rearrange containers & info

* reagent dispenser: remove `reagent-dispenser-window-container-label`

* reagent dispenser: add `Scrollcontainer` on right side

* reagent dispenser: get rid of pointless actions

* reagent dispenser: cleanup actions and `inventory` field on bound ui state

* reagent dispenser: cool reagent cards & finishing touches

* reagent dispenser: final cleanup and formatting

* reagent dispenser: `ButtonGrid` and `ReagentDispenserSetDispenseAmountMessage` refactor

* reagent dispenser: cleanup code & address minor concerns

* reagent dispenser: text in reagent cards no longer clips

* reagent dispenser: oh wait i forgot to change this and thats why the builds keep failing probably

* reagent dispenser mayybe this

* reagent dispenser: remove `using FastAccessors;`
2024-05-18 13:48:42 +02:00
username fe7f506139
Traitor objective issuers (#27855)
* the thing

* another one

---------

Co-authored-by: whateverusername0 <whateveremail>
2024-05-18 13:47:19 +02:00
Tayrtahn db488fce74
Fix two issues with ReplacementAccentSystem (#27866) 2024-05-18 13:36:05 +02:00
DrSmugleaf 44eff7af7a
Move id and health examinable to shared (#27867)
* Move id and health examinable to shared

* Make GetInfo public
2024-05-18 13:36:03 +02:00
Mr. 27 a56b364c7e
Prevent non-inital infected from getting the succumb to zombie action (#27820)
* b

* Update ZombieRuleSystem.cs

* hi
2024-05-18 13:35:55 +02:00
deltanedas 6781d9e0a6
make fire not burn through hardsuits (#27161)
* add FireProtection system and event

* minor optimisation + make flammable use fire protection event

* add fire protection values to some things, nerf firesuit heat resistance

* bruh

* unrevert laser nerfs, make elite hardsuit fully fireproof

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-05-18 13:35:46 +02:00
Killerqu00 a9f81262d9
Revolutionaries can now cuff command instead of killing/exiling them (#27627)
* command can now be restrained for revs victory

* headrevs still must be killed
2024-05-18 13:34:17 +02:00
deltanedas 1fa0bad89f
malf killer 9000 (robotics console) (#24855)
* create devicenet frequencies

* create borg transponder and give it to all nt borgs

* add robotics console

* actually implement battery charge display + some fix

* tab

* real explosion

* little safer

* disable destroy button clientside too when on cooldown

* m

* how do i do this when i review things...

Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>

* webedit ops

Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>

* ui updates

* oracle java

* do a thing

* update ui when a borg times out

* maybe fix test

* add IsLocked to LockSystem

* make destroying gib the chassis again, so emagging isnt sus

* use locking

* require using alt click to unlock so normal click is open ui

* the

* use LogType.Action

* take this L

* pocket lint?

* sharer

* pro ops

* robor pushmarkup

* m

* update and make it not use prototype anymore

* frame0

* update yaml

* untroll

* bad

* h

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
Co-authored-by: metalgearsloth <31366439+metalgearsloth@users.noreply.github.com>
Co-authored-by: Nemanja <98561806+EmoGarbage404@users.noreply.github.com>
2024-05-18 13:34:13 +02:00
deltanedas 48afd84a12
ninja criminal records hacking (#24982)
* more humour

* spotted a troll

* add TryFindObjective to MindSystem

* replace copypaste bool conditions with CodeCondition

* use CodeConditionSystem in ninja + add handling for criminal hack

* add criminal records hacking

* update objectives

* :trollface:

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-05-18 13:34:11 +02:00
Tornado Tech 094ea59b95
Added new HTN operations and preconditions (#27486)
* Added new HTN operations & preconditions

* Ok I forgot about partial

* Namespace pierce the skies

* Some fixes, debug and new operators

* Bruh git eat my files
2024-05-18 13:32:55 +02:00
Pieter-Jan Briers fa2223ed8d
Fix preferences sent to client not being sanitized (#27789)
Fucking whoops

In #27742 I made it so sanitization of character profiles was moved to be *after* database load. Except that means I moved it to be after the copy of all character profiles got sent to the client.

Move the sending to *also* be in that second load stage, and rename it. Fixes the issue.
2024-05-18 13:31:44 +02:00
deltanedas cdb9723f26
make dragons breathe fire (#26746)
* add ActionGun system

* add RepeatingTrigger

* dragons breath projectile, repeatedly explodes

* give dragon fire breathing action, fireproof it

* oop

* oop 2

* prevent troll

* proper repeating thing

* pro

* webedit ops

* realops

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-05-18 13:31:40 +02:00
deltanedas 51d94f2022
make lube speed up lathes (#25515)
* add LatheGetSpeedEvent

* add LatheLube system

* make typical lathes accept lube

* spill

* :trollface:

* rework to generic ReagentSpeedSystem

* hyperlathe ops

---------

Co-authored-by: deltanedas <@deltanedas:kde.org>
2024-05-18 13:31:28 +02:00
Kara b0369388bd
Log event starts to admin alert chat (#27761) 2024-05-18 13:30:31 +02:00
metalgearsloth b59ffd6673
Revert "Fix turned off thrusters consume power" (#27755)
Revert "Fix turned off thrusters consume power (#26690)"

This reverts commit 70959e7bb081c1a6e1457a8f8ee7732da91bb270.
2024-05-18 13:30:26 +02:00
ShadowCommander 2d48912bc9
Make arguments and parameters wrap to one variable per line (#27766) 2024-05-18 13:30:18 +02:00
Pieter-Jan Briers 8689c7f90d
Fix preference loading bugs (#27742)
First bug: if an error occured during pref loading code, it would fail. If the person then readied up, it would likely cause the round to fail to start.

Why could they ready up? The code only checks that the prefs finished loading, not that they finished loading *successfully*. Whoops.

Anyways, now people get kicked if their prefs fail to load. And I improved the error handling.

Second bug: if a user disconnected while their prefs were loading, it would cause an exception. This exception would go unobserved on lobby servers or raise through gameticker on non-lobby servers.

This happened even on a live server once and then triggered the first bug, but idk how.

Fixed this by properly plumbing through cancellation into the preferences loading code. The stuff is now cancelled properly.

Third bug: if somebody has a loadout item with a playtime requirement active, load-time sanitization of player prefs could run into a race condition because the sanitization can happen *before* play time was loaded.

Fixed by moving pref sanitizations to a later stage in the load process.
2024-05-18 13:30:09 +02:00
null d48b13ce64
Merge remote-tracking branch 'refs/remotes/upstream/master' into 2024/05/18-merge-master 2024-05-18 13:29:48 +02:00
Ed 0edbdd1f80
Night on Europa (#27731)
night
2024-05-18 13:26:53 +02:00
Nemanja 76695a70dd
Scattershot antag fixes (#27429)
* scattershot antag fixes

* this too?

* dawg fuck this code

* ok so we kinda need this?
2024-05-15 19:57:58 +02:00
Mr. 27 c4bbb2ae26
Change return to continue in gamerulesystem (#27656)
Update GameRuleSystem.cs
2024-05-15 19:57:51 +02:00
Mr. 27 85f50943eb
Fix some gamerules' round summary not working (#27654)
Update GameRuleSystem.cs
2024-05-15 19:57:37 +02:00
Mr. 27 d88d210c0b
Add syndicate sleeper agents random event (#27501)
* Intercept rule (#10)

* add

* b

* add this back lol

* fix test fails (alert levels dont have prototypes)

* tweaks
2024-05-15 19:57:27 +02:00
Ciac32 5150178041
Fix antag verb incorrectly giving role to admin player instead of target (#27584)
Fix antag verb giving role to admin player instead of target
2024-05-15 19:57:19 +02:00
Łukasz Mędrek e526739787
fix: localisation keys in random content books (#27390)
Fixes #27327
2024-05-15 19:56:48 +02:00
Nemanja c6d1f12be8
fix antag bugs (#27319)
* fix antag bugs

* Update NukeopsRuleComponent.cs
2024-05-15 19:56:34 +02:00
null 20fbb117a7
Auto namespace cleanup for Delta/Nyano gamerules 2024-05-15 19:56:18 +02:00
Nemanja 3055d7bac5
Mega Antag Refactor (#25786)
* Mega Antag Refactor

* last minute delta save

* more workshopping

* more shit

* ok tested this for once

* okkkkk sure

* generic delays for starting rules

* well darn

* nukies partially

* ouagh

* ballin' faded and smonkin wed

* obliterated the diff

* Spread my arms and soak up congratulations

* I've got plenty of love, but nothing to show for it

* but there’s too much sunlight
Shining on my laptop monitor, so I
Can’t see anything with any amount of clarity

* ok this junk

* OOK!

* fubar

* most of sloth's review

* oh boy

* eek

* hell yea!

* ASDFJASDJFvsakcvjkzjnhhhyh
2024-05-15 19:48:32 +02:00
Null f9ec70d258
Merge pull request #1122 from DeltaV-Station/2024/04/21-loadouts
Loadouts
2024-05-15 14:48:11 +02:00
deltanedas 9291c35364
shipyard rewrite/port (#1171)
* add shipyard code

* add shipyard preferred dock

* shipyard locale

* add the computer itself

* add all the pre rebase shuttles

* name the shuttle

* tweak all shuttle maps + fix test

* add some categories for future use

* rename nanotrasen to civilian

* update for new ui system and move remaining yaml into deltav folder

* good

* write tests

* wow

* helix price hike

* fix dirty dispose

* use deltav cvar file

* s

Signed-off-by: deltanedas <39013340+deltanedas@users.noreply.github.com>

---------

Signed-off-by: deltanedas <39013340+deltanedas@users.noreply.github.com>
Co-authored-by: deltanedas <@deltanedas:kde.org>
Co-authored-by: Null <56081759+NullWanderer@users.noreply.github.com>
2024-05-15 12:18:55 +00:00
Null f168cde164
Merge branch 'master' into 2024/04/21-loadouts 2024-05-15 13:38:01 +02:00
Mnemotechnican 12e2826db1
Paper signatures (#1172)
* Signatures!

* Fix typo

* Suggestions implemented
2024-05-14 19:49:58 +00:00
null 8db7894d51
Merge remote-tracking branch 'refs/remotes/upstream/master' into 2024/04/21-loadouts 2024-05-07 22:52:49 +02:00
null a2ac3f6bac
Merge remote-tracking branch 'refs/remotes/upstream/master' into 2024/05/02-Merge-master
# Conflicts:
#	Content.Server/Nyanotrasen/Carrying/CarryingSystem.cs
#	Content.Server/Pinpointer/NavMapSystem.cs
#	Content.Server/Power/EntitySystems/PowerMonitoringConsoleSystem.cs
#	Content.Shared/Tag/TagSystem.cs
#	Resources/Prototypes/Entities/Clothing/Uniforms/specific.yml
2024-05-07 04:53:36 +02:00
no 217e0b8d1c
Add ghost role raffles (#26629)
* Add ghost role raffles

* GRR: Fix dialogue sizing, fix merge

* GRR: Add raffle deciders (winner picker)

* GRR: Make settings prototype based with option to override

* GRR: Use Raffles folder and namespace

* GRR: DataFieldify and TimeSpanify

* GRR: Don't actually DataFieldify HashSet<ICommonSession>s

* GRR: add GetGhostRoleCount() + docs

* update engine on branch

* Ghost role raffles: docs, fix window size, cleanup, etc

* GRR: Admin UI

* GRR: Admin UI: Display initial/max/ext of selected raffle settings proto

* GRR: Make a ton of roles raffled
2024-05-07 04:43:28 +02:00
Jezithyr c8c478bd3e
Moved Serverside solution container code to shared (yes that includes ensureSolution!) (#27478)
* Added warning to tryGetSolution, moved SolutionContainer code to shared
- Added an optional warning (false by default) to print an error if a solution is missing when using tryGetSolution methods
- Moved ensuring solution containers to shared, left the old method stubs for compatability and marked them as obsolete.

* Update SharedSolutionContainerSystem.cs

* Update SharedSolutionContainerSystem.cs

* Update SolutionContainerSystem.cs

* Update SharedSolutionContainerSystem.cs

* Fixing ensuring chem solutions always returning false on client
- ensuring chem solutions will only return false on the client if it is waiting for a server solutionEntity to be synced

* Added concentration helpers

* fix whitespace
2024-05-07 04:40:39 +02:00
Kara 1680be6f0d
Fix `TryFindRandomTile` grid weighting (#27724) 2024-05-07 04:39:58 +02:00